Commit Graph

643558 Commits

Author SHA1 Message Date
Edwin Gao
d5df057c37 Bug 1538359, 1538331, 1538360 - disable mochitest-media tests that fail intermittently or permanently on windows10-aarch64 r=jmaher
Disabled the following for windows10-aarch64:
- test_getUserMedia_audioCapture
- test_AudioChange_mp4.html
- test_bug1255618.html
- test_singleSourceDest
- test_mediaElementAudioSourceNodeFidelity
- test_maxChannelCount
- test_abort
- test_audio_capture_error
- test_call_start_from_end_handler
- test_recognition_service_error
- test_success_without_recognition_service
- test_ExperimentalAsync
- test_peerConnection_restartIceNoBundle.html

All of these tests tend to fail on the first run of the push, then pass on the retry run.

Differential Revision: https://phabricator.services.mozilla.com/D24569

--HG--
extra : moz-landing-system : lando
2019-03-23 09:51:09 +00:00
Edwin Gao
1584ba74a9 Bug 1536906, 1536909, 1536917, 1536916, 1536919, 1536922, 1536925, 1536931, 1538283, 1538303 - disable or change expected outcome of web-platform-tests that are causing problems on windows10-aarch64 r=jmaher,gbrown
Disable or change the expected outcome on a variety of `wpt` tests:
- /beacon/beacon-redirect.window.html
- encrypted-media-report-only.https.html
- RTCDTMFSender-ontonechange.https.html
- RTCDataChannel-send.html
- RTCPeerConnection-getStats.https.html
- RTCPeerConnection-remote-track-mute.https.html
- RTCPeerConnection-setRemoteDescription-tracks.https.html
- RTCRtpTransceiver.https.html
- RTCPeerConnection-iceConnectionState.https.html
- testing/web-platform/meta/html/semantics/embedded-content/media-elements/track/track-element/
- signed-exchange/reporting/sxg-reporting

Differential Revision: https://phabricator.services.mozilla.com/D24540

--HG--
extra : moz-landing-system : lando
2019-03-23 09:49:07 +00:00
Csoregi Natalia
f6b80050f4 Backed out 2 changesets (bug 1147563) for permafails on test_basic_form_autocomplete.html.
Backed out changeset 5e0ac9f08356 (bug 1147563)
Backed out changeset b2f2db06d094 (bug 1147563)
2019-03-24 02:37:46 +02:00
Dale Harvey
dcb0f70ac2 Bug 1534219 - Only clear globally blocked permission on navigation. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23844

--HG--
extra : moz-landing-system : lando
2019-03-22 10:57:16 +00:00
Kartikaya Gupta
6b4891ea03 Bug 1538538 - Minor tweak for consistency. r=dthayer
This has no functional effect but makes it consistent with other similar
sites.

Depends on D24650

Differential Revision: https://phabricator.services.mozilla.com/D24651

--HG--
extra : moz-landing-system : lando
2019-03-24 20:52:46 +00:00
Kartikaya Gupta
be36538530 Bug 1538538 - Guard against null pointer dereference. r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D24650

--HG--
extra : moz-landing-system : lando
2019-03-24 20:47:31 +00:00
sakshaat
d781937a67 Bug 1517483 - Get rid of nsIScriptSecurityManager::IsSystemPrincipal r=bzbarsky
Replaced instances of callers in both C++ and JS files to query the state from the principal directly.

Differential Revision: https://phabricator.services.mozilla.com/D22532

--HG--
extra : moz-landing-system : lando
2019-03-24 20:36:25 +00:00
Ian Moody
3e2a03dd32 Bug 1536659 - docshell/ manual ESLint no-throw-literal fixes. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D24368

--HG--
extra : moz-landing-system : lando
2019-03-21 22:40:36 +00:00
Ian Moody
b6cbc669dc Bug 1536659 - docshell/ automated ESLint no-throw-literal fixes. r=nika
Result of running:
$ mach eslint -funix docshell/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24367

--HG--
extra : moz-landing-system : lando
2019-03-21 16:53:45 +00:00
Randall Barker
4b64fa649d Bug 1500719 - Ensure toolbar is hidden when going fullscreen r=botond
Differential Revision: https://phabricator.services.mozilla.com/D24348

--HG--
extra : moz-landing-system : lando
2019-03-21 23:39:59 +00:00
Randall Barker
c98140dbeb Bug 1537964 - Call bindService() with BIND_IMPORTANT r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D24418

--HG--
extra : moz-landing-system : lando
2019-03-25 14:29:54 +00:00
Alex Chronopoulos
22dbeb3470 Bug 1538474 - Enable dav1d in RDD process. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D24726

--HG--
extra : moz-landing-system : lando
2019-03-25 16:41:48 +00:00
Michael Ratcliffe
639bed7bb2 Bug 1509620 - Computed style inspector CSS cascade calculation is wrong r=ladybenko
### Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1bad5e5282812225da95c0ea9e2ef173640b5da

### Summary

!!Comparing numerous complex websites such as github, facebook, cnn etc. the cascade now matchers that of Chrome so we are in a much better place.!!

According to https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading we should now be doing this (descending order):

  - Transition declarations
  - User-Agent & !important
  - User & !important
  - Author & !important
  - CSS Animations, @keyframes
  - Author, normal weight
  - User, normal weight
  - User-Agent, normal weight
  - specificity
  - Sheet Index
  - Rule Line
  - Rule Column

We are only dealing with CSS selectors here so we can safely drop Transition declarations and CSS Animations because their presence here is irrelevant when it comes to the CSS cascade information we display in the computed view.

This leaves us with:

  - User-Agent & !important
  - User & !important
  - Author & !important
  - Author, normal weight
  - User, normal weight
  - User-Agent, normal weight
  - specificity
  - Sheet Index
  - Rule Line
  - Rule Column

### Changes

- References to content stylesheets have been changed to author stylesheet to closely match the technical terms author, user and agent stylesheets.
- Simplified and modernized a bunch of for loops to make the code easier to understand.
- Previous to these changes all matching parent rules were classed as equal e.g. color on the body tag was equal to color on a node's immediate container. We now use the `distance` variable to tell how close a rule is to the current node. This is the highest qualifier in our cascade calculation.
- The `_agentSheet`, `_authorSheet` and `_userSheet` properties are now used to obtain a sheets origin.
- `elementStyle` was renamed to `inlineStyle` in order to correctly identify the rule's origin.
- We used to sort the matchedSelectors to move rules with `STATUS.MATCHED` above `STATUS.PARENT_MATCH` but this is unnecessary now that we have the `distance` property so we no longer do this.
- The `compareTo()` method has been updated to match https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading. It has also been simplified and made far less prone to error.

Differential Revision: https://phabricator.services.mozilla.com/D23711

--HG--
extra : moz-landing-system : lando
2019-03-25 16:32:19 +00:00
Nicolas B. Pierron
59aaa3ef97 Bug 1532599 - Branch Pruning: Flag all Phi loops as used. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D23331

--HG--
extra : moz-landing-system : lando
2019-03-21 19:38:09 +00:00
Luke Wagner
4f1f0dbca7 Bug 1536905 - Baldr: do instantiation in a separate task from the getting of imports (r=lth)
Having this OffThreadPromiseTask in place may also be useful one day if we want
to do any non-trivial instantiation-time codegen (say of Web IDL Bindings stubs...).

Differential Revision: https://phabricator.services.mozilla.com/D24243

--HG--
extra : rebase_source : 7a1dc29de10004e1d6c1f82ee48da3eb0321eb5f
2019-03-20 13:45:04 -05:00
Luke Wagner
32ae9f2564 Bug 1536905 - Baldr: factor out ImportValues struct (r=lth)
This patch is also pure refactoring, replacing the N Rooted<GCVector>s with
one ImportValues struct that can be Rooted once and then passed around. This
reduces existing duplication and also simplifies the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D24242

--HG--
extra : rebase_source : bd5397286ee0981486ffffdd4724c41811e3479a
2019-03-20 13:45:00 -05:00
Luke Wagner
540f42b70f Bug 1536905 - Baldr: split Resolve() into ResolveCompile() and AsyncInstance() (r=lth)
This patch doesn't change behavior; it just splits out the compile and
instantiate paths so that the latter can be updated in a later patch.
This splitting also slightly simplifies the code. The bits of duplication
introduced here are refactored in the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D24241

--HG--
extra : rebase_source : b3eab314f7ba2018c46db657da897b080a1e5633
2019-03-20 13:44:56 -05:00
arthur.iakab
1ab45e3251 Merge mozilla-central to mozilla-inbound 2019-03-25 17:57:57 +02:00
Eugen Sawin
c8131a108b Bug 1530789 - [3.0] Update API changelog. r=agi
Differential Revision: https://phabricator.services.mozilla.com/D24715
2019-03-25 16:53:12 +01:00
Eugen Sawin
9e20531da6 Bug 1530789 - [2.0] Initialize the SafeBrowsing module only in the parent process. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D21422
2019-03-25 16:53:12 +01:00
Eugen Sawin
3c7d2391d5 Bug 1530789 - [1.2] Extend Content Blocking API: cryptomining protection. r=geckoview-reviewers,dimi,snorp,Ehsan
Tags: #secure-revision

Differential Revision: https://phabricator.services.mozilla.com/D21410
2019-03-25 16:53:11 +01:00
akshitha
3f1d5459d1 Bug 1511416 -Screen sharing preview pops up in Camera permission prompt . r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D21976

--HG--
extra : moz-landing-system : lando
2019-03-18 12:12:29 +00:00
Eitan Isaacson
0bcec64436 Bug 1538021 - Use owner of WindowEventDispatcher as window for messaging. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D24442

--HG--
extra : moz-landing-system : lando
2019-03-23 21:22:02 +00:00
Botond Ballo
9a387fad8c Bug 1531535 - Expose the ability to do a visual smooth scroll in nsIDOMWindowUtils. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D24555

--HG--
extra : moz-landing-system : lando
2019-03-23 20:23:54 +00:00
Botond Ballo
c0526d30f3 Bug 1531535 - Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D24554

--HG--
extra : moz-landing-system : lando
2019-03-23 20:23:44 +00:00
Botond Ballo
e6c2c99584 Bug 1531535 - Add visual smooth scroll support to nsIPresShell. r=kats
This patch renames nsIPresShell::SetPendingVisualScrollUpdate() to
ScrollToVisual(), and adds an instant vs. smooth option.

SetPendingVisualScrollUpdate() still exists, as a helper for the instant case.

Differential Revision: https://phabricator.services.mozilla.com/D24553

--HG--
extra : moz-landing-system : lando
2019-03-23 20:23:35 +00:00
Botond Ballo
902b978f7f Bug 1531535 - Extract an ApzSmoothScrollTo() helper function. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D24552

--HG--
extra : moz-landing-system : lando
2019-03-23 20:23:20 +00:00
Sylvestre Ledru
289f40d6de Bug 1538199 - Remove an useless declaration in TRR.cpp r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D24506

--HG--
extra : moz-landing-system : lando
2019-03-23 18:24:04 +00:00
Philipp Kewisch
52aa5b978e Bug 1507709 - Move WebExtensions geckoProfiler API to toolkit. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D12100

--HG--
rename : browser/components/extensions/ProfilerGetSymbols-worker.js => toolkit/components/extensions/ProfilerGetSymbols-worker.js
rename : browser/components/extensions/ProfilerGetSymbols.jsm => toolkit/components/extensions/ProfilerGetSymbols.jsm
rename : browser/components/extensions/parent/ext-geckoProfiler.js => toolkit/components/extensions/parent/ext-geckoProfiler.js
rename : browser/components/extensions/profiler_get_symbols.js => toolkit/components/extensions/profiler_get_symbols.js
rename : browser/components/extensions/schemas/geckoProfiler.json => toolkit/components/extensions/schemas/geckoProfiler.json
rename : browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js => toolkit/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js
rename : browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_schema.js => toolkit/components/extensions/test/xpcshell/test_ext_geckoProfiler_schema.js
extra : moz-landing-system : lando
2019-03-22 13:18:01 +00:00
David Major
ef4fa82ab2 Bug 1535441 - Update win64 clang-cl to 8.0.0final r=firefox-build-system-reviewers,chmanchester
This gets us back to using an official release.

Differential Revision: https://phabricator.services.mozilla.com/D24069

--HG--
extra : moz-landing-system : lando
2019-03-22 01:40:14 +00:00
Rob Wood
17dec601e9 Bug 1533423 - Raptor cold page-load support for Firefox android geckoview; r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D24464

--HG--
extra : moz-landing-system : lando
2019-03-22 15:27:27 +00:00
Helena Moreno
0274f5667c Bug 1538153 - Fix RTL alignment in RequestList headers and align Storage table headers with Netmonitor r=fvsch
Differential Revision: https://phabricator.services.mozilla.com/D24508

--HG--
extra : moz-landing-system : lando
2019-03-22 18:55:02 +00:00
Syeda Asra Arshia Qadri
1c3bc2c0b5 Bug 1535278: Cert error pages in iframes should not say 'Warning: Potential Security Risk Ahead' r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23792

--HG--
extra : moz-landing-system : lando
2019-03-22 21:09:10 +00:00
shindli
3234d0805e Backed out 2 changesets (bug 1530789) for linting failures on Android
Backed out changeset 2038ef43f89a (bug 1530789)
Backed out changeset 3f03780957a4 (bug 1530789)
2019-03-23 12:36:33 +02:00
shindli
87e963c030 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-03-23 11:50:37 +02:00
shindli
b3ac60ff06 Merge inbound to mozilla-central. a=merge 2019-03-23 11:47:34 +02:00
Mike Hommey
851ab5ec78 Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D24449
2019-03-23 09:29:25 +09:00
Mike Hommey
8d38f2020f Bug 1527463 - Apply same changes as win64-aarch64 nightlies to the shippable builds. r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D24573
2019-03-23 09:29:25 +09:00
Mike Hommey
d77900a882 Bug 1527463 - Enable EME on win64-aarch64 nightlies. r=tomprince
Bug 1534522 added win64-aarch64-eme/opt builds, which are artifact builds
that glue together a win64-aarch64/opt build and a win32/opt build.

This enables EME on the corresponding nightlies in a slightly different
way:
- this adds a no-eme build that corresponds to win64-aarch64/opt.
- this turns the existing nightly into an artifact build that glues
  together that no-eme build and the win32 nightly.

The no-eme build cannot have the nightly attribute set, first because
the beetmover transform fails in that case, and because that would imply
shipping those builds, but they're not meant to be shipped this way.

It also has run-on-projects set to an empty list so that it doesn't
appear by default in `mach try fuzzy`, while still being triggered when
needed due to being a dependency of the nightly build.

It is preferable to keep the win64-aarch64{,-eme}/opt builds untouched
to make things easier for try (the win64-aarch64 ones being the main
ones to try; also, the -eme builds currently fail with --artifacts).

Ideally, like in bug 1534522, we'd add a diffoscope build to ensure
the variations between the nightly and its base no-eme build are within
control, but currently, that would trigger nightlies on every push,
which is not desirable. Ideally, they'd trigger whenever both their
dependencies are in the target task graph. We leave that to a followup.

Differential Revision: https://phabricator.services.mozilla.com/D23640
2019-03-23 09:29:24 +09:00
Mike Hommey
27c0bbcc88 Bug 1527463 - Get full artifact build symbols for aarch64 EME builds. r=mshal
We need to have full symbols uploaded for the upcoming EME-enabled
win64-aarch64 nightlies, and the tasks to do that are derived from the
nightly itself, which is going to be an artifact build. Bug 1527463 took
care of adding the option to enable that, and we turn it on for
EME-enabled builds.

MOZ_ARTIFACT_TASK_WIN32_OPT is not exactly the right thing, but we're
already using it to enable EME in
browser/config/mozconfigs/win64-aarch64/common-opt and is only set on
those builds.

Differential Revision: https://phabricator.services.mozilla.com/D23639
2019-03-23 09:29:24 +09:00
Marco Bonardo
5306fabe9c Bug 1537640 - Properly autofill partial IPs in the address bar. r=adw
Trying to autofill as urls breaks our assumptions.

Differential Revision: https://phabricator.services.mozilla.com/D24572

--HG--
extra : moz-landing-system : lando
2019-03-23 00:12:21 +00:00
Tom Tung
88e2f17179 Bug 1423917 - P11 - Make the deprecated client check only enable after upgrading to the newest version; r=asuth
The previous patches didn't take care of the case there might have an asmjs
folder in the older version. To fix that, this patch makes Client allow to have
asmjs folders in the older version by requesting the callee of TypeFromText()
for passing the current storage version. If the version is lower than the
deprecate version, then the assertion won't be enabled.
The test verfies the fix by adding the older profile an asmjs folder.

Differential Revision: https://phabricator.services.mozilla.com/D24542

--HG--
extra : moz-landing-system : lando
2019-03-23 07:56:02 +00:00
Jeff Walden
84b07b0389 Bug 1538098 - Backed out changeset 0a0194cd76a7 for some in-the-field bustage that isn't immediately diagnosable and fixable, before the wekeend. r=crashes
--HG--
extra : amend_source : ef5e1c14b897af80f410365d5afd99ce5dc96ab2
2019-03-22 13:48:06 -07:00
Brian Hackett
1bc179f724 Bug 1536618 Part 2 - Tolerate sources from any debugger in getOrCreateSourceActor, r=loganfsmyth.
--HG--
extra : rebase_source : cc2a3155162c4bdc87fcbb91b3bc6bcedf38bd46
2019-03-22 12:08:19 -06:00
Brian Hackett
a4f96c5b36 Bug 1536618 Part 1 - Add Debugger.adoptSource(), r=jorendorff.
--HG--
extra : rebase_source : 4d25571e4af5289f820887ec022a5ccee4f914e5
2019-03-22 12:08:05 -06:00
violet
44ea792130 Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv
CreateMutableFile() doesn't allow empty name, we should check it before
further processing to avoid assertion failure.

Differential Revision: https://phabricator.services.mozilla.com/D23999

--HG--
extra : moz-landing-system : lando
2019-03-22 14:01:31 +00:00
Ting-Yu Lin
0e0ec3037e Bug 1534146 - Do not call NS_RemoveSubsumedHints if the frame is a column-span. r=emilio
We avoid removing subsumed hints for out-of-flow and column-span frames
in RestyleManager::ProcessPostTraversal(). We should do something
similar here.

Differential Revision: https://phabricator.services.mozilla.com/D24578

--HG--
extra : moz-landing-system : lando
2019-03-22 23:36:59 +00:00
Honza Bambas
3db65d831e Bug 1536387 - Part 2: enhance the range for allowed http cache storage key tag character values, r=michal
Differential Revision: https://phabricator.services.mozilla.com/D24342

--HG--
extra : moz-landing-system : lando
2019-03-22 23:22:37 +00:00
Noor Afshan Fathima
5b8f768977 Bug 1537535 - Changed the string replace method with trim() method. r=johannh
Summary:
Changed the string replace method with trim() method

Issue fixed

Reviewers: johannh

Reviewed By: johannh

Bug #: 1537535

Differential Revision: https://phabricator.services.mozilla.com/D24344

--HG--
extra : rebase_source : 10ed7e9dddb9b12bde40fcd2c470d2e237c1b2d1
extra : amend_source : 03939cad17159874b150695677dbf9f8b1ac5d65
2019-03-23 04:32:17 +02:00
Cosmin Sabou
520c7a9423 Backed out 2 changesets (bug 1535246) for devtools failures on devtools/client/debugger/new/test/mochitest/browser_dbg-html-breakpoints.js. CLOSED TREE
Backed out changeset 5860aac31563 (bug 1535246)
Backed out changeset 5929d34ee923 (bug 1535246)

--HG--
extra : rebase_source : 3aac58ce35404488259bd778b4a9d78bca706ae8
2019-03-23 03:28:05 +02:00