Commit Graph

701839 Commits

Author SHA1 Message Date
Makoto Kato
ff4dcdc969 Bug 1629730 - Remove unnecessary AKEYCODE defines from GeckoEditableSupport. r=geckoview-reviewers,agi
Old NDK requires AKEYCODE defines for newer API version, but it is unnecessary
to define it when using NDK r20.

Differential Revision: https://phabricator.services.mozilla.com/D70786

--HG--
extra : moz-landing-system : lando
2020-04-15 21:25:46 +00:00
Brindusan Cristian
094e7f1fa3 Backed out 2 changesets (bug 1628630) for build bustages at SdpAttribute.h. CLOSED TREE
Backed out changeset 5c05d978aa32 (bug 1628630)
Backed out changeset bbd66b8940bb (bug 1628630)
2020-04-16 09:01:26 +03:00
Nicolas Chevobbe
0aaf3525b8 Bug 1630221 - Fix netmonitor toggle input checked styling. r=Honza.
The toggle style was overridden in netmonitor for
no obvious reason, as the base styles take care of
everything we need.

Differential Revision: https://phabricator.services.mozilla.com/D71028

--HG--
extra : moz-landing-system : lando
2020-04-16 05:20:20 +00:00
Nico Grunbaum
763dd6c1c0 Bug 1628630 - Add Support for RTX in WebRTC SDP CAPI;r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D70330

--HG--
extra : moz-landing-system : lando
2020-04-16 05:36:10 +00:00
Nico Grunbaum
53809171df Bug 1628630 - update WEBRTC-SDP to 0.3.5;r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D70339

--HG--
extra : moz-landing-system : lando
2020-04-16 05:35:58 +00:00
Masayuki Nakano
4cc133b568 Bug 1627175 - part 2: Move EditorBase::IsModifiableNode(), EditorBase::IsEditable(), EditorBase::IsTextElementOrText() and EditorBase::IsPaddingBRElementForEmptyEditor() to EditorUtils r=m_kato
Due to the include hell, `EditorBase.h` cannot include `EditorUtils.h`.
Therefore we need these 3 methods once.  Additionally, `IsModifiableNode()`
is really odd method and looks like that it's used for the following 2 purposes:
1. Simply can be editable.
2. Can be removed from parent.

For the former case, we should sort out it with
`EditorUtils::IsEditableContent()`, but for now, this patch moves it to
`HTMLEditUtils::IsSimplyEditable()`.  On the other hand, for the latter case,
we obviously has a bug.  Therefore, this patch creates
`HTMLEditUtils::IsRemovableFromParentNode()` and make it check whether the
removing node is also editable.

Unfortunately, `EditorUtils::IsEditableContent()` needs to take editor type.
But it's most callers are in `HTMLEditor` and most of remains are in
common methods of `EditorBase`.  I guess we could remove this ugly argument
in the future.

Depends on D70874

Differential Revision: https://phabricator.services.mozilla.com/D70875

--HG--
extra : moz-landing-system : lando
2020-04-15 15:27:38 +00:00
Jan de Mooij
72d50388f6 Bug 1629791 part 3 - Define CacheIR ops in a YAML file and use that to generate a header file. r=iain
For now this generates just CACHE_IR_OPS and CACHE_IR_SHARED_OPS in CacheIROpsGenerated.h
but the plan is to use this to generate parts of the IR writer and compiler/transpiler
interface. The spewer could also potentially be improved now that each operand has a name
and more precise type.

Generating the IR writer will likely happen incrementally so that will give us
another chance to double check the precise types match what's in the YAML file.

Differential Revision: https://phabricator.services.mozilla.com/D70995

--HG--
extra : moz-landing-system : lando
2020-04-16 05:21:38 +00:00
Jan de Mooij
aa4f4f7fe1 Bug 1629791 part 2 - Remove unnecessary condition operand from GuardSpecificInt32Immediate. r=iain
Depends on D70993

Differential Revision: https://phabricator.services.mozilla.com/D70994

--HG--
extra : moz-landing-system : lando
2020-04-15 14:06:22 +00:00
Jan de Mooij
c60dee00d5 Bug 1629791 part 1 - Rename MOpcodes.h to MOpcodesGenerated.h and LOpcodes to LOpcodesGenerated.h. r=iain
Most other generated SpiderMonkey files have the 'Generated' suffix so let's
follow that convention.

Differential Revision: https://phabricator.services.mozilla.com/D70993

--HG--
extra : moz-landing-system : lando
2020-04-15 14:06:21 +00:00
Bob Clary
6caaf2e39b Bug 1630426 - mach should log to stderr if not logging to a file, r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D71107

--HG--
extra : moz-landing-system : lando
2020-04-15 22:33:43 +00:00
Karl Tomlinson
ed805470e3 Bug 1630149 Document AudioWorklet test failures r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D70970

--HG--
extra : moz-landing-system : lando
2020-04-15 15:58:35 +00:00
Masayuki Nakano
7ae8033ee1 Bug 1627175 - part 1: Move HTMLEditor::IsBlockNode() into HTMLEditUtils r=m_kato
`HTMLEditor::IsBlockNode()` is a virtual method derived from
`EditorBase::IsBlockNode()`.  For the performance, `EditorBase`'s one just
return false for text node and `<br>` element.  However, these check cost
is really cheap in these days.  Therefore, we can make `TextEditor` also
use rich API.

This patch moves `HTMLEditor::NodeIsBlockStatic()` and
`HTMLEditor::NodeIsInlineStatic()` to `HTMLEditUtils`, and removes the wrapper
of the fommer, `HTMLEditor::IsBlockNode()` and `WSRunScanner::IsBlockNode()`.

Differential Revision: https://phabricator.services.mozilla.com/D70874

--HG--
extra : moz-landing-system : lando
2020-04-15 13:55:36 +00:00
Csoregi Natalia
03432c0168 Backed out changeset 6a15a1a87348 (bug 1482147) for geckoview assertion failure. CLOSED TREE 2020-04-16 06:27:49 +03:00
Glenn Watson
f276147e7f Bug 1630480 - Update gleam GL bindings to 0.11.0 r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D71133

--HG--
extra : moz-landing-system : lando
2020-04-16 02:13:31 +00:00
Csoregi Natalia
ea673441ce Backed out 8 changesets (bug 1616411) for webgl failures on test_2_conformance__textures__misc__texture-upload-size.html. CLOSED TREE
Backed out changeset 03dd88d53439 (bug 1616411)
Backed out changeset cfee2ce9405d (bug 1616411)
Backed out changeset 0a323c33506f (bug 1616411)
Backed out changeset 1a25353a07b0 (bug 1616411)
Backed out changeset dc64af52b5f8 (bug 1616411)
Backed out changeset 0f54b1b12105 (bug 1616411)
Backed out changeset 4dee3e753e8e (bug 1616411)
Backed out changeset 034a30a6b088 (bug 1616411)
2020-04-16 05:43:16 +03:00
Emilio Cobos Álvarez
352456ac8d Bug 1482147 - Simplify nsTypeAheadFind visibility code to not lie. r=masayuki
Multiple issues here. The IsRangeVisible code was wrong, it was returning false
for ranges that were perfectly valid, but outside the viewport, because the
following piece of code:

 if (!aMustBeInViewPort) {
   // This is an early exit case because we don't care that that range
   // is out of viewport, so we return that the range is "visible".
   return true;
 }

Was incorrectly after some stuff checking viewport visibility. This code is
pretty complex for no good reason, it wants to do something very
simple: Start from the visible selection if possible.

This patch still achieves this, using IsRangeRendered (which does a proper
hit-test to figure out if a range is in the viewport). Should have no behavior
differences except for non-collapsed ranges that are partially inside the
viewport.

Differential Revision: https://phabricator.services.mozilla.com/D71067

--HG--
extra : moz-landing-system : lando
2020-04-16 02:31:01 +00:00
JulianWels
26f9d5efce Bug 1620244 - Retention telemetry for HTTPS Only Mode. r=ckerschb,jcj
Differential Revision: https://phabricator.services.mozilla.com/D69547

--HG--
extra : moz-landing-system : lando
2020-04-16 00:33:10 +00:00
Drew Willcoxon
a6b80b0e24 Bug 1628926 - Remove the browser.urlbar.oneOffSearches pref. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D70921

--HG--
extra : moz-landing-system : lando
2020-04-16 00:00:55 +00:00
Botond Ballo
54e45ef6b0 Bug 1629732 - Fix non-unified build errors in layout/generic. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D71122

--HG--
extra : moz-landing-system : lando
2020-04-16 00:52:02 +00:00
Emilio Cobos Álvarez
d9251840a7 Bug 1630463 - Simplify some backdrop-filter pref checks. r=cbrewster
We build the backdrop root only if the actual backdrop-filter computed
value has something relevant, so if the pref is changed the style will
change, the display list code doesn't need to do anything special.

This simplify enabling the property conditionally in other ways in the
future.

Differential Revision: https://phabricator.services.mozilla.com/D71124

--HG--
extra : moz-landing-system : lando
2020-04-16 01:20:31 +00:00
Daosheng Mu
a27bacb080 Bug 1630440 - Handle select and squeeze events when a VR controller's button only has pressed and unpressed. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D71113

--HG--
extra : moz-landing-system : lando
2020-04-16 01:02:45 +00:00
Cameron McCormack
23b2665123 Bug 1630165 - Remove nightly-only gate from naturalWidth/naturalHeight honoring orientation metadata. r=emilio
We will ship all of the EXIF orientation related changes together in
this release.

Differential Revision: https://phabricator.services.mozilla.com/D70982

--HG--
extra : moz-landing-system : lando
2020-04-16 00:37:57 +00:00
Cameron McCormack
1c996b2686 Bug 1616411 - Part 7: Tests. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D70277

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:46 +00:00
Cameron McCormack
687f8da347 Bug 1616411 - Part 6: When -moz-element references an image, use the target orientation. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D70276

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:43 +00:00
Cameron McCormack
24d7ac6242 Bug 1616411 - Part 5: Make naturalWidth/naturalHeight getters take RasterImage orientation handling into account. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D70275

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:41 +00:00
Cameron McCormack
54fca42d06 Bug 1616411 - Part 4a: Make SurfaceCache aware that native image sizes can be affected by orientation. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D70983

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:39 +00:00
Cameron McCormack
808783c5aa Bug 1616411 - Part 4: Make nsLayoutUtils::OrientImage undo any automatic RasterImage orientation when required. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D70274

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:31 +00:00
Cameron McCormack
edd1013c3e Bug 1616411 - Part 3: Make RasterImage deal with and apply image orientation. r=tnikkel
This makes EXIF orientation metadata honored by default.

Introduce OrientedPixel and UnorientedPixel typed rects and sizes and
use them throughout RasterImage so that we don't confuse which we want.

The reason for doing this rather than having the imgLoader wrap every
RasterImage it creates with an OrientedImage is that returning the
wrapper messes with various notifications, as OrientedImage is not an
ImageResource.

(It would be even better if the JPEG decoder could decode to imgFrames
handling the EXIF orientation itself, but that's a more complicated
change.)

Differential Revision: https://phabricator.services.mozilla.com/D70273

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:29 +00:00
Cameron McCormack
2ed202c917 Bug 1616411 - Part 2: Don't bother passing in the size to OrientedImage::OrientSurface. r=tnikkel
We can get the size from the surface directly.

Differential Revision: https://phabricator.services.mozilla.com/D70272

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:26 +00:00
Cameron McCormack
4038aaae51 Bug 1616411 - Part 1: Split out some helper methods from OrientedImage. r=tnikkel
RasterImage will make use of them.

Note that there is one bug fix in this patch, which is that
OrientedImage::OrientSurface now creates a surface of the correct size.

(Previously this code was creating a surface with the underlying
image's size, rather than the correctly oriented size.  But we must
not have been calling into that code with our current uses of
OrientedImage.)

Differential Revision: https://phabricator.services.mozilla.com/D70271

--HG--
extra : moz-landing-system : lando
2020-04-16 00:34:19 +00:00
Arthur Iakab
3928665a70 Backed out changeset af41b9549456 (bug 1630389) for causing mass Windows failures.
CLOSED TREE
2020-04-16 03:36:36 +03:00
Tooru Fujisawa
3a09380544 Bug 1630264 - Revive expected failure for win32 window.open test. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D71087

--HG--
extra : moz-landing-system : lando
2020-04-15 19:23:03 +00:00
Emilio Cobos Álvarez
072ca409e3 Bug 1630385 - Don't descend into scroll frames with a pre-existing anchor. r=dholbert
We can modify the scroll position without invalidating the anchor (that's kind
of the point, actually).

So it's possible (and ok) to end up with a frame which is already maintaining
an anchor but for which CanMaintainAnchor now returns false.

So if you have a scrollframe with a non-zero scroll position and select an
anchor for that scrollframe, and then try to select an anchor for an ancestor,
you don't want to dig into there.

Differential Revision: https://phabricator.services.mozilla.com/D71103

--HG--
extra : moz-landing-system : lando
2020-04-15 23:13:00 +00:00
Matt Woodrow
9f11c31d1a Bug 1627971 - Fire onerror event for CONTENT_BLOCKED in EndPageLoad. r=nika,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D70587

--HG--
extra : moz-landing-system : lando
2020-04-15 22:33:46 +00:00
Matt Woodrow
a27cfc760b Bug 1627971 - Add option to MaybeFireEmbedderLoadEvents to also fire the error event to the embedder element. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D70585

--HG--
extra : moz-landing-system : lando
2020-04-15 22:30:13 +00:00
Matt Woodrow
ce7219acd5 Bug 1627971 - Move docshell embedder unblock load to a helper. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D70584

--HG--
extra : moz-landing-system : lando
2020-04-15 22:29:25 +00:00
Geoff Lankow
c7a24ee34a Bug 1623704 - Fix saveAs option of browser.downloads.download on Thunderbird. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D70470

--HG--
extra : moz-landing-system : lando
2020-04-15 10:43:18 +00:00
Kris Maglione
2b97c80ec2 Bug 1582318: Remove shutting-down processes from pool immediately. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69441

--HG--
extra : moz-landing-system : lando
2020-04-15 22:44:36 +00:00
Eitan Isaacson
14c42949a0 Bug 1629162 - Scrollability changed should fire accessible FOCUSABLE changes. r=morgan,Jamie
When an element with overflow:auto becomes scrollable, either by a style change or growing children, it should become focusable and fire a state change. Same in the inverse.

Differential Revision: https://phabricator.services.mozilla.com/D70561

--HG--
extra : moz-landing-system : lando
2020-04-15 22:33:55 +00:00
Eitan Isaacson
d5a790643e Bug 1629162 - Attribute changes should cause FOCUSABLE state change events. r=morgan,Jamie
Changes to attributes such as disabled, contenteditable, and tabindex should cause FOCUSABLE
state changes to be fired when indeed the accessible gains or loses focusability.

Differential Revision: https://phabricator.services.mozilla.com/D70560

--HG--
extra : moz-landing-system : lando
2020-04-15 22:33:48 +00:00
Sylvestre Ledru
17b998fd75 Bug 1466070 - mozlint/clang-format: create the new job r=ahal
Depends on D69683

Differential Revision: https://phabricator.services.mozilla.com/D69685

--HG--
extra : moz-landing-system : lando
2020-04-15 20:39:40 +00:00
Sylvestre Ledru
ee37eb29a7 Bug 1466070 - Integrate clang-format into mozlint r=linter-reviewers,ahal
For now, the local detection sucks. I will fix that once bug 1625884
is fixed

Differential Revision: https://phabricator.services.mozilla.com/D69683

--HG--
extra : moz-landing-system : lando
2020-04-15 20:39:32 +00:00
Ricky Stewart
c9156704b1 Bug 1630317 - Add a warning if there is an attempt to mach bootstrap from an "old commit" r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D71076

--HG--
extra : moz-landing-system : lando
2020-04-15 20:58:58 +00:00
Eitan Isaacson
a0e9e925ab Bug 1629771 - When collapsed caret moves in focusable element, don't pivot to it. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D71109

--HG--
extra : moz-landing-system : lando
2020-04-15 22:16:34 +00:00
Arthur Iakab
3f105ec0c5 Backed out changeset 0c8a5b5094b6 (bug 1628926) for Eslint failure on UrlbarView.jsm
CLOSED TREE
2020-04-16 01:38:49 +03:00
Imanol Fernandez
025f4b6335 Bug 1630170 - Delete XRWebGLLayer Framebuffer on XRSession presentation end r=kip,jgilbert,daoshengmu
Differential Revision: https://phabricator.services.mozilla.com/D71063

--HG--
extra : moz-landing-system : lando
2020-04-15 21:58:13 +00:00
Imanol Fernandez
e3dd20241c Bug 1630290 - Update VRManager VRLayer instead of recreating it. r=daoshengmu,kip
Differential Revision: https://phabricator.services.mozilla.com/D71064

--HG--
extra : moz-landing-system : lando
2020-04-15 21:59:44 +00:00
Imanol Fernandez
c3114c1c70 Bug 1630007 - Apply XRSpace effective origin position and orientation using matrix multiplication. r=kip,daoshengmu
Differential Revision: https://phabricator.services.mozilla.com/D70923

--HG--
extra : moz-landing-system : lando
2020-04-15 22:05:26 +00:00
Tom Prince
01409a49a6 Bug 1630047 - Allow mozversioncontrol to add or remove multiple files at once; r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D70938

--HG--
extra : moz-landing-system : lando
2020-04-15 22:16:49 +00:00
Bert Peers
7c32464a6c Bug 1630389 - Enable WaitForVBlank by default on Windows 10 r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D71097

--HG--
extra : moz-landing-system : lando
2020-04-15 22:00:17 +00:00