Commit Graph

518 Commits

Author SHA1 Message Date
jayati
4da359df42 Bug 1628729 - Remove nsIFxAccountsUIGlue. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D70427

--HG--
extra : moz-landing-system : lando
2020-04-09 19:50:54 +00:00
Vlad Filippov
b2e173a799 Bug 1590946 - Remove service=sync from account management links. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D63737

--HG--
extra : moz-landing-system : lando
2020-03-13 20:53:12 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Brian Grinstead
3d2d2d0ea7 Bug 1608281 - Automated rewrite away from reading properties on the global this in JSM files - round 1 r=mossop
This patch was generated with a script. It doesn't include all files:

- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)

It was generated with the following command using d855222aa2/no-this-property-read.js:

```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```

Differential Revision: https://phabricator.services.mozilla.com/D60187

--HG--
extra : moz-landing-system : lando
2020-01-29 21:50:04 +00:00
Punam Dahiya
94027b5678 Bug 1608942 - Add FX_MONITOR_OAUTH_CLIENT_ID as FxA constant r=rfkelly,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D59930

--HG--
extra : moz-landing-system : lando
2020-01-16 18:01:29 +00:00
Brian Grinstead
06d6426d76 Bug 1608278 - Remove global this setter for LOG_LEVEL in Credentials.jsm r=eoger
We need to stop relying on the global `this` in order to support ES Modules.
This instance was harder to fix by a script than others since it's in a try/catch,
so this patch is a manual change.

Differential Revision: https://phabricator.services.mozilla.com/D60080

--HG--
extra : moz-landing-system : lando
2020-01-15 23:52:13 +00:00
Mark Hammond
12bcd1cab8 Bug 1601446 - re-register the FxA device after the user becomes verified. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D59831

--HG--
extra : moz-landing-system : lando
2020-01-14 21:11:34 +00:00
Mark Hammond
964d300af6 Bug 1601797 - ensure we consistently report auth errors when a session token is missing. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D56096

--HG--
extra : moz-landing-system : lando
2019-12-06 16:44:55 +00:00
Geoff Brown
9e59579c39 Bug 1601076 - Fix some broken BUG_COMPONENTS in moz.build files; r=jmaher
Some of these were obvious typos. Others probably reflect once-correct components
that have been combined, split, or otherwise obsoleted; for these I've tried to
use the component associated with the bugs for recent changes to the affected files.

Differential Revision: https://phabricator.services.mozilla.com/D55756

--HG--
extra : moz-landing-system : lando
2019-12-04 13:55:45 +00:00
Mark Hammond
818e5a5c52 Bug 1598997 - Mock profile fetching function in xpcshell tests. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D54450

--HG--
extra : moz-landing-system : lando
2019-11-25 21:21:46 +00:00
Mark Hammond
9ff9e9548a Bug 1595954 - record event as the user explicitly connects or disconnects sync or fxa. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D53907

--HG--
extra : moz-landing-system : lando
2019-11-25 00:12:01 +00:00
Vijay Budhram
0929b414ed Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D50931

--HG--
extra : moz-landing-system : lando
2019-11-14 21:01:23 +00:00
Mark Hammond
e57be9d2f3 Bug 1594929 - Remove invalidateCertificate from FxAccountsKeys.jsm. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D52623

--HG--
extra : moz-landing-system : lando
2019-11-12 04:05:28 +00:00
Mark Hammond
ab41353fa5 Bug 1548404 - Update UITour to reflect the decoupling of FxA and Sync. r=MattN,andreio,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D51976

--HG--
extra : moz-landing-system : lando
2019-11-12 23:58:03 +00:00
rfkelly
048a518c75 Bug 1591312 - Revert to using BrowserID to generate OAuth tokens. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D50770

--HG--
extra : moz-landing-system : lando
2019-11-08 06:28:54 +00:00
Oana Pop Rus
6c038766da Backed out changeset dd5c1030d23b (bug 1590231) for bc failures in browser_search_within_preferences_2.js on a CLOSED TREE 2019-11-06 19:44:13 +02:00
Vijay Budhram
b9c626a520 Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D50931

--HG--
extra : moz-landing-system : lando
2019-11-06 16:51:03 +00:00
Gijs Kruitbosch
00778dd54e Bug 1591212 - make webchannel work with fission, r=vladikoff,mconley
Differential Revision: https://phabricator.services.mozilla.com/D51214

--HG--
rename : toolkit/modules/WebChannel.jsm => toolkit/actors/WebChannelParent.jsm
rename : browser/base/content/test/general/browser_web_channel.js => toolkit/modules/tests/browser/browser_web_channel.js
rename : browser/base/content/test/general/browser_web_channel.html => toolkit/modules/tests/browser/file_web_channel.html
rename : browser/base/content/test/general/browser_web_channel_iframe.html => toolkit/modules/tests/browser/file_web_channel_iframe.html
extra : moz-landing-system : lando
2019-11-02 00:39:35 +00:00
Thom Chiovoloni
962b41a45b Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment

Differential Revision: https://phabricator.services.mozilla.com/D49166

--HG--
extra : moz-landing-system : lando
2019-10-25 21:38:01 +00:00
rfkelly
ebf99d6f4f Bug 1590948 - Properly inspect context param when handling fxa_status webchannel message. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D50408

--HG--
extra : moz-landing-system : lando
2019-10-25 00:23:09 +00:00
Cosmin Sabou
23c6504831 Bug 1590486 - Fix eslint failure. r=eslint-fix 2019-10-24 06:58:21 +03:00
Mark Hammond
274e0280b0 Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D50359

--HG--
extra : moz-landing-system : lando
2019-10-24 03:30:57 +00:00
Cosmin Sabou
291e0d381d Backed out changeset c5503bc49a73 (bug 1590486) for xpc failures on test_web_channel.js. 2019-10-24 02:04:03 +03:00
Mark Hammond
75ea9bc416 Bug 1590486 - ensure FxA web channels can grab the session token. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D50359

--HG--
extra : moz-landing-system : lando
2019-10-23 21:21:23 +00:00
Oana Pop Rus
5033d599b4 Backed out changeset 3d7b77564cb7 (bug 1238810) for bc perma failures in browser_startup.js on a CLOSED TREE 2019-10-24 00:38:10 +03:00
Thom Chiovoloni
b8fe187695 Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment

Differential Revision: https://phabricator.services.mozilla.com/D49166

--HG--
extra : moz-landing-system : lando
2019-10-15 22:57:58 +00:00
Mark Hammond
12dd37165b Bug 1574051 - make FxA's session/account status checking sane and understandable. r=rfkelly,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D49689

--HG--
extra : moz-landing-system : lando
2019-10-22 00:58:36 +00:00
Mark Hammond
9a28c6748d Bug 1574052 - only return public fields from fxAccounts.getSignedInUser(). r=rfkelly,eoger
Differential Revision: https://phabricator.services.mozilla.com/D49525

--HG--
extra : moz-landing-system : lando
2019-10-22 00:57:27 +00:00
Mark Hammond
0481284ac7 Bug 1583897 - Send a telemetry event for new sendtab. r=tcsc,eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D48153

--HG--
extra : moz-landing-system : lando
2019-10-14 22:17:28 +00:00
Mark Hammond
c7296e7825 Bug 1587769 - update the pref we watch to ensure we sync immediately after device name change. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D49102

--HG--
extra : moz-landing-system : lando
2019-10-14 16:30:27 +00:00
Mark Hammond
1b362fb843 Bug 1587837 - better checking of the Firefox Account password changing. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D48936

--HG--
extra : moz-landing-system : lando
2019-10-11 16:41:44 +00:00
Mark Hammond
b559ec6b1b Bug 1587691 - Firefox Accounts webchannel message should allow login without engine choices. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D48797

--HG--
extra : moz-landing-system : lando
2019-10-10 16:57:42 +00:00
Edouard Oger
79a871cd9c Bug 1577690 - WebChannel support for optional Sync. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46316

--HG--
extra : moz-landing-system : lando
2019-10-08 15:19:23 +00:00
Edouard Oger
da3f0d0753 Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46517

--HG--
extra : moz-landing-system : lando
2019-10-08 15:45:06 +00:00
Razvan Maries
9c27546918 Backed out changeset 6852bdb8d8c5 (bug 1581709) for Linting failures. CLOSED TREE 2019-10-08 18:42:11 +03:00
Edouard Oger
1093781abc Bug 1581709 - Use sessionTokens for OAuth requests. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46517

--HG--
extra : moz-landing-system : lando
2019-10-08 14:19:11 +00:00
Lina Cambridge
397d3a1156 Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
Instead of using the list of FxA devices from the Sync clients engine,
we now fetch the list of Send Tab devices from FxA. This works like
this:

* `FxAccountsDevice#getDeviceList` has been split up into
  `recentDeviceList` and `refreshDeviceList`.
* `recentDeviceList` synchronously returns the last fetched list, so
  that consumers like Send Tab can use it right away.
* `refreshDeviceList` is asynchronous, and refreshes the last fetched
  list. Refreshes are limited to once every minute by default, matching
  the minimum sync interval (Send Tab passes the `ignoreCached` option
  to override the limit if the user clicks the "refresh" button).
  Concurrent calls to `refreshDeviceList` are also serialized, to
  ensure the list is only fetched once.
* The list is flagged as stale when a device is connected or
  disconnected. It's still kept around, but the next call to
  `refreshDeviceList` will fetch a new list from the server.
* The Send Tab UI refreshes FxA devices in the background. Matching FxA
  devices to Sync client records is best effort; we don't do it if Sync
  isn't configured or hasn't run yet. This only impacts the fallback
  case if the target doesn't support FxA commands.

Differential Revision: https://phabricator.services.mozilla.com/D47521

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:55 +00:00
Lina Cambridge
51e03623ee Bug 1583413 - Move device-related methods into FxAccountsDevice.jsm. r=eoger
This commit contains no functional changes, just moving code around to
make the next patch in this series easier to write.

Differential Revision: https://phabricator.services.mozilla.com/D47520

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:41 +00:00
Mark Hammond
47380e1a34 Bug 1581980 - change the text of many Sync notifications so they aren't Sync specific. r=flod,eoger
Differential Revision: https://phabricator.services.mozilla.com/D47853

--HG--
extra : moz-landing-system : lando
2019-10-03 05:52:58 +00:00
Mark Hammond
51a55ec4ba Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D47861

--HG--
extra : moz-landing-system : lando
2019-10-03 01:18:09 +00:00
Bogdan Tara
11b09d510c Backed out changeset 961eac228e3e (bug 1585299) for ES Lint failures on FxAccounts.jsm && test_accounts.js CLOSED TREE 2019-10-02 09:41:37 +03:00
Mark Hammond
c0a71bf7f1 Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D47861

--HG--
extra : moz-landing-system : lando
2019-10-02 06:03:39 +00:00
Mark Hammond
4b629788b2 Bug 1570567 - update about:preferences#sync to reflect the decoupling of FxA and Sync. r=Gijs,eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46574

--HG--
extra : moz-landing-system : lando
2019-09-26 10:48:22 +00:00
Mark Hammond
7ec2097ae8 Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D46572

--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
Edouard Oger
5431bbfab3 Bug 1547120 - Add a method to list attached clients. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D46838

--HG--
extra : moz-landing-system : lando
2019-09-23 20:43:56 +00:00
Edouard Oger
7f39ae82a2 Bug 1582542 - Use getUserAccountData in FxA commands invoke. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46511

--HG--
extra : moz-landing-system : lando
2019-09-19 19:51:41 +00:00
Edouard Oger
3017be71f8 Bug 1582537 - Call getScopedKeys on keys field. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46509

--HG--
extra : moz-landing-system : lando
2019-09-19 19:28:48 +00:00
Mark Hammond
0203cd1dd5 Bug 1574048 - Remove FxAccounts internal/external/Object.freeze()/ weirdness. r=lina,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D44083

--HG--
extra : moz-landing-system : lando
2019-09-12 02:08:50 +00:00
Mark Hammond
e074186422 Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D43897

--HG--
extra : moz-landing-system : lando
2019-09-11 01:37:50 +00:00
Bogdan Tara
0f5e9e5206 Backed out changeset 93d2d4bbe263 (bug 1575921) for xpcshell failures on test_device.js CLOSED TREE 2019-09-10 04:42:15 +03:00