Commit Graph

10925 Commits

Author SHA1 Message Date
Igor Gutorov
5146a45474 servo: Merge #19749 - style: Move -moz-context-properties outside of mako (from gootorov:move_-moz-context-properties_from_mako); r=emilio
<!-- Please describe your changes on the following line: -->
Sub-PR of #19015

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19742  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 2ff3e119faab0488ebd4d790600d07695404f883

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 01b2a9b44500eca908d8d8ddd3ce956b2b214a3d
2018-01-15 06:04:30 -06:00
Emilio Cobos Álvarez
13ef7eb69b servo: Merge #19757 - style: Remove -servo-text-decorations-in-effect (from emilio:bye-custom-cascade); r=nox
It is bogus, because it depends on the display property as it's cascaded, but
the display property can change afterwards, for example, if we get blockified
because we're the root element or a flex item.

Replace it with a normal field instead.

Also, it carries some weight, because it's the last property that uses this
concept of "derived" property, and "custom cascade". So we can remove some code
after this.

Compute it after the cascade process in StyleAdjuster.

Source-Repo: https://github.com/servo/servo
Source-Revision: f2036e7661a3f865b38d8296cc1b8ab98e60f679

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0206357b95137b0ebb8533d71d7a705faf781e60
2018-01-15 05:14:49 -06:00
Emilio Cobos Álvarez
03f7906492 servo: Merge #19769 - layout: Simplify the pseudo-element setup (from emilio:simplify-layout-construct); r=nox
It's kind of a mess. See individual commits for details.

Source-Repo: https://github.com/servo/servo
Source-Revision: 032fd388e4efdd9ecc682877d017b9d2f78e29e2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f365989a4d7c713caf92ed0ef34a228a6243644e
2018-01-15 04:14:13 -06:00
Fernando Jiménez Moreno
44c2e62c99 servo: Merge #19772 - Do not fire pending callbacks on disconnected performance observer (from ferjm:performance.wpt); r=nox
Implement this change in the Performance Timeline API https://github.com/w3c/performance-timeline/issues/66

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: f866e1aacb5bcf17a7d11c6106d34b474d6b4f33

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 55e08a3e9a94522e4e53acbb39e8f737171837c1
2018-01-15 03:20:57 -06:00
Glenn Watson
9b5b59b43a servo: Merge #19768 - Update WR (overlap radii fix, subpixel AA in fast text shadows) (from glennw:update-wr-fixes1); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: eb1634b56b27c163a3721f7416c5ade5fa4878a6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c590555734f612679aadf7ca51b6ec78c4ea7ba2
2018-01-14 20:00:59 -06:00
Jon Leighton
be8afec803 servo: Merge #19766 - Move image-orientation property outside of mako (from jonleighton:issue-19765); r=emilio
Fixes https://github.com/servo/servo/issues/19765

r? emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: ec34023d7a1ba5d7cc882fbb66b880960ce79c43

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ed8a3717f74ff576a51720cdd025561675963a86
2018-01-14 16:55:15 -06:00
CYBAI
ca2729f9fa servo: Merge #19709 - style: Remove -servo-display-for-hypothetical-box from longhand (from CYBAI:servo-display-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

For the `fn set_original_display` inside `properties.mako.rs`, I removed `is_item_or_root` first to see how the tests result is. If it's needed, I'll add it back.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19697
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 1b46e2e7597e90a41c6bfb3bd7008bdd922c93c6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fd06f9afbcc05acfe20eb48096e421d7dd5b3c2e
2018-01-14 08:27:14 -06:00
Simon Sapin
0ec8be6cd9 servo: Merge #19764 - Upgrade to rustc 1.25.0-nightly (e6072a7b3 2018-01-13) (from servo:rustup); r=SimonSapin
CC #19762

Source-Repo: https://github.com/servo/servo
Source-Revision: 73cb6d415e026cb06f0dc2df1f9f4c803cdf6020

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 22dcbf8c8ba2734363bcbc41f293b3b13570dd96
2018-01-14 03:10:13 -06:00
Emilio Cobos Álvarez
2690891ba1 servo: Merge #19760 - style: Ruby style adjustments shouldn't reset mOriginalDisplay (from emilio:ruby-display-adjust); r=upsuper
This matches what Gecko does:

  https://searchfox.org/mozilla-central/rev/7476b71e0010ab3277b77cc0ae4d998c4b1d2b64/layout/style/GeckoStyleContext.cpp#992

And it's conceptually more right, since we ideally shouldn't mutate
mOriginalDisplay from StyleAdjuster.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7b92eb932b34ce1a4b823b2571a50a928491b4b2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b4bf984062c0deb84afa0c2e00deadbb64253f6c
2018-01-13 13:16:06 -06:00
Bobby Holley
39aaa2d873 servo: Merge #19756 - Avoid entraining various Debug impls in release builds (from bholley:avoid_debug_impls_in_release); r=emilio
See https://bugzilla.mozilla.org/show_bug.cgi?id=1351737#c29

This patch saves more than 80k of code size.

Source-Repo: https://github.com/servo/servo
Source-Revision: 08fc9f190d7e1eaa11560b5924e243ba686c3d79

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5c71e5e84415f8934a4e72b75e357d1962f82def
2018-01-13 11:52:15 -06:00
Emilio Cobos Álvarez
14e568fe7e servo: Merge #19758 - style: Adjust the writing-mode fixup to call set_adjusted_display on Servo (from emilio:adjust-display-right); r=emilio
This is functionally equivalent right now (set_adjusted_display will just do
set_display), but won't be after #19709.

Source-Repo: https://github.com/servo/servo
Source-Revision: e81193c5c953894eae0290614788997f0b89a386

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c73c03a4d3fd18b139f62888099fc0b3837a96f9
2018-01-13 06:00:45 -06:00
Simon Sapin
fef592f6e7 servo: Merge #19751 - Clean up the selectors crate for a new crates.io release (from servo:selectors); r=bholley
Source-Repo: https://github.com/servo/servo
Source-Revision: 6ca651c0c8271ce185448e1db95b893a276eaed9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 712f0420bf06ff978766865f757432bc7eb52b2a
2018-01-12 16:55:12 -06:00
Bobby Holley
27dd61154d servo: Merge #19753 - NoteDirtyElement optimizations (from bholley:notedirtyelement_optimizations); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1398119

Source-Repo: https://github.com/servo/servo
Source-Revision: 1a8366598afdbf4de31dcbaf0d9585f7a8a5e7b4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 464b9c00206d13c30fad6628c26fe0923a1a5fce
2018-01-12 12:22:10 -06:00
CYBAI
66f8fa7381 servo: Merge #19752 - style: Use Python's True instead of string for arbitrary Python code in mako (from CYBAI:fix-mako-true); r=nox
As discussion in IRC with @nox and @gootorov , it's more correct to use Python's `True` for `${arbitrary Python code}` in mako.

Following is related IRC logs

```
15:39 nox
As I said, that's because there are 2 ways to invoke the things with Mako.

15:40 nox
${arbitrary Python code} vs <%named_helper ..>...</%named_helper>

15:40 nox
IIRC <%foo bar=True></%foo> is not valid Mako syntax,

15:40 nox
but with bar="True" it is.

15:42 cybai
gootorov: I did meet some issues when moving makos if I set "True" instead of Python's `True`. Thus, like nox mentioned above, it's related to how the code works

15:44 gootorov
nox: Alright, I got it now, thanks. There are a couple ${function} blocks that still use `boxed="True" though. They aren't <%named_helpers>, shouldn't they use Python's True too, then?

15:45 nox
gootorov: I think there is an issue because this specific attribute is also used as a string through other <%helpers>,

15:46 nox
gootorov: Seems like it's not an issue anymore because the boxed attribute is passed to arg_to_bool,

15:46 nox
which either returns the boolean as is or check whether it's a "True" or "False" string.

15:47 nox
gootorov: So indeed, you can probably make those use booleans now.

15:47 gootorov
nox: Okay, got it, thanks for the explanation :)
```

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 865181b6e676fc9b76447ad5172e275b9861ca5e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 38ac407acec755822447200ce8b056c90ba5ceb1
2018-01-12 10:56:30 -06:00
Glenn Watson
dc6c675e4d servo: Merge #19750 - Update WR (new transaction API) (from glennw:update-wr-api); r=jdm
In the future we'll want to start making use of this in Servo
to get atomic updates of resources with display list changes etc.

Source-Repo: https://github.com/servo/servo
Source-Revision: 75f39b42abc88a2597186fe845d2deaa15bdb6da

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 93f893701ad69ccc6464c0ddd545cba4a38ffa64
2018-01-12 08:20:59 -06:00
Emilio Cobos Álvarez
543216dd9a servo: Merge #19747 - style: Add a document state invalidator (from emilio:doc-state-invalidator); r=upsuper
Don't use it yet (since I was working from a Servo tree). Will hook it up and improve in the Gecko bug.

Right now it takes a `StyleRuleCascadeData`, which means that if all the origins in the document have state selectors we could do just one walk over the tree and not multiple, that will be improved.

Other than that, this is completely untested of course, but I prefer to land it, given I don't think it's complex, and work on the Gecko integration separately. The reason for this is that I also plan to fix the `<slot>` bugs, which will change `StyleRuleCascadeData` and such, and I want the two bugs to conflict as little as possible.

Source-Repo: https://github.com/servo/servo
Source-Revision: 50e4171958d4ff7f1c76d133a8f89e7d5995376f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4f1c7698b9912d4782d744a4dbd9e80afa7fe0cf
2018-01-12 05:09:04 -06:00
Bobby Holley
68846f4468 servo: Merge #19748 - Adjust size of gecko ComputedValues struct for removal of separate lazy pseudo cache (from bholley:remove_lazy_pseudo_cache); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1429529

Source-Repo: https://github.com/servo/servo
Source-Revision: 005dc85a888b1c73a849bb7b4e2f7d9d22321909

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ce9d75e4b0b989760b3fc15fa3181d51d28a2545
2018-01-11 12:16:01 -06:00
Josh Matthews
04827552a3 servo: Merge #19740 - Allow warnings during mutation tests (from servo:jdm-patch-2); r=aneeshusa
Sometimes mutations include removing the only use of a variable. When we deny warnings globally, we inhibit these mutations that trigger new warnings.

Source-Repo: https://github.com/servo/servo
Source-Revision: 2b9dbc341502f5e9e1fb6e071c3d5119cc263a46

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ea29866756cb97c1ffe903334e9d73a9a30dbd88
2018-01-11 10:30:19 -06:00
Emilio Cobos Álvarez
765b6f3069 servo: Merge #19744 - style: A few trivial changes in preparation for document state invalidation (from emilio:doc-invalidation-preparation); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: 9b3fc43f5a576f4cc466a779e2a308e53a8a46f7

--HG--
rename : servo/components/style/invalidation/element/collector.rs => servo/components/style/invalidation/element/state_and_attributes.rs
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f1071c0458393a3ccf72cbb360fd789de7f7afc2
2018-01-11 07:50:55 -06:00
Pyfisch
6343bde1af servo: Merge #19716 - Use a ToLayout trait for converting from style to webrender types (from pyfisch:conversions); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 1a4df8f87668d5f5f24f4faeca43fb592a8edfe0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 07094f447f924cc0f0800906665d968ee41e2f90
2018-01-11 03:41:43 -06:00
Edgar Chen
0861896cc7 servo: Merge #19743 - style: Remove :unsolved pseudo-class (from EdgarChen:unresolved); r=heycam
<!-- Please describe your changes on the following line: -->

This is the servo part changes of https://bugzilla.mozilla.org/show_bug.cgi?id=1417829.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1417829.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this PR is to remove a feature.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: f47cd758fa76e571d378d29d031ecad38ac202d4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e218b96dd7cc592c96639824f1373bf4e02c450d
2018-01-10 21:06:04 -06:00
Simon Sapin
53ce66c194 servo: Merge #19683 - Upgrade to rustc 1.24.0-nightly (0a3761e63 2018-01-03) (from servo:rustup); r=jdm
Fixes #19635
Fixes #19637
Fixes #19735
Fixes #19519

Source-Repo: https://github.com/servo/servo
Source-Revision: a22bff8119dd9ef4f85b277de7be6a9e20119f70

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 850bb03bf38848f152cb635ff09b96d5cbf1cfa1
2018-01-10 14:00:32 -06:00
Igor Gutorov
c971270f8f servo: Merge #19739 - Add note to Gentoo setup to set LIBCLANG_PATH envvar (from gootorov:master); r=jdm
<!-- Please describe your changes on the following line: -->
Without `LIBCLANG_PATH` environment variable set the build for `gecko-media` fails as in https://github.com/servo/servo/issues/19351 for Gentoo Linux. This patch adds a note to the README to set the environment variable.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a documentation fix

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: e9f9fd1e4c7f2b670ac45631404430d1fc4c4b16

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c043e15295b35b5b3dbbb8c7c098ce73689c54a0
2018-01-10 13:05:17 -06:00
Simon Sapin
6102d09277 servo: Merge #19395 - Use rustup.rs instead of custom bootstrap (from servo:rustup.rs); r=jdm
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

Source-Repo: https://github.com/servo/servo
Source-Revision: 2be49ac80659f58f2a39910dd79a3f3b5da98945

--HG--
rename : servo/rust-stable-version => servo/geckolib-rust-toolchain
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c6a5c3079e3c2b9894e937024355e7586adef91e
2018-01-10 12:00:59 -06:00
Anthony Ramine
8e84d8fe5c servo: Merge #19727 - Properly handle CR in textarea placeholders (fixes #19717) (from nox:cr-placeholder); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 2065fa6da23c304093b0fdbbf7c068e0b0c67366

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 25a0a5700a81ef4eaf1bbd56035434758c5987f4
2018-01-10 10:37:47 -06:00
CYBAI
4280de0aae servo: Merge #19737 - style: Move paint-order outside of mako (from CYBAI:move-paint-order-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19736
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: ad622a46f05c1155f68ef4e9d0a19bbccadce457

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 41fdf73bba0ca15be1972ba211fb061d3b882a27
2018-01-10 07:59:04 -06:00
Emilio Cobos Álvarez
462ee655fa servo: Merge #19734 - style: Remove some unneeded indirection (from emilio:less-indirection); r=mbrubeck
All TElement's implement Copy, and are just pointers, so the double indirection
is stupid.

I'm going to try to see if removing this double-indirection fixes some
selector-matching performance, and this is a trivial pre-requisite while I wait
for Talos results.

Source-Repo: https://github.com/servo/servo
Source-Revision: e2c89df8eeb5f2dbac1436335aea52099a622d0d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4d89983f1f0838dc6c11c31e15321289df7f0192
2018-01-09 23:34:15 -06:00
Nathan
fe7e4f4997 servo: Merge #19730 - number input type validations (from NLincoln:19172-number-input-type-validations); r=KiChjang
I used rust's builtin float parser to implement this. Rust's parser is more permissive than what browsers support (in this case), so I added some code to handle those edge cases.

This passes all the prewritten test cases locally, but I fell asleep last night before updating the manifests 😅

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are part of #19172

<!-- Either: -->
- [X] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: afe298b53d91226d61a2ca7955b9c1d3d233a194

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b4f052180dd5c3eaf446bde7bb5c5f405f6cc888
2018-01-09 22:15:12 -06:00
Emilio Cobos Álvarez
c45cdb9767 servo: Merge #19733 - style: Use Option::get_or_insert_with (from emilio:less-unwrap); r=glennw
Less unwraps is better.

Source-Repo: https://github.com/servo/servo
Source-Revision: e5a0bb9b4d26156ee675c33968007c7d0d54fd3b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 41c7404b7e1489db6ba158397a49793b6b8af42f
2018-01-09 20:50:12 -06:00
Igor Gutorov
a08ebf9101 servo: Merge #19732 - Update Gentoo Linux setup to include clang (from gootorov:master); r=jdm
<!-- Please describe your changes on the following line: -->While other Linux distributions include clang package as required in the setup section of README, Gentoo does not. This patch fixes it.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a documentation fix

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d0300ffd67c2278f6c9ce8cac23923f13641abf3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3ecedd3f8ddafe7a01d5e24c7dc2fa452480d69a
2018-01-09 17:27:47 -06:00
Josh Matthews
46bde0fb69 servo: Merge #19728 - Update web-platform-tests (from servo:wptup); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 94b188d6c137a2502a29d00a7669a2d674e9693f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1f3b3a487503abff3891a745a74735a294e47ba2
2018-01-09 12:38:08 -06:00
Aneesh Agrawal
8044f8fd4e servo: Merge #19720 - Update buildbot_steps lint to handle env variables (from aneeshusa:support-env-vars-in-buildbot-steps); r=jdm
https://github.com/servo/saltfs/pull/687 added support
for specifying environment variables in `buildbot_steps.yml`.
Update the servo-tidy buildbot_steps.yml linter to reflect this.

Use the voluptuous Python library (BSD 3-clause license) for validation
in lieu of a much larger hand-written implementation.

Extracted out of #17171. Helps with servo/saltfs#770.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because they change the tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 6a6dda526961b7bb7b856e8310ffc165d8bd39aa

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ebdbefbc7cb6f397a0630f417c9c03e003cfc9ab
2018-01-09 11:40:27 -06:00
Glenn Watson
5cdd3ff7a8 servo: Merge #19725 - Update WR (inset box shadow fix, line decoration optimizations) (from glennw:update-wr-bs-line); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: d9800191e7248d003b4056987eef6b9bb02627ee

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 228f5238ec60debfa490ad7e546582af90ddc11c
2018-01-09 08:22:13 -06:00
Emilio Cobos Álvarez
d09192fc43 servo: Merge #19721 - style: Support ::slotted better (from emilio:slotted); r=heycam
This allows to selector-match ::slotted, though we still don't parse it.

Bug: 1425834, 1424607, 1425755
Reviewed-by: heycam
MozReview-Commit-ID: ItELHkf2PMl
Source-Repo: https://github.com/servo/servo
Source-Revision: bb34b7f54aa85cde600c6d675360d03714cf1f8b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c92bde66c55c112ea537384d89a698ccb5eba798
2018-01-09 07:26:28 -06:00
Manoj
bafb51a99f servo: Merge #19724 - Remove out of date FIXME comments from domimplementation (from hindenbug:19723-remove-fixme-comments); r=metajack
<!-- Please describe your changes on the following line: -->
This removes out of date FIXME comments from `domimplementation.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19723

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this is a comment cleanup

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: aa199307c86051e13b17a5feb77722ddcdeed5ce

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 389a0f62b8ec997d1ea665182b2ed38a2ad90665
2018-01-08 19:28:49 -06:00
tigercosmos
cdac28a303 servo: Merge #19647 - replace DocumentSource::NotFromParser with DocumentSource::FromParser (from tigercosmos:x3); r=jdm
<!-- Please describe your changes on the following line: -->
per https://github.com/servo/servo/pull/4297/files#r158729975

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d41f720ee422f53a7c49d0877d105d8750ea404f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 301ea2abc9fa41a80af1bc2590c108a2ffec8ccf
2018-01-08 11:23:21 -06:00
Adrian Wielgosik
511aeddd07 servo: Merge #19722 - Remove js.mem.gc.refresh_frame_slices.enabled pref (from adrian17:master); r=emilio
Clean up after gecko [bug 1421358](https://bugzilla.mozilla.org/show_bug.cgi?id=1421358), which removed the pref entirely.

Source-Repo: https://github.com/servo/servo
Source-Revision: 02f1864770c108a47b3c83c3d89293222cb6dfcf

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2588bb21f54258c3639ad1d6a222f98fcef0761d
2018-01-08 04:52:09 -06:00
Glenn Watson
677bd4968e servo: Merge #19715 - Update WR (removal of RGB8, which isn't supported on some hardware) (from glennw:update-wr-rgb8); r=emilio
Instead, we convert any source RGB8 images into RGBx (with
an opaque alpha channel).

Source-Repo: https://github.com/servo/servo
Source-Revision: 5d0d6cff81a003e72dda83f6b2dd87ad8821d779

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 425ab27ae1e200eec6d63585e9da02af7717ab89
2018-01-07 17:04:54 -06:00
Pyfisch
30dce265cf servo: Merge #19686 - Create own file for background calculations in layout (from pyfisch:layout-background); r=emilio
See #19676

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e226fe9ff412cff087069f17d1bc634cf5fa994

--HG--
rename : servo/components/layout/display_list_builder.rs => servo/components/layout/display_list/builder.rs
rename : servo/components/layout/webrender_helpers.rs => servo/components/layout/display_list/webrender_helpers.rs
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3ea1341671593aa486b39b2dc570a7afc56cc5a2
2018-01-07 08:53:18 -06:00
tigercosmos
7e509de21b servo: Merge #19602 - implement valid DatetimeLocal input (from tigercosmos:r1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement valid Date time Local input

part of #19172

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19587 fix #19603(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7f36b59762864731279fb249dd50faca5078b751

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ea6250ffebfac620b987fac98b653247aa81a951
2018-01-07 05:10:47 -06:00
Igor Matuszewski
17d094116c servo: Merge #19644 - Root sequence<any> params using CustomAutoRooter (from Xanewok:root-seq-any); r=jdm
<!-- Please describe your changes on the following line: -->

Attempt at https://github.com/servo/servo/issues/16678. At the moment this pulls an external [remove-handle-conv](https://github.com/Xanewok/rust-mozjs/tree/remove-handle-conv) branch for rust-mozjs (removing `FromJSValConvertible` implementation for `HandleValue` and adding one for `*mut JSObject`)

In short, this roots the `sequence<any>` and `sequence<object>` function arguments using `CustomAutoRooter` (introduced in https://github.com/servo/rust-mozjs/pull/382).

As per https://github.com/servo/servo/issues/16678#issuecomment-302224110 the underlying vector contains raw gc thing pointers instead of handles. To do that, this introduces new possible `isMember = "AutoRoot"` value in CodegenRust.py.
The rooted argument is passed to a function wrapped in a `CustomAutoRooterGuard` [RAII root guard](ed5e37a288/src/rust.rs (L586-L588)) (e.g. as `CustomAutoRooterGuard<Vec<JSVal>>`)

I felt quite out of my depth when trying to adapt CodegenRust.py code, so I'd appreciate any help with how can be done better/in a more clean manner.
Also the name `CustomAutoRooterGuard` is quite lengthy, so I'm also open to changing it (`AutoRoot`? `AutoRootGuard`?)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #16678  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 989d2fd53267d063212ef3b7b7f13f2402943c4a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1d2081536bfa13c32a50b4862abbe3a03f305da3
2018-01-05 14:02:53 -06:00
Nate Tenczar
bdd03ff7ab servo: Merge #19701 - Update Arch Linux setup to include clang (from ntenczar:update-readme-clang); r=jdm
<!-- Please describe your changes on the following line: -->
`clang` is needed to compile servo, but isn't listed as one of the dependencies needed for arch and isn't part of the `base-devel` group.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X]  no applicable github issue

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's a README change

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dd27fbcb3f31ae7a72d5d3ba5d22db318249acbd

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 52f76145122ae13d8154f1306d850fcbc35bf9f3
2018-01-05 13:01:28 -06:00
Alan Jeffrey
3d419b7a66 servo: Merge #19523 - Filter out failed test-perf runs (from asajeffrey:test-perf-filter-out-failed-tests); r=avadacatavra
<!-- Please describe your changes on the following line: -->

Google Data Studio is a lot happier if the data that's driving it is already filtered. This PR filters out any failed test runs from the CSV file generated by test-perf.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 753e2bc781ee3f9fd219b1f06ac332ec3077675c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f67a4d3961e01f0279bde2d9482b2f88552a7172
2018-01-05 09:15:48 -06:00
Pyfisch
6137e455a9 servo: Merge #19699 - Correctly place images with background-position: center (from pyfisch:background-position-fix); r=emilio
Add a regression ref test.
See also #19680.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 12a74de5a181c03852550d04632548011f8e7cb9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 917c23a500ce0f8a31814a58d8f23be155c431cc
2018-01-05 06:37:38 -06:00
Emilio Cobos Álvarez
15c20a101d servo: Merge #18893 - style: Remove TNode::set_can_be_fragmented and TNode::can_be_fragmented (from emilio:bye-can-be-fragmented); r=SimonSapin
Replace them instead by a computed value flag, the same way as the
IS_IN_DISPLAY_NONE_SUBTREE flag works.

Source-Repo: https://github.com/servo/servo
Source-Revision: 83a8891bd4d04ccb3f2f7b292d53f2847380b94c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e866663b660580644a022356b6226f5ec3e336d4
2018-01-05 05:11:00 -06:00
Xidorn Quan
89d2d74b33 servo: Merge #19696 - Skip rule node which contains only inherited properties for rule cache (from upsuper:rule-cache-opt); r=emilio
This is one possible fix for [bug 1427681](https://bugzilla.mozilla.org/show_bug.cgi?id=1427681) which tries to skip some rule nodes when using rule cache.

Try push for correctness: https://treeherder.mozilla.org/#/jobs?repo=try&revision=74e3941e2cfc5fba4bce839f2518af8a5a8b7411

It doesn't really show much memory saving on awsy. It only shows several KB save on fresh start memory. But since conceptually it's simple, I guess it's worth taking.

Source-Repo: https://github.com/servo/servo
Source-Revision: 6131371cc230cca45b13ef9a2622c6e602208357

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1291fd4e9a1c7aa05125ffccac6d81227bc3c221
2018-01-05 03:35:04 -06:00
Glenn Watson
7e0011ceb3 servo: Merge #19614 - Update WR (dual-source subpixel text optimizations, clip-out segment builder) (from glennw:update-wr-clip-out-seg); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: a5a7b96ac28e3f51732b0ac9e048ded46591a310

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : dba4c7545d3baa4fdfa646f292e64deca32dd801
2018-01-05 02:34:38 -06:00
Pyfisch
d50101b22b servo: Merge #19691 - Remove mention of some old issues (from pyfisch:cleanup-issues); r=emilio
* #228 was done (confirmed by mbrubeck)
* #2012 fixed TODO item
* servo/webrender#28 (zoom does work)

<!-- Please describe your changes on the following line: -->
See #19685

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d1c72fde33338fb2042957c3ccafb31540adee92

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 160f69f3147dd8ecb6471c64080cf73def1c2778
2018-01-05 00:25:12 -06:00
Hiroyuki Ikezoe
1373124b80 servo: Merge #19693 - Drop animation name and transition property from early properties (from hiikezoe:drop-animation-name-and-transition-property-from-early-properties); r=boris
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1420928

Source-Repo: https://github.com/servo/servo
Source-Revision: 97e39797418486196e9685931e01a3d1b563f93e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b6829e2a84c8b6d7cd037d6b7cacd40769caca7b
2018-01-04 22:14:18 -06:00
lizhixun
e97719a4e8 servo: Merge #19692 - style: Make Contain::parse simpler (from stevel98:Contain); r=emilio
<!-- Please describe your changes on the following line: -->
---
Makes Contain::parse slightly simpler, as discussed in #19682

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19682 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

Source-Repo: https://github.com/servo/servo
Source-Revision: 0393f9d231ce146761ed6b6b635ac040adfb07f3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 80573b78a8a266eec84f2b72ac157491219425c8
2018-01-04 19:52:44 -06:00