Commit Graph

10925 Commits

Author SHA1 Message Date
Aneesh Agrawal
bd8f29779e servo: Merge #19591 - Actually run Taskcluster jobs on PRs (from aneeshusa:actually-trigger-taskcluster); r=edunham
Spawn TC jobs on the following events:
  - Pull request opened or reopened
  - New commit made in pull request

Spawn TC jobs for pull requests started by anybody,
not just trusted collaborators.
This is safe for now as we do not provide any scopes to spawned jobs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 6440f17835e35069eddab88067f328a1a99d5376

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e2c5882be224caa2999ab7b5bf8fbb6b98329385
2018-01-04 18:40:39 -06:00
Pyfisch
4e3d9fc756 servo: Merge #19689 - Fix typo. san-serif -> sans-serif (from pyfisch:san-serif); r=jdm
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 782e3fe4e47b4be47bf8ec87e6ef566881c312b0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ba9aa56e5a5435735368ffa50738785c43e9d672
2018-01-04 14:06:47 -06:00
lizhixun
43e33f8506 servo: Merge #19682 - style: Move contain outside of mako (from stevel98:moveContain); r=emilio
<!-- Please describe your changes on the following line: -->
Sub-PR for #19015.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19656 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7a9f99eda881d500ea344382d02037bfd11789da

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7543846743c59ec1d0c917efb915155e2f7e17da
2018-01-04 04:28:23 -06:00
Pyfisch
24b5e64ac1 servo: Merge #19681 - Format parts of layout (from pyfisch:rustfmt-display-lists); r=emilio
Formats the following files:
* components/layout/display_list_builder.rs
* components/layout/webrender_helpers.rs

Remove outdated options from rustfmt.toml.
Configure rustfmt to place binary operators
at the end of line (to match ./mach test-tidy).

Rationale: I am tired of indenting my patches by hand trying my best to do it correctly and match the surrounding code. Just to be told that either my indentation is wrong or that I should switch to block indentation for this function because it looks better.

The new formatting passes `./mach test-tidy`. Compared to the old formatting it is a lot more consistent but also tends to spread the code across more lines. The diff is this big because a lot of code used visual indentation.

See also #8553

Source-Repo: https://github.com/servo/servo
Source-Revision: 3692f13dcbba64741e2f8d15fc1e225667437ef6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 03e42b8bf9b41ecf90a607bcfe8b3b5647fca017
2018-01-03 19:49:02 -06:00
Glenn Watson
263090a0aa servo: Merge #19677 - Enable GPU queries by default when opening the profiler view (from glennw:wr-queries); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: cdf7c0ceff7edc4374521fb19329109f999a9c3b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f70a843dbc6b1cfd241b6d5bd814690fedebe653
2018-01-03 14:13:42 -06:00
Pyfisch
bc58b3d036 servo: Merge #19675 - Implement correct corner clipping for background color (from pyfisch:issue19649); r=emilio
Add one regression ref test.

See also #19649

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

- [x] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: ef4246537da6888de0d7a4274ebd26faf52c9bf2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9880251ac005d85b228c627d278b6886fb262566
2018-01-03 13:03:49 -06:00
Emilio Cobos Álvarez
61f3d7e4e8 servo: Merge #19654 - style: Allow building stylo with rust nightly (from emilio:geckolib-nightly); r=jdm
See individual commits for details.

Source-Repo: https://github.com/servo/servo
Source-Revision: f71fb8bddc28060320c233701898541112322d66

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8f8b2ccece94cc9df26c8c41afba04032fe9d506
2018-01-03 12:01:42 -06:00
tigercosmos
928bcae734 servo: Merge #19586 - let mutation testing display diff if compilation fails (from tigercosmos:x1); r=jdm
<!-- Please describe your changes on the following line: -->

let mutation testing display diff if compilation fails

r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19566 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 2b1a30175ce8118eab7ffa0bd771602742e915ad

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 63a8ab7ec1e80dcc48719e6201c4a7cef5cf7011
2018-01-03 10:21:18 -06:00
Emilio Cobos Álvarez
71ed50bebd servo: Merge #19673 - style: Make GetFlattenedTreeParent more straight-forward (from emilio:flattened-tree-parent); r=smaug
Now that accessing nsIContent slots is not a blob of virtual function calls, we
should be able to unify logic here, and speed up the not-so-rare case for
chrome, while keeping the usual case fast.

Bug: 1427511
Reviewed-by: smaug
MozReview-Commit-ID: 87iY5Cbhx4T
Source-Repo: https://github.com/servo/servo
Source-Revision: 9187c9a093860d9f3c31b5a5f402458aa4a607cb

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 246fcb20110ef1096cf79d73a3b2985ea15aa466
2018-01-02 10:00:22 -06:00
Pyfisch
92b150e06c servo: Merge #19651 - Unify background placement code (from pyfisch:background-placement); r=emilio
Merges the implementations for background-image placement
from gradients and images. Add missing parts and fix bugs.

Now supported are the CSS properties:

* background-attachment (except for local value, see #19650)
* background-clip
* background-origin
* background-position-x/y
* background-repeat
* background-size

It should be noted that backgrounds are not clipped to
rounded border corners.
(This was done before but worked only in simple cases)
See: #19649

This solves the following issues:
closes #19626
closes #16657
closes #19482 (examples from http://lea.verou.me/css3patterns/ are rendered perfectly but the round border is completely ignored now)
closes #19577

- `./mach build -d` does not report any errors
- `./mach test-tidy` does not report any errors

I enabled a few tests with the first commit but I have written about a dozen manual tests I will try to turn into ref tests either before or after this patch lands.

@bors-servo try

The relationship between the different inputs is visualized in this flowchart:
![flowchart-background](https://user-images.githubusercontent.com/2781017/34394430-5a06c72c-eb59-11e7-9d51-3d23e2215f07.png)

Source-Repo: https://github.com/servo/servo
Source-Revision: 691bff86b6f57da37c2e0af99aa7f72fc1b4f9d6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4f9cad4730e7c98c724e7dedc48b8f7bb7ba8cce
2018-01-02 08:47:24 -06:00
Boris Chiou
2bc354c080 servo: Merge #19607 - hashglobe: Dump the requested aligment if out of memory while allocating a table (from BorisChiou:stylo/crash/out_of_memory_alignment); r=emilio
This is for Bug 1418806 and Bug 1416903. We need not only the requested size
but also the requested alignment for debugging.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 27a443fbaaf3e19fa3a753f68b20a7a7ccc5d199

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fa754d106c4d47fd89f89a46df704c85387722bd
2018-01-01 21:32:59 -06:00
CYBAI
2ff1e2200e servo: Merge #19659 - style: Move display outside of mako (from CYBAI:display-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19658
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 2a139cebacc02b3ae04974e1e5b2b601df5b774c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 77c791f1c8ee001deef16ed754ca3200ddcbee77
2018-01-01 12:14:39 -06:00
Pyfisch
643bbbf5a0 servo: Merge #19652 - Fix division by zero in gradient stop calculation (from pyfisch:issue18435); r=emilio
Check if total_length is zero and return 0.0 instead
of NaN in this case.

Closes #18435

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18435 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [x] These changes do not require tests because simple bugfix/no idea for good test

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1ce6d8ea2d2bbb4d6f095ac62514eca942599e83

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e30331dc8bdbe4af4687be81956e31850d4e5613
2018-01-01 09:38:07 -06:00
Pyfisch
12c64e4849 servo: Merge #19655 - Remove solved FIXMEs about border radii (from pyfisch:border-radii-comments); r=emilio
cc pcwalton

cgaebel: Is this [comment] still accurate?

    // TODO(cgaebel): Support border radii even in the case of multiple border widths.
    // This is an extension of supporting elliptical radii. For now, all percentage
    // radii will be relative to the width.

[comment]: 446536b9c3/components/layout/display_list_builder.rs (L659-L661)

Source-Repo: https://github.com/servo/servo
Source-Revision: 657d8a2ede97e7f7fedee5ada97c833abe5a8d9e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 17007da85fd7ed378445e95ab4a1cc745f54ecd7
2018-01-01 08:19:36 -06:00
Emilio Cobos Álvarez
1795108268 servo: Merge #19667 - Revert #19666 since we do create NAC elements and expect them to be inline (from emilio:root-and-item); r=emilio
This reverts commit 1970e82b0d310128eabe8466d39d42cc20e7ae4b, reversing
changes made to e882660ea694f9f12d9d2936012dbdf192f8aec8.

The reparenting logic is still bogus, but I'll figure out how to deal with that
in a bit.

Source-Repo: https://github.com/servo/servo
Source-Revision: be7d13e37fad6eb594a7b8c8ec9b07fa0df11116

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6466a27a0b5271a78c3d00357de1db4e14495b17
2017-12-31 10:01:58 -06:00
Emilio Cobos Álvarez
4291ece36d servo: Merge #19666 - style: Simplify the skip item based display fixup adjustment (from emilio:root-and-item); r=upsuper
In practice the only NAC that possibly inherits from a grid or flex container
are pseudos.

In Gecko, if the root element is an item container, custom anon content would
also sometimes incorrectly inherit from that (see bug 1405635), but that's fixed
in Stylo.

We remove the IS_ROOT_ELEMENT blockification from the "skip display fixup"
check, since the root element is never NAC or anything like that, so there's no
need for the check.

This also fixes some reparenting fishiness related to pseudo-elements. We were
only skipping the fixup when reparenting anon boxes, not when reparenting normal
element styles, nor when reparenting other pseudo styles which are not anon
boxes.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1970e82b0d310128eabe8466d39d42cc20e7ae4b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6633420bdbfffc8a284fa7d804cb48ed0ab20cae
2017-12-31 07:01:10 -06:00
Emilio Cobos Álvarez
adbbb69afb servo: Merge #19664 - style: Stop duplicating slots (from emilio:dupe-slots); r=smaug
Reland of #19660 since it was backed out for not landing its Gecko changes on time.

Bug: 1427001
Reviewed-by: smaug
MozReview-Commit-ID: Cq647BcOzbe
Source-Repo: https://github.com/servo/servo
Source-Revision: e882660ea694f9f12d9d2936012dbdf192f8aec8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6c1039bb1853cd340a0170a73d43f8d4331e7bcc
2017-12-31 05:13:47 -06:00
Emilio Cobos Álvarez
04be6ceded servo: Merge #19665 - style_derive: Support parse-time aliases (from emilio:derive-parse-alias); r=Manishearth
This will allow #19659 to use derive on display using:

    #[parse(aliases = "-webkit-flex")]
    Flex,
    #[parse(aliases = "-webkit-inline-flex")]
    InlineFlex,

And such.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4ba795081cd1efa42ce03c996d574cfe96f68ece

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7157dd2b10e6e39595ae090ad40219fd012b7baf
2017-12-31 03:46:22 -06:00
Emilio Cobos Álvarez
2facd37693 servo: Merge #19662 - style: Simplify "prohibit display: contents" adjustment (from emilio:simplify-prohibit-display-contents); r=upsuper
On top of #19661.

The NAC condition is pointless because NAC don't match author rules unless they
are a pseudo-element too.

Source-Repo: https://github.com/servo/servo
Source-Revision: ebff37b80720447044cc38553558e8339512144f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 12bd00a0a939f3b61b22f1db2073dc49e4c58f9b
2017-12-31 02:23:59 -06:00
Narcis Beleuzu
e9ee243a5f Backed out changeset dda1c7951937 for build bustage force-cargo-library-build. r=backout on a CLOSED TREE 2017-12-31 03:15:56 +02:00
Emilio Cobos Álvarez
42b7b3a0a0 servo: Merge #19660 - style: Stop duplicating slots (from emilio:dupe-slots); r=smaug
Bug: 1427001
Reviewed-by: smaug
MozReview-Commit-ID: Cq647BcOzbe
Source-Repo: https://github.com/servo/servo
Source-Revision: d3f603ecbae8c55062142d3979f433a1b6b903a4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 50a7494bbf13646ba014d3a1ca4c8784986086bb
2017-12-30 17:31:38 -06:00
Emilio Cobos Álvarez
9bd39a3393 servo: Merge #19661 - style: Simplify ::-moz-fieldset-content special-casing (from emilio:simplify-fieldset-contents); r=upsuper
The style adjuster knows about the pseudo, so there's no reason to thread that
info down.

There are more simplifications that can be done in followups, cleaning a bit the
cascade flags too, those will come later.

Source-Repo: https://github.com/servo/servo
Source-Revision: fb569f9c159627a058b902bfe820f55c2657e590

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9edac6e97fe86837e59d333cb2ce084cda2ab083
2017-12-30 15:12:23 -06:00
CYBAI
bfd346cb0b servo: Merge #19646 - style: Move touch-action outside of mako (from CYBAI:move-touch-action-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19645
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 446536b9c34b331f5466bfb212be8cb1faa2dee8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 95d2c35265415ad7c93319d1364efa59f49cdaad
2017-12-29 06:08:33 -06:00
tigercosmos
18dd2a1cb6 servo: Merge #19628 - add note on readme (from tigercosmos:x3); r=KiChjang
<!-- Please describe your changes on the following line: -->
Add note about how to use command while running servo
origin  `readme` is not clear.
I think ./mach run [url] [arguments] is more clear than ./mach run [url]

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 97bba5fdc16b4902df4280ec27682a0fa160bc41

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e5d55c23f7490a07f83eaa46b867ded0a523bd3b
2017-12-25 15:08:39 -06:00
tigercosmos
aa58e15a76 servo: Merge #19622 - pretty print tree (from tigercosmos:x2); r=shinglyu
<!-- Please describe your changes on the following line: -->
```
│  │  │  │  │  │  │         floatspec-out=L 0px R 0px
│  │  │  │  │  │  │         overflow=Overflow { scroll: TypedRect(0px×0px at (0px,0px)), paint: TypedRect(0px×0px at (0px,0px)) }
│  │  │  │  │  │  │         damage=BUBBLE_ISIZES
│  │  │  │  │  │  │  └─ ↑↑ Fragment for block:
│  │  │  │  │  │  │  │         SpecificFragmentInfo::Table(2671) []
│  │  │  │  │  │  │  │         border_box=LogicalRect(H LTR, i0px×b0px, @ (i0px,b0px))
│  │  │  │  │  │  │  │         damage=REPOSITION | STORE_OVERFLOW | BUBBLE_ISIZES | REFLOW_OUT_OF_FLOW | REFLOW
│  │  │  │  ├─ Block(1268a9710)
│  │  │  │  │         sc=StackingContextId(0)
│  │  │  │  │         pos=LogicalRect(H LTR, i720px×b36px, @ (i152px,b2636.883333333333px))
│  │  │  │  │         floatspec-in=L 0px R 0px
│  │  │  │  │         floatspec-out=L 0px R 0px
│  │  │  │  │         overflow=Overflow { scroll: TypedRect(750px×36px at (-15px,0px)), paint: TypedRect(750px×36px at (-15px,0px)) }
│  │  │  │  │         children=1
│  │  │  │  │         damage=BUBBLE_ISIZES
│  │  │  │  │  ├─ ↑↑ Fragment for block:
│  │  │  │  │  │         SpecificFragmentInfo::Generic(2673) []
│  │  │  │  │  │         border_box=LogicalRect(H LTR, i720px×b36px, @ (i0px,b0px))
│  │  │  │  │  │         border_padding=LogicalMargin(H LTR, i:0px..0px b:6px..0px)
│  │  │  │  │  │         damage=REPOSITION | STORE_OVERFLOW
│  │  │  │  │  ├─ Block(128554f10)
│  │  │  │  │  │         sc=StackingContextId(0)
│  │  │  │  │  │         pos=LogicalRect(H LTR, i750px×b30px, @ (i0px,b6px))
│  │  │  │  │  │         floatspec-in=L 0px R 0px
│  │  │  │  │  │         floatspec-out=L 0px R 0px
│  │  │  │  │  │         overflow=Overflow { scroll: TypedRect(750px×30px at (-15px,0px)), paint: TypedRect(750px×30px at (-15px,0px)) }
│  │  │  │  │  │         children=6
│  │  │  │  │  │         damage=BUBBLE_ISIZES
│  │  │  │  │  │  ├─ ↑↑ Fragment for block:
│  │  │  │  │  │  │         SpecificFragmentInfo::Generic(2361) []
│  │  │  │  │  │  │         border_box=LogicalRect(H LTR, i750px×b30px, @ (i-15px,b0px))
│  │  │  │  │  │  │         margin=LogicalMargin(H LTR, i:-15px..-15px b:0px..0px)
│  │  │  │  │  │  │         damage=REPOSITION | STORE_OVERFLOW
│  │  │  │  │  │  ├─ TableWrapperFlow: Block(128555410)
│  │  │  │  │  │  │         sc=StackingContextId(0)
│  │  │  │  │  │  │         pos=LogicalRect(H LTR, i750px×b0px, @ (i-15px,b0px))
│  │  │  │  │  │  │         floatspec-in=L 0px R 0px
│  │  │  │  │  │  │         floatspec-out=L 0px R 0px
│  │  │  │  │  │  │         overflow=Overflow { scroll: TypedRect(0px×0px at (0px,0px)), paint: TypedRect(0px×0px at (0px,0px)) }
│  │  │  │  │  │  │         children=1
│  │  │  │  │  │  │         damage=BUBBLE_ISIZES
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12675 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7aae164fcdb8ab308bfa0806e1123e9b7eb73a7c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ce4a8508aef07608aa4f7c7a530c422a7acccbf2
2017-12-25 07:56:42 -06:00
tigercosmos
26524a9831 servo: Merge #19642 - cleanup no need cfg target_os (from tigercosmos:c1); r=emilio
<!-- Please describe your changes on the following line: -->
Already in macos, no need cfg target_os

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d49cb8a47812c0e8ae25643e5437e212f5cbee16

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b8fbbea34c7660db93f1de9b6220c57e55cf336f
2017-12-25 05:12:41 -06:00
Emilio Cobos Álvarez
0784fd2551 servo: Merge #19641 - style: Some trivial cleanup (from emilio:christmas-cleanup); r=cybai
Source-Repo: https://github.com/servo/servo
Source-Revision: d96fb89c3118ff12142397f25d1546235515ec14

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 09c4f9ca6645326975b3579f7358ede152d402f0
2017-12-24 21:34:21 -06:00
Jon Leighton
04c93db31f servo: Merge #19636 - Move list-style-type outside of mako (from jonleighton:issue-19629); r=emilio
Closes issue #19629

r? emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 9a207d17c57cb8133b198933f754989358b7638e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5bc86a773ea499f07b74634ed9509c596d680549
2017-12-24 14:08:55 -06:00
tigercosmos
20148744de servo: Merge #19633 - pass -vv through mach to cargo (from tigercosmos:vv); r=emilio
<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7c07f31a55e3d6f156e8fa8360eb804f323a0cb1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 80c479fc7627f27e21df34ffd61edf4aed7c6dae
2017-12-24 12:39:34 -06:00
Emilio Cobos Álvarez
691ff85bf1 servo: Merge #19640 - tests/net: Update testing cert (from emilio:testing-cert); r=emilio
Fies #19634

Source-Repo: https://github.com/servo/servo
Source-Revision: a2d8e0c79e880ef94e2ba368bb3c9744b98b3ea1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3caff93b2a9e1bc4cfab7aa8ed38e2244d845c54
2017-12-24 08:53:29 -06:00
Yati Sagade
cda0c94d8c servo: Merge #19256 - Paint worklets: Implement timeout for worklet painter threads (from yati-sagade:master); r=asajeffrey
When a paint worklet thread takes too long, we would like to move on,
since we have a ~16ms budget for rendering at 60fps. At the moment, there
is no provision in the paintworklet spec to signal such timeouts to the
developer. ajeffrey opened an [issue][1] for this, but it got punted to
v2 of the spec. Hence we are silently timing out unresponsive paint
scripts.

The timeout value is chosen to be 10ms by default, and can be overridden
by setting the SERVO_PAINT_WORKLET_TIMEOUT_MS environment variable.

In the absence of such a timeout, the reftest in this commit would fail
by timing out the testrunner itself, since the paint script never
returns. From my discussions with ajeffrey, this should do until we spec
out a way to signal timeouts to the script developer.

This fixes #17370.

[1]: https://github.com/w3c/css-houdini-drafts/issues/507

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 54f8cc37c5a7874607128e3518fd0982f7065565

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0234a7fd5437d1c2a9c0424b9e2bb51d309a4490
2017-12-22 04:50:16 -06:00
tigercosmos
7be35fc71a servo: Merge #19612 - deny warnings (from tigercosmos:o1); r=jdm
<!-- Please describe your changes on the following line: -->
deny warnings
related to #19573

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #19572 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 2eb1512c22e7d79a4c6af70af7aec53f4b18cac2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : dbac199ced6f23c0e3c360d9c814585837e1389d
2017-12-21 13:57:04 -06:00
石博文
11a1f0db42 servo: Merge #19621 - using local variable instead of a function call (from sbwtw:using_variable); r=jdm
the data of `frame_size` is already storage into variable `new_frame_size`

Source-Repo: https://github.com/servo/servo
Source-Revision: a15cecb3f792d4807ec8b271369fa85bb35924b5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2974cde355ad39b3e7baee4fde7e97efb2f940df
2017-12-21 08:53:21 -06:00
Emilio Cobos Álvarez
c15479b46f servo: Merge #19620 - style: Make sure to honor parse_method in transition and animation shorthands (from emilio:parse-transition-longhand); r=bbirtles
Reviewed-by: birtles
Bug: 1426312
MozReview-Commit-ID: HY3jtdSdaga
Source-Repo: https://github.com/servo/servo
Source-Revision: e983a5e982df6f5c4725d5f35a31efb7769be43d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d7e25fd32405e43067a8ef09e21eb63d6b34fd0c
2017-12-21 07:01:59 -06:00
Xidorn Quan
73b4f1fe9b servo: Merge #19618 - Convert NS_STYLE_BORDER_IMAGE_REPEAT_* to an enum class (from upsuper:border-image-repeat); r=emilio
This is the Servo side change of [bug 1325940](https://bugzilla.mozilla.org/show_bug.cgi?id=1325940).

Source-Repo: https://github.com/servo/servo
Source-Revision: df0f9ad7ae6f10ffeaf5d40f4a2a25abadabf9cc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : dc0415a53f03159e7a0e9c79021187822ee9169b
2017-12-21 01:34:04 -06:00
Emilio Cobos Álvarez
77db25b297 servo: Merge #19617 - style: Fix inheritance of animation and transition properties of mismatched length (from emilio:inherit-animation-stuff); r=hiro
At least when the animation-name length is bigger than the animation properties,
we mess up inheritance and only set properly the specified counts, then don't
cycle it.

The nicer fix for this is making these vectors properly, and move the cycling
logic at used-value time (bug 1420928). Same for transitions.

Bug: 1426246
Reviewed-by: hiro
MozReview-Commit-ID: 3cguzIvfMFU
Source-Repo: https://github.com/servo/servo
Source-Revision: 9a4a2b07aa15efe3c41debb3ec199557694c4d62

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : dceaa7f7ba61fc5fcbc998f14ec4950bdab055ba
2017-12-21 00:10:49 -06:00
Emilio Cobos Álvarez
7048b0b8b9 servo: Merge #19615 - style: Remove needless and bogus bounds-check (from emilio:useless-check); r=KiChjang
The check should read index >= self.len(). But it doesn't matter anyway since
we're covered by Rust's bound checks by default anyway.

Source-Repo: https://github.com/servo/servo
Source-Revision: 6524d2281453da816c532dc83a522331df8ce9c0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a5fd5040f80563badd67ac7e65b36511454fbe49
2017-12-20 21:23:29 -06:00
Emilio Cobos Álvarez
29d3ec75ba servo: Merge #19613 - style: Workaround a likely valgrind false-positive (from emilio:slotted-list); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: fd6847fd764c423b8952d59179f5c08ebec185c5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 93b75b5ad69220b68f23997eba2245f093a2a825
2017-12-20 17:08:30 -06:00
Igor Matuszewski
da9941ddbc servo: Merge #19611 - Bump mozjs to 0.1.9 (from Xanewok:bump-mozjs); r=jdm
<!-- Please describe your changes on the following line: -->

Bumping rust-mozjs, which was updated in tandem ([here](f9664091b1)) with https://github.com/servo/servo/pull/19487, but the new version wasn't pulled in here.

r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it only bumps used crate minor version.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dfd8e85338fb5460d800577d5761e979644dc869

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 085ce92b97b22c82371f547d8a1a5bb3baa598a3
2017-12-20 12:09:20 -06:00
Emilio Cobos Álvarez
330618653c servo: Merge #19610 - style: Don't support a list of selectors in ::slotted yet (from emilio:slotted-list); r=xidorn
Bug: 1425757
Reviewed-by: xidorn
MozReview-Commit-ID: G0I0gM2sWTh
Source-Repo: https://github.com/servo/servo
Source-Revision: e074a1c62012e966b499d797b49b2efc08fe4007

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8a3c314a43a335edc25f18b613c49b1eef954bb3
2017-12-20 11:09:50 -06:00
tigercosmos
ef5210faf4 servo: Merge #19609 - remove unsued IpcReceiver (from tigercosmos:q1); r=emilio
<!-- Please describe your changes on the following line: -->
```
warning: unused import: `IpcReceiver`
  --> components/canvas/canvas_paint_thread.rs:14:41
   |
14 | use ipc_channel::ipc::{self, IpcSender, IpcReceiver};
   |                                         ^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default
```

recently I have done similar commits for three times
Shall we merge #19573?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8f786d4e964ee67f80462e8af9cef1e2bbd328a2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3e9d77cfb8b7acd85f0a3d3610ad7242162100c9
2017-12-20 09:11:56 -06:00
Glenn Watson
1d8b968345 servo: Merge #19606 - Update WR (fix incorrect rendering of small box shadows) (from glennw:update-wr-bs-artifacts); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: c2cacb69f3d69d2db0db23f7f46eaabf555cb2be

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f4dd80185f8c97c8d742b18875a4a77df05aa832
2017-12-19 15:40:26 -06:00
Emilio Cobos Álvarez
7d692c9098 servo: Merge #19579 - Bug 1417725 - (Servo) Add -moz-column-span alias for column-span prop… (from neerjapancholi:master); r=emilio
…erty.

<!-- Please describe your changes on the following line: -->
This is part of the patch for adding a -moz- alias for column-span. See https://bugzilla.mozilla.org/show_bug.cgi?id=1417725
Clean try run for this patch is at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=faa9c050c9adf10714953b8c5d5af67683992437&selectedJob=151353901

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 873bc3a726a7677564730b3d73ca107ca76dc365

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 229ff35becf444d8975c127271de0f39dfa9f0e1
2017-12-19 14:13:32 -06:00
Manish Goregaokar
6e2cf9edf4 servo: Merge #19604 - stylo: Correctly handle interpolation where optional second argument for translate(), skew(), scale() exists in one but not the other (from Manishearth:animate-second); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1424798

Source-Repo: https://github.com/servo/servo
Source-Revision: 861ceb10eadcd8e73c54a85336d081432813b2b1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e88c7957592ff4b343d51f4d6cda72ae96e21722
2017-12-18 20:46:31 -06:00
Emilio Cobos Álvarez
fbfdcd0795 servo: Merge #19601 - style: Don't adjust :visited styles (from emilio:adjust-visited); r=upsuper
As the comment says those are not interesting, and it matches what we do for
text and placeholders in Servo_ComputedValues_Inherit.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425893

Source-Repo: https://github.com/servo/servo
Source-Revision: d6797db10054dd42a7e96ce2ca8198838b068c81

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 73cf2966d38e6159a3558b735a6bf5a36ab334d1
2017-12-18 18:00:27 -06:00
Alan Jeffrey
eb6f86f0a5 servo: Merge #19528 - Capture loadEventEnd in test-perf (from asajeffrey:test-perf-measure-loadEventEnd); r=avadacatavra
<!-- Please describe your changes on the following line: -->

Capture perf-test data after the load event has finished firing.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 89f9af88a31e4b07609658545f1c2bf6878a2acc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 27f95833b3a94cb3f8e1f5e1e658721634932ad5
2017-12-18 16:54:07 -06:00
Glenn Watson
82c17eef7c servo: Merge #19600 - Update WR (sticky frame fixes, handling overlapping border corners) (from glennw:update-wr-border-sticky); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 7fb6b9fcaed91dbffb8385d01d18de79d889f462

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f17d8974d74298cb06e97db53d946ba2e2f260ae
2017-12-18 15:38:13 -06:00
Alan Jeffrey
2cf50232b2 servo: Merge #19574 - Downgrade to rustc nightly-2017-11-14 (from asajeffrey:rustdown-2017-11-14); r=glennw
<!-- Please describe your changes on the following line: -->

This is causing nightly servo to crash with hardware acceleration.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes work around #19519
- [X] These changes do not require tests because testing requires AWS instances with GPUs.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 57277acd27968df6323fa925d149f9a8c1c3f0cc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e627c7f86160f7d25e7a1d4808c2948c67772480
2017-12-18 13:59:23 -06:00
Nazım Can Altınova
af3cd13ada servo: Merge #19576 - style: Move text-align outside of the mako file (from canaltinova:text-align); r=Manishearth,emilio
I will need this refactoring before my next job. I didn't actually fix the FIXME's along the way. My other PR probably will cover these.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: a9c17970c19a993920ce1ba2ff9faebd033c52b4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8ee32ab5b3c274a73fb1f27fe2a85c78a47ae30d
2017-12-18 12:12:52 -06:00
Marcin Mielniczuk
b0146307d8 servo: Merge #19545 - Fix and document build on CentOS 7.4 (from marmistrz:bump-gecko-media); r=jdm
Fix and document build on CentOS 7.4

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable). **N/A**

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no code is changed

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 92a2c37e65691a43ad57ee712e271d85c1856163

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 753fc20eb0a8764d0c0c7abf55150835fff9742f
2017-12-18 11:19:40 -06:00
Josh Matthews
ac9391b620 servo: Merge #19599 - Revert canvas IPC changes (from jdm:revertcanvas); r=asajeffrey
https://github.com/servo/servo/pull/19547 is responsible for the surge of new intermittent timeouts in canvas-related tests. There's nothing wrong with the change, so I suspect an underlying problem in ipc-channel instead.

Fixes #19592. #19593. Fixes #19594. Fixes #19597.

Source-Repo: https://github.com/servo/servo
Source-Revision: 37fe9f29573e669ea9dd86ed6d9de0e43b3f746d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 84f6a3819cb33421e270a2a8bbd6b62dcf0e9afb
2017-12-18 10:19:30 -06:00
Emilio Cobos Álvarez
a4ae45ac68 servo: Merge #19595 - style: Add a FIXME comment that I need to write a test-case for (from emilio:broken-code-all-around); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: fab8042fa73ff326a0fa5c65863434eac0070ac1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 23fdd1f370979cb387cc6deb1eadfe0be98eeff2
2017-12-18 07:24:13 -06:00
Simon Sapin
200ff11a39 servo: Merge #19590 - Use [patch] instead of [replace] (from servo:patch); r=SimonSapin
CC https://github.com/servo/webrender/pull/2215

Also, `[replace]` prevented using `[patch]` for other crates. (Cargo forbids using both.)

Source-Repo: https://github.com/servo/servo
Source-Revision: 3a37d8093108b66fb3edc212c97551738450c402

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 446a416f4a7c2e85487eb7cc00731adf09d7982a
2017-12-17 15:18:05 -06:00
tigercosmos
4ec4c9eede servo: Merge #19589 - remove unused Auto in test of serialization (from tigercosmos:e1); r=emilio
<!-- Please describe your changes on the following line: -->
```
warning: unused import: `Auto`
 --> /Users/tigercosmos/servo/tests/unit/style/properties/serialization.rs:9:40
  |
9 | use style::values::{CustomIdent, RGBA, Auto};
  |                                        ^^^^
  |
  = note: #[warn(unused_imports)] on by default
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: f17564926300e759d38f4ebdf0eefd064357af3f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9eaaf02d839c57eb3aaf95a98dcb12394b3602d0
2017-12-17 11:51:10 -06:00
tigercosmos
cd78f6e385 servo: Merge #19559 - implement valid week string (from tigercosmos:t1); r=KiChjang
<!-- Please describe your changes on the following line: -->
implement valid week string
part of #19172

r? @KiChjang

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8798e498892524ebb42ab8d7613c68033fdd1db8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5b0f9bb1d931cecf47f47da8af052740494cd1bd
2017-12-17 03:50:33 -06:00
tigercosmos
436cad9fed servo: Merge #19585 - remove unused self in canvas_paint_thread (from tigercosmos:b1); r=KiChjang
<!-- Please describe your changes on the following line: -->
```
Compiling canvas v0.0.1 (file:///Users/tigercosmos/servo/components/canvas)
warning: unused import: `self`
  --> components/canvas/canvas_paint_thread.rs:14:24
   |
14 | use ipc_channel::ipc::{self, IpcSender, IpcReceiver};
   |                        ^^^^
   |
   = note: #[warn(unused_imports)] on by default
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: f8c09abece5c4952d786ae843900b0135468f7c5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5ad8d7ea63ef451313cdb8171d6dc6a4d0edfaf5
2017-12-17 02:47:09 -06:00
CYBAI
08b5d999f0 servo: Merge #19583 - style: Move will-change outside of mako (from CYBAI:move-will-change-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19582
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 8aba41d951d63a09cc6c12cba7ed200ea4396544

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 24b27ac8fd2e837f365610ecd737993588b6ea98
2017-12-16 16:39:37 -06:00
Emilio Cobos Álvarez
6a04994e12 servo: Merge #19584 - style: Remove the grid pref (from emilio:remove-grid-pref); r=mats
Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze
Source-Repo: https://github.com/servo/servo
Source-Revision: 1501a417044061126401d96f236631c97d4e1946

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5e4997020d3b10b205ac8a66b86cde69b5e238ab
2017-12-16 15:44:21 -06:00
tigercosmos
25eac1e745 servo: Merge #19547 - Send IPC receiver for canvas as part of CreateCanvasPaintThread message (from tigercosmos:b1); r=jdm
<!-- Please describe your changes on the following line: -->
I am not sure if @jdm want this.
r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19483(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: c9e3fabdfd0d4c900e83a1050ec465303e339681

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6aa288e249807e1eae78d5900427d8f72414a4ee
2017-12-16 11:35:40 -06:00
Emilio Cobos Álvarez
6f65825326 servo: Merge #19581 - style: Fix grid line serialization to avoid redundant spacing (from emilio:grid-line-serialize); r=canaltinova
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425227.

Source-Repo: https://github.com/servo/servo
Source-Revision: a31fd24ce93f3a8bde1b56e01109ee3b94532e0d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ad4c63f930027b6a896a3439e2af453140b63db7
2017-12-16 09:13:48 -06:00
Brian Birtles
f464fbbad3 servo: Merge #19580 - Update references to Web Animations spec (from birtles:update-web-animations-link); r=hiro
This has been reviewed in [Gecko bug 1425548](https://bugzilla.mozilla.org/show_bug.cgi?id=1425548).

Source-Repo: https://github.com/servo/servo
Source-Revision: f7440bf1a68cd0beaf12621c9c460c6f6ddc57e3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : be54a712cafe4eb7fb42bc073bd687f6fd0220cb
2017-12-15 17:39:55 -06:00
Pyfisch
238056272d servo: Merge #19568 - layout: background-origin attribute for gradients (from pyfisch:background-origin-gradients1); r=mbrubeck
Fixes the glitches mentioned in #19554.
Now gradient tiles are placed in the whole bounding box.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dbfcb7bc39715211928a550d2807cb2ba1e161e7

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ebd1706316e9488589f7f82d3db4014dc01956bd
2017-12-15 15:54:59 -06:00
Emilio Cobos Álvarez
42677736f2 servo: Merge #19578 - Allow deriving Parse on keywords (from emilio:parse-keyword); r=Manishearth,canaltinova
This makes patches like #19576 much easier.

Source-Repo: https://github.com/servo/servo
Source-Revision: e631d167bf28676e45e37f418b4282fcfba98c1e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9668fc507960090009446afb651e5742d54b9f30
2017-12-15 14:55:49 -06:00
Matt Brubeck
8172baeffb servo: Merge #19565 - Turn flow::base and friends into methods (from mbrubeck:base); r=emilio
This feels more idiomatic in modern Rust, and replaces code like this:

`flow::base(&**root_flow).restyle_damage`

with this:

`root_flow.base().restyle_damage`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are refactoring only

Source-Repo: https://github.com/servo/servo
Source-Revision: 53968fef6112a3c934d527e4034d53b7a6174721

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f2f831dc700343ba9a03a977ad847938174d490d
2017-12-15 12:44:50 -06:00
Emilio Cobos Álvarez
8afea3a742 servo: Merge #19564 - style: Slightly simplify push_applicable_declarations (from emilio:push-applicable-simple); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 90290cfafed0bff88920fd286ea09656fd9e999f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : df82fcbf35663f58f655981884d3f16fc454bd40
2017-12-15 11:28:16 -06:00
Felipe Nakandakari
1e31306380 servo: Merge #19570 - style: move list-style-image out of mako (from fenak:list-style-image-mako); r=emilio
<!-- Please describe your changes on the following line: -->
Moving `list-style-image` out of mako.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19557  (part of #19015 ).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: da3dd05ff98dd2b4c0a9c399d03d6b774e8d6553

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7aadbd628e82b5320d6f5e8a51314b57ef6f92db
2017-12-14 23:36:34 -06:00
Alan Jeffrey
832283ef24 servo: Merge #19569 - Add a topLevelDomComplete metric (from asajeffrey:script-perf-measure-topLevelDomComplete); r=jdm
<!-- Please describe your changes on the following line: -->

Measure DOM completion without iframes. This is in support of measuring when the main document is loaded, ignoring secondary content, e.g. ads.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19561
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d832e1b8f843612b4cb124d8c4eb9dce94e92d50

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 377138e2fc2d7d65866ba238978ba0e30ae910b0
2017-12-14 17:02:44 -06:00
E. Dunham
7fee5cc08f servo: Merge #17580 - Add rudimentary .taskcluster.yml (from edunham:taskcluster); r=aneeshusa
Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the
linux-dev builder in etc/ci/buildbot_steps.yml, but with the real parts
commented out for speed during the testing process.

r? @aneeshusa

I got the first-draft image built and pushed to docker hub at https://hub.docker.com/r/servobrowser/servo-linux-dev which is what this is set to pull from.

cc @gregarndt @imbstack

Source-Repo: https://github.com/servo/servo
Source-Revision: 7897bd15d7df2f27b70d5ef7597458ecf296fdba

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : bcf187dd5d64cd9273ce48f612d88fd5dc28f98a
2017-12-14 14:23:58 -06:00
Pyfisch
b2df8f0384 servo: Merge #19554 - layout: support tiled gradients (from pyfisch:tiled-gradients1); r=mbrubeck
Use background-size, background-position properties to render
CSS gradients.

Some cleanup in display_list_builder.rs related to gradient
calculations.

Adds two wpt tests for tiled gradients.

Note: For now even gradients with background-repeat: no-repeat
are repeated. Sometimes the gradient is not repeated everywhere.

Resolves partially #19482. (See the mentioned website for example gradients with these features)
See also: #16657 and #10412

Some glitches can be seen in the attached file. I am unsure what the exact intended semantics of [`push_gradient`](https://doc.servo.org/webrender_api/struct.DisplayListBuilder.html#method.push_gradient) are and want to ask the webrender team before building in "workarounds" for the missing gradients.
![half-rhombes](https://user-images.githubusercontent.com/2781017/33958051-b16f964a-e043-11e7-8218-b28388e2cf8d.png)

Source-Repo: https://github.com/servo/servo
Source-Revision: 6ee8e6a1684d6dbc65933da11ce1a2c8ba660442

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 96cc2524eaba5602eba84d6aa314e5ddaa9a9dc1
2017-12-14 13:20:34 -06:00
Matt Brubeck
cf3a9680c8 servo: Merge #19562 - Make layout depend on style/servo feature (from mbrubeck:feature); r=emilio
This fixes an error when running commands like `./mach check -p layout`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they change build metadata only

Source-Repo: https://github.com/servo/servo
Source-Revision: bc9062b689706f481f5865e38e856cce0eeccb61

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e59c9eb9a54d3095ba945500deb80efd404e1f8b
2017-12-14 11:55:25 -06:00
Emilio Cobos Álvarez
232ec02559 servo: Merge #19558 - selectors: Manually inline any(..) in matches_selector_list (from emilio:sadness); r=heycam
Since the compiler refuses to inline the inner closure even with -O3, which is
sad :(.

Sad try run:

  https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=c2724c47e98f990826327da05220cd83b772d144&newProject=try&newRevision=52ac88b40a08a5ef6a629bd681f2e5a444b75f54&framework=1

Source-Repo: https://github.com/servo/servo
Source-Revision: 370f5acf6dcf2fa2b4755105376302b41a88fed3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c9111fe877a9e1d7893c91f13be33fded64acbe9
2017-12-14 10:19:23 -06:00
Emilio Cobos Álvarez
a0e7854c60 servo: Merge #19556 - Move list quotes out of mako (from emilio:quotes-mako); r=emilio
Rebase of https://github.com/servo/servo/pull/19154.

Source-Repo: https://github.com/servo/servo
Source-Revision: 26feea3be5bc70fed7a642ca768187d29469fee0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7e29dfb2e654d65b512942e77f2bb48c449df9b9
2017-12-14 01:39:38 -06:00
Emilio Cobos Álvarez
7e7d23433a servo: Merge #19541 - selectors: Add parsing support for ::slotted() (from emilio:parse-slotted); r=heycam
Without turning it on yet, of course.

The reason why I didn't use the general PseudoElement mechanism is because this
pseudo is a bit of its own thing, and I found easier to make ::selectors know
about it (because you need to jump to the assigned slot) than the other way
around.

Also, we need to support ::slotted(..)::before and such, and supporting multiple
pseudo-elements like that breaks some other invariants around the SelectorMap,
and fixing those would require special-casing slotted a lot more in other parts
of the code.

Let me know if you think otherwise.

I also don't like much the boolean tuple return value, but I plan to do some
cleanup in the area in a bit, so it should go away soon, I'd hope.

Source-Repo: https://github.com/servo/servo
Source-Revision: f5129ef7b5efa59a176cac98dc68d910cb3279c9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5f956f568b12d8aa7611bc05ac7b1d1497689189
2017-12-14 00:22:45 -06:00
Emilio Cobos Álvarez
750fde1fd6 servo: Merge #19551 - style: Make anon boxes account for :visited (from emilio:anon-box-visited); r=heycam
This should fix one of the test failures of:

  https://bugzilla.mozilla.org/show_bug.cgi?id=616436

Source-Repo: https://github.com/servo/servo
Source-Revision: c258bfb430fabc2ebc55db679a52f09c7df04b58

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : be8406d2a2836f38ebf74b0814cca306b2f023f7
2017-12-13 22:47:38 -06:00
Emilio Cobos Álvarez
f0d9de7275 servo: Merge #19539 - mach: Fix cargo-geckolib check / cargo-geckolib build after #19476 (from emilio:cargo-geckolib); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 11d32d8800dcd32834961ee4013cd58a718d3762

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f0a1de1bcedf2c27524732723afd4475b82cceb0
2017-12-13 20:26:43 -06:00
CYBAI
1fe45bc205 servo: Merge #19548 - style: Move outline-style outside of mako (from CYBAI:move-outline-style-out-of-mako); r=emilio
This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19546
- [x] These changes do not require tests

Source-Repo: https://github.com/servo/servo
Source-Revision: 714c1b2455bc6f651e982b5efec85e3bf711f708

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c435362b7e4d8abcae2548a7bfd07e7e77328e8a
2017-12-13 19:30:26 -06:00
Glenn Watson
b35fce9024 servo: Merge #19552 - Update WR (fix transformed primitives with hidpi) (from glennw:update-wr-fixes); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 8ca43e41efca61b015c47f4d109c4d49b2a4ea0b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e78437976056ec4abb520092d76bb0723be02716
2017-12-13 11:20:12 -06:00
Alan Jeffrey
2c43d71711 servo: Merge #19507 - Add a --date option to test-perf (from asajeffrey:test-perf-date-option); r=avadacatavra
<!-- Please describe your changes on the following line: -->

To generate old test-perf results, we need a way to set the date when running `./mach test-perf`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they're test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: b93579a8f0e59c8102a243133455d8012e82e415

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0d2ca17707b8299fe0232a605741a6bea14661bd
2017-12-12 13:52:59 -06:00
Manish Goregaokar
c9afd2ae75 servo: Merge #19549 - Add telemetry probe for measuring frequency of parallel restyles (from Manishearth:telemetry); r=emilio
Servo side of https://bugzilla.mozilla.org/show_bug.cgi?id=1421195

r=emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 80341b291b3c1f0d423d8b8ab4eb8b1e78e03f2a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 246f365e3ae9434619fed6d187e97f9224c48d0c
2017-12-12 10:14:31 -06:00
Alex Touchet
63728c35c2 servo: Merge #19542 - Add Windows as a development platform in Readme (from atouchet:readme-windows); r=jdm
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0fa605d2439c4f640b7f180c18d768a7a14e7f1e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 498a62bafec0736638d14968d5a5ac90f9d7f1d8
2017-12-11 01:01:42 -06:00
Jon Leighton
29c83eed34 servo: Merge #19461 - Handle cases where selection API doesn't apply (from jonleighton:issue-19171-4); r=KiChjang
The selection API only applies to certain <input> types:

https://html.spec.whatwg.org/multipage/#do-not-apply

This commit ensures that we handle that correctly.

Some notes:

1. TextControl::set_dom_selection_direction now calls
   set_selection_range(), which means that setting selectionDirection will
   now fire a selection event, as it should per the spec.

2. There is a test for the firing of the select event in
   tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/select-event.html,
   however the test did not run due to this syntax error:

   (pid:26017) "ERROR:script::dom::bindings::error: Error at http://web-platform.test:8000/html/semantics/forms/textfieldselection/select-event.html:50:11 missing = in const declaration"

   This happens due to the us of the "for (const foo of ...)" construct.
   Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
   this should actually work, so it's somewhat unsatisfying to have to
   change the test.

3. I removed tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html
   because it doesn't seem to add any extra value - the selection API
   always applies to textarea elements, and the API is tested elsewhere.

4. If an `<input>`'s type is unset, it defaults to a text, and the
   selection API applies. Also, if an `<input>`'s type is set to an
   invalid value, it defaults to a text too. This second case doesn't
   currently work, and I'll need to do more restructuring of the code in
   a future commit. See discussion with nox in IRC:
   https://mozilla.logbot.info/servo/20171201#c13946454-c13946594

Source-Repo: https://github.com/servo/servo
Source-Revision: db41cc00be93523114092125859534b107ec772a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1ac0a74fcea1cfc06a94607896101667847e727c
2017-12-10 18:37:58 -06:00
Glenn Watson
44f20cec67 servo: Merge #19531 - Update WR (bitmap font fixes, serde deserialization optimizations) (from glennw:update-wr-bitmap-fonts); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 92cbf5630966c2a3f655e1edefa451628f2811ef

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e017cb40f1afa6b46a5ba30885224b87aa3fb414
2017-12-10 11:12:20 -06:00
Simon Sapin
0a48e0345b servo: Merge #19540 - Check that 'style' is compiled in a supported configuration (from servo:style-features); r=emilio
Provide an explanatory error message when the compilation would fail because of missing or duplicate items.

Source-Repo: https://github.com/servo/servo
Source-Revision: 29d960ee5c043ba87ec0da565b5d61979a8a9b78

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 938036878f0738eb87e98a6f70a0f031d465b240
2017-12-09 20:00:23 -06:00
Emilio Cobos Álvarez
be9bd84788 servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck
I'll need this for ::slotted().

Source-Repo: https://github.com/servo/servo
Source-Revision: c6bf85eca90b9cb71ff05d4454a43a7da5fc3ac8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 02f9868af7469734b70d02e8ddb0470a9c8d407d
2017-12-09 17:15:14 -06:00
Emilio Cobos Álvarez
8093a3dd29 servo: Merge #19533 - style: Remove unused SelectorImpl::pseudo_element_cascade_type (from emilio:unused-code-should-die); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 95520ca39c4dde7296584227d49d70615dda0bf0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1a97cecaec5781d0a5fe9a9c53dda6eb7982ba8e
2017-12-09 15:27:49 -06:00
Emilio Cobos Álvarez
d6ec9e4c13 servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 548028fd07d85dbbbd0511386f88ea19825dc258

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4599b24e3d0dbd27d08d9232272f98c0c36cecd7
2017-12-09 13:58:25 -06:00
Matt Brubeck
e9500aa84a servo: Merge #19537 - style: Use the ? operator for Option (from mbrubeck:try); r=nox
This is stable in Rust 1.22 (#19532).

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it is refactoring only

Source-Repo: https://github.com/servo/servo
Source-Revision: 5f4f355cea4a24992ac9efa97f4a6e1837008e0b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3a61f3b466e9f3c80f94b7ecb30f70f85efa55b3
2017-12-09 10:50:55 -06:00
Emilio Cobos Álvarez
342c95966f servo: Merge #19534 - style: Simplify naming and signatures of single-colon pseudo stuff (from emilio:naming-is-a-bit-hard-but-not-that-hard); r=nox
Also drop a few FIXMEs while at it, since they look bogus.

Source-Repo: https://github.com/servo/servo
Source-Revision: 051eb6bcb9204ecab1c1481a275a09fd50bf0467

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 049f90ddd1ae37e05adec201fbaa6f876cbdddfe
2017-12-09 09:52:27 -06:00
Matt Brubeck
d8e57cef81 servo: Merge #19532 - Use Rust 1.22.1 for geckolib (from mbrubeck:rustup); r=SimonSapin
This matches the version required for Firefox builds:
https://bugzilla.mozilla.org/show_bug.cgi?id=1421097

Source-Repo: https://github.com/servo/servo
Source-Revision: 051a715721b026c9ec2d256adfe432c404fd6788

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3498391f66ad4846da3f1480dc8ac1cb14ddee34
2017-12-09 01:14:02 -06:00
Emilio Cobos Álvarez
1bdfa1c2a6 servo: Merge #19530 - style: Don't unconditionally extend() the declaration block vector (from emilio:extend-not-much); r=jdm
Since it appears in profiles when used from CSSOM, like the one in the bug
mentioned in the comment.

Source-Repo: https://github.com/servo/servo
Source-Revision: f8a87a76b2c940fdcf1ced230c616b5312e97402

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a56d1632cd6ce0fc9015a0e4ae5f6603a0de65bb
2017-12-08 19:59:38 -06:00
Xidorn Quan
b5dc8edd90 servo: Merge #19526 - Add @supports -moz-bool-pref() support for stylo (from upsuper:moz-bool-pref); r=emilio
This is the Servo side change for [bug 1267890](https://bugzilla.mozilla.org/show_bug.cgi?id=1267890).

Source-Repo: https://github.com/servo/servo
Source-Revision: 42a3c1631c27dde2d845338ccf80e0fb1b3cf9bf

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b027cf2d3d0234e7e54675d1c76c5915fe21db1f
2017-12-08 18:49:39 -06:00
Emilio Cobos Álvarez
63378542f1 servo: Merge #19520 - selectors: Simplify :visited by only using the "is inside link" information (from emilio:simplify-visited); r=jryans
Right now we go through a lot of hoops to see if we ever see a relevant link.

However, that information is not needed: if the element is a link, we'll always
need to compute its visited style because its its own relevant link.

If the element inherits from a link, we need to also compute the visited style
anyway.

So the "has a relevant link been found" is pretty useless when we know what are
we inheriting from.

The branches at the beginning of matches_complex_selector_internal were
affecting performance, and there are no good reasons to keep them.

I've verified that this passes all the visited tests in mozilla central, and
that the test-cases too-flaky to be landed still pass.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7a8733723551201d2c06acde9b0915b4c03938b4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 00a655d0bcdf9cec70330c34eea0756b73c38cc3
2017-12-08 17:37:32 -06:00
Keith Yeung
755f12989a servo: Merge #19522 - Remove border_collapse field in InternalTable (from KiChjang:remove-border-collapse-field); r=emilio
This field doesn't seem to serve a purpose after #18252.

Source-Repo: https://github.com/servo/servo
Source-Revision: fd785f2424bacd6f60cb1937648fed28a43b0f36

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b67e4a7581ff797e73348c8f7e8d35639f974d15
2017-12-08 16:02:09 -06:00
Alan Jeffrey
cf16493499 servo: Merge #19524 - Use urllib rather than httplib2 when downloading build perf data (from asajeffrey:build-perf-urllib); r=jdm
<!-- Please describe your changes on the following line: -->

Fixes http://build.servo.org/builders/linux-nightly/builds/534/steps/shell__3/logs/stdio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructire

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: ab7187cb665914d3038d79411e563e4ff12a0f65

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : baaaf15cab9472c1ef8bb58fc123dd78415bb339
2017-12-08 14:30:46 -06:00
Simon Sapin
7412becfe8 servo: Merge #19527 - Fix running cargo test at the repository root (from servo:root); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 8a8c06ac7b77ca1199c778f2ab6f1c27d88a340a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9788f0e00ebfa0724aa3d910efda8dcb367969c7
2017-12-08 12:30:03 -06:00
Matt Brubeck
f8fdec5746 servo: Merge #19525 - Update to webdriver 0.33 (from mbrubeck:deps); r=nox
Removes the extra version of the `cookie` crate

Source-Repo: https://github.com/servo/servo
Source-Revision: a8be1597c9d1b4d019ed93d68cc7fdfba8ca1f86

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b7b0c6e20e3d75414de87d9ccddf2bb177ed5d18
2017-12-08 10:29:08 -06:00
Simon Sapin
a869d43078 servo: Merge #19510 - Update some dependencies, remove heapsize from the build (from servo:heapsize); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 07bd84ecc8dc9ba56df873453696993118e18583

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 92be8729bbeadf778435c95878ddef5c3195879c
2017-12-08 07:49:54 -06:00
Emilio Cobos Álvarez
95703831fd servo: Merge #19518 - style: Remove useless type parameter (from emilio:useless-code-is-useless); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: 22472b4db4564f7bc274eb01447e4f04fd7e7205

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4c9671fc867830cf6fb5ccd528e7c0beafe39548
2017-12-07 20:32:11 -06:00
Matt Brubeck
b64e68ef18 servo: Merge #19517 - Defend against bugs in SelectorFlagsMap (from mbrubeck:uluru); r=emilio
Some defensive programming:

* Make `SelectorFlagsMap::apply_flags` private so it's easier to ensure it is called from the correct thread.

* Clear the cache and the map at the same time; otherwise `apply_flags` leaves `SelectorFlagsMap` in an inconsistent state.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they do not change behavior

Source-Repo: https://github.com/servo/servo
Source-Revision: 254bbf50a7676b00bb4c5f515c45f2cd3e8e283a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : afe8557cdba4e6dba6843aa657bd6e28164ca412
2017-12-07 19:09:07 -06:00
Matt Brubeck
84f6c35c0f servo: Merge #19512 - Improve LRU cache behavior in SelectorFlagsMap (from mbrubeck:uluru); r=emilio
This code used to insert duplicate entries to avoid expensive shuffling of the LRU cache.  With uluru this is no longer necessary, because reordering the cache is cheap.

Now it uses the `LRUCache::find` method from uluru 0.2 to update entries in-place.  This should increase cache hits by eliminating unnecessary evictions.

This PR also updates `arrayvec` because `uluru` depends on it, and `immeta` because it depends on `arrayvec`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they don't change behavior

Source-Repo: https://github.com/servo/servo
Source-Revision: 0c13f14aaa151764e1b3dd2d4503cb6fc3c9595b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b1551f8e564b25ef5a332d0492584e8e179e9325
2017-12-07 16:02:44 -06:00