mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-30 05:35:31 +00:00
570d1f0e83
Change the logic that moves the main summary to the front from operating on generated frames in DetailsFrame::SetInitialChildList() to operating on frame construction item list in AddFrameConstructionItemsInternal() so that it will be correct when cooperating with ::first-line. The root cause of the bug reported is because when specifying ::first-line on details element, the first frame of summary element, which is generated due to ib-split, will be wrapped in nsFirstLineFrame. The original code fails to find the summary frame in the wrapper frame and triggers assertion because of the second ib-split summary frame. To fix that, we need to descend into the child list of wrapper frames when checking the main summary. Add original test case as a crashtest as well as reftests to clearly reproduce the issue. Note that in the reftest, the blue color in ::first-line is applied incorrectly to the second line in the summary due to bug 520605. MozReview-Commit-ID: Bv4Vcvxp6pY
63 lines
1.8 KiB
C++
63 lines
1.8 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef DetailsFrame_h
|
|
#define DetailsFrame_h
|
|
|
|
#include "nsBlockFrame.h"
|
|
#include "nsIAnonymousContentCreator.h"
|
|
|
|
class nsContainerFrame;
|
|
class nsStyleContext;
|
|
|
|
// DetailsFrame is generated by HTMLDetailsElement. See
|
|
// nsCSSFrameConstructor::ConstructDetailsFrame for the structure of a
|
|
// DetailsFrame.
|
|
//
|
|
class DetailsFrame final : public nsBlockFrame
|
|
, public nsIAnonymousContentCreator
|
|
{
|
|
public:
|
|
NS_DECL_FRAMEARENA_HELPERS
|
|
NS_DECL_QUERYFRAME_TARGET(DetailsFrame)
|
|
NS_DECL_QUERYFRAME
|
|
|
|
explicit DetailsFrame(nsStyleContext* aContext);
|
|
|
|
virtual ~DetailsFrame();
|
|
|
|
nsIAtom* GetType() const override;
|
|
|
|
#ifdef DEBUG_FRAME_DUMP
|
|
nsresult GetFrameName(nsAString& aResult) const override
|
|
{
|
|
return MakeFrameName(NS_LITERAL_STRING("Details"), aResult);
|
|
}
|
|
#endif
|
|
|
|
#ifdef DEBUG
|
|
// Check the frame of the main summary element is the first child in the frame
|
|
// list. Returns true if we found the main summary frame; false otherwise.
|
|
bool CheckValidMainSummary(const nsFrameList& aFrameList) const;
|
|
#endif
|
|
|
|
void SetInitialChildList(ChildListID aListID,
|
|
nsFrameList& aChildList) override;
|
|
|
|
void DestroyFrom(nsIFrame* aDestructRoot) override;
|
|
|
|
// nsIAnonymousContentCreator
|
|
nsresult CreateAnonymousContent(nsTArray<ContentInfo>& aElements) override;
|
|
|
|
void AppendAnonymousContentTo(nsTArray<nsIContent*>& aElements,
|
|
uint32_t aFilter) override;
|
|
|
|
private:
|
|
nsCOMPtr<nsIContent> mDefaultSummary;
|
|
};
|
|
|
|
#endif // DetailsFrame_h
|