mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-24 21:31:04 +00:00
3ad6fe2ca8
Current implementation
```lang=javascript
exports.method = function(fn, spec = {}) {
fn._methodSpec = Object.freeze(spec);
if (spec.request) {
Object.freeze(spec.request);
}
if (spec.response) {
Object.freeze(spec.response);
}
return fn;
};
```
https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/devtools/shared/protocol/utils.js#70-79
The helper method() in protocol/utils.js is only called from two methods:
- actorBridge (never used in the codebase)
- actorBridgeWithSpec (used by a few actors)
actorBridgeWithSpec doesn't pass the second argument, so in practice, this method could be reduced to:
```lang=javascript
exports.method = function(fn) {
fn._methodSpec = Object.freeze({});
return fn;
};
```
`_methodSpec` is only mentioned in one other spot: https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/devtools/shared/protocol/Actor/generateActorSpec.js#27-40
But based on our coverage tooling, we never actually have a `_methodSpec` when we run this code: https://coverage.moz.tools/#view=file&revision=latest&path=devtools/shared/protocol/Actor/generateActorSpec.js
To hit it, we would have to call `generateActorSpec` directly with an actor where we used `actorBridgeWithSpec`. But we never do that, we only use it with plain JS objects in the devtools/shared/specs folder.
Consequently, this helper can be removed.
Differential Revision: https://phabricator.services.mozilla.com/D96935
|
||
|---|---|---|
| .. | ||
| acorn | ||
| compatibility | ||
| css | ||
| discovery | ||
| heapsnapshot | ||
| inspector | ||
| jsbeautify | ||
| layout | ||
| locales | ||
| node-properties | ||
| performance | ||
| performance-new | ||
| platform | ||
| protocol | ||
| qrcode | ||
| resources | ||
| screenshot | ||
| security | ||
| specs | ||
| sprintfjs | ||
| storage | ||
| test-helpers | ||
| tests | ||
| transport | ||
| webconsole | ||
| worker | ||
| .eslintrc.js | ||
| accessibility.js | ||
| async-storage.js | ||
| async-utils.js | ||
| base-loader.js | ||
| builtin-modules.js | ||
| constants.js | ||
| content-observer.js | ||
| debounce.js | ||
| defer.js | ||
| DevToolsUtils.js | ||
| dom-helpers.js | ||
| dom-node-constants.js | ||
| dom-node-filter-constants.js | ||
| event-emitter.js | ||
| extend.js | ||
| flags.js | ||
| generate-uuid.js | ||
| indentation.js | ||
| indexed-db.js | ||
| jar.mn | ||
| l10n.js | ||
| loader-plugin-raw.jsm | ||
| Loader.jsm | ||
| moz.build | ||
| natural-sort.js | ||
| path.js | ||
| picker-constants.js | ||
| plural-form.js | ||
| protocol.js | ||
| system.js | ||
| task.js | ||
| ThreadSafeDevToolsUtils.js | ||
| throttle.js | ||
| wasm-source-map.js | ||
| webextension-fallback.html | ||