gecko-dev/widget
Markus Stange 43e5d7e69f Bug 1707598 - When opening a new menu just after closing an old menu, make sure we exit the nested event loop for the old NSMenu before we ask the new NSMenu to open. r=harry
On CI, where we open and close menu items in quick succession, we sometimes got
into a state where the new menu was opened while we were still in the old menu's
nested event loop. So we had the following sequence of events:

```
 - old menu +[NSMenu popUpContextMenu:withEvent:forView:]
   - nested event loop for old menu
     - old menu -[NSMenu cancelTrackingWithoutAnimation]
     - new menu +[NSMenu popUpContextMenu:withEvent:forView:]
       - nested event loop for new menu
         - new menu -[NSMenu cancelTrackingWithoutAnimation]
     - new menu's event loop is exited, but old menu's event loop remains on the
       stack
     - shutdown hang here
```

MOZMenuOpeningCoordinator makes sure that +[NSMenu popUpContextMenu:withEvent:forView:]
is always called in sequence, never in a nested fashion.

Differential Revision: https://phabricator.services.mozilla.com/D113373
2021-04-26 20:57:20 +00:00
..
android Bug 1558103 - Don't try to dispatch XPCOM events during shutdown. r=aklotz 2021-04-26 20:49:27 +00:00
cocoa Bug 1707598 - When opening a new menu just after closing an old menu, make sure we exit the nested event loop for the old NSMenu before we ask the new NSMenu to open. r=harry 2021-04-26 20:57:20 +00:00
crashtests
generic Bug 1657401 - Prelude: rearrange IPDL files in widget/. r=spohl 2020-11-11 23:17:40 +00:00
gtk Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi 2021-04-26 15:52:25 +00:00
headless Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi 2021-04-26 15:52:25 +00:00
reftests Bug 1702755 - Allow a couple more fuzzy pixels in non-webrender. 2021-04-02 20:20:28 +02:00
tests Bug 1677334 - Part 1: Don't generate click event for mouse-left-down with ctrl key is pressed on Mac; r=masayuki 2021-04-07 11:23:45 +00:00
uikit Bug 1702765 - Plumb ColorScheme through nsXPLookAndFeel. r=mstange 2021-04-02 22:17:55 +00:00
windows Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi 2021-04-26 15:52:25 +00:00
x11 Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
BasicEvents.h Bug 1689317 - Clipboard events should be composed. r=smaug 2021-01-29 13:30:40 +00:00
CommandList.h Bug 1357365 - part 3: Make TypeInState::OnSelectionChange() stop keeping link style if caret is positioned at edge of a link element and not moved in the link r=m_kato,edgar 2021-01-13 01:55:29 +00:00
CompositorWidget.cpp Bug 1678892 - Pass dirty and opaque regions to layers compositor. r=sotaro 2021-03-23 06:36:39 +00:00
CompositorWidget.h Bug 1690216 - Clarify that StartRemoteDrawingInRegion does not actually modify the region. r=mattwoodrow 2021-02-24 18:34:52 +00:00
ContentCache.cpp Bug 1683226 - part 4: Make stop ContentCache check whether a plugin has focus or not r=m_kato 2020-12-21 05:59:57 +00:00
ContentCache.h Bug 1678553 - part 12: Make ContentCache store character rects with Maybe r=m_kato 2020-11-27 14:48:03 +00:00
ContentEvents.h
EventClassList.h Bug 1683226 - part 16: Get rid of WidgetPluginEvent r=smaug 2020-12-29 21:19:45 +00:00
EventForwards.h Bug 1691622 - part 9: Make nsIWidget::SynthesizeNativeMouseEvent take an XP button ID and abstract message value r=smaug,geckoview-reviewers,agi,m_kato 2021-02-24 01:27:10 +00:00
EventMessageList.h Bug 1701789 - Restore UserProximityEvent r=smaug 2021-03-30 20:44:47 +00:00
FontRange.h
GfxDriverInfo.cpp Bug 1702479 - Add support for GFX10_3 (Navi 2x) GPUs. r=aosmond 2021-04-01 18:26:59 +00:00
GfxDriverInfo.h Bug 1690568 - Block WebRender on Linux with Mesa r600 driver if older than 17.3.0. r=jrmuizel 2021-02-03 16:00:47 +00:00
GfxInfoBase.cpp Bug 1615574 - Disable webrender shader cache on Adreno 3xx. r=aosmond 2021-04-12 15:14:12 +00:00
GfxInfoBase.h Bug 1689945 - Update display info when WM_DISPLAYCHANGE happens r=jrmuizel 2021-02-04 23:25:35 +00:00
GfxInfoCollector.cpp
GfxInfoCollector.h
GfxInfoX11.cpp Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi 2021-04-26 15:52:25 +00:00
GfxInfoX11.h Bug 1696937 [Linux] Remove wayland/drm info from about:support, r=jhorak 2021-03-08 21:26:19 +00:00
IconLoader.cpp Bug 1691861 - Remove unused mContentType fields. r=mconley 2021-02-12 00:32:06 +00:00
IconLoader.h Bug 1691861 - Remove unused mContentType fields. r=mconley 2021-02-12 00:32:06 +00:00
IMEData.cpp Bug 1683226 - part 11: Get rid of IMEEnabled::Plugin r=m_kato 2020-12-21 08:26:24 +00:00
IMEData.h Bug 1683226 - part 11: Get rid of IMEEnabled::Plugin r=m_kato 2020-12-21 08:26:24 +00:00
InProcessCompositorWidget.cpp Bug 1674142: Add additional checks to find a crash in InProcessCompositorWidget::PreRender. r=jrmuizel 2021-03-10 00:45:49 +00:00
InProcessCompositorWidget.h Bug 1674142: Add additional checks to find a crash in InProcessCompositorWidget::PreRender. r=jrmuizel 2021-03-10 00:45:49 +00:00
InputData.cpp Bug 1672726 - Part 1: Rename MultiTouchInput::ToWidgetTouchEvent to ToWidgetEvent; r=botond 2021-04-22 16:01:26 +00:00
InputData.h Bug 1672726 - Part 1: Rename MultiTouchInput::ToWidgetTouchEvent to ToWidgetEvent; r=botond 2021-04-22 16:01:26 +00:00
LookAndFeel.h Bug 1702879 - Add LookAndFeel::ColorSchemeForDocument so that it can be called from nsNativeThemeCocoa. r=emilio 2021-04-04 15:48:02 +00:00
LookAndFeelTypes.ipdlh Bug 1702765 - Plumb ColorScheme through nsXPLookAndFeel. r=mstange 2021-04-02 22:17:55 +00:00
LSBUtils.cpp
LSBUtils.h
MediaKeysEventSourceFactory.h
MiscEvents.h Bug 1683226 - part 16: Get rid of WidgetPluginEvent r=smaug 2020-12-29 21:19:45 +00:00
MouseEvents.h Bug 1697769 - Apply implicit pointer capture only for pointer events that are generated from the touch events; r=smaug 2021-04-13 13:14:12 +00:00
moz.build Bug 1682030 - Remove nsIPluginWidget r=jmathies 2021-04-06 19:28:15 +00:00
NativeKeyToDOMCodeName.h
NativeKeyToDOMKeyName.h
NativeMenu.h Bug 1704883 - Report which mouse button was used to click items in native menus. r=harry 2021-04-21 03:45:27 +00:00
nsAppShellSingleton.h
nsAutoRollup.cpp
nsAutoRollup.h
nsBaseAppShell.cpp
nsBaseAppShell.h
nsBaseClipboard.cpp
nsBaseClipboard.h
nsBaseDragService.cpp Bug 941356 - Fix start offset of transformed drag images. r=botond 2021-03-04 10:56:22 +00:00
nsBaseDragService.h
nsBaseFilePicker.cpp Bug 1686616 - make StringBundle use Components instead of Services. r=kmag 2021-02-18 13:26:32 +00:00
nsBaseFilePicker.h
nsBaseScreen.cpp
nsBaseScreen.h
nsBaseWidget.cpp Bug 1672726 - Part 2: Support dispatching synthesized touch events through parent process; r=ipc-reviewers,botond,nika 2021-04-22 16:01:26 +00:00
nsBaseWidget.h Bug 1705877 - Add back some virtual keywords that I shouldn't have removed. 2021-04-20 12:26:00 +02:00
nsClipboardHelper.cpp
nsClipboardHelper.h
nsClipboardProxy.cpp
nsClipboardProxy.h
nsColorPickerProxy.cpp
nsColorPickerProxy.h
nsContentProcessWidgetFactory.cpp
nsCUPSShim.cpp Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsCUPSShim.h Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsDeviceContextSpecProxy.cpp Bug 1698235 - Add some error handling when using RemotePrintJobChild which may be destroyed. r=TYLin 2021-03-18 19:39:09 +00:00
nsDeviceContextSpecProxy.h
nsDragServiceProxy.cpp Bug 1641270 - Part 8: Make the Drag&Drop to use the correct cookieJarSettings to download the url. r=smaug,dimi 2020-11-11 11:14:05 +00:00
nsDragServiceProxy.h
nsFilePickerProxy.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
nsFilePickerProxy.h
nsGUIEventIPC.h Bug 1528289 - part 4: Prevent click event if APZC cancels autoscroll synchronously r=botond 2021-03-23 19:22:49 +00:00
nsHTMLFormatConverter.cpp
nsHTMLFormatConverter.h
nsIApplicationChooser.idl
nsIAppShell.idl
nsIBaseWindow.idl
nsIBidiKeyboard.idl
nsIClipboard.idl
nsIClipboardHelper.idl
nsIClipboardOwner.idl
nsIColorPicker.idl
nsIDeviceContextSpec.h Bug 1664258 - Increase the default PDF resolution for non-windows platforms. r=jwatt 2020-09-11 11:37:40 +00:00
nsIDisplayInfo.idl
nsIDragService.idl Bug 1641270 - Part 8: Make the Drag&Drop to use the correct cookieJarSettings to download the url. r=smaug,dimi 2020-11-11 11:14:05 +00:00
nsIDragSession.idl
nsIFilePicker.idl
nsIFormatConverter.idl
nsIGfxInfo.idl Bug 1615574 - Disable webrender shader cache on Adreno 3xx. r=aosmond 2021-04-12 15:14:12 +00:00
nsIGfxInfoDebug.idl
nsIGtkTaskbarProgress.idl
nsIJumpListBuilder.idl
nsIJumpListItem.idl
nsIMacDockSupport.idl
nsIMacFinderProgress.idl
nsIMacSharingService.idl
nsIMacWebAppUtils.idl
nsIPaper.idl Bug 1662538 - patch 1 - Make nsIPaper expose a non-localizable .id in addition to a localizable .name attribute. r=jwatt 2020-09-17 20:05:08 +00:00
nsIPaperMargin.idl Bug 1655558 - Retrieve the paper margins lazily on Windows. r=jwatt,bobowen 2020-08-05 11:26:13 +00:00
nsIPrintDialogService.h
nsIPrinter.idl Bug 1663652 part 1 - Implement combined CreateDefaultSettings and GetPaperList interface for nsPrinterBase r=emilio,mstriemer 2020-11-03 20:35:38 +00:00
nsIPrinterList.idl Bug 1659807 - Add nsIPrinter.systemName and nsIPrinterList.getPrinterBySystemName r=emilio 2020-09-15 21:23:27 +00:00
nsIPrintSession.idl
nsIPrintSettings.idl Bug 1692845 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=bobowen 2021-02-23 10:52:53 +00:00
nsIPrintSettingsService.idl Bug 1669723. Stop unnecessarily catching exceptions from nsIPrintSettingsService.lastUsedPrinterName. r=mstriemer 2020-10-09 10:21:44 +00:00
nsIPrintSettingsWin.idl Bug 1663940: Ensure the unwriteable margins are populated in the print settings. r=emilio 2020-09-11 15:00:18 +00:00
nsIRollupListener.h Bug 1702041 - Call NativeMenu::Close() before firing the contextmenu event. r=harry 2021-03-31 17:41:56 +00:00
nsIScreen.idl
nsIScreenManager.idl
nsISharePicker.idl
nsISound.idl
nsIStandaloneNativeMenu.idl Bug 1699792 - Remove nativeData IDL property and use the NativeNSMenu() C++ method instead. r=harry 2021-03-23 13:40:24 +00:00
nsISystemStatusBar.idl
nsITaskbarOverlayIconController.idl
nsITaskbarPreview.idl
nsITaskbarPreviewButton.idl
nsITaskbarPreviewController.idl
nsITaskbarProgress.idl
nsITaskbarTabPreview.idl
nsITaskbarWindowPreview.idl
nsITouchBarHelper.idl
nsITouchBarInput.idl
nsITouchBarUpdater.idl
nsITransferable.idl Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 2021-02-01 12:05:12 +00:00
nsIUserIdleService.idl
nsIUserIdleServiceInternal.idl
nsIWidget.h Bug 1580595 - [Wayland] Add support for pointer lock via relative-pointer and pointer-constraints r=stransky,rmader,emilio 2021-04-22 14:56:43 +00:00
nsIWidgetListener.cpp Bug 1699506 - Part 1 - Add a NSTitlebarAccessoryViewController to ToolbarWindow to track when the titlebar is shown in fullscreen. r=mac-reviewers,mstange 2021-03-18 20:20:39 +00:00
nsIWidgetListener.h Bug 1699506 - Part 1 - Add a NSTitlebarAccessoryViewController to ToolbarWindow to track when the titlebar is shown in fullscreen. r=mac-reviewers,mstange 2021-03-18 20:20:39 +00:00
nsIWindowsUIUtils.idl
nsIWinTaskbar.idl
nsNativeBasicTheme.cpp Bug 1703774 - Fix radii computation in WebRender codepath for auto-style outline. r=spohl 2021-04-08 14:23:25 +00:00
nsNativeBasicTheme.h Bug 1703604 - When using a transparent scrollbar button / track color, use the thumb color to paint the scrollbar arrow. r=spohl 2021-04-08 09:48:01 +00:00
nsNativeTheme.cpp Bug 1698821 - Simplify native-appearance-disabling for number spinners. r=dholbert 2021-03-16 21:53:20 +00:00
nsNativeTheme.h Bug 1615038: Fine-tune scrollbars in the non-native theme on Windows. r=emilio 2021-01-20 21:33:34 +00:00
nsPaper.cpp Bug 1662538 - patch 1 - Make nsIPaper expose a non-localizable .id in addition to a localizable .name attribute. r=jwatt 2020-09-17 20:05:08 +00:00
nsPaper.h Bug 1678374 - Avoid including js/RootingAPI.h from header files. r=jandem 2020-11-23 16:12:12 +00:00
nsPaperMargin.cpp Bug 1655558 - Retrieve the paper margins lazily on Windows. r=jwatt,bobowen 2020-08-05 11:26:13 +00:00
nsPaperMargin.h Bug 1655558 - Retrieve the paper margins lazily on Windows. r=jwatt,bobowen 2020-08-05 11:26:13 +00:00
nsPrimitiveHelpers.cpp
nsPrimitiveHelpers.h
nsPrinterBase.cpp Bug 1663652 part 2 - Add combined printerInfo method to nsPrinterCUPS r=emilio 2020-11-03 20:35:38 +00:00
nsPrinterBase.h Bug 1663652 part 2 - Add combined printerInfo method to nsPrinterCUPS r=emilio 2020-11-03 20:35:38 +00:00
nsPrinterCUPS.cpp Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsPrinterCUPS.h Bug 1705977 - Add more monochrome settings to CUPS. r=emilio 2021-04-19 19:53:02 +00:00
nsPrinterListBase.cpp Bug 1667486 part 1 - Make fallback paper sizes public to nsPaper, localize the sizes only once in nsPrinterListBase r=jwatt,emilio 2020-10-13 21:53:47 +00:00
nsPrinterListBase.h Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
nsPrinterListCUPS.cpp Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsPrinterListCUPS.h Bug 1683226 - part 14: Get rid of ComplexTextInputPanel r=m_kato 2020-12-24 02:49:02 +00:00
nsPrintSession.cpp
nsPrintSession.h
nsPrintSettingsImpl.cpp Bug 1689789 part 2 - Use Ceil instead of Truncate the ensure the print surface is large enough for the requested paper size. r=jfkthame 2021-02-06 00:28:29 +00:00
nsPrintSettingsImpl.h Bug 1669854 - Add a single pageRanges print setting. r=nordzilla 2020-11-07 16:01:57 +00:00
nsPrintSettingsService.cpp Bug 1692845 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=bobowen 2021-02-23 10:52:53 +00:00
nsPrintSettingsService.h Bug 1667285. Make nsPrintSettingsService::_CreatePrintSettings pure virtual. r=bobowen 2020-09-25 09:33:14 +00:00
nsShmImage.cpp
nsShmImage.h
nsSoundProxy.cpp
nsSoundProxy.h
nsTransferable.cpp Bug 1641270 - Part 7: Add setter/getter of nsICookieJarSettings to nsITransferable. r=smaug 2020-11-11 11:14:07 +00:00
nsTransferable.h Bug 1641270 - Part 7: Add setter/getter of nsICookieJarSettings to nsITransferable. r=smaug 2020-11-11 11:14:07 +00:00
nsUserIdleService.cpp
nsUserIdleService.h
nsWidgetInitData.h Bug 1679087 - Remove ability to create non-Unicode widgets. r=mhowell 2020-12-17 18:21:39 +00:00
nsWidgetsCID.h Bug 1695873 - remove nativemenuservice remnants and fix macOS openedwithkey attribute use, r=mak,mstange 2021-03-04 22:54:23 +00:00
nsXPLookAndFeel.cpp Bug 1701691 - -moz-toolbar-prefers-color-scheme for dark theme detection r=desktop-theme-reviewers,emilio,harry 2021-04-18 22:22:49 +00:00
nsXPLookAndFeel.h Bug 1702765 - Plumb ColorScheme through nsXPLookAndFeel. r=mstange 2021-04-02 22:17:55 +00:00
PrintBackgroundTask.h Bug 1660686: Add telemetry for time taken in print background tasks. r=jwatt, dr=tdsmith 2020-08-31 14:36:45 +00:00
PuppetBidiKeyboard.cpp
PuppetBidiKeyboard.h
PuppetWidget.cpp Bug 1672726 - Part 2: Support dispatching synthesized touch events through parent process; r=ipc-reviewers,botond,nika 2021-04-22 16:01:26 +00:00
PuppetWidget.h Bug 1580595 - [Wayland] Add support for pointer lock via relative-pointer and pointer-constraints r=stransky,rmader,emilio 2021-04-22 14:56:43 +00:00
RemoteLookAndFeel.cpp Bug 1703205 - Don't query AlertNotificationOrigin from RemoteLookAndFeel. r=cmartin 2021-04-06 13:44:06 +00:00
RemoteLookAndFeel.h Bug 1702765 - Plumb ColorScheme through nsXPLookAndFeel. r=mstange 2021-04-02 22:17:55 +00:00
Screen.cpp
Screen.h
ScreenManager.cpp Bug 1696845 - Use dlsym for gdk_*_display_get_type. r=stransky 2021-03-11 14:32:53 +00:00
ScreenManager.h
ScrollbarDrawingMac.cpp Bug 1703691: Start respecting widget.disable-dark-scrollbar pref on macOS. r=emilio,mac-reviewers,mstange,bradwerth 2021-04-07 23:53:52 +00:00
ScrollbarDrawingMac.h Bug 1519636 - Reformat recent changes to the Google coding style r=andi 2021-03-15 08:45:29 +00:00
SharedWidgetUtils.cpp
SystemTimeConverter.h
TextEventDispatcher.cpp Bug 1704070 - Expose the APZ event status in the return value of DispatchInputEvent(). r=tnikkel 2021-04-14 05:07:56 +00:00
TextEventDispatcher.h Bug 1685491 - part 5: Move the code remapping arrow keys in vertical content to NativeKeyBindings r=smaug,jfkthame 2021-02-02 03:29:31 +00:00
TextEventDispatcherListener.h
TextEvents.h Backed out 3 changesets (bug 1685183) for causing build bustages. CLOSED TREE 2021-04-08 06:48:02 +03:00
TextRange.h
ThemeChangeKind.h Bug 1668875 - Distinguish theme changes that can and cannot affect style/layout. r=tnikkel 2020-10-27 10:24:40 +00:00
TouchEvents.h
TouchResampler.cpp Bug 1676771 - Add a TouchResampler class. r=kats 2020-11-18 03:57:35 +00:00
TouchResampler.h Bug 1676771 - Add a TouchResampler class. r=kats 2020-11-18 03:57:35 +00:00
VsyncDispatcher.cpp
VsyncDispatcher.h
WidgetEventImpl.cpp Bug 1701108 - Split this assertion up into three assertions that are easier to understand. r=masayuki 2021-03-26 02:06:53 +00:00
WidgetMessageUtils.h Bug 1640186 - Add machinery for sending native pinch gestures from a test, and a test which uses it r=botond 2021-02-19 05:35:40 +00:00
WidgetTraceEvent.h
WidgetUtils.cpp Bug 1701182 - Prepend SNAP-specific prefix to shm path. r=stransky 2021-04-09 14:41:31 +00:00
WidgetUtils.h Bug 1701182 - Prepend SNAP-specific prefix to shm path. r=stransky 2021-04-09 14:41:31 +00:00
WindowSurface.h
WindowSurfaceX11SHM.cpp
WindowSurfaceX11SHM.h