Nathan Froyd cfb8fb313f Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg ... This patch was generated by running: ``` perl -p -i \ -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \ -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \ $FILE ``` against every .cpp and .h in mozilla-central, and then fixing up the inevitable errors that happen as a result of matching C++ expressions with regexes. The errors fell into three categories: 1. Calling the convert functions with `std::string::c_str()`; these were changed to simply pass the string instead, relying on implicit conversion to `mozilla::Span`. 2. Calling the convert functions with raw pointers, which is not permitted with the copy functions; these were changed to invoke `MakeStringSpan` first. 3. Other miscellaneous errors resulting from over-eager regexes and/or the replacement not being type-aware. These changes were reverted. Differential Revision: https://phabricator.services.mozilla.com/D88903		2020-09-02 09:54:37 +00:00
..
build	Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj	2020-07-01 08:29:29 +00:00
decoders	Bug 1661368 - Slow testcase impacts AVIF fuzzing performance. r=tsmith	2020-08-28 00:06:07 +00:00
encoders	Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj	2020-07-01 08:29:29 +00:00
test	Bug 1655846 - Hit MOZ_CRASH(assertion failed: (left == right) left: 1024, right: 0). r=tnikkel	2020-08-14 23:17:37 +00:00
AnimationFrameBuffer.cpp
AnimationFrameBuffer.h
AnimationParams.h
AnimationSurfaceProvider.cpp	Bug 1651587 - Make image::Image released efficient on main thread r=aosmond	2020-07-10 14:34:01 +00:00
AnimationSurfaceProvider.h
BMPHeaders.h	Backed out changeset 40784ea31188 (bug 651482) for Reftest failures in bmp-corrupted/wrapper.html?invalid-compression-BITFIELDS.bmp. CLOSED TREE	2020-05-22 12:21:32 +03:00
ClippedImage.cpp	Bug 1652254 - Remove svg from some moz.build local includes r=dholbert	2020-07-12 16:38:26 +00:00
ClippedImage.h
CopyOnWrite.h
DecodedSurfaceProvider.cpp	Bug 1651587 - Make image::Image released efficient on main thread r=aosmond	2020-07-10 14:34:01 +00:00
DecodedSurfaceProvider.h
DecodePool.cpp	Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj	2020-08-04 11:27:07 +00:00
DecodePool.h
Decoder.cpp	Bug 1651587 - Make image::Image released efficient on main thread r=aosmond	2020-07-10 14:34:01 +00:00
Decoder.h	Bug 1620600 - Add flags to allow image decoders to produce sRGB output. r=tnikkel	2020-04-10 16:26:33 +00:00
DecoderFactory.cpp	Backed out changeset 6c865ed1f998 (bug 1641389) for perma failures on test_animation_operators.html. CLOSED TREE	2020-05-28 05:43:40 +03:00
DecoderFactory.h	Bug 1625363 - AVIF (AV1 Image File Format): experimental support. r=aosmond,necko-reviewers,valentin	2020-05-01 22:56:04 +00:00
DecoderFlags.h
Downscaler.cpp
Downscaler.h
DownscalingFilter.h
DynamicImage.cpp	Bug 1652254 - Remove svg from some moz.build local includes r=dholbert	2020-07-12 16:38:26 +00:00
DynamicImage.h
FrameAnimator.cpp	Bug 1634839. Fix img.decode for animated images that aren't in the document. r=aosmond	2020-05-04 18:43:32 +00:00
FrameAnimator.h	Bug 1629490. The composited frame is now invalid for animated images that have finished. r=aosmond	2020-04-20 03:38:27 +00:00
FrameTimeout.h
FrozenImage.cpp	Bug 1631365. img.decode never fulfills or rejects if the image is too big to fit into the surface cache. r=aosmond	2020-04-20 21:04:45 +00:00
FrozenImage.h	Bug 1631365. img.decode never fulfills or rejects if the image is too big to fit into the surface cache. r=aosmond	2020-04-20 21:04:45 +00:00
ICOFileHeaders.h
IDecodingTask.cpp	Bug 1616411 - Part 3: Make RasterImage deal with and apply image orientation. r=tnikkel	2020-04-17 02:57:30 +00:00
IDecodingTask.h
Image.cpp
Image.h	Bug 1625797 - Replace RasterImage nsIProperties impl with accessors for hotspot coordinate. r=tnikkel	2020-03-31 21:16:39 +00:00
ImageBlocker.cpp
ImageBlocker.h
ImageCacheKey.cpp	Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin	2020-05-27 18:11:12 +00:00
ImageCacheKey.h	Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 2 - Expose PartitionedPrincipal, r=dimi	2020-06-03 06:09:52 +00:00
ImageFactory.cpp	Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika	2020-04-07 15:16:33 +00:00
ImageFactory.h
ImageLogging.h
ImageMemoryReporter.cpp	Bug 1652883 - Shared surfaces memory reporter should give KIND_OTHER a different path. r=aosmond	2020-07-17 00:02:13 +00:00
ImageMemoryReporter.h
ImageMetadata.h	Bug 1626570 - Improve handling of copying arrays in image/. r=tnikkel	2020-05-06 11:54:32 +00:00
ImageOps.cpp	Bug 1616411 - Part 4: Make nsLayoutUtils::OrientImage undo any automatic RasterImage orientation when required. r=tnikkel	2020-04-17 02:57:32 +00:00
ImageOps.h	Bug 1616411 - Part 4: Make nsLayoutUtils::OrientImage undo any automatic RasterImage orientation when required. r=tnikkel	2020-04-17 02:57:32 +00:00
ImageRegion.h
ImageWrapper.cpp	Bug 1631365. img.decode never fulfills or rejects if the image is too big to fit into the surface cache. r=aosmond	2020-04-20 21:04:45 +00:00
ImageWrapper.h
ImgDrawResult.h
imgFrame.cpp	Bug 1641594 - Remove the wrapper around recycled surfaces. r=tnikkel	2020-06-11 17:49:13 +00:00
imgFrame.h	Bug 1641594 - Remove the wrapper around recycled surfaces. r=tnikkel	2020-06-11 17:49:13 +00:00
imgICache.idl
imgIContainer.idl	Bug 1631365. img.decode never fulfills or rejects if the image is too big to fit into the surface cache. r=aosmond	2020-04-20 21:04:45 +00:00
imgIContainerDebug.idl
imgIEncoder.idl
imgILoader.idl	Bug 1628727 - Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel	2020-04-10 21:14:49 +00:00
imgINotificationObserver.idl
imgIRequest.idl	Bug 1631365. img.decode never fulfills or rejects if the image is too big to fit into the surface cache. r=aosmond	2020-04-20 21:04:45 +00:00
imgIScriptedNotificationObserver.idl
imgITools.idl
imgLoader.cpp	Bug 1656927 - Assertion failure: aContentType.Equals("image/avif"), at /builds/worker/checkouts/gecko/image/imgLoader.cpp:2785. r=aosmond	2020-08-04 17:30:14 +00:00
imgLoader.h	Bug 1599160 - Better integration of the shared stylesheet cache with the network cache. r=tnikkel,mayhemer,heycam	2020-06-12 19:06:04 +00:00
imgRequest.cpp	Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel	2020-07-30 08:55:24 +00:00
imgRequest.h	Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel	2020-07-30 08:55:24 +00:00
imgRequestProxy.cpp	Bug 1519636 - Reformat recent changes to the Google coding style r=andi	2020-08-02 15:29:15 +00:00
imgRequestProxy.h	Bug 1519636 - Reformat recent changes to the Google coding style r=andi	2020-08-02 15:29:15 +00:00
imgTools.cpp	Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj	2020-08-07 07:49:47 +00:00
imgTools.h
IProgressObserver.h	Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp	2020-07-23 14:51:46 +00:00
ISurfaceProvider.h
LookupResult.h	Bug 1631365. img.decode never fulfills or rejects if the image is too big to fit into the surface cache. r=aosmond	2020-04-20 21:04:45 +00:00
moz.build	Bug 1652254 - Remove svg from some moz.build local includes r=dholbert	2020-07-12 16:38:26 +00:00
MultipartImage.cpp
MultipartImage.h
nsIIconURI.idl
Orientation.h	Bug 1616411 - Part 4: Make nsLayoutUtils::OrientImage undo any automatic RasterImage orientation when required. r=tnikkel	2020-04-17 02:57:32 +00:00
OrientedImage.cpp	Bug 1652254 - Remove svg from some moz.build local includes r=dholbert	2020-07-12 16:38:26 +00:00
OrientedImage.h	Bug 1616411 - Part 2: Don't bother passing in the size to OrientedImage::OrientSurface. r=tnikkel	2020-04-17 02:57:22 +00:00
PlaybackType.h
ProgressTracker.cpp	Bug 1620594 - Part 5: Use GetMainThreadSerialEventTarget instead of SystemGroup::EventTargetFor. r=nika	2020-04-07 15:17:07 +00:00
ProgressTracker.h	Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp	2020-07-23 14:51:46 +00:00
RasterImage.cpp	Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg	2020-09-02 09:54:37 +00:00
RasterImage.h	Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp	2020-07-23 14:51:46 +00:00
ScriptedNotificationObserver.cpp
ScriptedNotificationObserver.h
ShutdownTracker.cpp
ShutdownTracker.h
SourceBuffer.cpp	Bug 1642989 - Use RemoveLastElements instead of RemoveElementsAt where possible. r=froydnj	2020-06-08 08:50:15 +00:00
SourceBuffer.h
StreamingLexer.h
SurfaceCache.cpp	Bug 1651587 - Make image::Image released efficient on main thread r=aosmond	2020-07-10 14:34:01 +00:00
SurfaceCache.h	Bug 1651587 - Make image::Image released efficient on main thread r=aosmond	2020-07-10 14:34:01 +00:00
SurfaceCacheUtils.cpp
SurfaceCacheUtils.h
SurfaceFilters.h
SurfaceFlags.h	Bug 1620600 - Add flags to allow image decoders to produce sRGB output. r=tnikkel	2020-04-10 16:26:33 +00:00
SurfacePipe.cpp
SurfacePipe.h
SurfacePipeFactory.h
SVGDocumentWrapper.cpp	Bug 1656117 - Reduce include dependencies on nsRefreshDriver.h. r=mstange	2020-08-04 21:17:50 +00:00
SVGDocumentWrapper.h
SVGDrawingParameters.h	Bug 1652254 - Remove svg from some moz.build local includes r=dholbert	2020-07-12 16:38:26 +00:00
VectorImage.cpp	Bug 1652254 - Remove svg from some moz.build local includes r=dholbert	2020-07-12 16:38:26 +00:00
VectorImage.h