mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 01:35:35 +00:00
7d7ca7e5f3
The problem with this bug was that it did not correspond to animations that
have multiple keyframes with the same offset.
In summary graph, although we were changing the resolution for the graph
creation by the distance of offset between keyframes, as the calculation of
resolution between keyframes with equivalent offset was infinite, generation
was not completed and it was in a state of freezing.
In here, in case of zero distance of offsets, we make avoiding to affect to
changing the resolution.
In addition, the detail graph did not display correctly.
For example, there is an animation below.
div.animate(
[
{
offset: 0,
opacity: 1,
},
{
offset: 0.5,
opacity: 0.5,
},
{
offset: 0.5,
opacity: 0.1,
},
{
offset: 1,
opacity: 1,
},
],
1000
);
In this animation, opacity changes from 1 to 0.5 during 0 - 499ms, from 0.1 to 1
after 500ms.
So, opacity at offset 0.5 behaves 0.5 during 0 - 499ms, 0.1 after 500ms.
Since current animation inspector creates the graph with computed value of the
time of offset, the opacity of offset 0.5 always is 0.1 in the example,
was not correct.
As a solution, same to the actual animation work, create the graph between each
keyframes with range that from start keyframe offset time to just before the
time of end keyframe offset time.
Also, in same offsets, connects between just before the time of the offset time
and the offset time.
So, in the example, we separate as below, then calculate the each coordinates,
then combine as graph shape.
1: 0 ~ 499.999ms
2: 499.999 ~ 500ms (same offsets)
3: 500 ~ 999.999ms
4: 1000ms
MozReview-Commit-ID: p4Cn2N9iFt
--HG--
extra : rebase_source : 0f175fa0b7a3c882171e59a6e4a94bb4802e96d2
|
||
|---|---|---|
| .. | ||
| aboutdebugging | ||
| animationinspector | ||
| canvasdebugger | ||
| commandline | ||
| debugger | ||
| dom | ||
| framework | ||
| inspector | ||
| jsonview | ||
| locales | ||
| memory | ||
| netmonitor | ||
| performance | ||
| performance-new | ||
| preferences | ||
| responsive.html | ||
| scratchpad | ||
| shadereditor | ||
| shared | ||
| sourceeditor | ||
| storage | ||
| styleeditor | ||
| themes | ||
| webaudioeditor | ||
| webconsole | ||
| webide | ||
| .eslintrc.js | ||
| definitions.js | ||
| jar.mn | ||
| menus.js | ||
| moz.build | ||