gecko-dev/UPGRADING.md at 845e499a7c986a6e488172be633988e3bc4a3fb5

mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00

Julian Descottes ad080b4f63 Bug 1406311 - sprintfjs: optimise string-format for %S patterns;r=bgrins

MozReview-Commit-ID: AOi3cUTedX9

--HG--
extra : rebase_source : 2e469aa4ee4cb2df867e3eb328454aad3dc26a2e

2017-10-17 21:11:48 +02:00

920 B

Raw Blame History

SPRINTF JS UPGRADING

Original library at https://github.com/alexei/sprintf.js

This library should no longer be upgraded from upstream. We added performance improvements in https://bugzilla.mozilla.org/show_bug.cgi?id=1406311. Most importantly removing the usage of the get_type() method as well as prioritizing the %S use case.

If for some reason, updating from upstream becomes necessary, please refer to the bug mentioned above to reimplement the performance fixes in the new version.

By default the library only supports string placeholders using %s (lowercase) while we use %S (uppercase). The library also has to be manually patched in order to support it.

grab the unminified version at https://github.com/alexei/sprintf.js/blob/master/src/sprintf.js
update the re.placeholder regexp to allow "S" as well as "s"
update the switch statement in the format() method to make case "S" equivalent to case "s"

920 B Raw Blame History

920 B

Raw Blame History