gecko-dev/layout
Masayuki Nakano 7a894386f2 Bug 1577058 - part 2: Make nsFrameSelection::CommonPageMove() handle nsFrameSelection::ScrollSelectionIntoView() too r=smaug
Currently, `nsFrameSelection::CommonPageMove()` is called before every caller
calls `nsFrameSelection::ScrollSelectionIntoView()`.  However, when an editing
host has focus, the scroll target may be outside of it.  In such case, without
moving caret, user may want only to scroll the scrollable element.

Chrome behaves like so.  Chrome also can scroll outside scrollable element
of focused editing host.  However, it scrolls caret into view only when
caret is moved actually.  Therefore, it makes sense to follow this behavior.

This patch makes `nsFrameSelection::CommonPageMove()` also call
`nsFrameSelection::ScrollSelectionIntoView()`.  However, it newly takes
`SelectionIntoView` flag for making callers can choose the condition.  I.e.,
`ScrollSelectionIntoView()` should be called always, or only when selection
is actually changed, or shouldn't be called.

Differential Revision: https://phabricator.services.mozilla.com/D50178

--HG--
extra : moz-landing-system : lando
2019-10-27 01:44:55 +00:00
..
base Bug 1577058 - part 2: Make nsFrameSelection::CommonPageMove() handle nsFrameSelection::ScrollSelectionIntoView() too r=smaug 2019-10-27 01:44:55 +00:00
build Bug 1584993: Make CSP frame-ancestors work with fission enabled. r=jkt,farre,valentin 2019-10-22 10:57:43 +00:00
doc
forms Bug 1587645 Part 2 - Add WritingMode::IsPhysicalLTR(). r=jfkthame 2019-10-25 20:01:46 +00:00
generic Bug 1577058 - part 2: Make nsFrameSelection::CommonPageMove() handle nsFrameSelection::ScrollSelectionIntoView() too r=smaug 2019-10-27 01:44:55 +00:00
inspector Bug 1590639 part 6: Fix non-unified build issues in layout/inspector. r=emilio 2019-10-24 17:15:32 +00:00
ipc Bug 1556548 - Rename RenderFrame to RemoteLayerTreeOwner. r=mattwoodrow 2019-06-02 13:51:33 -04:00
mathml Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-10-21 14:13:44 +00:00
media
painting Bug 1590639 part 3: Fix non-unified build issues in layout/{forms,painting}. r=TYLin 2019-10-23 22:12:39 +00:00
printing Bug 1521640 - Update android crashtest assertion ranges; r=geckoview-reviewers,snorp 2019-10-15 19:40:24 +00:00
reftests Bug 1589766 - Experiment with implementing zoom as a transform + transform-origin shorthand. r=xidorn 2019-10-26 14:17:28 +00:00
style Bug 1589766 - Experiment with implementing zoom as a transform + transform-origin shorthand. r=xidorn 2019-10-26 14:17:28 +00:00
svg Bug 1590639 part 5: Fix non-unified build issues in layout/svg. r=emilio 2019-10-23 08:16:45 +00:00
tables Bug 1482778 - Include captions within table outlines. r=dbaron 2019-09-22 23:42:04 +00:00
tools Bug 1587142 - Remove most XBL tests in dom/ r=bzbarsky 2019-10-25 22:38:08 +00:00
xul Bug 1587645 Part 2 - Add WritingMode::IsPhysicalLTR(). r=jfkthame 2019-10-25 20:01:46 +00:00
moz.build