Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 10:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
8785168981
gecko-dev/layout/base
History
Masayuki Nakano 7a894386f2 Bug 1577058 - part 2: Make nsFrameSelection::CommonPageMove() handle nsFrameSelection::ScrollSelectionIntoView() too r=smaug 
Currently, `nsFrameSelection::CommonPageMove()` is called before every caller
calls `nsFrameSelection::ScrollSelectionIntoView()`.  However, when an editing
host has focus, the scroll target may be outside of it.  In such case, without
moving caret, user may want only to scroll the scrollable element.

Chrome behaves like so.  Chrome also can scroll outside scrollable element
of focused editing host.  However, it scrolls caret into view only when
caret is moved actually.  Therefore, it makes sense to follow this behavior.

This patch makes `nsFrameSelection::CommonPageMove()` also call
`nsFrameSelection::ScrollSelectionIntoView()`.  However, it newly takes
`SelectionIntoView` flag for making callers can choose the condition.  I.e.,
`ScrollSelectionIntoView()` should be called always, or only when selection
is actually changed, or shouldn't be called.

Differential Revision: https://phabricator.services.mozilla.com/D50178

--HG--
extra : moz-landing-system : lando
2019-10-27 01:44:55 +00:00
..
crashtests Bug 1521640 - Update android crashtest assertion ranges; r=geckoview-reviewers,snorp 2019-10-15 19:40:24 +00:00
doc
gtest Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
tests Bug 1577058 - part 2: Make nsFrameSelection::CommonPageMove() handle nsFrameSelection::ScrollSelectionIntoView() too r=smaug 2019-10-27 01:44:55 +00:00
AccessibleCaret.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
AccessibleCaret.h
AccessibleCaretEventHub.cpp Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika 2019-07-26 16:48:31 +00:00
AccessibleCaretEventHub.h
AccessibleCaretLogger.h
AccessibleCaretManager.cpp Bug 1553772 - Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats 2019-09-26 20:55:58 +00:00
AccessibleCaretManager.h
ArenaObjectID.h Bug 1560188 - Fix and improve display list memory reporting. r=mattwoodrow,njn 2019-07-02 02:46:09 +00:00
AutoProfilerStyleMarker.h Bug 1583271 - Part 1: Change profiler page information IDs to BrowsingContextID and InnerWindowID r=gerald,nika 2019-10-09 21:25:11 +00:00
CaretAssociationHint.h
FrameProperties.h
GeckoMVMContext.cpp Bug 1590639 part 2: Fix non-unified build issues in layout/base. r=TYLin 2019-10-23 22:10:11 +00:00
GeckoMVMContext.h Bug 1551659 - Remove MVMContext::ResizeEventFlag and related code. r=botond,hiro 2019-09-25 19:35:29 +00:00
GeometryUtils.cpp Bug 1567310 Part 2: Make GeometryUtils::GetBoxQuads suppress whitespace frames when requested. r=emilio 2019-09-12 19:05:32 +00:00
GeometryUtils.h
LayoutConstants.h Bug 1549267 Part 2 - Improve comments in LayoutConstants.h. r=mats 2019-06-06 00:04:19 +00:00
LayoutLogging.cpp
LayoutLogging.h
MediaEmulationData.h Bug 1570721 - Add an API to nsPresContext to override the prefers-color-scheme value. r=heycam 2019-08-02 15:18:27 +02:00
MobileViewportManager.cpp Bug 1551659 - Remove MVMContext::ResizeEventFlag and related code. r=botond,hiro 2019-09-25 19:35:29 +00:00
MobileViewportManager.h Bug 1523844 Part 3: Make the MVM set resolution only as an adjustment, not a restore resolution. r=botond 2019-08-12 22:23:34 +00:00
moz.build Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky 2019-10-08 23:52:14 +00:00
MVMContext.h Bug 1551659 - Remove MVMContext::ResizeEventFlag and related code. r=botond,hiro 2019-09-25 19:35:29 +00:00
nsAutoLayoutPhase.cpp Bug 1567818 - Convert nsLayoutPhase into enum class. r=heycam 2019-07-23 05:40:49 +00:00
nsAutoLayoutPhase.h Bug 1567818 - Convert nsLayoutPhase into enum class. r=heycam 2019-07-23 05:40:49 +00:00
nsBidi.cpp
nsBidi.h
nsBidiPresUtils.cpp Bug 1576972 - Keep lastRealFrame up-to-date even when we skip empty text frames. r=jfkthame 2019-08-29 10:14:08 +00:00
nsBidiPresUtils.h Bug 1300293 - Make nsBidiPresUtils track line boxes separately for the progress of TraverseFrames and ResolveParagraph. r=jfkthame 2019-07-22 18:55:56 +00:00
nsCaret.cpp Bug 1582224 - Split SIDEWAYS bit in WritingMode. r=jfkthame,emilio 2019-09-19 02:37:14 +00:00
nsCaret.h
nsChangeHint.h Bug 1590203 - Handle overflow changes more gracefully when possible. r=mattwoodrow 2019-10-21 23:47:31 +00:00
nsCompatibility.h
nsCounterManager.cpp Bug 1578295 - Use cbindgen for counters. r=mats 2019-09-02 23:11:26 +00:00
nsCounterManager.h Bug 1578295 - Use cbindgen for counters. r=mats 2019-09-02 23:11:26 +00:00
nsCSSColorUtils.cpp
nsCSSColorUtils.h
nsCSSFrameConstructor.cpp Bug 1590897 - Remove support for XUL <spring> element. r=mats 2019-10-24 14:55:25 +00:00
nsCSSFrameConstructor.h Bug 1578844 - Fix various issues with display: contents within svg text. r=mats 2019-10-12 16:28:13 +00:00
nsDocumentViewer.cpp Bug 1561227 Part 1: Make nsDocumentViewer send a new event before setting full zoom levels on the pres contexts. r=emilio 2019-10-25 21:05:42 +00:00
nsFrameManager.cpp Bug 1566945 - Add a parameter to nsContainerFrame::InsertFrames for aPrevFrame's line box. r=dholbert 2019-07-17 23:34:45 +00:00
nsFrameManager.h
nsFrameTraversal.cpp
nsFrameTraversal.h
nsGenConList.cpp Bug 1510785 - Only build XBL related code when MOZ_XBL is defined. r=bzbarsky 2019-10-08 23:52:14 +00:00
nsGenConList.h Bug 1552719 - Make nsBulletFrame::Ordinal() O(1) again. r=mats 2019-05-21 17:30:42 +00:00
nsIDocumentViewerPrint.h
nsIFrameTraversal.h
nsILayoutHistoryState.idl Bug 1551652. Stop using [array] in nsILayoutHistoryState. r=heycam 2019-05-16 00:36:41 +00:00
nsIPercentBSizeObserver.h
nsIPreloadedStyleSheet.idl
nsIReflowCallback.h
nsIStyleSheetService.idl
nsLayoutDebugger.cpp Bug 1566215 - Part 2: Merge nsILayoutDebugger functionality into nsLayoutDebuggingTools. r=dbaron 2019-07-22 04:48:33 +00:00
nsLayoutHistoryState.cpp Bug 1551652. Stop using [array] in nsILayoutHistoryState. r=heycam 2019-05-16 00:36:41 +00:00
nsLayoutUtils.cpp Bug 1590639 part 2: Fix non-unified build issues in layout/base. r=TYLin 2019-10-23 22:10:11 +00:00
nsLayoutUtils.h Backed out changeset 77357e0aa88e (bug 1584859) for wpt and mochitest failures. on a CLOSED TREE 2019-10-13 14:06:44 +03:00
nsPresArena.cpp Bug 1590639 part 2: Fix non-unified build issues in layout/base. r=TYLin 2019-10-23 22:10:11 +00:00
nsPresArena.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-07-16 07:33:44 +00:00
nsPresArenaObjectList.h Bug 1560188 - Fix and improve display list memory reporting. r=mattwoodrow,njn 2019-07-02 02:46:09 +00:00
nsPresContext.cpp Bug 1590551. Allow nsPresContext::GetNearestWidget to work when there is no frame tree. r=botond 2019-10-23 23:37:11 +00:00
nsPresContext.h Bug 1590551. Allow nsPresContext::GetNearestWidget to work when there is no frame tree. r=botond 2019-10-23 23:37:11 +00:00
nsPresContextInlines.h
nsQuoteList.cpp Bug 1421938 - Add an 'auto' value for the CSS 'quotes' property, and make it use language-dependent quote marks. r=emilio 2019-07-09 08:59:27 +00:00
nsQuoteList.h
nsRefreshDriver.cpp Bug 1578851 - Using VRManagerChild to check isPresenting to skip painting in nsRefreshDriver. r=rbarker,imanol,mstange 2019-10-24 19:58:15 +00:00
nsRefreshDriver.h
nsStyleChangeList.cpp
nsStyleChangeList.h
nsStyleSheetService.cpp Bug 1571530 - Remove various bool arguments in sheet loader APIs. r=heycam 2019-08-16 10:56:05 +00:00
nsStyleSheetService.h
OverflowChangedTracker.h Bug 1544995 - Always update overflow areas up to the preserve-3d root. r=dbaron 2019-05-19 22:39:58 +00:00
PositionedEventTargeting.cpp
PositionedEventTargeting.h
PresShell.cpp Bug 1577058 - part 2: Make nsFrameSelection::CommonPageMove() handle nsFrameSelection::ScrollSelectionIntoView() too r=smaug 2019-10-27 01:44:55 +00:00
PresShell.h Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-10-06 18:29:55 +00:00
PresShellForwards.h Bug 1551659 - Remove MVMContext::ResizeEventFlag and related code. r=botond,hiro 2019-09-25 19:35:29 +00:00
PresShellInlines.h Bug 1571612 - P2: Collect flush req and flush telemetry. r=heycam 2019-08-21 01:43:30 +00:00
PresState.ipdlh
RestyleManager.cpp Bug 1590203 - Handle overflow changes more gracefully when possible. r=mattwoodrow 2019-10-21 23:47:31 +00:00
RestyleManager.h Bug 1585882 - Fix the case where where a node with an up-to-date style loses its frame due to a DOM mutation of siblings. r=heycam 2019-10-06 23:30:23 +00:00
ScrollStyles.cpp Bug 1590281 - Don't propagate overscroll-behavior from body to viewport. r=hiro 2019-10-22 12:16:13 +00:00
ScrollStyles.h Bug 1590281 - Don't propagate overscroll-behavior from body to viewport. r=hiro 2019-10-22 12:16:13 +00:00
ScrollTypes.h
ShapeUtils.cpp Bug 1561738 - Remove nsStyleCoord. r=boris 2019-06-28 12:44:44 +02:00
ShapeUtils.h Bug 1561738 - Remove nsStyleCoord. r=boris 2019-06-28 12:44:44 +02:00
StackArena.cpp
StackArena.h
StaticPresData.cpp
StaticPresData.h
TouchManager.cpp Bug 1543439 - Part 2: Move is-user-interaction checks out of PresShell::EventHandler::PrepareToDispatchEvent; r=masayuki 2019-05-27 10:14:06 +00:00
TouchManager.h Bug 1543439 - Part 2: Move is-user-interaction checks out of PresShell::EventHandler::PrepareToDispatchEvent; r=masayuki 2019-05-27 10:14:06 +00:00
Units.h Bug 1568673 part 1: Adjust MobileViewportManager::ComputeIntrinsicScale to prevent divide-by-zero and to allow for meaningful min/max clamping. r=botond 2019-07-27 00:11:20 +00:00
UnitTransforms.h Bug 1565525 - Add helper functions to make working with Maybe<Matrix> easier. r=hsivonen 2019-08-20 06:36:01 +00:00
WordMovementType.h
ZoomConstraintsClient.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
ZoomConstraintsClient.h