gecko-dev/dom/html
Kris Maglione 878d4b6711 Bug 1595936: Part 2 - Refresh feature policy when attaching browsing context. r=farre,baku
We go to great lengths to try to avoid initializing FrameLoaders during
document updates. That means that when `BindToTree` is called, the element's
FrameLoader is not initialized, and it has no BrowsingContext. Calling
`GetBrowsingContext()` (which happens as a side-effect of
`HTMLIFrameElement::RefreshFeaturePolicy`), however, forces eager
initialization, which can cause any number of problems.

This patch moves that logic from being triggered by `BindToTree` to being
triggered by `BrowsingContext::Embed`, which happens as soon as the
BrowsingContext is bound to the element, but does not force it to be created
early.

Differential Revision: https://phabricator.services.mozilla.com/D55872

--HG--
extra : moz-landing-system : lando
2020-01-24 19:03:10 +00:00
..
crashtests Bug 1587142 - Remove most XBL tests in dom/ r=bzbarsky 2019-10-25 22:38:08 +00:00
input Bug 981248 - Rewrite <input type=number> to avoid an anonymous input. r=masayuki,surkov,jwatt,ntim,jfkthame,smaug 2020-01-14 19:01:05 +00:00
reftests Bug 1591641 - annotate select-load.html with fuzzy-if condition for Android r=gbrown 2019-10-30 21:25:22 +00:00
test Bug 1606043 - Make TextControlState::SetValueWithoutTextEditor() notify the text control element of value changed before dispatching eEditorInput event r=smaug 2020-01-23 17:50:37 +00:00
components.conf
ElementInternals.cpp Bug 1552313 - Implement element.attachInternals; r=smaug,edgar 2019-11-12 11:27:55 +00:00
ElementInternals.h Bug 1552313 - Implement element.attachInternals; r=smaug,edgar 2019-11-12 11:27:55 +00:00
HTMLAllCollection.cpp Bug 1558571 - Move HTMLDocument.all to Document; r=farre 2019-07-09 18:09:40 +00:00
HTMLAllCollection.h Bug 1558571 - Move HTMLDocument.all to Document; r=farre 2019-07-09 18:09:40 +00:00
HTMLAnchorElement.cpp Bug 1586008 - Factor out IsNodeInEditableRegion. r=bzbarsky 2019-10-05 11:39:16 +00:00
HTMLAnchorElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLAreaElement.cpp Bug 1555216 - Cache owner doc in the BindContext. r=bzbarsky 2019-05-31 23:31:57 +02:00
HTMLAreaElement.h Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLAudioElement.cpp
HTMLAudioElement.h
HTMLBodyElement.cpp Bug 1606659 - Don't pass margin and scrollbar preferences to nsFrameLoader::Show. r=mattwoodrow 2020-01-05 22:48:40 +00:00
HTMLBodyElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLBRElement.cpp
HTMLBRElement.h Bug 1569902 - part 2: Stop using attribute to consider whether a <br> element is a special node for empty last line or not r=m_kato,smaug 2019-08-02 05:45:18 +00:00
HTMLButtonElement.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLButtonElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLCanvasElement.cpp Bug 1588980 - Part 2: Remove the deprecation warning for HTMLCanvasElement.mozGetAsFile; r=bzbarsky 2020-01-20 22:02:59 +00:00
HTMLCanvasElement.h Bug 1477756 - Client-side bindings mirror for precise CC, and merge similar codepaths. r=handyman 2020-01-08 22:19:16 +00:00
HTMLDataElement.cpp
HTMLDataElement.h
HTMLDataListElement.cpp
HTMLDataListElement.h
HTMLDetailsElement.cpp
HTMLDetailsElement.h
HTMLDialogElement.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
HTMLDialogElement.h
HTMLDivElement.cpp
HTMLDivElement.h
HTMLElement.cpp
HTMLEmbedElement.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLEmbedElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLFieldSetElement.cpp
HTMLFieldSetElement.h
HTMLFontElement.cpp
HTMLFontElement.h
HTMLFormControlsCollection.cpp
HTMLFormControlsCollection.h
HTMLFormElement.cpp Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj 2020-01-20 16:19:48 +00:00
HTMLFormElement.h Bug 1552301 - Implement form.requestSubmit(); r=smaug 2019-12-03 10:13:41 +00:00
HTMLFormSubmission.cpp Bug 461204 - Improve the random number generator for the boundaries in multipart/form-data r=smaug 2020-01-13 20:41:14 +00:00
HTMLFormSubmission.h Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug 2019-09-20 20:51:25 +00:00
HTMLFormSubmissionConstants.h
HTMLFrameElement.cpp Bug 1560055 part 2. Switch frame/iframe marginwidth/height parsing to follow the spec. r=mccr8 2019-06-28 20:54:30 +00:00
HTMLFrameElement.h
HTMLFrameSetElement.cpp Bug 1593222: part 12) Rename "nsNodeUtils.*" to "MutationObservers.*". r=smaug 2019-11-06 09:08:06 +00:00
HTMLFrameSetElement.h
HTMLHeadingElement.cpp Bug 1590366 - Remove accessibility.heading-element-level-changes.enabled. r=MarcoZ 2019-10-22 13:51:41 +00:00
HTMLHeadingElement.h Bug 1590366 - Remove accessibility.heading-element-level-changes.enabled. r=MarcoZ 2019-10-22 13:51:41 +00:00
HTMLHRElement.cpp Bug 1560055 part 3. Switch various "width" and "height" attributes on HTML elements to mostly follow the spec for parsing the attribute. r=mccr8 2019-06-28 20:56:55 +00:00
HTMLHRElement.h
HTMLIFrameElement.cpp Bug 1595936: Part 2 - Refresh feature policy when attaching browsing context. r=farre,baku 2020-01-24 19:03:10 +00:00
HTMLIFrameElement.h Bug 1595936: Part 2 - Refresh feature policy when attaching browsing context. r=farre,baku 2020-01-24 19:03:10 +00:00
HTMLImageElement.cpp Bug 1608905 - Parse the HTMLImageElement.loading attribute. r=smaug 2020-01-13 21:10:43 +00:00
HTMLImageElement.h Bug 1608905 - Parse the HTMLImageElement.loading attribute. r=smaug 2020-01-13 21:10:43 +00:00
HTMLInputElement.cpp Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan 2020-01-21 09:51:27 +00:00
HTMLInputElement.h Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug 2020-01-16 14:38:40 +00:00
HTMLLabelElement.cpp Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug 2020-01-16 14:38:40 +00:00
HTMLLabelElement.h Bug 1432856 - Extended focus methods in Window.webidl, Client.webidl and Element.webidl to pass CallerType. r=smaug 2020-01-16 14:38:40 +00:00
HTMLLegendElement.cpp Bug 1341018 - Create enum class LegendAlignValue to replace NS_STYLE_TEXT_ALIGN_* and NS_STYLE_VERTICAL_ALIGN_* in legend code. r=emilio 2020-01-23 03:10:03 +00:00
HTMLLegendElement.h Bug 1341018 - Create enum class LegendAlignValue to replace NS_STYLE_TEXT_ALIGN_* and NS_STYLE_VERTICAL_ALIGN_* in legend code. r=emilio 2020-01-23 03:10:03 +00:00
HTMLLIElement.cpp
HTMLLIElement.h
HTMLLinkElement.cpp Bug 1605814 - Don't capture CSP nonce when loading a child sheet. r=emilio,ckerschb 2020-01-13 11:47:25 +00:00
HTMLLinkElement.h Bug 1587457 - Remove Element::GetTokenList. r=bzbarsky 2019-10-11 04:09:40 +00:00
HTMLMapElement.cpp
HTMLMapElement.h
HTMLMarqueeElement.cpp Bug 1562257 part 4. Fix style mapping of hspace and vspace attributes to match the spec. r=mccr8 2019-06-28 23:51:43 +00:00
HTMLMarqueeElement.h Bug 1562257 part 4. Fix style mapping of hspace and vspace attributes to match the spec. r=mccr8 2019-06-28 23:51:43 +00:00
HTMLMediaElement.cpp Bug 1595603 - part2 : delay seeking task when media is inactive r=bryce 2020-01-09 17:10:08 +00:00
HTMLMediaElement.h Bug 1595603 - part1 : remove duplicate parameter and rename variable r=bryce 2020-01-09 06:10:02 +00:00
HTMLMenuBuilder.jsm Bug 1577746 - Enable ESLint rule object-shorthand for dom/. r=baku 2019-09-02 11:22:27 +00:00
HTMLMenuElement.cpp Bug 1565767 part 5. Remove some unnecesary refcounting at nsIContent::GetBaseURI callsites. r=peterv 2019-07-15 18:29:05 +00:00
HTMLMenuElement.h
HTMLMenuItemElement.cpp Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLMenuItemElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLMetaElement.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLMetaElement.h Bug 1498729 - Handle the cases where the name of viewport meta tag changes. r=smaug,botond 2019-07-25 04:26:04 +00:00
HTMLMeterElement.cpp
HTMLMeterElement.h
HTMLModElement.cpp
HTMLModElement.h
HTMLObjectElement.cpp Bug 1589027 - Fix object.tabIndex should return 0 by default; r=smaug 2019-10-28 15:50:59 +00:00
HTMLObjectElement.h Bug 1589027 - Fix object.tabIndex should return 0 by default; r=smaug 2019-10-28 15:50:59 +00:00
HTMLOptGroupElement.cpp
HTMLOptGroupElement.h
HTMLOptionElement.cpp Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLOptionElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLOptionsCollection.cpp Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen 2019-06-13 08:58:07 +00:00
HTMLOptionsCollection.h
HTMLOutputElement.cpp Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLOutputElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLParagraphElement.cpp
HTMLParagraphElement.h
HTMLPictureElement.cpp
HTMLPictureElement.h
HTMLPreElement.cpp
HTMLPreElement.h
HTMLProgressElement.cpp
HTMLProgressElement.h
HTMLScriptElement.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLScriptElement.h Bug 1528697 - Expose ReferrerPolicy.webidl and use referrerpolicy enum r=smaug 2019-08-21 13:24:45 +00:00
HTMLSelectElement.cpp Bug 1581537 - Avoid several browser language leaks r=smaug 2019-11-04 16:56:27 +00:00
HTMLSelectElement.h Bug 1570982 - remove CPP_THROW_NEW; r=glandium 2019-08-14 01:32:41 +00:00
HTMLSharedElement.cpp Bug 1555216 - Cache owner doc in the BindContext. r=bzbarsky 2019-05-31 23:31:57 +02:00
HTMLSharedElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLSharedListElement.cpp
HTMLSharedListElement.h
HTMLSlotElement.cpp Bug 1554498 - Don't use nsIMutationObserver for ShadowRoot. r=smaug 2019-08-27 22:10:46 +00:00
HTMLSlotElement.h Bug 1554498 - Don't use nsIMutationObserver for ShadowRoot. r=smaug 2019-08-27 22:10:46 +00:00
HTMLSourceElement.cpp Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLSourceElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLSpanElement.cpp
HTMLSpanElement.h Bug 1602421 - Remove some useless includes. r=jfkthame 2019-12-09 14:53:50 +00:00
HTMLStyleElement.cpp Bug 1605814 - Don't capture CSP nonce when loading a child sheet. r=emilio,ckerschb 2020-01-13 11:47:25 +00:00
HTMLStyleElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLSummaryElement.cpp
HTMLSummaryElement.h
HTMLTableCaptionElement.cpp
HTMLTableCaptionElement.h
HTMLTableCellElement.cpp Bug 1562257 part 1. Remove pointless parsing of "charoff" attributes. r=mccr8 2019-06-28 23:31:57 +00:00
HTMLTableCellElement.h Bug 1560055 part 5. Fix various reflection cases that should be using GetUnsignedIntAttr but are using GetIntAttr. r=mccr8 2019-06-28 20:57:44 +00:00
HTMLTableColElement.cpp Bug 1560055 part 4. Remove remaining uses of ParseSpecialIntValue. r=mccr8 2019-06-28 21:00:15 +00:00
HTMLTableColElement.h Bug 1560055 part 5. Fix various reflection cases that should be using GetUnsignedIntAttr but are using GetIntAttr. r=mccr8 2019-06-28 20:57:44 +00:00
HTMLTableElement.cpp Bug 1562257 part 4. Fix style mapping of hspace and vspace attributes to match the spec. r=mccr8 2019-06-28 23:51:43 +00:00
HTMLTableElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLTableRowElement.cpp Bug 1562257 part 1. Remove pointless parsing of "charoff" attributes. r=mccr8 2019-06-28 23:31:57 +00:00
HTMLTableRowElement.h
HTMLTableSectionElement.cpp Bug 1562257 part 1. Remove pointless parsing of "charoff" attributes. r=mccr8 2019-06-28 23:31:57 +00:00
HTMLTableSectionElement.h
HTMLTemplateElement.cpp
HTMLTemplateElement.h
HTMLTextAreaElement.cpp Bug 1599971 - part 5: Mark TextControlState::UnbindFromFrame() as MOZ_CAN_RUN_SCRIPT r=m_kato,emilio 2019-12-11 03:04:20 +00:00
HTMLTextAreaElement.h Bug 970802 - part 4: Make TextControlState dispatch "beforeinput" event if there is no TextEditor r=smaug 2020-01-14 07:16:34 +00:00
HTMLTimeElement.cpp
HTMLTimeElement.h
HTMLTitleElement.cpp Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLTitleElement.h Bug 1555216 - Change the signature of BindToTree to be (BindContext&, nsINode& aParentNode). r=bzbarsky 2019-05-31 23:31:52 +02:00
HTMLTrackElement.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLTrackElement.h Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
HTMLUnknownElement.cpp
HTMLUnknownElement.h
HTMLVideoElement.cpp Bug 1602163 - part2 : remove 'corruptedFrames' from 'VideoPlaybackQuality' r=bzbarsky 2019-12-11 07:19:15 +00:00
HTMLVideoElement.h Bug 1536156 - Let cloneElementVisually() return a promise that resolves when frames have been rendered. r=alwu,mconley,bzbarsky 2019-11-22 12:52:48 +00:00
ImageDocument.cpp Bug 1601475 - Remove ImageContentLoaded event and ImageDocumentLoaded message handling code across the tree r=Gijs,mccr8 2019-12-18 21:46:51 +00:00
ImageDocument.h
MediaDocument.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
MediaDocument.h Bug 1581537 - Avoid several browser language leaks r=smaug 2019-11-04 16:56:27 +00:00
MediaError.cpp
MediaError.h
moz.build Bug 1597679 - part 2: Make nsITextControlElement inherit nsGenericHTMLFormElementWithState r=smaug 2019-11-25 06:35:15 +00:00
nsBrowserElement.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
nsBrowserElement.h
nsDOMStringMap.cpp
nsDOMStringMap.h
nsGenericHTMLElement.cpp Bug 1607918. Fix case handling for webkit-prefixed transition/animation event handlers. r=smaug. 2020-01-13 20:04:59 +00:00
nsGenericHTMLElement.h Bug 1552313 - Implement element.attachInternals; r=smaug,edgar 2019-11-12 11:27:55 +00:00
nsGenericHTMLFrameElement.cpp Bug 1588791 - Make fission iframes honor and deal with the scrolling attribute. r=mattwoodrow 2020-01-13 11:30:44 +00:00
nsGenericHTMLFrameElement.h Bug 1603889 - Simplify the scrollbar preference setup. r=smaug 2019-12-15 22:56:23 +00:00
nsHTMLContentSink.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
nsHTMLDNSPrefetch.cpp Bug 1552176 - pass TRRMode into nsHTMLDNSPrefetch methods r=dragana 2020-01-07 19:33:51 +00:00
nsHTMLDNSPrefetch.h Bug 1552176 - pass TRRMode into nsHTMLDNSPrefetch methods r=dragana 2020-01-07 19:33:51 +00:00
nsHTMLDocument.cpp Bug 1597029 - Set securityInfo for all document types. r=baku 2020-01-09 14:55:02 +00:00
nsHTMLDocument.h Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan 2019-12-06 09:24:56 +00:00
nsIConstraintValidation.cpp
nsIConstraintValidation.h
nsIForm.h
nsIFormControl.h Bug 981248 - Rewrite <input type=number> to avoid an anonymous input. r=masayuki,surkov,jwatt,ntim,jfkthame,smaug 2020-01-14 19:01:05 +00:00
nsIFormSubmitObserver.idl
nsIHTMLCollection.h
nsIImageDocument.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsIMenuBuilder.idl
nsIRadioGroupContainer.h
nsIRadioVisitor.h
nsRadioVisitor.cpp
nsRadioVisitor.h
PlayPromise.cpp Bug 1591655 - Remove the unnecessary |proto| argument from |JS::NewPromiseObject| and its callers, seeing as all callers pass |nullptr| (and therefore uniformly request the default prototype). r=jandem,bzbarsky 2019-10-26 08:14:05 +00:00
PlayPromise.h
PluginDocument.cpp Bug 1605934 - Use nested namespaces r=sg 2020-01-18 13:48:34 +00:00
RadioNodeList.cpp
RadioNodeList.h
TextControlElement.h Bug 1599971 - part 5: Mark TextControlState::UnbindFromFrame() as MOZ_CAN_RUN_SCRIPT r=m_kato,emilio 2019-12-11 03:04:20 +00:00
TextControlState.cpp Bug 1540043 - part 1: Move all constants and methods of nsIPlaintextEditor to nsIEditor and make nsIPlaintextEditor inherit nsIEditor r=m_kato 2020-01-24 08:33:42 +00:00
TextControlState.h Bug 1540043 - part 1: Move all constants and methods of nsIPlaintextEditor to nsIEditor and make nsIPlaintextEditor inherit nsIEditor r=m_kato 2020-01-24 08:33:42 +00:00
TextInputListener.h Bug 1597679 - part 2: Make nsITextControlElement inherit nsGenericHTMLFormElementWithState r=smaug 2019-11-25 06:35:15 +00:00
TextTrackManager.cpp Bug 1600353 - Make TextTrackSource and TextTrackReadyState enum classes. r=bzbarsky 2019-12-02 19:13:11 +00:00
TextTrackManager.h Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce 2019-08-02 18:17:45 +00:00
TimeRanges.cpp
TimeRanges.h
ValidityState.cpp
ValidityState.h
VideoDocument.cpp Bug 1564449, ensure the right body element is used throughout the method call, r=mccr8 2019-08-06 16:43:01 +03:00