mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-20 08:45:46 +00:00
ee1f6d7a78
We have the `LauncherRegistryInfo` class to check the launcher process was launched successfully on Windows by comparing the timestamps in the registry when each process was launched. The problem was when the process is launched from an elevated process, we relaunch a new launcher process via shell after we updated the launcher's timestamp. As a result, `LauncherRegistryInfo` unexpectedly disabled the launcher process even though there was nothing wrong. A proposed fix is to introduce delay-write to the `LauncherRegistryInfo`. With this, `LauncherRegistryInfo::Check` modifies only the image timestamp. To update the launcher/browser timestamps, we need to call `LauncherRegistryInfo::Commit`. When we ask shell to relaunch a new process, we hold back commit, delegating it to the new process. There is another consideration needed. If something fails during `LauncherMain`, we call `DisableDueToFailure()` to disable the launcher until the image timestamp is changed. In such a case, we should not change the stored timestamps even though commit is attempted. The problem is we use a different instance to call `DisableDueToFailure()` in `HandleLauncherError`. To deal with this design, `LauncherRegistryInfo` has a static boolean to indicate disablement happens or not. Differential Revision: https://phabricator.services.mozilla.com/D44928 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| awsy | ||
| condprofile | ||
| config | ||
| crashtest | ||
| extensions | ||
| firefox-ui | ||
| geckodriver | ||
| gtest | ||
| jsshell | ||
| marionette | ||
| mochitest | ||
| modules | ||
| mozbase | ||
| mozharness | ||
| profiles | ||
| raptor | ||
| runtimes | ||
| specialpowers | ||
| talos | ||
| tools | ||
| tps | ||
| web-platform | ||
| webdriver | ||
| xpcshell | ||
| addtest.py | ||
| cppunittest.ini | ||
| mach_commands.py | ||
| moz.build | ||
| parse_build_tests_ccov.py | ||
| README.txt | ||
| remotecppunittests.py | ||
| runcppunittests.py | ||
| testsuite-targets.mk | ||
Common testing tools for mozilla codebase projects, test suite definitions for automated test runs, tests that don't fit anywhere else, and other fun stuff