Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
ddeb475085
gecko-dev/gfx/layers
History
Timothy Nikkel ddeb475085 Bug 1687927. Don't request a repaint for a scroll update of type NewScrollFrame that doesn't change the scroll offset. r=botond 
https://searchfox.org/mozilla-central/rev/2c06b16a0c15ae340a0532e319cbf89ef9d21b68/gfx/layers/apz/src/AsyncPanZoomController.cpp#4866

scrollOffsetUpdated gets set to true if we get basically any scroll update, including a NewScrollFrame update that we create for every new scroll frame that just informs apzc the scroll offset is (0,0).

scrollOffsetUpdated being true means RequestContentRepaint gets called a little later. RequestContentRepaint causes a full display port to be set on the content. That is undesirable because we set zero margin display ports (via SetZeroMarginDisplayPortOnAsyncScrollableAncestors) and we don't want to expand them to full display ports.

This bug is to fix the regression caused by bug 1662013. Two other bugs also regressed this (bug 1627012 and bug 1667475), and we need to fix all of them to fix the problem. Bug 1687886 is filed for the regression from bug 1667475. Bug 1687926 is filed for the regression from bug 1627012.

Before https://hg.mozilla.org/integration/autoland/rev/b78646d59e32 we only set scrollOffsetUpdated to true if GetScrollOffsetUpdated() was set to true on the metrics, and it didn't get set to true for new scroll frames.

Differential Revision: https://phabricator.services.mozilla.com/D102587
2021-02-02 04:24:08 +00:00
..
apz Bug 1687927. Don't request a repaint for a scroll update of type NewScrollFrame that doesn't change the scroll offset. r=botond 2021-02-02 04:24:08 +00:00
basic Bug 1660470 - Split SurfaceDescriptor.h from ShadowLayerUtils.h. r=mattwoodrow 2020-12-10 11:09:39 +00:00
client Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
composite Bug 1687239 part 2 - Remove plugin support from layout/. r=emilio 2021-01-25 11:53:49 +00:00
d3d11 Bug 1687427 - Update display list when ExternalCompositing is changed r=mattwoodrow 2021-01-19 21:42:57 +00:00
ipc Bug 1687886. Don't request a repaint and set a display port if it's the first time for an azpc getting metrics always. r=botond 2021-02-01 11:15:04 +00:00
layerviewer Bug 1679758 - Remove trailing empty lines r=sylvestre,marionette-reviewers,jgraham 2020-12-15 10:34:54 +00:00
mlgpu Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
opengl Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
protobuf Bug 1627444 p2 - Regenerate protobuf classes r=lina 2020-04-07 18:05:56 +00:00
wr Bug 1688144 - Add more error logs to WebRenderBridgeParent::UpdateResources() r=nical,aosmond 2021-01-22 12:42:28 +00:00
AndroidHardwareBuffer.cpp Bug 1670543 - Remove fence argument from AndroidHardwareBuffer::Unlock() r=jnicol 2020-10-13 00:31:30 +00:00
AndroidHardwareBuffer.h Bug 1670543 - Remove fence argument from AndroidHardwareBuffer::Unlock() r=jnicol 2020-10-13 00:31:30 +00:00
AnimationHelper.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
AnimationHelper.h Bug 1677284 - Remove unused includes of Variant.h. r=andi 2020-11-23 15:49:20 +00:00
AnimationInfo.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
AnimationInfo.h Bug 1638152 - Inform transform value in the clip rectangle and the offset from the reference frame for the partial pre-render check on WebRender. r=botond 2020-07-21 10:09:06 +00:00
AnimationStorageData.h Bug 1324591 - Jank if we are trying to composite area which is outside of the the partial prerender rect on non WebRender. r=botond,jrmuizel 2020-07-05 11:44:18 +00:00
AtomicRefCountedWithFinalize.h
AxisPhysicsModel.cpp Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
AxisPhysicsModel.h
AxisPhysicsMSDModel.cpp Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
AxisPhysicsMSDModel.h
BSPTree.cpp
BSPTree.h Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj 2020-01-20 16:19:48 +00:00
BufferTexture.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
BufferTexture.h Bug 1595994 - P1D. Properly serialize display size when sending image over IPC. r=mattwoodrow 2020-10-20 23:30:04 +00:00
BuildConstants.h Bug 1659225 - Apply UNPACK_ params only after init. r=lsalzman 2020-08-23 06:09:33 +00:00
CanvasDrawEventRecorder.cpp Bug 1674834: Check that 2D Canvas recorder has initialized. r=jrmuizel 2020-11-04 15:32:02 +00:00
CanvasDrawEventRecorder.h Bug 1641256: Don't deactivate remote canvas due to read error when the writer has already failed. r=jrmuizel 2020-07-07 19:30:14 +00:00
CanvasRenderer.cpp Bug 1668575 - Disable DMABUF with software WebRender. r=mattwoodrow 2020-10-15 03:41:46 +00:00
CanvasRenderer.h Bug 1654211 - Hold WeakPtr to PresistentBufferProvider in BorrowedSourceSurface. r=gfx-reviewers,nical 2020-08-25 15:36:11 +00:00
CompositionRecorder.cpp Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
CompositionRecorder.h
Compositor.cpp Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
Compositor.h Bug 1627716 - Remove now-unused SetRenderOffset code related to DynamicToolbarAnimator. r=jrmuizel 2020-04-22 11:50:40 +00:00
CompositorAnimationStorage.cpp Bug 1679272 - Include ScopeExit.h exactly where used. r=andi 2020-12-07 14:25:59 +00:00
CompositorAnimationStorage.h Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
CompositorTypes.cpp Bug 1666802 - Move the TextureFlags serializer into an ostream operator. r=mattwoodrow 2020-10-11 21:19:32 +00:00
CompositorTypes.h Bug 1674878 - Expose more detailed WR backend information to TextureFactoryIdentifier. r=jrmuizel 2020-11-03 18:24:43 +00:00
D3D9SurfaceImage.cpp Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman 2021-01-14 01:23:06 +00:00
D3D9SurfaceImage.h Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman 2021-01-14 01:23:06 +00:00
D3D11ShareHandleImage.cpp
D3D11ShareHandleImage.h Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman 2021-01-14 01:23:06 +00:00
D3D11YCbCrImage.cpp Bug 1595994 - P1D. Properly serialize display size when sending image over IPC. r=mattwoodrow 2020-10-20 23:30:04 +00:00
D3D11YCbCrImage.h Bug 1618458 - Clean up TextureClientRecycleAllocator r=nical 2020-02-27 13:34:08 +00:00
DirectedGraph.h
DirectionUtils.h
DMABUFSurfaceImage.cpp Bug 1660336 Build ffvpx FFmpegVideoDecoder module with VAAPI support, r=jya,glandium,jgilbert 2020-12-08 15:26:09 +00:00
DMABUFSurfaceImage.h Bug 1660336 Build ffvpx FFmpegVideoDecoder module with VAAPI support, r=jya,glandium,jgilbert 2020-12-08 15:26:09 +00:00
Effects.cpp Bug 1666802 - Remove LayersLogging.*. r=mattwoodrow 2020-10-11 21:20:46 +00:00
Effects.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
FrameMetrics.cpp Bug 1687927. Don't request a repaint for a scroll update of type NewScrollFrame that doesn't change the scroll offset. r=botond 2021-02-02 04:24:08 +00:00
FrameMetrics.h Bug 1687927. Don't request a repaint for a scroll update of type NewScrollFrame that doesn't change the scroll offset. r=botond 2021-02-02 04:24:08 +00:00
GLImages.cpp Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
GLImages.h Bug 1648076 - Use AndroidSurfaceTexture related files only on Android r=jgilbert 2020-06-24 18:59:14 +00:00
GPUVideoImage.h Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman 2021-01-14 01:23:06 +00:00
ImageContainer.cpp Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman 2021-01-14 01:23:06 +00:00
ImageContainer.h Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman 2021-01-14 01:23:06 +00:00
ImageDataSerializer.cpp Bug 1595994 - P1D. Properly serialize display size when sending image over IPC. r=mattwoodrow 2020-10-20 23:30:04 +00:00
ImageDataSerializer.h Bug 1595994 - P1D. Properly serialize display size when sending image over IPC. r=mattwoodrow 2020-10-20 23:30:04 +00:00
ImageLayers.cpp Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
ImageLayers.h Bug 1610388 - Remove nsAutoPtr usage from gfx/. r=mattwoodrow 2020-01-21 01:25:28 +00:00
ImageTypes.h Bug 1645704 [Wayland] Rename WaylandDMABufSurface to DMABufSurface at gxf, r=sotaro 2020-06-21 13:59:17 +00:00
IMFYCbCrImage.cpp
IMFYCbCrImage.h
IPDLActor.h
LayerAttributes.h Bug 1613009 - Make SimpleLayerAttributes explicitly serialized. r=botond 2020-03-13 19:59:04 +00:00
LayerManager.cpp Bug 1677929 - Record payloads with the correct composition end timestamp. r=kats 2020-12-08 22:40:33 +00:00
LayerManager.h Bug 1677929 - Record payloads with the correct composition end timestamp. r=kats 2020-12-08 22:40:33 +00:00
LayerMetricsWrapper.h Bug 1610731 - Remove GetIsStickyPosition and clean up some TODOs. r=botond 2020-04-04 06:16:57 +00:00
Layers.cpp Bug 1677929 - Record payloads with the correct composition end timestamp. r=kats 2020-12-08 22:40:33 +00:00
Layers.h Bug 1677929 - Record payloads with the correct composition end timestamp. r=kats 2020-12-08 22:40:33 +00:00
LayerScope.cpp Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
LayerScope.h
LayersHelpers.cpp
LayersHelpers.h
LayerSorter.cpp Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj 2020-06-10 10:46:14 +00:00
LayerSorter.h
LayersTypes.cpp Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
LayersTypes.h Bug 1624264 - Use different texture cache sizes for popup windows. r=jrmuizel 2020-12-18 09:27:19 +00:00
LayerTreeInvalidation.cpp Bug 1666802 - Remove LayersLogging.*. r=mattwoodrow 2020-10-11 21:20:46 +00:00
LayerTreeInvalidation.h
LayerUserData.h
MacIOSurfaceHelpers.cpp Bug 1659760 - Specify correct FOURCC yuv type when converting IOSurfaces to RGB. r=miko 2020-08-26 12:46:37 +00:00
MacIOSurfaceHelpers.h
MacIOSurfaceImage.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
MacIOSurfaceImage.h Bug 1667267 - Set MacIOSurfaceImage picture rect in device pixels. r=mstange 2020-09-28 02:48:32 +00:00
MemoryPressureObserver.cpp Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 2020-07-01 08:29:29 +00:00
MemoryPressureObserver.h
moz.build Bug 1678463 - Part 1: Add _WITH_DELETE_ON_EVENT_TARGET macros to nsISupportsImpl, r=mccr8 2020-12-14 18:30:51 +00:00
NativeLayer.h Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow 2020-09-15 20:47:19 +00:00
NativeLayerCA.h Bug 1666055 - Remove RenderTextureHostOGL. r=lsalzman 2020-10-14 07:58:18 +00:00
NativeLayerCA.mm Bug 1686834: Increase the specificity of a release assert in NextSurfaceAsFramebuffer. r=jrmuizel 2021-01-19 21:31:45 +00:00
OOPCanvasRenderer.h Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
PaintThread.cpp Bug 1683551 - Make gfx buildable outside of unified-build environment. r=sg,jgilbert 2021-01-04 14:20:17 +00:00
PaintThread.h Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
PersistentBufferProvider.cpp Bug 1668713 - Disable D2D canvas when using SWGL. r=jrmuizel 2020-10-07 21:07:06 +00:00
PersistentBufferProvider.h Bug 1654211 - Hold WeakPtr to PresistentBufferProvider in BorrowedSourceSurface. r=gfx-reviewers,nical 2020-08-25 15:36:11 +00:00
ProfilerScreenshots.cpp Bug 1675409 - Removed now-unused ProfilerMarkerPayload and all dependencies - r=gregtatum,necko-reviewers 2020-11-18 21:56:57 +00:00
ProfilerScreenshots.h
ReadbackLayer.h Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
ReadbackProcessor.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
ReadbackProcessor.h
RecordedCanvasEventImpl.h Bug 1654477 P1: Use a unique ID to track recorded textures. r=jrmuizel 2020-10-16 10:59:11 +00:00
RenderTrace.cpp
RenderTrace.h
RepaintRequest.cpp Bug 1671048 - Add serializer for RepaintRequest. r=botond 2020-10-14 19:23:57 +00:00
RepaintRequest.h Bug 1662019 - Replace the uint32_t scroll generation with ScrollGeneration. r=tnikkel 2020-11-13 22:58:06 +00:00
RotatedBuffer.cpp Bug 1664831. r=sotaro 2020-11-16 22:41:08 +00:00
RotatedBuffer.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
SampleTime.cpp Bug 1653796 - Introduce a SampleTime class. r=botond 2020-08-10 20:14:05 +00:00
SampleTime.h Bug 1653796 - Introduce a SampleTime class. r=botond 2020-08-10 20:14:05 +00:00
ScreenshotGrabber.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
ScreenshotGrabber.h Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow 2020-09-15 20:47:19 +00:00
ScrollableLayerGuid.cpp Bug 1667176 - Collapse ScrollableLayerGuid stringification functions. r=mattwoodrow 2020-09-25 08:57:23 +00:00
ScrollableLayerGuid.h Bug 1667176 - Collapse ScrollableLayerGuid stringification functions. r=mattwoodrow 2020-09-25 08:57:23 +00:00
ShareableCanvasRenderer.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
ShareableCanvasRenderer.h Bug 1632249 - Support compositing out-of-process WebGL. r=handyman,lsalzman,nical,geckoview-reviewers,agi,imanol 2020-06-15 18:25:55 +00:00
SourceSurfaceSharedData.cpp Bug 1612589 - Improve image memory reporting even further. r=tnikkel 2020-02-05 22:22:13 +00:00
SourceSurfaceSharedData.h Bug 1677236 - don't require padding for SWGL FBO textures. r=jrmuizel 2020-11-16 16:43:23 +00:00
SourceSurfaceVolatileData.cpp Bug 1612589 - Improve image memory reporting even further. r=tnikkel 2020-02-05 22:22:13 +00:00
SourceSurfaceVolatileData.h Bug 1612589 - Improve image memory reporting even further. r=tnikkel 2020-02-05 22:22:13 +00:00
SurfacePool.h Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
SurfacePoolCA.h
SurfacePoolCA.mm Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
SyncObject.cpp Bug 1678136 - Lazily initialize SyncObject r=mattwoodrow 2020-11-26 04:59:52 +00:00
SyncObject.h Bug 1678136 - Lazily initialize SyncObject r=mattwoodrow 2020-11-26 04:59:52 +00:00
TextureDIB.cpp Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj 2020-02-20 11:40:14 +00:00
TextureDIB.h
TextureSourceProvider.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
TextureSourceProvider.h
TextureSync.cpp Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj 2020-08-07 07:49:47 +00:00
TextureSync.h Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi 2021-01-07 08:53:08 +00:00
TextureWrapperImage.cpp Bug 1613985 - Use default for equivalent-to-default constructors/destructors in gfx. r=jrmuizel 2020-03-04 15:39:20 +00:00
TextureWrapperImage.h
TiledLayerBuffer.h Bug 1666802 - Remove LayersLogging.*. r=mattwoodrow 2020-10-11 21:20:46 +00:00
TransactionIdAllocator.h
TreeTraversal.h Bug 1625138 - Part 39: Replace mozilla::IsSame with std::is_same in gfx/. r=froydnj 2020-03-28 13:57:21 +00:00
UpdateImageHelper.h Bug 1676357 - Avoid including Layers.h in header files. r=botond 2020-11-23 16:09:05 +00:00
ZoomConstraints.cpp Bug 1668921 - Move ZoomConstraints serializer into a friend function. r=mattwoodrow 2020-10-08 12:39:37 +00:00
ZoomConstraints.h Bug 1668921 - Move ZoomConstraints serializer into a friend function. r=mattwoodrow 2020-10-08 12:39:37 +00:00