Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 23:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
e1db0f779e
gecko-dev/addon-sdk/source/CONTRIBUTING.md
Dave Townsend cac13216a3 Bug 1139189: Uplift the Add-on SDK to Firefox a=me 
3fbf5a6bdd..3394ad5d1d

--HG--
rename : addon-sdk/source/test/addons/l10n/locale/en-GB.properties => addon-sdk/source/test/addons/e10s-l10n/locale/en.properties
rename : addon-sdk/source/test/addons/l10n/locale/en-GB.properties => addon-sdk/source/test/addons/l10n/locale/en.properties
extra : rebase_source : f29b067cf47279b79946d01c510e52780798a64f
2015-03-11 22:19:48 -07:00

3.5 KiB
Raw Blame History

Overview

  • Changes should follow the design guidelines, as well as the coding style guide
  • All changes must be accompanied by tests
  • In order to land, changes must have been reviewed by one of the Jetpack reviewers
  • Changes should have additional API review when needed
  • Changes should have additional review from a Mozilla platform domain-expert when needed

If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.

How to Make Code Contributions

If you'd like to contribute the Jetpack project, follow these steps:

  1. Look for your issue in the list of bugs already filed. If you want to contribute, but don't already know what you want to do, we keep a list of good first bugs.
  2. If no bug exists, submit one.
  3. Get the code: get a GitHub account, fork the Add-on SDK repo, and clone it to your machine.
  4. Make your changes. Changes should follow the design guidelines as well as the coding style guide.
  5. Write tests: unit testing introduction, unit testing API.
  6. Submit a pull request with the changes and a title in the form of Bug XXX - description.
  7. Make sure that Travis CI tests are passing for your branch.
  8. Copy the pull request link from GitHub and paste it in as an attachment to the bug.
  9. Each pull request should ideally contain only one commit, so squash the commits if necessary.
  10. Flag the attachment for code review from one of the Jetpack reviewers listed below. This step is optional, but could speed things up.
  11. Address any issues mentioned in the review.

Finally, once review is approved, a team member will do the merging

Good First Bugs

There is a list of good first bugs here.

Reviewers

All changes must be reviewed by someone on the Jetpack review crew:

For review of Mozilla platform usage and best practices, ask [@autonome], [@0c0w3], or @mossop to find the domain expert.

For API and developer ergonomics review, ask @gozala.