Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-12-23 07:52:06 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[ASTImporter] Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

Browse Source 
Summary:
For a CXXRecordDecl the RecordDeclBits are stored in the DeclContext. Currently when we import the definition of a CXXRecordDecl via the ASTImporter we do not copy over this data.
This change will add support for copying the ArgPassingRestrictions from RecordDeclBits to fix an LLDB expression parsing bug where we would set it to not pass in registers.
Note, we did not copy over any other of the RecordDeclBits since we don't have tests for those. We know that copying over LoadedFieldsFromExternalStorage would be a error and that may be the case for others as well.

The companion LLDB review: https://reviews.llvm.org/D61146

Differential Review: https://reviews.llvm.org/D61140

llvm-svn: 359338
This commit is contained in:
Shafik Yaghmour 2019-04-26 18:51:28 +00:00
parent 7ab164c4a4
commit 16b90733c7
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/AST/ASTImporter.cpp
View File

@ -1767,6 +1767,9 @@ Error ASTNodeImporter::ImportDefinition(
ToData.HasDeclaredCopyAssignmentWithConstParam
= FromData.HasDeclaredCopyAssignmentWithConstParam;
// Copy over the data stored in RecordDeclBits
ToCXX->setArgPassingRestrictions(FromCXX->getArgPassingRestrictions());
SmallVector<CXXBaseSpecifier *, 4> Bases;
for (const auto &Base1 : FromCXX->bases()) {
ExpectedType TyOrErr = import(Base1.getType());

9
clang/test/Import/cxx-record-flags/Inputs/F.cpp Normal file
View File

@ -0,0 +1,9 @@
class FTrivial {
int i;
};
struct FNonTrivial {
virtual ~FNonTrivial() = default;
int i;
};

14
clang/test/Import/cxx-record-flags/test.cpp Normal file
View File

@ -0,0 +1,14 @@
// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | FileCheck %s
// CHECK: FTrivial
// CHECK: DefinitionData
// CHECK-SAME: pass_in_registers
// CHECK: FNonTrivial
// CHECK-NOT: pass_in_registers
// CHECK: DefaultConstructor
void expr() {
FTrivial f1;
FNonTrivial f2;
}