In file included from rtr.c:234:0:
rtr_http.c: In function 'r_core_rtr_http_run.isra.1':
rtr_http.c:403:44: warning: 'path' may be used uninitialized in this function [-Wmaybe-uninitialized]
path = (*index == '/')? strdup (index): r_str_append (path, index);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Co-authored-by: pancake <pancake@nopcode.org>
* Refactor r_sign metrics match ##signatures
This reduces the interface for matching function metrics to a single call. Now
each RSignItem is created once for all metric search types. Additionally, other
function data that is expensive to compute is now cached.
* Replace int with size_t
Co-authored-by: Dennis Goodlett <dennis@hurricanelabs.com>
json_parser.c: In function 'parse_value':
json_parser.c:240:9: warning: 'new_key' may be used uninitialized in this function [-Wmaybe-uninitialized]
p = parse_value (js, new_key, p);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Co-authored-by: pancake <pancake@nopcode.org>
disasm_stackptr.inc:124:29: warning: 'ostackptr' may be used uninitialized in this function [-Wmaybe-uninitialized]
Co-authored-by: pancake <pancake@nopcode.org>
```
fcn.c: In function 'fcn_recurse':
fcn.c:229:68: warning: 'omov_aop.disp' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (o_reg_dst && reg_src && o_reg_dst->offset == reg_src->offset && omov_aop.disp != UT64_MAX) {
fcn.c:181:10: note: 'omov_aop.disp' was declared here
RAnalOp omov_aop, mov_aop = { 0 };
^~~~~~~~
fcn.c:229:17: warning: 'reg_src' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (o_reg_dst && reg_src && o_reg_dst->offset == reg_src->offset && omov_aop.disp != UT64_MAX) {
^~
fcn.c:183:12: note: 'reg_src' was declared here
RRegItem *reg_src, *o_reg_dst = NULL;
```
Co-authored-by: pancake <pancake@nopcode.org>
As with the windbg implementation of fork_and_ptraceme, this checks for
the presence io->args and appends them to the child command before
invoking it.
The primary purpose of this fix is to make argument-passing possible
when using Cutter to debug programs, as Cutter sets dbg.args in order to
pass user-provided arguments to the child task. Presently, this does not
do anything on *nix platforms, greatly limiting Cutter's usefulness
insofar as debugging.
* The emitted esil for jalr was incorrect in the case where `rd` and
`rs1` are equal, since then `rs1` is written to as `rd` before adding
the immediate.
For example, `jalr ra ra 0x42` was lifted to the following esil:
4,$$,+,ra,=,ra,66,+,pc,=
While this does correctly set rd to the return address after the call,
pc is not correctly set according to `pc <- ra + 0x42`, but instead
`pc <- pc + 4 + 66`.
This commit flips the order of setting `pc` and `rd`, so that `rd` is
read from before it is written to.
* According to the spec, the auipc instruction's immediate is a
20-bit upper immediate, which means it should be left-shifted
by 12 similar to the lui instruction:
> AUIPC forms a 32-bit offset from the 20-bit U-immediate,
> filling in the lowest 12 bits with zeros, adds this offset
> to the address of the AUIPC instruction, then places the
> result in register rd.
