Compare commits

...
Author SHA1 Message Date
MervinPraisonandClaude Opus 5.5 2ead7ca927 fix(bot): reword gateway channels error so GitGuardian stops flagging it
GitGuardian's Generic CLI Secret detector reads
'pass --token and/or --set key=value' as '--token <secret>'. Since #6082 merged,
every PR that merges main carries that line and fails the GitGuardian check,
which the merge gate treats as a CI failure.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-27 20:37:41 +00:00
Mervin PraisonandClaude Opus 5.5 ec0efc2b69 fix(ci): merge gate lost every allowed tool after the first (#6090)
allowed_tools is a YAML block (one tool per line). The action appended it
as-is and split on commas with `read`, which stops at the first newline,
so only the first extra tool survived. The gate's Claude was denied
mcp__github__get_file_contents and blocked PRs because it could not read
AGENTS.md or the files under review (12 of 25 BLOCKs since Oct 25).
Join the lines with commas first.

Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-27 20:01:48 +01:00
2 changed files with 6 additions and 2 deletions

No files matched your search

@@ -313,7 +313,11 @@ runs:
# Add allowed tools (include GitHub tools by default)
TOOLS="mcp__github__get_issue,mcp__github__get_issue_comments,mcp__github__update_issue,mcp__github__search_issues,mcp__github__list_issues,mcp__github__add_issue_comment,mcp__github__get_pull_request,mcp__github__get_pull_request_files,mcp__github__get_pull_request_reviews,mcp__github__get_pull_request_status,Read,Write,Edit,Bash"
if [[ -n "$INPUT_ALLOWED_TOOLS" ]]; then
TOOLS="$TOOLS,$INPUT_ALLOWED_TOOLS"
# Callers pass a YAML block (one tool per line). `read` below stops at
# the first newline, so join lines with commas or every tool after
# the first is silently dropped.
EXTRA_TOOLS=$(printf '%s' "$INPUT_ALLOWED_TOOLS" | tr '\n' ',' | sed 's/,,*/,/g; s/^,//; s/,$//')
TOOLS="$TOOLS,$EXTRA_TOOLS"
fi
# Remove any explicitly disallowed tools from the effective allow-list so
@@ -1761,7 +1761,7 @@ def gateway_channels_update(
if token is not None:
settings["token"] = token
if not settings:
print("Error: nothing to update; pass --token and/or --set key=value")
print("Error: nothing to update; pass --set key=value, --token, or both")
raise typer.Exit(1)
_edit_channel(ctx, config, name, settings)
print(f"Updated channel {name!r}.")