* fix: session-scoped stop drains queued backlog (fixes#5129)
Add a pure StopScope/StopResult primitive to core gateway protocols and
wire a scoped _abort_session into the bot gateway server so a session
stop owns both the running turn and the queued-but-unstarted ingress.
- core: StopScope (TURN default / SESSION) + StopResult in protocols.py,
exported from gateway/__init__.py
- bot: _abort_session drains _inbox under scope=session; "/stop all" and
"/cancel" chat commands and a WS abort {"scope":"session"} frame carry
the scope. "/stop"/"stop" and default abort stay turn-scoped.
- pending_cancelled is reported as a visible, intentional non-outcome.
Additive and backward-compatible: default stays turn-scoped.
Co-authored-by: Mervin Praison <[email protected]>
* fix: close session-stop dequeue race, guard core import, add tests (#5129)
Reviewer follow-ups on the session-scoped stop:
- Race (P1, Qodo/Greptile): the queue worker dequeues a message before
registering its turn, so a SESSION stop landing in that gap missed it.
Add a per-session _stop_epoch bumped by _abort_session; the worker
snapshots it after dequeue and drops the message before dispatch if it
advanced. An in-flight-unstarted message is counted toward
pending_cancelled via _inflight_unstarted so nothing is silently lost.
- Import safety (Qodo): guard StopScope/StopResult behind a try/except
with a dependency-free local mirror, matching the existing _ingress
pattern, so an older permitted praisonaiagents floor cannot break the
gateway import.
- CI (test-core): the durable memory-independent team resume path read
self.tasks unconditionally; a bare AgentTeam (no tasks) raised
AttributeError. Make _snapshot_task_state / _task_set_fingerprint /
_restore_serialised_task_state tolerate a missing tasks attribute
without weakening the tests.
- Tests: add test_scoped_stop.py covering coercion, serialisation,
turn-scope preservation, session-scope drain+count, no-active-turn,
unknown session, and the dequeue race.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* ci: run 3002 praisonai-agents tests instead of 15
#4939 found that CI executed 15 of this package's ~11,900 tests and added a
collection gate, deliberately NOT enabling the suite: it would have gone red on
arrival, and a job that is red the day it lands teaches people to ignore it --
which is how this package ended up running 15 tests in the first place.
That reasoning still holds, but the number was never measured, because every
attempt to run the full suite in that session died. Moving
test_botos_integration.py out of tests/unit (it blocks in socket.accept()) was
what unblocked it. The suite now completes in about four minutes:
9064 passed, 297 failed, 28 skipped
So this enables what passes. 35 directories run clean -- 3002 tests in ~60s --
and they go into CI as an EXPLICIT list rather than `tests/unit`.
The list is a ratchet: fix a failing area, add it here, and it can never
silently regress. The header records where the 297 live, so the next person
starts from the biggest cluster rather than a survey:
tools(54) provider_matrix(38) gateway_routing(22) tool_guardrails(18)
gateway_server(17) managed_backend(16) session(12) runtime(12)
knowledge(12) agent(9) ... and a long tail
Coverage goes from 15 tests to 3002 without landing red. ~60s of Actions time
per PR touching src/praisonai-agents, on top of the existing ~40s collect gate.
The workflow is renamed agents-suite.yml, since it is no longer only a gate.
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: record what the 297 failures actually are
Every failing file was re-run in isolation, so the next person does not repeat
the search:
94 failures (18 files) PASS ALONE -> test pollution
203 failures (47 files) fail alone -> genuine
tests/unit/tools shows it starkly: 54 failures in a full run, 5 when that
directory runs by itself.
Also recorded: the pollution is CUMULATIVE (neither half of the suite nor the
top-level files reproduce it), its symptom for one victim is arguments not
reaching the tool, and resetting the approval and tool registries changed
nothing -- so neither is the leak. That last one was tried and REMOVED rather
than shipped: a fixture that fixes nothing while looking like a fix is worse
than none.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix: make agents-suite green set installable and machine-independent
The green-set job selected directories whose tests require optional extras
(litellm for workflows/embedding/eval/context, praisonai-sandbox for sandbox)
but installed only base deps, so 15 tests raised ImportError. Install [llm]
and praisonai-sandbox so the selected set can actually run.
Also fixes a hardcoded /Users/praison absolute cwd in the trace import-time
test, and marks two real-agentic tests `live` so a fake OPENAI_API_KEY in CI
cannot let them reach a real network call.
Co-authored-by: Mervin Praison <[email protected]>
* ci: 5797 praisonai-agents tests, and fix an install gap worth 47 failures
Builds on the earlier commit here (15 -> 3002). Two changes take it further.
1. CI now installs praisonai-sandbox.
It is a MONOREPO SIBLING, not a third-party optional. Without it 47 tests
fail with "No module named praisonai_sandbox.compute" -- an install gap
being reported as 47 code failures. Installing it took the full unit suite
from 297 failures to 250, and test_provider_matrix.py alone from 44 failures
to 6 with 103 passing (up from 68).
Worth stating: I first "fixed" this with pytest.importorskip and then with a
per-place skip. Both worked in the sense that the red went away, and both
LOST coverage -- the module-level skip dropped 68 passing tests, the
per-place one dropped 21. Installing the sibling is the root cause, and it
loses nothing.
2. The green set is now a file, and much larger.
tests/green-set.txt lists 189 paths that pass CLEAN TOGETHER: 5797 tests in
~92s, up from 3002. Four files that pass ALONE are deliberately excluded --
test_compute_home, test_placement, test_provider_matrix, test_run_on_docker
fail only alongside the rest, which is pollution rather than broken code.
A file rather than an inline list so it can be edited without touching CI,
and so the reasoning travels with it. It stays a ratchet: fix an area, add
its path, and it can never silently regress.
The workflow header records what the 250 remaining failures actually are (94
pollution across 18 files, 156 genuine across 44) and what is already known
about the pollution, so nobody repeats the search.
CI coverage: 15 -> 5797 tests, ~92s per PR touching src/praisonai-agents.
Verified by running the exact command CI runs, including the portable `xargs <`
form -- `xargs -a` is GNU-only and fails on BSD.
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: 5823 tests, and 83 of the 297 failures were never code
Continuing the environment work. The full-suite failure count moved
297 -> 250 -> 214 purely by cleaning the ENVIRONMENT, not the code:
-47 installing the monorepo praisonai-sandbox
-36 installing the monorepo praisonai-bot, and running with a clean HOME
So 83 of the original 297 were never code. Two examples, both of which I had
mis-classified as GENUINE because I ran the isolation checks on the same
contaminated machine:
- test_provider_matrix.py: 44 failures, all "No module named
praisonai_sandbox.compute". A monorepo sibling CI never installed.
- test_gateway_routing.py: 22 failures, all KeyError: 'code' from a malformed
~/.praisonai/gateway/pairing.json on THIS machine, read by a STALE installed
praisonai-bot. The monorepo version already handles both the legacy `code`
and hashed `code_hash` forms. With a clean HOME: 22 passed.
That correction matters more than the number. A failure inventory taken on a
developer's machine will over-report, and I had published 156 genuine when it
is nearer 120. The workflow header now records the real figures.
CI installs both siblings, so a fresh runner has neither problem.
green-set.txt grows to 191 paths / 5823 tests (~95s), verified with the exact
command CI runs, in a clean HOME. The same four files stay excluded: they pass
alone and fail alongside the rest, which is pollution rather than broken code.
CI coverage: 15 -> 5823 tests.
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: record the genuine failures, measured in a clean environment
tests/known-failures.txt lists the 40 files that fail IN ISOLATION with a clean
HOME and both monorepo siblings installed -- 120 failures, ranked, so the next
person starts from the biggest and can re-measure any line with one command.
Re-classifying in a clean environment moved the split materially:
dirty machine: 94 pollution / 203 genuine (what I reported first)
clean: 94 pollution / 120 genuine
The 83 difference was environment, and I had published the wrong figure because
I ran the isolation checks on the same contaminated machine. Isolation proves a
test does not depend on OTHER TESTS; it proves nothing about the environment
they all share.
Two spot-checks of what "genuine" now means, so the list is not mistaken for a
defect backlog:
- test_tool_guardrails.py: 18 failures in a full run, 50/50 PASS alone. That
is pollution and it is already excluded from the genuine list.
- test_managed_backend.py: 16 failures, and genuinely stale -- it asserts a
LocalManagedAgent._get_client() that exists in neither the installed nor
the monorepo wrapper. Same class as the two dead test modules fixed in
#4961: the code was refactored and the test was not. Repairing it means
reconstructing intent, which is a decision for someone who knows what that
API became, not a guess from me.
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: exclude a test that is green on macOS and red on Linux
tests/unit/memory/test_prefetch.py passes locally and fails on the runner
(test_async_memory_search_enforces_..., search_long_term never called).
The green set was derived on a developer machine, so CI is the first place a
platform difference can show. That is the ratchet working: the job went red,
the cause was specific, and the file is excluded rather than the list widened
or the failure ignored. It needs its own look, and is recorded in
tests/known-failures.txt so it is not forgotten.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(runtime): the "unknown runtime" error handler crashed instead of explaining
Two genuine failures from the known-failures list, and one is a real bug.
1. runtime/resolver.py raised ImportError where it meant to be helpful.
The ValueError handler for an unknown runtime id did:
from .registry import list_available_runtimes
available = [entry.runtime_id for entry in list_available_runtimes()]
The registry has never defined list_available_runtimes -- it defines
list_runtimes(), which already returns ids as strings. So a user passing an
unknown runtime got an ImportError instead of "Unknown runtime ID: X.
Available runtimes: [...]". The handler crashed exactly where the error was
supposed to be explained, and only on the branch nobody exercises.
tests/unit/runtime/test_resolver.py: 6 failures -> 4. The remaining 4 assert
a "legacy" resolution_source that now resolves as "default"; that is a
behavioural question for whoever changed it, not something to guess at.
2. session/test_bot_session_persistence.py: 11 failures -> 0.
It reached for src/praisonai/praisonai/bots by walking five dirname() calls
up from __file__ and putting the result on sys.path. The bots module has
since moved to the praisonai-bot package, so that path no longer contains
_session.py and every test failed with "No module named '_session'".
Replaced with a real import of praisonai_bot.bots._session, guarded by
importorskip: it follows the module wherever it lives, and skips clearly
when praisonai-bot is absent rather than failing as if the code were broken.
Also retargets three @patch decorators in that resolver test. They patched
praisonaiagents.runtime.resolver.resolve_runtime, but the resolver imports it
INSIDE the function, so the name never existed on that module -- the patch
target has to be the registry.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(approval): fix three stale mocks and one test that asserted a forbidden thing
tests/unit/test_approval_protocol.py: 3 failures -> 0.
1. Three mocks used the OLD _prompt_user contract.
backends.py:216 documents a (approved, scope, scope_pattern, feedback)
tuple; the tests returned a bare bool, so the backend raised "cannot unpack
non-iterable bool object" and reported approved=False. Updated to the
documented shape.
2. test_yaml_approved_skips_backend asserted the wrong LAYER, and then a thing
the design forbids.
It called reg.approve_sync() directly and expected YAML pre-approval to be
honoured there. It never has been: the standing-grant check lives in the
CALLER -- agent/tool_execution.py ORs is_env_auto_approve, is_yaml_approved,
is_auto_approved and is_already_approved before deciding to prompt -- and in
tools/tool_proxy.py. Asserting it a layer too low made approve_sync fall
through to the console backend, which tried to read stdin under pytest. The
failure looked like broken pre-approval; the product behaviour is correct.
It also used execute_command, which is CRITICAL. is_yaml_approved refuses
critical tools outright, deliberately, so config cannot pre-approve the most
dangerous calls. The test was asserting something the design exists to
prevent.
Rewritten to test the registry API the caller actually uses, with a
high-risk tool -- and it now PINS the safety carve-out: a critical tool
stays un-approvable even when config names it. That property had no test.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(llm): a malformed response was retried against an error that cannot resolve
tests/unit/test_error_classification.py: 5 failures -> 0. Four were missing
patterns; two were real behaviour bugs.
1. "malformed response" and "invalid response format" were classified as
empty_response. They are FORMAT errors, and the distinction is not cosmetic:
resolve_failover_decision treats format_error as NON-RETRYABLE and
empty_response as retryable. So a malformed body was retried against an
error that cannot fix itself -- spending calls and delaying the real message.
Moved to the format_error branch.
2. An auth error with NO failover manager fell through to the generic retry.
There is nothing to rotate to and the attempt-0 credential refresh has
already had its chance, so retrying a rejected credential only spends calls
and delays the one message that tells the caller their key is wrong. It now
surfaces, which is what the test has always documented.
Missing patterns added, each a real classification gap:
billing <- "subscription expired" (had "subscription required")
overloaded <- "try again later", "server busy"
empty_response <- "no content", "blank output", "null response"
format_error <- "parsing error", "decode error"
An unclassified error becomes "unknown", which takes the generic path -- so
these were not cosmetic either: a billing failure was being retried like a
transient one.
No regressions: tests/unit/llm went from 3 failures to 2 (the third was
pollution that these runs no longer trigger).
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(handoff): stop Mock's auto-attributes defeating the tool-boundary tests
tests/unit/test_handoff_tool_policy.py: 5 failures -> 3. Both fixes are the
test's shape, not the product -- and checking that was the point, because the
symptom looked like a security boundary failing.
1. Mock tools had no usable name.
_compute_effective_tools reads
getattr(tool, 'name', getattr(tool, '__name__', ...)). A Mock AUTO-CREATES
.name, so every mock tool's "name" was a unique Mock object and the
intersection was always empty -- 0 tools where 1 was expected. Replaced with
plain functions, which have no .name and fall through to __name__ exactly as
a real callable tool does.
2. source and target were the SAME object.
The end-to-end test built both from a patched MockAgent class. Calling a
Mock class twice returns the same return_value, so target.tools overwrote
source.tools and intersecting a set with itself returned BOTH tools. That
read as "execute_code was not blocked" -- a security boundary failure. It is
not: execute_programmatic does compute effective tools and pass them to
agent.chat (handoff.py:802, :610). The test had collapsed two agents into
one.
The remaining 3 in this file are the same class -- an end-to-end test whose
Mock agents keep tripping the real code paths (target.chat never invoked,
"cannot unpack non-iterable Mock"). Fixing them properly means rebuilding it on
real Agent fixtures, which is a larger change than the failure warrants and
where the test's intent is no longer obvious. Left recorded rather than guessed
at.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(runtime): fix four resolve tests defeated by Mock's auto-attributes
tests/unit/runtime/test_resolve.py: 4 failures -> 0 (21 pass).
Wrong patch target. test_default_resolver_fallback patched
praisonaiagents.runtime.resolve.LLM, but resolve() imports LLM lazily from
..llm.llm inside the function body, so it is not an attribute of that module --
AttributeError, not a fallback. The sibling test_default_resolver_with_llm
already patches praisonaiagents.llm.llm.LLM; this now matches it.
Mock auto-attributes, again. A bare Mock() answers hasattr() for ANY name, so:
- provider: LLMRuntimeWrapper.provider returns self.llm.provider when the llm
has one, else infers from model_ref. The mock always had one, so the
inference chain the tests exist to cover ("# inferred from model name") was
never reached -- assert Mock == 'openai'.
- achat: aexecute uses achat when present, else runs chat in an executor. The
test that says "# No achat method - should fall back to sync" auto-created
achat and awaited a plain Mock -- "object Mock can't be used in 'await'".
Both now use Mock(spec=[...]) so the mock has only the methods a real LLM would
have on that path. No product change: the tests were asserting against a shape
no real LLM has.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(knowledge): index() reported success=True when every file failed
Real product bug, found behind 5 failing tests in test_indexing.py.
IndexResult.success is a dataclass field defaulting to True, and NOTHING in the
package ever assigned it -- there was no `result.success = ...` anywhere. So
Knowledge.index() returned success=True unconditionally. A directory whose every
file failed to embed (revoked key, wrong model, exhausted quota) came back as:
IndexResult(success=True, files_indexed=0, errors=[...3 entries...])
index() catches each per-file exception into result.errors, so nothing raised
and the flag stayed True. No caller read the field either, which is why no test
ever caught it: the bug was invisible unless you believed the flag over the
counts, which is exactly what an API consumer does.
success is now derived from the errors index() already collects. Partial
failure counts as failure; callers wanting the split still have files_indexed
and errors.
Three regression tests in test_indexing_reports_failures.py (all-fail,
partial-fail, and an all-succeed control so `success = not errors` can't pass
vacuously). Verified by reverting the one-line fix: 2 fail without it, all pass
with it.
Separately, the 5 tests that surfaced this were calling OpenAI for real.
TestKnowledgeIndex asserts file counts, ignore patterns, glob filters and corpus
stats -- none of which involve embedding -- but used the real Knowledge.add().
Without live credentials the class failed on a 401; with them it spent money and
network time on a unit test. And because index() swallows the error into
result.errors, the 401 surfaced as a bare "assert 0 >= 1" that read like broken
directory traversal. Now stubbed at the class level: 25 pass, 2.90s -> 0.33s.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(managed): 16 failures were ambient credentials, not broken code
tests/unit/test_managed_backend.py: 16 failures -> 0 (47 -> 50 tests).
ManagedAgent is no longer a class -- it is a FACTORY that picks a backend by
reading the environment:
if os.getenv("ANTHROPIC_API_KEY") or os.getenv("CLAUDE_API_KEY"):
provider = "anthropic" # -> AnthropicManagedAgent
else:
provider = "local" # -> LocalManagedAgent
TestManagedAgent obtained its subject from that factory and then asserted
Anthropic-only behaviour: _get_client, usage tracking, session reuse, interrupt.
So all 16 passed on any machine with ANTHROPIC_API_KEY exported and failed
everywhere else with "'LocalManagedAgent' object has no attribute '_get_client'"
-- which reads like a missing method, not a missing env var. Measured both ways:
16 failed without the key, 46 passed with it, same commit.
The 24 in-test imports now name AnthropicManagedAgent directly (aliased to
ManagedAgent, so the 25 construction sites are untouched). The suite now passes
identically with and without a key exported -- verified in both environments.
Added TestManagedAgentFactoryRouting to cover the dispatch itself, which nothing
tested: key present -> Anthropic, key absent -> Local, explicit provider ignores
the environment.
Also test_config_defaults: ManagedConfig.networking became a typed
NetworkingConfig instead of a dict. NetworkingType is a str Enum so the wire
value is still "unrestricted"; only the container changed. Assertion updated to
the current type, keeping the original intent.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(bot): YAML rejected the comma-separated allowed_users the CLI accepts
tests/unit/test_whatsapp_message_filtering.py: 5 failures -> 0, and 122.60s ->
2.21s, because two of them were starting real servers.
Product bug: same setting, two entry points, one broken.
bots_cli splits the CLI flag on commas --
allowed_numbers = [n.strip() for n in respond_to_raw.split(",") ...]
-- so `--respond-to 123,456` works. But allowlist/blocklist/allowed_users were
widened to List[str] "for consistency", and pydantic rejects a str for List[str],
so the identical value in bot.yaml raised a ValidationError. Comma-separated
strings are already this schema's convention: admin_users and
user_allowed_commands sit directly below those fields and are documented as
exactly that. A mode="before" validator now splits them; lists pass through
untouched, whitespace and empty items are dropped.
Three YAML tests were asserting nothing.
They patched builtins.open and yaml.safe_load and fed a flat dict
({"platform":..., "respond_to":...}). start_from_config no longer parses YAML
itself -- it checks the path exists, then hands the FILE to
load_and_validate_gateway_yaml, which validates a channels-based schema. So the
patches never applied and every test died on "Config file not found: bot.yaml".
They also wrapped every assertion in `if mock_start.called:`, so they would have
passed silently checking nothing once the call stopped happening. Rewritten
against real temp files in the current schema, with unconditional assertions.
Two CLI tests were starting a real WhatsApp server.
They patched praisonai.bots.whatsapp.WhatsAppBot, but start_whatsapp does
`from praisonai_bot.bots import WhatsAppBot` at call time -- so the patch missed,
a real bot was constructed, and start_whatsapp's closing asyncio.run served
forever until the 60s pytest timeout. That is where 120 of the 122 seconds went.
Correct target, plus _run_bot patched so the serve loop never runs.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(tools): async tool failures counted twice, opening breakers at 3 of 5
Real product bug. Every async tool failure was recorded against the circuit
breaker TWICE, so a breaker configured failure_threshold=5 opened on the 3rd
failure. Measured: instrumenting CircuitBreaker._on_failure showed 2 calls per
single tool invocation, and the breaker rejecting the 4th call.
_invoke_guarded already records every outcome:
- error dict -> raises _ToolFailure (applying the approval/permission/policy/
guardrail exclusions) so breaker.acall counts it
- success -> acall's _on_success
- raised exc -> acall's `except Exception: self._on_failure()`
Two further breaker_record calls -- one after the invoke, one in the except
block -- counted the same failure again. The except-block comment says it was
added because "the post-invoke record block above is skipped and raised failures
never trip the breaker"; that was true of _invoke, but not of the breaker
wrapper that now surrounds it. Both are removed. Both failure shapes were
affected, not just raises.
The timeout path is the one outcome the breaker genuinely does not see:
asyncio.wait_for cancels the coroutine inside acall, and CancelledError is a
BaseException, so acall's `except Exception` never runs. It now records
explicitly, where the timeout is handled.
Why no test caught it: the only test pinning the threshold covered raises alone,
and its sibling drives 5 failures then asserts the 6th is open -- which holds
whether the breaker opens at 3 or at 5. Added tests for both failure shapes and
a control that denials never trip the breaker. Verified by reverting: 2 fail
without the fix, 17 pass with it. Full tools + agent suites: no regressions.
Also in this commit, tool retry tests:
- Agent(tool_retry_policy=...) moved into tool_config=ToolConfig(retry_policy=...).
6 call sites migrated, and Agent's unknown-kwarg _HINTS now names the
replacement for tool_retry_policy and tool_timeout, as it already does for
verbose and stream. Previously the user got a bare "unexpected keyword
argument" and a 41-parameter signature to search.
- TestRetryPolicyAgentic drives a REAL LLM through agent.start() (AGENTS.md
§9.4). Without a live key all 4 fail on "Expected string response, got
NoneType", which reads like a retry bug. Marked @pytest.mark.live, the repo's
existing gate (skipped unless PRAISONAI_LIVE_TESTS=1).
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(runtime): a runtime instance passed as cli_backend was silently discarded
tests/unit/runtime/test_resolver.py: 4 failures -> 0, +2 tests.
Product bug. resolve_runtime_config gates ALL legacy cli_backend handling behind
`if self.default_runtime_id is None`, and the in-line comment concedes "in
practice, default is always available" -- so the branch was dead. Passing an
already-constructed runtime INSTANCE therefore warned about deprecation and then
dropped the object, running the agent on the default registry runtime instead of
the one the caller handed over. resolve_runtime_instance still carries the branch
that unwraps such an instance; it had simply become unreachable.
An instance is now honoured regardless of the default. The default-wins order is
about choosing between runtime *ids*, and an instance is not an id: it cannot be
expressed as the model-scoped configuration the warning tells you to migrate to,
so the default cannot stand in for it. A legacy backend NAME keeps the
documented priority -- default outranks it -- and that test now asserts
"default" rather than "legacy", which is what the code actually does.
The two validation tests built an invalid AgentRuntimeConfig and expected
validate_runtime_config to raise. The type checks moved into __post_init__, so
the TypeError fired on the construction line OUTSIDE the pytest.raises block and
the tests errored. Both checks still exist in both places, so each is now
covered by its own test: construction rejects it up front, and
validate_runtime_config still rejects a config mutated after construction.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(bus): event history was empty unless something happened to be subscribed
tests/unit/bus/: 3 failures -> 0 (49 pass).
EventBus recorded history AFTER a no-subscriber fast path, in all three publish
paths:
publish() returned a bare Event without calling publish_event at all
when there were no subscribers and no sinks
publish_event() returned before the history append when no subscribers
publish_async() same
So get_history() returned nothing at all unless a subscriber or sink happened to
be attached. The record of what the bus did depended on who was watching it --
which is precisely backwards for the auditing and debugging history exists for,
and get_history() is documented as "Get recent event history" with no such
caveat. Appending to a list capped at _max_history is not the expensive work the
fast path was protecting; subscriber matching and dispatch are, and those are
still skipped when there is nobody to dispatch to.
JUDGEMENT CALL, flagged deliberately: the repo contradicted itself here, and I
picked a side. Three tests (test_event_history, _with_filter, _limit) publish
with no subscribers and expect history back -- those were the ones failing. Two
others (test_publish_fast_path_no_subscribers, test_no_sink_preserves_fast_path)
asserted get_history() == [] and so blessed the bug. I took the documented
contract over the implementation detail: the three describe what the feature
promises, the two describe how it happened to be built. Both blessing tests are
updated to assert that dispatch is skipped while the event is still recorded,
each carrying the reasoning. If the performance of the append is the real
concern, the decision to revisit is whether history should be opt-in, not
whether it should silently depend on subscribers.
No product code consumes EventBus.get_history(), so nothing internal depended on
either behaviour. Regression-checked across bus, session, agent and telemetry:
925 passed, and the 4 remaining failures were already on known-failures.txt.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test: live tests gated on a key being SET, not on it being real
8 failures -> 0, across 5 files. All one bug, in five spellings.
These are "real agentic" tests that drive a live LLM. Each guarded itself by
checking whether OPENAI_API_KEY was present:
test_streaming_with_tools.py not os.environ.get("OPENAI_API_KEY")
test_gap_closure.py not os.environ.get("OPENAI_API_KEY")
test_toolsets.py ... or OPENAI_API_KEY == "test-key" (x2)
test_circuit_breaker.py ... or OPENAI_API_KEY == "not-needed"
test_max_steps_budget.py ... and not PRAISONAI_LIVE_TESTS
But a placeholder key is always exported. The agents-suite workflow sets
OPENAI_API_KEY: 'sk-not-a-real-key' on purpose -- some modules bail at import
without one -- and local harnesses do the same. So the skip never fired and every
one of these ran against a fake credential and failed. The two guards that try to
exclude a placeholder by value each hardcode a single string ("test-key",
"not-needed") and miss whatever the next harness uses.
The failures were actively misleading. test_streaming_with_tools.py asserts
"a plain streamed turn produced nothing; the harness is broken" -- which is
exactly what a missing credential produces, and reads like the streaming defect
the file was written to catch.
All now use the repo's canonical gate, @pytest.mark.live: an explicit opt-in via
PRAISONAI_LIVE_TESTS=1 rather than an inference from a variable that is set
either way. That is the mechanism the workflow already documents ("the live
marker keeps these offline"); these five files just predated it.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test: fix patch targets and an approval prompt reading stdin under pytest
6 failures -> 0 across two files.
test_ast_grep_tool.py (3): ast_grep_rewrite is
@require_approval(risk_level="high"). With no approval callback configured the
gate falls back to an interactive stdin prompt, which under pytest raises
"reading from stdin while output is captured" and surfaces as "Execution of
ast_grep_rewrite denied: Approval error: ...". That reads like the tool
crashing -- which is precisely what test_tool_does_not_crash_when_not_installed
set out to disprove. These tests cover ast-grep's fallback behaviour, not the
approval gate, so an autouse fixture sets PRAISONAI_AUTO_APPROVE for the module.
test_context_compaction_policy.py (3): the tests patched
praisonaiagents.context.adapters.{get_model_limit, ContextBudgeter,
estimate_messages_tokens}. None of those names is in adapters -- it imports only
from .protocols. compute_context_budget pulls them in as function-level imports
from .budgeter and .tokens, so the patches now name those source modules, where
a call-time import actually resolves.
The third was arithmetic. test_model_specific_overrides mocked
budgeter.usable = 7200 and then reasoned as though the denominator were the
model limit of 8000: its comment claims "87.5% utilization", but
compute_context_budget divides by usable, giving 7000/7200 = 97%. That is over
the 0.92 model override, so the route was compact_then_truncate and the test
failed against its own stated intent. usable is now 8000, which makes the real
utilization the 87.5% the test describes. test_policy_routing_logic in the same
file already pins the denominator (utilization == 2500 / 3600).
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(knowledge): whole suite now runs offline — 131 pass, 0 fail
7 failures -> 0 across three files. tests/unit/knowledge/ is fully green with no
credential at all.
test_embedding_failure.py (3) and test_adapters.py (2): both build a
ChromaKnowledgeAdapter via __new__ to skip the chromadb import, mirroring the
attributes __init__ would set. _embedder was added to __init__ later (the fix
that stopped an explicitly-configured local embedder from silently going to
OpenAI) and neither helper was updated, so _resolve_embedder raised
AttributeError inside the product on every add and search -- the tests never
reached the failure path they exist to cover.
test_directory_ingestion.py (2): these hit the real OpenAI embeddings endpoint.
The module guard excluded one placeholder key by value ("not-needed") while CI
exports 'sk-not-a-real-key', so it never skipped; the request 401'd; and because
add() swallows the embedding error into its result rather than raising, the
failure surfaced as "assert 0 > 0". The per-test `except ... pytest.skip("api_key")`
guards never fired for the same reason -- nothing escapes add() for them to catch.
Rather than mark them live and lose the coverage, an autouse fixture replaces the
embedding call with deterministic bag-of-words vectors, so ingestion, storage and
search all run for real, offline. Not a constant vector: the tests assert that a
search for ZEBRA-71 returns the ZEBRA document FIRST, so the stub has to preserve
ranking. crc32 keeps it stable across processes where hash() is randomised.
One trap worth recording: `import praisonaiagents.embedding as m` yields a lazy
proxy that resolves to the FUNCTION, not the module, so setattr on it fails.
importlib.import_module gives the module object both call sites resolve against.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(plugins): enable()/disable() with no arguments always raised
Real product bug. PluginManager.list_plugins() is typed List[PluginInfo] and
returns dataclasses, but the enable-all and disable-all branches called
plugin_info.get("name", "") on them:
for plugin_info in manager.list_plugins():
manager.enable(plugin_info.get("name", ""))
So plugins.enable() and plugins.disable() -- the no-argument form that acts on
every discovered plugin -- raised AttributeError: 'PluginInfo' object has no
attribute 'get'. Passing explicit names worked, which is why it survived; the
whole-set path was simply broken.
Notably the module-level list_plugins() wrapper right below handles BOTH shapes
(`if hasattr(info, 'name')` ... `elif isinstance(info, dict)`), so the dict
assumption had already been noticed once and fixed in one place but not the
other. Both call sites now use plugin_info.name, matching the declared type.
test_self_improve.py (2): the parser was tightened to reject values outside the
preset list, with a did-you-mean suggestion; two tests still asserted that an
unrecognised value silently disabled review. Rejecting is the stronger
guarantee, and the one the tests were written to protect -- "a typo like
'backround' must not silently enable inline review" is satisfied more completely
by an error than by a silent default. Updated to assert the ValueError and the
suggestion. Recognised falsy values (false/off/no/0/False/OFF) still disable and
are still covered; "" is unrecognised and moved to the rejection test.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(permissions): align with the safe-by-default deny set; fix two real defects
5 failures -> 0 across two files.
test_permissions.py (3): three tests asserted _perm_deny == frozenset() for an
agent with no approval config. That default was deliberately hardened -- an
agent with no approval mechanism now applies _resolve_default_deny_set(), which
blocks execute_command, delete_file, kill_process, execute_code and friends
rather than letting them run unguarded. approval=False is the same story: it
disables the BACKEND, and with nobody left to ask, denying destructive tools is
the safe posture, not a regression. Tests updated to assert the hardened
default, with PRAISONAI_TOOL_SAFETY=off pinned in a new test so the documented
opt-out cannot rot silently. The zero-overhead test now sets that env var, since
the falsy-empty-set path it describes is only reachable with denials off.
test_allowed_tools_filter.py (2): two genuine defects, one in each layer.
The test patched logging.getLogger() -- the ROOT logger -- while the module logs
through logging.getLogger(__name__). A child logger's .warning is its own
method, and propagation carries records to root's HANDLERS, not to root.warning,
so the assertion failed while the warning sat in the captured log output two
lines above it. Now patches the module logger.
And diagnostics reported "whitelist": list(self._whitelist) from a SET, so the
order differed between runs -- a diagnostic report that cannot be diffed across
two runs is much less useful for the debugging it exists for. Now sorted, which
is deterministic without changing how the whitelist is stored or matched.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test: five stale contracts — protocol growth, eager auth, a copy, a budget
5 failures -> 0 across five files.
test_protocols.py: AgentRuntimeProtocol is @runtime_checkable, so isinstance()
requires EVERY member. The protocol grew seven members (runtime_name,
runtime_version, capabilities, execute_agent, stream_agent, validate_config,
health_check) after MockRuntime was written, so the mock had quietly stopped
implementing the protocol it exists to demonstrate, and the test failed on a
bare "assert False". MockRuntime now implements the full surface.
test_cli_backend_protocol.py: same cause, subtler mechanism. The test assigns
config/execute/stream onto a Mock but left capabilities to Mock.__getattr__.
isinstance() against a runtime_checkable Protocol uses inspect.getattr_static,
which does NOT call __getattr__ -- so an auto-created Mock attribute is invisible
to the check even though hasattr() returns True. Verified the protocol itself is
sound: a concrete class implementing all four members satisfies it. capabilities
is now assigned like the others.
test_panel.py: Agent.__init__ resolves subscription credentials eagerly for
auth=, by design ("missing credentials must fail at construction, not at request
time"). The test passes auth="claude-code" because it asserts auth reaches the
panel, so it raised AuthError on any machine without Claude Code logged in --
every CI runner. Now sets ANTHROPIC_TOKEN, the fallback the resolver names in
its own error message.
test_runtime_capabilities.py: asserted `resolve_runtime(config) is config`.
The resolver now canonicalises preferred_runtime and returns
dataclasses.replace(...), specifically so "a config reused/compared after agent
construction is unchanged". The test now pins that non-mutation guarantee, plus
a second case for the identity shortcut that still holds when there is nothing
to normalise.
test_api_exports.py: __all__ hit 31 against a < 29 bound. Traced the two
additions rather than just raising the number: RetryBackoffConfig (#2082) and
RunOutcome (#3406), both canonical public types. Bound raised to 32 with that
recorded, and a note that the ratchet is only worth keeping if each bump is
deliberate.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(security): SSRF bypass — octal-dotted loopback hosts passed URL validation
http://0177.0.0.1/ was accepted by BOTH URL validators. 0177 is octal for 127,
so under glibc's inet_aton that host is 127.0.0.1 — loopback.
This is a parser differential, not a missing blocklist entry, which is why it
survived. Both validators classify a host by asking the resolver, and resolvers
disagree:
glibc inet_aton "0177.0.0.1" -> 127.0.0.1 (loopback)
getaddrinfo/macOS "0177.0.0.1" -> 177.0.0.1 (public)
Measured, not assumed: socket.getaddrinfo("0177.0.0.1") returns 177.0.0.1 here.
So the validator sees a harmless public address, clears the URL, and the HTTP
client on a glibc host then connects to loopback. Asking the resolver cannot fix
this, because the resolver is one of the two disagreeing parsers.
Every other encoding in GHSA-5c6w-wwfq-7qqm was already handled --
127.1, 0x7f000001, 2130706433, localhost. -- so only the dotted form with a
non-decimal label fell through, in:
- SpiderTools._validate_url: reached the getaddrinfo fallback and was allowed
- url_safety.is_safe_http_url: classifies purely by getaddrinfo, so allowed
The second is the more serious of the two: it is the shared helper other tools
call. It had no test for any of this.
Ambiguous dotted numeric hosts (a leading-zero decimal label, or a 0x hex label)
are now rejected outright by one shared helper, is_ambiguous_numeric_host, used
by both validators. Rejecting beats normalising: there is no legitimate use for
these in a URL, and guessing which parser the transport will agree with is the
mistake that created the hole. Canonical dotted-quads and ordinary hostnames are
untouched.
Also caught two forms the advisory does not list and neither validator blocked:
0x7f.0.0.1 and 127.0.01.1.
New tests cover both helpers, including a control asserting that ordinary hosts
(example.com, 1.1.1.1, 93.184.216.34) are NOT flagged — without it, a check that
rejected everything would pass just as well. Full tools suite: 674 passed, no
regressions.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test: four stale bindings and signatures
4 failures -> 0 across four files.
test_trust_system.py (2):
- Patched praisonaiagents.tools.trust.get_registry, which does not exist:
_is_tool_external imports it inside the function as
`from .registry import get_registry`, so the call resolves against the
source module. Retargeted there.
- Asserted membership through the name imported at the top of the test file.
add_external_tool REBINDS the module global (the set is a frozenset, so it
builds a new one), leaving `from ... import EXTERNAL_TOOL_NAMES` pointing at
the old object. The product behaviour was correct all along --
is_external_tool returned True in the same test -- only the stale reference
was wrong. Now read through the module. The test also mutated
process-global state with no undo, leaking a fake tool name into everything
that ran after it; the original set is now restored in a finally.
test_todo_update.py (1): the test's stand-in agent defined
_check_tool_policy_and_guardrails(self, function_name, arguments) while the real
method gained a `tools` argument. The async path calls it with four positionals,
so the stub raised TypeError, and the failure surfaced as
{"error": "Error in execute_tool_async: ... takes 3 positional arguments but 4
were given"} rather than as the missing progress channel the test is about.
test_hierarchy.py (1): asserted `session2 is session1` -- that a second read
returns the cached object. get_extended_session deliberately stopped doing that:
#1785 ("stale extended cache after cross-instance writes") found it returning
TRUNCATED message lists after a cross-process write, and reading fresh every
time was the fix. The cache is still maintained and _is_cache_valid still passes
in the same test; it is simply no longer what this accessor returns. Now asserts
equality, with the reason recorded so nobody restores the identity check and the
bug with it.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(runtime): an empty turn result carried no error unless the key was missing
3 failures -> 0. One product bug, two stale assertions.
PraisonAIRuntime.run_turn checked for an empty result but only set an error when
OPENAI_API_KEY was ABSENT:
if not result:
if not os.environ.get('OPENAI_API_KEY'):
return RuntimeResult(content="", error="...required")
return RuntimeResult(content=str(result) if result else "", metadata=metadata)
So the one case it handled was the one already obvious to the user, while an
INVALID key, a rate limit, a network failure or a refusal all returned
content="" with error=None -- indistinguishable from "the model had nothing to
say". Presence of a credential is not validity, which is the same trap that put
five test files on live endpoints in this branch. An empty result now always
carries an error, keeping the specific missing-key message where it applies.
test_thread_safety.py: asserted isinstance(agent._history_lock,
type(threading.Lock())). The lock was upgraded to AsyncSafeState, which selects
a threading or asyncio primitive by context and still works as a plain context
manager. The test pinned an implementation detail; it now asserts the lock is
usable and releases, which is what thread safety actually requires.
test_tool_resolution_repair.py: expected execute_tool to raise
ToolExecutionError for an unknown tool name. #3309 ("self-repair and actionable
feedback on unknown tool calls") deliberately made that case RETURN
{"error": ..., "available_tools": [...]} so the model can pick a real tool and
retry, rather than finalizing the run failed over a recoverable mistake -- the
loop boundary only converts results marked retryable or raised-exception. Test
now asserts the dict, including that the available names reach the model.
Its sibling still expects a raise for a bind failure, which stays correct: that
is the tool itself throwing, not a name the model can correct.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(agent): memory="history" silently dropped on the default OpenAI path
Real product bug. Persisted session history was injected in only ONE of the two
branches of _build_messages:
if self._openai_client is not None:
messages, original_prompt = self._openai_client.build_messages(
..., chat_history=self.chat_history, ...) # session history absent
else:
...
if self._history_enabled and self._session_store is not None:
... # session history here
_openai_client is set for OpenAI models -- the default -- so an agent configured
with memory="history" loaded nothing from its session store and answered every
turn with no memory of the previous ones. Only agents on the manual/custom-LLM
branch actually got history. There is no error; the feature just quietly does
nothing on the common path, which is why it survived: the test covering it set
_using_custom_llm = True intending to take the other branch, but _openai_client
is non-None regardless of that flag, so the test was silently exercising the
broken path and failing there.
The load is now a single _load_session_history() helper used by both branches
(prepended to the in-memory chat history for the client path), so the two cannot
drift apart again. Behaviour is otherwise unchanged: same working-history
preference (Issue #2741), same fallback to raw chat history, same
swallow-and-log on failure.
Regression-checked across agent, session, memory, context and llm suites:
1491 passed, 0 failed.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(handoff): finish the tool-boundary tests — 18/18, boundary verified
The remaining 3 in test_handoff_tool_policy.py, deferred earlier as needing real
fixtures. They were three more variants of the same Mock trap, and none of them
was a product defect: the tool security boundary IS enforced, and the end-to-end
test now proves it (search allowed, execute_code excluded).
Every one comes from `getattr(mock, name, default)` never taking the default,
because a Mock has every attribute:
- _prepare_context does getattr(source_agent, 'chat_history', []) and iterates
it -> "'Mock' object is not iterable", caught and logged inside the handoff,
so target.chat was simply never called and the assertion read as a broken
boundary. Fixed by giving the mock agents a real empty history.
- _get_handoff_seed_lock builds a real DualLock only when
getattr(agent, '_handoff_seed_lock', None) is None. A Mock returns a Mock,
so the seeding context manager got an object that is not a context manager
-> "'Mock' object does not support the context manager protocol". Fixed by
handing the targets a real DualLock.
test_agent_chat_tools_none_inherits_agent_tools was worse than wrong -- it
tested nothing. It bound the REAL _format_tools_for_completion to a Mock and
then asserted the MOCK's _format_tools_for_completion had been called, which
could only pass if the real method delegated to itself. It does not (that would
recurse): it assigns `tools = self.tools` and formats them. Rewritten against a
real Agent, asserting the OUTPUT, which is the property that actually matters:
None inherits the agent's tools, and an explicit [] denies them all. Both
directions are asserted, so neither can silently collapse into the other.
Running theme across this file: four separate failures that each looked like a
security regression and were all Mock auto-attributes. Worth remembering the
next time a boundary test goes red.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test: diagnose the cross-test pollution — 29 failures -> 5
The full unit suite had 29 failures that every affected file passed in
isolation. Two causes, both process-global state, found by bisecting the
collection order.
1. One line, nineteen failures.
tests/unit/tools/test_delegation_tools.py line 8:
os.environ.setdefault("PRAISONAI_AUTO_APPROVE", "true")
At module level, so it runs at COLLECTION time and leaves auto-approval on for
the rest of the pytest process. Every later test that checks a tool actually
REACHES the approval backend then saw an empty backend, because auto-approve
short-circuits it first:
test_approval_protocol assert 'execute_command' in [] (x3)
test_default_tool_safety "must reach the approval backend" (x2)
test_approval_liveness "stale resolution is denied" (x2)
test_loop_detector_wiring doom-loop approval gate (x3)
...and the delegation tests themselves, once another test's env
patching removed the value they were silently relying on (x6)
Replaced with an autouse monkeypatch fixture, so those tests keep their
auto-approval and it is unset afterwards. This is exactly the hazard already
recorded at the top of test_indexing_reports_failures.py: "a module-level env
mutation persists for the whole test process".
2. Deprecation warnings are emitted once per PROCESS.
warn_deprecated_param keeps a module-level `_warned_params` set so users see
each deprecation once rather than on every Agent construction. Right for users,
fatal for tests: whichever test constructs an Agent with a given deprecated
parameter first gets the warning, and every later test asserting the same
warning sees nothing -- even inside warnings.catch_warnings() with
simplefilter("always"), because the suppression is not the warnings filter.
Verified directly: two identical constructions, warning on the first, silence on
the second, restored by clearing the set. Five failures across three files, on
collection order alone. Cleared by an autouse fixture in conftest.
Neither was a product defect, and neither was visible from any single file. Full
unit suite: 9368 passed, 5 failed (down from 29).
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: run the whole unit suite — 9373 pass, 0 fail
The green-set is gone. This job now runs tests/unit in full.
Last four pollution failures, each found by bisecting collection order and each
a test's own global state, not a product defect:
test_cost::test_lazy_litellm_import
test_embedding.py evicted every sys.modules key matching `'litellm' in k`.
That also matches praisonaiagents.llm._litellm_loader, so the next import of
it re-executed the module and produced a SECOND module object with fresh
globals -- while _cost.py still called get_litellm bound to the first. The
test reset and asserted one object's _litellm_import_attempted while the
calls updated the other's. Now matches the litellm PACKAGE only.
test_presentation_poll (x2)
asyncio.get_event_loop().run_until_complete(...). Since 3.12 get_event_loop
does not create a loop when none is set, so this raised "There is no current
event loop" as soon as any earlier test's asyncio.run() left the main thread
without one. Now asyncio.run().
test_code_tools_bridge::test_approval_gate_required_for_every_call
cleared the approval context in its finally but never at the start, so an
approval left in the contextvar by an earlier test made the first call
record a remembered approval covering the second -- the callback fired once
instead of twice, which is exactly the "first approval silently unlocks
later calls" behaviour the test forbids.
test_mixed_tools_list_resolution::test_named_tool_is_dispatchable...
tests/unit/skills/test_approval_scoping.py calls
registry.add_requirement("read_file", "high") on the process-global registry
and never removes it. read_file stayed approval-gated for the rest of the
suite, so an unrelated tools test hit the interactive console prompt and
failed with "reading from stdin while output is captured". Now saved and
restored around each test in that file.
Verified with the exact command CI runs: 9358 passed, 0 failed (15 fewer than
9373 because test_prefetch.py stays excluded -- it passes on macOS and fails on
Linux, a real platform difference that still needs its own look).
The workflow header no longer claims the suite cannot be run, and carries the
three pollution traps so the next person does not repeat the bisect.
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: verify on Python 3.11 — the version CI actually pins
Everything up to here was verified on Python 3.12. The workflow pins 3.11. On a
CI-shaped 3.11 environment the suite was NOT green: 28 failures. It is now 0.
The excluded test was misdiagnosed.
tests/unit/memory/test_prefetch.py was excluded as "passes on macOS, fails on
Linux". Wrong variable: it is Python 3.12 vs 3.11. asearch_memory branches on
isinstance(backend, AsyncMemoryProtocol), a runtime_checkable Protocol, and that
check changed between versions:
3.11 hasattr -> MagicMock satisfies it -> async branch taken
3.12 getattr_static -> Mock's auto-attrs invisible -> sync branch taken
So on 3.11 asearch_long_term ran and the assertion failed with "search_long_term
not called"; on 3.12 it passed. Demonstrated directly on both interpreters, then
proved by reverting: fails on 3.11 without the fix, passes with it. The mock now
names its methods (spec=), so both versions take the same branch. The test is
back in the suite and nothing is excluded any more.
Two real gaps in the install list, invisible on a developer machine.
[knowledge] extra 22 knowledge tests failed on "chonkie package not found"
src/praisonai 47 tests failed on "No module named 'praisonai'" --
test_managed_backend.py imports
praisonai.integrations.managed_agents
Both were already installed in my local env, which is exactly why running in a
clean CI-shaped venv was worth doing rather than assuming.
Two tests required optional third-party packages CI does not install:
TestJIRAConnection needs `jira`, and test_get_client_raises_without_key needs the
anthropic SDK -- without it the ImportError about the missing SDK fires before
the missing-key check the test is about, which is the case its own sibling
covers. Both now skip when the package is absent instead of failing.
Verified on both interpreters, in CI-shaped environments:
3.11 9357 passed, 0 failed
3.12 9373 passed, 0 failed
One trap for whoever runs this next: a corrupt .praisonai/chroma.sqlite3 left in
the worktree by earlier runs makes chromadb's rust bindings raise
pyo3_runtime.PanicException and fails two config tests. It is gitignored, and
deleting it fixes them. That is the store isolation issue #4376 refers to.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test: make the suite order-independent — verified across random seeds
pytest-randomly was never installed, so every `-p no:randomly` in this repo
(mine included) was a no-op and the suite had only ever run in collection order.
Installing it and running real random orderings found five more tests that
depend on the order they run in. All were global state a test set and did not
put back.
test_cost::test_lazy_litellm_import
Reached the loader's state by importing the module BY NAME. Other test
modules evict every sys.modules key matching 'praison' or 'litellm' and
re-import, which can leave two live module objects with separate globals --
so the test reset one dict while the calls updated the other. Now goes
through the function's own __globals__, which by definition is the dict
get_litellm writes to and cannot drift. (An earlier fix via __module__ was
not enough: sys.modules[name] can still be the other object.)
test_security_hardening_round2::test_launch_auth_optional_by_default
resolve_launch_host() writes PRAISONAI_LAUNCH_AUTH_TOKEN into os.environ
directly when it mints a token for a non-loopback bind, and caches it in
_GENERATED_TOKEN. A test about the DEFAULT has to establish the default, not
inherit it; an autouse fixture now clears both.
test_availability_gating::test_transient_probe_failure_serves_last_good
Another test shrinks the global registry's _availability_grace to 0.0 to
exercise the sustained-failure path and never restores it. registry.clear()
resets the caches but not the tuning, so the grace window stayed 0 and
last-good was never served. Saved and restored per test.
test_code_tools_bridge (x2: approval_gate_denies, serve_tool_call_honours_gate)
Approvals are remembered in a contextvar, correctly. An approval left by an
earlier test made a DENIAL test see an already-approved tool and not raise.
The whole file now starts each test with a clean approval context, which
also subsumes the single inline clear added earlier.
test_unified_plugin_system::test_skills_discovery_uses_paths_module
Asserted every discovered dir is named "skills", but
get_default_skill_dirs() walks every cwd ancestor and appends the
remote-skills cache, whose leaf is not "skills". It was asserting on
whatever happened to exist on the machine. Now hermetic via PRAISONAI_HOME
and a temp cwd.
Verified on Python 3.11 in a CI-shaped env, full suite:
collection order 9357 passed, 0 failed
seed 12345 9357 passed, 0 failed
seed 424242 9357 passed, 0 failed
KNOWN, NOT FIXED: seed 7 segfaults (exit 139) in
tests/unit/skills/test_self_improve.py. Reproducible for that seed, does not
reproduce from a file-order replay or a short prefix, and does not occur on
origin/main under the same seed -- though main has 150 failures there, so that
comparison is not clean. It needs the whole randomised suite to manifest, which
makes it a native-crash bisect rather than a test fix. CI is unaffected: it runs
collection order and does not install pytest-randomly. Recorded rather than
quietly dropped.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(tests): the seed-7 crash was a dangling chroma mmap; +4 more order deps
The interpreter crash is fixed, and fixing it uncovered four more
order-dependencies it had been hiding by aborting the run at 71%.
The crash: exit 139 (SIGSEGV) on one run, 138 (SIGBUS) on the next, always
inside an unrelated test. Alternating SEGV/BUS is the signature of touching a
memory-mapped file whose backing store is gone, and the crash disappeared
entirely when tests/unit/knowledge was excluded.
ChromaDB caches a System per persist path in
SharedSystemClient._identifier_to_system, and that cache outlives the directory.
A test builds a store under a temp dir, the dir is removed, the cached client
and its mmap'd sqlite stay alive, and a later test resolving to the same path
touches a mapping with no file behind it -- which the kernel answers with a
signal, not an exception. conftest now clears that cache after each test.
Uncovered by the fix, since the run now reaches the end:
test_paths.py (17) get_data_dir() returns ~/.praisonai if it exists, else the
legacy ~/.praison if THAT exists. These tests assert the default while
inheriting the ambient home, so once any earlier test created a legacy
~/.praison they all asserted '.praisonai' and got '.praison'. Each test now
gets an empty home and a cleared path cache.
TestModuleWiring (x2, in two files) compared DEFAULT_RULES_DIR / _DEFAULT_DIR
-- constants computed at IMPORT time from the home in effect then -- against
a get_rules_dir() call made later. That only holds if no earlier test moved
the home. The modules are now reloaded so the constant is recomputed under
the current home, which is what "resolves via paths.py" actually asserts.
test_ast_grep_tool is_ast_grep_available() memoises in a module global, so
the first caller fixed the answer process-wide and a later test patching
shutil.which got the cached one. Reset around each test.
Verified on Python 3.11 in a CI-shaped env, full suite, every seed clean:
collection order, seeds 1, 7, 12345, 99, 424242 -> 9357 passed, 0 failed
Python 3.12, collection order -> 9373 passed, 0 failed.
Repo-hygiene trap, unchanged and worth knowing: tests write chroma stores into
the worktree's gitignored .praisonai/, which accumulates across runs (142 dirs,
26MB here) until one goes corrupt and chromadb raises
pyo3_runtime.PanicException, failing ~14 memory/learn tests. `rm -rf
src/praisonai-agents/.praisonai` fixes it. CI never sees this because a runner
starts clean; it cost me two false diagnoses locally.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(tests): the 9 CI failures — all pre-existing, newly exposed by the gate
CI went red on this branch with 9 failures across 3 files. None of the three had
EVER run in CI: none was in the old green-set. They are pre-existing failures
that running the full suite exposed, which is the gate doing its job on its
first outing.
test_allowed_tools_filter.py (3)
AllowedToolsFilter is STRICT when the CI env var is truthy -- an unknown tool
RAISES instead of being warned about and stripped. Three tests exercise the
dev-mode warn path but never pinned CI, so on a runner (where CI=true is
exported) they took the strict path and failed with "All specified tools must
be available in CI mode". The convention was already there:
test_filter_tools_with_unknown_tools_dev_mode pins CI="false". These now do
too. My local runs never set CI=true, which is why I did not see this.
test_run_on_docker.py (3)
The tests probed docker themselves -- `docker version --format
{{.Server.Version}}`, 25s timeout -- while the runtime asks the docker
provider's `is_available`, which runs `docker version` with a 5s timeout. On a
cold runner those disagree: the guard says yes, the test runs, and the runtime
then refuses with "run_on='docker' cannot start: docker is not available on
this machine". A guard that can disagree with the thing it guards is not a
guard. They now gate on the provider's own answer, so they skip exactly when
the runtime would refuse.
test_team_session_resume.py (3)
_bare_team() builds an AgentTeam with object.__new__ and mirrors "just the
fields the methods touch". __init__ also sets `self.tasks = {}`, which the
save/restore path reaches on Linux but not on macOS -- so it passed here and
failed there with "'AgentTeam' object has no attribute 'tasks'". Mirrored, the
same way the ChromaKnowledgeAdapter fixtures had to mirror _embedder.
Worth recording: the 5s timeout on `docker version` is tight for a cold machine,
and its failure mode is a flat "docker is not available" when docker is merely
slow. That is in praisonai-sandbox, so it belongs in its own change; noted, not
touched here.
Verified with CI's own conditions -- CI=true, CI-shaped 3.11 venv, clean HOME:
9357 passed, 0 failed.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(tests): gate the docker tests on the provider the RUNTIME resolves
CI went 9 -> 3: the allowed-tools and team-session fixes landed, the docker ones
did not, because my first attempt probed the wrong class.
ComputeManagedAgent._ensure resolves its provider through
`resolve_compute(place)`, which returns DockerCompute. I gated the tests on
`DockerSandbox().is_available` from praisonai_sandbox -- a different class, with
a different answer. On the runner DockerSandbox said available, the tests ran,
and DockerCompute then refused. Same disagreement as the original 25s-vs-5s
probe, just moved one class along.
The guard now performs the runtime's exact resolution and reads is_available
the same way _ensure does (a property on one provider, a method on another), so
the two cannot answer differently by construction. Verified locally:
resolve_compute('docker') -> DockerCompute, is_available -> False, and the three
tests skip rather than fail.
The lesson I should have taken the first time: "gate on the same check the
product uses" only helps if it is the same check. Reading the resolution path
beats assuming which provider a name maps to.
Co-Authored-By: Claude Opus 5 <[email protected]>
* ci: drop "(green set)" from the job name
The green set is gone -- the job runs the whole unit suite -- but the label
still said otherwise on every PR check list, which is exactly the kind of stale
signal this branch spent its time removing.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(parity): drop four stale signature waivers now closed on the TS side
#4986 (Task human review) and #5004 (per-tool guardrails) have merged into
main, so praisonai-ts now exposes humanInput/humanReviewPrompt on Task and
inputGuardrails/outputGuardrails on tool(). The four waivers that recorded
those as Python-only gaps no longer cover any gap, so the signature gate
fails them as stale. Delete them, exactly as the gate instructs.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
* fix: add canonical terminal-outcome contract with deterministic precedence (fixes#4828)
Extend praisonaiagents/run_outcome.py with RunTerminal, a frozen closed
discriminated union for how a run ends, plus a pure merge_run_terminal()
that refines only toward stronger attribution (aborted > timeout > failed
> ok), is_sticky() for deliberate cancels / hard timeouts / supersedes,
and collapse() projecting onto the existing RunStatus vocabulary. Prevents
a late generic provider error from silently overwriting a user cancellation
or a hard timeout.
Co-authored-by: Mervin Praison <[email protected]>
* fix: make merge_run_terminal order-independent for equal-kind sticky sources
Equal-rank observations previously always kept the first writer, so a sticky
run_budget/external/superseded terminal observed after a non-sticky same-kind
signal was dropped and stayed downgradeable — identical signals in reverse
order produced a different final outcome. merge now promotes an equally-ranked
sticky observation over a non-sticky current, guaranteeing order-independent
convergence. Adds regression tests covering both orderings and full fold.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: ship isolated tool-capable code_mode with default subprocess bridge (fixes#5126)
Wires the merged CodeToolBridge contract (#3474) into a production-reachable
path. Adds a shipped concrete transport (LocalProcessBridge) and a third
code_mode value "isolated" that runs model-generated code in a subprocess
while its allow-listed tool calls are serviced in the parent under the same
allow-list + approval gate, returning only stdout to the model.
- praisonaiagents/tools/tool_proxy.py: LocalProcessBridge (subprocess isolation
+ newline-delimited JSON tool-call protocol over stdin/stdout; reuses
serve_tool_call and POSIX resource limits; no new dependencies).
- praisonaiagents/tools/python_tools.py: build_code_execution_tools now accepts
code_mode="isolated", building a default bridge and passing it to
execute_code_with_tools(..., bridge=...).
- praisonaiagents/config/feature_configs.py: validate code_mode in
{safe, unsafe, isolated}; backward compatible defaults unchanged.
- praisonaiagents/agent/agent.py: attach the isolated tool path.
- tests: LocalProcessBridge protocol/pipeline/isolation/approval/allow-list.
Co-authored-by: Mervin Praison <[email protected]>
* fix: harden isolated code bridge (sandbox escape, tool contract, async, zombie) + fix pre-existing team-resume CI
Security & correctness fixes on the isolated code_mode bridge, plus the
unrelated pre-existing team session-resume CI failure.
- tool_proxy.py: reuse the in-process executor's hardened _validate_code_ast
in the parent BEFORE spawning the child, closing the
type(x).__subclasses__()/__globals__ introspection sandbox-escape class
(only imports were previously blocked).
- tool_proxy.py: _service_bridge_call now re-raises ONLY authoritative policy
denials (PermissionError/NameError); ordinary tool failures return a
structured success=False result and no longer swallow SystemExit/
KeyboardInterrupt — matching the in-process executor's result contract.
- tool_proxy.py: async def tools are awaited to their value via
_call_and_resolve (both bridged and in-process paths) instead of leaking an
unawaited coroutine string.
- tool_proxy.py: reap timed-out children with process.wait() (no zombies);
wrap subprocess.Popen so a launch failure returns the documented failure
dict instead of raising a separate exception path.
- registry.py: add ToolRegistry(discovery_enabled=...) (default True). Agent
scoped code-execution registries set it False so an allow-listed name absent
from the agent's own tools cannot resolve to an installed global plugin.
- agent.py: build the isolated scoped registry with discovery_enabled=False.
- agents.py: make team task-state snapshot/fingerprint/restore defensive with
getattr(self, "tasks", {}) — fixes pre-existing test_team_session_resume
AttributeError (from #4986), unrelated to this PR's feature.
- tests: introspection escape blocked, ordinary tool error -> success=False,
async tool awaited, discovery-disabled registry, Popen startup failure.
Co-authored-by: Mervin Praison <[email protected]>
* fix: remove 4 stale signature-parity waivers failing the gate
The signatures parity gate ran on this PR because it touches
praisonaiagents/**/*.py, and failed on four pre-existing stale waivers
whose gaps no longer exist (Task.human_input, Task.human_review_prompt,
tool().input_guardrails, tool().output_guardrails). The gate's own error
prescribes deleting them from waivers.yaml. Not related to the isolated
code_mode change; removes the stale entries so the gate passes.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: close three concurrency gaps in agent state (fixes#5120)
1. PraisonAIAgents/_guard_execution: track run ownership via a ContextVar
instead of threading.get_ident(), so two coroutines that astart() the
same team under asyncio.gather no longer share an OS-thread id, falsely
take the re-entrant branch, and bypass the lock. Mirrors the existing
_tools_scope_depths ContextVar fix in the same class.
2. chat_mixin.py tool-dispatch (async custom-client + sync streaming):
malformed tool-call JSON is no longer silently dispatched as {} and
reported success=True. Reuse a shared _TOOL_ARGUMENTS_PARSE_FAILED
sentinel + tool_parse_error_message (promoted to agent.tool_execution
and shared with llm.py) to skip execution and return a retryable
tool-error to the model.
3. chat_mixin.py OpenAI-native chat/achat: replace the unatomic
check-then-act duplicate guard with _add_to_chat_history_if_not_duplicate
so concurrent turns no longer mistake another turn's user message for
their own duplicate and drop the user turn from the record.
Co-authored-by: MervinPraison <[email protected]>
* fix: close reviewer-identified gaps in concurrency guard + tool-parse
- guard: pin re-entrancy owner to (id(self), thread, asyncio task) via
_execution_identity() so a child task inheriting the copied ContextVar
can no longer falsely re-enter and bypass the held lock; sequential
batch->item nesting still matches on the same thread/task (Qodo #1,
Greptile P1).
- async custom-client tool path: catch TypeError alongside JSONDecodeError
and fire _notify_tool_call(success=False) on parse failure, mirroring the
sync streaming path (Qodo #6, Greptile P2).
- sync streaming tool path: catch TypeError alongside JSONDecodeError too.
- llm.py: make _tool_arguments_parse_failed / _tool_parse_error_message
thin delegates to the shared agent.tool_execution helpers, removing the
duplicate bodies (single source of truth) (Qodo #4).
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: MervinPraison <[email protected]>
Co-authored-by: Claude <[email protected]>
* fix(config): load AutonomyConfig lazily in feature_configs
The eager `from ..agent.autonomy import AutonomyConfig` at the top of
config/feature_configs.py pulled agent.autonomy and, through it,
escalation.types onto every `from praisonaiagents import Agent` path.
Import it under TYPE_CHECKING for annotations, import it inside
resolve_autonomy() where it is actually used, and serve the historical
`from praisonaiagents.config.feature_configs import AutonomyConfig` via
the existing PEP 562 module __getattr__ so nothing breaks.
Adds lazy-import tests for the default Agent path and the re-export.
Closes#5056
* test(config): pin autonomy lazy-import parity with tool_search pattern
Adds a regression test verifying resolve_autonomy keeps AutonomyConfig out
of feature_configs module globals until first access (matching the established
ToolSearchConfig PEP 562 pattern) so `from praisonaiagents import Agent` stays
lazy per #5056, while explicit access still resolves and caches the canonical class.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(plugins): honour selective enable allow-list on late registration
Follow-up to #5023: new plugins registered after plugins.enable([...])
default to disabled unless allow-listed; remove stale signature waivers;
fix AgentTeam session resume test helper missing tasks dict.
Co-authored-by: Cursor <[email protected]>
* fix(plugins): isolate late-registration allow-list per manager
Move the selective enable allow-list from package-global state into an
instance-local snapshot on PluginManager. The facade sets it only on the
singleton used by plugins.enable([...]) and clears it on plugins.disable(),
so standalone managers keep their default (enabled) registration behaviour
and caller list mutations after enable() no longer affect registration.
Also restore the singleton allow-list in the test fixture and add a
regression test proving standalone managers ignore the facade allow-list.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Cursor <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: stop concurrent agents sharing one LLM from misattributing tokens
current_agent_name was a plain instance attribute on LLM, so when two
Agents share one LLM object and arun_all_tasks gathers their tasks
concurrently, one task's set_current_agent() could overwrite it while
the other was still awaiting its own completion. Convert it to a
per-instance contextvars.ContextVar, same shape as the existing
_tools_scope_depths fix: asyncio.gather copies the context into each
task it creates, so a set() in one task never reaches a sibling task
on the same LLM instance.
Refs #5052 (finding 2a only; 2b and findings #1/#3 are untouched).
* fix: give LLM its own deepcopy so a shared ContextVar does not break Agent clones
Storing the current-agent ContextVar directly on LLM broke copy.deepcopy(Agent)
for any agent built with an already-constructed LLM instance, because
ContextVar has no __deepcopy__/__reduce__ and Agent.__deepcopy__ recursively
copies _llm_instance. Add LLM.__deepcopy__, following the same memo-registering
pattern already used by Agent.__deepcopy__, so a clone gets a fresh ContextVar
instead of failing with TypeError. Also replace the wall-clock
asyncio.sleep(0.05) in the concurrent-attribution regression test with
asyncio.Event coordination so the interleaving is deterministic.
`_bookends` walks the shared archived-plus-active projection, so an opening
bookend can be a compacted turn, but its entries carried no `archived` key --
unlike `search`'s context and `window`. That left `SessionHit.bookends` as the
one projection where the compaction boundary introduced by #5031 is invisible.
* fix: auto-extend MCP init timeout for npx/uvx cold-starts (fixes#5099)
Cold-start package launchers (npx/uvx/bunx/...) download the MCP server
package on first run, which on a fresh cache regularly exceeds the 60s
default init timeout and fails before the handshake begins (esp. Windows).
When the caller does not pass an explicit timeout, raise the effective
init timeout to 180s for these launchers. Explicit timeouts always win,
and non-launcher stdio commands keep the 60s default. The timeout error
now hints at pre-warming the launcher command.
Co-authored-by: Dhivya-Bharathy <[email protected]>
* fix: quote pre-warm hint via shlex.join + generic timeout remediation
Address PR review feedback on #5110:
- Use shlex.join so the pre-warm command hint preserves argv boundaries for
spaced paths / shell metacharacters (Greptile, Qodo #4).
- Add actionable remediation to non-launcher stdio timeouts (Qodo #1).
- Add tests asserting launcher and non-launcher timeout message content (Qodo #2).
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Dhivya-Bharathy <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
* fix: inject retrieved RAG context into llm_prompt in sync chat (fixes#5098)
In Agent._chat_impl the retrieved knowledge was appended to `prompt` but
the LLM call used a separate `llm_prompt`, so the model never received the
retrieved text and answered from parametric memory only. Sync llm_prompt
with the formatted context (text prompts only, preserving any response
template). Async path already passed the merged prompt.
Adds a regression test asserting the retrieved marker reaches the prompt.
Co-authored-by: Dhivya-Bharathy <[email protected]>
* fix: inject retrieved RAG context into multimodal (list) llm_prompt
Handle the attachment case where llm_prompt is a multimodal list: append
the retrieved context to the last text part (copying dicts before mutation
to avoid aliasing caller attachments), adding a text part if none exists.
Mirrors the existing response-template append pattern so knowledge reaches
the model on attachment-bearing sync turns too. Adds a regression test.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Dhivya-Bharathy <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
* fix: fail fast on duplicate Telegram poller with 409 pre-flight (fixes#5094)
Telegram allows only one getUpdates poller per token. A second process
(CLI bot, gateway telegram channel, UI Channels worker) silently breaks
replies with a 409 conflict loop. Add a lightweight pre-flight getUpdates
probe that detects an already-active poller before binding, and fail fast
with a clear, actionable message instead of entering the conflict cascade.
Co-authored-by: Dhivya-Bharathy <[email protected]>
* fix: fail fast on real Telegram 409 instead of harmful getUpdates probe (#5094)
The pre-flight getUpdates probe is itself a competing consumer: with a
short poll it terminates an incumbent long-poll (incumbent gets the 409,
probe gets 200), so it both disrupts a healthy bot and unreliably detects
the conflict. Remove the probe and instead classify the real 409 raised by
updater.start_polling(), then re-raise a clear, actionable RuntimeError so
supervisors mark startup as failed rather than silently stopping.
- Remove detect_telegram_poll_conflict() from _resilience.py
- telegram.py: capture is_conflict_error() in the polling loop and
fail fast after cleanup with a single-instance RuntimeError
- tests: replace probe tests with 409 classification + start() fail-fast
structural guarantees + helper-removal assertion
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Dhivya-Bharathy <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
* fix: wrap chonkie embeddings import with actionable error (fixes#5102)
The semantic/sdpm/late chunkers imported chonkie.embeddings.AutoEmbeddings
without wrapping, surfacing a raw ModuleNotFoundError. Now raises the same
actionable message as the main chunker path: install praisonaiagents[knowledge].
Co-authored-by: Dhivya-Bharathy <[email protected]>
* fix: preserve original chonkie import error + add embeddings guard tests
Only translate the AutoEmbeddings import failure into the install hint when
the top-level chonkie package is genuinely missing; otherwise re-raise the
original ImportError so a broken transitive dependency is not masked.
Add unit tests covering the default semantic, sdpm, late and string-model
paths (actionable hint) and the installed-but-broken case (original error).
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Dhivya-Bharathy <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
* fix: pin Langflow transitive deps for praisonai[flow] on Python 3.13 (fixes#5101)
a2a-sdk<1.0 lacks a2a.server.active_task and older fastapi-pagination
breaks against newer FastAPI, causing `praisonai flow` to crash on import.
Co-authored-by: Dhivya-Bharathy <[email protected]>
* docs: note flow/claw a2a-sdk mutual exclusivity in [flow] extra
Langflow needs a2a-sdk>=1.0.0 while praisonaiagents[a2ui] (pulled in by
[claw] via praisonaiagents[all]) pins a2a-sdk<1.0.0. Document that [flow]
and [claw] are mutually exclusive rather than risk a core a2ui bump that
would regress the existing praisonaiagents/ui/a2a integration.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Dhivya-Bharathy <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
* feat(task): require a person to sign off a task's output
Two things already existed and neither did this: the approval system gates a
TOOL CALL, and guardrails validate automatically. Nothing let an orchestrator
say "a person must approve this before the next task consumes it".
Task(description=..., human_input=True, human_review_prompt="Is this legally safe?")
Reuses the approval BACKENDS rather than prompting directly, so it works
wherever approvals already do -- console, callback, bot, UI -- instead of
hard-wiring input() and breaking every non-TTY caller. A rejection fills the
same Task.validation_feedback slot the guardrail retry already uses, so the
reviewer's reason reaches the re-run through machinery that exists.
Review runs AFTER the automatic guardrail passes, not before. Waking a person
to reject output a guardrail would have caught wastes the one resource this
feature spends.
Two refusals worth stating:
- If praisonaiagents.approval is unavailable, a task with human_input=True
RAISES rather than skipping the review. A task that was supposed to be signed
off and simply was not is the failure this feature exists to prevent.
- Repeated rejection stops at max_retries with a message naming the reviewer's
reason, rather than looping.
9 tests, three of them controls: a task without human_input is never reviewed
(and the backend is never called), a rejection within budget does not raise,
and the flag defaults off.
Parity: adds two expiring waivers (2026-12-08). They say plainly they are NOT
an equivalence but a real gap -- TypeScript has an approval manager, so the port
is tractable and was left out only because it is a separate change in a separate
package. The expiry means the gate goes red if it is forgotten.
No regressions: tests/unit/{agents,task} is 259 passed vs 250 on origin/main,
exactly the 9 new tests, zero failures either side. Collect gate and all three
parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(task): gate async task output on human review and fix feedback shape
Two valid defects from PR review:
- arun_task applied the guardrail but never called the human-review hook, so
an async task with human_input=True released unreviewed output. Add
_aapply_human_review (blocking backend offloaded to a thread, mirroring
_aapply_task_guardrail) and wire it into arun_task after the guardrail passes.
- A rejection stored the reviewer's reason as a bare string, but
Process._build_task_context indexes feedback['validation_response']; the
workflow engine would raise the moment it consumed it. Write the same dict
shape the guardrail retry writes so the reason reaches the re-run.
Adds end-to-end async gate tests (plus a control) and a test asserting the
rejection feedback survives Process._build_task_context.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Rebased onto latest main. Consolidates the branch's 42 commits into one
because the original history could not be replayed onto main (the early
commit shared no blob ancestry, yielding spurious whole-tree conflicts).
The net change is identical to the branch's intended diff (70 files).
Conflict resolved: praisonaiagents/tools/spider_tools.py -- main (#4966)
landed the same SSRF octal-loopback fix; kept main's superset, preserving
this PR's defect-1 intent.
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
- history.py: skip fcntl sidecar flock for backend storage (avoids
FileNotFoundError under uninitialised path); move backend delete inside
index lock; cache RunHistory per resolved path so Windows (flock no-op)
still serialises via shared in-process RLock.
- passthrough.py: key cached httpx.AsyncClient to its owning event loop and
rebuild on loop change; add close_clients()/aclose_clients() shutdown hooks.
- executor.py: guard lazy webhook client creation with an asyncio.Lock and
close under the same lock in stop() to prevent a leaked/overwritten client.
- langfuse_client.py: add close()/context-manager to release the Session pool.
- test_langfuse_commands.py: patch requests.Session.get (client now uses a
session) so tests mock correctly instead of hitting localhost:3000.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
- registry: remove shadowed duplicate resolve_or_default so the intended
fallback-with-actionable-error definition wins (was dead code)
- recipe/history: guard index read-modify-write with a reentrant in-process
lock plus cross-process fcntl advisory lock, make _save_index atomic via
tmp file + os.replace, and lock the get_history() singleton assignment
- recipe/operations: JobHandle keeps a lazily-built shared httpx.Client so
wait()/poll loops reuse one keep-alive connection (context-manager + close)
- jobs/executor: reuse a single AsyncClient for webhooks, closed on stop()
- capabilities/passthrough: module-level lazy shared sync/async clients
- cli/langfuse_client: reuse a requests.Session with persistent auth
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: MervinPraison <[email protected]>
* feat(ts): port the model-harness testing helpers, closing 5 parity gaps
praisonai-ts had no way to unit-test an agent offline. Python gained
ScriptedModel and a global no-network guard; the TypeScript side had neither,
which the parity tracker recorded as 5 missing exports.
Adds src/model-harness/{scripted,guard}.ts:
- ScriptedModel extends the real BaseLLM and replaces only the
provider-facing generate/generateStream, so prompt assembly, options
handling and the response shape all run production code. The double cannot
drift from the real client, because it IS the real client with its network
boundary swapped out -- the same reasoning as the Python port.
- It records every request the agent sent, supports callable entries that
answer based on the request, and throws ScriptExhausted when the script runs
out rather than inventing a reply or hanging.
- allowModelRequests(false) blocks real provider calls and ModelRequestBlocked
names the offending call site.
The guard tracks open scopes with a COUNTER, not a saved-and-restored boolean.
The Python version originally used a snapshot, and an inner scope exiting
first could re-enable requests while an outer scope was still open -- leaking
exactly the call the guard exists to prevent. A regression test covers the
overlapping case here so the TypeScript port never acquires that bug.
Parity: TS gap count 6 -> 1 (only GuardrailRetry remains, which needs a real
guardrail retry loop in TS rather than an exported name).
11 new tests, each positive paired with a control. Full suite 2454 passed,
build and webview gate exit 0, all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* feat(ts): guardrail retry — TS parity gap count reaches 0
TypeScript had no guardrail retry at all: applyOutputGuardrails ran in
finishTurn, downstream of the model call, and simply threw. Exporting a
GuardrailRetry symbol would have satisfied the name tracker while doing
nothing, so this builds the behaviour instead.
A blocking guardrail now raises GuardrailRetry carrying its reason. The turn
loop appends that reason to the same conversation and re-runs the turn, so the
model patches its previous answer rather than the caller restarting the task.
maxGuardrailRetries defaults to 0, which preserves the previous behaviour
exactly -- including the error text. GuardrailRetry.toBlockedMessage()
reproduces the original
`Agent <name>: guardrail "<g>" blocked the response: <why>` byte for byte, so
existing callers and tests are untouched. An existing parity test caught this
when the first draft dropped "blocked the response" from the message.
6 tests, mutation-checked: disabling the loop fails 3 of them. Two are
controls -- a passing guardrail runs the turn exactly once, and the default
config still throws on the first rejection.
Not shipped: an `Agent({ provider })` option for injecting a built provider.
It was written, and then found never to be consulted -- the suite mocks the
OpenAI client globally and the agent reached it by another path, so the option
would have looked supported while doing nothing. Removed rather than shipped
half-wired. Making a model double drive a full TS agent run needs that seam
built properly, and is worth its own change.
Parity: praisonai-ts name gap count 6 -> 0.
Full suite 2460 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* feat(ts): per-tool guardrails — clears both expiring waivers
Python gained @tool(input_guardrails=, output_guardrails=); TypeScript had
neither, so #4929 shipped two waivers with expires: 2026-12-07 to unblock it.
Those waivers said plainly they were NOT an equivalence but a real gap. This
closes the gap, so both are deleted -- a waiver whose gap has closed is stale
and fails the check, which is what proves the port is real.
Adds src/tools/tool-guardrails.ts and wires it into FunctionTool.executeRaw:
- Input guardrails run FIRST, before the approval gate, so bad arguments are
refused without waking a human and never reach the tool.
- Output guardrails run on the result before it reaches the model.
- Either may block or REPLACE, so a guardrail can redact instead of refuse.
- A blocked call returns { error, guardrail_denied } rather than throwing:
the model reads it and reacts, which is what makes the guardrail useful
mid-run instead of fatal. Same shape the Python side returns.
7 tests, three of them controls: an allowed call runs normally, a guardrail on
one tool does not fire for another, and an unguarded tool declares undefined
so the fast path stays free.
Parity: `signatures --check` now passes with both waivers REMOVED.
Full suite 2467 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* docs(parity): record why 10 of the 12 behaviour entries must NOT be "closed"
Verified against praisonaiagents, not assumed:
- AgentTeam knowledge/guardrails/web/reflection/caching/learn: Python's
AgentTeam constructor logs that it does not apply them at the team level
either and tells callers to pass them to individual Agents. TEAM_OPTION_NOTES
in agent/team.ts already said so; the ledger did not.
- Task web/reflection/autonomy/planning: Python's Task assigns each to self and
nothing in agents.py or process.py reads them back -- `task.<option>` returns
zero hits in both. Stored and ignored.
So TypeScript not acting on those ten IS parity. Implementing them would make
this SDK diverge from the reference it is measured against, which is the
opposite of what the number appears to ask for. Only AgentTeam.autonomy and
AgentTeam.toolsRunOn are blocked on TypeScript-side work, and both wait on
larger subsystems.
The count is deliberately left at 12 rather than trimmed. Quietly shrinking a
parity number is the exact failure this tooling exists to catch; the fix is to
record what the number means, so the next person starts from the two entries
that are real instead of doing ten changes that would each be a regression.
Co-Authored-By: Claude Opus 5 <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Cursor <[email protected]>
* Add AnyAPI built-in tool
AnyAPI puts hundreds of scraping and data APIs behind one key and one
normalized JSON schema, priced per request in USD.
Three tools, not one per platform. The catalog is a few hundred APIs and
it grows, so a tool per platform would be a wrapper that goes stale. The
interface that does not is discover then run:
anyapiSearchApis ranked catalog search; slug, description, USD price
anyapiGetApi one API's normalized input/output JSON Schema + price
anyapiRunApi run an API by slug; returns output and the USD cost
Follows the valyu/firecrawl pattern: ToolMetadata, a lazy import() of the
optional package that throws MissingEnvVarError without ANYAPI_API_KEY and
MissingDependencyError without @getanyapi/sdk, tool factories, and
create*Tool wrappers registered in tools.ts.
One deviation from those two, deliberate: when the package loads but does
not export the client, this throws MissingDependencyError instead of
returning an empty result. A run reports the USD it charged, and a
fabricated zero cost would misreport money.
* fix(ts): export anyapi factories from package root
Adds anyapiSearchApis/anyapiGetApi/anyapiRunApi to the praisonai package
root export list so consumers can import them like the sibling built-ins
(valyu*, firecrawl*), closing the parity gap flagged in review.
Co-authored-by: Mervin Praison <[email protected]>
* fix(ts): make the advertised anyapi id resolvable and name the price a ceiling
Two review findings on #4817.
Register the base `anyapi` id alongside the three suffixed ones, the way
tavily already does. `tools list` prints the metadata id `anyapi`, and
`tools.anyapi()` exists on the facade, but the registry only held
anyapi-search-apis/get-api/run-api, so `tools.create('anyapi')` and
`praisonai-ts tools test anyapi` both failed on an id the CLI had just
listed. The base id now resolves to the search tool, the entry point of
the discover-then-run loop.
Rename AnyapiApiSummary.priceUsd and AnyapiGetApiResult.priceUsd to
maxCostUsd. Both map pricing.from.maxUsd, which the SDK documents as the
price of a flat offer but only the ceiling of a linear one, so "price"
overstated it for metered APIs and sat oddly beside failoverMaxUsd, which
was already named as a ceiling. The two tool descriptions the model reads
say the same thing now. AnyapiRunApiResult.costUsd is unchanged: that one
really is what the call was charged.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
* chore(ts): regenerate the parity tracker for the anyapi exports
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Kevin Wang <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
Co-authored-by: Cursor <[email protected]>
* feat(ts): compute providers become toolsRunOn places
`toolsRunOn` was already wired end to end -- resolvePlacement picks a place and
Agent.invokeTool routes tool calls through it -- but the registry that
registerToolPlace fills was EMPTY. The mechanism existed and nothing populated
it, so every `toolsRunOn` value silently fell back to running on the host.
new Agent({ instructions: '...', toolsRunOn: 'docker', tools: [...] })
ComputeToolPlace adapts a ComputeProvider (#5003) to the ToolPlaceLike
contract, and registering happens on import of praisonai/compute -- by the act
of having providers, rather than a caller remembering a setup step.
Four decisions:
- A tool without a declared `command` runs LOCALLY and says so. A JavaScript
closure cannot cross a process boundary, and pretending otherwise would imply
isolation that is not there.
- Every substituted argument is single-quoted. Verified: `{who: "a; echo pwned"}`
produces the literal text, not a second command.
- An unavailable provider RAISES rather than falling back to the host. Silently
running on the host what a caller asked to sandbox is the opposite of what
asking for a sandbox means -- a security property, not an inconvenience.
- A timeout raises rather than returning an empty string, which would read as a
successful tool call that found nothing.
Deliberately NOT claimed: AgentTeam.toolsRunOn stays in the behaviour ledger.
This honours the AGENT-level option; team-level placement needs one shared
instance across members and is not wired. I removed that ledger entry first,
an existing parity test failed, and it was right to -- the entry is restored
rather than the test adjusted.
8 new tests (24 in tests/unit/compute total), three of them controls. Full
suite 2485 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* feat(ts): a team-wide toolsRunOn places every member in ONE sandbox
The ledger note said this "needs one shared sandbox for the whole team;
TypeScript has no compute providers yet, so every tool would still run on the
host". That was true until #5003 and #5007. A single ToolPlace instance handed
to every member is exactly one shared sandbox, so the entry is now removed --
legitimately, with a test proving members share the SAME instance rather than
one each (separate instances would multiply cost and lose state tools leave for
each other).
An agent that declared its OWN toolsRunOn keeps it: an explicit choice on the
member is more specific than the team's default, and silently overriding it
would be the surprising direction.
behaviour parity: 12 -> 11 options.
Two things went wrong on the way, both worth recording:
1. I first removed the ledger entry after wiring only the AGENT-level option.
An existing parity test failed and was RIGHT to -- team placement was not
wired. The entry went back until it actually was.
2. Making toolsRunOn validated (rather than accepted-and-ignored) meant 'docker'
had to be a known name without the caller importing praisonai/compute. My
first attempt used `require()` in placement.ts, which put compute on
praisonai/mobile's static graph and broke the chrome58 bundle check --
`require` counts as a STATIC import, a trap this package has hit before.
The built-ins are now thin placeholders that load the real provider inside
runTool through a COMPUTED specifier, so nothing lands on any bundle graph.
One existing test is updated rather than worked around: it used 'docker' as its
example of an UNREGISTERED place, which docker no longer is. It now names one
that genuinely is not registered, keeping the behaviour it guards.
6 new tests, three of them controls: no toolsRunOn leaves members unplaced,
toolsRunOn=false is not a placement, and an unknown place still raises.
Full suite 2491 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(ts): close five gaps in compute tool placement
- ESM: use a literal dynamic import so esm-shim appends .js (computed
specifier dodged the rewrite and threw ERR_MODULE_NOT_FOUND); still
dynamic, so compute/ stays off the mobile/chrome58 static graph
- team: adopt the shared place in agentFor so task-owned and agentConfig
agents land in the SAME sandbox, not just constructor members
- compute: registerComputeProvider now also registers the toolsRunOn
place, so a custom provider is selectable via toolsRunOn
- docker: shutdown throws when `docker rm -f` fails instead of reporting
a clean stop for a container that may still be running
- tool-place: warn once per tool when a non-local place falls back to
host execution, making the isolation gap visible
Tests: 2495 passed, build + webview-gate exit 0.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Co-authored-by: Cursor <[email protected]>
Ports praisonaiagents/guardrails/tool_guardrails.py to praisonai-ts and removes
the two expiring parity waivers it was written to cover.
praisonai-ts had guardrails at two scopes and nothing in between: whole-run
output validation, and an agent-wide tool surface firing for every tool the
agent can reach. Neither lets a tool author say "*this one* tool must never be
called with a recipient outside the company domain":
const sendEmail = tool({
name: 'send_email',
inputGuardrails: [(args) =>
String(args.to).endsWith('@corp.com')
? [true, args]
: [false, 'Recipient is outside the company domain.']],
execute: async ({ to, body }) => { ... },
});
Contract, matching Python exactly:
- A block RETURNS the reason to the model as the tool result; it does not
throw. A blocked call is a normal policy outcome, and throwing would abort
the run and surface a stack trace for it. The model can then pick different
arguments, choose another tool, or explain to the user.
- A guardrail may REWRITE: [true, value] substitutes, [true, null] means
"unchanged" rather than "replace with null".
- Unreadable verdicts and throwing guardrails FAIL CLOSED. A verdict that
cannot be interpreted is not an approval.
- Input rewrites must still be an object of keyword arguments; anything else
blocks, because handing a non-object to the tool would throw inside user
code instead of producing a message the model can act on.
- The output guardrail sees the RAW result, before any agent-wide handling.
- Chains run in order, each guardrail's allowed value feeding the next, short
-circuiting on the first failure. failOpen is opt-in.
Coerced at definition time so a malformed declaration surfaces where it was
written, and so the per-call path is a single property read -- a tool with no
guardrails does no per-call work at all.
One TypeScript-specific trap worth recording: the direction is passed THROUGH
the base constructor rather than declared as a subclass field. Subclass field
initializers run after super(), so `readonly direction = INPUT` would still be
undefined inside the base constructor that needs it.
30 tests covering both directions, all verdict shapes, rewriting, redaction,
chaining and short-circuit, both fail-closed paths, the failOpen escape hatch,
memoised coercion, and controls proving guardrails on one tool never fire for
another and that an unguarded tool is untouched.
Parity gates: names regenerated (guardrails 16 -> 33 exports), signatures OK
(input_guardrails/output_guardrails now camelCase-matched instead of MISSING
(waived)), behaviour ratchet OK. Full praisonai-ts suite: 2705 passed, 0 failed.
The behaviour report and package-lock are deliberately NOT in this commit: the
report's only change is a pre-existing 12 -> 10 drop from AgentTeam.autonomy and
toolsRunOn, which this change did not close and should not claim, and main
regenerates that file on push anyway.
Co-authored-by: Claude Opus 5 <[email protected]>
Local ./.github/actions/pick-oauth-token vanishes after checkout switches to
PR branches that predate dual OAuth (e.g. #4958). Use the template action
and run token pick before PR branch checkout.
Co-authored-by: Cursor <[email protected]>
Catching bare Exception let an installed-but-broken praisonai_code import
be treated as absent, silently disabling test isolation and hiding the
environment defect. Narrow to ImportError so genuine import failures surface.
Co-authored-by: Mervin Praison <[email protected]>
Add an autouse fixture in src/praisonai/tests/conftest.py that calls
praisonai_code._framework_availability.invalidate() before and after each
test, so a memoised answer computed while a test stubs find_spec /
distribution never leaks into later tests. Also document invalidate() as
the test escape hatch in the is_available() docstring.
Co-authored-by: pm25coder <[email protected]>
- _config_schema.py: add field_validator rejecting invalid unknown_user_policy
at load time (mirrors validate_approval_mode) so typos no longer pass schema
validation and silently disable the channel via BotConfig.
- _config_schema.py: reword deny banner to acknowledge already-paired users
(responds to "NOBODY new") instead of overstating "NOBODY".
- _unknown_user.py: deny-drop warning now logs platform= and conversation=
separately so operators can locate the affected chat.
- tests: add pair-policy banner test, invalid-policy rejection test, and assert
platform/conversation labels in the deny-drop warning test.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
When unknown_user_policy defaults to deny, a DM from a user not in
allowed_users was dropped with no log at all, and the startup banner
still warned the bot "responds to EVERYONE" — the opposite of the
effective policy. Both made a misconfigured bot look broken.
- _unknown_user.py: log a WARNING (user_id + policy) instead of a
silent drop so an operator can see why a DM was ignored.
- _config_schema.py: add the unknown_user_policy field and make the
empty-allowlist banner match the resolved policy (deny -> NOBODY,
allow -> EVERYONE, pair -> pairing required).
Co-authored-by: Dhivya-Bharathy <[email protected]>
Skip litellm remote cost-map fetches in ollama URL tests, use portable paths
in context_events import benchmark, and fall back to github.token in the
review-chain workflow when the GH_TOKEN secret is unset.
Co-authored-by: Cursor <[email protected]>
Address reviewer findings on the single-bot admission-policy wiring:
- Coerce numeric owner_user_id via a before-validator on both the channel
and top-level single-bot fields, so an unquoted YAML `owner_user_id:
987654321` (natural for Telegram/Discord) no longer fails Pydantic
validation. Mirrors the gateway path's existing str() coercion.
- Validate the top-level unknown_user_policy via a shared normalization
helper so a typo (`alow`) fails closed even when a `channels:` block is
present (previously only validated when migrated onto a synthesised
channel).
- Gate the startup `unknown_user_policy` line behind `policy_applied` so it
is printed only on platforms that actually wire it into BotConfig
(telegram/discord/slack), and surface the effective `deny` default when
omitted instead of printing nothing on the common path.
- Add regression tests: numeric owner id (channel + top-level), top-level
typo rejection with channels present, and startup-info gating.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Mervin Praison <[email protected]>
The `praisonai bot start` CLI path built BotConfig without forwarding
`unknown_user_policy`/`owner_user_id`, so a bot.yaml declaring
`unknown_user_policy: allow` was silently ignored and the secure `deny`
default won — dropping every DM. The gateway path already wires this
(Issue #2855); the single-bot CLI path was missed.
- Declare `unknown_user_policy`/`owner_user_id` on ChannelConfigSchema and
as top-level single-bot fields, migrating the top-level values onto the
synthesised channel.
- Validate `unknown_user_policy` (fail-closed on typos).
- Forward the fields through BotCapabilities into all three CLI BotConfig
sites (telegram/discord/slack) via a shared `_policy_kwargs` helper.
- Print the resolved policy at startup so operators can confirm it applied.
- Add regression tests for CLI wiring and YAML validation.
Co-authored-by: Dhivya-Bharathy <[email protected]>
- Wrap crewai availability invalidation in try/finally so a failing
assertion cannot leak a stale ``crewai: False`` into the process-wide
registry cache (Greptile: order-dependent follow-on failures).
- Reword missing-YAML routing test docstring/comment to be dispatch-only,
since the recorder stubs run.app and the target is not read (CodeRabbit).
Co-authored-by: Mervin Praison <[email protected]>
is_available() memoises probe results per process (intended hot-path
behavior). The two TestRegistryImportErrorIsContained tests patch
registry.create to raise ImportError, but a cached probe from an earlier
test short-circuited before create() ran, so the ImportError path was
never exercised (DID NOT RAISE / assert True is False). Drop the cached
crewai entry around each test so the patch is honored deterministically.
Co-authored-by: Mervin Praison <[email protected]>
The npm package @modelcontextprotocol/server-time does not exist (404).
Replace npm/npx references with working packages:
- YAML example: use published Python server via `uvx mcp-server-time`
- mcp.py docstring and CLI test: use @modelcontextprotocol/server-filesystem
Co-authored-by: Dhivya-Bharathy <[email protected]>
`praisonai run agents.yaml` already routes a .yaml/.yml first token to the
modern Typer agent runner instead of the async-jobs CLI (issue #4374 fix in
praison_ai.py:1382-1415). This adds a regression test covering the
non-existent/misspelled .yaml case from issue #5095 so the documented
onboarding path can't silently regress back to the confusing jobs-API error.
Co-authored-by: Dhivya-Bharathy <[email protected]>
Only forward the top-level app_token into the migrated channel when the
declared platform is slack (Greptile p2). app_token is Slack-specific, so
forwarding it to a non-Slack custom adapter with a strict constructor could
prevent the channel from starting. Adds regression tests for the ${ENV}
reference form and the Slack-scoping guard.
Co-authored-by: Mervin Praison <[email protected]>
The single-bot bot.yaml migration built the Slack channel from `token`
alone, so a plaintext top-level `app_token:` was silently dropped and
never reached the Slack Socket Mode adapter. Accept `app_token` as a
top-level field and thread it into the migrated channel. The core
`BotConfig(app_token=...)` TypeError was already fixed and tested; this
closes the remaining wiring gap.
Co-authored-by: Dhivya-Bharathy <[email protected]>
litellm fetches its remote model-cost map from GitHub at import time; the
network guard blocks that outbound call, so any unit test that freshly imports
litellm (LLM construction, capabilities) failed with NetworkBlockedError.
Set LITELLM_LOCAL_MODEL_COST_MAP in pytest_configure so imports use the bundled
local map, unless the environment explicitly opts in to live network.
Co-authored-by: Mervin Praison <[email protected]>
Invalidate crewai availability in a finally block so the two
TestRegistryImportErrorIsContained tests no longer leave a stale
False cached on the process-wide default registry, preventing the
order dependency Greptile flagged from moving to later tests.
Co-authored-by: Mervin Praison <[email protected]>
TestRegistryImportErrorIsContained assumed the patched create() was the only
path, but is_available() memoises probes in _avail_cache. When an earlier test
in the same xdist worker warmed the cache (e.g. via list_available_frameworks),
the patched create() was never reached, causing intermittent failures.
Call registry.invalidate_availability("crewai") before patching, as the
is_available docstring already prescribes for tests.
Co-authored-by: pm25coder <[email protected]>
_build_yaml_workflow referenced self._adapter_registry unconditionally,
raising AttributeError when an AgentsGenerator is constructed without the
injected registry (e.g. via __new__ in tests, or any path bypassing
__init__). Resolve the registry once via the existing safe accessor
(getattr(...) or _get_default_adapter_registry()) so build-time framework
resolution and validation still honour an injected/tenant-scoped registry
but transparently fall back to the process default otherwise.
Fixes CI: test_workflow_yaml_cli_backend_rejected.
Co-authored-by: Mervin Praison <[email protected]>
- Workflow observability labels (sync + async) now resolve
self.framework or config.get('framework') so caller-supplied
frameworks aren't mislabeled by config-only resolution.
- _build_yaml_workflow resolves and validates the framework through
the injected registry, keeping build-time validation consistent with
the observability label for tenant-scoped registries.
- JobSubmitRequest.framework defaults to None so an omitted API field
reaches the registry default selection instead of forcing praisonai.
- Executor resolves the default framework via asyncio.to_thread to keep
registry entry-point discovery off the event loop.
- Add unit tests for resolve_or_default and registry-backed
framework_from_config.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
Gap 1: adds FrameworkAdapterRegistry.resolve_or_default() and removes the
scattered `or "praisonai"` literals in agents_generator, jobs, scheduler, and
workflow_framework. Workflow observability sessions now tag the config-resolved
framework instead of a hardcoded name. Backward-compatible.
Co-authored-by: Mervin Praison <[email protected]>
Lazy __getattr__ served symbols only from a private cache, so resolved
names never became real module attributes. This broke eager-import
parity: dir() omitted the API and monkeypatch.delattr(gw, ...) raised
AttributeError, failing test_check_code_skew_uses_cached_predicate_not_fresh_import.
Now __getattr__ writes each resolved symbol into globals() (real,
deletable, patchable, discoverable), and a __dir__ exposes __all__ for
IDE/autocomplete without importing protocols.py. Cold-import boundary is
preserved: protocols.py is still parsed only on first protocol touch.
Co-authored-by: Mervin Praison <[email protected]>
Replace the eager `from .protocols/.liveness/.degraded_state/.hooks/.config
import (...)` blocks with a symbol->submodule map driven by the SDK's
existing `create_lazy_getattr`, chained from the module's existing
`__getattr__` (which already lazy-loads WebSocketGateway/GatewaySession).
protocols.py (7,201 lines / 283 KB) is now parsed only when a protocol/policy
symbol is first touched; config-only access loads only gateway/config.py.
All public import paths, __all__, and behaviour are unchanged; mirrors the
mcp/skills packages per AGENTS.md §4.2.
Co-authored-by: MervinPraison <[email protected]>
- Arm the shutdown-phase deadline around the real supervisor-driven
teardown in start_with_config()'s finally (stop_channels + session
drain), not only the explicit stop() path — closes the primary gap.
- Reject non-finite (NaN/inf) grace overrides in _resolve_shutdown_grace
so an override never silently no-ops arm_deadline().
- Make the deadline generation-safe: each arm gets its own stop event
under a lock; a cancelled/stale generation checks its own event and
stays inert, so it can never os._exit a later healthy shutdown.
- Make deadline tests deterministic (drive _on_deadline / join instead
of fixed sleeps); add stale-generation and non-finite-grace tests.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Mervin Praison <[email protected]>
Address reviewer feedback (Qodo/Greptile/CodeRabbit) on the DbAdapter
tool-turn persistence path:
- Move optional on_assistant_message/on_tool_message off the
runtime_checkable DbAdapter base protocol into a separate
ToolTurnDbAdapterProtocol capability protocol, so legacy adapters stay
structurally compliant (isinstance) while the agent still feature-detects
via hasattr.
- Implement on_assistant_message/on_tool_message in the production
PraisonAIDB adapter and carry tool_calls/tool_call_id in on_agent_start
so the fix actually reaches the supported DB backend end-to-end.
- Normalize restored tool calls to provider-shaped (OpenAI) dicts in
_init_db_session so a DbToolCall dataclass from a spec-following adapter
never yields a malformed/non-serializable tool-call list.
- Tests: capability-protocol detection, legacy-adapter compliance,
DbToolCall normalization, and a real SQLite round-trip in the wrapper.
Co-authored-by: Mervin Praison <[email protected]>
Reviewer fixes for PR #5083:
- Agent.aclose() now tears down a materialised LLM client (async-preferred),
mirroring close(); previously aclose() marked _closed without releasing the
client, so per-request invoke clones (which prefer aclose) leaked pools.
Avoids lazy client creation by only touching an existing _llm_instance.
- _safe_close_agent derives clone ownership from _supports_session_isolation()
on the resolved agent instead of comparing against a second, independently
timed registry lookup — race-free under concurrent registry replacement.
Drops the now-unused template argument from both invoke paths.
- Tests: add FastAPI route-level clone cleanup coverage (success/failure/shared
template) and Agent.aclose() LLM-client teardown regression tests.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
Forward the cancellation token from the agent streaming path into
get_response_stream, stop the streaming loop before the follow-up model
call when cancelled, and skip pending fallback tool dispatches on Stop.
Co-authored-by: Mervin Praison <[email protected]>
- Revert _execute_backend_sync to its original unbounded form. Applying
_tool_timeout (ToolConfig.timeout, a per-tool deadline) to bound an entire
managed backend run was out of scope for #5077, semantically wrong, and
ineffective anyway (ThreadPoolExecutor context exit calls shutdown(wait=True),
which waits for the already-running worker). Flagged by Greptile/Qodo.
- Middleware async-tool timeout (the actual #5077 fix) is retained and unchanged.
- Add correlation context (agent/run_id/tool_call_id) to the middleware timeout
warning and use the module logger for consistency.
Co-authored-by: Mervin Praison <[email protected]>
Address reviewer feedback (Qodo/Greptile) on PR #5078:
- MCP.shutdown() now keeps self.runner if the thread outlives the join so a
later shutdown() can retry, instead of clearing the reference unconditionally.
- MCPToolRunner.stop() takes an optional timeout defaulting to the runner's own
operation timeout so in-flight calls can unwind before giving up.
- Init-failure path uses stop(timeout=1) to preserve fast-fail teardown.
- Tests exercise a live worker thread join and the still-alive retry branch.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
Reuse the core LoopWatchdog stack-dump/os._exit primitive with a new
deadline mode (arm_deadline/cancel + shutdown_grace_s policy field) so a
teardown step that blocks while the event loop is still alive gets an
all-thread stack dump and a bounded self-exit instead of an external
SIGKILL. Wire it into gateway server.stop(): arm drain_timeout+grace at
the start of the stop path, cancel in a finally on clean completion so a
healthy shutdown never self-exits. 3-way surface: gateway.watchdog.
shutdown_grace (YAML) + stop(grace=...) (Python).
Co-authored-by: MervinPraison <[email protected]>
The n8n/HTTP invoke API resolves a fresh Agent clone per request via
resolve_session_agent() but never called close()/aclose(), leaking LLM
client pools, tool-executor threads and MCP subprocesses into the
long-lived server process.
Wrap both the FastAPI route and invoke_agent_standalone in try/finally
that calls a new _safe_close_agent() helper. The helper only closes a
genuine clone (agent is not the shared registry template), prefers async
aclose(), falls back to close() via a worker thread, and swallows/logs
cleanup errors so teardown never masks a successful response.
Co-authored-by: Dhivya-Bharathy <[email protected]>
The DbAdapter branch of _persist_message() took a text-only early return,
dropping assistant tool_calls and role="tool" results — and restore stripped
the same structure. This gave resumed DB sessions a broken transcript (the
JSON store already handled this in #3089).
- _persist_message DB branch now routes assistant tool_calls to
on_assistant_message() and tool results to on_tool_message() when the
adapter exposes them, falling back to on_agent_message() (text-only) for
legacy adapters so behaviour is unchanged for them.
- _init_db_session restore rebuilds the full LLM message shape, carrying
tool_calls / tool_call_id from DbMessage.
- Added optional on_assistant_message / on_tool_message to the DbAdapter
protocol and a tool_call_id field to DbMessage.
- Tests mirror #3089 with a mock adapter, including legacy fallback.
Co-authored-by: Dhivya-Bharathy <[email protected]>
Both execute_batch call sites in llm.py omitted cancel_token, so a
Stop/interrupt requested during the tool phase let batched tools run to
completion. Forward the token in get_response and extract+forward it in
get_response_stream so pending tool calls short-circuit with a typed
cancelled result.
Co-authored-by: Dhivya-Bharathy <[email protected]>
The async tool middleware path blocked a worker thread on future.result()
with no timeout, so a hung async tool blocked middleware indefinitely and the
per-agent tool timeout was ignored on this path. Bound the worker wait by the
existing _tool_timeout, cancel the future on timeout, and surface the same
structured timeout error dict the direct async path returns. Apply the same
bound to _execute_backend_sync.
Co-authored-by: Dhivya-Bharathy <[email protected]>
MCP.shutdown() previously only enqueued a sentinel via runner.shutdown(),
leaking one daemon thread and stdio child (npx/node) per MCP server on
long-lived processes. Now it also calls runner.stop() to join the thread
and clears self.runner, aligning normal teardown with the init-failure path.
Co-authored-by: Dhivya-Bharathy <[email protected]>
- Gateway _build_channel_adapter now runs the same capability-contract
verification as Bot._build_adapter; a declared-but-unbacked supports_*
flag is recorded as a degraded channel instead of failing mid-turn.
- verify_capability_contract now requires the backing attribute to be
callable, so edit_message/delete_message = None is caught at build time.
- Move supports_delete to the end of PlatformCapabilities to preserve the
positional constructor contract for existing callers.
- Add tests: non-callable backing detection and positional-order regression.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
Add a pure, dependency-free capability-contract check in core so a declared
`supports_*` flag can never reach a live turn unbacked. `verify_capability_contract`
/ `enforce_capability_contract` check each flag in `CAPABILITY_BACKING` against the
method that must override the BasePlatformAdapter default, raising a clear
`CapabilityContractError` at adapter build time instead of a late
`NotImplementedError` in the delivery loop. Adds a `supports_delete` flag and makes
`delete_message` capability-gated (parity with `edit_message`) rather than silently
returning False. The wrapper's `Bot._build_adapter` invokes the verifier.
Co-authored-by: Mervin Praison <[email protected]>
Three tests in tests/unit/bus/test_event_bus.py published to a bare bus and
expected get_history() to return the events. Two others in the same file
published to a bare bus and asserted get_history() is empty. Both cannot hold,
and the first three had been red since June.
b7b877c5f1 (#2066) added a fast path that skips the lock, Event construction
and the history append when has_subscribers is False, because memory and
sub-agent lifecycle publishes were paying uuid4 + lock + append on every call
with nothing listening. It added the two tests pinning the new behaviour and
did not update the three that contradict it.
The three now subscribe before publishing, which is what they were really
testing (history records, filters, and honours its limit). Two new tests state
the replacing contract directly -- nothing is recorded without a subscriber,
and subscribing later does not backfill -- so the file no longer holds both
positions, and a future reader is not left deciding which red test to believe.
get_history's docstring now says so too. The consequence is worth stating
because it is surprising in the case you would most want history -- debugging
after the fact with nothing subscribed: publish three events to a bare bus,
call get_history(), get an empty list.
No production code reads the bus's own history, so this documents and pins the
existing optimisation rather than reversing it. Whether an introspection API
should be silently lossy is a design question for whoever owns #2066; this
change only stops the suite arguing with itself.
Suite: tests/unit/bus 52 passed (was 3 failed).
Co-Authored-By: Claude Opus 5 <[email protected]>
merge-only skipped APPROVE merges when verdict comments sat beyond page 1
of issue comments or landed after the 25-minute lookup window. Paginate
comments explicitly and poll for MERGE_GATE_VERDICT on HEAD before merging.
Co-authored-by: Cursor <[email protected]>
- concurrency: replace loop-keyed asyncio.Semaphore with a single per-agent
threading.Semaphore shared by sync/async callers across all event loops.
Fixes cross-loop over-admission, sync acquire/release bypass, and unbounded
loop-key cache growth. Async acquire offloads the blocking wait to an
executor so the event loop is never blocked.
- health_monitor: dispatch on canonical health_check/ahealth_check while
keeping backward compatibility with legacy check_health/acheck_health.
- tests: add cross-loop limit, sync-pool-shared/blocking, mixed sync+async,
jitter-at-cap, and canonical+legacy health-protocol regression tests.
Co-authored-by: Mervin Praison <[email protected]>
_process_single_input raised only when *every* chunk of a file failed to
store, so a document that lost some — but not all — of its chunks returned
a success-shaped result and left IndexResult.success True. add() now reports
the partial-failure count; index() surfaces it into result.errors, flipping
success. Regression test added for the partial-chunk path.
Co-authored-by: Mervin Praison <[email protected]>
Address reviewer findings on cross-session recall of compacted history:
- window() now scrolls the same archived+active projection search anchors
against, so an archived hit resolves to the matching turn (not an
unrelated recent one) across all three built-in stores.
- SqliteSessionStore versions the FTS content projection and force-rebuilds
an already-populated (pre-upgrade, active-only) index once on open, so
archived-only queries reach previously compacted routed sessions without
waiting for another write.
- Add regression tests: transcript-store archived recall + real compaction +
window scroll, sqlite upgrade/migration, and archived-anchor window scroll
for the default and indexed stores.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
Cross-session recall (session_search) only indexed/scanned a session's
active `messages`, so once a conversation was compacted under the default
`retention="compact"` policy its raw turns — moved into
`archived_messages` — became permanently unsearchable.
All three built-in stores now recall the whole persisted conversation via
one shared projection `_searchable_messages(data)` (archived + active, in
order), keeping the readers from drifting:
- sqlite_store._flatten indexes archived ahead of active turns, so a
post-compaction re-index preserves rather than DELETEs them.
- DefaultSessionStore.search, SqliteSessionStore.search and
SqliteTranscriptSessionStore.search scan the merged list; archived
context entries are tagged `archived=True` so the compaction boundary
stays visible to callers.
Core-only (praisonaiagents), stdlib sqlite3, no new params/exports/deps.
Co-authored-by: Mervin Praison <[email protected]>
- concurrency.py: replace per-(agent,loop) asyncio.Semaphore with a single
loop-neutral threading.Semaphore per agent so the limit is a true global cap
across every event loop and thread. async acquire() polls non-blockingly
(cancellable, never blocks the loop or leaks a blocked executor thread);
acquire_sync() shares the same pool; no more closed-loop cache leak.
- health_monitor.py: dispatch canonical ahealth_check/health_check AND fall
back to legacy acheck_health/check_health for backward compatibility.
- tests: multi-thread global-cap, sync+async shared-pool, non-blocking async
acquire; canonical/legacy/callable health-check dispatch.
Co-authored-by: Mervin Praison <[email protected]>
The shim's _register_submodules iterated list(sys.modules.items()); a concurrent
import in another thread could mutate sys.modules mid-materialisation, raising
RuntimeError: dictionary changed size during iteration (CI: _shim.py:115). Retry
the snapshot, then fall back to reading values by key.
Co-authored-by: Mervin Praison <[email protected]>
- concurrency.py: key semaphores per (agent_name, running loop) so a cached
asyncio.Semaphore is never shared across event loops; acquire_sync creates
and acquires inside its own loop; release/set_limit/remove_limit are loop-aware.
- retry.py / tool_execution.py: re-clamp delay to max_delay AFTER jitter so the
documented cap is a hard ceiling (was reaching up to 1.25x/1.5x).
- health_monitor.py: reuse circuit_breaker.HealthCheckProtocol and dispatch on
health_check/ahealth_check so classes written against the public protocol are
no longer silently reported unhealthy.
Co-authored-by: Mervin Praison <[email protected]>
- Restore exported status/outcome so a terminal run does not resurrect as running
- overwrite=True now replaces (delete_run) instead of merging stale destination events
- Validate all events up front so a malformed blob leaves no partial run behind
- Move portable API into the runtime lazy-import group (no eager SQLite journal load)
Co-authored-by: Mervin Praison <[email protected]>
- /api/approvals read ApprovalRegistry's real fields (_required_tools /
_agent_required_tools + get_risk_level) instead of a nonexistent
_requirements attr that made every request 503.
- Bound client-controlled limit with Query(ge=1, le=...) on runs/sessions
so a negative value can no longer disable SQLite's LIMIT (LIMIT -1 = all).
- Return 404 for unknown sessions even when the store lacks session_exists,
via an empty-transcript fallback.
- Add tests for all three.
Co-authored-by: Mervin Praison <[email protected]>
An earlier list member requesting a stop (StepResult(stop_workflow=True)
or on_error="stop") was overwritten by a later member's success because
the stop check ran only after the whole sequence. Now stop halts the
remaining members immediately. Repeat([]) no longer raises
UnboundLocalError; it is a defined no-op. Adds two regression tests.
Co-authored-by: Mervin Praison <[email protected]>
A genuine ImportError inside an installed praisonai_bot would otherwise be
turned into a skip by importorskip on the deep module, silently dropping these
tests from CI. Skip only when the top-level package is absent; import _session
directly so real regressions surface as failures.
Co-authored-by: Mervin Praison <[email protected]>
Address reviewer findings on the step-result cache:
- Patterned executor now caches only successful results (skips dicts carrying
an "error" key) so a transient nested failure retries instead of replaying a
cached failure forever. Same guard added to the manager wrapper.
- Linear cache stores the step's output variable (output_variable or
<name>_output) so a cache hit restores it; without this a fully cached
re-run left the variable missing and broke downstream substitutions.
- InMemoryStepCache deep-copies on set and get (with a safe fallback for
non-copyable values) so cached state cannot be mutated in place, and guards
all reads/writes with a lock so shared parallel branches cannot race
move_to_end into a KeyError.
- make_step_key tags each variable value with its type so True and "True"
(or 1 and "1") no longer collapse to the same key.
Adds regression tests: failure-not-cached inside a Parallel, output-variable
replay on a cached re-run, mutation isolation, and type-preserving keys.
tests/unit/workflows: 229 passed, 0 failed.
Co-authored-by: Mervin Praison <[email protected]>
- resolver: only enhance the "Unknown runtime:" message with the available
list; a ValueError raised by a runtime factory after a valid id is found
(bad config/construction) is re-raised untouched rather than mislabeled
"Unknown runtime ID", which hid the actionable cause (Greptile P2).
- test_learn: the MongoDB-fallback test patched a lazily resolved attribute
whose real construction lives in the praisonai wrapper; mock resolved the
original first and the module __getattr__ raised ImportError (not
AttributeError) in a base install, so the patch blew up before the test
ran. Inject the stub into the module dict so the same offline fallback is
exercised regardless of wrapper presence.
Co-authored-by: Mervin Praison <[email protected]>
- knowledge: surface within-file partial chunk failures via failed_chunks so
index() records an error and success reflects incomplete corpus
- hooks test: pass command as arg list to preserve interpreter paths with spaces
- plugins test: clear paths cache on teardown to stop tmp_path leaking to later tests
Co-authored-by: Mervin Praison <[email protected]>
Address reviewer feedback (greptile):
- test_tool_retry_agentic.py: replace OPENAI_API_KEY skipif with @pytest.mark.live
so PRAISONAI_LIVE_TESTS=1 is the single explicit opt-in; a key merely being
present no longer routes billable LLM calls through the default unit run.
- test_indexing.py: move the class-level live marker onto only the indexing
methods that make real embedding calls, so the deterministic
test_knowledge_has_index_method API-contract check stays in the default suite.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
Addresses the reviewer note that the hand-kept parameter->config mappings
cannot catch a future config-backed parameter left unexported. Adds a
completeness guard that walks every Agent/PraisonAIAgents parameter
annotation, extracts referenced *Config classes defined in feature_configs,
and asserts each is importable from praisonaiagents.config -- so a new
parameter's class cannot be left behind without editing any list.
Mutation-checked: un-exporting ToolConfig fails the new guard.
Co-authored-by: Mervin Praison <[email protected]>
reasoning_effort is a live constructor arg (Issue #4452) that was absent from
_AGENT_FIELDS, so a 'high' agent silently round-tripped back to the default.
Added it, plus tests. team_to_dict now reports tasks_included so a caller is
told the task graph is not serialised in v1 rather than left to discover it,
and the module docstring states the grouped-config limit plainly.
Co-authored-by: Mervin Praison <[email protected]>
The rebase merged two independent timeout-recording paths: main's
breaker._on_failure() and this branch's _circuit_breaker_record(). Both
ran on every timeout, counting each timeout twice and opening a
threshold-5 breaker after only 3 timeouts. Keep main's single record so
timeouts are counted exactly once; the async breaker test now passes.
Co-authored-by: Mervin Praison <[email protected]>
- execution_mixin: wait_for cancels breaker.acall on timeout, so the
breaker never saw the outcome and the post-execution record was skipped
whenever a breaker existed -- repeated timeouts never opened the circuit.
Record the timeout as a breaker failure in the timeout branch.
- conftest/test_config_env_isolation: isolated_config_env now scrubs
PRAISONAI_CONFIG_CONTENT / PRAISONAI_CONFIG (read by _load_env_user_config),
with a guard test pinned to the resolver's constants so the leak can't reopen.
- project.py: a stale root pin (history rewrite / shallow clone) is now
refreshed to the chosen root instead of being left to drift on later runs.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
The praisonai-code unit suite had ten reds on main. None was a code defect;
every one was a test that consulted something outside its own control, so it
passed or failed per machine and was green on CI, where none of it is set.
That is worse than a missing test: it trains you to ignore a red suite.
Seven: the developer's exported model leaked into the config resolver.
ConfigResolver._load_env_config folds MODEL_NAME / OPENAI_MODEL_NAME /
PRAISONAI_MODEL and friends into an "environment" layer. Exporting those is
the normal way to use this tool, so config.sources gained an "environment"
entry that the tests did not expect and the resolved model became whatever
the developer had set:
assert ['defaults', 'environment'] == ['defaults']
assert 'gpt-4o-mini' == 'claude-3-5-sonnet'
A new tests/unit/conftest.py provides isolated_config_env, and the two
affected modules opt in with a module-level usefixtures mark.
test_config_env_isolation.py keeps the scrub list honest by parsing
_load_env_config: a variable added there and not listed would silently
reopen the leak. It reads only the ("VAR", [path]) mapping entries and
os.environ.get calls, not every uppercase string -- the bare suffixes in
endswith(("COLOR", "VERBOSE", "QUIET")) are not variables.
One: the trainer-module assertion depended on which packages were installed.
The dispatcher prefers praisonai_train (the owner package since the C10
extraction) and falls back to the praisonai.train.* compatibility shim. That
is correct, but the test asserted the owner branch without controlling the
condition, so it was red on a checkout without praisonai-train on the path.
Both branches are now driven explicitly by patching train_package_available
at _train_bridge, where the dispatch function imports it from.
One: a command that was migrated to native was still listed as a stub.
The stub table asserts exit 1 without the wrapper. 448b7bb912 made `rules`
native to standalone praisonai-code (#4337) and the table was never updated,
so this had been red ever since. It is the opposite assertion now -- the
point of that change is that it works with no wrapper -- and HOME is
redirected, because it was otherwise listing the developer's real rules.
One: a signature check that could not see through **kwargs.
test_custom_agent_verbose_maps_to_output_preset asserted the captured kwargs
are a subset of Agent.__init__'s named parameters. Agent takes **kwargs and
stores extras as attributes, so a legitimate auto_save (set by the session
wiring) was flagged. Binding against the signature is no better: **kwargs
accepts even the `verbose` this test exists to catch. Only the constructor
knows -- it validates kwargs itself and raises for names that have moved --
so the test now constructs a real Agent. Mutation-checked: re-introducing
agent_config["verbose"] fails it.
Suite: 989 passed, 0 failed, 0 errors (was 10 failed).
Co-Authored-By: Claude Opus 5 <[email protected]>
The prior run failed only at actions/checkout for the 'test-core (root)'
shard with 'remote error: upload-pack: not our ref' — a transient GitHub
fetch error, not a code/test failure. All real test shards (cli, subdirs,
mcp, bots-gateway, deploy, train, sandbox) passed, including the shard
carrying the new test_run_max_tokens.py. Empty commit forces a fresh
checkout to clear the flake.
Co-authored-by: Mervin Praison <[email protected]>
Address reviewer findings on PR #5044:
- Planning now returns executed results (start/astart): _run_with_planning
and _arun_with_planning expose executed plan tasks via _plan_tasks; both
_start_impl and _astart_impl collect status/results/final response from
them instead of the restored (unexecuted) original tasks. Fixes the
high-severity "planned runs return empty results" bug in both sync/async.
- Fallback/rejected plans reset _plan_tasks so no stale executed tasks leak.
- get_task_result gains an optional tasks= source (backward compatible).
- Sync _run_with_planning now routes through the shared _build_plan_tasks
helper so start() and astart() cannot construct divergent plan tasks.
- Async Ollama tool batches resolve chained args at dispatch time and run
sequentially, so a dependent call in the same response resolves an earlier
call's recorded result (parity with sync/stream loops).
- New registry.get_tool_definition(name) returns the effective schema with
dynamic overrides applied and the advertised function name forced to the
registry key; openai_client._generate_tool_definition_from_name uses it so
aliased/overridden string tools resolve correctly. Exception logging now
preserves the traceback (exc_info) instead of discarding the cause.
- Add tests/test_pr5044_fixes.py covering all three fixes.
Co-authored-by: Mervin Praison <[email protected]>
Move _durable_iteration_kwargs to its natural home in tools/call_executor.py
next to the _accepts_durable_iteration flag it reads, and import it in
llm/llm.py and openai_client.py. Deletes the two byte-identical local copies
and reuses the helper in call_executor's own inline block, giving a single
source of truth. Behaviour is unchanged at all call sites.
Co-authored-by: MervinPraison <[email protected]>
- model_capabilities.max_output_tokens: only return max_output_tokens; never
fall back to the generic max_tokens (a context-window field here), which
would inflate the ceiling and leave over-limit requests unclamped (P1).
- run.py: thread the ceiling-derived/clamped budget into the actions fast path
and custom --agent path via a shared _apply_max_tokens helper, carry it on the
YAML config_list model config, and make the warm-runtime path ineligible when
--max-tokens is explicit so a per-call budget is not silently dropped.
- tests: add max_output_tokens accessor coverage (known/unknown/context-only/
litellm-absent) and _resolve_max_tokens/_apply_max_tokens dispatch coverage.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
- rank() now ranks present-but-unknown trust labels as UNTRUSTED so
malformed/forged provenance fails closed instead of crossing a
trusted boundary (absent field still ranks TRUSTED for compat).
- _filter_by_trust validates min_trust strictly (raises on unknown
threshold) and is null-safe for backends returning metadata=None.
- search_*: over-fetch when min_trust is set so trusted matches ranked
below untrusted candidates are not truncated out of recall.
- Add regression tests for the three cases above.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
- Remove package-wide plugins.enable() gate in _merge_plugin_tools; a
registered TOOL plugin is enough (docs: tools work without enable()).
get_all_tools() already filters per-plugin enabled state.
- Skip metadata-only dict descriptors (no executable impl) with a warning
instead of appending un-callable tools; support OpenAI-schema dicts that
carry a callable "function".
- Make PluginManager.get_all_tools() snapshot enabled plugins under the
manager lock so concurrent register/unregister can't drop every tool.
- Update regression test to prove wiring works WITHOUT the global flag and
add a metadata-only-dict skip test.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
Covers _is_reply_to_bot plus the mention_only, observe, and legacy
mention_required branches so a payload-extraction or wiring regression
that silently restores dropped replies fails the suite (Qodo #3 / Greptile P2).
Co-authored-by: Mervin Praison <[email protected]>
- get_implementations: normalize LocationLink (targetUri/targetSelectionRange)
into Location via new _to_location helper so link-shaped responses no longer crash
- _call_hierarchy: query every prepared hierarchy item and deduplicate combined
callers/callees instead of only items[0]
- client: swallow JSON-RPC RuntimeError from optional implementation/callHierarchy
requests so unsupported servers degrade to empty results, not scary errors
- tests: deterministic coverage for link normalization, multi-item dedup, and
no-symbol message
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
- window() now scrolls the same archived-plus-active projection search()
anchors against, so archived-hit anchor indices resolve correctly.
- _searchable_messages guards non-list messages/archived_messages so a
malformed session is skipped rather than aborting all searches.
- SqliteTranscriptStore.search uses the shared projection + archived marker.
- SqliteSessionStore adds an index-content version so an upgraded store
rebuilds stale FTS rows once, making pre-existing compacted sessions
searchable immediately.
- Tests: window archived anchor, malformed-field isolation, upgrade rebuild,
transcript-store archived recall.
Co-authored-by: Mervin Praison <[email protected]>
Adds TestDispatchMaybeAwaitable to test_async_bridge.py exercising the four
branches of the new shared sync→async dispatch helper: non-awaitable
passthrough, no-loop READ/WRITE blocking, running-loop WRITE tracked
fire-and-forget (returns None + tracks future), and failed-write logging
without propagation.
Co-authored-by: Mervin Praison <[email protected]>
The `internal` field had no live consumer anywhere in the codebase
(scope creep per AGENTS.md). Keep only the `allow_control` control-trust
primitive on the shared BotMessage contract, trusted-by-default for
backward compatibility.
Co-authored-by: Mervin Praison <[email protected]>
- exceeds_loss() fails closed on non-finite/out-of-range max_loss_fraction (ValueError)
- add retained_originals so destructive equal-size rewrites trip the loss guard
- import ConsolidationResult at module scope so get_type_hints() resolves
- mark ConsolidationResult docstring example as schematic
- add tests: invalid-threshold, equal-size rewrite, retained_originals, runtime hint resolution
Co-authored-by: Mervin Praison <[email protected]>
- openai_client._generate_tool_definition_from_name now resolves string
tool names via the shared tool registry (mirrors llm.py) instead of
returning None, so Agent(tools=["my_tool"]) works on the OpenAI-native path.
- agents._astart_impl now branches on self.planning and runs a new async
_arun_with_planning (plan -> approval gate -> todo list -> execute),
matching the sync start() path. Task-building extracted to _build_plan_tasks.
- llm.py extracts Ollama tool-chaining into shared helpers
(_resolve_ollama_chained_args, _record_ollama_tool_result) and applies them
in get_response, get_response_stream fallback, and get_response_async so
chained tool references resolve identically across all three loops.
Co-authored-by: Mervin Praison <[email protected]>
Add a lazy `max_output_tokens(model)` accessor to model_capabilities.py
(reusing the same litellm lookup already used for input budgeting) and use
it in the run CLI to derive an unset --max-tokens default and clamp an
over-limit explicit value, so a bare `praisonai run` no longer 400s on
lower-ceiling models nor truncates silently on higher-ceiling ones.
Unknown-metadata models keep today's 16000 constant (backward-compatible).
Co-authored-by: Mervin Praison <[email protected]>
Add a MemoryTrust provenance signal to the core memory protocol so untrusted
channel input (e.g. a gateway bot ingesting a group-chat message) is no longer
silently promoted to and recalled from memory as trusted.
- protocols.py: new MemoryTrust enum (trusted|untrusted|system) with rank()
- Memory.store_short_term/store_long_term: optional trust/origin stamped into a
dedicated metadata field the model cannot forge through prose
- Memory.search_short_term/search_long_term: optional min_trust gate that drops
lower-trust records (untrusted content fenced out when min_trust=TRUSTED)
- Backward compatible: defaults leave writes unstamped (treated as trusted) and
searches unfiltered.
Co-authored-by: Mervin Praison <[email protected]>
PluginType.TOOL plugins returned tools via get_tools(), collected by
PluginManager.get_all_tools(), but no caller merged them into any agent —
the tools were silently never callable. Merge enabled plugins' tools into
self.tools during Agent init; existing agent tools win on a name collision
(reported via warning, not silently shadowed).
Co-authored-by: Mervin Praison <[email protected]>
Collapse the three near-identical submit/track/callback blocks in
db/adapter.py (_call_store, _merge_and_set, on_agent_end) into a single
dispatch_maybe_awaitable() helper in _async_bridge.py, the module that
already owns "run a coroutine correctly from a sync context".
Read-vs-write intent is now expressed via an explicit DispatchKind at the
call site, so the dispatch policy no longer depends solely on a hand-kept
_READ_OPS string allow-list. _READ_OPS is retained as the backward-compatible
default classifier in _call_store.
Scope note: this addresses only Gap 3 of #5026. Gaps 1 and 2 (parallel
storage families and doubled vector-store registries) require destructive
on-disk schema migrations and are deferred as larger, separate changes per
the "lightweight, no scope creep" guideline in AGENTS.md.
Co-authored-by: Mervin Praison <[email protected]>
Extend the core admission primitive with structured MentionFacts (explicit /
reply_to_bot / quoted_bot / thread_participant) and a configurable
implicit_mentions set (default {"reply"}), so a reply/quote/thread to the bot
can be treated as addressing it. Keeps is_mention: bool as a back-compat shim.
Wire the Telegram adapter to detect reply-to-bot as an implicit mention.
Co-authored-by: Mervin Praison <[email protected]>
Add lsp_implementations, lsp_incoming_calls and lsp_outgoing_calls
agent-callable tools backed by the existing LSP client, completing the
semantic-navigation toolset. Extends the client with textDocument/
implementation and callHierarchy/* request helpers, reusing the proven
server lifecycle and position-resolution machinery. No new dependencies.
Co-authored-by: Mervin Praison <[email protected]>
BotMessage now carries allow_control (default True) and internal (default
False). is_command returns False when allow_control is False, so untrusted or
non-interactive content (webhook payloads, relayed/mirrored bot messages,
proactive/wake injects) is never interpreted as a privileged control command
even when attributed to a privileged identity. Interactive human turns are
unchanged (backward compatible by default). Wired through to_dict/from_dict.
Co-authored-by: Mervin Praison <[email protected]>
Core exposes a protocol-only MemoryConsolidationProtocol (sync + async) and a
ConsolidationResult with a maximum-loss guard, so a scheduled off-hot-path
consolidation pass can merge/promote/prune long-lived memory without a bad
rewrite wiping existing entries. Heavy LLM pass + scheduling live in
PraisonAI-Plugins; core stays lightweight and protocol-only.
Co-authored-by: Mervin Praison <[email protected]>
Cross-session recall (session_search) indexed and scanned only a session's
active `messages`, never its `archived_messages`. Under the default
retention="compact" policy, compaction moves raw turns into the archive and
replaces them with a synthetic summary — so the raw turns were DELETEd from
the FTS index on the next write and became permanently unsearchable, silently
dropping older specifics.
Both built-in stores now scan archived + active turns via one shared
projection (`_searchable_messages`) so their results cannot drift:
- sqlite_store `_flatten` indexes archived turns ahead of active ones, so a
post-compaction re-index preserves rather than deletes them.
- Both `search` implementations scan the merged list; archived context entries
are tagged `archived=True` so the compaction boundary stays visible.
Stdlib-only (sqlite3), core `praisonaiagents`, no new params/exports.
Co-authored-by: Mervin Praison <[email protected]>
Delete inert LAZY_IMPORTS constant and drop PRAISONAI_LAZY_IMPORTS from
the module docstring (lazy loading is always on and unconditional).
Remove unused PLUGINS_ENABLED / PLUGINS_LIST constant assignments; the
live plugin gate lives in config/loader.py. Helper functions
_get_plugins_enabled / _get_plugins_list are retained (test-covered).
No behavioural change.
Co-authored-by: Mervin Praison <[email protected]>
Address three valid gaps found in review of PR #4969:
1. Async tool timeouts bypassed circuit-breaker accounting. asyncio.wait_for
cancels the awaited acall, and acall catches only Exception (not the
BaseException CancelledError), so _on_failure never ran; the fallback
recorder is disabled when a breaker exists. Repeated timeouts therefore
never opened the circuit. The timeout path now records the one failure
directly on the breaker.
2. A persisted root-commit pin naming a vanished root was re-chosen but never
rewritten, so it stayed stale and a later root change could reassign the
project id and orphan session history. Stale pins are now refreshed in
place to the current choice.
3. The external-tool registration test leaked into the now-mutable module set,
making is_external_tool order-dependent across tests. An autouse fixture
snapshots and restores the set in place (AGENTS.md 4.6: deterministic tests).
Adds regression tests for each.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
Four tests had been red on main. None was a bad test; three were real defects
and the fourth encoded a contract a later PR deliberately replaced.
1. The async circuit breaker halved its own threshold.
``breaker.acall`` records success/failure for the invocation, and then a
second block recorded the same outcome again through
``_circuit_breaker_record``. That block predates the acall wrapper (#4281),
whose comment still explains it as covering a path acall now covers.
call 1: recorded=2 call 2: recorded=4 call 3: recorded=6 -> OPEN
Every outcome counted twice, so a breaker configured failure_threshold=5
opened after 3 -- a flaky tool was cut off at roughly half the configured
tolerance. The success side is affected too: a HALF_OPEN circuit closed in
half the required successes, re-admitting traffic to a still-broken tool.
Both blocks now run only when the acall wrapper did not (``breaker is
None``). One failure per call; the breaker opens at exactly 5.
2. A trust lookup that failed was treated as "trusted".
``_is_tool_external`` wrapped the registry call in a blanket
``except Exception: return False``, so a registry that existed and failed to
answer was indistinguishable from one that said trusted.
agent/tool_execution.py uses this to decide whether to fence tool output
against prompt injection, so an external tool's result reached the model
unfenced. Now fails closed, and "no registry at all" stays distinct from
"the registry raised" -- otherwise every ordinary function tool would be
fenced.
3. add_external_tool rebound the module global.
It replaced the frozenset rather than mutating it, so any module holding a
reference imported earlier kept the pre-registration copy and went on
treating the tool as trusted. Nothing in-tree holds such a reference yet,
which is a bad way to learn about a security boundary. Now a set, mutated in
place.
4. test_unknown_tool_message_reaches_model_via_public_path was stale.
It asserted the public path raises ToolExecutionError for an unknown tool.
That was true until 1a677bf1c0 (#4446) made tool error dicts flow back as a
normal result "letting the model see the error and retry", which is right
here: ToolExecutionError is terminal and non-retryable
(execution_mixin lets it propagate "to stop the run"), so raising would kill
the run at the exact moment the runtime has handed the model the list of
valid names -- defeating the self-repair #3309 added. The test now asserts
the message and the inventory, and a second test pins that it must NOT
raise, so a future "fix" cannot quietly undo #4446.
Tests: 3 new for the fail-closed lookup, 1 for the in-place registration, 1
pinning the non-raising contract. Each production fix mutation-checked by
reverting it individually. Suite: 683 passed, 0 failures in tools/security
(was 4 failures).
Co-Authored-By: Claude Opus 5 <[email protected]>
adoptAutonomy now mirrors the constructor: an enabled, prompting level on a
member with no approval manager creates one (with a prompt handler) and the
doom-loop guard, so a team-wide `suggest` actually pauses tool calls instead of
being recorded and ignored.
ComputeToolPlace warns when a tool with no command falls back to the host, so a
caller who asked for `toolsRunOn` isolation is told it was not applied rather
than believing they had a sandbox they did not.
Co-authored-by: Mervin Praison <[email protected]>
The ledger note said "Python propagates it to members that have none of their
own; TypeScript Agents have no autonomy to propagate to yet." The second half
was STALE: agent/features/autonomy.ts has levels, presets, auto-approval rules
and doom-loop messages, and Agent has resolved `autonomy` into _autonomyConfig
all along. Verified by running it before writing anything.
So this is propagation, not a new subsystem:
new AgentTeam({ agents: [...], autonomy: 'full_auto' })
behaviour parity: 11 -> 10 options. With AgentTeam.toolsRunOn closed in the
previous change, both entries that were genuinely blocked on TypeScript work
are now done -- the remaining 10 are the ones Python does not act on either,
where implementing them would make this SDK diverge rather than match.
The precedence decision: a MEMBER's own autonomy wins over the team's. An
autonomy level is a permission boundary, and silently WIDENING one an agent
declared for itself is the direction that causes harm. Python does the same --
it propagates only to members that have none.
adoptAutonomy also re-applies the level to that agent's approval manager, so a
propagated level actually changes what runs without asking rather than being
recorded and ignored. It skips agents with no approval manager: there is
nothing to widen there.
One existing parity test listed AgentTeam.autonomy as accepted-with-notice and
is updated, because it no longer is.
5 new tests, two of them controls: no team autonomy leaves members untouched,
and autonomy=false is not a propagation.
Full suite 2496 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
The ledger note said this "needs one shared sandbox for the whole team;
TypeScript has no compute providers yet, so every tool would still run on the
host". That was true until #5003 and #5007. A single ToolPlace instance handed
to every member is exactly one shared sandbox, so the entry is now removed --
legitimately, with a test proving members share the SAME instance rather than
one each (separate instances would multiply cost and lose state tools leave for
each other).
An agent that declared its OWN toolsRunOn keeps it: an explicit choice on the
member is more specific than the team's default, and silently overriding it
would be the surprising direction.
behaviour parity: 12 -> 11 options.
Two things went wrong on the way, both worth recording:
1. I first removed the ledger entry after wiring only the AGENT-level option.
An existing parity test failed and was RIGHT to -- team placement was not
wired. The entry went back until it actually was.
2. Making toolsRunOn validated (rather than accepted-and-ignored) meant 'docker'
had to be a known name without the caller importing praisonai/compute. My
first attempt used `require()` in placement.ts, which put compute on
praisonai/mobile's static graph and broke the chrome58 bundle check --
`require` counts as a STATIC import, a trap this package has hit before.
The built-ins are now thin placeholders that load the real provider inside
runTool through a COMPUTED specifier, so nothing lands on any bundle graph.
One existing test is updated rather than worked around: it used 'docker' as its
example of an UNREGISTERED place, which docker no longer is. It now names one
that genuinely is not registered, keeping the behaviour it guards.
6 new tests, three of them controls: no toolsRunOn leaves members unplaced,
toolsRunOn=false is not a placement, and an unknown place still raises.
Full suite 2491 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
Address reviewer feedback on the human sign-off feature:
- Send the COMPLETE output to the reviewer instead of a 4,000-char prefix,
so unreviewed trailing content cannot slip past an approval.
- Type the injected approval manager with a boolean-returning requestApproval
(ReviewApprovalManager) and guard the boundary so a truthy non-boolean
verdict is treated as a rejection, not an approval.
Co-authored-by: Mervin Praison <[email protected]>
The TypeScript counterpart to Task(human_input=True) (#4986). That PR shipped
the Python side and had to add two EXPIRING waivers because praisonai-ts had no
equivalent; this is what lets those waivers be deleted once both land.
new Task({ description: '...', humanInput: true,
humanReviewPrompt: 'Is this legally safe?' })
const outcome = await reviewTaskOutput(task, output);
if (!outcome.approved) { /* re-run with outcome.reason */ }
Reuses the existing approval manager rather than prompting directly, so it
works wherever approvals already do instead of hard-wiring a TTY read -- the
same decision the Python side made.
A missing approval manager RAISES rather than skipping the review. A task that
was supposed to be signed off and simply was not is the failure this prevents;
silently proceeding would be worse than not having the feature.
A task that did not ask for review returns { approved: true } untouched and the
manager is never called, so callers need no branch of their own -- there is a
control test asserting the manager receives nothing in that case.
An existing parity test caught this properly: parity-task.test.ts asserts every
TaskConfig option is exercised via Required<Omit<...>>, so adding two options
failed the suite until the fixture covered them. That guard is why the new
options cannot be added and then left untested.
9 new tests, two of them controls. Full suite 2470 passed, build and webview
gate exit 0, all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
- registerComputeProvider now mirrors into the placement registry, so a
custom provider registered by name (e2b, modal) is selectable via
new Agent({ toolsRunOn: '<name>' }) instead of throwing "not a known place".
- LocalCompute.execute switches from exec to a detached spawn and kills the
whole process group on timeout, so descendant processes do not outlive the
timeout (exec + detached did not reliably create a killable group).
- DockerCompute.shutdown checks docker rm -f's exit code and raises (marking
status 'error') on failure, instead of reporting a clean shutdown while the
container is still running.
Adds unit tests for each: descendant termination, provider->place mirroring,
and failed vs clean docker removal.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
`toolsRunOn` was already wired end to end -- resolvePlacement picks a place and
Agent.invokeTool routes tool calls through it -- but the registry that
registerToolPlace fills was EMPTY. The mechanism existed and nothing populated
it, so every `toolsRunOn` value silently fell back to running on the host.
new Agent({ instructions: '...', toolsRunOn: 'docker', tools: [...] })
ComputeToolPlace adapts a ComputeProvider (#5003) to the ToolPlaceLike
contract, and registering happens on import of praisonai/compute -- by the act
of having providers, rather than a caller remembering a setup step.
Four decisions:
- A tool without a declared `command` runs LOCALLY and says so. A JavaScript
closure cannot cross a process boundary, and pretending otherwise would imply
isolation that is not there.
- Every substituted argument is single-quoted. Verified: `{who: "a; echo pwned"}`
produces the literal text, not a second command.
- An unavailable provider RAISES rather than falling back to the host. Silently
running on the host what a caller asked to sandbox is the opposite of what
asking for a sandbox means -- a security property, not an inconvenience.
- A timeout raises rather than returning an empty string, which would read as a
successful tool call that found nothing.
Deliberately NOT claimed: AgentTeam.toolsRunOn stays in the behaviour ledger.
This honours the AGENT-level option; team-level placement needs one shared
instance across members and is not wired. I removed that ledger entry first,
an existing parity test failed, and it was right to -- the entry is restored
rather than the test adjusted.
8 new tests (24 in tests/unit/compute total), three of them controls. Full
suite 2485 passed, build and webview gate exit 0, all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
A flow's state was an untyped Dict[str, Any]. A typo --
ctx.variables["reserach_results"] -- was found at runtime, if at all, and
nothing told you what fields a workflow's state carried without reading every
step. CrewAI leads its production guide with typed flow state for this reason.
class ReviewState(BaseModel):
draft: str = ""
score: int = 0
flow = AgentFlow(steps=[...], state_model=ReviewState, variables={"draft": "hi"})
flow.state.draft # typed access
flow.validate_variables() # re-check after a step writes
Validation runs at CONSTRUCTION. A misspelled variable found when the flow is
built costs nothing; found mid-run it has already burned the steps before it,
and may never be found at all -- a variable written once and never read is
silent by nature.
Three decisions:
- An unknown key is an ERROR, not something to ignore. Silently accepting
"reserach_results" is exactly the typo this exists to catch, and the message
lists the declared fields so the fix is visible without opening the model.
- A dataclass works as well as a Pydantic model. Requiring Pydantic to run a
workflow would be a heavier dependency than the feature is worth.
- flow.state returns None when no model is declared, rather than an empty
object, so a caller can tell "untyped" from "typed and empty".
Entirely additive: without state_model, variables stay the untyped dict they
have always been, and a control test pins that.
13 tests, five of them controls. tests/unit/workflows: 219 passed vs 206 on
origin/main -- exactly the 13 new tests, no failures on either side. Collect
gate and all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
- Track physical file line via _iter_jsonl_numbered so blank/comment lines
no longer skew the file:line reported for a malformed case (auto-names
stay sequential case_N by position).
- Add load_cases/iter_jsonl/export_sft/sft_records/DatasetError to the eval
package __all__ so wildcard imports and __dir__ surface them.
- Correct the module docstring example: EvalReport comes from a runner's
run(package, agent), not suite.run(cases); document the .results contract.
- Add regression tests for physical-line numbering and public exports.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
EvalCase.from_dict existed but nothing read a FILE, so a task set had to be
assembled in Python. And praisonai-train sat in the repo with no connection to
eval: there was no way to take the runs that scored well and turn them into
supervised fine-tuning data, which is the obvious next step after measuring.
cases = load_cases("tasks.jsonl")
report = suite.run(cases)
export_sft(report, "train.jsonl", min_score=0.8)
JSONL rather than a new format: it is what Agno, OpenAI's fine-tuning API and
every dataset tool already speak, so a task set is portable in and the training
file is portable out.
Loading is forgiving where it costs nothing and strict where it matters:
- Common column aliases (prompt/question/query, answer/output/completion) are
accepted, because a task set exported from another tool is the normal case.
- Unrecognised columns are KEPT as metadata rather than dropped -- a dataset
usually carries provenance (source, difficulty, id) worth having in reports.
- A malformed line is reported by FILE:LINE. On a thousand-line dataset,
"invalid JSON" is not an actionable message.
- An empty file RAISES. An empty task set would otherwise report a perfect pass
rate over nothing.
Export refuses to lie in the same way:
- Only PASSING runs at or above min_score are written. Training on a run the
evaluation rejected teaches the model the behaviour the eval exists to catch.
- An export with nothing to write RAISES rather than producing an empty file,
which would look like a successful export.
15 tests, two of them controls: a weak pass DOES export when the bar is lower,
and blank/comment lines are skipped rather than failing the file.
No regressions: tests/unit/eval is 389 passed vs 374 on origin/main, exactly
the 15 new tests, zero failures either side. Collect gate and all three parity
gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
Address two valid P1 defects flagged in review of the compute providers:
- Docker timeouts now wrap the command in the container's own `timeout`
so the in-container process is killed at `timeoutSeconds`, not just the
host-side `docker exec` client. Exit 124 maps back to `timedOut: true`.
- A failed `docker rm -f` no longer reports success: the instance is
marked `error` and the failure raises, so a container reported stopped
cannot still be running. Successful removal drops it from the map.
Also refuse `execute` against a non-running container, mirroring
LocalCompute. Adds three unit tests (timeout mapping, cleanup failure,
in-container timeout wrapping) via a stubbed host seam — no daemon needed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
The sync tool-calling path (tool_execution.py) depends on
_run_async_in_sync_context, which lived only inside UnifiedExecutionMixin —
a module documented as fully unused and scheduled for removal (#2644).
Following that removal plan would delete a load-bearing helper and
reintroduce a silent-data-loss bug for async tool bodies.
Relocate the helper to the stable, already-imported async_safety module as
run_async_in_sync_context; tool_execution.py now imports it from there. The
mixin keeps a thin shim so its deprecated public methods still work, and the
inaccurate "no production usage" docstring/MRO comment are corrected. No
behaviour change.
Co-authored-by: Mervin Praison <[email protected]>
- Restore completed task results as TaskOutput, not bare str, so
process.py consumers reading result.raw (dependency context, routing)
no longer raise AttributeError on resume.
- Guard per-field JSON serialisability: a nested datetime/set/bytes in a
dict/list result or in task variables degrades to text/{} instead of
failing the whole durable write and losing the checkpoint.
- Fingerprint now covers agent name and expected_output and the full
(untruncated) description, so a materially changed task no longer keeps
the same fingerprint and get wrongly skipped on restore.
Adds tests for all three (fingerprint agent/expected_output/late
description, nested non-JSON durability, restored-result .raw type).
Co-authored-by: Mervin Praison <[email protected]>
- Propagate a speaker's stop_workflow signal out of _execute_discussion so
an on_error="stop" turn halts the whole workflow instead of burning the
round budget and continuing to later steps.
- Add a Discussion branch to _execute_single_step_internal so a nested
Discussion executes instead of being stringified into a Task action.
- Export Discussion in workflows __all__ for wildcard imports.
- Align the Discussion docstring with the implemented context (previous_result
per turn; full thread via discussion_transcript) and the rounds default.
- Add tests for speaker-stop propagation and nested Discussion.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
praisonai-ts had NO compute providers at all, so every tool ran in the host
process and `toolsRunOn` had nothing to select -- which is why it sits in the
behaviour ledger as unhonoured. Python has six (E2B, Modal, Daytona, Docker,
SSH, Novita) in a separate package. This ports the contract and the two
providers that need no SDK.
import { LocalCompute, DockerCompute, resolveComputeProvider } from 'praisonai';
- ComputeProvider: the contract Python's providers already share
(provision/execute/shutdown/listInstances/getStatus/isAvailable).
- LocalCompute: runs on the host. Honest about not sandboxing -- it exists so
the default works and the contract is exercised by something real.
- DockerCompute: real isolation via the docker CLI rather than an SDK, because
this package ships to a webview and one provider should not put weight on
every consumer.
- An open registry, so a remote provider can be added without touching callers.
Three decisions worth reviewing:
- child_process is loaded through a COMPUTED specifier. A static node builtin
on the browser graph fails the webview gate, and this package has made that
exact mistake twice. Verified: gate exits 0 with zero FAIL lines.
- A TIMEOUT is its own outcome (timedOut: true, exitCode: null), not a non-zero
exit. "We do not know the answer" and "the answer is no" are different, and
collapsing them makes a slow command look like a failing one.
- An unknown provider name RAISES and lists what exists. Falling back to local
would run on the HOST something the caller asked to sandbox -- here that is a
security property, not an inconvenience.
DockerCompute checks `docker info`, not `docker --version`: the CLI can be
installed while the daemon is down, and a provider that reports available and
then fails on provision is worse than one that says no.
NOT included, deliberately: E2B, Modal, Daytona, SSH and Novita each need their
own SDK and credentials, so they belong in follow-ups against this contract
rather than as stubs that would look implemented.
15 tests, three of them controls: a failing command reports a non-zero exit
rather than a timeout, an empty target means "no provider" rather than an
error, and an object without execute() is refused. Full suite 2476 passed,
build and webview gate exit 0, all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
save_session_state persisted only the shared _state dict -- no task status, no
task outputs -- so a team that died on task 9 of 12 restarted from task 1 and
re-paid for eight completed tasks. Step-level resume already existed, with a
definition fingerprint and everything, but only on the YAML workflow path,
which AgentTeam cannot reach.
The durable payload now carries per-task status, output, retry count and
variables, and restore_session_state re-applies them, so the process layer's
existing "skip anything already completed" logic sees finished work as finished.
_snapshot_task_state already existed for in-memory batch resets; this makes it
durable rather than inventing a second representation.
A TaskOutput object is reduced to its text before writing. A half-serialised
object that failed to write would lose the WHOLE checkpoint rather than one
field.
The guard that took the longest to get right: task keys are POSITIONAL
(0, 1, 2...), not ids. I only noticed because a fresh team restored 2 tasks
from another team's payload in a scratch run -- which looked like success and
was wrong. A checkpoint from a different task set would put task 3's output onto
a different task 3: a resume that looks fine and silently skips the wrong work.
The payload now carries a task-set fingerprint, and a mismatch restores the
shared state (safe, keyed by name) while REFUSING the task outputs, with a
warning saying so. That mirrors the definition_fingerprint the YAML path
already uses.
Unknown task ids are skipped rather than invented, so a partial mismatch cannot
half-restore.
9 tests, two of them controls: an unfinished task is not marked done, and an
unknown task id restores nothing.
No regressions: tests/unit/{agents,task} is 259 passed vs 250 on origin/main,
exactly the 9 new tests, zero failures either side. Collect gate and all three
parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
PraisonAI had no N-agent conversation loop at all -- no round-robin, no speaker
selection -- so having agents debate meant writing the loop by hand.
repeat([a, b]) was the obvious workaround and silently misbehaved (it
stringified the list into a prompt) until that was fixed separately, which is
what made this worth building rather than documenting around.
Discussion([critic, author], rounds=3,
until=lambda ctx: "AGREED" in (ctx.previous_result or ""))
Each speaker is handed the transcript so far, so this is a conversation rather
than N independent answers, and the transcript is exposed as a variable for
later steps.
Bounds are mandatory, not optional. `rounds` is required and must be >= 1: an
unbounded debate is a bill, not a feature. An empty speaker list is refused
because zero speakers would run zero turns and report success -- the flattering
kind of failure this codebase keeps producing.
A broken until() RAISES rather than being swallowed. Treating an exception as
"do not stop" would quietly turn a discussion that should have ended on turn
two into the full round budget, and the symptom would be a bill rather than an
error.
select= is consulted for every turn, so round-robin is the default rather than
an assumption baked into the loop; a test proves a custom selector can pick the
same speaker repeatedly.
10 tests, two of them controls: without until= the full budget runs, and the
refusals are on construction rather than mid-run.
No regressions: tests/unit/workflows is 216 passed vs 206 on origin/main,
exactly the 10 new tests, zero failures either side. Collect gate and all three
parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
Prompt caching existed; caching a STEP's output by input key did not, so a
deterministic step -- a formatter, a lookup, a summariser over unchanged text --
paid full price on every re-run. That is felt most while iterating on the steps
AFTER it, which is exactly when re-running is most frequent.
flow = AgentFlow(steps=[...], cache=True)
flow = AgentFlow(steps=[...], cache=InMemoryStepCache(max_entries=256))
OPT-IN on purpose. An agent step is not always deterministic -- temperature,
tools with side effects, a clock -- and silently serving a cached answer for a
call the user expected to happen again is the quiet wrongness this codebase has
repeatedly been bitten by. Nothing caches unless asked.
BOTH executors are wrapped. This SDK runs a linear step inline in _run_impl and
a patterned step through _execute_single_step_internal; caching only one would
make the feature work or not depending on whether a step happened to sit inside
a Parallel or an If -- worse than not having it. I found this by tracing the
actual call stack after two wrong guesses about which executor ran.
Two correctness points:
- Only a SUCCESSFUL step is cached. Caching a failure would serve it again on
every re-run, turning a transient error into a permanent one no retry clears.
- Variables are part of the key. Two runs with the same prompt but different
variables are different calls, and sharing an entry would serve one run's
answer to another.
A test caught a real collision while writing this: a bare STRING step keyed as
"str", so two different string steps shared an entry. Identity now uses the
string itself, and falls back to type+id() so two anonymous steps of the same
type do not collide either.
The cache is bounded (LRU, default 128). Unbounded would be a memory leak that
only shows up on a long-running flow in production.
19 tests, five of them controls. tests/unit/workflows: 225 passed vs 206 on
origin/main, exactly the 19 new tests, zero failures either side. Collect gate
and all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
Nine HookEvent members were declared with zero emission sites anywhere in
the monorepo. Registering a hook on one succeeded and then never fired --
silence on a plausible-looking registration.
The worst was the BEFORE_MESSAGE/AFTER_MESSAGE collision: the plugin-facing
method names before_message/after_message are live and route to
MESSAGE_RECEIVED/MESSAGE_SENDING (plugins/manager.py:876,890), while the
identically named enum members were dead.
Wired (real emission point):
ON_INIT / ON_SHUTDOWN -> PluginManager.register() / unregister()
SUBAGENT_STOP -> subagent completion chokepoint in subagent_tool
Aliased to the live event they duplicate (registration now lands on the
event that is actually emitted; legacy string values still resolve):
BEFORE_MESSAGE -> MESSAGE_RECEIVED
AFTER_MESSAGE -> MESSAGE_SENDING
TOOL_RESULT_PERSIST -> AFTER_TOOL
Removed (no emission point exists, so the mistake now fails loudly):
USER_PROMPT_SUBMIT, NOTIFICATION, SETUP
Adds a ratchet test so the enum cannot silently regrow a dead member.
Co-authored-by: Claude Opus 5 <[email protected]>
`_startup_folder()` used `os.path.expandvars(r"%APPDATA%\...")`. `%VAR%`
syntax is only expanded on Windows, so off Windows the string stayed literal
and the install path called `os.makedirs()` on it -- creating a directory
named `%APPDATA%\Microsoft\Windows\Start Menu\Programs\Startup` relative to
the current directory, i.e. inside the repository when tests run there.
That path is invalid on Windows. Once such a file is committed,
`actions/checkout` fails before any test runs:
error: invalid path 'src/praisonai-bot/%APPDATA%\Microsoft\Windows\
Start Menu\Programs\Startup/PraisonAIGateway.cmd'
The process 'git.exe' failed with exit code 128
That happened on PR #4994, where a `git add -A` swept the directory up.
Reproduced on clean main: `pytest tests/unit/cli/test_gateway_install.py
tests/unit/daemon/test_daemon_dispatch.py` exits 0 -- all green -- and leaves
the directory behind. The vector is
test_windows_scheduled_task_command_is_well_formed, which mocks
subprocess.run and drives the real write path on a non-Windows host.
Changes:
- `_startup_folder()` reads APPDATA from the environment directly, so the
path resolves on any platform when it is set. The expandvars form is kept
as the fallback, so Windows behaviour with APPDATA set is unchanged.
- Both write sites refuse when the path still contains an unexpanded `%`.
The scheduled-task path needed its own guard because it writes the wrapper
script *before* calling schtasks, so it polluted the tree and only then
failed.
- uninstall() reports the location as unresolved instead of guessing.
- The offending test points APPDATA at tmp_path, keeping its actual intent
(command formatting) while writing nowhere near the repo.
Tests: tests/unit/daemon/test_windows_autostart_offplatform.py
- the helper must refuse rather than create the directory
- the full install() path must leave no unexpanded-variable directories
- a control probe asserting the detector matches a known-bad name, without
which both scans could pass vacuously
Verification: 2 failed before / 3 passed after, by process exit code. Three
mutations -- dropping either guard, and ignoring the APPDATA env var -- all
killed, each guarded by an `assert target in source` so it could not silently
no-op, with the anchor green before and after.
Failure-neutral: full praisonai-bot tests/unit is 4 failed / 2207 passed on
pristine main and 4 failed / 2210 passed here (+3 new), failure-set diff
empty in both directions. After the full suite the tree is clean.
Co-authored-by: Claude Opus 5 <[email protected]>
``HookEvent.SCHEDULE_ADD`` and ``HookEvent.SCHEDULE_REMOVE`` were declared
in praisonaiagents/hooks/types.py but never emitted by any production code
path, so a plugin registering on them stayed silent forever. The strings
"schedule_add"/"schedule_remove" do occur in production, but only as agent
*tool names* (TOOL_MAPPINGS, tool profiles, tool_search, bot defaults) —
name collisions, not emissions.
Emit from the schedule store, the one point every author/deleter path
funnels through:
* the agent-callable schedule_add / schedule_remove tools
* `praisonai schedule add` (delegates to the tool) and
`praisonai schedule remove` / `delete` (call store.remove(job_id))
* the gateway config reconciler (add + _prune_removed_config_jobs)
* the automatic cleanup of a spent `delete_after_run` one-shot, which is
deleted inside claim_due() and never passes through remove()
Emission is best-effort and observability-only: it happens after the store
locks are released (so a hook cannot deadlock the cross-process file lock),
it is skipped entirely when no hook is registered, it is loop-aware
(execute_sync raises inside a running event loop), and a raising hook can
never break or roll back the mutation. Nothing is emitted for a rejected
add, a no-op remove, a cross-tenant remove that matched nothing, or a
one-shot deletion whose persist failed and was rolled back.
Adds ScheduleAddInput / ScheduleRemoveInput payload types and a
test suite that fails on the pre-change code (10 of 18 red).
Co-authored-by: Claude Opus 5 <[email protected]>
* fix(hooks): the 7 declared-but-never-emitted lifecycle events now fire
HookEvent declared JOB_COMPLETED and the six KANBAN_TASK_* members, but
nothing in production ever emitted them: a plugin that registered a hook on
KANBAN_TASK_CREATED waited forever.
Two independent causes:
1. The kanban dispatcher DID have emission sites, but every one of them ran
`from praisonaiagents.hooks import fire_hook` — a symbol that has never
existed. The ImportError was caught and logged at debug, so all six kanban
events died silently. Two of the sites also named enum members that do not
exist at all (KANBAN_TASK_COMPLETED, KANBAN_TASK_RECLAIMED), and the rest
passed the member NAME where subscribers listen on the canonical value.
2. JOB_COMPLETED was emitted only by BotOS.on_background_job_complete, which
is never registered anywhere: `on_job_complete` is passed by tests only,
and even then only when a job carries a `deliver` target.
Fixes:
* Add `praisonaiagents.hooks.fire_hook()` — the emission counterpart to
add_hook(). Resolves an event from the enum, its value or its member name,
builds the right HookInput subclass, and works from inside a running event
loop (execute_sync refuses to). Best-effort: unknown ids, bad payloads and
raising subscribers are swallowed.
* Emit the six kanban events from SQLiteKanbanStore, after commit — it is the
chokepoint the CLI, agent tools, dispatcher, HTTP API and UI all write
through, so every writer is covered by one emission each:
create_task -> KANBAN_TASK_CREATED (not on idempotent replay)
claim_task -> KANBAN_TASK_CLAIMED (only when the CAS is won)
move_task -> KANBAN_TASK_MOVED, plus DONE / BLOCKED by destination
record_failure -> KANBAN_TASK_FAILED, plus BLOCKED on circuit-break
reclaim_stale_claims -> KANBAN_TASK_MOVED (running -> ready)
* Emit JOB_COMPLETED from BackgroundJobManager when a job reaches COMPLETED or
FAILED, so every background job is observable rather than only delivering ones.
* Drop the dispatcher's four now-duplicate emission sites (the store owns
those transitions); keep its dependency-promotion MOVED, which bypasses
move_task and so has no store-side counterpart.
* Collect src/praisonai-bot/tests/unit/kanban/ in CI — it was in no shard,
which is how six eventless events shipped.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix: remove stray %APPDATA% artifact that broke Windows checkout
Running the bot daemon tests on macOS/Linux creates a literal
`%APPDATA%\Microsoft\Windows\Start Menu\Programs\Startup/` directory in the
repo: `_startup_folder()` uses `os.path.expandvars(r"%APPDATA%\...")`, which
does not expand `%VAR%` syntax off Windows, and
`_create_startup_folder_entry` then calls `os.makedirs()` on the literal
string. A `git add -A` afterwards commits it.
The resulting path is invalid on Windows, so `actions/checkout` fails outright
before any test runs:
error: invalid path 'src/praisonai-bot/%APPDATA%\Microsoft\Windows\
Start Menu\Programs\Startup/PraisonAIGateway.cmd'
The process 'git.exe' failed with exit code 128
This removes the file so this branch checks out on Windows. The root cause —
tests writing that directory into the working tree — is pre-existing on main
and fixed separately.
Co-Authored-By: Claude Opus 5 <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
`Knowledge.reset()` deliberately no-ops when the configured memory backend
has no `reset()`: it logs a warning and returns. The MCP tool
`praisonai.knowledge.clear` called it and then returned the fixed string
"Knowledge cleared" regardless, so a user who asked to clear a knowledge base
was told a destructive operation had succeeded when it had never run.
Reproduced against the real Knowledge.reset implementation with a backend
that has no reset():
WARNING _BackendWithoutReset does not support reset(); no-op
tool returned: 'Knowledge cleared'
After:
'Error: knowledge was NOT cleared - the configured backend
(ChromaKnowledgeAdapter) does not support reset()'
Changes:
- Knowledge.reset() now returns True when the backend actually reset and
False when the call was a no-op. Returning a value is backward
compatible: existing callers that ignore it are unaffected.
- knowledge_clear() reports honestly and names the backend that refused.
This matters more than a wording nit: the false confirmation is on a
destructive path, so a user could believe sensitive material was erased
when it is still stored.
Tests: src/praisonai-mcp/tests/mcp_server/test_knowledge_clear_honesty.py
- the no-op backend must not be reported as cleared
- control: a backend that really resets must still be confirmed, and the
control asserts the backend was actually reset so it cannot pass vacuously
Verification: 1 failed before / 2 passed after, judged by process exit code.
Two mutations, each guarded by an `assert target in source` so it could not
silently no-op: reset() always returning True, and the tool ignoring the
return value. Both killed.
Failure-neutral: praisonai-mcp 216 passed baseline -> 218 with these tests,
both exit 0. praisonai-agents knowledge/memory selection is byte-identical
against pristine origin/main (13 pre-existing failures, same set, 704 passed).
Co-authored-by: Claude Opus 5 <[email protected]>
Both MCP CLIs define a `_print_rich` helper that renders Rich markup when
Rich is installed and strips the tags when it is not. 30 call sites bypassed
it and used the builtin `print()` with markup in the string, so the user saw
the raw tags. The files were already inconsistent: cli.py routed three sites
through the helper (374, 514, 566) and fifteen others through bare print.
Reproduced on origin/main by running the real command:
$ praisonai mcp list-recipes
[bold]Available Recipes (3):[/bold]
• my-joke-template (v1.0.0)
After:
Available Recipes (3):
• my-joke-template (v1.0.0)
All 30 sites were single-argument calls inside CLI methods, so each becomes
`self._print_rich(...)` with no other change.
Tests: tests/unit/test_cli_rich_markup.py
- runtime assertion on real `cmd_list_recipes` output
- static guard so a bare markup print cannot be reintroduced
- a control probe proving the detector fires on a known-bad line
(without it, the static scan would pass vacuously)
Verification: 3 failed before / 4 passed after, judged by process exit code.
Mutation (restore one bare print) killed by both the static and runtime
tests, with an `assert old in s` guard so the mutation could not silently
no-op. Package suite is failure-neutral: the same 6 tests fail on pristine
origin/main (auth/adapter, unrelated), 210 passed baseline vs 214 with these.
Co-authored-by: Claude Opus 5 <[email protected]>
Three tests went red on main today, from two of this afternoon's merges.
praisonai --help emits U+1F99E and raises UnicodeEncodeError on a cp1252
console (Windows). #2699 removed emoji from praisonai-code's help strings for
exactly this reason, and the guard tests for it are still there -- but the
`claw` entry is lazily loaded from praisonai_bot, whose own
typer.Typer(help="...") overrides the clean text registered in
praisonai_code/cli/app.py. So the emoji comes back for anyone who has
praisonai-bot installed, which is why CI (without it) stayed green while the
tests fail locally.
Only the Typer help string is changed; the command's runtime output keeps its
emoji, because that is not what --help has to survive.
Separately, test_code_print_json pinned tool_groups as
["acp", "edit", "search", "lsp"]. #4965 added "mcp", so the headless `code -p`
path now passes five. Updated, and deliberately kept as an exact list rather
than loosened to a subset, so a group silently appearing or disappearing from
that path still fails here.
Co-Authored-By: Claude Opus 5 <[email protected]>
jira -- six tests failed with ModuleNotFoundError: No module named 'jira'
(four from @patch('jira.JIRA'), which cannot patch a module that is not
importable) and the tools' own "JIRA library not installed" ImportError.
``jira`` is an optional extra; a missing optional dependency is not a defect,
and reporting it as one is how a suite stops being read. Skipped via
importorskip, the convention already used elsewhere in this directory.
test_context_compaction_policy -- nine patches named
praisonaiagents.context.adapters.{get_model_limit, ContextBudgeter,
estimate_messages_tokens}. adapters.py imports all three inside the function
from .budgeter and .tokens, so none exists at module level and the patches
raised AttributeError before the test bodies ran. Retargeted to the defining
modules.
That is the fourth place in this sweep where a test patched a name imported
inside the function under test: praisonai_code's train_package_available,
runtime's resolve_runtime and resolve.LLM, and now these. The pattern is worth
recognising -- the decorator fails at setup, so the test reports an
AttributeError about the patch rather than anything about the code.
One of those then failed on its own arithmetic. Utilization is
current_tokens / budgeter.usable, but the test mocked 7000 tokens against
usable=7200 and described it as "87.5% utilization" -- 7000/8000, the model
limit. The real ratio was 97%, over the 0.92 gpt-4 override, so the route was
compact_then_truncate. Now 6480/7200 = 90%: above the 0.85 default and below
the 0.92 override, which is the case the test exists to cover.
Root-level tests/unit: 43 failed (was 49); test_context_compaction_policy 10
passed, test_jira_tools skipped rather than failed.
Co-Authored-By: Claude Opus 5 <[email protected]>
None was a code defect. Each test consulted something outside its control, or
encoded a contract the code had deliberately replaced.
hooks -- the test shelled out to a bare "python". Modern macOS (and plenty of
Linux images) ship only python3, so the hook failed with "[Errno 2] No such
file or directory: 'python'" and the assertion looked for 'boom-detail' in a
prompt that carried the Errno instead. The diagnostics plumbing under test was
working the whole time -- it faithfully carried the wrong error. Uses
sys.executable now. The sibling parsing test keeps its literal "python",
because it never executes the command.
memory -- test_mongodb_warns_and_falls_back reached a real
mongodb://localhost:27017/ and waited out the driver's ~20s server-selection
timeout before falling back: a unit test making a network connection, and 20
seconds to assert an offline code path. The backend constructor is now stubbed
to fail, exercising the same fallback in milliseconds and deterministically on
a machine that happens to be running MongoDB. Also asserts the warning, which
is the half that keeps the fallback from being silent. 20.45s -> 0.25s.
plugins -- test_skills_discovery_uses_paths_module asserted every discovered
directory is named "skills". Remote-skill caching later added entries like
~/.praisonai/cache/remote-skills/<hash>/current, and because the test ran
against the real home it was checking whatever the developer had cached: 84
such directories here, none of them named "skills". HOME is redirected and the
paths cache cleared, and the original intent -- discovery derives its location
from the paths module rather than hardcoding one -- is asserted directly.
skills -- two tests asserted a typo'd or empty self_improve value silently
resolves to disabled. 351e30c093 (#4116) made closed-set preset params raise
instead, which serves the same concern better: "backround" now says so and
names 'background', rather than leaving the user wondering why self-improvement
never ran. Updated to the new contract, including that the near-miss
suggestion is present.
streaming -- a test's fake _check_tool_policy_and_guardrails took three
positional arguments; the real one gained a `tools` parameter, so the async
path raised "takes 3 positional arguments but 4 were given" and the result came
back as an error dict instead of 'ok'. Signature aligned.
Suites: hooks 110, memory 52, plugins 168, skills 297, streaming 82 -- all
passing, all previously red.
Co-Authored-By: Claude Opus 5 <[email protected]>
Two production defects behind twelve reds in tests/unit/runtime.
1. The unknown-runtime message raised ImportError instead.
resolve_runtime_instance catches the registry's ValueError and re-raises it
with the available runtimes appended. It imported list_available_runtimes,
which the registry does not define -- it exports list_runtimes(), returning
ids. So the branch raised
ImportError: cannot import name 'list_available_runtimes' from
'praisonaiagents.runtime.registry'
at the one moment its message is worth having: the user has just mistyped a
runtime id. Fixed to the real function, with the listing wrapped so a failure
there degrades to the original ValueError rather than an error about error
handling.
Nothing caught it: the existing tests patch both resolve_runtime and the
listing, so the real import never ran. A new module drives the unmocked path
and asserts the enhanced wording specifically -- checking only for a runtime
id would still pass with the listing broken, because the registry's own error
mentions them too.
2. An empty turn returned success.
PraisonAIRuntime.run_turn reported an error for an empty result only when
OPENAI_API_KEY was unset. Every other cause -- a model the key cannot access,
quota, a provider error swallowed upstream -- returned content="" with
error=None, so a caller could not tell "the model answered nothing" from "the
call never happened". An empty result now always carries an error, keeping the
specific API-key message where that is the cause. test_builtin.py already
asserted this contract ("Runtime should handle missing API keys gracefully")
and had been red.
Ten stale tests alongside them:
- Four patched names that are imported inside the functions under test
(resolver.resolve_runtime, resolver.list_available_runtimes, resolve.LLM), so
the decorators raised AttributeError before the bodies ran. Retargeted to the
defining modules.
- Three used a bare Mock() where the code branches on hasattr. Mock answers
hasattr for every name, so `provider` returned a Mock instead of the
model-name inference under test, and the "no achat method" fallback awaited a
plain Mock. Given explicit spec= lists.
- Two built an invalid AgentRuntimeConfig to hand to the validator, but
__post_init__ validates the same thing, so the setup line raised the very
error being asserted. They now assert at construction, with new tests keeping
the validator covered for a config mutated afterwards.
- One asserted resolution_source == "legacy"; resolver.py makes the built-in
default outrank legacy ("lowest priority"), so it is "default" unless no
default exists. Both halves of that rule are now covered, plus the surprising
consequence for an already-constructed legacy instance -- pinned, not
endorsed, since it is a deprecated parameter.
- MockRuntime claimed protocol compliance while missing seven members the
protocol had gained. Completed, and the assertion now names what is missing
rather than failing as "assert False".
Suite: tests/unit/runtime 138 passed, 1 skipped (was 12 failed).
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(core): make four accepted-and-ignored config knobs real
Four settings were accepted by the API and then did nothing. Each is
reproduced by a test that fails before the fix.
1. Agent(hooks=HooksConfig(...)) — on_step was assigned to
self.step_callback and never called; on_tool_call was never read at all,
while the TypeError for an unknown key advertised both as valid. Both are
now routed onto the middleware chain that already powers hooks=[...]:
on_step -> after_model, on_tool_call -> before_tool.
2. ExecutionConfig(code_execution=True) set allow_code_execution and produced
no tool, so the agent gained no capability, and code_mode was a
security-shaped label with nothing behind it. The flag now attaches the
existing execute_code tool (registered "critical" in the approval registry,
so it stays gated under every preset but "full"), and code_mode decides what
it does: "safe" = subprocess isolation with no tool access, "unsafe" =
in-process with the code_tools_allow list injected as tool proxies. An
unknown code_mode raises; code_tools without unsafe mode warns.
Wiring this made a latent double-execution bug reachable: both code
executors exec'd the whole module and then re-eval'd a trailing expression
statement, so `print(x)` printed twice and a trailing tool call ran the tool
twice. The trailing expression is now split off before exec and evaluated
once.
3. AgentTeam(execution=ExecutionConfig(...)) — the single-agent config is the
one exported at the top level, and passing it resolved against
MultiAgentExecutionConfig and dropped everything, including the max_iter
both classes define, with no error and no warning. Shared fields are now
carried over and a UserWarning names the right class and the settings that
have no team-level counterpart.
4. praisonaiagents.context.get_global_store() is an in-memory process-local
singleton that nothing in the runtime populates, so `praisonai context
compact` read an always-empty store and printed "Compaction complete."
Wiring it cannot fix that (the CLI is a different process), so the store is
documented for what it is and the CLI now says nothing was done instead of
reporting success.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(core): address reviewer findings on accepted-and-ignored config
- Team retries: only carry ExecutionConfig shared fields when the caller
changed them, so AgentTeam(execution=ExecutionConfig(max_iter=99)) keeps the
team's own max_retries default (5) instead of silently dropping to 2 (P1).
- Unsafe code mode: scope code_tools_allow resolution to an agent-built
registry so code cannot reach globally-registered tools the agent was never
granted; fix tool_proxy falling back to the global registry when an explicit
but empty (falsy) ToolRegistry was passed (P1 security).
- Hook callbacks: await coroutines returned by async on_step/on_tool_call
callbacks instead of dropping them silently (P2).
- Safe-mode execute_code tool now binds the configured timeout; unsafe mode's
in-process timeout limitation is documented.
- Context CLI: export/compact honour shared-context-only stores and report
honestly; store lifecycle docstring clarified (not *automatically* persisted).
- Tests: self-cleaning approval backend/context via autouse fixture; add
regressions for team retries, agent tool-scope enforcement, async callbacks,
and shared-context-only export/compact.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
IndexResult.success defaults to True and Knowledge.index() never assigned it.
Each per-file failure was appended to result.errors and then contradicted by
the one flag a caller actually branches on:
IndexResult(success=True, files_indexed=0, chunks_created=0,
errors=['/tmp/.../test.txt: Failed to generate embedding ...'])
So `if result.success:` went on believing the corpus was indexed while nothing
had been stored. success is now `not result.errors`. A partial failure counts:
a knowledge base quietly missing one document out of ten is exactly the loss
this result object exists to surface, and the caller still has `errors` and
`total_files` for the detail.
Three mocked tests pin it -- total failure, partial failure, and the guard that
it does not become a blanket False. Mocked rather than marked live, so the
contract is checked in CI rather than skipped.
Two more causes behind the twelve reds in this directory:
- test_adapters.py and test_embedding_failure.py build ChromaKnowledgeAdapter
through __new__ to avoid a real chromadb client, then set only `collection`.
`_embedder` was added to __init__ later (so an agent that had selected a local
embedder stopped being silently routed to OpenAI) and these five began failing
with AttributeError before reaching the assertions they exist for. The
bypassing helpers now supply it, with a note saying why.
- TestKnowledgeIndex, TestDirectoryIngestion and TestContextBuilderUsesText
embed every chunk through the configured provider -- a real network call --
and carried no marker, so `pytest tests/unit` issued live embedding requests
and failed on any key without access to the default model. Marked with the
repo's existing `live` gate, per class rather than per file so the pure
dataclass and ignore-matcher tests keep running (11 skipped, not 30).
Suite: tests/unit/knowledge 121 passed, 11 skipped (was 12 failed).
Co-Authored-By: Claude Opus 5 <[email protected]>
ToolConfig's own docstring shows the intended usage:
Agent(tool_config=ToolConfig(timeout=60, retry_policy=RetryPolicy(...)))
That line could not be written. ToolConfig is defined in feature_configs and
was never listed in praisonaiagents.config.__all__, while its siblings
(ExecutionConfig, OutputConfig, MemoryConfig, ...) are. Six more were in the
same position, every one of them backing a public parameter:
Agent(tool_config=) ToolConfig PraisonAIAgents(execution=) MultiAgentExecutionConfig
Agent(autonomy=) AutonomyConfig PraisonAIAgents(hooks=) MultiAgentHooksConfig
Agent(learn=) LearnConfig PraisonAIAgents(memory=) MultiAgentMemoryConfig
PraisonAIAgents(output=) MultiAgentOutputConfig
All seven are now exported through the same lazy map the others use.
A new test pins the rule rather than the list -- for each public parameter, the
config class it accepts must be importable -- so a config added for a new
parameter cannot be left behind. It also walks __all__ and resolves every name,
because the lazy loader means a typo there surfaces only on first access.
Also, in the two tool-retry test modules:
- They passed a top-level tool_retry_policy= to Agent, which the consolidated
constructor rejects; retry moved onto tool_config. Updated to the current API,
which is what surfaced the missing export.
- Agent's unknown-kwarg error names the replacement for `verbose` and `stream`
but said nothing for the tool ones, so a user got a bare "unexpected keyword
argument" with no hint that it had moved. tool_retry_policy and tool_timeout
now carry the same migration hint.
- TestRetryPolicyAgentic makes real LLM calls (AGENTS.md 9.4) but sat in
tests/unit with no gate, so running the unit suite issued live API calls and
failed outright without a key. Gated with the same condition
test_circuit_breaker.py already uses.
Suite: tests/unit/config 333 passed; the live-LLM module now reports 4 skipped
instead of 4 failed when no key is present.
Co-Authored-By: Claude Opus 5 <[email protected]>
- Validate parsed hostname as a real .blob.core.windows.net authority and bind
the Azure request to the account named in the URL (no A-URL served from B).
- Stream Azure blobs with readinto() instead of readall() to avoid buffering
the whole payload in memory.
- Percent-decode object keys so escaped names (e.g. spaces) resolve.
- Persist the original cloud URI in stored chunk metadata (not the temp path).
- Download into a TemporaryDirectory so fetched files are removed after indexing.
Co-authored-by: Mervin Praison <[email protected]>
Config flowed one way. workflows/yaml_parser.py builds agents FROM YAML and
nothing exported them back, so you could not build a team in Python and hand it
to the visual builder, diff two team configs, or put into review what a
programmatically-assembled team actually became. This is the missing half of a
pipeline that already existed.
blob = agent_to_dict(agent) # JSON-safe
same = agent_from_dict(blob, tool_registry={"search": search})
The field set is derived from the CONSTRUCTOR SIGNATURE, not hardcoded. The
first draft used a fixed list and exported attributes that still exist on the
instance but have moved into output= (verbose, stream, markdown, self_reflect
...), producing a config that raised TypeError on import -- an export that
cannot be imported is worse than none. Intersecting with the live signature
means the exporter cannot drift from the constructor again.
Refusals, each because the silent version loses something quietly:
- Tools are exported by NAME (a callable cannot survive JSON), and importing a
config with tools but no tool_registry RAISES. Rebuilding tool-less would
produce an agent that looks like it chose not to act.
- A registry missing a tool names the missing one rather than dropping it.
- tools_resolvable records whether every tool survived as a name, so a caller
is told rather than left to discover it.
- A config from another version is refused.
Runtime state -- clients, caches, sessions, memory -- is deliberately not
exported; a test asserts none of it leaks into the config.
Shipped as module functions rather than Agent.to_dict/from_dict on purpose. The
methods were written first, and the signatures gate correctly flagged them as a
new Python/TypeScript method divergence needing the baseline grown. Growing a
parity baseline for two convenience aliases is a poor trade when
agent_to_dict(agent) is equally usable, so the methods were removed and parity
stays flat.
11 tests, two of them controls. tests/unit/agent: 450 passed vs 439 on
origin/main with the SAME 3 pre-existing failures. Collect gate and all three
parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
- openai_client.format_tools now forwards allowlisted hosted tools (default
Agent path previously dropped them, so Agent(tools=[WebSearchTool(), ...])
silently lost them)
- llm._get_tools_cache_key serializes the full hosted spec so file_search over
vs_1 vs vs_2 (and differing MCP urls) no longer collide on hosted:<type>
- is_hosted_tool validates per-type required fields (mcp needs server_url) so a
malformed allowlisted dict is dropped, not forwarded upstream
- tools/__init__ __all__ exports the hosted symbols for `import *`
- tests for the default-Agent path, config-distinct cache keys, and malformed mcp
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
Eleven: a path hack pointing at a directory that no longer exists.
ModuleNotFoundError: No module named '_session'
_make_manager walked five directory levels up to praisonai/praisonai/bots and
pushed it onto sys.path to import a bare `_session`. The bots code has since
moved to the praisonai-bot package and that directory is gone, so every test
in TestBotSessionManagerWithStore failed on import. They now import
praisonai_bot.bots._session as a package, via importorskip so a checkout
without the optional package reports "not installed" rather than an import
error that reads like a broken test. A second copy of the same hack inside
test_backward_compat_no_store is removed too.
One: a cache test asserting a contract that was deliberately removed.
test_cache_performance_with_unchanged_files asserted `session2 is session1` --
that a second get_extended_session returns the same cached object. #1781 and
#1785 made the getter always reload, and not as tidying: the stale extended
cache could WIPE SESSION MESSAGES, and went stale on cross-instance writes.
Restoring the cached object to make the test pass would reintroduce exactly
that data loss.
So identity is not the contract. The test now asserts what must hold -- a
second read sees the same data, and the fresh read leaves the cache and its
mtime coherent rather than stale -- and a new test covers the case that
motivated #1785: a write from another store instance on the same directory
must be visible, which a cached object would hide.
Suite: tests/unit/session 413 passed (was 12 failed), and 11 skipped rather
than failed when praisonai-bot is absent.
Co-Authored-By: Claude Opus 5 <[email protected]>
Repeat.step is typed Any and was handed straight to the single-step executor,
so repeat([a, b]) was ACCEPTED and then stringified into a prompt -- the list
became text and the default agent answered it. Nothing raised; the flow just
did something else.
That mattered more than an ordinary type bug because there is no N-agent
discussion loop in this SDK, so repeat([agent_a, agent_b]) is exactly the
workaround people reach for. Silently misbehaving is worse than rejecting.
A list now runs its members in order, once per iteration, and each member sees
the previous member's output -- so a two-step repeat composes the way a
two-step flow does.
repeat([step_a, step_b], max_iterations=2) # a, b, a, b
6 tests, three of them controls: a single step still works, max_iterations
still bounds a list, and until= still stops one early. Mutation-checked --
removing the list handling fails 5 of the 6.
No regressions: tests/unit/workflows is 212 passed vs 206 on origin/main,
exactly the 6 new tests, zero failures on either side. Collect gate and all
three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
AgentOS could list agents and take a chat turn, and nothing else. A session
could not be replayed, a run inspected, or a pending approval seen over HTTP --
even though the protocols to expose all three already existed
(runs/sqlite_ledger.py, session/, approval/registry.py). Four routes became
nine.
GET /api/runs?limit=50 GET /api/runs/{run_id}
GET /api/sessions?limit=20 GET /api/sessions/{session_id}
GET /api/approvals
READ-only on purpose: mutating a run over HTTP is a much larger design question
than surfacing one, and the audit that found this gap recommended taking the
slice rather than building the whole control plane.
The decision worth reviewing: a missing store returns 503 NAMING WHAT TO
CONFIGURE, not an empty list. An empty list is indistinguishable from "no runs
yet", so an operator debugging a missing run would see a healthy-looking empty
response and conclude the run never happened -- the exact silent-failure shape
this effort keeps finding. An unknown run or session is 404 rather than an
empty object, for the same reason.
_run_to_dict serialises via the record's own as_dict/__dict__ instead of a
hardcoded field list, so a ledger carrying extra fields is not silently
truncated on the way out.
10 tests, two of them controls: the pre-existing /health and /api/agents routes
still answer 200, and limit= is honoured rather than ignored. Verified against
a real FastAPI TestClient.
Not regressions: src/praisonai/tests/unit collects 5742 tests with 6 errors, all
in unrelated modules (cli, code, compute, scheduler, langflow) and all present
before this change. The suite also exits non-zero on an interpreter-shutdown
logging crash in Agent.__del__ that predates this branch.
Co-Authored-By: Claude Opus 5 <[email protected]>
- Own add_user_message/add_assistant_message so the normal agent path
encrypts instead of forwarding to the inner store and writing plaintext
- Decrypt get_session and get_working_history, not just get_chat_history
- Accept and encrypt tool_calls; forward tool_call_id; only pass these
kwargs when present so leaner stores keep working
- Recognise the metadata envelope only by its exact one-key + PREFIX shape,
so legacy metadata containing an "__enc__" key is no longer corrupted
- Export EncryptedSessionStore/SessionEncryptionError/generate_session_key
- Tests for runtime helpers, tool_calls round-trip, get_session decryption,
and legacy __enc__ metadata
Co-authored-by: Mervin Praison <[email protected]>
Durable execution is real and thorough -- agent/durable.py replays a run from
its journal -- but the journal is a local SQLite file, so a run could only
resume where it started. Pausing on a web worker, putting the state in a queue
and resuming it somewhere that shares no disk was not possible.
blob = export_run_json(journal, run_id)
redis.set(key, blob)
# elsewhere, no shared disk:
run_id = import_run_json(other_journal, blob)
Verified across two separate journal files: metadata, every event and its
payload arrive, and replay_index() is rebuilt on the far side -- which is the
point, since that index is what durable replay reads.
Deliberately a JOURNAL export rather than a new state format. The journal is
already the single source of truth DurableRunContext replays from; a second
representation would be a second thing to keep correct, and the two would drift.
Refusals are explicit, because each silent alternative fails much later and
looks like something else:
- Exporting a run that does not exist raises. An empty blob would import as an
empty run and replay nothing, which reads as "the run did no work".
- Importing over an existing run raises unless overwrite=True. Merging two
runs' events yields a replay index belonging to neither, surfacing later as
a confusing resume rather than an import error.
- A blob from another version is refused by version, not half-imported.
- Malformed JSON and a missing run_id are each reported as themselves.
run_id= imports the same blob under a new id, so a run can be forked
deliberately rather than by accident.
11 tests, three of them controls: a new id lets the same blob import twice,
overwrite=True is allowed when asked for, and the JSON form round-trips.
No regressions: tests/unit/runtime is 131 passed vs 120 on origin/main with the
SAME 12 pre-existing failures. Collect gate and all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
Knowledge could only read local disk. detect_source_kind() already classified
s3:// and gs:// as URLs, but nothing fetched them -- so a bucket path was handed
to an HTTP fetcher that cannot speak those schemes, and anyone with documents in
a bucket had to download them by hand first.
Knowledge(sources=["s3://my-bucket/handbook.pdf"])
A cloud URI is resolved to a local temp file and then read by the SAME readers
as any local file, so PDF/DOCX parsing is not reimplemented per provider. The
downloaded file keeps the object's extension, because the readers dispatch on
it -- an extension-less temp file would make a PDF be read as plain text.
The cloud branch is checked BEFORE the http/https branch on purpose: an Azure
blob URL is https, and would otherwise be handed to the web fetcher.
Every SDK is optional and imported only when a URI of that scheme is used, so
installing PraisonAI does not pull three cloud SDKs. A missing one raises with
the exact pip command rather than failing later inside the provider.
Failure modes are explicit rather than silent, which is the recurring defect
this effort keeps finding:
- A provider error (AccessDenied, missing object) is reported, not swallowed
into an empty document.
- An SDK that reports success but writes no file is caught and reported --
otherwise the knowledge base would look populated and be empty.
- A URI naming a bucket but no object is refused.
- The ORIGINAL uri is kept in the result metadata; a temp path is meaningless
in a citation.
18 tests, six of them controls -- an ordinary https URL is NOT claimed by the
cloud branch, a local path is not, and an unsupported scheme is refused by name.
The SDKs are faked in-process, so nothing touches a network.
No regressions: tests/unit/knowledge is 134 passed vs 116 on origin/main with
the SAME 12 pre-existing failures. Collect gate and all three parity gates
exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(code): stop reporting success for shell syntax that never ran
execute_command used shlex.split + Popen(shell=False), so any shell
operator became a literal argument and the call still returned exit 0 /
success True. Measured on origin/main:
'echo written > redir.txt' -> exit=0 success=True
stdout='written > redir.txt' FILE NOT CREATED
'cd .. && pwd' -> exit=0 success=True stdout=''
'echo a | wc -l' -> exit=0 success=True stdout='a | wc -l'
A false success is worse than an error: the model has nothing to correct
on. shell=False is a legitimate prompt-injection defence and is NOT
removed here.
New praisonai_code/cli/features/shell_exec.py:
- quote-aware find_shell_syntax(): 'echo "a > b"' has no redirect
- PRAISON_SHELL=off (default): refuse, naming the operator and the
alternatives, instead of running a mutilated command
- PRAISON_SHELL=sandboxed: a real /bin/sh -c inside OS containment
- PRAISON_SHELL=unsafe: a real shell, opt-in, never a fallback
New praisonai_code/cli/features/os_sandbox.py wires the OS-native
containment the repo advertised but never reached from praisonai-code.
SandboxConfig.native()'s docstring promises "macOS: Seatbelt", but
SandboxManager maps native -> sandlock, which is Linux-only and needs an
optional wheel; on macOS it raises ImportError, so there was no
containment at all. This module drives sandbox-exec (Seatbelt) directly
on macOS and bwrap on Linux.
Crucially it never claims containment it has not observed:
probe_enforcement() runs a child under the wrapper and tries to write
outside the writable set, reporting the backend unavailable if that
write succeeds. sandboxed mode refuses to run rather than degrade to an
uncontained shell -- a sandbox that is assumed but not enforcing is
worse than none.
Approval is not weakened: the real-shell path is wrapped in
require_approval(risk_level="critical") under the tool name
"execute_command", the same identity and risk level as the executor it
stands beside.
Also fixed on the ACP path, which had the opposite failure -- a
substring blocklist that rejected build-test-fix one-liners outright and
also false-rejected 'git commit -m "fix: a > b"' because ">" appeared
inside a quoted argument. Both paths now share one quote-aware scanner,
and ActionOrchestrator's step executor refuses a redirect it cannot
perform instead of returning returncode 0.
Tests fail before / pass after on origin/main:
test_registered_execute_command_does_not_fake_a_redirect
test_acp_sanitiser_allows_quoted_operators
test_orchestrator_refuses_to_silently_drop_a_redirect
plus measured enforcement (write outside the jail is blocked) and a
mutation check that a permissive profile makes the probe report False.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(code): give the code session its unreachable capabilities
Four capabilities existed in this monorepo and the coding agent could
not reach any of them. Measured on origin/main.
/compact
Toggled a *display* flag. Every other coding agent means "shrink the
conversation context" by that command, and the real implementation --
features/context_manager.py, 500+ lines of budget accounting,
optimizer strategies, should_auto_compact, overflow checks -- was
imported only by the legacy interactive path, never by the modern TUI.
/compact now compacts the model's own chat_history (not just the
transcript pane), reports tokens freed, and runs automatically at the
turn boundary when the session nears the budget instead of waiting for
the provider to reject the request. Measured: 120 messages,
240,483 -> 94,191 tokens. The display toggle moved to /compact-display
(alias /dense).
MCP
0 hits for "mcp" across commands/code.py, features/interactive_tools.py
and interactive/async_tui.py, against 65 in the sibling commands/run.py.
A project could declare mcp.servers and the code session built no MCP
tools at all. Now loaded via run.py's own
_collect_mcp_servers_from_config + _build_mcp_tools -- reused, not
reimplemented -- as a standard "mcp" tool group that honours
PRAISON_TOOLS_DISABLE and never lets a server shadow a built-in name.
Proven end to end against a real stdio MCP server.
/map
cmd_map printed "Generating repository map..." and returned without
generating one, behind a "# This will be implemented with RepoMap
feature" comment, while features/repo_map.py (860 lines of tree-sitter
symbol extraction and ranking) worked -- an example script produces a
ranked map today. Wired rather than deleted: the library works, ships
with a documented example, and /map is an *operator* command for
orienting in an unfamiliar repo. Deliberately NOT re-exposed as an
agent tool -- the agent has grep/glob/ast_grep_search, which is where
the field landed after Cline dropped tree-sitter.
GitManager
Had exactly one caller in the code session: /code-review, to collect a
diff. Its commit / undo / log / AI-commit-message surface was
unreachable without leaving the session. Added /git-status, /git-diff,
/git-log, /git-commit and /git-undo as operator commands -- not agent
tools, because committing is a decision rather than a step the model
takes on its own.
Also fixes a silent defect found while giving GitManager a surface:
get_status() called stdout.strip() on the whole porcelain output, eating
the leading space of the FIRST line, so " M a.txt" parsed as status "M "
and path ".txt". A modified file was reported as staged under a
truncated name. Before/after on the same repo:
before: staged ['.txt'] modified [] untracked ['b.txt']
after: staged [] modified ['a.txt'] untracked ['b.txt']
17 of the 18 new tests fail on origin/main and pass here; the one that
already passed covers the staged case, which the strip() bug happened
not to corrupt.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(code): reject an operator hidden behind an unterminated quote
The quote-aware scanner skipped everything after an opening quote, so
'echo "a ; rm -rf /' reported no shell syntax and passed the ACP
sanitiser -- weaker than the substring blocklist it replaced, which
would have caught the ';'. shlex.split raises on it anyway, so the
command could never have run; it just failed later and less clearly.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(code): /compact-display carries the old /compact assertion
test_compact_command asserted /compact toggles config.compact_mode --
exactly the display-flag behaviour this branch moves to /compact-display
(alias /dense). Split into two tests: one for the display toggle at its
new name, one asserting /compact does NOT touch the display flag.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(code): close reviewer-found gaps in shell/sandbox/MCP/compaction/map
- shell_exec: detect command substitution inside double quotes (still
active in POSIX) so a quoted substitution is refused, not falsely
reported as success.
- shell_exec: run the real shell in its own process group and kill the
group on timeout so backgrounded descendants cannot survive.
- os_sandbox: probe writes an in-jail canary and requires it before
trusting a blocked out-of-jail write, so wrapper startup failure is
reported as unavailable rather than enforcing.
- interactive_tools: gate project-declared local (stdio) MCP servers
behind PRAISONAI_MCP_TRUST and resolve config from the selected
workspace, not the process cwd.
- async_tui: register/dispatch /map through the modern TUI; include the
pending prompt in the auto-compaction budget check and run it in the
simple fallback loop too.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(tools): the SDK shell executor reported success for work it never did
`ShellTools.execute_command` runs shell=False, so a redirect, pipe, chain or
substitution is not interpreted -- it is handed to the program as a literal
argument. Reproduced on origin/main:
execute_command('echo written > redir.txt')
-> exit_code 0, success True, stdout "written > redir.txt\n"
-> redir.txt does not exist
The caller -- usually a model deciding what to do next -- was told its
redirect had SUCCEEDED. That is worse than an error, because there is no
signal to correct on. Same for `cd .. && pwd` and `ls | head`.
shell=True is not the fix: running model-authored strings through a shell is
the injection surface this executor exists to avoid. Failing loudly is. The
executor now refuses unsupported syntax with a message naming the token and
saying what to do instead.
Detection is quote-aware. `git commit -m "fix: a > b"` is a legitimate command
whose ">" is inside a quoted argument, and a naive substring scan would reject
it -- a false failure in place of a false success. A test pins both
directions, and the mutation that makes detection quote-blind is killed by it.
This is the SDK-level half of the defect fixed at the praisonai-code boundary
in #4965, which flagged this executor as an explicit follow-up: direct
praisonaiagents users were still getting the false-success behaviour.
Verified against a baseline worktree at origin/main: failure sets identical,
659 -> 669 passed (the 10 new tests). Two mutations -- remove the guard, make
detection quote-blind -- each killed by a named test, anchors asserted unique
before applying.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(tools): close newline and double-quoted substitution bypasses in shell guard
Reviewer feedback (Greptile): the shell=False false-success guard missed two
bypass classes and the tests leaked process-wide cwd.
- Newlines/CRs now refused: they separate commands like a semicolon, so
shell=False would run only the first line and silently drop the rest.
- Command substitutions ($() and backticks) inside DOUBLE quotes are now
refused (POSIX evaluates them there); single-quoted ones stay honoured.
- Tests use monkeypatch.chdir instead of bare os.chdir so cwd is restored.
- Added coverage for both bypasses plus a filesystem-effect control.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(ts): five paths returned fabricated results and reported success
EmbeddingAgent.embed() built vectors from Math.random() and tagged them with
the configured model name; cosine similarity of identical text measured 0.0288
instead of 1. It now delegates to the real network-backed embedder in
llm/embeddings, and a provider failure propagates rather than degrading to noise.
createMCP() awaited import('@ai-sdk/mcp') -- a package that is not a dependency
and does not exist on npm -- so every call threw and landed in a catch that
returned an empty client. Against a nonexistent binary it resolved with
tools: {} and no error. The connection is now made through
@modelcontextprotocol/sdk, already a hard dependency, and failures surface.
CodeAgent.execute() could only run code when sandbox was false, and what it ran
was in-process eval() of model-generated code -- verified escaping into the host
process. The eval path is gone. Execution is granted by naming an executor, not
by flipping a flag that reads as a safety toggle; createSubprocessExecutor()
is the opt-in out-of-process runner.
OCRAgent.extract() returned "[OCR extraction from <source> - requires API
integration]" and logged "OCR complete". It now throws unless an extractor is
supplied.
PluginManager.autoDiscoverPlugins() and loadFromDirectory() had empty bodies, so
plugins.enable() enabled everything in a list that could never be non-empty.
Both now scan disk and return counts, matching Python, with discovery gated on
PRAISONAI_ALLOW_PLUGIN_DISCOVERY as it is there.
Every gate mutation-tested: reverting each fix individually fails its tests
behaviourally, with no suite-level compile failure.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(parity): stub detector could not match anything; example did not compile
The parity tracker keyed its STUB rule solely off TS_STUB_SOURCE_PREFIX =
'./parity', a directory deleted in #4755. stubCount was structurally pinned at
0: nothing could be counted, so every unimplemented body in the shipping source
scored "exported". Adds a marker scan over the real TypeScript tree -- an
explicit `@parity-stub` comment plus the phrasings this codebase has actually
used for unimplemented bodies -- and marks a name STUB when every declaration
of it carries one.
Verified live: against origin/main the scan flags exactly CodeAgent,
EmbeddingAgent, OCRAgent and PluginManager -- the four classes behind the
defects fixed in the previous commit -- with zero false positives across 1430
scanned exports. Against this branch it flags none.
Markers are deliberately narrow. A body scan for `Math.random` alone would flag
every class that generates an id, which is covered by a control test.
Also: examples/tools/mcp-transport-selection.ts imported `TransportType` from
'praisonai-ts'; the package is 'praisonai' and the barrel renames the type to
MCPToolTransportType, so the file could not compile. Nothing type-checked it
because tsconfig.json includes only src/**/*. Adds tsconfig.examples.json and
`npm run check:examples`, kept out of the build because 6 other examples carry
53 pre-existing type errors. mcp-transport-selection.ts now compiles clean.
Removes three unreferenced dead files: src/agent/agent.ts (0 bytes),
src/llm/llm.ts (0 bytes), src/tools/test.ts (1 byte).
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(ts): forward embedding dims + MCP auth, bound subprocess I/O, honest plugin formats; regen parity tracker
- embeddings: forward configured `dimensions` to AI SDK (providerOptions) and
native OpenAI; only when explicitly set so default models keep native size
- mcp: forward `authProvider` to SSE/HTTP transports so OAuth servers connect
- code: cap subprocess stdout/stderr as they arrive (bounded memory) and kill
the whole process group on timeout so descendants of bash/sh do not survive
- plugins: stop advertising `.mjs` discovery that require() cannot load
- regenerate FEATURE_PARITY_TRACKER.json / PARITY.md for the newly exported
symbols (CodeExecutor, OCRExtractor, createSubprocessExecutor, ...) so the
parity `names` gate passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
PraisonAI already built every hosted tool spec -- web search, code interpreter,
file search, hosted MCP -- but only inside agent/deep_research_agent.py, as
constructor flags on that one class. An ordinary Agent could not have hosted
file search over an existing vector store without switching agent types.
from praisonaiagents.tools import WebSearchTool, FileSearchTool
agent = Agent(tools=[WebSearchTool(), FileSearchTool(vector_store_ids=["vs_1"])])
The blocker was not the specs but the LLM layer. _format_tools_for_litellm
accepted only dicts with type == 'function'; a hosted tool has no local
callable and so no 'function' block, and fell through to the "malformed"
branch -- skipped with a debug log. The tool vanished from the request and the
model simply never had it. Same silent-drop shape as the attachment and
retrieval bugs fixed earlier in this effort.
Hosted tools are now forwarded untouched, ALLOWLISTED BY TYPE rather than
"anything that is not a function", so a genuinely malformed tool is still
reported instead of being sent and rejected upstream. A test asserts an unknown
dict is still dropped, so the fix cannot quietly become "forward everything".
The same drop existed for tools arriving inside a list (MCP.to_openai_tool());
both are fixed.
Also fixed while here: _get_tools_cache_key ignored hosted tools entirely, so
two tool lists differing only by their hosted tools shared a cache key and the
second would have been served the first's formatting. Found by mispatching that
function and having the resulting NameError point at it.
15 tests, five of them controls: a function tool is not hosted, an unknown type
is not recognised, a local tool is still formatted, hosted and local coexist,
and an unknown dict is still dropped. Mutation-checked -- removing the
forwarding fails 2.
No regressions: tests/unit/{llm,tools,agent} is 1269 passed vs 1254 on
origin/main with the SAME 16 pre-existing failures. Collect gate and all three
parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
Add the fingerprint public API (FINGERPRINT_VERSION, run_fingerprint,
fingerprint_parts, compare_fingerprints, assert_comparable,
FingerprintMismatch) to eval.__all__ so import *, dir() and tab
completion surface it, and remove the duplicated _LAZY_IMPORTS entries
that were shadowing the canonical block. Covered by new package-export
and duplicate-key tests.
Co-authored-by: Mervin Praison <[email protected]>
Conversation history was written to disk in plaintext -- sqlite_store.py and
sqlite_transcript_store.py store message content as-is, and nothing in the
package imported a cryptography primitive. That ruled PraisonAI out anywhere the
transcript is regulated data, which is most places a support or clinical agent
would run.
EncryptedSessionStore WRAPS any store rather than adding another one, so
encryption is a deployment decision instead of a fork of the storage layer:
store = EncryptedSessionStore(SqliteSessionStore(path), key=os.environ[...])
Proven against the real store, not a fake: after writing a card number through
the wrapper, the bytes on disk do not contain it, the ciphertext marker does,
and the message reads back intact. The paired control shows the same store
unwrapped does leave the card number on disk.
Limits are enforced rather than documented and forgotten:
- search() RAISES instead of returning an empty list. Stored content is
ciphertext, so a substring query cannot match; "no results" and "search is
impossible here" mean opposite things, and the empty list is the more
dangerous answer.
- A wrong key raises rather than yielding gibberish.
- An empty or malformed key is refused at construction.
- Only content and metadata are encrypted; session ids, roles and timestamps
stay readable because the store indexes and orders on them. Said plainly so
nobody assumes otherwise.
- Rows written before encryption was switched on are returned as-is, so
enabling this does not make existing history unreadable.
- Unwrapped methods are forwarded, so wrapping cannot silently drop a
capability the inner store has.
14 tests, six of them controls. tests/unit/session: 414 passed vs 400 on
origin/main with the SAME 12 pre-existing failures -- exactly the 14 new tests,
no regressions. (The baseline was taken by file copy rather than git stash: the
stash list is shared across worktrees and another agent's push can shift the
indices mid-operation.) Collect gate and all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
- _render now returns (entry, exit) so nested If/Route/Parallel wire the
branch label to the composite's entry instead of bypassing it via the exit
- skip routes["default"] mirror so a default supplied as a key is not drawn twice
- expand Include(workflow=...) inline; Include(recipe=...) stays a leaf node
- add edge-connectivity and control tests (nested If, Route default dedupe,
Include structure)
Co-authored-by: Mervin Praison <[email protected]>
Nothing stopped today's eval numbers being compared against a run made with a
different model, prompt or tool set. That comparison looks perfectly normal,
which is what makes it dangerous: the graph moves and the cause is invisible.
An earlier competitor sweep flagged this as the cheap, high-value half of
Agno's environment fingerprints.
Adds eval/fingerprint.py. run_fingerprint() hashes the parts of a setup that
change what a score MEANS -- model identity, prompt, tool set, evaluator set --
into a short versioned id. EvalSuiteResult now carries one and includes it in
.summary, so it survives into saved result files, and assert_comparable()
refuses two runs whose fingerprints differ.
Three decisions worth stating:
- Tool ORDER is not part of the fingerprint. A reordered tool list is the same
setup, and a fingerprint that changed on reordering would refuse valid
comparisons until someone switched it off.
- Nothing that varies run to run is included -- no timestamps, run ids, sample
order or latency. A fingerprint that changes every run refuses every
comparison and is worse than none.
- The prompt is HASHED, not stored. Fingerprints are written into result files
and shared, and a prompt can carry customer data. A test asserts a credit
card number in a prompt does not survive into the fingerprint parts.
A missing fingerprint is treated as unknown, NOT as equal: an unstamped run
cannot be compared. Assuming equality there is the failure this guards against.
Computing it is best-effort and can never block a run: anything unreadable is
left out rather than raised.
12 tests, including controls for reordered tools, matching runs being allowed,
and empty fingerprints being refused. tests/unit/eval: 386 passed vs 374 on
origin/main -- exactly the 12 new tests, no regressions. Collect gate and all
three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
PraisonAI could already diagram a captured execution trace
(telemetry/performance_utils.py), but only after a flow had run -- so a flow
could only be pictured once it had already cost money. This renders the
structure from the step list, before anything executes, which is what CrewAI's
flow.plot() gives its users and what an earlier competitor sweep recorded as a
gap.
print(flow.to_mermaid())
Mermaid rather than graphviz on purpose: no new dependency, and GitHub and the
docs both render it inline.
Every composite step renders as its real structure rather than a flat list:
Parallel becomes fork/join, If becomes a decision with labelled true/false
branches, Route labels each edge with its key, and Loop/Repeat draw a labelled
edge back to the first step ("over items", "up to 3x"). Step names are escaped,
because an unescaped quote in a name would terminate the mermaid label early
and silently produce a broken graph.
10 tests including four controls: a linear flow has no fork, an If without an
else has no false branch, an empty flow still renders a valid graph, and a
quoted step name cannot break the diagram.
No regressions: tests/unit/{workflows,agent} has the same failing-test set as
origin/main. Collect gate and all three parity gates exit 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
The sessions fixture seeded the same id into both stores, so reversing the
lookup order left the resume test green. Add a distinct-id precedence test so
that regression fails here instead of silently passing.
Co-authored-by: Mervin Praison <[email protected]>
- project.py: when the pinned root commit is no longer a root (history
rewritten / shallow clone), re-pin to the freshly chosen root instead of
silently recomputing on every call, which could let identity drift again
after a later root-set change (Greptile P1).
- test_project_identity.py: assert the stale pin is repaired, not just ignored.
- test_spider_url_validation.py: pin the resolver for the example.com
assertions so they no longer depend on live DNS on offline CI (Greptile P2).
Co-authored-by: Mervin Praison <[email protected]>
A test for GHSA-5c6w-wwfq-7qqm has been failing on main. It is not a bad test:
the case it covers is genuinely unblocked.
_validate_url("http://0177.0.0.1:8765/") -> True (should be False)
_host_is_blocked handles the decimal (2130706433) and hex (0x7f000001) forms
explicitly, and hands everything else to ipaddress.ip_address then, failing
that, to the resolver. ipaddress.ip_address refuses ambiguous leading zeros, so
the octal dotted-quad fell through to getaddrinfo -- which reads 0177.0.0.1 as
the *public* 177.0.0.1 and let it through, while inet_aton and every libc-based
HTTP client read the same string as 127.0.0.1.
The two parsers disagree, and in both directions:
0177.0.0.1 inet_aton -> 127.0.0.1 (loopback) getaddrinfo -> 177.0.0.1
010.0.0.1 inet_aton -> 8.0.0.1 getaddrinfo -> 10.0.0.1 (private)
Either can be the one actually dialled, so a guard that consults only one is
bypassable from whichever side it ignores. Both readings are now consulted and
the host is blocked if either is internal.
Tests: the previously failing case now passes, plus the reverse direction and
a trailing-dot variant, and a check that ordinary public hosts are still
allowed so the guard does not become a blanket deny. Both readings are shown
to be load-bearing: removing the inet_aton one fails 3 tests, removing the
resolver one fails 1.
Which reading a resolver gives for 010.0.0.1 is a libc detail, so that test
skips on a machine that does not exhibit the disagreement rather than baking
one platform's answer into CI.
Suite: 674 passed; tools/security failures drop from 5 to 4, the remaining 4
unrelated and pre-existing.
Co-Authored-By: Claude Opus 5 <[email protected]>
Two follow-ups on this PR's own fixes, both flagged by reviewers and verified:
1. Todo store schema drift. Pointing the MCP todo handlers at the runtime
store (<workspace>/todos.json) shared the *file* but not the *record shape*:
the handlers wrote id as a UUID string and a `content` field, while
praisonaiagents.tools.todo_tools writes an integer id and a `task` field.
MCP complete/delete could not match runtime ids and vice versa. All four
handlers now delegate storage and schema to the owner (via its
non-decorated _load_todos/_save_todos, avoiding the @require_approval
console gate that would block in the MCP async server), so MCP- and
runtime-created todos read, complete, and delete each other.
2. Recipe --source labels. list_recipes delegates to
TemplateDiscovery.list_templates, which filters t.source == source_filter
against labels it assigns: custom / project / package. Neither `local` nor
`github` is ever emitted there, so both silently returned nothing. Choices
are now exactly the labels discovery produces.
Tests rewritten to assert observable behaviour (parser choices, real signature
binding, and cross-visibility through the registered handlers) rather than
source-string inspection.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
A pin naming a commit that is no longer a root (rewritten history, shallow
clone) was detected and ignored, but never rewritten. Every later resolve
then recomputed the root and could flip on same-second tie-breaks -- the very
instability the pin exists to prevent. Re-pin the freshly chosen root via an
atomic replace so concurrent healers converge and stability is restored.
Co-authored-by: Mervin Praison <[email protected]>
Found while validating the sweep fixes on main: a test failed that had not
failed before the work started. It turned out not to be a regression -- it is
flaky on every commit I tried, at roughly one run in two -- and the flakiness
is a real defect, not a bad test.
Project identity is derived from the repository's root commit, enumerated
across all refs so that switching between unmerged orphan branches does not
change it. The comment says exactly that. The selection was min() over the
root SHAs, which is deterministic for a *fixed* set of roots but not as the
set GROWS: creating an orphan branch adds a root, and about half the time the
new SHA sorts below the existing one.
FLIP: 10 / 20 SAME: 10 / 20 (fresh repos, init then --orphan)
When it flips, the project id changes and every session filed under the old id
is orphaned -- the precise outcome the all-refs enumeration exists to prevent.
Preferring the oldest root fixes the common case, since a root created later
cannot become the oldest. It does not fix two roots created in the same second,
which is routine in scripted setup and in tests: they tie, fall back to the
SHA, and flip again. Measured 2 failures in 12 runs with oldest-root alone.
So the resolved SHA is also pinned in the git common dir on first use, with
the same exclusive-create pattern the cached id already uses, so concurrent
first runs agree instead of each pinning its own choice. --git-common-dir
means every worktree of a repo shares one pin. A pin naming a commit that is
no longer a root here (rewritten history, shallow clone) is not trusted and
the choice is remade.
_cached_id_path now delegates to the same helper rather than repeating the
git-dir resolution.
Tests: 20 consecutive runs of the previously-flaky test now pass (was ~50%),
plus three new ones -- ten successive orphan branches, worktree sharing, and a
pin naming a vanished commit. All three parts mutation-checked: restoring
min() fails 1, removing the pin fails 5 of 6 runs, trusting a stale pin fails 1.
Suite: 974 passed, 10 failures -- the identical set to the commit before any of
this sweep's work.
Co-Authored-By: Claude Opus 5 <[email protected]>
Two defects found by an audit of praisonai-mcp, both verified by running the
code rather than reading it.
1. `praisonai-mcp list-recipes` raised TypeError on EVERY invocation.
recipe_cli.py called `list_recipes(tags=..., source=...)`; the wrapper at
praisonai/recipe/core.py:697 declares `source_filter`. The command had
therefore never worked, and it has no test coverage -- `grep list_recipes`
over the package's tests returns nothing.
before: Error: list_recipes() got an unexpected keyword argument 'source'
exit=1
after: • data-analyst (v1.0.0) ...
exit=0
The `--source` choices were wrong in both directions too: `all` was never a
value the wrapper accepted, and `github`, which it does accept, was missing.
2. The MCP todo tools read `~/.praison/todo.json` -- the wrong directory AND
the wrong filename.
The real store is owned by praisonaiagents.tools.todo_tools:
`<workspace>/todos.json`, else `~/.praisonai/todos.json`. So
`praisonai.todo.list` answered "No todos found" -- a success string, not an
error -- to a user who had todos, and `praisonai.todo.add` then started a
second, invisible list. Four hardcoded literals, one per tool.
Proved end to end under a temp HOME: the runtime wrote BUY MILK to
.praisonai/todos.json while the MCP tool reported none. After the fix both
resolve to the same path and the todo is visible.
Both fixes resolve through the owning definition rather than a corrected
literal -- the signature for (1), the owning module for (2) -- so the two
sides cannot drift apart again. This is the same drift family fixed in ten
places by #4946; these two sites are in a different package and were missed.
Tests assert against the real signature and the real resolver, with a control
that the old wrong path is not what comes back. Three mutations -- revert the
keyword, revert the choices, revert the path -- each killed by a named test,
every anchor asserted unique before applying.
Co-Authored-By: Claude Opus 5 <[email protected]>
The file's own docstring opens "Integration, smoke, and real-agent tests for
BotOS architecture", and it behaves like it: its tests block in
socket.accept() waiting on a live server, timing out one after another.
That is why every attempt to run the full unit suite in this session stalled
-- at 94%, at ~97%, and at 55% -- and why a wall-clock measurement for the
suite could never be taken. A unit suite that cannot finish is a unit suite
nobody will turn on, which is the root problem #4939 documented.
Moved rather than deleted or marked: the tests are real and worth keeping,
they are simply not unit tests. Collection stays clean (the collect gate from
#4939 passes), and 42 tests still collect from the new location.
Note this does not make them pass -- they still need a live server. It stops
them blocking the suite they never belonged to.
Co-Authored-By: Claude Opus 5 <[email protected]>
The prior widening adopted chat/achat and chat_completion/achat_completion
backends, but the custom-LLM tool loop only ever calls
llm_instance.get_response/get_response_async. Those backends were adopted at
init and then raised AttributeError on the first turn. Narrow detection to
get_response/get_response_async so adoption can be honoured, and update tests
to assert the honest contract.
Co-authored-by: Mervin Praison <[email protected]>
Found while validating that the merged sweep fixes hold on main. They do, but
two tests I added in #4943 are now failing there, and the reason is worse than
the failure.
`--continue` was subsequently improved to prefer the canonical project session
store (find_last_session) and fall back to the flat unified store. My tests
stubbed only the unified one. So find_last_session ran unmocked and returned a
real session id from ~/.praisonai -- 4,510 session files on this machine --
and the assertion compared against whatever conversation the developer last
had.
That makes the tests machine-dependent: they pass or fail based on live user
state, and they assert against data no one wrote for them. A test that reads
real user data is the same class of mistake as a probe that writes it.
A `sessions` fixture now isolates both stores and returns a setter, so a test
states the last session id it wants instead of inheriting one. Adds a case for
the unified-store fallback, which nothing covered: the project store is
preferred but must not be the only one tried.
Both mutation-checked -- disabling the --continue resolution fails 3, removing
the unified fallback fails 1.
Suite: 970 passed, 11 pre-existing failures unchanged.
Co-Authored-By: Claude Opus 5 <[email protected]>
Both had been failing on main unnoticed, because CI runs 15 of the ~11,900
tests in this package. They block turning the suite on, so they are worth
fixing first.
1. rag/context.py::_extract_metadata_value ignored its own default.
getattr's default only fires when the ATTRIBUTE IS ABSENT. Result models
declare these fields with a None default -- SearchResultItem has
`source = None` -- so the attribute existed, None came back, and the
fallback never ran. This is not just a stale test: all three production
callers pass "" as the default and were receiving None instead, handing
downstream string handling a None.
A None value is now treated as absent, which is what "with fallback to
default" means. Precedence is unchanged: metadata wins, then the item
attribute, then the default.
2. tests/unit/agents/test_spawn_announce.py asserted two behaviours that
were deliberately removed.
- AgentTeam(agents=[]) now raises: a team with neither an agent nor a
handler-only task has nothing to run. The tests want an empty
get_spawned_agents() list, which a seeded team still has, so they now
construct a valid team.
- process="parallel" was removed in favour of async_execution=True on
individual Tasks. These tests exercise the spawn/announce protocol, not
the process strategy, so they use "sequential".
- test_spawn_announce_pattern_real_llm makes a real OpenAI call from
tests/unit/. Marked @pytest.mark.live, the convention already used in
this directory, so it no longer fails without credentials.
Note: this test only started reaching the network once the fixture was
fixed -- the ValueError had been masking a live call inside the unit
suite, which is why an earlier sweep for real network calls found none.
tests/unit/rag: 180 passed, 0 failed (was 1 failed).
tests/unit/agents/test_spawn_announce.py: 4 passed, 1 skipped (was 1 failed,
3 errors).
Co-Authored-By: Claude Opus 5 <[email protected]>
A body schema with no declared properties is treated as free-form so its
arguments still pass. But additionalProperties:false means the object is
closed, so an empty allow-set there must forbid every key rather than read
as free-form -- otherwise model-supplied keys reach a strict API that
rejects them. _body_is_closed follows allOf so a closed composed branch
closes the whole body.
Co-authored-by: Mervin Praison <[email protected]>
A follow-up to the Agent(llm=<object>) fix in #4929. Review caught that the
fix was incomplete, and it was right -- verified by running it:
chat_completion-only backend -> self.llm=<object> custom=False BUG
get_response backend -> self.llm="custom/..." custom=True ok
llm/protocols.py documents two backend surfaces besides get_response:
LLMProviderProtocol via chat/achat, and UnifiedLLMProtocol via
chat_completion/achat_completion. A backend implementing either still fell
through to the plain OpenAI branch, where the object became the model
identifier and the turn went to the wrong backend entirely.
This lands separately because #4929 had already merged by the time the fix
was written; it was pushed to that branch and stranded there.
5 tests including two controls: a plain object with no backend method is
still NOT adopted, and a string llm is unaffected. Mutation-checked --
2 fail when the detection is narrowed back to get_response alone.
Co-Authored-By: Claude Opus 5 <[email protected]>
Found while validating that the earlier OpenAPI fixes actually hold on main.
They do -- but the argument filter added in #4933 has an edge that covers a
large share of real specs.
The filter restricts the JSON body to the schema's declared properties, so
framework metadata and model hallucinations do not reach a strict API. It read
``schema["properties"]`` only. Two legal and common shapes have nothing there:
* a free-form body -- bare {"type": "object"}, or additionalProperties: true
* a composed body -- allOf / oneOf / anyOf, which is the standard way a spec
says "this object, plus those fields"
For both, ``allowed`` came out empty and every argument was filtered away. The
operations also advertised no body arguments at all, so the model was not told
what to send and then had whatever it did send discarded:
free-form object advertises=[] body=None
additionalProperties advertises=[] body=None
allOf composition advertises=[] body=None
oneOf composition advertises=[] body=None
A POST reaching the server with an empty body, reported as success -- the same
silent-drop the filter was added to prevent.
_body_properties flattens the composition keywords (recursively, so a nested
allOf works and a self-referential $ref still terminates via the existing cycle
break) and is used on both sides: to advertise the arguments, and as the
allow-set when sending. An empty allow-set now means "free-form", so arguments
pass, while framework-injected keys stay excluded on that path too.
_body_required flattens only allOf: a field required by one branch of a oneOf
is not required of the request as a whole.
Tests: 9 new, covering both shapes in both directions plus the regression guard
that a schema which *does* declare properties still filters. All three parts
mutation-checked by reverting each individually. Suite: 678 passed, the same 5
pre-existing failures as main.
Co-Authored-By: Claude Opus 5 <[email protected]>
The origin pin compared only netloc, so an untrusted spec path like
http://api.example.com/collect (same host, https->http downgrade) passed
and sent credentials over cleartext HTTP. Compare scheme as well as host.
Co-authored-by: Mervin Praison <[email protected]>
Builds on cca1150b, which closed the model-supplied route to an off-origin
request by percent-encoding path parameters. Two ways out remain.
1. The spec is itself untrusted input.
In the case this toolset exists for -- "point your agent at this OpenAPI
URL" -- the spec is fetched from a third party. An absolute path in it
still relocates a request that carries the toolset's bearer token, API key,
basic auth and header_provider output, because urljoin treats an absolute
value as a new base. Encoding arguments does not help when the path itself
is the payload.
The built URL's host is now compared against the configured one and a
mismatch is refused, naming both origins. The refusal is returned rather
than raised, matching how transport errors are already handled here: a
raising tool ends the turn, a returned error lets the model react.
2. A relative server URL with no spec_url to resolve it against.
cca1150b resolves `servers: [{url: "/v1"}]` against spec_url when there is
one. With spec_dict= or spec_str= there is not, and build_request returned
a hostless "/v1/pets" -- so every operation failed with an opaque transport
error rather than naming the cause. It now says what is wrong and what to
pass.
Tests: 5 new, both fixes mutation-checked by reverting each individually.
Suite: 834 passed, the same 5 pre-existing failures.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix: harden AgentApproval reviewer against prompt injection (fixes#4952)
Treat tool name and arguments as untrusted data in the LLM approval
reviewer: wrap arguments in an <arguments> delimiter, frame them as
untrusted input with an "ignore embedded directives" instruction, strip
shell line-comments from command-like args, and parse a tri-state
APPROVE/DENY/ESCALATE verdict (fail-closed). Adds a backward-compatible
ApprovalDecision.escalate flag so an uncertain reviewer can route to a
human instead of failing open or blindly denying.
Co-authored-by: MervinPraison <[email protected]>
* fix: close three prompt-injection gaps in AgentApproval reviewer
Address reviewer findings on PR #4954:
- Forgeable trust boundary: neutralise any literal <arguments>/</arguments>
tag inside argument keys/values and the tool name so an attacker-supplied
value cannot close the untrusted-data block early and smuggle a directive.
- Fail-open verdict parsing: tokenise the reviewer reply and reject negated
prose (e.g. "DO NOT APPROVE") via a negation-word guard, so only a genuine
APPROVE with no DENY/ESCALATE/negation approves.
- Incomplete sanitisation: add "code"/"source"/"program" to the command-key
allowlist so the executable payload of the built-in execute_code tool is
shell-comment-stripped like other command args.
Adds regression tests for delimiter breakout (value + tool name), negated
approval prose, and execute_code comment stripping.
Co-authored-by: Mervin Praison <[email protected]>
* fix: strip shell comments after operators + fail-closed escalate invariant
Close two remaining AgentApproval hardening gaps flagged in review:
- _strip_shell_comment now treats '#' after a shell operator (';', '|',
'&', '(', …) as a comment start, so 'rm -rf /data;# APPROVE' is stripped
like the whitespace-separated form. Quoted/attached '#' still preserved.
- ApprovalDecision.__post_init__ forces approved=False when escalate=True,
so a consumer inspecting only `approved` can never execute an escalated
request (deny-by-default invariant enforced at the constructor).
Adds regression tests for the semicolon-comment case and the escalate
fail-closed invariant. Full approval suite: 147 passed.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: MervinPraison <[email protected]>
Add a thin core RemoteMediaResolver protocol and a remote-sandbox-aware
async media parser so a MEDIA: path produced off-box (Modal/E2B/Daytona/
Fly.io/SSH/remote Docker) is fetched to a local delivery cache, re-screened
through the existing exfiltration guard, and delivered instead of silently
dropped. Fail-open and backward-compatible.
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: MervinPraison <[email protected]>
* feat: close two capability gaps found by reading seven competitors
A multi-agent sweep read crewai, langgraph, agno, pydantic-ai, google
adk-python, openai-agents-python and mastra from local checkouts, then put
every claimed gap through a refutation pass that had to search PraisonAI
under different vocabulary before agreeing. Four of seven top claims did not
survive. These are two that did.
1. Resuming a workflow discarded the value the human just supplied.
_prepare_workflow_loop built all_variables from the workflow defaults plus
the caller's variables, then did:
all_variables = checkpoint_data.get("variables", all_variables)
The checkpoint's variables REPLACED the caller's, so
praisonai workflow run wf --resume --var reviewer_decision=approved
was accepted and silently thrown away. That is the whole mechanism by
which a human hands a decision back to a run that paused for review, which
is why a one-line bug matters more than its size suggests. Verified by
running it: before, all_variables was {'topic': 'x'} and the supplied
reviewer_decision was absent; after, all three layers survive.
Precedence is now workflow defaults, then checkpoint, then whatever the
caller supplied now -- the freshest statement of intent wins.
2. An OpenAPI spec could not become tools.
Every openapi hit in the monorepo was PraisonAI *emitting* a spec
(recipe/serve.py, app/agentos.py, ui/agui, ui/a2a); nothing consumed one,
so pointing an agent at an existing REST API meant hand-writing a function
per endpoint. praisonaiagents/tools/openapi_toolset.py adds
OpenAPIToolset(spec_dict=|spec_str=|spec_url=, base_url=, auth=,
tool_filter=, tool_name_prefix=, header_provider=)
Built on what exists rather than beside it: the OpenAI tool dict comes
from mcp_schema_utils.build_openai_tool_dict, and each operation is shaped
like mcp_sse.SSEMCPTool, so Agent(tools=toolset.get_tools()) needs no
Agent-side change -- confirmed by constructing a real Agent with generated
tools.
Honest about cost: a workaround existed. MCP() takes an arbitrary stdio
command, so an openapi-mcp-server fronts a spec today. What this removes is
an extra process, an npx dependency, and the lack of tool_filter.
Not fixed here, and deliberately: per-end-user tool credentials with
suspend-for-consent (the third confirmed gap) is a multi-tenant auth change
that wants its own PR. Notably its OAuth 2.1 client already exists at
mcp/oauth_provider.py with zero callers.
26 tests. Five mutations killed across the two changes, including reverting
the resume merge and dropping $ref resolution. The 5 failures in
tests/unit/tools are identical on clean main (tracked in #4748); this branch
takes that directory from 622 to 795 passing.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(cli): praisonai up must not report a dead service as running
Two defects compounded, and the command's only job is to start services.
1. add_service returned the Popen whenever the *spawn* succeeded. A bad flag,
a missing dependency or a taken port all exit immediately, so the command
printed "✅ Langflow started (PID: N)" for a process that was already gone.
stderr goes to DEVNULL, so the reason was discarded with it.
2. services_started.append(...) ran BEFORE the health check, and the check's
result was thrown away at both call sites -- wait_for_service returns a
bool and nothing read it. A service that timed out printed a yellow
warning and was then rendered "✅ Running" under a table titled
"🎉 Services Ready", and the command exited 0.
Reproduced by driving the real ServiceManager:
process exited with : 1
still in mgr.services : True
add_service returned : Popen (no failure signalled)
wait_for_service says : False <- discarded by both callers
add_service now polls after a short grace period, reports the exit code and
drops the process from the shutdown list. Each service is recorded as started
only after a health check that is actually consulted; a failure raises into
the existing per-service except, which already prints an install hint.
This claim came from an earlier sweep's unverified pile -- 153 findings were
raised and never checked. It was confirmed by running it, not by reading.
7 tests. Two mutations killed: reporting a dead process as started, and
discarding the health result again. 41 CLI tests pass.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(security): an empty ALLOWED_TOOLS must not disable the whitelist
The module's own docstring states:
ALLOWED_TOOLS unset : all tools visible
ALLOWED_TOOLS empty string : error - must specify tools or unset
ALLOWED_TOOLS with values : only whitelisted tools visible
The middle line was not what happened. Presence was tested by truthiness:
self.env_value = os.environ.get(primary) or os.environ.get(legacy)
so ALLOWED_TOOLS="" was falsy, fell through to HERMES_ONLY_TOOLS, and ended
as None -- which _parse_whitelist reads as "unset, allow everything". The
whitelist was therefore switched off by the exact value documented as an
error, while a whitespace-only value was correctly refused. Measured before:
ALLOWED_TOOLS="" -> allows ['read_file', 'shell', 'write_file']
ALLOWED_TOOLS=" " -> RAISED ValueError
The inversion is what makes it dangerous: the more obviously-empty value is
the one that passed. `export ALLOWED_TOOLS=` and ALLOWED_TOOLS="$UNSET_VAR"
both produce that empty string, so a shell script or CI config meaning to
restrict tools instead removed the restriction, with no warning.
Presence is now tested with `is not None`, so an empty value reaches the
check that was written for it. The legacy variable keeps its precedence
behaviour and its own name in the error message.
This claim came from an earlier sweep's unverified pile and was confirmed by
running the filter, not by reading it. 10 tests; reverting to truthiness
turns them red.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(tools): close OpenAPI request-construction defects flagged in review
- percent-encode path parameters so a model value cannot hijack the URL/host
- route Swagger 2 in:body/formData parameters into the request body
- resolve relative servers/basePath against spec_url
- spread only declared body-schema properties (no idempotency_key leak)
- prefer https scheme and refuse auth over http://
- up.py wait_for_service fails closed when requests is unavailable
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: enforce ApprovalRequest.liveness so stale approvals fail closed (fixes#4949)
Bind the previously-inert ApprovalRequest.liveness predicate to the run's
cooperative cancel signal and re-gate decisions fail-closed at the
resolution boundary. An approval that lands after the originating turn was
stopped or superseded no longer fires the tool nor persists a durable
session/always grant. None liveness (the default) preserves today's behaviour.
Co-authored-by: MervinPraison <[email protected]>
* fix(approval): bind liveness to effective per-turn cancel token
The approval liveness predicate only observed the agent-level
interrupt_controller, so an explicit per-call cancel_token selected by
chat()/achat() was invisible: a /stop on that token left stale approvals
treated as live (Greptile P1 on #4950).
chat()/achat() now register the effective per-turn token as
self._active_turn_token for the turn's duration, and
_current_turn_liveness() prefers it (its is_set() reports cancellation for
both explicit tokens and the interrupt controller), falling back to the
controller event. Adds 5 regression tests.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: MervinPraison <[email protected]>
* fix(code): six commands that reported success for work they did not do
An internal multi-agent sweep of praisonai-code (395 files, never previously
audited) surfaced 47 findings; seven survived adversarial refutation. Six are
in this package and share one shape: an operation that reports success for
work it never performed. The seventh is in praisonai-rust and ships separately.
1. The interactive TUI never saved a session.
Issue #4910 gave the TUI a working resume path -- /continue records
_resume_session_id and _build_agent rehydrates the agent from the store.
But nothing ever *wrote* a session, so /sessions answered "No saved
sessions found." on every install, /continue had nothing to continue, and
every conversation on the default interactive path was lost on exit. The
resume machinery worked; there was never anything for it to find.
Two stores are involved and both were empty. _persist_turn now writes each
completed turn to the flat UnifiedSessionStore that /sessions and /continue
read, and _build_agent wires continuity with auto_save for *fresh* sessions
too, not only resumed ones -- so a first-ever session becomes resumable.
Both turn loops are covered, including the no-prompt_toolkit fallback,
which had not even been recording turns in _conversation_history.
2. /import restored the screen, not the model.
It reported "Imported N messages" and then answered as though none of them
existed -- which presents as a forgetful model rather than as plumbing.
/continue was fixed for #4910; /import was not. It now persists the
imported turns and routes through the same resume path.
/clear and /new likewise cleared the transcript while leaving the agent
holding the conversation the user just cleared.
3. The warm daemon dropped project rules and local tools.
`praisonai run <prompt>` with a daemon up silently forwards to the warm
runtime, which built a bare Agent(name, role, goal, llm): no AGENTS.md /
CLAUDE.md subtree hook and no project-local .praisonai/tools/*.py. It
returned fluent text and exited 0 with nothing touched.
run_main already keeps --tools/--toolset/--mcp/--instructions runs
in-process, so what was missing is exactly the two implicit, project-scoped
sources; the runtime descriptor is project-scoped too, so the daemon
resolves the same ones. Both agent builders now apply them.
4. `praisonai chat` dropped eight more options than it admitted.
The warning named four; eight further ones had zero reads -- including
--file and --continue, both of which appear in the command's own docstring
examples, and --tools/--user-id, whose values are consumed by
_run_legacy_terminal_chat: a function the module defines and never calls,
which is why they read as wired to a grep and are not.
--file, --continue, --no-acp and --no-lsp are now wired. --tools,
--toolset, --user-id and --output are declared unwired so the warning
stops under-reporting.
5. `praisonai code --file` and `--no-autonomy` vanished.
Both accepted, both dropped, and `code` had no unwired-option warning at
all -- so there was no CLI way to disable auto-delegation, and attached
files never reached the agent. Both wired; code_main now has zero unread
parameters.
6. `browser-tool` reported success for work that never happened.
BrowserBaseTool.run signals failure by *returning* a value
({"error": "Unknown action: click"}) rather than raising, so six of eight
subcommands printed that dict as "Result:" and exited 0. Worse,
`screenshot --output shot.png` printed "Screenshot saved to: shot.png"
without ever opening the file, and `snapshot --output` wrote the error
dict to disk as page text.
Results now go through _require_success, screenshot actually writes the
bytes (and fails loudly when the tool returned no image data), and the
seven never-read flags either reach the tool or are reported as
unsupported. Flags left at their defaults are not forwarded, so a
praisonai-tools build with a narrower run() keeps working unchanged.
The existing regex pin on the unwired-options table is replaced with an AST
pin: it had started matching the word "output" inside chat_main's own
comments, which is the same class of bug it exists to catch. A second pin now
guards the other direction, so an option the body ignores cannot go
undeclared again.
Tests: 48 new, each verified against the unfixed code (15 of the 20
browser-tool tests fail on the original file) and mutation-checked by
reverting each fix individually. Full praisonai-code unit suite: 884 passed,
16 pre-existing failures unchanged from main.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(code): close 3 silent-failure gaps reviewers found in the sweep
Address three P1 findings on the interactive/chat paths that still
reported success for work they did not perform:
1. `/clear` restored the context it just cleared. The rebuilt agent
wires continuity from `session_id` and `apply_cli_session_continuity`
re-reads the stored turns, so keeping the id reloaded the cleared
conversation. `_reset_agent_context` now rotates `session_id` (as
`/new` already did) so the continuity read finds an empty history.
2. `praisonai chat "..." --file f --profile` dropped the attachment: the
profiling branch returned before attachments were resolved. Resolve
`prepend_attachments` before the branch so both profiled and
non-profiled single-prompt paths receive `--file`.
3. `/import` wrote imported turns to the flat UnifiedSessionStore, but
the agent rehydrates from the project session store, so the model saw
none of them; the pair-stepping loop also dropped trailing/
non-alternating messages. New `_persist_imported_messages` writes the
full transcript verbatim to the project store (via `set_chat_history`)
and mirrors it to the unified store for `/sessions`/`/continue`.
Tests updated to pin the project-store rehydration for `/import`,
trailing-message preservation, `/clear` id rotation + no-rehydrate, and
profiled-chat attachment delivery.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: a broken knowledge base no longer looks like an empty one, and CI can see the suite
Three findings from an internal audit, all verified by running them.
1. SmartRetriever._search wrapped the knowledge store in
`except Exception: return []` with no log line at all, so a store that
was unreachable, misconfigured or refusing auth produced byte-identical
output to a healthy store with no matches:
BROKEN store -> retrieve() chunks=[] # connection refused
EMPTY store -> retrieve() chunks=[] # genuinely no match
# zero log output, even at DEBUG
The agent then answered from the model's own knowledge and nothing
recorded that retrieval had failed. Knowledge.search itself re-raises
correctly, so the store was honest and the retriever discarded the truth.
RetrievalResult now carries retrieval_failed and error, the failure is
logged at ERROR, and a later success clears the previous error. chunks
is still [] either way, so existing callers are unaffected.
2. Two test modules could not be imported at all. They referenced symbols
moved or replaced months earlier, so 19 tests contributed nothing while
still appearing to exist. test_runtime_middleware.py asked
runtime.registry for the middleware registry, which now lives in
runtime.middleware_registry, and built a RuntimeRegistry where it needed
a MiddlewareRegistry. test_title_gen.py imported _DEFAULT_SMALL_MODEL, a
constant deliberately replaced by a call-time resolver so environment
variables set after import still take effect.
Suite collection goes from 2 errors to clean: 11,847 -> 11,873 tests.
3. Those two modules stayed broken because CI runs 15 of the ~11,900
praisonai-agents tests -- one smoke step naming two files. Every other
job either touches the package for benchmarks, docs and release, or sets
PYTHONPATH at it and then runs a different package's tests. test-core.yml
exports PYTHONPATH=.../src/praisonai-agents and then does
`cd src/praisonai` before `pytest tests/unit/`, which reads as coverage
of both.
Adds agents-collect-gate.yml: collection only, ~40s, no suite execution.
Mutation-checked -- exit 2 on a module-level broken import, exit 0 when
healthy. Deliberately NOT the full suite: 11,900 tests on every PR is a
real compute decision and would go red on arrival, since there are
pre-existing failures nothing has been enforcing. A job that is red the
day it lands teaches people to ignore it.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix: collect-gate now green — guard wrapper-only import, redact query from error log
The agents-collect-gate failed because tests/integration/test_allowed_tools_
filter_integration.py hard-imported praisonai.cli.features.agents at module
level. That wrapper package is not installed when praisonaiagents is tested in
isolation, so the module could not be collected -- exactly the class of dead
module the gate exists to catch, here surfaced as a pre-existing cross-package
import. Guard it with pytest.importorskip, matching the convention every other
cross-package test in the agents tree already uses; the module now skips when
the wrapper is absent and runs unchanged when it is present.
Also address the reviewer security note: the retrieval-failure ERROR log no
longer echoes the raw caller query (which can carry PII/credentials); it logs
the query length plus the store exception, which is enough to diagnose.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: guard concurrent handoffs, AgentTeam re-entrancy, and approval scope leak (fixes#4937)
- handoff: serialize per-target-agent chat_history seeding with a DualLock
(sync + async) so concurrent handoffs to the same target (parallel_handoffs)
no longer interleave and corrupt/leak each other's context.
- AgentTeam: add a Workflow-style _execution_lock re-entrancy guard to
start()/astart() so concurrent runs on one instance fail loudly instead of
silently corrupting shared Task state and swapping callers' results.
- ApprovalRegistry: add release_scope() to evict a dead Agent's per-instance
approval grants; called from Agent.close()/aclose()/__del__ to stop unbounded
growth in per-request/session agents.
Co-authored-by: MervinPraison <[email protected]>
* fix: close concurrency gaps flagged in review (handoff lock race, batch guard, approval scope leak)
Address the P1 concurrency issues raised by reviewers on #4938:
- handoff.py: serialize lazy _handoff_seed_lock creation with a module-level
double-checked-locking guard so racing first-handoffs to the same target
can't each mint a distinct lock. Async seed path now also holds the sync
thread-lock for the whole seeded turn so a cross-thread sync handoff can't
mutate the same shared chat_history concurrently.
- agents.py: make the AgentTeam re-entrancy guard owner-thread-reentrant and
hold it across the WHOLE start_for_each/astart_for_each batch, so per-item
variables/task-state mutations can't interleave with a competing run while
per-item start()/astart() still re-enters on the same thread.
- registry.py: guard the process-global scoped-grant collections with a lock and
mutate release_scope() in place (no rebuild-and-replace race); also evict this
scope's _approved_context approval-cache keys so the leak is fully closed.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Mervin Praison <[email protected]>
---------
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: MervinPraison <[email protected]>
* fix(cli): workflow exit codes, .praisonai path drift, dropped CLI options
Three classes of silent defect in src/praisonai and src/praisonai-code, each
reproduced before the fix and each gated by a test that fails without it.
1. `praisonai workflow run` reported success when every step failed.
Two compounding defects, fixed at both levels.
The engine returned status="completed" for a run whose only step produced
None. `Agent.chat()` returns None when the model call failed and the agent
swallowed the error (an auth 401 is the common case); workflows.py already
logged "Step 'x': Output is None" and then reported the run completed
anyway. That verdict belongs in the engine, not in one CLI: only there is
it known whether the step was LLM-backed (an output is definitionally
expected) or a custom `handler` (which may legitimately return None), and
every consumer of Workflow.start() -- the API server and Python callers as
well as this CLI -- was being told the run succeeded. An agent/action step
producing None is now a step failure, honouring on_error like any other, so
the run does not feed None into the next step either. Handler steps are
untouched. A failed result now also carries `error`, which was absent, so
the CLI printed "Workflow failed: Unknown error".
Separately, the CLI could not fail. grep -c "sys.exit|SystemExit|typer.Exit"
over the 111-print handler returned 0, and the legacy dispatcher hard-coded
sys.exit(0), so even the `❌ Workflow failed` branch exited 0 and
`workflow validate /nonexistent.yaml` exited 0. The handler and its helpers
now return exit codes and the dispatcher propagates them, following the
pattern #4927 established for `hooks`.
Callers: the only in-repo consumer is
.github/workflows/praisonai-pr-review.yml, which runs
`praisonai workflow run .github/praisonai-reviewer.yaml` as its last step.
It will now fail when that workflow actually fails -- which is the point.
`workflow list/help` and a successful run/validate still exit 0.
2. `.praison` vs `.praisonai` -- the #4927 hooks-path bug in nine more places.
`doctor` scanned .praison/skills while `skills list` loads .praisonai/skills:
with both populated, `skills list` showed one skill and `doctor` validated a
different one, and doctor's empty state told users to create the directory
nothing reads.
The siblings are not cosmetic either. `.praison` is the FIRST entry of
paths._PROJECT_MARKERS, so the moment `praisonai thinking set high` creates
./.praison/ in a project whose config lives in ./.praisonai/,
_config_dirname_for flips and the project's .praisonai/config.toml silently
stops being read. Proven: ConfigLoader().load().model.default went from
"from-praisonai-dir" to the built-in default across one `thinking set`.
Rather than correct nine literals, project-local data now derives from one
shared constant -- PROJECT_DATA_DIRNAME in cli/configuration/paths.py, taken
from praisonaiagents.paths.DEFAULT_DIR_NAME -- with
get_project_data_path (writes) and resolve_project_data_path (reads, with a
read-only .praison fallback so nothing saved before this is orphaned).
Applied to thinking, compaction, output-style, file-history, the queue db,
the knowledge vector-store path (config_loader, unified_schema and the three
retrieval.py sites, which had to move together or knowledge would break),
and doctor's skills check, which now derives its locations from the same
praisonaiagents.paths helpers the skill loader itself uses.
The two documented read-only legacy fallbacks in configuration/paths.py and
credentials.py are deliberately left alone.
3. Declared CLI options that were silently ignored.
`memory clear` was the dangerous one: it advertised --force, dropped it, and
had no confirmation prompt at all, so it wiped memory unprompted. It now
confirms first -- matching the `memory learn clear` sibling 170 lines below
in the same file -- and only --force skips it. Its `all` target, named in its
own docstring, was also unreachable; it is now an argument.
Also wired: `todo add --priority` (yielded medium regardless),
`config list --scope` (user and project gave byte-identical output),
`eval accuracy -n/--iterations` (the sibling `eval performance` forwarded it;
the agent also had to move to --agent, which is what the wrapper's parser
declares -- a bare positional made the whole command fail with "unrecognized
arguments"), `serve ui-gateway --agents` (used in its own docstring example,
forwarded only when the installed gateway host accepts it),
`recipe judge --goal` (also in its docstring example; judge_trace grew a
recipe_goal override that wins over the YAML-extracted one),
`code --no-autonomy` (chat wires the identical flag at chat.py:285), and
chat's --continue, --no-acp and --no-lsp (the AsyncTUIConfig fields already
existed and `code` already set them).
`up logs` accepted --service/--follow/--lines, honoured none, printed "not
implemented yet" and exited 0. The three options are removed and it exits
non-zero rather than advertising work it does not do.
The _UNWIRED_CHAT_OPTIONS mechanism is kept and generalised rather than
replaced: it covered 4 of the 13 options chat drops, so the other five that
are still genuinely unimplemented (--tools, --toolset, --user-id, --file,
--output) are now listed and warned about instead of being accepted in
silence. A new test derives the full dropped set from the AST and fails if
any declared option is neither wired nor listed, so the table cannot be a
subset of the gap again. The existing pinning test moved from a line regex
to the AST, because the regex also matched an option name in a comment.
Of the 15 unverified options from the scan, app.py:751 `version` is a false
positive (a typer callback, verified by running `praisonai --version`); the
seven browser_tool.py ones, context.py:84/144, knowledge.py:331, docs.py:1065
and realtime.py:15 are genuinely unread but are not fixed here and are reported
rather than changed blind.
Every gate was mutation-tested: 6 mutations for (1), 6 for (2), 12 for (3), each
confirmed to turn a named test red. Two mutations initially survived (the recipe
--goal source-text assertion, and an ambiguous memory.py anchor that aborted);
both tests were strengthened and re-run until they killed the mutation.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(workflows): hierarchical mode reported success for runs that failed
Follow-up to the same defect as (1): found while verifying that the async path
inherited the fix. `astart()` delegates to the sync `run()`, so it did. But
`process="hierarchical"` is a separate loop that had the reported symptom in
full, via three independent fail-opens.
Reproduced end to end with the same dead API key:
praisonai workflow run h.yaml -> "Workflow completed successfully!" EXIT=0
after this commit:
-> "Workflow failed: Step 'haiku' produced no output (None)" EXIT=1
1. The manager's verdict was parsed with a bare `json.loads`. Models routinely
fence JSON in ```json ... ```, which raises JSONDecodeError -- and the
handler substituted {"approved": True, "reason": "assuming success"}. Proved
with a real call: the manager answered
{"approved": false, "reason": "The output is empty and does not address
the task."}
and the run still reported "completed". Manager validation was a no-op for
rejections whenever the model fenced its reply, which is the common case.
Now parsed with this module's own `_parse_json_output`, which already strips
those fences, and an unreadable verdict fails CLOSED rather than open.
2. When the manager LLM call itself raised (an auth 401, say), validation was
skipped with a warning and the workflow carried on to report success. The
manager is a gate: if it could not run, it has not passed. Since the same
try block now fails closed on an unparseable verdict, failing open on an
exception would be incoherent. Hierarchical mode is opt-in, so a caller who
asked for manager validation gets it enforced.
3. The loop marked every non-raising step "completed" before the manager saw it,
so a step whose agent returned None was never judged at all. The same
LLM-backed-step-produced-nothing rule as the sequential path now applies,
and the per-step record is marked failed too -- not just the run -- because
that record is what `--save` writes out.
The result also now exposes `error` alongside `failure_reason`; the CLI reads
`error`, so a genuine hierarchical failure printed "Workflow failed: Unknown
error".
Four mutations run against the new gates. One initially SURVIVED -- forcing the
per-step status back to "completed" changed nothing observable, because the run
status was still set failed a few lines below and no test asserted the step
record. Added that assertion; it now kills the mutation. A healthy hierarchical
run still completes, pinned by its own test.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(cli): surface continued-failure reason and wire serve ui-gateway --agents
workflows.py: a None-output step with on_error=continue now carries its failure_reason in the step result, so the final error reports the real reason instead of the generic 'step(s) failed' fallback. serve.py: serve ui-gateway --agents now loads the agents YAML into a parsed list and forwards agents=[...] (the gateway host takes a list via configure_host, not an agents_file path); the previous signature check always rejected the option. Fails loudly (exit 2) on a missing/malformed file.
Co-authored-by: Mervin Praison <[email protected]>
* fix(doctor): memory check ignored PRAISONAI_HOME and scanned the legacy dir
The tenth instance of the same drift, found while checking the doctor checks I
had listed as "likely the same defect, left for a follow-up" rather than
assuming. Two of them were worth checking and they did not agree:
- `mcp_checks` is already CORRECT and deliberately so: it resolves
`get_mcp_dir()` / `get_project_data_dir()` first and lists `.praison` below
them under an explicit "Legacy paths for backward compatibility" comment.
Left untouched.
- `memory_checks` hard-coded `~/.praison/...` with no canonical path at all,
exactly as `skills_checks` did.
Reproduced: with PRAISONAI_HOME=/tmp/memproof/home, `praisonai memory add`
stored under /tmp/memproof/.praisonai/memory while
memory_checks._find_memory_dirs()
-> ['/Users/praison/.praison/memory', '/Users/praison/.praison/sessions']
reported neither. The check inspected directories nothing reads and missed the
one that mattered. It now resolves through the same `praisonaiagents.paths`
helpers the memory store itself uses, honours PRAISONAI_HOME, and keeps the
legacy `~/.praison` entries only as an additional read location after the
canonical ones so existing installs still report. Duplicates are suppressed.
Gated by three tests asserting against the shared constant, and mutation-tested:
reverting to the hard-coded `.praison` list turns two of them red.
`praisonai doctor` still exits 2 here with the same six failing checks as
origin/main -- verified against a baseline worktree at this branch's parent, so
the exit code and check set are unchanged.
Co-Authored-By: Claude Opus 5 <[email protected]>
* test(serve): pin the real --agents contract that my first fix got wrong
My `serve ui-gateway --agents` fix in the first commit was broken, and the
triage bot's 69769cbdd8 corrected the implementation. This corrects the test I
had written against my own wrong assumption, so the mistake cannot come back.
What I got wrong, verified against praisonai-bot:
run_integrated_gateway(*, port, host, static_dir, ui_config, **configure_kwargs)
-> configure_host(*, ..., agents: Optional[List[Any]] = None, ...)
so the parameter is `agents` and it takes a PARSED LIST. I passed
`agents_file=<path>` -- wrong name and wrong type -- behind an
`inspect.signature(...).parameters` guard. That guard can never match a
`**kwargs` function, so the option was rejected 100% of the time and my
"an older gateway that cannot take it fails loudly" test was asserting the
failure path as though it were the compatibility path. It passed for the wrong
reason.
The tests now assert the real contract: a parsed list of Agents reaches the
gateway under `agents`, no path is passed under `agents_file`, a
missing/malformed/agent-less file fails loudly without starting the gateway,
and the other options still get through.
Added a test that reads the ACTUAL `configure_host` signature (skipped when
praisonai-bot is not importable). A stub-based unit test structurally cannot
catch "we pass a kwarg the real function rejects", which is precisely how the
first attempt slipped through.
Three mutations, all killed -- including restoring my original broken
agents_file/signature-guard version, which turns five tests red.
Co-Authored-By: Claude Opus 5 <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(workflows): loop body output_variable results were silently discarded
Sibling of #4932. `_execute_loop` handed every iteration its own
`copy.deepcopy(all_variables)` and threw the copy away when the iteration
ended, in both the sequential and the parallel path, so every
`output_variable` a step inside a `loop()` wrote was silently lost while
the run still reported "completed".
Only `loop` lost it - the control set is the proof:
parallel inner='I' control='AFTER'
repeat inner='I' control='AFTER'
if_ inner='I' control='AFTER'
route inner='I' control='AFTER'
loop inner=None control='AFTER' <- both modes
`loop_outputs` is not the aggregate that recovers it: it only holds each
iteration's *last* step's output, so an earlier step's `output_variable`
in a multi-step body, and any `StepResult.variables` write, had nowhere
left to be read from.
Sequential loop: no concurrency, so nothing to isolate from. It now runs
against the shared scope exactly like Repeat/If/Route - the loop is its
body unrolled - which also lets iteration N see iteration N-1's writes.
Parallel loop: isolation is required (concurrent writes to one dict is a
data race), so it reuses `_WriteTrackingDict` and `_merge_branch_variables`
from #4932 and merges each iteration's delta in *item* order, never
completion order. A cross-iteration collision is inherent to looping
rather than an authoring accident, so it is not warned about;
`warn_on_collision` keeps Parallel's warning unchanged.
Both modes therefore end on the last item's value, and the loop's own
control variables (`item`/`var_name`, `loop_index`, `item.<key>`) stay
loop-scoped in both. The parity is pinned by a named test so neither side
can be "fixed" into a race or back into silent loss.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(workflows): clear stale flattened item.<key> between sequential loop iterations
A sequential loop runs against the shared scope, so a flattened item.<key>
accessor written for one dict item lingered while iterating a later item that
omits that key - the body would read the previous item's value. Drop the prior
item's flattened control keys not present in the current item before updating.
Fixes greptile P1 on PR #4947.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Address reviewer feedback on #4948:
- P1 (hooks.py): the ContextVar held a mutable list mutated in place, so a
copied/child context (create_task/to_thread/copy_context) shared the same
list object and could cross-finalize a sibling run. Treat the stack value as
immutable — readers get a copy, writers set a new list via _push_run/
_pop_run/_remove_run — restoring genuine per-context isolation.
- P2 (_lazy_cache.py): add regression coverage for transient cool-down
(cached before expiry, retried after expiry), structural permanent caching,
and reset clearing the failure-timestamp map.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
1. db/adapter.py: run/agent/trace/span completion hooks did a two-call
get-then-set that raised (and was silently swallowed) inside a running
loop, stranding records as status="running". Route the whole
read-modify-write through one coroutine (_merge_and_set) so the write
half always executes — as a tracked fire-and-forget on the bridge inside
a loop, blocking otherwise.
2. observability/hooks.py: replace threading.local() run-stack with a
ContextVar so concurrent asyncio tasks on one worker thread no longer pop
each other's runs (void-signature finalize).
3. _lazy_cache.py: give transient loader failures (OSError/ConnectionError/
TimeoutError) a 30s cool-down instead of caching every BaseException for
the process lifetime; add a scoped retry_cooldown constructor.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: MervinPraison <[email protected]>
* fix(bot): declared platform wins, slack can start, bots stay up, failures exit non-zero
Four defects in src/praisonai-bot, three of them silent.
1. `praisonai bot start` started a DIFFERENT bot than the config declared.
The single-bot migration in `_config_schema.py` required an inline
`token:` (`if self.platform and self.token and not self.channels`).
Supplying the token via the environment — the documented way — failed
that guard, so the declared `platform:` was dropped, `channels` stayed
empty, and `_autofill_channels_from_env()` invented channels from
whatever unrelated credentials happened to be exported.
Reproduced: a config saying `platform: telegram` with only
`DISCORD_BOT_TOKEN` in the environment attempted a Discord login
(`discord/http.py … 401 Unauthorized`), with no warning that
`platform:` had been ignored.
The declared platform now wins wherever its token comes from, and when
the config names one platform, credential autofill refuses to bring up
any other — logging a WARNING that names each one it skipped instead of
silently replacing the operator's choice. Nothing new is discovered
from the environment: a tokenless `platform: telegram` resolves exactly
`${TELEGRAM_BOT_TOKEN}`, the variable that platform already documents.
2. `praisonai bot slack` could not start at all. `bots_cli.py` passed
`app_token=` to `BotConfig`, which has no such field:
`TypeError: BotConfig.__init__() got an unexpected keyword argument
'app_token'`. Also fired via `bot start` on any Slack channel.
Fixed by dropping the bogus kwarg rather than adding the field —
`SlackBot.__init__` already takes `app_token` and Socket Mode reads
`self._app_token`, so a `BotConfig` field would have been dead weight,
the same defect one layer along. Socket Mode without an app token
subscribes to nothing, so a missing one is now a hard error instead of
a warning followed by a bot that can send but never receive.
3. `praisonai bot linear` exited 0 in under a second and never served.
`LinearBot.start()` arms an aiohttp TCPSite and returns;
`asyncio.run(bot.start())` then closed the loop, tore the socket down,
and the command exited 0 having printed "Press Ctrl+C to stop". A
systemd or daemon wrapper saw a clean exit and did not restart it.
`email`, `agentmail` and `webhook` have the same shape. A `_serve_bot`
helper — mirroring the fix already in `Bot.start()` for #2869 — now
holds the loop open while the adapter reports `is_running`, for all
seven start paths. Verified with a live probe: the Linear webhook
endpoint answers HTTP 200 and the process stays up.
4. Twenty failure paths in `bots_cli.py` exited 0. `grep -c
"typer.Exit\|sys.exit"` returned 0 against 20 `print("Error: …");
return` sites, so `bot start --config /nope.yaml` and `bot email`
with no password both reported failure and exited 0.
Nineteen fatal sites now route through `_fail()`, raising a
`BotStartupError(SystemExit)` so every caller — Typer, the legacy
argparse dispatcher, a supervisor — sees a real non-zero exit. The
twentieth (`_load_agent`'s degrade-to-default-agent fallback) is a
deliberate no-op and is left alone.
Also settled: `bot <platform>` exposed 7 platforms while the registry has
10. `signal`, `webhook` and `local` ship adapters with no verb, reachable
only through `bot start` YAML — and `start_from_config`'s if/elif chain
fell off the end for them, printing nothing and exiting 0. Added a
generic `praisonai bot run --platform <name>`, which also gives
entry-point and drop-in plugin channels a first-class verb, and routed
`bot start`'s fallthrough into it instead of the silent no-op.
Why CI missed all of this: the `bots-gateway` shard collects
`tests/unit/{bots,gateway,cli,daemon}/` only, so
`src/praisonai-bot/tests/unit/test_bots_cli.py` — the one existing
CLI-surface suite — was collected by no workflow at all. That file is
now named in the shard, and the new tests live under `tests/unit/cli/`.
Tests: 22 new tests in `tests/unit/cli/test_bot_cli_defects.py`. Defect 1
asserts the resolved platform, not log text; defect 4 asserts exit codes,
not messages. All 18 mutations — each reintroducing one defect, every
anchor asserted present before it was applied — are killed by a named
test. Full bot suite: 2199 passed; the 4 remaining failures are
pre-existing on origin/main and environment-dependent.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(bot): forward adapter-specific channel config through generic start path
The generic `bot start` facade copied only `webhook_port`, silently dropping
the Webhook adapter's `verify` (no env fallback) — replacing a configured
signature verifier with the unverified default — and Signal's `account`/
`bridge_url`. Forward the channel's `model_extra` (where `extra="allow"`
preserves adapter-specific keys) so a YAML-configured generic channel reaches
its adapter with the same fidelity as the gateway/BotOS path. Adds two
regression tests asserting the fields reach the Bot facade.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(ts): stop 13 observability adapters claiming to send telemetry they discard
Twelve external observability adapters were 23-line shells and LangSmith a
71-line one. All of them set `isEnabled = true`, delegated every trace and span
to the in-memory adapter, and shipped an empty `flush()`. No network call, no
API key read, no endpoint. A user who checked `isEnabled`, or who called
`flush()` before exit, was told everything was fine while nothing left the
process.
LangSmith deserves a specific note: it dynamically imported the `langsmith` SDK
and constructed a Client in `initialize()`, then assigned it to a private field
that no other method ever read. It was a stub with decoration, not a partial
implementation, so it is treated as one.
Langfuse - the only adapter with real delivery - had the same bug in milder
form: it hardcoded `isEnabled = true` even when the optional SDK was absent and
its client was null, which is the common case since `langfuse` is not a
dependency of this package.
Chosen route: tell the truth rather than half-implement. The OTLP-compatible
vendors were considered for a real implementation and rejected, because this
package depends on `@opentelemetry/api` only - the instrumentation API, which
carries no SDK, span processor or exporter and cannot ship a span anywhere.
Real delivery would mean adding exporter dependencies and shipping six
per-vendor endpoint/auth conventions that cannot be verified against the live
services from here. An adapter that posts on some paths and drops on others is
the same defect with more code.
- New `UndeliveredObservabilityAdapter` base: `isEnabled = false`, warns on
construction naming the adapter, and `flush()` warns instead of resolving
silently. The 13 non-delivering adapters now extend it and are 15 lines each.
- Langfuse `isEnabled` is derived from a live client rather than hardcoded, and
its `flush()` warns when no client was ever created.
- `ObservabilityToolInfo` gains `delivers`; `features.export` is corrected to
false for every tool that cannot export.
- The CLI stops lying: `observability test <tool>` no longer prints "Test
Passed" (and no longer returns `success: true` in JSON) for a tool that
delivered nothing, and `doctor` no longer reports "Ready" for a tool whose
API key cannot change the outcome.
- The factory's 13 per-vendor functions carried "X not available, install X"
warnings in catch blocks that could never fire, since the imports are local
modules that always resolve. Replaced with one honest loader table.
- Removed `src/observability/index.ts.new`, a tracked 0-byte leftover.
Tests discover adapters from disk rather than naming them, so a fifteenth
adapter added later is covered on the day it lands - verified by dropping a
hollow `newrelic.ts` into the tree and watching five gates fail. Nine mutations
(re-enabling an adapter, deleting the warning, silently resolving `flush()`,
faking the registry, and three CLI regressions) were each killed by a named
test, with every mutation anchor asserted present before it was applied.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(ts): make observability delivery reporting internally consistent
Address reviewer feedback on PR #4941:
- list: 'ready' now requires delivers||no-envKey, matching the doctor
aggregate, so a keyed non-delivering tool (weave) is not counted ready.
- test: 'delivered' now means reached an external backend (registry
delivers && isEnabled), not merely isEnabled. Built-in local recorders
(memory/console) report success:true, delivered:false, status:'recorded'.
- langfuse: shutdown() now nulls the client so a cached/reused instance
reports isEnabled false instead of advertising a terminated transport.
Tests updated to assert the honest built-in semantics and added a
shutdown regression gate (16 external-adapter tests, full suite green).
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Two shipped placeholders returned success for work they never did. Both are
in the published crate, and both were covered by tests that asserted the
fabrication rather than the behaviour.
RAG::query returned Ok(..) containing:
- a fabricated answer, "Answer to: {question} (based on retrieved context)"
- a fabricated chunk, "Sample retrieved content for the query."
- a confidence score of 0.95 on that chunk
- a fabricated citation pointing at "knowledge_base"
The score and the citation are the damning part: they are precisely what a
caller inspects to decide whether to trust an answer, and both were invented.
Nothing distinguished this from real retrieval. It now returns an error
naming what is unbuilt.
Judge::judge ignored all three of its arguments and returned a hardcoded
score of 0.8 with passed=true, disregarding the threshold set by
with_threshold() -- a gate that could not fail, passing every output put
through it. Its signature returns a bare JudgeResult rather than a Result, so
it now fails CLOSED: score 0.0, passed=false, and a reasoning string saying
why. Failing closed is the safe direction for an evaluation gate.
The two tests asserted the fakes -- `!answer.is_empty() && !citations.is_empty()`
was satisfied by the fabricated citation, and `assert!(result.passed)` by the
hardcoded true. Both now assert the honest behaviour. The module docs state
the status so a reader of the API sees it before calling.
465 crate tests pass; cargo build clean.
Co-Authored-By: Claude Opus 5 <[email protected]>
Small local models routinely answer with the tool call as JSON *content*
instead of populating tool_calls - especially after a repair prompt. Recovering
those is one of the things PraisonAI does that no other framework does; a
ten-framework source review found the case handled nowhere else.
get_response has recovered them since the adapter seam landed. get_response_async
never did. So the same agent, same model, same prompt silently stopped calling
tools the moment the caller awaited instead of called - with no error and no
log line, just an answer that ignored the tools.
A full audit of the three response paths found 11 of 15 compensations present in
sync and missing from at least one other path. This closes the one that is both
highest-impact and structurally identical between the two paths; the rest are
tracked separately because each changes a contract.
The guard stays adapter-driven, so hosted providers are unaffected:
DefaultAdapter returns None and a hosted model's JSON prose stays prose.
Verified: the new test fails without the change and passes with it; 493 + 201
tests pass; live sync and async baselines byte-identical.
Co-Authored-By: Claude Opus 5 <[email protected]>
The merge gate allowed pull_request_read/issue_read but the GitHub MCP
server exposes get_pull_request, get_issue, etc., so Opus could not read
CI status or reviews and always posted BLOCK on merge-ready PRs.
Co-authored-by: Cursor <[email protected]>
* fix(workflows): merge parallel branch variables back into the shared scope
Every step inside a `Parallel` block that set `output_variable` had its result
silently discarded. `_execute_parallel` hands each branch
`copy.deepcopy(all_variables)`, and the write at the end of
`_execute_single_step_internal` ("the same variable-scoping guarantee the
top-level loop provides") landed in that copy, which was thrown away when the
branch returned:
branch_a_output present False
branch_b_output present False
after_output (control) True
The deep copy is deliberate - concurrent branches writing one shared dict is a
data race - so the isolation stays; what was missing is the merge back.
The merge rule, documented in `_merge_branch_variables` so it is not
"simplified" back into a race:
* Only the delta a branch actually wrote is merged (keys added, or keys whose
value changed), so an untouched variable keeps the parent's own object rather
than a per-branch clone.
* Deltas are applied in branch declaration order, never completion order, so
the outcome does not depend on thread scheduling.
* On a key collision the later branch in declaration order wins - what the same
steps would produce run sequentially - and the collision is logged as a
warning naming the key and both branches, because a silently dropped branch
result is exactly the bug being fixed.
* `on_failure="partial_ok"` keeps the variables a failed branch had already
written (partial means partial); `fail_fast`/`fail_all` raise, so they merge
nothing.
`Loop` is a different case and is deliberately left alone: N iterations share
one step name, so per-iteration variables stay iteration-scoped and the
aggregate is exposed through the Loop's own `output_variable`/`loop_outputs`.
Parallel and sequential loops already behaved identically; a parametrised test
now pins that parity so neither side gets "fixed" into a race.
Tests: tests/unit/workflows/test_parallel_branch_variables.py - 7 of its 11
tests fail on the pre-fix code (including the exact probe above with its
control assertion) and all 11 pass after. Nine mutants of the merge (removed,
drops first/last branch, reversed order, whole-dict merge, partial_ok drop,
default-name filter, warning suppressed, existing-key skip) were each asserted
to have a unique anchor before being applied and were all killed.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(workflows): detect parallel branch writes by assignment, not value
Value-equality delta detection dropped an equal-valued output_variable
write (a later branch writing a variable back to its baseline value lost
declaration-order precedence) and misclassified an untouched value whose
`!=` is not a bool (numpy arrays, some ORM/pydantic objects) as a write,
replacing the parent object with a branch-local clone and emitting a false
collision warning. Object identity would still miss a rebind to an interned
immutable (`x = "SAME"`).
Track writes at the assignment via a _WriteTrackingDict so the merge back
knows exactly which keys a branch bound (output_variable, StepResult.variables
merge, nested pattern merge) regardless of value. Adds regression tests for
the equal-valued write and the non-bool-inequality untouched value.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix: never drop an attachment silently
_build_multimodal_prompt matched five image extensions and had no else
branch, so agent.chat(attachments=["report.pdf"]) appended nothing -- no
part, no warning, no error. The model answered from the text prompt alone
and the caller could not tell the file was ignored. A mistyped path
failed just as quietly, as did pathlib.Path attachments, directories,
non-image URLs, non-image data: URIs and video.
Routing moves to praisonaiagents/agent/attachments.py with one invariant:
an attachment either becomes a model-visible content part or produces a
loud signal. The split is on who can act on it, not on severity.
Addressing errors raise AttachmentError (a ValueError subclass, so
existing handlers still catch): the path does not exist, is a directory,
is unreadable, or is not a str/PathLike/dict. These are always caller
mistakes and there is no useful degraded answer -- continuing means the
model confidently discussing a document it never saw. The message names
the path and the cwd, since a relative path resolved from an unexpected
directory is the usual cause.
Capability limits warn and degrade visibly: the file is readable but the
target model cannot ingest that type. A logging.warning names the file,
model and remedy, AND a marker part is injected into the prompt so the
model knows too and can say it answered without the file. A log line
alone would still leave the answer looking complete.
PDF, audio and ~45 text/code extensions are now routed per model
capability via new supports_pdf_input / supports_audio_input /
supports_vision helpers. PDF degrades by local text extraction, labelled
as such. Images are unchanged, byte for byte.
Co-Authored-By: Claude Opus 5 <[email protected]>
* feat: scriptable test model and a no-network guard
Nothing shipped let a user unit-test an agent offline. The repo's own
pattern is hand-rolled per test -- LLM.__new__(LLM) followed by assigning
twelve private methods -- repeated across three files.
ScriptedModel subclasses the real LLM and replaces only the
provider-facing methods, so system-prompt assembly, tool-schema
serialisation, the tool-execution loop, tool-result messages, streaming
and async all run production code. Replies are real litellm
ModelResponse objects, parsed by the same path as a live response, so the
double cannot drift from reality. It records requests, scripts tool calls,
and raises ScriptExhausted rather than hanging or inventing a reply.
allow_model_requests(False) blocks every real provider call at the 6
litellm request sites and both OpenAI client properties, and names the
offending call site -- which needed a frame walk, since requests are
dispatched through an asyncio loop on a worker thread.
Fixes a bug found while building this: Agent(llm=<model object>) fell
through every branch to the plain OpenAI path, leaving self.llm set to
the object itself and _using_custom_llm False, so every turn went to
OpenAI under a model name that was really a repr(). Passing your own
model did the opposite of what it means.
Both new error types derive from BaseException on purpose: the tool
loop's broad `except Exception` would otherwise turn "your script is one
reply short" into a silent None return.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix: feed guardrail rejections back into the live conversation
_apply_guardrail_with_retry already retried on validation failure, but it
threw the conversation away: on rejection it built one fresh user message,
prompt + "Note: Previous response failed validation due to: ...", and sent
that alone. The system prompt, retrieved context, tool results and the
rejected answer never reached the retry. Proven against pristine code --
the second request was a single-element message list.
So the missing capability was never retry; it was feedback into the live
conversation. The retry now appends the rejected assistant turn plus the
reason as a user turn and re-calls with the full history, bounded by the
max_guardrail_retries that already existed. No competing setting is added.
Validators signal rejection the way they already could, by returning
(False, reason). GuardrailRetry is added for validators whose check fails
several frames down -- a Pydantic parse, a lookup helper -- whose message
was previously mangled into "Agent guardrail validation error: ...".
The whole-task layer had the same disease: AgentTeam re-ran tasks with the
identical prompt, logging the guardrail reason and dropping it. It now
fills the Task.validation_feedback slot that already existed, so
Process._build_task_context renders it into the re-run. Reuse of existing
wiring, not new wiring.
Two fixes fell out: the retry passed stream=True regardless of agent
config (the sync path logged an ERROR and fell back on every retry), and
GuardrailChain buried the rejection under "Guardrail error: ...".
Regenerates the parity tracker, which records GuardrailRetry as a new
praisonai-ts gap (count 0 -> 1) pending a TypeScript follow-up.
Co-Authored-By: Claude Opus 5 <[email protected]>
* chore(parity): regenerate tracker for the new Python exports
Merging the three fixes made the tracker stale in a way none of the
individual branches showed: each was regenerated before the others
existed. Records 6 praisonai-ts gaps (GuardrailRetry plus the five
model_harness test-double exports), up from 0.
Recorded rather than avoided. Withholding the exports to keep the count
at zero would game the measurement instead of reporting it; Python is the
source of truth and TypeScript follows in a separate PR, which is exactly
the state this tracker exists to make visible.
Co-Authored-By: Claude Opus 5 <[email protected]>
* feat: per-tool guardrails
Guardrails were agent-wide: _tool_call_guardrails / _tool_result_guardrails
are fed only from Agent(guardrails=...) and fire for every tool. Approvals
gate calls interactively. Nothing sat between them, so validating one
tool's arguments -- rejecting a send_email whose recipient is off-domain --
meant hand-wrapping the function.
Adds input and output guardrails scoped to a single tool, declared
alongside the approval and trust options a tool already carries. An input
guardrail sees the arguments before the tool runs and may block or rewrite
them; an output guardrail may block or substitute the result. A blocked
call feeds a message back to the model rather than raising at the user.
Built on the existing GuardrailResult and GuardrailChain rather than a
second guardrail system, so there is one vocabulary for a validation
outcome. Ordering relative to the approval gate and the trust fence is
chosen for safety and documented at the call site.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix: block model requests by scope depth, not a shared snapshot
no_model_requests() saved and restored the single _allowed boolean, so two
overlapping scopes (or cross-thread scopes) could re-enable requests while
another scope was still open, leaking a real provider call. Track active
scopes with a counter instead: requests stay blocked until every open scope
exits. Adds regression tests for overlapping and globally-allowed cases.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Mervin Praison <[email protected]>
* chore(parity): waive the two new tool() guardrail parameters, with an expiry
CI's signatures gate failed on tool().input_guardrails and
tool().output_guardrails: both are new Python parameters with no
TypeScript counterpart.
These waivers are marked NOT an equivalence. Every other reason in
waivers.yaml documents two SDKs reaching the same result by different
routes, validated by running both. These record a real gap instead --
nothing in praisonai-ts resolves the same behaviour. They exist only to
unblock this PR, because porting is a praisonai-ts change and the two
packages do not share a branch.
Both carry expires: 2026-12-07. An expired waiver fails the check, so if
the TypeScript port is forgotten the gate goes red rather than the gap
quietly becoming permanent.
Co-Authored-By: Claude Opus 5 <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(local): use the measurements the local layer already takes
A competitor review read the source of ten frameworks - CrewAI, Agno, AutoGen,
LangChain/LangGraph, LlamaIndex, Haystack, Pydantic AI, the OpenAI Agents SDK,
smolagents and DSPy - and reached one conclusion: PraisonAI's local *sensing* is
the best of the field, and its local *acting* is the weakest. Nobody else
auto-discovers a server, asks it what a model can do, or tracks whether a
capability was observed or guessed. And PraisonAI then threw all of it away.
Every fix here is plumbing. No new probing, no new dependency, no new
abstraction - just connecting a measurement that was already taken to the
decision it should drive. Each was reproduced before being fixed.
1. Context window. get_model_limit("ollama/qwen3:0.6b") returned 128000, the
generic default, while the server reports 40960 - a 3x over-budget that
makes compaction never fire and lets the server drop the head of the
conversation. The real number was already sitting in LocalTarget.extra.
A 4096-context model was being budgeted at 31x its real room.
2. Embedding width. local_embedder_config emitted no dimension at all, so a
store was built at whatever the first vector happened to be. The correct
table already existed. local/ is a dependency sink and cannot import it, so
the caller supplies it; an unknown width is omitted rather than guessed.
3. Union-typed tool parameters. Ollama models parameters.type as a Go string,
so an Optional[str] argument produces ["string","null"] and 400s the WHOLE
request. The quirk table has recorded this as severity HARD since the day it
was written. Local adapters now collapse the union; hosted providers keep
the full schema.
4. format + tools. Measured three times, by me and by two independent reviews:
sending a JSON grammar with tools makes the tool call unemittable, so the
model fabricates a confident answer and returns it with HTTP 200. The quirk
note prescribes "raise - a confident fabrication is worse than an error".
Now it does, for local engines only.
Fixes 3 and 4 are the first two consumers the quirk table has ever had.
Verified: 715 praisonai + 201 agents-package tests pass; 14 new tests; live
Ollama end-to-end unchanged for Ollama and untouched for hosted providers.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(embedding): give nine locally-served embedders their real width
They were silently inheriting DEFAULT_DIMENSION, which is OpenAI's 1536:
bge-m3 1536 -> 1024
bge-large 1536 -> 1024
bge-base 1536 -> 768
bge-small 1536 -> 384
snowflake-arctic-embed 1536 -> 1024
snowflake-arctic-embed2 1536 -> 1024
granite-embedding 1536 -> 384
paraphrase-multilingual 1536 -> 768
qwen3-embedding 1536 -> 1024
Harmless while nothing read the value. Not harmless now that this commit's
parent makes it size the vector store: a store built at 1536 for a 1024-wide
embedder rejects every write.
Also stop passing the generic default through as if it were measured. An
unknown embedder now omits the width entirely and lets the store infer it from
the first vector, which is right for every model present and future. The
default stays in get_dimensions() so callers can still distinguish "unknown"
from "measured".
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(local): preserve measured embedding width; only collapse nullable unions
Two reviewer-flagged correctness gaps in the measurement plumbing:
1. Measured embedding dimension was overwritten. local_embedder_config already
carries the server-measured embedding_dims; agent.py then unconditionally
replaced it with the static dimension table, which returns the generic 1536
for any unknown local model. A measured width is authoritative and now wins;
the static table only fills a genuine gap.
2. Heterogeneous unions were narrowed. collapse_union_param_types collapsed any
list-valued type to its first member, so a real union like
[string, integer] lost the integer arm and misrepresented the tool's
accepted inputs. Now only the nullable case (type + null) collapses; genuine
multi-type unions are preserved.
Added two regression tests covering both directions of the union rule.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(ts): RealtimeAgent.connect() opens a real WebSocket
connect() set connected = true and emitted a fabricated session.created
without opening any socket, while the Python RealtimeAgent genuinely
calls websockets.connect(). Nothing listening, an unresolvable host and a
401-refused handshake all reported success.
connect() now builds wss://api.openai.com/v1/realtime?model=<llm>,
constructs the socket, and resolves only on the open event -- error,
close-during-handshake and timeout all reject. this.ws and this.connected
are set only after open. session.created is no longer fabricated; every
emitted event is parsed off the wire, and unknown server event types pass
through verbatim. isConnected() reads the live socket readyState.
sendText/sendAudio now send the real conversation.item.create +
response.create and input_audio_buffer.append frames, and throw when not
connected rather than emitting a local echo.
The WebSocket implementation is resolved via injection, globalThis, then
the ws package through a computed specifier so it stays off every
bundler's static graph.
Replaces a test that asserted the bug: "should emit events on connect"
required the fabricated session.created, so it passed while the feature
did nothing.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(ts): wire db("sqlite:") to the DbAdapter contract
db("sqlite:./data.db") threw "not yet wired to the DbAdapter contract"
while src/index.ts:26 advertised exactly that call in the quickstart.
Adds SqliteDbAdapter implementing the full DbAdapter contract (sessions,
messages, runs, tool calls, traces, spans) on a SQLite file, with two
drivers tried in order: better-sqlite3, then Node's built-in node:sqlite.
There is no memory fallback on any path -- if no driver opens the file,
every operation rejects with a message naming each driver's failure and
the fix. Behaviour is matched to MemoryDbAdapter so swapping backends
changes only durability.
postgres:// and redis:// still throw by design: both are remote-only HTTP
transports exposing query/get/set rather than sessions/messages/runs.
Their errors now point at db("sqlite:") as the working durable option.
Also fixes a .gitignore trap: the bare `db` rule on line 18 ignores any
directory named db, so tests/unit/db/ was silently untracked -- the new
durability suite would have passed locally and never been committed.
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(ts): CI Buffer type, realtime connect/disconnect races, sqlite schema check
- minimal-ws-server: annotate `buffered: Buffer` to resolve @types/node 22.20
generic Buffer<ArrayBufferLike> vs Buffer<ArrayBuffer> mismatch that failed
the unit-test suite compile (the CI failure).
- RealtimeAgent: serialize connect() so concurrent callers share one handshake;
track the in-flight socket and a connect generation so disconnect() cancels a
handshake still in flight instead of it later marking the agent connected.
- sqlite-adapter: REQUIRED_COLUMNS now lists every column each INSERT/UPDATE
touches, so a partial legacy schema is diagnosed on open() rather than failing
the first write.
- Tests: concurrent connect/disconnect lifecycle, ws-fallback via injectable
loader (ws is transitive here so absence cannot be assumed), partial-schema
diagnosis.
Co-authored-by: Mervin Praison <[email protected]>
* fix(ts): isolate realtime onMessage/onAudio callbacks from throwing handlers
A throwing user callback in the response.text.delta / response.audio.delta
loops escaped handleMessage, skipping later callbacks and preventing the
wildcard emit for that frame. reportError and emit already isolated handlers;
these two loops did not. Route both through a shared invokeCallbacks helper
with the same try/catch isolation, and add a regression test.
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
* fix(code): stop `praisonai code` truncating mid-task and reporting success
Four linked defects meant `praisonai code` could not finish a coding task,
and nothing could tell that it hadn't. All four were reproduced end-to-end
before being changed; each fix has a named test that fails without it
(16/16 mutations killed).
(b) A truncated run reported success. `_run_print_code` classified any
non-empty string as `status: "ok"`, exit 0 — but a budget-exhausted turn
returns a non-empty wrap-up summary, so truncation was indistinguishable
from completion. Measured before:
$ praisonai code -p --output json "...make the tests pass"
{"result": "Tool call limit reached (10 calls)...", "status": "ok"} exit 0
$ pytest -q -> 6 failed, 2 passed
Now `status: "truncated"` and exit 2, reusing `run._run_was_truncated`
rather than adding a second, drifting guard. Same run after: exit 2.
(c) `--dangerously-skip-approval` did not skip approval. It set
PRAISON_APPROVAL_MODE/PRAISONAI_TOOL_SAFETY, which the gate that actually
prompts (the core `@require_approval` decorator, resolving through the
approval registry backend) never reads. With stdin at /dev/null every
prompt was auto-denied, so the agent could not run one shell command —
while still exiting 0. Measured on one task, stdin /dev/null:
before 2 prompts / 2 denials / `1 failed`; after 0 / 0 / `1 passed`.
Fixed by registering AutoApproveBackend the way `--plan` already
registers its own backend — one mechanism, not a second env var. Strictly
opt-in: the safe-by-default branch is unchanged and now also clears a
bypass left by an earlier --no-safe call in the same process. A per-agent
backend (`--plan`, `--agent` scope) still wins, and --plan remains
mutually exclusive with the opt-outs; both are covered by tests.
(a) The step budget was general-purpose, not coding-sized, and unreachable
from the CLI. Two loops enforce different knobs — the LiteLLM loop caps at
`max_tool_calls_per_turn=10` (Gemini-routed run stopped at exactly 10
calls), the OpenAI-native loop at `max_steps`/`max_iter=20` — and
`praisonai code` set neither. Ten calls is "list files, read two files,
one grep"; it cannot reach a test run. Adds `--max-steps` (env fallback
PRAISONAI_CODE_MAX_STEPS) defaulting to 200 for a coding session, raising
*both* knobs, applied to the headless and interactive paths. The core
ExecutionConfig defaults are deliberately left alone so no library user's
behaviour changes. End-to-end on the 8-module repro: previously 6 failed /
2 passed with `status: "ok"`; now 8 passed.
Also fixes the remediation text at run.py:168, which told users to
"Re-run with a higher --max-iter" — a flag with 0 occurrences in the CLI
(control: `--model` = 56).
(d) The gate that would have caught all of this has been red for months. The
Terminal-Bench smoke workflow pinned Python 3.11; harbor requires >=3.12,
so `pip install harbor` resolved to no candidate and every scheduled run
died in ~15s (confirmed 2026-07-27 through 2026-09-07, every week).
RESULTS.md still says `_pending first run_`, accurately: no
Terminal-Bench score has ever been produced. Bumped to 3.12 (verified:
harbor 0.22.0 resolves cleanly on 3.12) and dropped the `|| true` that
would hide a real harness failure. The first honest run may well be red —
that is the point.
Refs #3932
Co-Authored-By: Claude Opus 5 <[email protected]>
* fix(code): apply --max-steps budget on profiled and wrapper-dispatched paths
Closes two Greptile P1 gaps in PR #4930 where the new coding step budget
was silently dropped:
- --profile/--profile-deep built the Agent with no ExecutionConfig, so a
profiled coding run kept the general-purpose core defaults (20 steps /
10 tool calls per turn). Thread build_code_execution_config(max_steps)
into _run_profiled_code.
- The wrapper legacy dispatch (_run_chat_mode / _start_interactive_mode)
never read args.execution, so the common `pip install praisonai`
interactive/single-prompt sessions ignored --max-steps. Thread
args.execution onto the Agent in both interactive_legacy build sites,
mirroring the existing args.agent_approval pattern.
Adds regression tests locking in both paths.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Mervin Praison <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Four independently reproduced CLI defects, each with a gate that fails before
the fix and a mutation run confirming a named test goes red.
1. `praisonai hooks add` printed "Unknown hooks action: add" and exited 0, so a
script that added a hook succeeded while doing nothing (same for `remove`).
The handler now returns a real exit code and the legacy dispatcher exits
with it instead of a hard-coded `sys.exit(0)`. The Typer group advertised
`add`/`remove` (never implemented) and omitted `init`/`stats` (which work);
it now registers only what the handler accepts, so `hooks add` exits 2.
2. `hooks list` told users to create `.praison/hooks.json` while
`HooksManager.CONFIG_FILE` is `.praisonai/hooks.json`, and `hooks init`
wrote that same wrong path — so init-then-list never saw the hooks. Both
now derive the location from `HooksManager.CONFIG_FILE`, and the round trip
works.
3. `plugins discover`'s empty state pointed at `praisonai plugins init <name>`,
which does not exist; the command is `create`. The hint is now derived from
the Typer app's own command registry.
4. `praisonai call` accepted only `--model`/`--verbose`, so `--public` (the
ngrok exposure inbound PSTN requires) and `--host` were reachable only via
environment variables. `--public`/`--port`/`--host` are now wired through
the Typer command to `api/call.py:main()`. Port and host are forwarded only
when typed: the shared argparse default is 8005 while the call server's own
is `$PORT` (else 8090), so unconditional forwarding would have silently
retargeted the port.
No security guard is weakened by (4). `--public` reaches the same code path
`PUBLIC=true` already reached; `run_server` still forces the bind to 0.0.0.0
and publishes it as `PRAISONAI_CALL_BIND_HOST`, which keeps
`PRAISONAI_CALL_AUTH=disabled` refused for a non-loopback bind, and both the
inbound-call route and the media-stream socket still fail closed when
`CALL_SERVER_TOKEN` is unset. Two tests pin that.
Co-authored-by: Claude Opus 5 <[email protected]>
- aembed/aembedding/aembeddings now delegate to the real async embedder in
llm/embeddings instead of the throwing sync placeholder, so the public async
API returns real vectors rather than always rejecting (Greptile P1).
- Replace brittle source-text inspection in embedder-is-real.test.ts with a
runtime test that constructs ChromaMemory without an injected embedder and
asserts it routes through the mocked real embedder (Greptile P2).
Co-authored-by: Mervin Praison <[email protected]>
`src/embeddings/index.ts` returned `Math.random() * 2 - 1` for every vector,
and `src/memory/adapters.ts:377` wired that as ChromaMemory's default embedder.
So every semantic search over memory ranked noise. Nothing indicated it - the
module's own docstring claimed "Python parity: praisonaiagents/knowledge".
The placeholder existed because embedding needs a network call and those
functions are synchronous. Returning plausible-looking garbage was the wrong
answer to that: a caller cannot tell a random vector from a real one.
Two changes:
- The sync `embed`/`embeddings` now throw, naming the async replacement and the
import path, instead of returning noise. `getDimensions` still works, since
it needs no network.
- ChromaMemory defaults to the real async embedder in `src/llm/embeddings.ts`.
`MemoryEmbedder` is already typed `MaybePromise<number[]>` and is awaited at
the call site, so this needed no contract change.
Anyone who passed their own `embedder` is unaffected. Anyone who did not was
getting noise, and now gets either real embeddings or a clear error.
Found by reading Vercel AI SDK, Mastra and LangChain.js at source: all three
derive embedding dimensions empirically and none fabricates a vector.
Verified: 2538 tests pass, build clean, 5 new tests.
Co-Authored-By: Claude Opus 5 <[email protected]>
2026-09-07 12:16:08 +01:00
538 changed files with 45324 additions and 4281 deletions
# Create the __getattr__ function using centralized utility
Loaded 100 of 538 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.