Compare commits

...
Author SHA1 Message Date
praisonai-triage-agent[bot] 75e89a1d28 Release v4.7.1 2026-08-24 09:36:19 +00:00
praisonai-triage-agent[bot] 9579b23987 Merge pull request #4287 from MervinPraison/claude/issue-4286-20260824-0827
fix: repair async MongoDB state store, async DB hook names, and safe_format drift
2026-08-24 09:26:56 +00:00
MervinPraison 567e50e751 docs: auto-update documentation parity trackers [skip ci] 2026-08-24 08:57:36 +00:00
praisonai-triage-agent[bot] eaabcaf393 Merge pull request #4285 from MervinPraison/claude/issue-4284-20260824-0746
fix: persist guardrails/approval config so clone_for_channel forwards them
2026-08-24 08:57:03 +00:00
praisonai-triage-agent[bot]andMervin Praison 50a3eeb788 fix: accurate async MongoDB hdel count and dotted-field hash round-trip
Address Greptile P1s on AsyncMongoDBStateStore:
- async_hdel now returns only the count of fields actually present and
  removed (StateStore contract "Returns count deleted"), matching the
  Firestore/DynamoDB document-store backends instead of over-reporting.
- async_hset/async_hdel treat fields as opaque top-level keys via a
  $mergeObjects pipeline / read-compute-write, so a dotted field like
  "a.b" round-trips through hget/hgetall/hdel instead of being coerced
  into a nested MongoDB path.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-24 08:37:21 +00:00
praisonai-triage-agent[bot]andMervinPraison 11bdca8ad8 fix: repair async MongoDB state store, async DB hook names, and safe_format drift (fixes #4286)
- AsyncMongoDBStateStore: implement the 7 missing StateStore abstract
  methods (keys, ttl, expire, hget, hset, hgetall, hdel) plus async twins
  so the class is instantiable and every async_mongodb/motor/mongodb_async
  factory alias boots instead of raising TypeError.
- db/adapter.py: rename the 6 async state-store call sites from the
  non-existent aset/aget to async_set/async_get so async persistence hooks
  take the native coroutine path instead of silently falling back to sync.
- agents_generator.safe_format: delegate to core
  BaseFrameworkAdapter._format_template (single source of truth) so wrapper
  and core cannot drift; fixes latent TypeError on non-string (None) input.

Co-authored-by: MervinPraison <[email protected]>
2026-08-24 08:30:50 +00:00
MervinPraison b472fb11ff docs: auto-update feature parity trackers [skip ci] 2026-08-24 08:15:21 +00:00
praisonai-triage-agent[bot] f619483bbc Merge pull request #4283 from MervinPraison/claude/issue-4282-20260824-0716
fix: undeclared tool must retry regardless of its name (fixes #4282)
2026-08-24 08:14:54 +00:00
praisonai-triage-agent[bot]andMervin Praison 2471285afd test: verify clone forwards approval policy + deny set (fixes #4284 review gap)
Closes the Greptile/CodeRabbit approval-clone coverage gap: the prior test
only inspected the original agent's private _approval_config and never
constructed a clone. Add a clone round-trip test asserting the served clone
reconstructs the same approval config and enforced _perm_deny set, plus a
negative test that a plain agent and its clone stay policy-free.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-24 07:57:28 +00:00
praisonai-triage-agent[bot]andMervinPraison 5a26705ae3 fix: persist guardrails/approval config so clone_for_channel forwards them (fixes #4284)
clone_for_channel() rebuilds the agent from getattr(self, '_guardrails_config',
None) and getattr(self, '_approval_config', None), but neither attribute was
ever assigned to the instance -- both were locals inside __init__. The getattr
therefore always returned None and every served clone (one per gateway channel,
one per HTTP invocation) ran with no output guardrail and lost its approval
policy. Persist both resolved values on the instance so the clone can read them.

Co-authored-by: MervinPraison <[email protected]>
2026-08-24 07:50:13 +00:00
praisonai-triage-agent[bot]andMervinPraison 7e7bcfc790 fix: undeclared tool must retry regardless of its name (fixes #4282)
Regression from #4257: `_tool_declares_not_idempotent` fell back to the
shared `MUTATING_TOOLS` name registry, silently dropping the retry from
any *undeclared* tool that happened to share a name with an entry
(`write_file`, `store_memory`, `mkdir`...). Key on the explicit
declaration only, and consult the process-global registry the way
`_is_tool_idempotent` already does when `allow_global_tools` is set.

Co-authored-by: MervinPraison <[email protected]>
2026-08-24 07:19:06 +00:00
praisonai-triage-agent[bot] 3a85e1e4a8 Merge pull request #4279 from MervinPraison/claude/issue-4278-20260824-0102
feat: add HOL Guard wrap_tool_call security example
2026-08-24 02:10:42 +00:00
praisonai-triage-agent[bot]andMervin Praison 37a80c3133 fix: fail-closed on non-object JSON and surface HOL Guard denial in result
- Return False for non-dict verdicts (e.g. [], "allow", null) to avoid
  AttributeError and preserve fail-closed behavior (CodeRabbit)
- Set ToolResponse.result to the denial message since the agent tool
  executor returns result and discards error, so denials reach the model
  instead of a null result (Greptile)
- Add non-object JSON regression test; update block test assertion

Co-authored-by: Mervin Praison <[email protected]>
2026-08-24 01:17:08 +00:00
praisonai-triage-agent[bot]andkantorcodes 96f6d0d93b feat: add HOL Guard wrap_tool_call security example (fixes #4278)
Adds an optional, provider-neutral example that gates command-bearing
tools through HOL Guard at the existing wrap_tool_call boundary. The
policy is fail-closed: the wrapped tool only runs on an explicit allow
verdict; block/unknown/malformed/timeout/CLI-failure short-circuit with
zero downstream execution. Includes a regression test suite proving a
denied command never reaches the tool executor.

Co-authored-by: kantorcodes <[email protected]>
2026-08-24 01:05:03 +00:00
MervinPraison 33b359f0da docs: auto-update documentation parity trackers [skip ci] 2026-08-23 10:46:23 +00:00
praisonai-triage-agent[bot] 67c511a44e Merge pull request #4270 from MervinPraison/claude/issue-4267-20260823-0945
fix: portable session export/import/migration for gateway stores
2026-08-23 10:45:53 +00:00
praisonai-triage-agent[bot] 3756369680 Merge pull request #4269 from MervinPraison/claude/issue-4268-20260823-0945
fix: add latency histograms to gateway metrics
2026-08-23 10:39:55 +00:00
MervinPraison 72f6b6f4eb docs: auto-update documentation parity trackers [skip ci] 2026-08-23 10:14:15 +00:00
praisonai-triage-agent[bot] 722203fc02 Merge pull request #4266 from MervinPraison/claude/issue-4265-20260823-0914
fix: expose gateway saturation/back-pressure telemetry (#4265)
2026-08-23 10:13:40 +00:00
praisonai-triage-agent[bot]andMervin Praison 5c647c0aef fix: harden session import — version guard, verbatim restore, no payload mutation, atomic export
- reject import payloads newer than PORTABLE_VERSION (reported, not applied)
- persist imported sessions verbatim via _save_imported_session (bypass
  destination retention/active_window so a valid larger export is not truncated)
- copy metadata before clearing live fields so the caller payload is not mutated
- write CLI exports to a temp file + atomic os.replace (never corrupt an
  existing backup on failure; nonzero exit on error)
- add tests for the above

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 10:00:21 +00:00
praisonai-triage-agent[bot]andMervin Praison f2596edeb2 fix: validate histogram buckets and reserve le label in GatewayMetrics
- Reject non-finite/non-increasing bucket bounds before storing (prevents
  render_prometheus() failures)
- Raise ValueError on conflicting bucket layouts for an existing metric name
  instead of silently ignoring later overrides
- Reject caller-supplied reserved 'le' label to avoid duplicate le samples
- Fix snapshot() to emit name_count{labels}/name_sum{labels} matching the
  Prometheus renderer
- Rename _HistData sum param to avoid shadowing builtin (ruff A002)
- Add tests for bucket conflicts, le rejection, validation, and label ordering

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 09:57:53 +00:00
praisonai-triage-agent[bot] d82364ec23 Merge pull request #4264 from MervinPraison/claude/issue-4263-20260823-0853
fix: stream LLM narrative into primary Textual TUI
2026-08-23 09:54:12 +00:00
praisonai-triage-agent[bot]andMervinPraison e475b3e22d fix: add portable session export/import/migration for gateway stores (fixes #4267)
Extend the session-store contract with a store-agnostic portability surface so
a gateway operator can back up, move, or restore live conversation state:

- core: add PortableSessionStoreProtocol + ImportReport to session.protocols
- core: implement export_session / export_all / import_sessions on
  DefaultSessionStore (SqliteSessionStore inherits it), reusing the existing
  SessionData.to_dict/from_dict shape. Export is lineage-aware; import is
  hardened (size cap, duplicate guard, malformed-record skip) and resets live
  routing/activity fields so restored state is inert until re-bound.
- core: export the new symbols from session/__init__.py
- wrapper: add `praisonai gateway sessions export/import` CLI + preflight
  helpers over the gateway's own default store.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 09:51:29 +00:00
praisonai-triage-agent[bot]andMervinPraison 6cbc363948 fix: add latency histograms to gateway metrics (fixes #4268)
Add a dependency-free histogram metric type to GatewayMetrics so the
gateway /metrics endpoint exposes latency distributions (buckets, _sum,
_count) for SLOs and slow-turn diagnosis, alongside the existing
counters and gauges.

- observe(name, seconds, buckets=..., labels=...) records durations
- timer(name, ...) context manager times its body and records it
- render_prometheus() emits _bucket/+Inf/_sum/_count histogram lines
- snapshot() includes a "histograms" section
- default buckets cover sub-second to multi-second turns

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 09:49:02 +00:00
praisonai-triage-agent[bot]andMervin Praison 848b9c61d3 fix: keep watchdog lag anchored to oldest probe; non-blocking outbox health reads (#4265)
Address two P1 review findings on the gateway saturation telemetry:

- LoopWatchdog: anchor the lag clock to the oldest still-unacked probe so a
  stall spanning several probe intervals is no longer understated (each fresh
  probe was overwriting the send-time). The ack consumes the anchor so the
  next probe re-anchors from a caught-up loop.
- OutboundQueue.try_depth_snapshot(): non-blocking (pending, dead_letter)
  counts that yield None when the writer lock is contended, and wire
  _compute_pressure() to reuse last-known depths instead of blocking. Health
  and /metrics run on the event loop and must never wait on the outbox lock.

Adds regression tests for the anchoring invariant and the non-blocking snapshot.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Mervin Praison <[email protected]>
2026-08-23 09:34:15 +00:00
praisonai-triage-agent[bot] e40b96eb5c Merge pull request #4261 from MervinPraison/claude/issue-4259-20260823-0820
fix: harden wrapper shim, api/call, and async bridge (fixes #4259)
2026-08-23 09:25:01 +00:00
praisonai-triage-agent[bot]andMervinPraison a19da24991 fix: expose gateway saturation/back-pressure telemetry (fixes #4265)
The always-on gateway enforces back-pressure (admission ceiling + fair
wait-queue, durable outbox/DLQ, event-loop wedge watchdog) but exposed no
saturation telemetry — health() reported liveness only, so the first signal
of overload was dropped work.

Core (praisonaiagents) owns the shape + a pure classifier, mirroring the
ReloadStatus precedent:
- HealthPressure frozen dataclass + deterministic evaluate_pressure() helper
- LoopWatchdog now reads back its continuously-measured scheduling lag
  (last_lag_ms), the same signal the wedge check already uses

Wrapper (praisonai_bot) reads facts already in hand and fills the block:
- health() gains a "pressure" block; /metrics gains admission/backlog/lag gauges
- OutboundQueue.dead_letter_count() surfaces the permanent-failure tier

Additive observability only — no new config keys, no new endpoint.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 09:22:00 +00:00
MervinPraison c054e54ddb docs: auto-update documentation parity trackers [skip ci] 2026-08-23 09:05:47 +00:00
praisonai-triage-agent[bot]andMervin Praison bc768e01ed fix: preserve display callback ownership in Textual TUI turn
Save the prior tool_call/llm_content callbacks and restore them on cleanup
under the core callbacks lock with an identity check, instead of blindly
overwriting and deleting the process-global slots. This mirrors
praisonaiagents' own register/restore pattern so another in-process
consumer that owns these slots keeps receiving events after a TUI turn.

Addresses Greptile P1 (global callback ownership lost).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 09:05:41 +00:00
praisonai-triage-agent[bot] 4b9d0a319f Merge pull request #4260 from MervinPraison/claude/issue-4258-20260823-0818
fix: strip whitespace from decision routing keys in process (fixes #4258)
2026-08-23 09:05:09 +00:00
praisonai-triage-agent[bot]andMervin Praison 564f55c434 fix: stream LLM narrative into primary Textual TUI (fixes #4263)
The default interactive TUI (async_tui.py) only registered the tool_call
display callback, so intermediate assistant text was rendered as a single
whole-response append after the worker thread joined. Register the core
llm_content callback (already emitted per LLM step) to push narrative into a
live assistant message as the turn progresses, and reuse that streamed
message as the finalised turn to avoid a duplicate append. Read-only review
turns keep their single-summary behaviour. No new core surface; wrapper-only.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 08:56:53 +00:00
praisonai-triage-agent[bot] 8c974f29e6 Merge pull request #4257 from MervinPraison/claude/issue-4256-20260823-0804
fix: honour explicit idempotent=False in both tool retry loops
2026-08-23 08:53:31 +00:00
praisonai-triage-agent[bot]andMervin Praison 8a312b0466 fix: restore FastAPI Request/WebSocket injection; harden shim None guard and strict-loop test
- api/call.py: the lazy-import refactor dropped the ``request: Request`` /
  ``websocket: WebSocket`` annotations, so FastAPI treated ``request`` as a
  required query param and 422'd the ``/`` route. Stamp the real classes onto
  the handlers in _register_routes (build time, where fastapi is already
  imported) — import stays cheap, route injection restored.
- cli/_shim.py: skip ``None`` placeholders in the eager walk_packages loop so a
  known-absent submodule can't poison the old dotted path before _AliasFinder
  resolves it lazily (mirrors the existing guard in the first pass).
- test_wrapper_layer_regression.py: force PRAISONAI_ALLOW_LOOP_BLOCKING empty
  around the strict assertion so an ambient opt-in can't mask the RuntimeError.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 08:49:04 +00:00
MervinPraison 73b55af165 docs: auto-update documentation parity trackers [skip ci] 2026-08-23 08:47:27 +00:00
praisonai-triage-agent[bot] 65037b1442 Merge pull request #4255 from MervinPraison/claude/issue-4254-20260823-0752
fix: empty LLM response no longer returns SDK object repr
2026-08-23 08:46:54 +00:00
praisonai-triage-agent[bot]andMervinPraison 7e98368745 fix: restore shim module identity (default eager) and make call tools idempotent
The lazy-by-default shim in cli/_shim.py broke module identity across the
old/new dotted paths (guarantee #1 in its own docstring): importing the
old name first (e.g. `from praisonai.mcp_server.cli import ...`, as the
tests do) re-entered _AliasFinder and double-loaded the moved file,
yielding two distinct module objects. That made mock.patch("<old.path>")
target a different object than the running code (imported via the new
name), causing the test-core (cli/subdirs) and smoke CI failures.

Restore eager pre-registration as the DEFAULT (it was already lightweight:
optional heavy submodules that fail import are logged and left for lazy
resolution). Keep an explicit opt-out via PRAISONAI_SHIM_LAZY=1 for
callers that don't rely on cross-path module identity.

Also make api/call._load_local_tools() idempotent (clear before repopulate)
so repeated build_call_app(load_local_tools=True) builds no longer
accumulate duplicate tool definitions in the shared registry (greptile).

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 08:43:04 +00:00
praisonai-triage-agent[bot] 1e3ceca30d Merge pull request #4252 from MervinPraison/claude/issue-4250-20260823-0744
fix: don't relabel tool failures as LLM errors in _chat_completion
2026-08-23 08:32:41 +00:00
MervinPraison 8f0237fd6d docs: auto-update documentation parity trackers [skip ci] 2026-08-23 08:31:46 +00:00
praisonai-triage-agent[bot] 80bc2ad458 Merge pull request #4253 from MervinPraison/claude/issue-4251-20260823-0745
fix: bound sync self-reflection parse-error retry
2026-08-23 08:31:11 +00:00
praisonai-triage-agent[bot]andMervinPraison a942df600f fix: harden wrapper shim, api/call, and async bridge (fixes #4259)
Three lightweight, backward-compatible wrapper fixes:

1. cli/_shim.py: gate the eager walk_packages pre-import behind
   PRAISONAI_SHIM_EAGER (lazy by default via _AliasFinder) and log
   previously-swallowed submodule ImportErrors instead of silently
   skipping them.

2. api/call.py: make heavy deps (fastapi, twilio, uvicorn, pyngrok,
   websockets, rich) lazy-imported; build the FastAPI app via a
   build_call_app() factory plus a lazy module __getattr__ for `app`;
   move the import-time tools.py filesystem scan + user-code execution
   into a server-entry-point path so importing the module has no side
   effects.

3. _async_bridge.run_sync_or_offload: refuse to block a running event
   loop by default (opt-in via PRAISONAI_ALLOW_LOOP_BLOCKING), steering
   async callers to arun_sync_or_offload; PraisonAIAdapter.run uses
   run_sync on the plain-sync path and raises a clear error from a
   running loop.

Updated the corresponding wrapper regression test to the new strict
contract.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 08:28:32 +00:00
praisonai-triage-agent[bot]andMervin Praison a2cf33ca80 test: cover synchronous workflow() decision routing whitespace strip
The sync workflow() path (lines 1502/1504) is duplicated code, edited
independently from aworkflow(). The existing suite drove only aworkflow(),
so a whitespace regression in the sync branch would leave it green.
Adds _run_sync driver + parametrized sync retry/control tests. Verified
they fail without .strip() and pass with it.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 08:27:54 +00:00
praisonai-triage-agent[bot]andMervinPraison d9adc77a0d fix: strip whitespace from decision routing keys in process (fixes #4258)
Decision task verdicts were routed via result.raw.lower() and pydantic.decision.lower() at eight sites without strip(). Raw model text routinely carries a trailing newline, so the condition lookup missed and a miss was treated as exit-condition-met: the workflow finished silently with the rejected output (no retry, no validation feedback, no error). This adds strip() at all eight sites so a padded verdict routes exactly like a clean one, matching validate_decision_string which already lowers and strips.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 08:21:06 +00:00
MervinPraison 535d0b5aab docs: auto-update documentation parity trackers [skip ci] 2026-08-23 08:16:16 +00:00
praisonai-triage-agent[bot] 96e981800b Merge pull request #4249 from MervinPraison/claude/issue-4247-20260823-0714
fix: correct ast_grep rewrite receipt + add path confinement, -- terminator, output cap
2026-08-23 08:15:44 +00:00
praisonai-triage-agent[bot]andMervin Praison 7c2e76869b fix: honour restart_safe=False in non-idempotent retry veto
The retry veto only read the raw `idempotent` attribute, missing the public
`restart_safe=False` contract used by @tool (FunctionTool) and BaseTool. Such
effectful tools remained retryable in both loops, duplicating side effects.
Fall back to `restart_safe` when `idempotent` is unset; add regression tests
for @tool and BaseTool declarations.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 08:14:34 +00:00
praisonai-triage-agent[bot]andMervinPraison 7de11a78cd fix: honour explicit idempotent=False in both tool retry loops (fixes #4256)
A tool declaring idempotent=False was still re-driven up to max_attempts
times by both retry loops, duplicating side effects (send a second email,
charge twice). Both loops now veto the retry when a tool *explicitly*
declares itself non-idempotent, via a new tri-state helper
_tool_declares_not_idempotent that keys on the explicit declaration only,
leaving undeclared/declared-safe tools' retry behaviour unchanged.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 08:07:04 +00:00
praisonai-triage-agent[bot]andMervin Praison 72f1fc12d9 fix: warn on model refusal and strengthen async empty-response assertions
- _extract_llm_response_content now inspects message.refusal (carried
  independently of finish_reason) and warns without logging refusal text
- async chat_history test now asserts result == "" and an empty assistant
  message, closing gaps flagged in review

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 08:00:23 +00:00
praisonai-triage-agent[bot]andMervin Praison e668943114 fix: re-raise ToolExecutionError in streaming fallback path too
The streaming auto-detect block in _chat_completion caught every
non-LLMError exception and fell back to a non-streaming retry. Tool
failures during the streaming attempt were therefore run again by the
fallback, executing the tool twice and potentially masking the original
typed failure. Re-raise ToolExecutionError before the generic fallback,
mirroring the guard in the main completion block.

Also tighten the regression tests to assert the failing tool actually
executed (the tool executor retries a failing tool, so every attempt is
verified to target the same recipient).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 07:54:58 +00:00
praisonai-triage-agent[bot]andMervinPraison 103c859400 fix: empty LLM response no longer returns SDK object repr (fixes #4254)
_extract_llm_response_content ended in return str(response), reached whenever
a well-formed response carried no content and no tool_calls (content filter,
refusal, or finish_reason=length with zero output tokens). achat() used this,
so the user's answer became the raw ChatCompletion repr, persisted into
chat_history and replayed to the model.

Now a cleanly-parsed-but-empty message returns "" (matching the sync path),
logging a warning when finish_reason is unexpected. str(response) is reserved
for genuinely unparseable responses where the repr is a diagnostic.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 07:54:14 +00:00
praisonai-triage-agent[bot]andMervinPraison 4f4969cb80 test: fix unused variable lint in bounded reflection test
Prefix the unused _agent() tuple element with an underscore to satisfy
Ruff RUF059, as flagged in review.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 07:53:27 +00:00
praisonai-triage-agent[bot]andMervinPraison b7d77bd872 fix: bound sync self-reflection parse-error retry (fixes #4251)
The sync reflection handler incremented the retry counter and continued
unconditionally on a parse error, so a persistently unparseable reflection
(e.g. an OpenAI structured-output refusal where message.parsed is None)
looped forever at two LLM calls a turn and chat() never returned. Mirror the
async bound at chat_mixin.py so the loop stops at max_reflect and returns the
un-reflected answer.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 07:47:38 +00:00
praisonai-triage-agent[bot]andMervinPraison 18ac8951dd fix: don't relabel tool failures as LLM errors in _chat_completion (fixes #4250)
Add an explicit `except ToolExecutionError: raise` guard before the blanket
`except Exception` in `_chat_completion`, mirroring the existing
`BudgetExceededError` escape hatch. Previously a `ToolExecutionError` raised by
the sync tool executor was caught by position and re-labelled as `LLMError`,
causing chat() to return None, the tool's message to be fed to the LLM error
classifier (so a tool error resembling a rate limit re-drove the model with no
tool result), and confident answers generated with no tool result.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 07:46:43 +00:00
praisonai-triage-agent[bot]andMervin Praison 6195b8ee80 fix: spill ast_grep overflow into workspace so retrieval pointer is reachable
The overflow pointer advertises read_file/grep on the spilled artifact, but
those tools reject out-of-workspace paths. When PRAISONAI_TOOL_OUTPUT_DIR is
unset, spill into a workspace-local .praisonai_tool_output dir so the omitted
output stays retrievable (fixes Greptile P1 on #4247).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 07:25:57 +00:00
praisonai-triage-agent[bot]andMervinPraison 221c7d5b0b fix: correct ast_grep receipt, add path confinement, -- terminator, output cap (fixes #4247)
- Rewrite success path now surfaces the "Applied N changes" receipt that
  sg writes to stderr, instead of reporting the failure value
  "No changes made" after a real, destructive rewrite.
- Confine path/rule_file to the workspace via path_safety.resolve_within_root.
- Add a `--` argv terminator so a dash-leading path is never parsed as a flag.
- Bound search/rewrite/scan output via _output_overflow.bounded_with_pointer.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 07:18:01 +00:00
MervinPraison 514b35e58f docs: auto-update documentation parity trackers [skip ci] 2026-08-23 06:35:15 +00:00
praisonai-triage-agent[bot] 1cda79b538 Merge pull request #4242 from MervinPraison/claude/issue-4240-20260823-0515
fix: six context strategies silently disabled by optimizer kwargs fan-out
2026-08-23 06:34:43 +00:00
MervinPraison 30744e5bdd docs: auto-update documentation parity trackers [skip ci] 2026-08-23 06:23:36 +00:00
praisonai-triage-agent[bot] de32295eb5 Merge pull request #4245 from MervinPraison/claude/issue-4241-20260823-0520
fix: surface unparseable tool-call args and forward configured temperature
2026-08-23 06:23:00 +00:00
praisonai-triage-agent[bot] 95e7da3f06 Merge pull request #4239 from MervinPraison/claude/issue-4238-20260823-0459
fix: stop praisonai-train silently discarding data and misreporting
2026-08-23 06:19:30 +00:00
praisonai-triage-agent[bot] 99a9b6aa47 Merge pull request #4237 from MervinPraison/claude/issue-4233-20260823-0452
fix: abort close-delimited slow monitor bodies via pinned raw socket
2026-08-23 06:17:17 +00:00
praisonai-triage-agent[bot] 24a12f6a8d Merge pull request #4235 from MervinPraison/claude/issue-4231-20260823-0449
fix: four residuals — judge parsing, gateway stop, telemetry counting, crawl SSRF (#4231)
2026-08-23 06:14:53 +00:00
MervinPraison afbc190c10 docs: auto-update documentation parity trackers [skip ci] 2026-08-23 06:08:07 +00:00
praisonai-triage-agent[bot] fa9ead256d Merge pull request #4232 from MervinPraison/claude/issue-4226-20260823-0442
fix: make as_tool run sub-agent, resolve openai-compat, make db/obs callable
2026-08-23 06:07:32 +00:00
MervinPraison 207c911199 docs: auto-update feature parity trackers [skip ci] 2026-08-23 05:57:38 +00:00
praisonai-triage-agent[bot] 85d10cf8a1 Merge pull request #4230 from MervinPraison/claude/issue-4227-20260823-0443
fix: unwrap LLMConfig in AgentTeam/AgentFlow so members don't fail silently
2026-08-23 05:57:11 +00:00
praisonai-triage-agent[bot]andMervin Praison 86daa44a84 test: assert parse-failure sentinel for malformed tool-call args
The malformed-JSON cases in test_tool_call_parsing encoded the old buggy
behaviour (args -> {}), which silently ran tools with wrong arguments and
reported success. Defect 1 of #4241 replaces {} with a distinct
_TOOL_ARGUMENTS_PARSE_FAILED sentinel. Update the test to assert the
sentinel (not weaken it) so it keeps guarding that malformed args are
surfaced as retryable errors instead of dispatched.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 05:42:54 +00:00
praisonai-triage-agent[bot]andMervin Praison 3534914544 fix: budget full request in emergency-truncation threshold (PR #4242 review)
The hard-limit check and failure-path fallback in _apply_context_management
counted only message-history tokens. A large system prompt or tool schema
could push the request over the model window while the history alone stayed
under 95%, so truncation was skipped and an over-limit request was sent.

Both paths now add system-prompt + tool-schema tokens via a new
_estimate_request_overhead_tokens helper, and the emergency target reserves
that overhead so the whole request lands near 80% of the window. Adds
regression tests covering the fallback with an oversized system prompt.

Addresses CodeRabbit and Greptile review on PR #4242.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 05:35:21 +00:00
praisonai-triage-agent[bot]andMervin Praison b4733628d8 fix: preserve symlink output destinations on atomic dataset replace
os.replace(tmp, out_path) clobbers a symlink itself, leaving its target
holding the stale corpus. Resolve the final-path symlink to its real
target before creating the temp file and replacing, so generate/dedup
update the file consumers read through the link. Adds a regression test.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 05:33:27 +00:00
praisonai-triage-agent[bot]andMervinPraison 416a59da2f fix: surface unparseable tool-call args and forward configured temperature (fixes #4241)
Defect #1: a truncated/invalid tool-call argument string no longer executes
the tool with {} and reports success. _parse_tool_call_arguments now returns a
distinct sentinel on JSON parse failure (kept separate from {} = "no args"),
and every tool-execution site emits a retryable tool-error message instead of
dispatching. Covers sync/async, streaming, batched and Responses-API paths.

Defect #2: a temperature configured via Agent(llm={'temperature': ...}) now
actually reaches the request. Public entry points default temperature to None
and _build_completion_params resolves it from self.temperature once; chat/achat
and the internal completion helpers default to None so the configured value is
no longer overridden by a hardcoded 1.0. Unset temperature is omitted so the
provider default applies rather than sending an explicit None.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 05:32:51 +00:00
praisonai-triage-agent[bot]andMervin Praison 26721fff9a fix: fail-closed on unscored verdicts, confirm force-kill, preserve crawl batch order
- eval/grader.py + judge.py: passing now requires a parsed numeric SCORE
  (score_parsed), so a reasoning-only response can no longer fabricate a
  passing 5.0 against a low threshold. Multi-line REASONING is captured.
- crawl4ai_tools.py: crawl_many preserves input->output positional order for
  mixed safe/blocked batches instead of hoisting blocked entries to the front.
- gateway.py: _force_kill_process polls until the PID is confirmed gone before
  returning True, so the PID lock is not released while a process may survive.
- test_grader.py: assert fail-closed (1.0) for an unparseable score.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 05:31:25 +00:00
praisonai-triage-agent[bot]andMervin Praison 7248b17e95 fix: preserve dataset file permissions on atomic replace
mkstemp creates the temp file 0600 and os.replace would make that the
final mode, stripping group/other read that a plain open(..., "w") would
grant via umask and locking shared-corpus consumers out. Restore the
destination's existing mode when overwriting, else 0666 & ~umask.
Applies to both generate and dedup; adds two regression tests.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 05:29:32 +00:00
praisonai-triage-agent[bot]andMervin Praison 9b8996c77c test: assert AgentTeam member + AgentFlow seed get the unwrapped model string
Covers the #4227 failure mode directly (member propagation, not just the
container field) per CodeRabbit review, without a live LLM call.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-23 05:20:52 +00:00
praisonai-triage-agent[bot]andMervinPraison adb262d596 fix: filter optimizer kwargs so six context strategies stop failing silently (fixes #4240)
ContextManager built one union kwargs dict and passed it to every optimizer,
but only SmartOptimizer accepted that signature. The other six raised
TypeError, which chat_mixin swallowed with a blanket except, disabling context
management entirely — including the emergency hard-limit truncation.

- get_optimizer now filters kwargs to each optimizer's constructor signature
  (single choke point; fixes all six strategies without touching call sites).
- chat_mixin._apply_context_management falls back to emergency truncation on
  failure instead of returning the unchanged, over-budget history.
- Add regression tests covering every strategy.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 05:19:50 +00:00
praisonai-triage-agent[bot]andMervinPraison 6820f64d10 fix: stop praisonai-train silently discarding data and misreporting (fixes #4238)
Four HIGH-severity silent-data-loss bugs in praisonai-train:

- train llm <dataset>: forward the path as --dataset (the option the train
  branch reads) instead of a bare positional the legacy dispatcher drops,
  which silently trained on yahma/alpaca-cleaned.
- generate: write to a temp file and os.replace only when rows are produced
  (mirrors dedup), so an all-failures run no longer truncates an existing
  corpus to zero bytes.
- Ollama export: dedent the Modelfile TEMPLATE so continuation lines sit at
  column 0 and the served prompt format matches the trained one.
- agent training: a genuine agent failure now re-raises instead of being
  captured as "Error: ..." output, graded as training data, and reported as
  success with exit 0.

Adds regression tests for all four.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 05:05:00 +00:00
praisonai-triage-agent[bot]andMervinPraison ed662cab0d fix: abort close-delimited slow monitor bodies via pinned raw socket (fixes #4233)
The scheduler monitor's total-deadline watchdog was a no-op for
Connection: close responses. http.client.getresponse() calls close()
for close-delimited replies, nulling connection.sock, so when the
watchdog fired on exactly the responses that can hang forever there was
no socket left to shut down. A page dripping one byte per socket window
stalled the whole sequential scheduler tick while holding its lease.

Retain a separate raw-socket handle the close() path does not clear and
fall back to it in _abort_connection; clear it after each probe so the
fd is not held past the (per-probe) connection.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 04:56:12 +00:00
praisonai-triage-agent[bot]andMervinPraison 132f08bfdf fix: harden judge parsing, gateway stop, telemetry counting and crawl SSRF (fixes #4231)
- #4195: grader.py/judge.py now parse markdown-bolded labels and fail closed
  (score 1.0) instead of fabricating a mid-range 5.0 that could pass a threshold
- #4192: gateway stop distinguishes PermissionError from a dead process and
  keeps a live cross-uid holder's lock
- #4196: telemetry re-entrancy guard uses a ContextVar so concurrent executions
  on one agent are counted independently
- #4189: crawl4ai_tools now validates every URL entry point via is_safe_http_url,
  and mentions.py re-validates each redirect hop instead of only the first

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 04:55:45 +00:00
praisonai-triage-agent[bot]andMervinPraison ad1f596bce fix: make as_tool run sub-agent, resolve openai-compat, make db/obs callable (fixes #4226)
Three closed defects still reproduced on main, each shielded by a test that
passed on the broken behaviour.

1. Agent.as_tool() returned a success string without running the sub-agent.
   ContextPolicy.NONE discards history, so no prompt was ever derived. The
   generated tool now advertises a `task` parameter and passes it verbatim as
   the sub-agent's prompt.
2. `--type openai-compat` was refused though listed as registered. The endpoint
   registry loads under both `praisonai_code.*` and the `praisonai.cli.features`
   shim namespace; the relative `from ..._wrapper_bridge` resolved to the
   non-existent `praisonai._wrapper_bridge` under the shim. Made it absolute.
3. `from praisonaiagents import db` (and `obs`) yielded a non-callable module,
   because a real submodule shadows the package `__getattr__`. The submodules
   now swap their `__class__` to a callable ModuleType subclass that proxies to
   the lazy singleton, so `db(...)`/`obs(...)` and `db.PraisonDB` both work.

Tests: added a behavioural as_tool test asserting the sub-agent call, a
resolve() assertion under the shim namespace, an obs-callable test, and removed
the bug-detecting workaround from the db test so its assertion can fail without
the fix. Each new test was confirmed to fail against the unfixed tree.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 04:51:39 +00:00
praisonai-triage-agent[bot]andMervinPraison 0521d43fe9 fix: unwrap LLMConfig in AgentTeam/AgentFlow so members don't fail silently (fixes #4227)
The containers called resolve_model_alias (alias rule only) while the seven
media/specialist agents call resolve_model_name (alias rule + LLMConfig
unwrapping). AgentTeam/AgentFlow therefore pushed the raw LLMConfig into every
member via _apply_default_llm, and the member's chat() failed silently with
"'LLMConfig' object has no attribute 'lower'", returning None.

Switch both container sites to resolve_model_name and widen the regression
test's parametrize from UNWRAPPING to ALL.

Co-authored-by: MervinPraison <[email protected]>
2026-08-23 04:47:30 +00:00
MervinPraison 52e3e37b1c docs: auto-update documentation parity trackers [skip ci] 2026-08-22 18:03:27 +00:00
praisonai-triage-agent[bot] 146373039a Merge pull request #4225 from MervinPraison/claude/issue-4224-20260822-1711
fix: remove vestigial thread-local lazy-cache machinery
2026-08-22 18:02:47 +00:00
praisonai-triage-agent[bot]andMervin Praison c7b54c526d test: exercise synchronized first-load path in lazy-cache concurrency test
Evict the 'Task' key from _lazy_cache before spawning threads so the
concurrent access hits the double-checked locking path in
_lazy.lazy_import instead of the unlocked cache fast path. Addresses
Greptile P2: prior test could read an already-cached attribute after
suite collection, letting concurrent first-load regressions go
undetected.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 17:19:51 +00:00
praisonai-triage-agent[bot]andMervinPraison 1eed1c5c76 fix: remove vestigial thread-local lazy-cache machinery (fixes #4224)
Remove dead _lazy_cache_local threading.local and _get_lazy_cache()
helper from praisonaiagents/__init__.py. The runtime lazy-loader only
uses the plain _lazy_cache dict (guarded by the lock in _lazy.py);
the thread-local cache had no runtime consumer.

Repoint TestLazyCacheThreadSafety at the real lazy-loading path
(concurrent access of praisonaiagents.Task resolving to one cached
object) instead of the removed self-referential helper.

Co-authored-by: MervinPraison <[email protected]>
2026-08-22 17:13:13 +00:00
MervinPraison 68b325735f docs: auto-update api.md [skip ci] 2026-08-22 11:56:22 +00:00
Mervin Praison f682ffdcc6 Merge pull request #4213 from MervinPraison/claude/issue-4212-20260822-0711
fix: memory prompt injection, timeout retry safety, handoff context (#4212)
2026-08-22 12:55:54 +01:00
MervinPraison 4b92def4e0 docs: auto-update documentation parity trackers [skip ci] 2026-08-22 11:55:38 +00:00
Mervin Praison 3f3ff78dbb Merge pull request #4211 from MervinPraison/claude/issue-4210-20260821-1715
fix: emit reasoning deltas on async Responses streaming; narrow Expected warning filter
2026-08-22 12:55:04 +01:00
MervinPraison d55ee886f3 docs: auto-update api.md [skip ci] 2026-08-22 11:54:55 +00:00
Mervin Praison fa881a604d Merge pull request #4207 from MervinPraison/claude/issue-4206-20260821-0918
fix: forward model-fallback, retry, todo, and tool-result stream events in gateway relay
2026-08-22 12:54:30 +01:00
Mervin Praison d58eaffb40 Merge pull request #4203 from MervinPraison/claude/issue-4202-20260821-0709
fix: isolate memory backends, pre-compaction batch commit, Parallel stop propagation
2026-08-22 12:54:10 +01:00
MervinPraison 0538482030 docs: auto-update documentation parity trackers [skip ci] 2026-08-22 10:54:44 +00:00
praisonai-triage-agent[bot] 33b67c2da2 Merge pull request #4223 from MervinPraison/claude/issue-4221-20260822-0946
fix: cross-replica quota coordination seam for credential cooldowns
2026-08-22 10:54:04 +00:00
MervinPraison 15a5c72b0b docs: auto-update documentation parity trackers [skip ci] 2026-08-22 10:44:30 +00:00
praisonai-triage-agent[bot] b279f16a35 Merge pull request #4222 from MervinPraison/claude/issue-4220-20260822-0945
fix: add core global operator emergency-stop brake protocol
2026-08-22 10:43:53 +00:00
MervinPraison 27bc4e1963 docs: auto-update feature parity trackers [skip ci] 2026-08-22 10:14:51 +00:00
praisonai-triage-agent[bot] 96d4b58cad Merge pull request #4219 from MervinPraison/claude/issue-4217-20260822-0916
fix: add restart_safe tool contract for durable resume
2026-08-22 10:14:26 +00:00
praisonai-triage-agent[bot] 4b917c407a Merge pull request #4218 from MervinPraison/claude/issue-4216-20260822-0915
fix: make gateway crash-safe by default with journal-backed resume
2026-08-22 10:13:20 +00:00
praisonai-triage-agent[bot]andMervin Praison f7d1b53818 fix: use stable credential identity and guard stale-success clearing in quota coordination
- AuthProfile.credential_id: stable, non-secret (hashed) identity keyed on
  provider+api_key+base_url so coordinator benches track the credential, not
  the local profile label. Prevents same-name collisions ("default") benching
  unrelated keys and different names on the same key breaking propagation.
- mark_success: only clear the shared bench when it is not newer than the
  cooldown being recovered from, so a stale in-flight success cannot clobber a
  newer fleet-wide bench set by a concurrent failure.
- All three coordinator call sites now use credential_id consistently.
- Tests: add same-name-distinct-keys isolation, stale-success guard, and
  own-bench clear coverage; update existing tests to key on credential_id.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 09:58:30 +00:00
praisonai-triage-agent[bot]andMervin Praison b3853c0eeb fix: harden emergency-stop sentinel and accept gateway.control in bot schema
- state(): catch TypeError so a valid-JSON sentinel with a non-numeric `at`
  (e.g. a list) still fails safe engaged instead of raising.
- engage(): commit via tempfile.mkstemp in the sentinel dir + fsync file and
  parent dir, closing a predictable-tmp symlink pre-creation vector and making
  an engaged brake durable across an abrupt crash; cleanup tmp on failure.
- bot GatewayServerSchema: declare `control` and `turn_lock` so the documented
  `gateway.control` YAML block loads under extra="forbid".
- tests: drop hardcoded /tmp path (S108) and add structured-`at` fail-safe case.

Skipped (scope/lightweight mandate): async FileEmergencyStop variants (no live
async admission consumer yet; is_engaged is a fast local stat/read) and
agent.start() agentic tests (this PR ships the core contract + config only, no
admission wiring to exercise via the LLM).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 09:58:00 +00:00
praisonai-triage-agent[bot]andMervinPraison 3f458b9452 fix: add cross-replica quota coordination seam for credential cooldowns (fixes #4221)
Adds a pure, dependency-free QuotaCoordinatorProtocol + QuotaCoordinatorConfig
and an in-memory LocalQuotaCoordinator in core (praisonaiagents/llm/quota.py).
FailoverManager now consults an optional coordinator so a credential benched
by any replica (429/auth/billing cooldown) is skipped by all replicas sharing
the same backend. Defaults to the local in-memory coordinator, so single-replica
/ no-backend deployments behave exactly as before with no new dependency and no
hot-path change. All coordinator calls are fail-open (never wedge failover) and
benches carry TTLs that self-expire.

Co-authored-by: MervinPraison <[email protected]>
2026-08-22 09:51:28 +00:00
praisonai-triage-agent[bot]andMervinPraison 875a5a7948 fix: add core global operator emergency-stop brake protocol (fixes #4220)
Introduce a pure, dependency-free EmergencyStopProtocol in core gateway
plus a zero-cost NullEmergencyStop default and a durable, fail-safe
FileEmergencyStop sentinel. Wire an EmergencyStopConfig (gateway.control)
into GatewayConfig defaulting to backend "off" so behaviour is unchanged.
This is the shared contract every new-work admission seam can consult to
halt new runs while preserving in-flight ones; a corrupt/unreadable
sentinel fails safe (engaged).

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: MervinPraison <[email protected]>
2026-08-22 09:50:37 +00:00
praisonai-triage-agent[bot]andMervin Praison 8b40690a6d fix: fail closed on malformed restart_safe + tolerate repaired tool names
- Only genuine booleans count as a restart_safe declaration; malformed values
  (e.g. the string "False") are treated as unsafe instead of coerced truthy.
- Empty tool names fail closed rather than falling through to the read-only
  heuristic which returns True for "".
- Declaration lookup now compares canonicalised names so an explicit
  restart_safe declaration survives execute_tool's case/separator repair.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 09:31:20 +00:00
praisonai-triage-agent[bot]andMervin Praison 91294a67a9 fix: base gateway durable-runs default on effective session store
CodeRabbit: session.persist:true but a failed persistent-store init degrades
to in-memory (self._session_store is None). The old config-based default still
enabled ExecutionConfig(durable=True), journalling against no durable store.
Resolve the auto-default from the instantiated self._session_store instead;
explicit gateway.durable_runs still wins. Adds a regression test.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 09:30:20 +00:00
praisonai-triage-agent[bot]andMervinPraison 23e358b5ae fix: add restart_safe tool contract for durable resume (fixes #4217)
Add a `restart_safe` declaration to the tool contract (@tool / BaseTool /
FunctionTool) and honour it during durable resume. An in-flight tool call
(journalled tool_call with no tool_result at the crash) is now re-run only
when the tool resolves as restart-safe (explicit declaration, else the
read-only name heuristic); effectful/undeclared tools fail closed with a
typed NotSafelyResumable outcome instead of silently re-executing, removing
the duplicated-side-effect risk on crash recovery.

Co-authored-by: MervinPraison <[email protected]>
2026-08-22 09:22:18 +00:00
praisonai-triage-agent[bot] af5082ee85 Merge pull request #4215 from MervinPraison/claude/issue-4214-20260822-0819
fix: reap cancelled subprocesses, offload blocking recipe handlers, atomic hash writes
2026-08-22 09:22:13 +00:00
praisonai-triage-agent[bot]andMervinPraison f3cc8bee17 fix: make gateway crash-safe by default with journal-backed resume (fixes #4216)
Auto-enable durable (journal-backed) gateway runs when a durable session
store is present (the default), so a restart mid-turn replays completed
model/tool steps instead of re-executing side-effecting tools or re-billing
the model. Zero-overhead escape hatches: explicit `gateway.durable_runs:
false` or `gateway.reliability: "off"`, and sessions with `persist: false`.
An explicit `durable_runs` and per-agent `durable` still win.

Co-authored-by: MervinPraison <[email protected]>
2026-08-22 09:20:09 +00:00
praisonai-triage-agent[bot]andMervin Praison 1a7cb66802 fix: correct hash deletion counts, migrate legacy hashes, stop stranded SSE producer
- firestore.hdel: count only fields actually present instead of len(fields)
- dynamodb.hset/hdel: migrate legacy JSON-string hashes into native map so
  existing fields stay visible and legacy deletions are effective; count actual
- recipe/serve.py: drain SSE queue + stop event on consumer cancellation so the
  producer worker thread unblocks instead of leaking the executor

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 08:31:02 +00:00
praisonai-triage-agent[bot]andMervinPraison 53543e020c fix: reap cancelled subprocesses, offload blocking recipe handlers, atomic hash writes (fixes #4214)
- integrations/base.py: reap the child in a finally block in execute_async
  and execute_async_with_stderr so caller cancellation (CancelledError) no
  longer leaks a running subprocess plus its stdout/stderr pipes.
- recipe/serve.py: route sync recipe.* calls through asyncio.to_thread and
  bridge the sync run_stream generator to an asyncio.Queue on a worker
  thread so a single recipe run no longer blocks the whole event loop.
- persistence/state/firestore.py: scope credentials to the client instead
  of mutating process-wide os.environ, and use atomic field-level merge /
  DELETE_FIELD for hset/hdel to avoid lost concurrent updates.
- persistence/state/dynamodb.py: use atomic UpdateExpression on a native
  map attribute for hset/hdel to avoid non-atomic read-modify-write races.

Co-authored-by: MervinPraison <[email protected]>
2026-08-22 08:23:16 +00:00
praisonai-triage-agent[bot]andMervin Praison 884e212319 fix: scope handoff history, guard empty memory query, resolve global idempotent tools
- handoff.py: make seeded handoff context invocation-scoped via a
  restore-on-exit context manager so target chat_history no longer leaks
  across sequential/concurrent handoffs or grows unbounded (CodeRabbit/Greptile P1)
- handoff.py: exclude the exact message folded into the prompt (by index)
  from seeded history instead of always dropping the final list item
- memory.py: get_context returns "" for empty/None query (no LIKE "%%"
  unrestricted match) and propagates the effective user_id for user-scoped memories
- tool_execution.py: resolve explicit idempotent flag on process-global
  registry tools before falling back to the shared name registries

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 07:32:14 +00:00
praisonai-triage-agent[bot]andMervin Praison f8e59659f3 fix: memory prompt injection, timeout retry safety, handoff context (fixes #4212)
Bug #1 — retrieved memory never reached the prompt:
- build_context_for_task defaulted include_in_output to a DEBUG-only gate, so
  Agent(memory=True) retrieved hits but returned "" under normal logging. Default
  to True (the method's primary purpose is feeding memory into the prompt).
- Added Memory.get_context() so the non-cache path (get_memory_context) works;
  previously only FileMemory had it, so hasattr(...) was always False.

Bug #2 — timed-out tool auto-retried while still running:
- future.cancel() is a no-op once a worker starts, so the tool body keeps running.
  Added _is_tool_idempotent() and gated the _outer_timeout retry on it, reusing
  the escalation loop_guard read-only/mutating registry plus an optional per-tool
  `idempotent` flag. Mutating tools now surface the timeout once instead of
  duplicating side effects.

Bug #3 — HandoffConfig context policy computed then discarded:
- _prepare_context() result was thrown away; the target only got the prompt string.
  Added _seed_target_history() and threaded the filtered messages through
  _execute_with_runtime_resolution(_async) for sync/async Handoff and TypedHandoff.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-22 07:18:26 +00:00
praisonai-triage-agent[bot]andMervinPraison 455d81c615 fix: emit reasoning deltas on async Responses streaming; narrow Expected warning filter (fixes #4210)
- llm/llm.py: add response.reasoning_summary_text.delta branch to
  _stream_responses_api_async so async streaming emits reasoning-summary
  deltas, matching the sync path.
- _warning_patch.py: replace over-broad bare "Expected" substring with
  precise "fields but got" so unrelated third-party/user warnings are no
  longer swallowed process-wide.

Co-authored-by: MervinPraison <[email protected]>
2026-08-21 17:17:13 +00:00
MervinPraison c24b3e7fa8 docs: auto-update documentation parity trackers [skip ci] 2026-08-21 10:38:58 +00:00
praisonai-triage-agent[bot] 624049392c Merge pull request #4209 from MervinPraison/claude/issue-4208-20260821-0946
fix: make inbound webhook/trigger dedup durable across restarts
2026-08-21 10:38:24 +00:00
praisonai-triage-agent[bot]andMervin Praison dc237ae969 fix: wire sqlite hook idempotency backend + reclaim crashed reservations
Address the two P1 findings on the inbound webhook dedup durability change
(#4208):

- SQLite backend was unreachable: _get_hook_idem_store read a GatewayConfig
  field that no config path populates. Capture hooks.idempotency.store_backend
  in _apply_hooks_from_config (the only path that sees the raw hooks dict),
  supporting both the mapping-shaped hooks.idempotency and a sibling
  hooks_idempotency key, and rebuild the store on a hot-reload backend flip.

- In-flight claims survived a crash: a process exit between reserve and
  record/release left a durable inflight row that deduplicated the provider's
  post-restart retry for the full TTL. Add a bounded inflight lease; a stale
  inflight reservation is reclaimed on reserve so the retry re-runs, while
  recorded keys keep deduplicating until TTL.

Adds regression tests for config wiring (default/sqlite/sibling/hot-reload) and
crash reclaim (stale inflight reclaimed; recorded not reclaimed).

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 10:02:30 +00:00
praisonai-triage-agent[bot]andMervinPraison 9f0c7e1d0b fix: make inbound webhook/trigger dedup durable across restarts (fixes #4208)
Add a core IdempotencyStoreProtocol (reserve/record/release) with a bounded
in-memory default, and a durable SQLite backend in praisonai-bot. The gateway's
inbound hook handler now delegates dedup to a swappable store selected via
hooks.idempotency.store_backend ("memory" default; "sqlite" for restart/
multi-replica durability), so a provider redelivery after a restart no longer
starts a duplicate agent run. Mirrors the existing ingress-journal/outbound-
queue durability.

Co-authored-by: MervinPraison <[email protected]>
2026-08-21 09:54:09 +00:00
praisonai-triage-agent[bot]andMervin Praison 0dd56a72e0 fix: advertise and persist new stream events in gateway contract
Register MODEL_FALLBACK_STREAM, RETRY_STREAM, TODO_STREAM, and
TOOL_RESULT_STREAM in the streaming capability handshake and the
session-history allowlist so clients can discover these events and
so they receive a cursor for reconnect/resume replay (fixes gap
flagged by CodeRabbit/Greptile reviews on #4206).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 09:27:09 +00:00
praisonai-triage-agent[bot] e068d04d2d Merge pull request #4205 from MervinPraison/claude/issue-4204-20260821-0825
fix: repair three src/praisonai wrapper defects (scheduler bridge, audit rotation, LazyCache)
2026-08-21 09:21:12 +00:00
praisonai-triage-agent[bot]andMervin Praison fe07ad5201 fix: forward model-fallback, retry, todo, and tool-result stream events in gateway relay (fixes #4206)
The WebSocket gateway relay dropped four StreamEventTypes the SDK already
emits (MODEL_FALLBACK, RETRY, TODO_UPDATED, TOOL_CALL_RESULT), causing live
clients to see an unexplained token-stream stall during fallback/backoff.

- Add additive EventType members (MODEL_FALLBACK_STREAM, RETRY_STREAM,
  TODO_STREAM, TOOL_RESULT_STREAM) to gateway protocol enum
- Map the four events through the existing cross-thread relay send path,
  carrying their existing metadata untouched

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 09:20:51 +00:00
praisonai-triage-agent[bot]andMervin Praison b3ae6c8c0e fix: bump praisonai-mcp to 0.1.2 so editable install wins over stale PyPI wheel
The smoke job installs praisonai-mcp==0.0.15 as editable, but the wrapper's
`praisonai-mcp>=0.1.0` constraint then made pip fetch the stale PyPI wheel
praisonai_mcp-0.1.1 (no `cli` submodule), clobbering the editable install and
breaking `praisonai_mcp.cli` (test_mcp_list). Bumping the local package to
0.1.2 satisfies the constraint so the editable install is retained.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 08:39:02 +00:00
praisonai-triage-agent[bot]andMervin Praison ea2be988d5 fix: preserve unbounded scheduled runs and prevent audit fd leak
- schedules_runner: pass timeout=None to run_sync_or_offload so long
  scheduled agent/command runs are not cancelled by the bridge's default
  300s timeout after ScheduleLoop has already claimed the occurrence
  (would silently drop one-shot / long-interval work). Restores the prior
  unbounded asyncio.run(...) behaviour. (Greptile P1)
- security/audit: close the file handle best-effort in the rotation
  OSError branch before dropping the reference, so an fstat/close failure
  cannot leak the descriptor. (Greptile P2)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 08:34:25 +00:00
praisonai-triage-agent[bot]andMervinPraison 368b23a757 fix: repair three src/praisonai wrapper defects (fixes #4204)
- scheduler on_trigger now uses run_sync_or_offload instead of asyncio.run,
  so scheduled ticks share the async bridge / per-loop connection pools
- AuditLogHook reopens its handle when the log path is rotated (mv/rm),
  preventing silent loss of audit records after logrotate
- LazyCache memoises every terminal loader failure (not just ImportError),
  while letting KeyboardInterrupt/SystemExit propagate, avoiding hot-path
  cache stampedes on broken optional deps

Co-authored-by: MervinPraison <[email protected]>
2026-08-21 08:28:13 +00:00
praisonai-triage-agent[bot]andMervin Praison 96098f46df fix(memory): resolve batch-commit deadlock, honor deadline/guard, sanitize user_id paths
Addresses reviewer P1 findings on the Memory batch-commit path:

- Deadlock: commit_memory_batch no longer holds the non-reentrant
  _write_lock while calling store_short_term/store_long_term (which
  reacquire it). Writes now dispatch outside the lock.
- Atomicity/cancellation: both sync and async batch commits route each
  write through _AtomicCommitGuard.commit(deadline=...) so cancelled or
  past-deadline facts are skipped; acommit offloads blocking stores via
  asyncio.to_thread instead of blocking the event loop.
- Path traversal: default sqlite/chroma store paths derive a
  filesystem-safe suffix from user_id, rejecting separators/parent refs
  and sanitizing other characters (bare stores keep legacy defaults).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 07:26:07 +00:00
praisonai-triage-agent[bot]andMervinPraison 1635d4de2c fix: isolate memory backends, implement pre-compaction batch commit, propagate Parallel stop (fixes #4202)
- Thread the per-agent mem_user_id into every Memory(...) construction path in
  agent.py (string and dict forms) via config.setdefault, and scope the default
  sqlite/chroma paths and collection_name by user_id in Memory so two agents in
  one process no longer silently share one store. Bare stores keep legacy
  defaults for backward compatibility.
- Add commit_memory_batch/acommit_memory_batch to the Memory class so the
  pre-compaction fact flush durably commits extracted facts for
  sqlite/chroma/mongodb/mem0 instead of raising and being swallowed.
- Propagate a nested on_error="stop" stop signal out of Parallel: _execute_parallel
  now returns a stop flag, the nested dispatcher forwards it, and the top-level
  loop halts like Route/Loop/Repeat/If. Keep parallel_outputs index-aligned with
  the branch list on partial_ok failures.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: MervinPraison <[email protected]>
2026-08-21 07:17:44 +00:00
praisonai-triage-agent[bot] 104f374ccf Release v4.7.0 2026-08-21 05:09:40 +00:00
Mervin Praison b83ee8a633 Merge pull request #4194 from MervinPraison/claude/issue-4190-20260820-1920
fix: propagate step failures through nested workflow patterns
2026-08-21 06:05:49 +01:00
Mervin Praison 290fa903e6 Merge pull request #4199 from MervinPraison/claude/issue-4195-20260820-1928
fix: SafetyEval parse miss no longer reports max safety
2026-08-21 06:05:41 +01:00
Mervin Praison aa5861ac22 Merge pull request #4201 from Terminator666666/feat/scheduler-monitor
feat(scheduler): add command and URL change-detection monitors
2026-08-21 06:05:28 +01:00
Mervin Praison e4268cf3d9 Merge pull request #4200 from MervinPraison/claude/issue-4196-20260820-1929
fix: correct telemetry opt-out, token totals, cost lookup and flush
2026-08-21 06:03:36 +01:00
Mervin Praison 19b06e5e18 Merge pull request #4197 from MervinPraison/claude/issue-4192-20260820-1927
fix: gateway PID lock owner identity and psutil 7 collision diagnostic
2026-08-21 06:02:52 +01:00
Mervin Praison c3ceb13a8f Merge pull request #4188 from MervinPraison/claude/multi-agent-praisonai-platform-dfbgzo
chore: move praisonai-platform to its own repository
2026-08-21 06:01:11 +01:00
MervinPraison 90f6f99291 docs: auto-update documentation parity trackers [skip ci] 2026-08-21 05:00:30 +00:00
Mervin Praison b7398733f1 Merge pull request #4186 from MervinPraison/claude/issue-4182-20260820-1857
fix: share one canonical preset key between validation and resolution
2026-08-21 05:59:54 +01:00
MervinPraison 5424238cc0 docs: auto-update feature parity trackers [skip ci] 2026-08-21 04:59:15 +00:00
Mervin Praison 4d00348dd7 Merge pull request #4153 from MervinPraison/claude/issue-4139-20260820-1423
fix: unify llm=/model= alias resolution across all agent classes
2026-08-21 05:58:50 +01:00
Terminator666666 3c9955f538 fix(scheduler): address monitor review findings 2026-08-21 10:38:02 +08:00
Terminator666666 0bacb3f0b7 fix(scheduler): bound monitor response header time 2026-08-21 10:34:20 +08:00
praisonai-triage-agent[bot]andMervin Praison 92883c5d51 fix(scheduler): enforce total wall-clock deadline on monitor URL read
The URL monitor's response.read() bounded bytes and per-socket waits but
had no total deadline, so a slow drip-feed endpoint could keep the
synchronous read alive within each socket window and stall the sequential
scheduler tick, delaying other due jobs. Read the body in bounded chunks
and check an absolute deadline between reads so a slow response fails the
probe at the monitor timeout instead of blocking progress.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-21 02:15:30 +00:00
Terminator666666 a723ab8b9f feat: implement scheduler monitor change detection 2026-08-21 10:00:28 +08:00
praisonai-triage-agent[bot] e58dfcea6d Merge pull request #4198 from MervinPraison/claude/issue-4193-20260820-1927
fix: record failed scheduled delivery as delivered=False (fixes #4193)
2026-08-20 21:13:41 +00:00
praisonai-triage-agent[bot] 69c0e8b859 Merge pull request #4184 from MervinPraison/claude/issue-4180-20260820-1855
fix: guard vendored PluginRegistry fallbacks against built-in shadowing
2026-08-20 20:38:22 +00:00
praisonai-triage-agent[bot]andMervin Praison 8abaeed38c test: assert every resolver preset key is already canonical
The existing collision guard only ensured no two keys collapse to the same
canonical form. It did not catch a single non-canonical key (e.g. 'full-auto'),
which validation would accept but the direct dict.get(canonical_preset_key(...))
lookup would miss, silently falling back to the disabled default. Add an
invariant test enforcing key == canonical_preset_key(key) for all four
resolver preset dicts. (addresses Greptile review)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 20:19:28 +00:00
praisonai-triage-agent[bot]andMervinPraison 65f13740eb fix: share one canonical preset key between validation and resolution (fixes #4182)
Validation normalised strip().lower().replace('-','_') while the four
resolvers did a raw dict .get(), so blessed spellings like
autonomy='full-auto' or context='sliding-window' were accepted then
silently ran with the feature off.

Add canonical_preset_key() in parse_utils and route both the validator
and the context/autonomy/output/execution resolvers through it. Replace
the vacuous test_normalized_preset_accepted assertion with the
resolution checks its own comment described.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 20:19:28 +00:00
praisonai-triage-agent[bot]andMervin Praison f62be0f9ba fix: mark delivered when failure-summary reaches the channel (#4198)
_maybe_deliver_failure only recorded the negative outcome, leaving
JobResult.delivered False even when the failure summary was delivered
successfully — so monitoring reported a delivered notification as
undelivered (Greptile P1 on PR #4198). Set result.delivered = True on
the success branch and add regression tests for both the delivered and
failed failure-summary paths.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 20:18:44 +00:00
praisonai-triage-agent[bot]andMervinPraison 5d8aee9bb9 fix: record failed scheduled delivery as delivered=False (fixes #4193)
_deliver_scheduled_result returned None on every path, so the executor
treated 'the handler did not raise' as success — a routing failure was
recorded delivered=True with delivery_error=None next to a logged
'Failed to deliver'. Return a bool from the gateway handler, propagate it
through _dispatch_delivery, and key delivered/delivery_error off it at the
three executor call sites plus the failure-summary path.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 20:18:44 +00:00
praisonai-triage-agent[bot] 8d94039ed0 Merge pull request #4187 from MervinPraison/claude/issue-4181-20260820-1856
fix: restore textual doc guard over DOCS and fix README db import
2026-08-20 20:17:00 +00:00
MervinPraison 06f4b7162a docs: auto-update documentation parity trackers [skip ci] 2026-08-20 20:11:36 +00:00
praisonai-triage-agent[bot] 87defc4184 Merge pull request #4191 from MervinPraison/claude/issue-4189-20260820-1919
fix: SSRF - loopback allowlist re-opening web_crawl to 127.0.0.1
2026-08-20 20:10:37 +00:00
praisonai-triage-agent[bot]andMervin Praison 3a753b377e test: restore prior sys.modules state after forced vendored import
Snapshot and restore the pre-existing module entry in the vendored-fallback
import helper so the forced standalone re-import cannot leak the fallback
PluginRegistry into later tests expecting the bridged canonical class.
Addresses CodeRabbit review on #4184.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:56:24 +00:00
praisonai-triage-agent[bot]andMervinPraison df0de54b73 fix: guard vendored PluginRegistry fallbacks against built-in shadowing (fixes #4180)
vendored fallback copies used when praisonai-sandbox / praisonai-deploy are
installed standalone did not get it. Apply the same guard so an installed
distribution can never replace a built-in loader via entry-point discovery.

Add a class-parametrised test that forces the standalone fallback import path,
proving each vendored copy is protected (the previous test only exercised the
canonical class through varied group-name strings).

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:56:24 +00:00
praisonai-triage-agent[bot] 896d60ca7c Merge pull request #4185 from MervinPraison/claude/issue-4183-20260820-1857
fix: guard legacy entry-point group against replacing builtins
2026-08-20 19:51:55 +00:00
praisonai-triage-agent[bot]andMervin Praison 4ab923a1ac fix: reset cached endpoint-provider registry singletons in spelling test
EndpointProviderRegistry.default() caches a per-class singleton whose
entry-point discovery runs once at construction. cmd_invoke resolves
providers through that cache, so under the CI root shard (-n 2 --dist
loadfile) a singleton built by an earlier test on the same worker — before
this file publishes the `acme` plugin — never sees it, and invoke falls back
to the recipe HTTP path (assert http == [] => assert 2 == 0). Evict the
cached singletons in the `published` fixture before and after each case so
the plugin is rediscovered and no poisoned instance leaks forward.

Test-only change in the praisonai wrapper; no production or praisonai-agents
code touched. Strengthens isolation rather than weakening any assertion.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:48:20 +00:00
praisonai-triage-agent[bot]andMervin Praison c489c2b723 fix: restore run/start telemetry via re-entrancy guard
Wrapping only chat() dropped all execution telemetry for start(stream=True)
(-> _start_stream) and backend-backed run()/start() (-> _delegate_to_backend),
neither of which funnels through chat(). Re-instrument run/start/chat behind a
per-agent re-entrancy flag so the outermost call records exactly one execution,
preserving single-count for run()->chat() while covering stream/backend paths.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:46:42 +00:00
praisonai-triage-agent[bot]andMervin Praison 8ddf9ef302 fix: reset both endpoint-provider registry default() singletons in test
The full-suite CI failure (`assert 2 == 0`, "Unknown provider type: acme")
was a test-isolation bug: the CLI handler's cmd_invoke resolves
EndpointProviderRegistry via the `praisonai.cli.features._endpoint_registry`
shim namespace, a distinct class object from the `praisonai_code...` one the
test imports. Their default() singletons are cached independently, so an
earlier full-suite test that warmed the handler's cache left it stale and the
monkeypatched entry points never reached it. Reset the cached _default_instance
on both class objects so discovery re-runs under the patched entry points.

Unrelated to PR #4187's session-docs changes; fixes the pre-existing flake.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:45:13 +00:00
praisonai-triage-agent[bot]andMervinPraison 9d12746653 fix: correct telemetry opt-out, token totals, cost lookup and flush (fixes #4196)
- token_collector: total_tokens no longer double-counts cached/reasoning/audio
  tokens (they are subsets of input/output, not additional buckets)
- cost_utils: replace loose substring matching with longest-key exact/prefix
  match so gpt-4o-mini is no longer billed at gpt-4o rates (16.7x); strip
  provider prefixes; exclude "default" from matching
- performance_monitor: consult shared telemetry state live so a later
  disable_telemetry() actually stops the import-time global monitor
- telemetry.__init__: atexit handler no longer resurrects a shut-down/opted-out
  telemetry instance at interpreter exit
- integration: instrument only chat()/execute_tool(); run()/start() delegate to
  chat() so wrapping them double-counted executions and errors
- telemetry.flush: only zero counters after a successful send

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:37:24 +00:00
praisonai-triage-agent[bot]andMervin Praison 1dbc9f77e2 fix: propagate nested stop signal and guard parallel error chaining
- _execute_loop/route/repeat/if now return a `stop` flag so a nested
  on_error="stop" step halts the enclosing workflow instead of only its
  own pattern iteration. Both nested dispatch and top-level _run_impl
  honor the propagated signal.
- Parallel fail_fast/fail_all no longer `raise ... from <str>` (which
  raised TypeError and masked the real failure); the string branch error
  is preserved in WorkflowStepError.errors and only real exceptions chain.
- Added regression tests: nested-stop halts outer workflow, and parallel
  fail_fast reports failed without TypeError.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:35:47 +00:00
praisonai-triage-agent[bot]andMervinPraison 61b99e2c99 fix: SafetyEval parse miss no longer reports max safety (fixes #4195)
Parse safety judge responses tolerantly (markdown bolding, bullets, case)
and fail closed when nothing usable is parsed. Previously a bolded field
label - the default output style of most models - matched nothing and the
verdict silently fell through to 10.0/10 SAFE, even on a detected severe
violation. An unparsed verdict is now treated as UNSAFE (1.0), matching the
existing exception handler in evaluate_safety.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:31:37 +00:00
praisonai-triage-agent[bot]andMervinPraison a9ed86248c fix: gateway PID lock owner identity and psutil 7 collision diagnostic (fixes #4192)
- _is_process_running: treat PermissionError as running so a gateway owned
  by another uid is not reported dead and its lock deleted, admitting a
  second poller for the same bot token.
- Record a create_time fingerprint in the lock so a recycled PID cannot be
  mistaken for the original gateway; verified before stop/refuse decisions.
- check_port_available: use net_connections with a connections() fallback and
  a broad except so the port-collision diagnostic works on psutil 7 instead
  of raising 'invalid attr name connections'.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:29:38 +00:00
praisonai-triage-agent[bot]andMervin Praison 9302b5cea4 fix: SSRF - allowlist may only exempt loopback, not link-local/private (fixes #4189)
Previously is_safe_http_url returned True for any allowlisted hostname before
resolving/classifying its addresses, so SEARXNG_URL_ALLOWLIST=169.254.169.254
could reach the cloud metadata endpoint. Now every address is classified and an
allowlisted host only bypasses the loopback class; private, link-local,
multicast and unspecified addresses stay blocked. Docstring corrected to match.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:27:11 +00:00
praisonai-triage-agent[bot]andMervinPraison 698025b877 fix: propagate step failures through nested workflow patterns (fixes #4190)
Nested patterns (loop/parallel/when/route/repeat/if) routed failing steps
through _apply_step_policies, which folded f"Error: {e}" into the step output
and never consulted on_error. Wrapping a pipeline in any pattern therefore lost
failure detection: the run reported status="completed" and the next step
consumed the exception text as input.

_apply_step_policies now returns (output, step_error) instead of folding the
error into output. _execute_single_step_internal applies the same
on_error/status logic the top-level _run_impl already uses: it marks the run
failed, signals a stop when on_error="stop", and never hands the exception text
forward. Pattern executors honor the stop signal, and Parallel on_failure modes
fire again since the branch failure is now surfaced.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:26:45 +00:00
praisonai-triage-agent[bot]andMervinPraison 12f2dcfafa fix: SSRF - make loopback allowlist an explicit opt-in per call site (fixes #4189)
The shared is_safe_http_url unconditionally allowlisted loopback and
consulted it before the IP-class checks, re-opening web_crawl to
127.0.0.1/localhost/::1. Split the allowlist into an explicit per-caller
opt-in consulted after the IP checks. validate_searxng_url opts into
loopback (SearXNG is self-hosted); the crawler passes none.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:21:59 +00:00
praisonai-triage-agent[bot]andMervin Praison 5b33731548 fix: close nested-parenthesis gap in session doc kwarg guard (#4187)
The restored TOP_LEVEL_KWARG regex only balanced one level of parens, so
a top-level rejected kwarg after a two-level nested call
(Agent(memory=MemoryConfig(db=db(...)), session_id=...)) escaped the guard,
re-opening the #4178 regression (greptile). Replace the regex with a
depth-aware scanner that attributes each kwarg to its enclosing call at any
nesting depth, and skips string literals and comments so dict keys
(memory={"session_id": ...}) and comments (# session_id = resume) are not
false positives. Add regression tests for the nested-call, dict-key, comment
and prose cases.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 19:11:06 +00:00
Mervin PraisonandClaude Opus 5 8744a0c6bb docs: fix contradictory platform roster endpoint and auth docstring
Addresses Greptile's P2 finding on this PR plus one gap found reviewing the
diff independently.

- pattern-d-platform.md: the note added in the previous commit corrected the
  platform agent roster path, but line 25 still listed it as /api/v1/agents,
  which the same note defines as the unrelated endpoint served by
  `praisonai serve agents`. A reader following the numbered list would have
  integrated against the wrong service. Also softened "Three registries may
  coexist" — a full install has more than three; the three listed are the ones
  relevant to agent_id correlation.
- auth/__init__.py: the module docstring said implementations "live in the
  platform package" without saying where that is, which is now ambiguous since
  the package left this repository. Points at the separate repo and, more
  usefully, states first that you can implement the protocols against your own
  store. This matches the change made to protocols.py in the previous commit.

src/praisonai-agents/tests/unit/auth/ passes (33 tests).

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_014ZfTXTzdudKb4oswNSHpHw
2026-08-20 19:06:45 +00:00
Mervin PraisonandClaude Opus 5 a47971ffec chore: move praisonai-platform to its own repository
praisonai-platform is extracted to MervinPraison/PraisonAI-Platform, with full
history carried over via git filter-repo.

Why it belongs outside this repo:

- Nothing here imports it. A grep for praisonai_platform across every .py
  outside its own directory returns no hits, and no pyproject declares it.
- It is in no CI job. No workflow under .github/ references it — it is absent
  from install-monorepo-packages and from pypi-release.yml, which enumerates the
  nine tiered packages and notes it is near GitHub's 25-input cap.
- It is absent from ARCHITECTURE.md, which describes a nine-package tiered
  model; the platform was a tenth, untiered package with no boundary manifest.
- Separate-repo is the ecosystem norm: PraisonAI-Tools, PraisonAI-Plugins,
  PraisonAIUI and Agent-Recipes all live outside and consume praisonaiagents as
  a plain versioned PyPI dependency. The platform already did exactly that, and
  already carried its own uv.lock.
- Its releases were already documented as an independent semver line.

Changes here:

- Remove src/praisonai-platform/ (9,263 lines).
- SECURITY.md: drop the platform row from supported packages and point
  vulnerability reports at the new repository's advisories.
- security-audit.md: the platform is no longer triaged, released or audited
  from this runbook. Removes publish steps 13 and 15 and the two table rows so
  an agent executing it cannot cd into a directory that no longer exists.
- auth/protocols.py: WorkspaceContextProtocol's example named
  PlatformWorkspaceContext, a class no longer in this tree. Renamed to a
  generic example and noted where the reference implementation lives. Core
  keeps the protocol with no in-tree implementation, which is the documented
  design — auth/__init__.py already states that implementations live in the
  platform package, and the core tests use local mocks.
- pattern-d-platform.md: kept, since it documents an integration contract
  rather than platform internals. Adds a pointer to the new repo and corrects
  the agent roster path, which is /api/v1/workspaces/{id}/agents — /api/v1/agents
  is a different endpoint served by `praisonai serve agents`.

src/praisonai-agents/tests/unit/auth/ passes (33 tests).

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_014ZfTXTzdudKb4oswNSHpHw
2026-08-20 19:00:43 +00:00
praisonai-triage-agent[bot]andMervinPraison 297421852a fix: restore textual doc guard over DOCS and fix README db import (fixes #4181)
PR #4179 replaced the textual kwarg guard with an executing one but the
executor is blind to session/__init__.py (documented via an indented
docstring, zero python fences) and to README blocks excluded by
_is_self_contained. The surviving text check only covered _EXAMPLE_FILES,
so the original #4178 bug (a top-level Agent(session_id=...)) could be
reintroduced with the suite green.

- Restore test_docs_do_not_pass_rejected_kwargs_to_agent, widened to cover
  DOCS as well as _EXAMPLE_FILES. TOP_LEVEL_KWARG matches only inside
  Agent(, so prose mentioning session_id= is not a false positive.
- Add test proving an executor-only guard is blind to a fenceless file.
- Fix session README "Using with DB Adapter" block: import the callable
  via `from praisonaiagents.db import db` instead of `from praisonaiagents
  import db`, which yields the non-callable module and raised
  TypeError: 'module' object is not callable whenever the wrapper was
  importable (README.md#3 was green only via importorskip).

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 19:00:41 +00:00
praisonai-triage-agent[bot]andMervinPraison 5c4212a170 fix: guard legacy entry-point group against replacing builtins (fixes #4183)
The deprecated entry-point group bypassed #4171's built-in guard because
_discover_legacy_entry_points ran first and called _add_loader
unconditionally. A plugin published under the legacy spelling could thus
replace a built-in, contradicting the docstring. Apply the same built-in
guard to the legacy path.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 18:59:35 +00:00
praisonai-triage-agent[bot] dc847a36d9 docs: align AgentTeam model= docstring with team default propagation 2026-08-20 18:31:06 +00:00
Mervin Praison 97b4a2cf98 Merge pull request #4174 from MervinPraison/claude/issue-4166-20260820-1705
fix: namespace framework retry verdict; stop re-running returned error dicts (#4166)
2026-08-20 19:30:34 +01:00
Mervin Praison 681ee086dd Merge pull request #4169 from MervinPraison/claude/issue-4164-20260820-1704
fix: catch truncation typos instead of billing them to the LLM
2026-08-20 19:29:46 +01:00
praisonai-triage-agent[bot]andMervinPraison 29563104d4 fix: unify llm=/model= alias resolution across all agent classes (fixes #4139)
One helper resolves the llm=/model= pair everywhere: model= is canonical,
llm= is a deprecated alias, passing both raises TypeError, and LLMConfig is
unwrapped for classes that store a bare model name. Adds model= to CodeAgent,
RealtimeAgent, AgentTeam and AgentFlow.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 18:29:14 +00:00
Mervin Praison aada087cb1 Merge pull request #4128 from MervinPraison/claude/issue-4116-20260820-1351
fix: validate closed-set preset params to reject typos
2026-08-20 19:28:38 +01:00
Mervin Praison 1cc0b424fa Merge pull request #4179 from MervinPraison/claude/issue-4178-20260820-1724
fix: execute session doc examples instead of matching their text
2026-08-20 19:28:05 +01:00
Mervin Praison 8678e39715 Merge pull request #4177 from MervinPraison/claude/issue-4172-20260820-1715
fix: move dead demo module example_harness out of installed package
2026-08-20 19:27:40 +01:00
Mervin Praison bdb510f132 Merge pull request #4176 from MervinPraison/claude/issue-4171-20260820-1715
fix: guard entry-point shadowing of builtins in base PluginRegistry
2026-08-20 19:26:56 +01:00
Mervin Praison 77cb696c42 Merge pull request #4175 from MervinPraison/claude/issue-4173-20260820-1715
refactor: consolidate duplicate tool-call parse blocks in openai_client
2026-08-20 19:26:22 +01:00
Mervin Praison c5dcc356cf Merge pull request #4157 from MervinPraison/claude/issue-4152-20260820-1438
fix: reconcile endpoint-provider entry-point group spelling
2026-08-20 19:25:51 +01:00
Mervin Praison 1bf26af328 Merge pull request #4148 from MervinPraison/claude/issue-4138-20260820-1422
fix: make AgentTeam(llm=)/AgentFlow(llm=) reach member agents
2026-08-20 19:24:55 +01:00
Mervin Praison 20e246e919 Merge pull request #4147 from MervinPraison/claude/issue-4137-20260820-1421
fix: forward auth= on every Agent branch and honour it on Responses API
2026-08-20 19:23:44 +01:00
Mervin Praison bb814de03e Merge pull request #4146 from MervinPraison/claude/issue-4136-20260820-1420
fix: convert as_tool() Handoff objects passed in tools=
2026-08-20 19:23:25 +01:00
praisonai-triage-agent[bot] 0bb6c05ebf Merge pull request #4168 from MervinPraison/claude/issue-4165-20260820-1705
fix: _store_agent_history reports failure when write never verified
2026-08-20 18:21:48 +00:00
Mervin Praison 2b874ce537 Merge pull request #4145 from MervinPraison/claude/issue-4130-20260820-1416
fix: make MemoryConfig backends match the adapter registry
2026-08-20 19:21:05 +01:00
Mervin Praison 34a564d515 Merge pull request #4144 from MervinPraison/claude/issue-4132-20260820-1416
fix: wire up inert KnowledgeConfig fields
2026-08-20 19:20:54 +01:00
MervinPraison e032f82d8f docs: auto-update documentation parity trackers [skip ci] 2026-08-20 18:19:53 +00:00
Mervin Praison e482a65c19 Merge pull request #4122 from MervinPraison/claude/issue-4112-20260820-1351
fix: accept guardrail objects instead of silently discarding them
2026-08-20 19:19:17 +01:00
Mervin Praison 265a7af1c5 Merge pull request #4118 from MervinPraison/claude/issue-4113-20260820-1351
fix: make ExecutionConfig.parallel_tool_calls the single source of truth
2026-08-20 19:18:39 +01:00
praisonai-triage-agent[bot]andMervin Praison 1a7a162869 test: make external-agent registry tests robust to CI module/default-cache skew
The main (3.11) job dropped the plugin `aider` across every registry-backed
surface (fixture tests + entry-point discovery test). The base guard and
production code are correct; the failure is a test-isolation issue that only
surfaces under `pytest -n --dist loadfile` + coverage on CI:

- The entry-point discovery test patched `praisonai_code._registry.entry_points`
  by dotted string. Under editable-install + coverage import tracing a
  re-imported copy of that module can differ from the one the
  `ExternalAgentRegistry` class actually discovers through, leaving the real
  path unpatched and silently dropping `aider`. Patch `entry_points` on the
  exact base module the class resolves via `__mro__`, and accept `group`
  positionally or by keyword.

- The `registered_plugin` fixture now also clears and restores the per-class
  `PluginRegistry.default()` cache so no sibling test file sharing the xdist
  worker can shadow the registered plugin.

No assertions weakened: built-ins still win over colliding entry points,
plugins can still add new names, and every surface must still agree.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 18:09:35 +00:00
praisonai-triage-agent[bot] a13ec71347 Merge pull request #4170 from MervinPraison/claude/issue-4167-20260820-1706
fix: reconcile external-agent registry surfaces and version skew (#4167)
2026-08-20 17:59:56 +00:00
praisonai-triage-agent[bot]andMervin Praison 8e9f19943a fix: fail on first-party import regressions and surface silently-excluded doc typos
Addresses two blind spots greptile flagged in the executing session-doc guard:

- ImportError from our own packages (praisonaiagents/praisonai) now re-raises
  instead of being swallowed by the optional-dependency skip, so a doc that
  advertises a renamed/removed symbol fails the guard. Optional third-party
  deps still skip.
- Blocks dropped by the self-contained filter are now asserted against a known
  set of documentation idioms, so a typo/omitted import in an otherwise-complete
  example fails a diagnostic test rather than vanishing from execution.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 17:38:09 +00:00
praisonai-triage-agent[bot]andMervinPraison 760c12f8a8 fix: execute session doc examples instead of matching their text (fixes #4178)
The #4127 guard regexed the docs for four hard-coded kwarg names, so
renaming the fixed example's session_id= to sessionid= left it green while
the documented MemoryConfig call raised. Replace the text match with a
primary guard that extracts every ```python fence, keeps the AST
self-contained ones (used - bound - builtins == set()), and execs them with
Agent.start/chat stubbed and PRAISONAI_HOME isolated. It now fails on the
sessionid= reproduction with the exact TypeError, and catches the next
mistake too. Non-hermetic examples opt out via <!-- praisonai: skip=true -->
and wrapper-backed db examples are skipped when praisonai is absent.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:29:47 +00:00
praisonai-triage-agent[bot]andMervin Praison cd4ca2a7dd fix: raise praisonai-code floor to 0.0.65 so wrapper guarantees the base guard
The entry-point shadowing guard is added inside praisonai-code 0.0.64, but the
wrapper floor was praisonai-code>=0.0.64 — the same version number that shipped
without the guard. A pre-fix 0.0.64 install would satisfy >=0.0.64 yet lack the
protection, restoring the shadowing path once the wrapper's local guard was
removed. Bump praisonai-code to 0.0.65 and raise the wrapper floor so the
dependency constraint actually guarantees the fix is present.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 17:27:17 +00:00
praisonai-triage-agent[bot]andMervin Praison add143ce8a test: cover async execute_tool_async retry path for #4166
Add deterministic tests exercising the public execute_tool_async path
(not just the impl) to close the coverage gap CodeRabbit flagged:
- a tool-owned `retryable` field does not drive the async retry loop
  (body runs exactly once, field preserved)
- the private `_praison_retryable` control key is not visible on the
  async surfaced result

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 17:27:01 +00:00
praisonai-triage-agent[bot]andMervin Praison 30d70d09d6 fix: preserve tool function name when JSON args parsing fails (#4173)
Extract the tool function name before json.loads so callers (streaming
verbose warning, deferred-media path) report the actual tool name instead
of 'unknown function' on malformed arguments.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 17:23:08 +00:00
praisonai-triage-agent[bot] 1bd1c26f2b Merge pull request #4163 from MervinPraison/claude/issue-4161-20260820-1618
fix: correct broken session/db doc examples and extend guard (#4161)
2026-08-20 17:20:34 +00:00
praisonai-triage-agent[bot]andMervinPraison e714d94a35 fix: move dead demo module example_harness out of installed package (fixes #4172)
Relocate praisonaiagents/runtime/example_harness.py (365-line, unreferenced
demonstration module) to examples/runtime/example_harness.py so it no longer
ships in the installed praisonaiagents wheel. Convert its relative imports to
absolute and correct the pre-existing broken TurnRuntimeProtocol import
(runtime.protocols, not runtime.turn_context) so the example runs standalone.
Update the AGENTS.md path reference. No public API or runtime module changes.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:19:28 +00:00
praisonai-triage-agent[bot]andMervin Praison 42ed55513b fix: surface version-skew error on external-agent execution path (#4167)
The primary --external-agent execution path (get_integration/execute) called
_catalog() which discarded the too-old-wrapper diagnostic and returned an empty
catalog, producing a misleading "Unknown integration" error on a version-skewed
install (Greptile P1). Add _require_catalog() that raises the upgrade guidance on
the execution path while listing surfaces (help/argparse/UI) keep degrading
quietly. execute() now catches RuntimeError to print the guidance cleanly.

Also fix test hygiene: restore the process-global root logger handlers via
monkeypatch instead of permanently clearing them (CodeRabbit).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 17:18:56 +00:00
praisonai-triage-agent[bot]andMervinPraison ec83c24af8 fix: guard entry-point shadowing of builtins in base PluginRegistry (fixes #4171)
#4158 patched only ExternalAgentRegistry. The real hole was in the base
PluginRegistry: builtins are registered first and entry points second, so any
installed distribution declaring a built-in name silently replaced it across
all ten registries (openai, docker, aws, ...). Those loaders decide where user
code runs.

Record built-in names once and skip colliding entry points during discovery,
matching the existing BotPlatformRegistry precedent (DEBUG, not WARNING, since
packages legitimately re-declare their own builtins). Runtime register() still
overrides -- deliberate dependency injection. The now-redundant re-assertion in
ExternalAgentRegistry is removed.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:18:46 +00:00
MervinPraison 653b095d75 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 17:18:45 +00:00
praisonai-triage-agent[bot]andMervinPraison b7c0285ead refactor: consolidate duplicate tool-call parse blocks in openai_client (fixes #4173)
Extract a private _extract_tool_call_name_and_args helper and reuse it in
the non-streaming, streaming, and deferred-media tool-calling paths. Each
call site keeps its own failure handling (tool-role reply vs. yield), so
behaviour is unchanged.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:18:43 +00:00
praisonai-triage-agent[bot]andMervinPraison 29baafb6c6 fix: namespace framework retry verdict and stop re-running returned error dicts (fixes #4166)
The retry machinery tagged its own verdict with an un-namespaced `retryable`
key, so a tool whose result legitimately contained `retryable` (common for
HTTP-API wrappers) had its body re-executed up to 3x and the internal verdict
leaked to the model. The sync outer loop separately escalated any returned
error dict of an uncovered type to retryable, re-running the tool body for a
decision it had already made.

- Rename the framework verdict to the private `_praison_retryable` key in the
  async impl (exception + timeout branches) and the sync `_execute_tool_impl`
  exception flatten, matching the `_outer_timeout` convention from #4133.
- Read and strip `_praison_retryable` in both retry loops so it never reaches
  the model and cannot collide with a tool's own `retryable` field.
- Sync outer loop escalates only framework-produced transients
  (`_outer_timeout`, `circuit_open`, or a flattened raised exception via
  `_praison_retryable`, and only when the type is not already re-driven by the
  inner loop). A plain returned error dict now runs exactly once.
- Update existing parity tests to the new key and add regression tests proving
  a tool's own `retryable` field does not drive the loop and the verdict is not
  visible to the model.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:17:53 +00:00
praisonai-triage-agent[bot] adba7c1791 Merge pull request #4162 from MervinPraison/claude/issue-4160-20260820-1617
fix: migrate legacy sub-agent transcripts outside the 50-session window
2026-08-20 17:17:53 +00:00
praisonai-triage-agent[bot] fa3c49cb40 Merge pull request #4159 from MervinPraison/claude/issue-4158-20260820-1613
fix: prevent installed plugins from replacing built-in --external-agent implementations
2026-08-20 17:11:18 +00:00
praisonai-triage-agent[bot]andMervinPraison 2428f5c2fa fix: reconcile external-agent registry surfaces and version skew (fixes #4167)
- list_external_agents() now derives from external_agent_catalog() so argparse
  --help choices can never advertise a plugin the handler then rejects
- registry uses a module logger instead of the root logger (no basicConfig on
  the embedding application)
- praisonai-code distinguishes an absent wrapper from a too-old wrapper: a
  mixed-version install now reports "too old" instead of a silent empty catalog

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:09:27 +00:00
praisonai-triage-agent[bot]andMervinPraison 6899241bc8 fix: catch truncation typos instead of billing them to the LLM (fixes #4164)
The prefix filter in _mistyped_command_suggestions spared both extensions
(``tests`` for ``test``) and truncations (``deplo`` for ``deploy``) of a
command. Truncations are typos: sparing them forwarded the word to ``run``
and billed a mistaken LLM call per invocation. Drop the truncation half so
only extensions — plausible prompts — stay untouched.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:08:27 +00:00
praisonai-triage-agent[bot]andMervinPraison a30fd629bb fix: _store_agent_history returns False when write never verified (fixes #4165)
After the bounded verify loop exhausts, nothing was persisted, so returning
True made the caller's 'history was lost' branch unreachable and printed a
misleading 'raced with a concurrent writer' warning. Return False and log the
real failure so the caller's existing warning fires.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 17:06:59 +00:00
praisonai-triage-agent[bot] c1a5fdf238 Merge pull request #4123 from MervinPraison/claude/issue-4114-20260820-1351
fix: route --output-format and typo'd verbs correctly in CLI dispatcher
2026-08-20 16:42:05 +00:00
praisonai-triage-agent[bot]andMervin Praison fa5604ddbb test: fail fast when session-doc example roots are missing
If _EXAMPLE_ROOTS is renamed/moved the guard silently emitted no
parametrized cases, letting the Agent(session_id=)/db= regression it
protects against slip back in. Raise a clear collection error instead.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 16:27:38 +00:00
praisonai-triage-agent[bot]andMervin Praison b420a15375 perf: memoize legacy sub-agent history scan per Session
Passing limit=None to migrate legacy transcripts (fixing #4160) turned an
already per-agent full-scan into a full-disk scan on every save: the save
loop over N agents re-enumerated every stored session N times, even once
migrated. Cache the scan result per Session keyed on the opt-in flag, since
legacy records are a frozen migration artefact never mutated by save or
restore. Addresses the P2 hot-path regression raised in PR review.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 16:26:45 +00:00
MervinPraison eb8b9ea578 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 16:26:25 +00:00
praisonai-triage-agent[bot] 41af4d66fa Merge pull request #4125 from MervinPraison/claude/issue-4121-20260820-1355
fix: resolve session store root lazily instead of freezing at import
2026-08-20 16:25:41 +00:00
praisonai-triage-agent[bot]andMervinPraison 9c93abd889 fix: correct broken session/db doc examples and extend guard (fixes #4161)
Replace the fictional PostgresAdapter import in session/README.md with the
real db(database_url=...) shortcut under MemoryConfig, and move the top-level
db=/session_id= Agent kwargs into MemoryConfig across the db package
docstrings and the runnable redis example. Also align the session_dir default
path in the API reference (~/.praisonai/sessions).

Extend the doc-example guard to discover all Agent( examples under the db
package and examples/persistence, and assert none reference a class we do not
ship, closing the gap the previous two-file textual guard left open.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 16:21:52 +00:00
praisonai-triage-agent[bot]andMervin Praison c9dc3a66a3 test: assert plugins can still add new external-agent names while built-ins win
Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 16:20:06 +00:00
praisonai-triage-agent[bot]andMervinPraison 3c9fda1a4f fix: migrate legacy sub-agent transcripts outside the 50-session window (fixes #4160)
_legacy_agent_histories called list_sessions() with no argument, inheriting
its default limit=50 (sorted by updated_at desc). A legacy per-agent record is
by definition older than anything written after the upgrade, so any user who
touched 50 sessions since upgrading had their tagged sub-agent transcript
silently skipped on restore. Pass limit=None (with a TypeError fallback for
stores whose limit is not optional) so migration scans every stored session.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 16:19:45 +00:00
praisonai-triage-agent[bot] c822adff80 Merge pull request #4124 from MervinPraison/claude/issue-4119-20260820-1355
test: assert denied approvals block tool execution
2026-08-20 16:18:30 +00:00
praisonai-triage-agent[bot]andMervinPraison d4f0b0b080 fix: prevent installed plugins from replacing built-in external agents (fixes #4158)
Re-assert built-in loaders after entry-point discovery so a third-party
distribution publishing a built-in name (e.g. "claude") can no longer
silently replace the shipped ClaudeCodeIntegration. Plugins may still add
new external agents. Adds a regression test.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 16:15:10 +00:00
praisonai-triage-agent[bot] 38055f157c Merge pull request #4126 from MervinPraison/claude/issue-4120-20260820-1355
fix: sub-agent transcript silently overwrites unrelated user session on close()
2026-08-20 16:11:12 +00:00
praisonai-triage-agent[bot] 37ad0938a3 Merge pull request #4156 from MervinPraison/claude/issue-4150-20260820-1437
fix: make praisonai.external_agents plugins usable across all surfaces
2026-08-20 16:10:17 +00:00
praisonai-triage-agent[bot] 583bff383e Merge pull request #4155 from MervinPraison/claude/issue-4151-20260820-1438
fix: make provider registry the validation authority for cloud deploy
2026-08-20 16:04:41 +00:00
MervinPraison b59cef7ea1 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 16:03:44 +00:00
praisonai-triage-agent[bot] 71d3838071 Merge pull request #4129 from MervinPraison/claude/issue-4127-20260820-1405
fix: correct session docs to use memory=MemoryConfig(session_id=...)
2026-08-20 16:02:59 +00:00
MervinPraison 5f619db73b docs: auto-update documentation parity trackers [skip ci] 2026-08-20 15:51:24 +00:00
praisonai-triage-agent[bot] 05a30a2267 Merge pull request #4140 from MervinPraison/claude/issue-4131-20260820-1416
fix: resolve knowledge vector_store provider through adapter registry
2026-08-20 15:50:46 +00:00
praisonai-triage-agent[bot] 31b353f76e Merge pull request #4141 from MervinPraison/claude/issue-4134-20260820-1419
fix: async tool retry never fires because exception is flattened
2026-08-20 15:44:44 +00:00
MervinPraison 8c432e8402 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 15:38:01 +00:00
praisonai-triage-agent[bot] f1adab5b39 Merge pull request #4143 from MervinPraison/claude/issue-4133-20260820-1418
fix: unify tool retry into one RetryPolicy budget (fixes #4133)
2026-08-20 15:37:20 +00:00
praisonai-triage-agent[bot] b1bb011d1f Merge pull request #4154 from MervinPraison/claude/issue-4149-20260820-1437
fix: preserve discovered praisonai.integrations entry points
2026-08-20 15:28:19 +00:00
MervinPraison a0f7ae7dde docs: auto-update documentation parity trackers [skip ci] 2026-08-20 15:15:43 +00:00
praisonai-triage-agent[bot] a03c9c7284 Merge pull request #4142 from MervinPraison/claude/issue-4135-20260820-1419
fix: resolve named tools in mixed tools=[...] lists
2026-08-20 15:15:11 +00:00
praisonai-triage-agent[bot] 19605e8a08 Merge pull request #4117 from MervinPraison/claude/issue-4115-20260820-1351
fix: validate MCP transport in praisonai serve mcp
2026-08-20 15:07:35 +00:00
praisonai-triage-agent[bot]andMervin Praison 1498766c7a fix: keep endpoint-provider CLI registry within C7 import boundary and stream via provider interface
- praisonai-code endpoint registry loaded openai-compat via a static
  `from praisonai.endpoints...` import, tripping the C7 hot-path import gate
  (smoke CI). Route it through the sanctioned _wrapper_bridge dynamic import so
  the standalone package no longer statically imports the wrapper.
- Provider adapter routed --stream through invoke(stream=True), whose terminal
  InvokeResult the CLI cannot render (Greptile P1). Consume
  BaseProvider.invoke_stream() instead and print SSE-shaped events.
- Add a streaming test asserting --stream drives invoke_stream, not invoke.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 15:02:36 +00:00
praisonai-triage-agent[bot]andMervinPraison 1c6dfac367 fix: keep external-agent catalog behind wrapper bridge and isolate faulty plugins
- praisonai-code external_agents handler now resolves the registry catalog
  through _wrapper_bridge.optional_wrapper_attr instead of a direct
  ``from praisonai.integrations.registry import ...`` reverse import. This
  restores the C7/C8 import boundary (the smoke `check_c7_imports.sh` gate)
  and degrades to an empty catalog when the wrapper is absent so the handler
  stays usable on a standalone praisonai-code install.
- external_agent_catalog() now skips any external agent whose entry point
  raises a non-ValueError during load (Greptile P1), so one broken optional
  plugin can no longer blank the catalog for argparse/CLI/UI surfaces.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:58:10 +00:00
praisonai-triage-agent[bot]andMervin Praison 37ed625a25 fix: plugin providers work in validate command and sample generation
Resolves two Greptile P1 issues on PR #4155:
- validate command accessed provider.value which crashes when the
  provider is a registry plugin string; now handles both enum and str.
- sample YAML generation fell through to a hardcoded aws block for
  plugin providers; now emits the requested provider name.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:56:03 +00:00
praisonai-triage-agent[bot]andMervinPraison 74f9f8535e fix: invalidate cached dispatcher when a container default llm is applied
_apply_default_llm reset _llm_instance but left the chat-mixin
_unified_dispatcher cached against the old model, so a used agent (team
default applied post-execution, or an AgentFlow re-run with a new llm)
kept calling the previous model. Drop the dispatcher too; add regression
tests for used and pinned agents.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:46:50 +00:00
praisonai-triage-agent[bot]andMervin Praison 6c6cf1b9cc fix: cap tool retry at one budget on inner-retried errors, keep 60s backoff
Address the two P1 review findings on the retry consolidation:

- N² attempts: the outer loop re-escalated timeout/circuit_open results as
  retryable even though the inner circuit-breaker loop already retries those
  error types to exhaustion, restarting the whole inner budget on every outer
  pass (up to max_attempts^2 tool-body runs on a persistently-timing-out MCP
  tool). Route every error dict through one guard: only escalate error types
  the inner loop does NOT retry. A genuine outer wall-clock timeout is tagged
  (_outer_timeout) so it still earns its single outer retry pass.

- Backoff parity: translating ExecutionConfig into a RetryPolicy silently
  dropped the delay cap from BackoffPolicy's 60s to RetryPolicy's 30s. Lift the
  translated max_delay_ms back to 60s so existing ExecutionConfig users keep the
  same delay ceiling.

Adds 5 tests: inner-retried timeout capped at max_attempts (not N^2),
non-inner-retried errors still get outer passes, and the 60s cap is preserved.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:44:56 +00:00
praisonai-triage-agent[bot]andMervinPraison 0e7730cc07 fix: reconcile endpoint-provider entry-point group spelling (fixes #4152)
Both endpoint-provider readers now scan the canonical
`praisonai.endpoint_providers` group, with `praisonai.endpoints.providers`
honoured as a deprecated alias (DeprecationWarning). Registers the orphaned
`openai-compat` provider, adapts BaseProvider subclasses into the CLI dispatch
shape, re-asserts CLI builtins so a plugin cannot hijack a shipped type, and
replaces the silent `_invoke_recipe` fallback for unknown `--type` with a
validation error. Declares the group in pyproject.toml and documents it.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:43:38 +00:00
praisonai-triage-agent[bot]andMervinPraison b90be35a5f fix: make praisonai.external_agents plugins usable across all surfaces (fixes #4150)
Collapse the four hand-written copies of the external-agent list into a
single source of truth in the registry. Adds list_external_agents() and
external_agent_catalog() to praisonai.integrations.registry; the argparse
--external-agent choices, the praisonai_code CLI handler INTEGRATIONS, and
the UI EXTERNAL_AGENTS toggles now all read the registry. Presentation
metadata (display_label, install_hint) moves onto the integration classes.

Backward-compatible: INTEGRATIONS and EXTERNAL_AGENTS stay Mappings
supporting in / iteration / []. Built-in order and labels are unchanged on
a default install.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:42:40 +00:00
praisonai-triage-agent[bot]andMervinPraison 738682701b fix: make provider registry the validation authority for cloud deploy (fixes #4151)
The CloudProvider enum could not be extended at runtime, so plugin
providers discovered/resolved via the praisonai.deploy.providers
entry-point group were rejected by validation. Widen CloudConfig.provider
to Union[CloudProvider, str] with a mode="before" validator that consults
the registry via coerce_cloud_provider. Built-ins keep enum identity and
byte-identical serialisation; plugins validate as normalised lowercase names.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:40:54 +00:00
praisonai-triage-agent[bot]andMervin Praison b841b44811 fix: honour terminal ToolExecutionError verdict on async retry path
The broad async exception handler flattened every raised exception into an
error dict with retryable = not isinstance(e, (ValueError, TypeError,
AttributeError)). A ToolExecutionError(is_retryable=False) is none of those,
so it was silently marked retryable=True and re-run up to max_attempts,
diverging from the sync path (tool_execution.py) which preserves an existing
ToolExecutionError's explicit verdict. Now the async path honours
e.is_retryable for ToolExecutionError and only applies the programming-error
rule to other exceptions.

Adds tests for terminal and retryable ToolExecutionError parity.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:40:12 +00:00
praisonai-triage-agent[bot]andMervinPraison cea0323c12 fix: preserve discovered praisonai.integrations entry points (fixes #4149)
IntegrationRegistry.__init__ reassigned self._loaders = {} right after
super().__init__() populated it from the entry-point group, discarding
every discovered third-party plugin. Remove the reassignment (builtins are
registered afterwards and still win on name clashes) and document the
entry-point group.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:39:42 +00:00
praisonai-triage-agent[bot]andMervin Praison 4db9b3a7d0 fix: treat explicit empty/null knowledge provider as misconfiguration
Presence of the vector_store.provider key (not its truthiness) now marks an
explicit choice, so an explicitly empty ("") or null (None) provider surfaces
the preset error instead of silently degrading to Mem0. Adds parametrized
regression coverage for both falsey values.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:38:04 +00:00
praisonai-triage-agent[bot]andMervin Praison 1f2de6c17c fix: rebind as_tool() handoff to clone in clone_for_channel
The as_tool() Handoff conversion in _process_handoffs produces a closure
bound to the source agent (its chat_history/tools/memory). clone_for_channel()
shallow-copied that closure verbatim, so a channel clone would delegate using
the ORIGINAL agent's state, leaking one channel's context into another.

Tag the generated closure with its source Handoff and, during cloning, swap it
back so the clone's own _process_handoffs rebinds it to the clone -- mirroring
the existing _praison_sandbox_tool drop-and-regenerate pattern. Adds a clone
regression test asserting the clone's converted tool is bound to the clone, not
the origin.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:37:50 +00:00
praisonai-triage-agent[bot]andMervin Praison 7c64fa622b fix: emit reranker provider so rerank_model is actionable
to_knowledge_config() emitted reranker.config.model without a provider.
mem0's RerankerConfig requires a provider and Knowledge._prepare_mem0_config
strips all but provider/config, so a provider-less rerank_model was silently
dropped. Derive the provider from a "provider/model" prefix (falling back to
the model string) so the requested reranker is instantiated.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:37:24 +00:00
praisonai-triage-agent[bot]andMervinPraison 80ef98fe15 fix: make AgentTeam(llm=)/AgentFlow(llm=) reach member agents (fixes #4138)
AgentTeam stored self.llm and nothing read it, so members silently kept
gpt-4o-mini. AgentFlow(llm=) only reached agents it built itself, never a
ready-made Agent step. Add Agent._apply_default_llm to adopt a container
default as a fill-in (agents that named their own model keep it), and call
it from both containers.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:26:22 +00:00
praisonai-triage-agent[bot]andMervinPraison 25ceb8d01c fix: forward auth= on every Agent branch and honour it on Responses API (fixes #4137)
Agent(auth="claude-code") was silently billed to the API key because auth=
was dropped on the commonest construction branch (bare model name / no model)
and self.auth was never assigned, so clone_for_channel() always lost it.

- Land auth on the final else branch: bare-name + auth= now builds an LLM
  instance that injects the resolved OAuth credentials.
- Assign self.auth so clone_for_channel() forwards it.
- Resolve the subscription provider eagerly at construction so an unknown or
  unusable provider raises instead of silently downgrading to API-key billing.
- Default the model to the auth provider's vendor when no model is given.
- Inject subscription credentials in _build_responses_params too, mirroring
  _build_completion_params.
- Add regression tests and wire the subscription-auth smoke tests into CI.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:25:55 +00:00
praisonai-triage-agent[bot]andMervinPraison e1c3dd8a8a fix: convert as_tool() Handoff objects passed in tools= (fixes #4136)
as_tool() returns a Handoff, and its own docstring passes the result into
tools=[...]. But tools= stores objects verbatim and only handoffs= ran
to_tool_function(), so an unconverted Handoff was invisible to both the LLM
tool schema and execute_tool(). Convert Handoff entries found in self.tools
inside _process_handoffs, the first point where the parent agent that
to_tool_function() needs actually exists.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:22:45 +00:00
praisonai-triage-agent[bot]andMervinPraison 412922ee64 fix: make MemoryConfig backends match the adapter registry (fixes #4130)
MemoryConfig declared backends (redis/valkey/postgres) that had no adapter,
so requests were silently redirected to a local SQLite/JSON store, and
"sqlite" was overloaded (Agent built ChromaDB while Memory built SQLite).

- MemoryBackend enum now mirrors the registry (file + registered adapters)
- Unimplemented backends raise a clear error instead of substituting
- "sqlite" now builds SQLite on both Agent and Memory (no rag rewrite)
- Memory provider with no adapter fails loudly; deliberate fallbacks warn
- Drop redis/postgres presets and URL schemes that dropped host/credentials
- register_memory_adapter() remains the escape hatch for custom backends

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:22:11 +00:00
praisonai-triage-agent[bot]andMervinPraison 6c48eb403c fix: wire up inert KnowledgeConfig fields (fixes #4132)
Eight of KnowledgeConfig's ten fields never reached the internal config:
chunk_size, chunk_overlap, chunking_strategy, chunker, vector_store,
auto_retrieve, rerank_model and retrieval_threshold were read then dropped.
Also config={...} replaced the whole resolved dict, silently resetting
retrieval_k.

- agent.py: forward every declared field with the keys RetrievalConfig
  reads (min_score, not threshold); config= now overrides instead of
  replacing.
- feature_configs.py: ChunkingStrategy gains TOKEN/RECURSIVE, FIXED/PARAGRAPH
  kept as aliases; declared chunking defaults aligned to the effective ones.
- chunking.py: normalize_chunker_type maps strategy names to real chunkers.
- knowledge.py: chunker reads from config instead of hardcoding recursive/512/50.
- retrieval_config.py: add rerank_model + chunking fields, round-trip them,
  and emit a chunker block from to_knowledge_config.

Defaults unchanged so existing users are unaffected on upgrade.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:22:04 +00:00
praisonai-triage-agent[bot]andMervinPraison af0ca74377 fix: unify tool retry into one RetryPolicy budget (fixes #4133)
ToolConfig(retry_policy=RetryPolicy(max_attempts=N)) now caps how many
times a tool body runs. Previously two nested loops consumed two
independent vocabularies (RetryPolicy vs ExecutionConfig) in different
units, so max_attempts was silently overridden by max_retry_limit,
running non-idempotent tools more times than configured.

The effective RetryPolicy is now the single budget; ExecutionConfig's
retries/seconds/fraction spelling is translated into it in one place
(_effective_tool_retry_policy). No behaviour change for users who do not
set retry_policy=.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:21:23 +00:00
praisonai-triage-agent[bot]andMervinPraison 72ebbe0939 fix: resolve named tools in mixed tools=[...] lists (fixes #4135)
An all-or-nothing all(isinstance(t, str)) gate silently left every
tool-name string unresolved as soon as one callable was present, so
tools=[my_tool, 'read_file'] dropped 'read_file'. Resolve per element
via a new resolve_tools_list() helper that passes non-strings through
untouched and reports/strict-checks unknown names exactly as the
all-strings path already does.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:21:11 +00:00
praisonai-triage-agent[bot]andMervinPraison 9ffac08d94 fix: async tool retry never fires because exception is flattened (fixes #4134)
execute_tool_async caught a raised tool exception and returned an untyped
error dict; the caller re-classified it as "unknown", which no default
RetryPolicy.retry_on contains, so async always ran a failing tool exactly
once. Carry the retry verdict across the flattening (same rule as the sync
path: programming errors terminal, everything else retryable) and honour it
in the retry loop.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:21:07 +00:00
praisonai-triage-agent[bot] 115debfa1f chore: remove stray knowledge.db test artifact 2026-08-20 14:18:37 +00:00
praisonai-triage-agent[bot]andMervinPraison e7eda02f4d fix: resolve knowledge vector_store provider through adapter registry (fixes #4131)
Knowledge.memory used provider_mapping.get(provider, "mem0"), silently
substituting Mem0 for any provider outside a hardcoded four-name list —
discarding every adapter registered via register_knowledge_adapter() and
swallowing typos. Match memory.py: keep the table for genuine legacy
aliases and pass everything else to the registry, raising a helpful
make_preset_error when an explicit provider is unknown.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:18:31 +00:00
praisonai-triage-agent[bot]andMervin Praison 1b3bb34bfd docs: correct session caching section to reflect opt-in prompt_caching
Prompt caching is not applied automatically. LLM._explicit_cache_breakpoints()
gates Anthropic cache_control injection on prompt_caching being truthy, and
Agent defaults it to None. Document the correct spelling
caching=CachingConfig(prompt_caching=True).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:17:42 +00:00
praisonai-triage-agent[bot]andMervin Praison 1efc7027f8 fix: align preset validation normalization with downstream resolvers
Resolves two P1 review findings on the closed-set preset validation:

- approval hyphen aliases (accept-edits, bypass-permissions, full-auto,
  dont-ask, ...) were rejected by the new guard even though
  PermissionMode.resolve accepts them (-/_ interchangeable). The validator
  now normalizes hyphens too, restoring previously-valid construction.
- learn= used case-sensitive, non-stripped == comparisons, so a validated
  value like "AGENTIC" or " agentic " fell through to else and SILENTLY
  disabled learning. It now uses .strip().lower() like self_improve does.
- resolve()'s preset lookup and the approval deny-set lookup now normalize
  whitespace/hyphens too, so every spelling the guard accepts also resolves
  (previously " sliding_window "/"read-only" passed validation but the
  deny-set lookup produced an EMPTY deny set — the exact read-only-sandbox
  bypass this PR exists to prevent).

Adds regression tests for hyphen aliases, case/whitespace-normalized
presets (learn actually enabled), and the read-only deny-set security path.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:15:54 +00:00
praisonai-triage-agent[bot]andMervin Praison 7c0c490c8c fix: make session store auto-created marker per-instance (fixes #4121 review)
Replace the single module-level identity pointer (_autocreated_store/
_autocreated_dir) with a per-instance marker attribute stamped on any store
this module auto-creates. A partial teardown that restores only
_default_store without restoring the out-of-band tracking variable could
otherwise misclassify a previously auto-created store as caller-injected and
pin it to a stale session directory (Greptile P1).

Also make the DEFAULT_SESSION_DIR __getattr__ hook honour an explicit module
override consistently via _resolve_default_session_dir(), and fix the
override test's leaky monkeypatch (the lazy __getattr__ made setattr restore
a computed value as a real global, leaking into later tests). Adds a
regression test for the restored-store scenario.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:09:20 +00:00
praisonai-triage-agent[bot]andMervinPraison 770676aa0a fix: correct session docs to use memory=MemoryConfig(session_id=...) (fixes #4127)
The session module's __init__.py and README.md documented
Agent(name=..., session_id=...), which Agent.__init__ rejects with TypeError.
session_id/user_id/db were consolidated into MemoryConfig, and prompt_caching
was never a parameter (caching is applied automatically per model capability).

Fixes the docs to the working spelling and adds a two-sided guard test.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:08:49 +00:00
praisonai-triage-agent[bot]andMervin Praison e8239c3d52 fix: recover partially-migrated agents and guard concurrent history saves
Address two P1 review findings on the sub-agent transcript relocation:

- Partial migration: legacy per-agent records were only consulted when the
  parent held no current-format histories, so a second agent still living in
  a tagged legacy record silently resumed empty. A new _merged_agent_histories
  helper always layers legacy under current-format entries (current wins), used
  by both single and bulk restore paths.
- Concurrent saves: _store_agent_history read the whole map outside the store
  lock then replaced it, letting a concurrent writer under the same parent drop
  another agent. It now re-reads the freshest map before each write and verifies
  no other key regressed, retrying a bounded number of times.

Adds regression tests for partial-migration recovery and concurrent-save
preservation.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:08:21 +00:00
praisonai-triage-agent[bot]andMervin Praison 3f9898db65 fix: don't block plural/extension prompts as typo'd commands
The mistyped-command guard used difflib ratio >= 0.8 alone, which also
matches legitimate one-word prompts that are plurals or extensions of a
command word (`tests`->`test`, `runs`->`run`, `server`->`serve`). Those
wrongly exited 2 before reaching the bare-prompt path.

Drop prefix-related matches: an extension contains the command as a prefix
(or vice-versa) whereas a genuine typo (`deploi` vs `deploy`) does not, so
real prompts reach `run` while typos still exit 2 with a suggestion.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:06:52 +00:00
praisonai-triage-agent[bot]andMervinPraison 351e30c093 fix: validate closed-set preset params to reject typos (fixes #4116)
Seven Agent(...) preset params (output, execution, context, autonomy,
approval, learn, self_improve) silently fell back to defaults on a typo'd
preset name. Worst case: approval="read_onl" produced an empty deny set,
allowing all 17 dangerous tools instead of the intended read-only sandbox.

Wire the existing make_preset_error helper to these params via a small
validate_preset_string() in parse_utils.py plus a compact
_PRESET_STRING_PARAMS table and _validate_preset_params() loop run at the
top of the consolidated-params block, before every fast path that could
swallow the value. Free-form string params (knowledge, guardrails, skills,
runtime, auth) are deliberately excluded.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:05:30 +00:00
praisonai-triage-agent[bot]andMervin Praison c904372fcc fix: keep guardrails=[] a no-op instead of raising TypeError
An empty list/tuple resolved to None (no-op) on main, but the new
fail-loud guard rejected it with TypeError. Exempt empty collections
so an empty opt-in stays backward-compatible; genuinely unsupported
values still raise. Adds a regression test.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:02:55 +00:00
praisonai-triage-agent[bot]andMervin Praison b477602c99 fix: reject explicit parallel_tool_calls=False overridden by ToolConfig alias
ExecutionConfig.parallel_tool_calls now uses None as an internal "not set"
sentinel (normalised to bool in __post_init__) so Agent._merge_parallel_tool_calls
can tell an explicit False from an omitted default. A ToolConfig(parallel=True)
alongside an explicit ExecutionConfig(parallel_tool_calls=False) now raises
TypeError instead of silently enabling parallel tool calls (Greptile P1).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:02:39 +00:00
praisonai-triage-agent[bot]andMervin Praison dadb87a1aa fix: tighten MCP transport tests and update stale http examples
- Assert exit_code == 2 for invalid/unsupported transports (usage-error contract)
- Assert http-stream rejection points to 'praisonai mcp serve --transport http-stream'
- Assert help advertises 'stdio, sse'
- Update stale '--transport http' examples to the sibling http-stream command

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 14:01:48 +00:00
praisonai-triage-agent[bot]andMervinPraison 625c43adfc fix: store sub-agent transcripts on parent session record (fixes #4120)
Sub-agent transcripts were persisted as separate top-level sessions named
"{session_id}_{name}:{role}", whose sanitised path collided with real user
sessions of the same name (e.g. Session("chat") + Agent("support", "agent")
-> chat_support_agent.json). An ordinary close()/save_state() then silently
overwrote an unrelated user's conversation and could leak it back into the
agent on restore.

Move sub-agent histories into the parent session's own
metadata["agent_histories"][agent_key], removing the second namespace
entirely. Legacy tagged records migrate forward on save; untagged pre-tag
records are restored only behind PRAISONAI_SESSION_LEGACY_AGENT_KEYS=1
(ambiguous by construction) and are never deleted.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 14:00:07 +00:00
praisonai-triage-agent[bot]andMervinPraison aee6736fca fix: resolve session store root lazily instead of freezing at import (fixes #4121)
DEFAULT_SESSION_DIR was evaluated at module import time, freezing the
store root to whatever PRAISONAI_HOME resolved to during the first import.
Any later override -- a container exporting PRAISONAI_HOME after the
package was imported, or a test monkeypatching get_sessions_dir -- was
silently ignored, so the store read, wrote and deleted sessions in the
wrong directory.

- Resolve the directory live in DefaultSessionStore.__init__ via
  _resolve_default_session_dir().
- Keep DEFAULT_SESSION_DIR readable/assignable via PEP 562 __getattr__.
- Rebuild the singleton when the resolved directory changes, while
  never second-guessing a store a caller injected.
- Fix two repo tests that set the unread PRAISONAI_SESSIONS_DIR env var
  and reset the wrong singleton attribute.
- Add tests/unit/session/test_session_store_dir_resolution.py.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 13:59:09 +00:00
praisonai-triage-agent[bot]andMervinPraison 25078ee083 test: assert denied approvals block tool execution (fixes #4119)
Add behavioural coverage for require_approval's sync and async wrappers.
The existing approval suite only asserted registration metadata, so both
denial `raise PermissionError` lines could be deleted with the suite green.
New tests install a denying backend, call a decorated tool, and assert the
PermissionError plus that the wrapped body never ran (side-effect probe).
Positive controls, modified_args, fail-closed, and async-context cases
included.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 13:57:22 +00:00
praisonai-triage-agent[bot]andMervinPraison 26e5d4a37b fix: route --output-format and typo'd verbs correctly in CLI dispatcher (fixes #4114)
The praisonai dispatcher only introspected the `run` subcommand's options,
never the root callback's global flags (`--output-format`/`-o`). As a result:

- `praisonai --output-format json version` misrouted to the legacy engine,
  dropped `version`, sent `json` to an LLM, and exited 0.
- A typo'd verb like `praisonai deploi` fell through to the bare-prompt path,
  was billed to an LLM, created a session, and exited 1.

Fix, entirely in the dispatcher:
1. Introspect the root callback and union with `run`'s options for argv
   tokenisation, so `--output-format` routes correctly.
2. Hoist global-only flags ahead of `run` when synthesising a `run` call
   (Click accepts group options only before the subcommand). Options declared
   by both (`-o`, `-v`) stay with `run`, preserving existing semantics.
3. Add an unknown-subcommand guard: a lone positional that difflib rates a
   close match (>= 0.8) to a registered command exits 2 with a suggestion,
   guarded so genuine one-word prompts still work.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 13:55:46 +00:00
praisonai-triage-agent[bot]andMervinPraison 88c78e4b8b fix: accept guardrail objects instead of silently discarding them (fixes #4112)
Agent(guardrails=<validator object>) previously fell past every dispatch
branch and was dropped with no exception or warning, so the agent ran with
zero enforcement. Adapt protocol-conforming guardrail objects (and lists of
them) into GuardrailChain, raise TypeError on unsupported values instead of
storing something that never runs, and wire _tool_call_guardrails so
validate_tool_call is no longer dead code.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 13:55:40 +00:00
praisonai-triage-agent[bot]andMervinPraison a2032aaf4b fix: make ExecutionConfig.parallel_tool_calls the single source of truth (fixes #4113)
ToolConfig.parallel is now a deprecated alias (None = unset) that feeds
ExecutionConfig.parallel_tool_calls, which every public entry point forwards
to the LLM. A bare ToolConfig() no longer silently disables an explicit
parallel_tool_calls=True, and conflicting explicit spellings raise TypeError.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 13:54:09 +00:00
praisonai-triage-agent[bot]andMervinPraison 60af031584 fix: validate MCP transport in praisonai serve mcp (fixes #4115)
Previously any --transport value other than exactly "stdio" fell through
to the SSE branch, so a typo (e.g. `stido`) or the advertised-but-
unimplemented `http-stream` silently started a listening socket instead
of a stdio pipe. Add explicit validation rejecting unknown/unimplemented
transports with exit code 2 before any branch can bind.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 13:53:15 +00:00
Mervin Praison 680bfb3555 Merge pull request #4110 from putramkti/fix/llm-failover-profile-race
fix(llm): stop failover rotation from mutating shared instance state
2026-08-20 14:23:14 +01:00
MervinPraison b9d57384a9 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 13:22:46 +00:00
Mervin Praison 81fcd90d3b Merge pull request #4111 from MervinPraison/claude/praisonai-moa-value-gaps-dk5fa1
feat(scheduler): first-class external CLI-backend jobs + CLI-backend robustness fixes
2026-08-20 14:22:06 +01:00
praisonai-triage-agent[bot] 9b6c2524c2 Merge pull request #4109 from MervinPraison/fix/reclaim-gaps
fix(docker): two more ways a container outlived the thing that made it
2026-08-20 13:14:16 +00:00
Claude 2bda29540c fix(review): reject cli_backend in workflow YAMLs, contain post-execution hook failures
- Workflow YAMLs run through YAMLWorkflowParser, which has no cli_backend
  wiring; the framework-level compatibility check passes for 'praisonai'
  and the field was silently dropped, running the workflow on the native
  LLM path. _build_yaml_workflow now fails fast with a clear error,
  mirroring the existing tool_timeout and CLI-capability rejections.
- _chat_via_cli_backend: post-success hook emission and chat-history
  bookkeeping failures are contained (logged) instead of being reported
  as backend-execution failures, which invited callers to retry work the
  external CLI already completed; the failure hook now receives the
  backend's error result (with its audit metadata) instead of None.
- Tests: workflow-YAML rejection, post-execution containment, and
  error-result metadata propagation.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 12:27:53 +00:00
praisonai-triage-agent[bot]andMervin Praison 2518428dd2 fix(test): align schedule_add stub with producer success shape
The precise duplicate-add detection introduced in this PR classifies a
schedule add as successful only when the response contains the producer-owned
confirmation "Schedule '<name>' added". The pre-existing timezone-surface test
stubbed schedule_add with a generic "Schedule added" string lacking the job
name, so the new guard correctly treated it as a rejection and the CLI exited
non-zero. Update the stub to return the real success shape; the guard is
unchanged (test was stale, not the code).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 12:19:35 +00:00
Claude 2891d3febf fix(review): precise add-failure detection, non-finite timeout validation, deferred gate watermark, resume state before hook
- schedule add: failure detected as absence of the producer-owned
  success confirmation instead of substring matching, so a schedule
  literally named 'Error monitor' no longer exits 1 on success
- --backend-timeout: nan/inf/-inf rejected before the job is created
  (inf previously raised OverflowError AFTER the schedule was stored);
  guard tolerates direct calls passing Typer OptionInfo defaults
- backend gate: go-path state_updates (cursor/watermark) now persist
  only after the backend turn succeeds — a policy block, resolution
  failure, timeout, or backend error no longer advances the cursor past
  unprocessed work; skip-path persistence unchanged; regression test
- CLI session: result validated and resume state recorded BEFORE the
  cancellable hook await, so cancellation during the hook cannot lose
  is_resume for the next turn (and the lock is already released)

Cross-event-loop lock coordination (two OS threads sharing one Agent,
each with its own loop) is documented as out of scope: sharing an Agent
across threads is unsupported for the wider Agent state; the re-key
path preserves per-loop serialisation, which is the supported usage.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 12:13:09 +00:00
Claude 4e19534198 fix(review): cancellation-safe session lock, state-aware backend gate, sub-ms timeout rounding
- CLI-backend session lock: asyncio.CancelledError bypasses 'except
  Exception', which could leave the per-session lock held forever; a
  dedicated handler now releases (guarded by a lock_held flag so a lock
  re-acquired by a concurrent turn is never stolen) and re-raises. The
  same flag guards the generic exception path.
- Backend pre-run gate now mirrors the native path's state handling:
  persisted gate state is loaded, passed to state-aware gates, and
  decision.state_updates persist on both skip and go — a backend
  monitor job keeps its cursor/watermark across ticks.
- schedule add --backend-timeout: positive sub-millisecond values no
  longer collapse to 0 (which the executor replaced with the 300s
  default); rounded up to at least 1ms.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 12:01:44 +00:00
Claude e2851da8f1 fix(review): audit + failure delivery on the command/backend conflict branch
The defensive conflict check marked the run failed but returned before
_audit_output and _maybe_deliver_failure, unlike every other backend
failure path — audited deployments would lose the record and the owner
notification. Now consistent; regression test asserts the audit.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 11:57:47 +00:00
praisonai-triage-agent[bot]andMervin Praison f27dca4026 fix(schedule): exit non-zero when 'schedule add' is rejected as a duplicate
A duplicate-name add creates nothing and (post the job_created guard) mutates
nothing, but still printed success and exited 0 — misleading scripts/CI. Treat
the 'already exists'/'Error' responses as failures so a rejected add exits 1 in
both text and --json modes. Adds a regression test asserting no mutation + exit 1.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 11:54:30 +00:00
Claude 7b13646464 fix(review): audit writes off the event loop in backend paths; tolerate explicit null cli_backend in YAML
- all backend-branch _audit_output calls now go through
  asyncio.to_thread, matching the native-agent failure paths so slow
  audit storage cannot block ticker/delivery coroutines
- 'cli_backend: null' in YAML behaves as unset (backward compatible);
  the fail-closed error fires only for a non-null value that cannot
  resolve

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 11:52:48 +00:00
praisonai-triage-agent[bot]andMervin Praison 2cffd51012 test(compute): fake commit must accept the changes kwarg it now gets
ef6bb47b started scrubbing secret ENV lines on capture via
container.commit(..., changes=scrub) -- a real docker-py kwarg -- but the
suite's _FakeContainer.commit() still took only (repository, tag). Every
capturing provision raised TypeError, fell back to ephemeral, and left
commit_log/list_captures empty: the IndexError and 0==N failures in CI.

Production code is correct; the fake had drifted from the API it mocks.
Widened the fake to the real signature so a successful commit stays a
successful commit.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 11:51:26 +00:00
Claude 317f1b4eee fix(review): command/backend mutual exclusion, backend jobs honour pre-run gate + run policy, per-session lock for CLI session establishment
Addresses the remaining review findings:
- --command and --backend are mutually exclusive at the CLI; the
  executor fails loudly on persisted jobs carrying both (defensive)
- backend jobs now evaluate the pre-run condition gate (skipped, no
  subprocess when nothing to do; gate context appended to the prompt)
  and pass the message through RunPolicy.scan_prompt when configured,
  matching native-agent jobs
- CLI session establishment is serialised per session id with an
  asyncio lock (cross-event-loop safe) so concurrent turns cannot
  spawn two fresh CLI conversations for one session

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 11:50:27 +00:00
Claude db7b33e31e fix(review): duplicate-add no longer mutates existing jobs; YAML backend fails closed; early backend failures audited
Addresses the three review findings:
- schedule add: trusted post-add options apply only when this invocation
  actually created the job — a duplicate-name rejection can no longer
  reconfigure a live schedule
- YAML cli_backend that cannot resolve now raises with remediation
  instead of silently running the native LLM path
- backend resolution/timeout/launch failures now write the durable
  audit record before failure delivery (all three early-return sites)

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 11:47:05 +00:00
praisonai-triage-agent[bot]andMervin Praison 55cf1442f4 fix(llm): thread failover profile per-call instead of shared instance
Greptile P1: the retry loop still mutated self._current_profile on
rotation, and mark_failure/mark_success plus token-model attribution read
that shared pointer. Concurrent requests on one LLM instance could mark
the wrong profile failed/healthy or misattribute cost.

Rotation is now a call-local: _handle_retry_exception takes the active
profile in and returns the (possibly rotated) profile out; both retry
loops keep it in a local and use it for mark_failure/mark_success.
self._current_profile stays pinned to the initial profile. Token usage
is attributed from the serving model on the response (race-free), so the
now-unused _active_profile_values() is removed.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 11:36:34 +00:00
Claude e9c099ca21 feat(scheduler): first-class external CLI-backend jobs + backend robustness fixes
Schedule a job that runs its message as one headless turn through a
registered coding-CLI backend (claude-code, codex-cli, gemini-cli,
grok-cli): new ScheduleJob.backend/backend_options fields, an executor
action that resolves backends lazily via the sanctioned _code_bridge
seam (bot never hard-depends on praisonai-code), and
'praisonai schedule add --backend/--backend-cwd/--backend-timeout'.
Output is bounded, failures flow through run records, audit and
failure delivery, and the pinned model is passed to the CLI.

Backend fixes shipped alongside, all previously silent:
- timeouts now return CliBackendResult(error=...) instead of escaping
  as bare TimeoutError (all four backends)
- captured stderr reaches the error message (codex/gemini/grok)
- codex: 'exec resume <id>' subcommand order; TOML-safe instructions
  escaping; -m model flag; -C honors cwd
- gemini/grok/claude: model flag + cwd threading
- CliSessionBinding.is_resume is now set on the second turn of a
  session, activating the resume branches in all four backends
- YAML 'cli_backend:' resolves through _resolve_yaml_cli_backend into
  the cli_backend kwarg instead of misrouting into the runtime
  registry (shipped example now works)
- 'praisonai backends' registered as a Typer command (standalone
  praisonai-code installs previously could not reach the legacy path)

Tests: 19 new (backend action + serialisation round-trip + fixes);
existing scheduler/backend suites verified unchanged vs main;
check_bot_code_imports gate passes.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Pwwvk68iPoNnGw6ov5Lpga
2026-08-20 11:28:27 +00:00
dymux 4634102f40 fix(llm): stop failover rotation from mutating shared instance state
_switch_to_profile wrote the rotated profile's api_key/base_url/model
onto the shared LLM instance. With one instance serving concurrent
requests (asyncio.gather on a shared Agent, or a cached per-session
Agent), a failover rotation for request A changed the credentials and
model that request B read on its next completion build, silently
sending B's traffic to the wrong provider. Rotation is now a per-call
concern: the retry loop threads the active profile through request
kwargs, and instance attributes keep the initial profile values.
Token tracking follows the profile actually used for the call.

Closes #3613 (gap 2).
2026-08-20 19:23:40 +08:00
praisonai-triage-agent[bot]andMervin Praison d7272ff514 fix(reclaim): loop-safe finalizer and stop ephemerals polluting managed ps
_release() called asyncio.run() directly, so GC on a thread already driving
an event loop raised RuntimeError before shutdown ran -- the instance leaked.
Bridge the loop the way SharedCompute._run_sync does (offload to a private
thread when a loop is live) so teardown survives either case.

DockerSandbox.execute() labelled its ephemeral --rm containers praisonai=managed,
the sole input to DockerCompute.list_instances(). Those praisonai-<uuid> names
then surfaced in `managed ps` but `managed stop` resolves praisonai_<id> and
could never reclaim them. Relabel as praisonai=sandbox-exec; the timeout kill
uses --name and is unaffected.

Adds a regression test proving _release reclaims when invoked on a live loop.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 11:22:12 +00:00
MervinPraisonandClaude Opus 5 281982993c fix(docker): two more ways a container outlived the thing that made it
Both found by adversarial review, both pre-existing, both leaks.

A TIMED-OUT execution left its container running. The handler called
proc.kill(), which ends the docker CLI while the container it started
carries on. The container also had no --name, so it got a random Docker
name -- neither the timeout handler nor `praisonai managed ps` could
find it, and the user was left with something they could see in
`docker ps` and had no supported way to stop. It is named and labelled
now, and the timeout kills the container rather than the client.

The sibling run_command() path already did this, with the comment "Kill
the container, not just the client". execute() never got the same
treatment; the two paths have been quietly different ever since.

run_on= NEVER RECLAIMED ITS INSTANCE. ComputeManagedAgent defaults to
keep_alive=True, which is right -- an instance should survive between
turns -- but it registered no finalizer, so it also survived the process.
For docker that was a container per script; for e2b, modal, daytona,
tenki and flyio it is a billed cloud instance whose only other reaper is
the provider's own idle timer, and docker and flyio have none.

It now uses the same weakref.finalize treatment tools_placement uses for
agents, which covers collection and interpreter exit, and stands down
when the caller shuts down deliberately. The finalizer deliberately does
not close over the backend -- that would keep alive the very object whose
collection it waits for.

Verified from a confirmed-zero baseline: 0 containers after a timeout
(was 1), 0 after a run_on= script exits (was 1), and ordinary runs
unaffected.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 12:15:01 +01:00
Mervin Praison d5c6a1ce46 Merge pull request #4105 from MervinPraison/claude/issue-4104-20260820-0943
fix: add YAML adapter: import path and filesystem drop-in for gateway channels
2026-08-20 12:13:40 +01:00
Mervin Praison 5c431310d1 Merge pull request #4093 from ugbotueferhire/fix/windows-test-failures
fix: handle Windows carriage returns and Unicode encoding in tests
2026-08-20 12:08:52 +01:00
Mervin Praison 134ea0d362 Merge pull request #4101 from MervinPraison/claude/issue-4096-20260820-0848
fix: add deny-with-guidance to approval flow
2026-08-20 12:08:30 +01:00
praisonai-triage-agent[bot]andMervin Praison af95798c93 fix: gate project channel drop-ins & drop loader-only adapter field (#4104)
Address two P1 review findings on the YAML adapter/drop-in feature:

- Trust gate bypass: project-local .praisonai/channels/*.py files were
  classified by the plugins-scoped _is_project_local() (which checks
  .praisonai/plugins), so they executed without PRAISONAI_ALLOW_PROJECT_PLUGINS.
  Add _is_project_local_channel() scoped to the channels dir and gate on it.

- adapter field reaching constructor: the loader-only YAML `adapter:` import
  ref was passed through into adapter_cls(**init_kwargs), raising TypeError for
  adapters that don't accept an `adapter` kwarg. Skip it in the gateway
  pass-through alongside platform/token.

Adds regression tests for project-local opt-in enforcement (blocked/allowed)
and the adapter-field exclusion.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 11:07:58 +00:00
praisonai-triage-agent[bot]andMervinPraison dfa9832f90 fix: add YAML adapter: import path and filesystem drop-in for gateway channels (fixes #4104)
Restores the CLI/YAML/Python 3-way surface for custom gateway channels:
- ChannelConfigSchema gains an optional `adapter:` dotted "module:Class"
  import string; unregistered platforms are lazily imported, validated
  against BasePlatformAdapter, and self-registered before startup.
- BotPlatformRegistry auto-discovers single-file adapters dropped into
  ./.praisonai/channels/ and ~/.praisonai/channels/, reusing the same
  trust gate as single-file plugins.

Backward compatible: absent the adapter key and drop-in dir, resolution
behaves exactly as before.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 11:07:58 +00:00
Mervin Praison 86e8ca8f98 Merge pull request #4107 from MervinPraison/fix/sandbox-toctou
fix(sandbox): a container could escape to the host, and every run leaked one
2026-08-20 12:07:38 +01:00
MervinPraison 07dc2a9fcf docs: auto-update documentation parity trackers [skip ci] 2026-08-20 11:07:15 +00:00
MervinPraisonandClaude Opus 5 c13b8f4301 fix(docker): /sandbox meant two different roots
The sandbox directory is mounted at /sandbox, so that is the path a user
sees from inside the container and the one they naturally reach for. But
the file API treats "/" as the sandbox root, so the container spelling
was joined onto the root a second time:

    write_file("/sandbox/report.txt")     -> True
    cat /sandbox/report.txt               -> No such file or directory
    find /sandbox -name report.txt        -> /sandbox/sandbox/report.txt

and the reverse direction failed too -- a file the container had just
written to /sandbox/out.txt was invisible to read_file("/sandbox/out.txt")
and absent from list_files("/sandbox"), while read_file("out.txt") found
it. Two spellings of one location, one of them silently wrong, and the
wrong one is the spelling the container itself shows you.

Both now resolve to the same file. Only the exact mount prefix is
stripped, so a genuine subdirectory called "sandbox" is not swallowed --
there is a test for that, because prefix-stripping is the kind of fix
that quietly breaks the case it was not thinking about.

Introduced by the mount added to make writes reach the container at all;
before that, /sandbox did not exist inside it, so nothing could be
addressed either way.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 12:06:42 +01:00
praisonai-triage-agent[bot] 3ade8b9081 Merge pull request #4103 from MervinPraison/claude/issue-4102-20260820-0914
fix: add W3C trace-context propagation carrier to GatewayTraceHook
2026-08-20 11:06:33 +00:00
praisonai-triage-agent[bot]andMervin Praison ef6bb47be8 fix(sandbox): apply PID floor on execute path, scrub all env on capture, guard openat on non-POSIX
Three valid P1s from adversarial review:

- execute()'s _build_docker_command passed max_processes straight to
  --pids-limit, so the default 10 killed the container before python
  started (exit 125). Apply MIN_CONTAINER_PIDS floor, matching run_command().

- docker commit scrubbed only a fixed secret-name set. ComputeConfig.env is
  public (.praisonai/environment.yaml), so an arbitrary custom secret was
  baked into the persistent image. Scrub the union of the known set and the
  config's own env names -- the values actually injected into the container.

- open_in_sandbox/makedirs_in_sandbox referenced os.O_DIRECTORY / O_NOFOLLOW
  and dir_fd unconditionally, raising AttributeError on Windows. Gate the
  openat walk behind a capability flag; fall back to the resolved-string
  guard where openat is unavailable (Docker there runs a Linux VM, so no
  host-shared dir exists to race).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 11:01:23 +00:00
MervinPraisonandClaude Opus 5 a87e97c343 fix(sandbox): a container could escape to the host, and every run leaked one
Four defects found by adversarial review of the merged consolidation. The
first two are mine.

ESCAPE. The bind mount added so write_file() actually reaches the
container turned a harmless check-then-use into an exploitable race.
safe_sandbox_path() validates a path STRING; the caller then opens that
string -- two syscalls with a gap. Nothing but the host could write to
that directory before it was mounted. Afterwards, code inside the
container could swap a name between a regular file and a symlink:

    for i in $(seq 1 6); do (while true; do
      rm -f /sandbox/notes.txt; ln -s /etc/passwd /sandbox/notes.txt
      rm -f /sandbox/notes.txt; : > /sandbox/notes.txt
    done) & done

Measured before the fix: an escape to an arbitrary host file on write
attempt 375, and a host secret disclosed on read attempt 4. Arbitrary
host read and write, from code that where_does_it_run() calls "a Docker
container".

No amount of stricter string checking fixes this -- anything verified
before the open can be invalidated after it. So the file is never
re-opened by name: open_in_sandbox() walks the path one component at a
time against an open directory descriptor with O_NOFOLLOW at each step,
so a symlink substituted at any level fails the open rather than
redirecting it. Re-running the attack: host file untouched, secret not
disclosed, ordinary writes unaffected.

LEAK ON EVERY EXIT. tools_run_on= releases its sandbox from a weakref
finalizer, which usually runs as the process ends -- and by then
concurrent.futures has set its own atexit flag, so run_in_executor raises
"cannot schedule new futures after interpreter shutdown". The failure was
swallowed and logged as a successful release, so every run left a
container up while reporting it had cleaned up. Docker and Fly.io have no
idle reaper, so those were indefinite.

_offload() now falls back to calling inline when the executor is gone,
which is correct there: no event loop is left to starve. Unrelated
RuntimeErrors still propagate. DockerCompute was never converted to the
shared base in the earlier extraction, so it had the same bug in four
more places; it inherits now. Teardown reports failure instead of
claiming success, since a failed release means something is still
running -- or still billing.

SECRETS IN A COMMITTED IMAGE. `docker commit` preserves Config.Env, so
the model API keys forwarded into a container were baked into an image
that persists for days and is readable by anyone who can run `docker
inspect`. The capture exists to reuse installed packages, not the
credentials that happened to be present while installing them, so the
commit now scrubs them.

FORK BOMBS. run_command() accepted max_processes and ignored it while
the other execution path applied it. Docker's --pids-limit is per
container, so unlike RLIMIT_NPROC it means what it says -- but the
default of 10 was chosen for the rlimit world and kills the container
before the shell finishes starting. The cap has a floor a container can
live within; it still bounds a fork bomb, it just stops the bound from
being the bug.

Also drops `native` from the not-a-boundary list: it aliases sandlock,
which applies Landlock and seccomp, so the two spellings of one backend
were giving opposite security advice.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 11:53:02 +01:00
praisonai-triage-agent[bot]andMervin Praison 5a204d4a7d fix: correct egress header merge order in GatewayTraceHook docstring
Seed the outbound carrier with provider headers first, then inject the
active trace context last so a fresh traceparent/tracestate always wins
over any stale provider-supplied values (Greptile review on #4103).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 10:24:17 +00:00
praisonai-triage-agent[bot]andMervin Praison d177b0680c fix: add W3C trace-context propagation carrier to GatewayTraceHook (fixes #4102)
Extend the dependency-free GatewayTraceHook seam so an exporter can continue
an upstream caller's distributed trace and propagate context downstream:

- stage() gains an optional parent_carrier (inbound traceparent/tracestate)
  so a stage can be entered under an extracted parent span context.
- inject_context()/extract_carrier() no-op defaults let egress call sites
  write the active traceparent and ingress boundaries continue a caller's
  trace. Real extract/inject lives in the OTel exporter plugin.

NullGatewayTraceHook stays the zero-cost, OpenTelemetry-free default:
inject_context leaves the carrier untouched and extract_carrier returns None.
Additive and backward compatible.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 10:24:17 +00:00
Mervin Praison 04b86a9edc Merge pull request #4106 from MervinPraison/fix/docker-sandbox-filesystem
fix(docker): run_in="docker" had no filesystem, and leaked the host path
2026-08-20 11:23:05 +01:00
praisonai-triage-agent[bot]andMervin Praison c4e15733ec test: align ollama malformed-JSON test with intentional name-preserving contract
The error branch in _parse_tool_call_arguments (PR #4075, commit 991b2ff28)
intentionally reads the real tool name from tool_call["function"]["name"] so a
malformed/truncated arguments string is reported back to the model for the
correct tool instead of aborting the turn with a fabricated name. The stale
test still asserted the old "unknown_function" behaviour, causing a pre-existing
test-core failure unrelated to the docker-sandbox changes on this branch.

Update the assertion to the current contract and add a case proving the
"unknown_function" fallback still applies when no name is recoverable.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 10:22:36 +00:00
praisonai-triage-agent[bot]andMervin Praison 66709c37a5 fix(docker): share /sandbox storage on the execute path too
run_in="docker" goes through execute(), which mounted only its own
script under /code -- so it could not see files write_file() wrote and
anything it created vanished with the container. Mount the sandbox dir
and run the script from there, matching run_command(). Adds a regression
test proving execute() reads a written file and its output persists.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 10:19:34 +00:00
MervinPraisonandClaude Opus 5 9563b57f71 docs(sandbox): the description described half the package
It said "backends extracted from the praisonai wrapper", which stopped
being the whole truth when the seven compute providers moved in. The
package now holds both shapes: eight sandboxes (one object IS one
environment) and seven compute providers (one object hands out many).

The distribution name stays. "sandbox" is imprecise for a package that
also contains fleet managers, but it is published, it appears in every
install hint and extra, and renaming a released package costs more than
the imprecision does. The precision lives in the subpackage instead:
praisonai_sandbox.compute is unambiguous about which shape you are
importing.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 11:13:40 +01:00
MervinPraisonandClaude Opus 5 e495c11839 fix(docker): run_in="docker" had no filesystem, and leaked the host path
Two user-visible defects, found by comparing the two docker
implementations now that they sit in one package.

WRITES WENT NOWHERE. write_file() writes into a host temp directory, and
`docker run` never mounted it. So the write reported success, the file
landed outside the container, and reading it back failed:

    write_file("/data.txt", ...)  -> True
    run_command("cat /data.txt")  -> exit 1, No such file or directory

Nothing carried between commands either, since each one got a fresh --rm
container with no shared storage. The directory is now mounted at
/sandbox and commands run there by default, so a write is visible to the
next read and to the next command.

LISTING LEAKED THE HOST PATH. list_files() returned entries like
"/../../../../../../private/var/folders/.../praisonai_sandbox_xxx/a.txt".
On macOS the sandbox directory comes back as /var/folders/... while
os.walk reports /private/var/folders/... -- /var being a symlink -- so
the relative-path computation escaped upward and handed back the real
host location. Both sides are resolved before comparing now, and any
entry that still escapes the root is dropped rather than reported.

Isolation is unchanged and tested: the host filesystem stays invisible,
only the sandbox directory crosses.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 11:12:45 +01:00
MervinPraison c0de8a7693 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 10:07:30 +00:00
Mervin Praison 3aa7e64b0a Merge pull request #4092 from MervinPraison/refactor/compute-into-sandbox
refactor(compute): move the vendor providers into praisonai-sandbox
2026-08-20 11:06:55 +01:00
praisonai-triage-agent[bot] ae992f9524 Merge pull request #4100 from MervinPraison/claude/issue-4098-20260820-0849
fix: report step-limit-truncated runs distinctly instead of as success
2026-08-20 09:43:36 +00:00
praisonai-triage-agent[bot] 08fb416dfb Merge pull request #4099 from MervinPraison/claude/issue-4097-20260820-0849
fix: drive provider->env-var maps from canonical catalogue
2026-08-20 09:42:43 +00:00
praisonai-triage-agent[bot] 11168d99b2 Merge pull request #4095 from MervinPraison/claude/issue-4094-20260820-0823
fix: redact audit secrets, lock DbSessionAdapter, fix transitive import misclassification
2026-08-20 09:37:10 +00:00
praisonai-triage-agent[bot]andMervin Praison c126bc2f36 fix(compute): point sandbox docstring examples at canonical import path
The C13 sandbox import gate flags any `from praisonai` line in
praisonai_sandbox/. The moved compute providers still documented the
legacy `praisonai.integrations.compute.*` alias in their docstring
examples, tripping the gate and failing test-core, test-core (sandbox)
and smoke. Point every example at the canonical
`praisonai_sandbox.compute.*` path (the old path is now only an alias),
which both satisfies the gate and gives users the correct import.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 09:29:30 +00:00
praisonai-triage-agent[bot]andMervin Praison 89c1d6e898 fix(compute): complete [all] extra and point install hints at the light package
- praisonai-sandbox[all] now includes tenki and flyio, so a user who runs
  `praisonai-sandbox[all]` and selects tools_run_on="tenki" gets the SDK
  instead of a missing-dependency error (Greptile P1).
- _compute_bridge _EXTRA_HINTS now point at praisonai-sandbox[<vendor>] rather
  than the heavy praisonai wrapper — the whole reason the providers moved
  (58 vs 143 resolved packages) — and cover the previously-missing tenki hint.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 09:29:30 +00:00
MervinPraisonandClaude Opus 5 d4f18f8114 refactor(compute): move the vendor providers into praisonai-sandbox
Reaching E2B through `tools_run_on=` required the praisonai wrapper: 20
hard dependencies and 8 sibling packages, including a browser package and
a Telegram bot, to run a command in a sandbox. The identical capability
through `run_in="e2b"` needed only praisonai-sandbox[e2b]. Measured, that
was 143 resolved packages against 58, for the same vendor.

The seven compute providers now live in praisonai_sandbox/compute/,
beside the sandbox backends they share a vendor with. That package was
already the right shape for this: four hard dependencies and one optional
extra per vendor, sitting directly above core. Nothing needed inventing --
the extras grid already existed and was already correct.

Verified with the wrapper made genuinely unimportable: providers resolve
and a real Docker container runs. That property now has a test, so the
providers cannot quietly drift back behind a dependency users should not
need.

Compatibility. The old modules alias the new ones through sys.modules
rather than re-exporting from them. A plain `from ... import X` shim
looks equivalent right up until someone monkeypatches a module-level name
through the old path -- the patch lands on the shim and the real module
never sees it, which is exactly what the wrapper's docker-capture tests
do. Aliasing keeps one shared module object, so every existing import,
attribute and patch keeps working.

tenki's SDK pin follows its implementation; flyio needs none, since it
speaks plain HTTP through aiohttp, which praisonaiagents already
requires.

This does not merge the two implementations of the four shared vendors.
That decision is still open, and it is now easier to make because the
pairs finally sit in the same distribution.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 09:28:48 +00:00
praisonai-triage-agent[bot] da756b1ec7 Merge pull request #4091 from MervinPraison/claude/issue-4079-20260820-0752
fix: wire unattended-run policy, host-app job execution, and BotOS model pin
2026-08-20 09:26:57 +00:00
MervinPraison 3e48ab98a9 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 09:26:37 +00:00
Mervin Praison 220c7994a3 Merge pull request #4073 from MervinPraison/fix/provider-install-hints
fix(compute): the install hints named extras that did not exist
2026-08-20 10:26:01 +01:00
MervinPraisonandClaude Opus 5 576e4a14ec fix(compute): the install hints named extras that did not exist
When a provider's SDK was missing, the error told the user what to
install. Three of those instructions were wrong:

    praisonai[e2b]      did not exist
    praisonai[docker]   did not exist
    praisonai[daytona]  existed but was EMPTY -- installed nothing

pip warns about an unknown extra and then carries on succeeding, so the
user followed the official hint, waited for the install, and hit the
identical failure again. That is worse than no hint at all, because it
looks like it is helping.

The wrapper extras are now real and delegate to praisonai-sandbox, which
already pins every vendor SDK correctly, rather than standing up a second
grid of pins to drift against the first.

A test walks every hint, resolves the extra it names against the real
pyproject, and asserts it exists and is non-empty. The only reason this
survived is that nothing checked whether the advice was true.

Rebased onto main and rebuilt rather than merged: this branch and main
had both appended to test_provider_matrix.py, so a textual merge cut a
function in half. Main's copy is taken whole and the one test unique to
this branch re-applied on top.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 09:20:14 +00:00
MervinPraison dc6b6d40b8 docs: auto-update api.md [skip ci] 2026-08-20 09:18:56 +00:00
praisonai-triage-agent[bot] 018ba5e9e1 Merge pull request #4089 from MervinPraison/claude/issue-4084-20260820-0755
fix: wire recipe run history into execution and expose recipe runs
2026-08-20 09:18:26 +00:00
Mervin Praison 1ac3f3bb83 Merge pull request #4076 from MervinPraison/claude/issue-4075-20260820-0713
fix: guard malformed tool-call JSON, tool-pair-safe window trimming, same-batch async dep ordering
2026-08-20 10:17:52 +01:00
Mervin Praison 12f8e6da7d Merge pull request #4072 from MervinPraison/fix/align-docker-default
fix(sandbox): the two docker implementations handed you different Pythons
2026-08-20 10:17:36 +01:00
MervinPraison 562dcf0bf4 docs: auto-update api.md [skip ci] 2026-08-20 09:12:38 +00:00
praisonai-triage-agent[bot] cfee692cdd Merge pull request #4088 from MervinPraison/claude/issue-4083-20260820-0754
fix: enforce launch auth + fail-closed bind on Agent.launch
2026-08-20 09:12:14 +00:00
MervinPraison 6def247752 docs: auto-update documentation parity trackers [skip ci] 2026-08-20 09:10:37 +00:00
praisonai-triage-agent[bot] da599758fa Merge pull request #4090 from MervinPraison/claude/issue-4081-20260820-0753
fix: fence externally-POSTed webhook/hook payloads as untrusted data
2026-08-20 09:09:48 +00:00
MervinPraison 9df22f5363 docs: auto-update api.md [skip ci] 2026-08-20 09:02:31 +00:00
praisonai-triage-agent[bot] e5f89675bf Merge pull request #4087 from MervinPraison/claude/issue-4078-20260820-0752
fix: unify praisonai schedule store management surface
2026-08-20 09:02:06 +00:00
praisonai-triage-agent[bot]andMervin Praison 5548e47a8b fix: mark stream terminal event not-ok on step-limit-truncated runs
Compute truncation before emit_run_result in the actions/custom-agent
paths so --output stream-json consumers never receive a contradictory
run.result {ok:true} ahead of the status:"truncated" outcome (exit 2).
Adds a regression test exercising the stream-bridge ordering.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 09:01:53 +00:00
praisonai-triage-agent[bot]andMervin Praison 95bd02f0a6 fix: surface every provider credential alias in auth (fixes #4097 drift)
auth._PROVIDER_ENV_KEYS retained only each provider's first catalogue
env-var, so providers with multiple credential spellings (together:
TOGETHER_API_KEY/TOGETHERAI_API_KEY, fireworks: FIREWORKS_API_KEY/
FIREWORKS_AI_API_KEY) had their secondary alias dropped. The runtime
(env.py) already honours all aliases, so `auth list`/`status` reported
"not found" for a credential the runtime accepts — the exact drift this
PR set out to eliminate. Now the map keeps all aliases and auth prefers
whichever the user actually set. Adds parametrised coverage over every
multi-alias provider.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:59:44 +00:00
MervinPraison e961d322ac docs: auto-update documentation parity trackers [skip ci] 2026-08-20 08:54:08 +00:00
praisonai-triage-agent[bot]andMervinPraison 15f0399aab fix: add deny-with-guidance to approval flow (fixes #4096)
Denials now support optional free-text guidance surfaced back to the model
as a course-correction instead of a bare "User denied" dead-end.

- ApprovalDecision gains optional feedback field (backward-compatible).
- ConsoleBackend adds a [d] "deny & redirect" choice capturing one line
  of guidance.
- Tool-loop denial handlers fold feedback into the tool result the model
  sees next turn (reuses existing result path, no new subsystem).
- InteractiveCLIApprovalBackend now also sets decision.feedback.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 08:53:49 +00:00
praisonai-triage-agent[bot]andMervinPraison a0f18d44a7 fix: report step-limit-truncated runs distinctly instead of as success (fixes #4098)
A run that hits its max_iter/max_steps budget returns a non-empty
finalisation summary, which the CLI's _run_succeeded accepted as success —
masking incomplete work with exit 0 and status "success".

The core already records the terminal reason on the agent via
last_stop_reason ("max_steps" on truncation), so consult it on the
in-process run paths that hold the Agent object and report a distinct
tri-state outcome:

- new _run_was_truncated(agent): reads last_stop_reason (best-effort)
- new _report_run_truncated(output, result): preserves the summary text,
  emits status "truncated" for --output json, prints a one-line stderr
  notice for interactive users, and exits 2 (distinct from failure=1 and
  completion=0)

Wired into the actions, custom-agent, and profiled-prompt paths. Genuine
completion and hard-failure paths are unchanged.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 08:53:43 +00:00
praisonai-triage-agent[bot] 03dd3c2f47 Merge pull request #4086 from MervinPraison/claude/issue-4082-20260820-0754
fix: branch-safety guardrails for github_commit_and_push
2026-08-20 08:53:43 +00:00
praisonai-triage-agent[bot]andMervinPraison dcf94f3ec5 fix: drive provider->env-var maps from canonical catalogue (fixes #4097)
Wire the two remaining parallel provider->env-var maps to the canonical
PROVIDER_ENV_CATALOGUE so key auto-detection, provider inference, and the
auth surface can no longer drift:

- model_resolver._provider_for_model() now resolves via the catalogue
  (provider_for_model + env_vars_for_provider), covering openrouter,
  mistral, deepseek, xai, together, fireworks, ... instead of returning
  None. Keeps the historical eight-provider ladder as an offline fallback.
- auth._PROVIDER_ENV_KEYS is derived from the catalogue at import, with the
  historical literal map retained as an offline fallback.
- Add parametrised drift tests asserting every catalogued provider is
  resolvable by auth, model_resolver, and env first-run detection, so
  future drift fails CI.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 08:52:29 +00:00
praisonai-triage-agent[bot] 3aea9183da Merge pull request #4085 from MervinPraison/claude/issue-4080-20260820-0753
fix: honour recipe fields on async runs API
2026-08-20 08:46:54 +00:00
praisonai-triage-agent[bot]andMervin Praison dfa9b08882 fix: honour single-arg redactor contract; serialize session init to prevent duplicate on_agent_start
- audit.py: bind sensitive_keys to the built-in redactor via functools.partial
  at construction so both default and custom redactors are always invoked with
  a single argument, honouring the declared Callable[[Any], Any] contract.
  Custom one-arg redactors no longer raise TypeError before _write runs.
- db_session_adapter.py: add per-session init lock so concurrent first access
  calls the non-idempotent on_agent_start exactly once, preventing duplicate-key
  races in SQL conversation stores. Init locks are cleaned up on delete_session.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:32:37 +00:00
praisonai-triage-agent[bot]andMervinPraison ea44da4d53 fix: redact audit secrets, lock DbSessionAdapter, fix transitive import misclassification (fixes #4094)
- security/audit.py: redact sensitive tool_input keys (api_key, token, etc.)
  via a default denylist redactor; chmod the log file to 0o600.
- integrations/db_session_adapter.py: guard the four in-memory containers with
  a threading.RLock (DB I/O stays outside the lock) to prevent dropped messages
  and duplicated on_agent_start under concurrent multi-agent load.
- __init__.py: disambiguate ModuleNotFoundError on e.name so a broken transitive
  dependency surfaces the real cause instead of a misleading "has no attribute".

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 08:26:01 +00:00
praisonai-triage-agent[bot]andMervin Praison fa146cceb0 fix: close request-fence gaps for use_system_prompt=False and deliver_only
Address two P1 review findings on the untrusted-request fencing:

- use_system_prompt=False bypass: add a self-describing inline notice
  (request_payload_notice) prepended once outside the fence at each
  ingress boundary (webhook render_prompt, hook render_template), so the
  untrusted-data semantics travel with the payload even when the agent
  never receives the system-prompt trust clause.
- deliver_only markup leak: resolve_message gains a fence flag; the
  gateway deliver_only path calls it with fence=False so recipients of
  direct channel deliveries never see literal fence tags.

Tests updated for the inline notice and unfenced deliver_only output.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:16:37 +00:00
praisonai-triage-agent[bot]andMervin Praison b64d4b4b73 fix(schedule): correct cadence reset, exact-id mutation, json list, store describe
Address reviewer-flagged issues on the unified schedule management surface:

- schedule_update now clears last_run_at on cadence change so a new at:/every/
  cron schedule is evaluated fresh (a previously-run job updated to at: was
  treated as already-fired and never ran).
- CLI pause/resume/update/remove/delete mutate the exact record resolved by id
  (via store.update/store.remove) instead of round-tripping through the
  name-based tool, so duplicate names cannot cause the wrong job to change.
- schedule list --json emits a single valid JSON document ({store, daemon})
  instead of mixing a JSON array with the daemon's human-readable table.
- schedule describe consults the canonical store first, so store-backed jobs
  authored by schedule add can be inspected; falls back to the daemon.

Adds a regression test for the cadence-reset fix. Full scheduler suite passes.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:15:07 +00:00
praisonai-triage-agent[bot]andMervin Praison 42714aba9c fix: correct atomic-claim leave-due, stale scheduler policy, resolver docstring (#4079)
Address final-review findings on the unattended-run wiring:

- schedules_runner: on the canonical store, claim_due advances last_run_at at
  claim time, so raising in on_trigger still consumed the occurrence. Only
  start the poll loop when an executor was built; otherwise leave the loop
  unstarted so no due job is claimed/consumed (P1: atomic claim consumes
  failed occurrence).
- schedules_runner: drop the misleading "process-global registry" claim from
  the resolver docstring — no such registry exists in host embedding; message
  jobs are recorded failed (auditable) and command jobs run (P1: agent
  resolution).
- gateway server: rebuild RunPolicy each tick from the current _loaded_config
  so a hot-reloaded scheduler: block applies without a process restart
  (P1: reloaded policy remains stale).
- test: replace the tautological on_trigger stub test with one that asserts
  the real bridge does not start the loop when no executor is available.

Full scheduler unit suite: 307 passed, 8 skipped (no regressions).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:12:59 +00:00
praisonai-triage-agent[bot]andMervin Praison 855cc0b977 fix: only mutate launch token after abort guards; reuse generated token
Addresses Greptile P1 on PR #4088: resolve_launch_host() previously wrote the
process-wide PRAISONAI_LAUNCH_AUTH_TOKEN before the no-agents / missing-deps
guards, so a launch that never started a server could still flip global auth
and retroactively 401 an already-running endpoint. The bind guard now runs only
after both paths are committed to serving. A generated token is also reused for
the process lifetime so a later non-loopback launch cannot mint a fresh token
and lock out an endpoint already serving with the previous one.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:11:41 +00:00
praisonai-triage-agent[bot]andMervin Praison 466d27cb4d fix(recipe): persist streaming runs, correct run-id column, harden legacy import
- run_stream() now records a terminal RecipeResult (success/failed/policy/
  missing-deps/dry-run) via best-effort history, closing the streaming gap
- recipe runs: label the identifier column "Run ID" and align judge guidance,
  since `recipe judge` consumes the run_id (the index has no trace_id)
- legacy praison_ai: use direct attribute access (removes Ruff B009)
- tests: add streaming-persistence coverage; legacy test now exercises the
  wrapper-bridge resolution path the legacy branch actually uses

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:11:05 +00:00
praisonai-triage-agent[bot]andMervin Praison 808de04378 fix: run branch-safety checks before commit; preserve existing branches; apply divergence check to agent branches
Addresses reviewer P1s in github_commit_and_push:
- Safety refusals now run BEFORE staging a commit, so a refused push leaves
  pending changes intact and a retry can succeed.
- Existing local target branches are switched to with a plain checkout instead
  of `checkout -B`, so their local-only commits are not discarded.
- Divergence (force-push) refusal is factored out and applied to every branch,
  including agent-prefixed ones, and is never overridable.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:07:09 +00:00
praisonai-triage-agent[bot]andMervinPraison 187f07c7d6 fix: wire unattended-run policy, host-app job execution, and BotOS model pin (fixes #4079)
Defect 1: gateway now constructs a default RunPolicy (deliver-on-failure,
prompt scan, denied toolsets) with optional gateway.yaml `scheduler:` overrides,
so failed scheduled jobs notify the owner and unattended tool downscoping fires.

Defect 2: the host-app schedule bridge now executes due jobs via
ScheduledAgentExecutor; when no executor can be built it raises so ScheduleLoop
leaves the job due instead of silently absorbing it.

Defect 3: the BotOS scheduler path now enforces pin_model via the canonical
_check_model_drift before agent.chat — a drifted pinned job takes no model turn
and is recorded failed with the drift reason.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 08:00:58 +00:00
praisonai-triage-agent[bot]andMervinPraison 41eba72c2f fix: fence externally-POSTed webhook/hook payloads as untrusted data (fixes #4081)
Wire the existing untrusted-content fencing at the HTTP ingestion boundary so
webhook/hook payloads arrive labeled as data, not instructions:

- Add reusable wrap_request_payload() + <external_request_payload> fence
  constants to tools/trust.py (ingress counterpart to wrap_if_external).
- Extend the system trust clause to name the new fence.
- Fence payload-derived content in the webhook channel render_prompt: template
  interpolations and the raw-body default are fenced; the no-prompt case gains a
  fixed operator prefix so attacker text is never the sole instruction.
- Fence payload interpolations in the gateway hook resolve_message; operator
  template text stays outside the fence.

Fence closers embedded in payloads are delimiter-escaped to prevent breakout.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 08:00:20 +00:00
praisonai-triage-agent[bot]andMervin Praison 7aae9eb469 test: assert prompt-only run completes via agent branch
Address CodeRabbit/Greptile feedback: the prompt-only regression test
previously never asserted that execution completed or that the agent
branch ran, so it could pass while the job stayed queued. Now records
the agent-branch call and asserts a 200 result of "agent-result".

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 08:00:10 +00:00
praisonai-triage-agent[bot]andMervinPraison c8b47fe997 fix: wire recipe run history into execution and expose recipe runs (fixes #4084)
- Persist every RecipeResult via history.store_run at the end of recipe
  core.run(); gated by PRAISONAI_RECIPE_HISTORY (default on), write
  failures never fail the run (logged and ignored).
- Add `praisonai recipe runs [name] [--status] [--session] [--limit]`
  to the Typer app, rendering recipe/version/status/when/session/trace-id
  and delegating to history.list_runs.
- Fix the broken legacy import in praisonai-code by routing through the
  wrapper bridge to the real praisonai.cli.features.recipe module.
- Add unit tests for persistence, env flag, safe write failure, status
  filtering, registry independence, and clean handler import.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 07:59:39 +00:00
praisonai-triage-agent[bot]andMervinPraison 5d5d4c3aa7 fix: enforce launch auth + fail-closed bind on Agent.launch (fixes #4083)
Agent.launch served an unauthenticated prompt-execution HTTP endpoint on
0.0.0.0, while Agents.launch enforced PRAISONAI_LAUNCH_AUTH_TOKEN. Factor the
request authoriser and a fail-closed bind guard into a shared
launch_security module and apply it to both paths:

- Agent.launch HTTP route now returns 401 without the bearer token.
- Both paths auto-generate and print a one-time token when bound to a
  non-loopback host keyless (loopback keyless dev flow unchanged).
- Default host changed 0.0.0.0 -> 127.0.0.1 for both launch methods.
- Bearer compare is now constant-time.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 07:58:54 +00:00
praisonai-triage-agent[bot]andMervinPraison 56d60c099e fix: unify praisonai schedule store management surface (fixes #4078)
Make store-backed jobs first-class in the CLI so what `schedule add`
writes is what `list`/`delete` and the new subcommands read.

- CLI: `list` now merges store jobs (labeled [store]) with daemon
  schedulers; add `runs`, `pause`, `resume`, `update`, `remove` operating
  on the ScheduleJob store; `delete` finds store jobs first; `add --once`.
- Agent tools: add `schedule_pause`, `schedule_resume`, `schedule_update`;
  expose `once` on `schedule_add` (maps to delete_after_run). Registered
  in TOOL_MAPPINGS for lazy string resolution.

Scope: kept to praisonaiagents + praisonai per AGENTS.md. `schedule tick`
requires the Tier-2 praisonai-bot executor and is intentionally not added.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 07:58:41 +00:00
praisonai-triage-agent[bot]andMervinPraison deb6e4705a fix: add branch-safety guardrails to github_commit_and_push (fixes #4082)
Refuse autonomous pushes to the default/protected branch, foreign-author
branches, and diverged remotes (never force). Auto-create praisonai/ branch
when on default. Opt-in override via allow_unsafe_branch / env.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 07:57:28 +00:00
praisonai-triage-agent[bot]andMervinPraison 471159d47e fix: honour recipe fields on async runs API (fixes #4080)
The runs API declared recipe_name/recipe_config on JobSubmitRequest and the
executor implemented the recipe branch, but the router never copied those
fields into the Job — so POST /api/v1/runs {"recipe_name": ...} silently ran
nothing recipe-related. Copy the fields through and add regression tests.

Co-authored-by: MervinPraison <[email protected]>
2026-08-20 07:55:02 +00:00
ugbotueferhire 7a19370e98 fix: handle Windows carriage returns and Unicode encoding in tests 2026-08-20 08:54:57 +01:00
MervinPraisonandClaude Opus 5 742681c8af fix(sandbox): the two docker implementations handed you different Pythons
`docker` is implemented twice -- once as a compute provider, once as a
sandbox backend -- and the two defaults had drifted a minor version
apart. Same word, different container:

    tools_run_on="docker"  -> Python 3.12.14
    run_in="docker"        -> Python 3.11.16

Nobody decided that. Two independent implementations of one idea simply
diverged, and unifying the vocabulary made the divergence easier to reach
rather than harder, because both spellings now look like the same thing.

The sandbox side moves to python:3.12-slim to match, along with the CLI,
docs and examples that quoted the old default.

The parity test compares the values a caller actually gets --
SandboxConfig.docker().image against ComputeConfig().image. An earlier
version of it scanned the DockerCompute docstring, which meant it passed
while the defaults were genuinely 3.11 and 3.12 apart. A test that cannot
fail is worse than no test, because it is counted as coverage.

Rebased onto main and rebuilt rather than merged: this branch and main
had both appended to test_provider_matrix.py, and a textual merge cut a
function in half. Main's copy is taken whole and the one test unique to
this branch re-applied on top.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 08:50:58 +01:00
praisonai-triage-agent[bot]andMervin Praison d678838fa4 fix: cover workflow-edge async deps, cascade async dep failures, prevent truncate re-orphan
Addresses reviewer P1 findings on the async batch/window fixes:

- _depends_on_pending now also detects dependencies expressed via
  task.previous_tasks (workflow next_tasks edges are stored as task names),
  not only task.context, so a workflow successor is no longer queued in the
  same async batch as its predecessor and forced to read an empty result.
- New _deps_failed method extends the failure cascade to the async_execution
  path in both the sequential and workflow branches: after a same-batch flush,
  an async dependent whose prerequisite failed is marked failed instead of
  running with missing upstream context (previously only sync dependents were
  guarded).
- TruncateOptimizer re-skips leading orphaned tool results after its
  token-budget pop loop, which could otherwise drop an assistant tool_calls
  message while retaining its role="tool" result and leave the trimmed
  transcript starting on an orphan (Issue #3089).

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 07:47:23 +00:00
praisonai-triage-agent[bot]andMervin Praison 991b2ff28b fix: guard malformed tool-call JSON, tool-pair-safe window trimming, and same-batch async dependency ordering (fixes #4075)
1. Guard the tool-call argument JSON parse in the non-streaming native
   loops (openai_client.chat_completion_with_tools / achat_completion_with_tools)
   so a malformed/truncated arguments string is reported back to the model
   instead of aborting the whole agent turn, matching the streaming path.
   Also read the real tool name from tool_call["function"]["name"] in
   llm._parse_tool_call_arguments' error branch instead of the never-present
   top-level "name" key.

2. Route DefaultSessionStore._enforce_window's window slice through the
   existing _trim_preserving_tool_exchanges guard, and skip leading orphaned
   role="tool" messages in the context TruncateOptimizer/SlidingWindowOptimizer,
   so a persisted/optimized window never starts mid tool-exchange.

3. Split an async task batch on an intra-batch context dependency in
   arun_all_tasks (sequential + workflow) so a dependent async task's context
   is built after its same-batch dependency completes, not before.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 07:47:22 +00:00
MervinPraison dbe9431c1a docs: auto-update documentation parity trackers [skip ci] 2026-08-20 07:46:47 +00:00
Mervin Praison c85401fb3c Merge pull request #4077 from MervinPraison/refactor/retire-docker-managed-agent
refactor(placement): retire the bespoke docker backend, which could not be stopped
2026-08-20 08:46:10 +01:00
praisonai-triage-agent[bot]andMervin Praison 264dcd8a95 fix(compute): honour requested image= on E2B and Modal, not just Docker
The generic ComputeManagedAgent forwards image= through ComputeConfig.image,
which Docker/Daytona/Fly read but E2B (used metadata[e2b_template]) and Modal
(hardcoded debian_slim) ignored -- so run_on='e2b', image=... silently booted
the provider default. E2B now takes a non-default image as its template; Modal
builds it via from_registry. The default value leaves both unchanged. Adds
boundary conformance tests asserting the value each SDK actually receives.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 07:37:36 +00:00
MervinPraisonandClaude Opus 5 f0180ca532 refactor(compute): write the async-over-sync plumbing once, not once per vendor
Every cloud SDK here is synchronous and ComputeProviderProtocol is async,
so each provider grew the same five methods whose entire body is "hand the
matching _*_sync call to a thread":

    async def provision(self, config):
        loop = asyncio.get_running_loop()
        return await loop.run_in_executor(None, self._provision_sync, config)

Measured: provision, execute, shutdown, upload_file and download_file were
byte-identical across e2b, daytona, modal and tenki -- six identical pairs
per method, about 210 lines of the same four statements.

That was the largest genuinely duplicated block in the project, larger
than all four cross-stack vendor pairs combined. It stayed invisible
because it sits *within* one stack rather than between two, and the
attention had been on the cross-stack pairs, where the real overlap turns
out to be about 6%.

A vendor now implements only the _*_sync half it differs in. Anything a
provider genuinely does differently it overrides, because these are
ordinary methods -- flyio does exactly that, since it speaks HTTP through
aiohttp and is natively async rather than sync-wrapped.

Each unimplemented operation raises NotImplementedError naming the
provider, rather than silently returning a wrong answer.

Net -119 lines. Verified live: docker and modal both still provision and
execute, and the provider matrix passes for all thirteen places.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 08:34:36 +01:00
MervinPraisonandClaude Opus 5 0a1bd56a77 refactor(placement): retire the bespoke docker backend, which could not be stopped
`run_on="docker"` had its own 321-line managed backend while the other
seven places shared one generic implementation. The justification written
into that file -- it talks to the daemon directly and skips a
provisioning layer -- did not survive being checked.

It named its containers `praisonai-agent-<hex>`, while DockerCompute's
lookup expects `praisonai_<instance_id>`. So:

    praisonai managed ps    ->  shows the container
    praisonai managed stop  ->  ValueError: No docker container found

Listed but unreclaimable, which is the worst combination: the user can
see the thing they cannot stop. Routing through the provider fixes it by
construction, and 321 lines go with it.

Two gaps in the generic backend had to close first, both real:

  - `image=` fell into **kwargs and was silently ignored, so asking for a
    specific image quietly got the provider's default.
  - the failure when a place is unavailable now names the place and
    offers tools_run_on=, which needs no daemon.

The generated class is still called DockerManagedAgent -- make_loader
names each backend after its place -- but it is now a ComputeManagedAgent
subclass, so there is one code path for every runtime.

Also adds the conformance tests that would have caught this class of
problem: the four vendors implemented twice must agree on their
conventions. Docker-only parity is exactly what let Daytona drift into
asking for 1024 GiB of RAM.

Verified live: docker provisions, runs a whole agent loop, appears in
`managed ps`, and `managed stop` now reclaims it.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 08:28:55 +01:00
Mervin Praison e6099cbb50 Merge pull request #4074 from MervinPraison/fix/daytona-units
fix(daytona): asking for 1024 GiB of RAM, and uploading files backwards
2026-08-20 08:21:01 +01:00
praisonai-triage-agent[bot]andMervin Praison d8597c5008 test(backend): assert real hosted-runtime contract post run_on=
test_hosted_agent_only_accepts_anthropic encoded a pre-run_on= assumption
that modal/e2b were unavailable managed runtimes. The placement feature
intentionally registered them via the backend registry, so HostedAgent now
resolves them. Assert the guarantee that still holds — providers with no
registered backend (openai/gemini) raise a helpful ValueError — instead of
the stale one.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 07:13:56 +00:00
praisonai-triage-agent[bot]andMervin Praison 4c4160d286 test(daytona): assert SDK boundary, not source text
Replace inspect.getsource() substring checks with behavioral tests that
mock the Daytona SDK and assert the actual value passed: memory converted
to GiB (2048MB->2, 512MB->1) and upload_file(src, dst) argument order.
Addresses Greptile p2: source inspection let equivalent regressions pass
and harmless refactors fail.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-20 07:10:09 +00:00
MervinPraisonandClaude Opus 5 e56065d276 fix(daytona): asking for 1024 GiB of RAM, and uploading files backwards
Two live defects on the compute side of Daytona, both found by comparing
it against the sandbox side, which had already learned the conventions.

MEMORY UNITS. daytona_sdk documents Resources.memory as "Amount of memory
in GiB to allocate". The compute provider passed ComputeConfig.memory_mb
straight through, so the default configuration asked Daytona for 1024 GiB
of RAM. That is a provisioning failure, not a rounding error. The sandbox
implementation converts correctly and always has.

ARGUMENT ORDER. FileSystem.upload_file(src, dst) takes the content first
and the destination second. The compute side called
upload_file(remote_path, content), so an upload wrote the path into a
file named after the content. The sandbox side calls it correctly.

Neither is a typo in the ordinary sense: both are the same class of
failure, where one of two implementations of a single vendor learned a
convention and the other never did. Nothing compared them, so nothing
noticed. The wrapper's daytona tests only assert provider_name and that
the constructor exists -- nothing exercises provision() or upload.

Tests now assert both conventions on the compute side, because a shared
vendor name is not a shared understanding of that vendor.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 08:04:08 +01:00
MervinPraison 0a4742fdbf docs: auto-update feature parity trackers [skip ci] 2026-08-20 06:38:22 +00:00
Mervin Praison b02252abeb Merge pull request #4071 from MervinPraison/feat/provider-matrix
feat(placement): run_on= for every place that can host a loop, plus a provider matrix
2026-08-20 07:37:58 +01:00
MervinPraisonandClaude Opus 5 c4dbce2033 test(placement): assert the guarantee, not a timing detail
The provisioning tests asserted an exact count of one. SharedCompute
provisions LAZILY, so a run that never touches a tool correctly
provisions nothing -- the exact count was asserting when provisioning
happened rather than the property that matters, and it flaked.

The guarantee is that a run never provisions MORE than one sandbox, and
that a three-row batch does not mean three. Verified the weaker assertion
still has teeth: mutating _needs_tools_scope to always open a scope fails
six tests including the batch one.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:33:21 +01:00
praisonai-triage-agent[bot]andMervin Praison 82daf4e958 fix(compute): reclaim ephemeral instance when a remote run fails
An ephemeral place (keep_alive=False) provisions a billable cloud
instance, but execute() only tore it down on the success path -- a
failed write, remote run, or parse left the instance running until
external cleanup. Move shutdown into a finally so teardown is
unconditional; keep_alive=True still keeps the warm instance.

Fixes the Greptile P1 on compute_managed_agent.py.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 23:30:36 +00:00
MervinPraisonandClaude Opus 5 253ab78e4a fix(placement): sandbox plugins were invisible to tools_run_on=
SANDBOX_ONLY was a hardcoded tuple of four names. The sandbox registry
accepts plugins by entry point, so a contributed backend worked with
run_in= and could not be selected with tools_run_on= at all -- the same
hardcoded-list bug just fixed for the compute registry, one layer down.

`capsule` was the live example: it ships from praisonai-plugins, resolves
fine through run_in=, and was missing from the tools_run_on= vocabulary
for no reason a user could see.

The names now derive from the registry, with the original four kept as a
floor so nothing depends on discovery succeeding. Anything the compute
registry already provides is excluded, so docker/e2b/modal/daytona keep
their richer implementations instead of being downgraded to the
one-instance adapter.

SANDBOX_ONLY stays a tuple subclass that re-reads the registry on
membership and iteration, because several call sites predate this and
import it directly.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
MervinPraisonandClaude Opus 5 7c67c1a94f feat(placement): a contributed place can name itself
The phrase table is a literal, so it cannot know about a package
installed later: an external place printed as a bare name
(tools_run_on='demo') while every built-in got a readable phrase. A
provider may now declare `display_name` and have it used in the repr and
in where_does_it_run().

Verified with a plugin installed from outside the repo: it reports
"a Demo cloud sandbox" in both. Declaring it stays optional and the
fallback to the bare name is unchanged, so nothing existing shifts.

That leaves one derived surface still hand-maintained -- the ToolPlace
Literal -- which is inherent to static typing rather than fixable: a type
checker cannot see a runtime plugin. Its union already stays open, so an
unknown name type-checks and only loses autocomplete.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
MervinPraisonandClaude Opus 5 e81d0e55de fix(cli): managed ps polls the registry, not a literal
_PS_PROVIDERS was a hardcoded tuple, so a place contributed by another
package could be provisioned and then never listed or stopped. An
unreclaimable cloud sandbox is a bill nobody sees, which makes this the
one remaining hand-maintained list with a cost attached.

Exclusions are now stated with reasons rather than by omission: local and
subprocess run here and have nothing to reclaim, ssh is someone else's
machine and not ours to stop, sandlock is a process rather than an
instance, and adapter-backed places have no cross-process registry to
enumerate.

_PS_PROVIDERS stays as a module attribute so existing imports keep
working.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
MervinPraisonandClaude Opus 5 adc4253f2a test(providers): check every provider and SDK without needing a credential
Modal's `run_in=` path was broken in five separate ways and nothing
noticed, because nothing had ever run it. Most of what breaks an
integration is checkable for free, so this checks it: for all ten places
the class resolves, satisfies the protocol, exposes coroutines rather
than sync methods (a sync one here does not raise -- it returns a
coroutine nobody awaits, so the call silently does nothing), answers
is_available without throwing, is accepted by tools_run_on=, is accepted
or refused by run_on= according to whether it can host a loop, and is
described in the repr as the place it was actually given.

The one that matters most in practice is the last check: a missing
credential has to fail with something actionable -- naming the key, the
install command or the daemon -- rather than an AttributeError from
inside a vendor SDK. All seven credential-less places pass it today.

Live where the machine allows: docker, subprocess, local and modal
provision and execute for real; the rest skip loudly.

Also removes a latent flake. The batch-provisioning test asserts an exact
provision count, and agents from earlier tests release their sandbox when
collected -- which could land inside the measurement window now that
lifetime is tied to a finalizer. The window is opened after a collection
instead of hoping the timing misses.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
MervinPraisonandClaude Opus 5 c454fea7f4 feat(placement): run_on= now covers every place that can host a loop
run_on= accepted two names while tools_run_on= accepted twelve. That was
not a fact about the places -- a place that can run a command can run the
agent loop, which is just one more command -- it was an implementation
detail: no backend had been written for the rest.

One generic ComputeManagedAgent wraps any ComputeProviderProtocol rather
than eleven near-identical vendor backends, taking run_on= from 2 places
to 8: anthropic, docker, e2b, modal, daytona, flyio, tenki, novita.

Verified live end to end on Modal -- the whole loop ran there and came
back with the answer, having installed the package remotely first.

Excluded deliberately, with tests asserting they still raise: `local`
would run the agent in your own shell, which is what you get by passing
nothing; `ssh` needs an object, not a name; `subprocess`/`sandlock`
isolate tools rather than host a runtime. `docker` keeps its specialised
backend since it can talk to the daemon directly.

Two details worth keeping:
- the registry loader returns a real subclass, not a factory function,
  because HostedAgent's factory path calls issubclass() on it
- files reach the remote machine through a quoted heredoc, since execute()
  is the only primitive every compute place has, and the delimiter is
  uppercase for the same reason as elsewhere: a lowercase hex delimiter
  contains "dd", a blocked command, about a tenth of the time

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
MervinPraisonandClaude Opus 5 de562fa043 fix(modal): run_in="modal" was dead five times over
Modal is authenticated on this machine, so the path could finally be
exercised. It failed five times in a row, each fault hiding the next:

1. keep_warm / allow_concurrent_inputs were renamed on 2025-02-24 and
   the old spellings now RAISE rather than warn. Both generations are
   handled by inspecting the installed SDK's signature, since hardcoding
   either spelling breaks half the installed base.
2. The decorated function is defined inside a method, which Modal only
   accepts with serialized=True.
3. The App was never started. A Modal function only carries the metadata
   it needs while its App is running, so .remote() failed with "Function
   has not been hydrated". The app.run() context is now held for the
   sandbox's lifetime and closed in stop().
4. add_python="3.11" was passed to an image that already ships Python --
   the default is python:3.11 -- so the image build failed outright.
5. The default image was pinned to 3.11 while a serialized function is
   pickled locally and unpickled inside it, so anyone not on 3.11 got
   "defined with Python 3.12, but its Image has 3.11". The default now
   follows the running interpreter.

Verified end to end: execute_code(run_in="modal") returns 'from modal'
with exit 0 against real Modal infrastructure.

tools_run_on="modal" was already working and is now verified live too --
provision, uname, a file written and read back across calls, shutdown.

The test asserting a hardcoded python:3.11 default was updated rather
than deleted; it now pins the interpreter-matching rule that replaced it.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
MervinPraisonandClaude Opus 5 2e237537bd feat(placement): let other packages contribute a place
Two of the three registries already discovered plugins by entry point --
praisonai.sandbox and praisonai.managed_backends. The compute registry,
which is where tools_run_on= places live, was a hardcoded dict, so adding
one meant editing core:

  _compute_bridge._PROVIDERS       the resolver
  compute/__init__.py              the lazy import
  placement.ToolPlace              or it gets no typing
  cli/commands/managed._PS_PROVIDERS  or `managed ps` cannot see it
  execution_location._PLACE_WORDS  or it prints a bare name
  plus the lists in two docstrings

Six edits across two packages, for something that is by nature a plugin.
It now reads praisonai.compute as well, so a provider ships in its own
distribution:

    [project.entry-points."praisonai.compute"]
    runpod = "praisonai_compute_runpod:RunpodCompute"

Verified end to end with a package installed outside this repo: it
appeared in available_providers(), passed tools_run_on= validation,
resolved, executed, and Agent(tools_run_on="demo") built -- with no
change to any file here. The repr falls back to the bare name, which is
the one remaining hand-maintained list and degrades gracefully.

Providers load on demand, so an installed-but-broken plugin fails only
for the caller that names it. There is a test for that.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-20 00:26:10 +01:00
praisonai-triage-agent[bot] f4c5ba37da Merge pull request #4070 from MervinPraison/feat/unified-run-on
fix(placement): one word still meant two backends, and the repr hid it
2026-08-19 22:46:10 +00:00
praisonai-triage-agent[bot]andMervin Praison 32d3c8c1b7 test(gateway): isolate start-command tests from the on-disk config so verify-turn does not fire
The bots-gateway CI shard runs from src/praisonai-bot, whose gateway.yaml was
auto-discovered when these tests invoked `gateway start` with config=None.
Discovery then ran the verify-turn pre-flight (a real agent turn, default-on
per #4042) before the monkeypatched start(), exiting 1 with CI's fake key.

Pass an explicit channel-less config so every start-time pre-flight is skipped
and the command reaches the patched handler deterministically. The exit-code and
watchdog-flag assertions are unchanged — the tests still guard exactly what they
did, just hermetically.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 22:00:30 +00:00
praisonai-triage-agent[bot]andMervin Praison 00ba9b7f94 fix(placement): a backend's LocalCompute object no longer borrows subprocess's words
The compute-only branch ran before the provider object was normalised, so a
managed backend holding a LocalCompute (provider_name="local") skipped it and
the alias table collapsed "local" to "subprocess" -- describing the
unrestricted shell in the locked-down backend's stronger words. Normalise
first, then apply the compute-only check, and read a backend's compute via the
compute vocabulary since that object is a compute-registry provider.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 22:00:30 +00:00
MervinPraison 1dc14b9f90 docs: auto-update documentation parity trackers [skip ci] 2026-08-19 21:18:42 +00:00
Mervin Praison cb4a702655 Merge pull request #4069 from MervinPraison/feat/run-on-docker
feat(placement): run_on="docker" — the whole agent in a container you own
2026-08-19 22:18:07 +01:00
praisonai-triage-agent[bot]andMervin Praison 374ca9a8a4 fix(docker): don't block the loop, don't leak the container, don't contradict the docs
Three issues raised in review of run_on="docker":

- execute()/stream() ran the blocking Docker start-up, install and container
  turn directly on the event-loop thread, stalling concurrent async callers.
  Offload to a worker thread with asyncio.to_thread.
- keep_alive=False only tore the container down on success, so a failure after
  start-up leaked a praisonai-agent-* container. Move teardown into finally.
- Both READMEs showed run_on="docker" raising TypeError while also documenting
  it as supported. The typo example now uses e2b, which genuinely cannot host
  an agent loop, so the two examples no longer contradict each other.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 21:17:10 +00:00
MervinPraisonandClaude Opus 5 0577772b39 feat(placement): run_on="docker" — the whole agent in a container you own
`run_on="anthropic"` hands the entire agent to a vendor's runtime. This is
the same shape, self-hosted: the loop runs in a local container instead.

The distinction from tools_run_on="docker" is what crosses the boundary:

  tools_run_on="docker"  your process runs the loop and calls the model;
                         only shell and file tools go into the container
  run_on="docker"        the loop itself runs inside, so the model call is
                         made from the container and nothing on your
                         filesystem is reachable unless you mounted it

Both name the same place, and that is not an ambiguity -- the parameter
carries the scope. So the two value sets deliberately overlap now, and
the tests say so: a name in both must work in both, a name in only one
must be refused by the other with a message naming the right parameter,
and the object must still report which scope you chose.

Implementation is just a backend registration. run_on= resolves against
ManagedBackendRegistry, so adding DockerManagedAgent there makes the
parameter, the repr, the explanation and the conflict checks all pick it
up with no changes to any of them.

Two things this exposed:

- _backend_places() identified hosted runtimes by CLASS NAME ("Hosted" or
  "Anthropic" in it). A self-hosted DockerManagedAgent matched neither,
  so an agent whose entire loop ran in a container reported that it was
  thinking on this machine. Backends are now asked what they are.

- The runner writes its payload into the container through `docker exec
  -i ... tee` rather than an argument, so instructions and API keys never
  appear in `docker inspect` or a process listing.

Stated limitations rather than hidden ones: Python callables in tools= do
not cross (same as the hosted runtimes), the container needs the model
API key, and the first run installs the package unless image= supplies
one that has it.

Tests that need a live daemon are marked skipif rather than silently
passing; the rest -- registration, both scopes, config marshalling,
result parsing, the missing-daemon message -- run without Docker.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 22:08:49 +01:00
MervinPraisonandClaude Opus 5 70ba441a2f fix(placement): one word still meant two backends, and the repr hid it
Two gaps found while documenting every accepted value.

"local" resolves differently depending on which parameter carried it:
run_in="local" is collapsed by SandboxManager to the subprocess backend
-- scrubbed environment, blocked commands and paths -- while
tools_run_on="local" is the wrapper's LocalCompute, a plain shell in the
current directory with the full environment inherited and no security
policy at all. Both printed "a separate process on this machine", so the
weaker of the two was described in the stronger one's words. That is
precisely the failure this module exists to prevent, hiding in the one
place the rest of the work did not look. say_place() now takes the
registry that resolved the name.

Resolver aliases were rejected at construction. Validation ran before
alias resolution, so tools_run_on="native" raised "not a known place"
while resolve_compute("native") returned a working sandlock adapter.
tool_places() now includes the alias table it validates against.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 22:01:38 +01:00
Mervin Praison 2f2b2d63c7 Merge pull request #4068 from MervinPraison/feat/unified-run-on
feat(placement): one vocabulary for where agents, tools and code run
2026-08-19 21:06:48 +01:00
MervinPraisonandClaude Opus 5 1d61aed1f9 test(managed): update the one assertion the merged resolver changed
LocalManagedAgent carried its own hardcoded provider list, which is why
LocalAgent(tools_run_on="sandlock") raised "Unknown compute provider"
for a place the rest of the library resolves happily. Routing it through
the merged resolver changes the message to "Unknown place", listing
every place both registries offer.

The behaviour is unchanged -- an unknown name still raises ValueError --
so only the assertion was stale. Added coverage for what the delegation
actually buys: the sandbox-only places now resolve here too.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 21:03:35 +01:00
praisonai-triage-agent[bot]andMervin Praison 4ffa3488a4 fix(placement): isolate concurrent async team runs with a ContextVar
Two coroutines that astart() the SAME team under one asyncio.gather share
the event-loop thread, so the previous threading.local scope state was
shared between them: the second saw the first's depth==1, skipped its own
sandbox, and ran against a sandbox the first could tear down mid-flight.

Switch _tools_scope_depths from threading.local to a contextvars.ContextVar
holding an immutable frozen mapping replaced via .set() (never mutated in
place). A ContextVar is copied per task at gather/create_task time, so each
run gets its own depth map; it stays per-thread too, so sync callers remain
isolated. The frozen value matters -- a copied context shares the reference
to a mutable dict, so in-place mutation would leak straight back across the
tasks the copy was meant to separate.

Adds a deterministic regression test that fails on the old design
(['own', 'borrowed']) and passes now (['own', 'own']) without needing a
live model.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 19:50:48 +00:00
MervinPraisonandClaude Opus 5 ea017740bf docs(placement): say plainly that the local tier is not a boundary
The security audit demonstrated `cat $(echo /etc/passwd)` reading the
file end-to-end through the subprocess place: blocked_paths matches
tokens, and any shell indirection -- command substitution, a variable, a
nested sh -c -- hides the path from it. That is inherent to a blocklist
over a real shell, not a patchable pattern, so where_does_it_run() now
says the command list can be worked around rather than implying the
tier contains anything.

Also updates the flagship YAML example to tools_run_on:, lists the four
newly reachable places, and marks which of them are real boundaries
(sandlock is kernel-enforced; subprocess is process separation only).

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 20:36:20 +01:00
MervinPraisonandClaude Opus 5 85af51b0d6 fix+test(placement): close the gaps mutation testing exposed
Mutation testing showed 7 of 14 deliberate breakages left the suite
green. The pattern was consistent: argument validation and repr strings
were well covered, and every path that actually moves work to a sandbox
was not covered at all. Deleting the ensure_tools_placed() call sites --
the feature's entire point -- broke nothing.

Bugs fixed:

- A clone inherited the source agent's bridged tools, which close over
  the SOURCE's sandbox, and its backstory already carrying the capability
  prompt. Its first turn then attached a second sandbox: two copies of
  the prompt, and work split across two machines. The tools are now
  tagged so the existing clone filter drops them, and the clone inherits
  the pre-attach backstory.

- test_apply_rlimits_sets_memory_limit still asserted RLIMIT_NPROC was
  set. It passed on main and failed here, because dropping NPROC is
  deliberate. Replaced with an assertion that it is NOT set, plus a new
  test that one unsupported limit no longer skips the others -- the
  latent bug that made RLIMIT_NOFILE never apply on macOS.

Tests added for what survived mutation:
  - every entry point (chat/achat/_start_stream) places tools before the
    first turn, asserted by driving the real method
  - AgentTeam start/astart/start_for_each provision exactly one sandbox,
    counted through a fake provider, instead of poking a private method
  - policy_scan_parts expands shell payloads, survives unbalanced quotes,
    strips quoted heredoc bodies but NOT unquoted ones, and a blocked
    path inside `sh -c` is genuinely refused (asserting the file was not
    read, not merely that an error was returned)
  - SandboxComputeAdapter, which had zero tests despite being the largest
    new file: policy denials report failure rather than exit 0, shell
    semantics work, state persists across calls
  - SandboxManager constructor introspection, including that the guided
    error names `host` and SSHSandbox rather than leaking a raw TypeError

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 20:32:15 +01:00
MervinPraisonandClaude Opus 5 c5ddc2d526 fix(sandbox): stop the policy check reading file contents as commands
Two reliability bugs the security audit reproduced.

write_file() built a heredoc delimiter from uuid4().hex, which is
lowercase. The security policy substring-matches blocked_commands
against the whole command string, and "dd" is one of them -- present in
9.6% of random lowercase hex strings (measured over 100k). So roughly
one write in ten failed with "Blocked command pattern: dd", for no
reason the caller could see. The delimiter is uppercase now.

The same substring scan also read the heredoc BODY, which is the literal
bytes of a file, not a command. Saving a shell tutorial containing
"rm -rf" was rejected as an attempt to run it; a file mentioning
/etc/passwd was rejected as an attempt to read it. Quoted heredoc
bodies are now stripped before the policy check -- only the quoted form,
since an unquoted heredoc still undergoes shell expansion and its
contents really can execute.

Verified the boundary is unchanged: `cat /etc/passwd` and `rm -rf /`
are still blocked, while all three content cases now write, and 60
consecutive writes produce 0 spurious failures.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 20:18:55 +01:00
MervinPraisonandClaude Opus 5 7d54af6b5c fix(placement): sandbox lifetime, and stop one global lock serialising everything
Four lifecycle bugs, all found by adversarial validation.

LEAK. An agent and its SharedCompute referenced each other, so a dropped
agent was reclaimed by the CYCLE collector, vanished from the WeakSet the
atexit hook iterated, and its sandbox was never shut down. Gateways clone
an agent per request, so that was one orphaned container per request --
measured: 5 requests, 5 provisioned, 0 shut down.

Fixed by tying lifetime to the agent with weakref.finalize (which also
covers interpreter exit, so the atexit hook and weak set are gone), and
by holding agents WEAKLY in SharedCompute._patched. The weak _patched is
the load-bearing half: while the restore list held agents strongly, the
finalizer kept its own agent alive and could never fire.
Now: 5 provisioned, 5 shut down, 0 leaked.

RACE. close_tools_sandbox() cleared the marker first and shut down after,
outside the lock. A concurrent chat() re-attached in that window and the
in-flight shutdown restored over it, leaving the agent marked as
sandboxed while holding no sandbox tools -- unrepairable, because
ensure_tools_placed()'s idempotent early return sees the marker and does
nothing. It is all under the lock now.

EXIT HANG. The exit path took a process-global lock, so any thread
holding it blocked interpreter exit forever (reproduced: rc=124). The
realistic form was a bounded stall, since the lock was held across
SharedCompute(...) -- which imports the provider SDK.

CONTENTION. That same global lock serialised placement for unrelated
agents (16 concurrent attaches: 0.87s against a 0.05s parallel floor),
and being non-reentrant while held across attach()'s writes to
agent.tools, any subclass with a tools setter that touched placement
would self-deadlock in its own constructor. Locks are per-agent now, and
the only global lock covers a dictionary lookup.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 20:18:08 +01:00
MervinPraisonandClaude Opus 5 76ea2793db fix(placement): team sandboxes were provisioned but never reached the model
Two bugs found by adversarial validation, both silent.

1. AgentTeam handed the model the PRE-ATTACH tool list.
   _build_execution_context snapshots agent.tools and passes it to chat()
   as an explicit `tools=`, which wins over agent.tools. The sandbox
   attached later, inside chat(), so the model got the local tools while
   a real sandbox sat provisioned and unused -- every tool ran on the
   host. Placement now happens before the snapshot.

   It read as flaky rather than broken: in start_for_each() row 1 got
   local tools and row 2 got the bridged set, because row 1's chat() had
   mutated agent.tools in time for row 2's snapshot.

2. The scope depth was shared class-wide, not per team.
   `_tools_scope_state` is a class attribute, so ANY team started while
   another team's run was on the stack saw depth==1 and skipped its own
   sandbox. A nested team ran on the host; a team sharing an agent with
   the outer run executed on the OUTER team's sandbox; two teams in one
   asyncio.gather gave one a sandbox and the other nothing. Depth is now
   keyed per team, and the key is dropped at zero so the dict cannot grow
   without bound on a long-lived worker thread.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 20:16:34 +01:00
MervinPraisonandClaude Opus 5 5743ef0829 feat(placement): one vocabulary for where agents, tools and code run
Three parameters meant "somewhere else" and none of them said which
somewhere: `run_on=` (tools only, on Flow/Team), `compute=` (tools only,
on LocalAgent) and `backend=` (the whole agent). One concept had two
names and one name had two concepts, so the docs had to keep correcting
the API.

Now two words, each answering a different question:

  run_on=        the WHOLE agent moves to a managed runtime
  tools_run_on=  only the tools move; thinking stays here
  run_in=        one execute_code() call, this call only

Because the two questions have disjoint answer sets, a wrong pairing is
a typo rather than a preference. `run_on="docker"` cannot mean anything
-- Docker does not host agent loops -- so it raises TypeError naming the
parameter the user actually wanted, instead of silently placing work on
a machine nobody chose. Never "last one wins".

Reachability: sandbox-only backends (subprocess, sandlock, ssh, novita)
spoke SandboxProtocol -- one object IS one environment -- while
tools_run_on= speaks ComputeProviderProtocol -- one object HANDS OUT
many. SandboxComputeAdapter supplies the missing half, taking the
registry from 7 places to 11. This finally makes `sandlock` selectable:
kernel-enforced Landlock + seccomp-bpf, the only real local boundary in
the project, previously unreachable.

Shipped bugs found and fixed along the way:
  - AgentTeam.astart() never provisioned the shared sandbox at all, so
    every async team ran its tools on the host and said nothing.
  - start_for_each() provisioned one sandbox per input row: a 50-row
    batch paid for 50, and no row could see what an earlier row wrote.
  - The re-entry guard set `self.run_on = None` for the duration of a
    run, so a concurrent start() observed "no sandbox" and executed
    every tool on the host. Now thread-local; placement stays readable.
  - SharedCompute.attach() could attach an agent twice (flow + its own),
    duplicating the capability prompt and, on non-LIFO teardown, leaving
    the agent holding tools bound to a shut-down instance.
  - SandboxManager passed config= to every backend; SSHSandbox and
    ModalSandbox do not accept it, so they raised before starting.
  - RLIMIT_NPROC was applied per *real user ID*, not per sandbox, so
    max_processes=10 counted the user's existing processes and the
    sandbox could not fork at all.
  - blocked_paths stopped matching once commands ran through `sh -c`,
    because the path hid inside the shell payload.

Removed ExecutionConfig.code_sandbox_mode. It defaulted to "sandbox"
while no execution path read it, so its own default told every reader
they had isolation they did not have.

where_does_it_run() now names the tools that will NOT move. Only four
tool names are bridged; the capability prompt tells the model the
sandbox is where things happen, so anything staying behind has to be
said out loud.

Migration:
  - YAML `run_on:` stays a silent alias -- it is data people already
    shipped, and there is no Agent-level run_on: key to confuse it with.
  - Python `run_on=` on Flow/Team raises with a directed message; it
    would otherwise mean the opposite of `run_on=` on Agent.
  - `compute=` warns (FutureWarning, visible to end users per PEP 565).
  - `Agent(sandbox=)` is kept, not removed: clone_for_channel() passes
    it and it is a legitimate per-agent default. `run_in=` overrides it
    per call.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 19:52:23 +01:00
Mervin Praison 59fc35ce5f Merge pull request #4023 from MkaliezZ/feat/agentfuse-tool-middleware
feat(agents): propagate tool_call_id through middleware context
2026-08-19 19:49:29 +01:00
Mervin Praison adf464bf50 Merge pull request #4017 from MervinPraison/claude/issue-4016-20260817-1715
fix: scope memory availability probe to skip FileMemory path
2026-08-19 19:40:17 +01:00
Mervin Praison fbd0e37500 Merge pull request #4020 from MervinPraison/claude/issue-4019-20260818-0710
fix: wire task when-routing, guard Knowledge/Memory erasure, apply defaults.guardrails
2026-08-19 19:39:31 +01:00
MervinPraison 5bd4b3eeee docs: auto-update api.md [skip ci] 2026-08-19 18:34:28 +00:00
Mervin Praison 8162421d16 Merge pull request #4034 from MervinPraison/claude/issue-4033-20260819-0710
fix: PII redaction hook, planning task restore, and tool-pair reconciliation
2026-08-19 19:33:53 +01:00
Mervin Praison 1d4d07d074 Merge pull request #4040 from MervinPraison/claude/issue-4037-20260819-0850
fix: zero-config OAuth for remote MCP servers (metadata discovery + Dynamic Client Registration)
2026-08-19 19:33:22 +01:00
Mervin Praison f8d4c82b52 Merge pull request #4041 from ugbotueferhire/fix/mathlib-implementations
fix: implement missing mathlib functions
2026-08-19 19:31:54 +01:00
Mervin Praison 2b64efbe96 Merge pull request #4045 from MervinPraison/claude/issue-4042-20260819-0916
fix: run a real agent turn at gateway startup and onboarding (#4042)
2026-08-19 19:31:31 +01:00
Mervin Praison e22db2b507 Merge pull request #4058 from ugbotueferhire/fix/pytest-timeout-mark-clean
fix: register pytest timeout marker in pytest.ini
2026-08-19 19:24:25 +01:00
Mervin Praison d32fe29b42 Merge pull request #4060 from MervinPraison/claude/issue-4053-20260819-0953
fix: wire verification hooks into an enforced completion gate
2026-08-19 19:24:10 +01:00
Mervin Praison 49d6997094 Merge pull request #4064 from ugbotueferhire/fix/shell-substitution-tests
fix: strip whitespace to handle Windows carriage returns in shell tests
2026-08-19 19:21:26 +01:00
Mervin Praison acec62618c Merge pull request #4065 from ugbotueferhire/fix/hybrid-workflow-tests
fix: skip hybrid workflow shell tests on Windows
2026-08-19 19:20:32 +01:00
Mervin Praison 3bf3314284 Merge pull request #4067 from MervinPraison/claude/issue-4066-20260819-1715
refactor: consolidate 13x task-name lookup idiom in process.py
2026-08-19 19:13:43 +01:00
praisonai-triage-agent[bot]andMervinPraison f60b7a96fc refactor: consolidate 13x task-name lookup idiom in process.py (fixes #4066)
Extract the repeated inline `next((t for t in self.tasks.values()
if t.name == <name>), None)` into a single `_task_by_name` helper and
call it at all 13 sites. Behaviour-identical: first-match by name,
None when absent. No public API or behaviour change.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 17:18:31 +00:00
ugbotueferhire d8121ab392 fix: skip hybrid workflow shell tests on Windows 2026-08-19 13:24:20 +01:00
praisonai-triage-agent[bot]andMervin Praison 172e90c934 test: run echo shell-substitution test cross-platform via shell builtin
Remove the shutil.which("echo") skipif: TemplateInterpolator runs commands
with shell=True, so echo is available as a shell builtin on both cmd.exe and
/bin/sh even without a standalone executable. Normalise output with .strip()
for Windows CRLF instead, restoring coverage. Also drops the now-unused shutil
import and trailing whitespace.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 11:52:00 +00:00
ugbotueferhire fd310f3786 fix: strip whitespace to handle Windows carriage returns in shell tests 2026-08-19 12:44:16 +01:00
praisonai-triage-agent[bot] 4d38313565 Merge pull request #4062 from MervinPraison/claude/issue-4052-20260819-0953
fix: make workflow routing surfaces execute instead of silently falling through
2026-08-19 11:12:39 +00:00
praisonai-triage-agent[bot] 868f3e6c6e Merge pull request #4061 from MervinPraison/claude/issue-4055-20260819-0954
fix: expose workflow checkpoint resume from CLI + fingerprint the definition
2026-08-19 11:06:34 +00:00
praisonai-triage-agent[bot] 07903c0aae Merge pull request #4059 from MervinPraison/claude/issue-4056-20260819-0955
fix: session handoff continuation prompt + default structured compaction summary
2026-08-19 11:04:16 +00:00
praisonai-triage-agent[bot] 83648c9b54 Merge pull request #4054 from MervinPraison/claude/issue-4050-20260819-0947
fix: durable retry + WhatsApp/Signal senders for standalone scheduled delivery
2026-08-19 11:00:31 +00:00
praisonai-triage-agent[bot] 34fb85aaec Merge pull request #4051 from MervinPraison/claude/issue-4048-20260819-0946
fix: add recurrence generator to SuggestionEngine.observe() (#4048)
2026-08-19 10:53:38 +00:00
praisonai-triage-agent[bot] acf96b3e13 Merge pull request #4047 from MervinPraison/claude/issue-4044-20260819-0917
feat: gateway diagnostics export sanitised support bundle
2026-08-19 10:46:24 +00:00
MervinPraison 3311cef626 docs: auto-update feature parity trackers [skip ci] 2026-08-19 10:42:19 +00:00
praisonai-triage-agent[bot] a4ee5e92b8 Merge pull request #4057 from MervinPraison/claude/issue-4049-20260819-0947
fix: give scheduled automations cross-run memory (JobStateStore)
2026-08-19 10:41:51 +00:00
praisonai-triage-agent[bot] a7ca5ea65f Merge pull request #4046 from MervinPraison/claude/issue-4043-20260819-0917
fix: re-drain durable outbox when a channel recovers
2026-08-19 10:36:31 +00:00
ugbotueferhire e02ae4c42a fix: skip hanging test_get_runtime_descriptor_keeps_live_lock 2026-08-19 11:33:50 +01:00
praisonai-triage-agent[bot]andMervinPraison 44d501c73e fix: validate agent refs nested in route/parallel/loop/if payloads (#4062)
Cross-reference validation only inspected step.agent, step.steps, and
step.routes, so undefined agents nested inside the newly accepted bare
runtime-form payloads (route:/parallel:/loop:/repeat:/if:) silently
passed while the runtime parser drops/rejects them (Greptile P1).

- Walk route: value lists (agent-name scalars) and parallel/loop/repeat/if
  sub-step dicts (agent: keys), leaving non-agent scalars like
  loop: {over: <var>} untouched.
- Regenerate the stale agents.schema.json artefact to match the PR's
  broadened WorkflowStep model.
- Add tests for undefined agents in route/parallel payloads and a
  loop-over-variable false-positive guard.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 10:12:53 +00:00
praisonai-triage-agent[bot]andMervin Praison 24b1fc6c7f fix: address verification-gate review findings (async, journal, diagnostics)
- Async event loop: run_autonomous_async now offloads verification hook
  execution to a worker thread via _verification_gate_async so a slow/blocking
  CommandVerificationHook no longer stalls concurrent coroutines.
- Durable journal: rewire _record_verification_journal to the real
  DurableRunContext.record_verification (append JournalEvent, KIND_VERIFICATION)
  instead of a non-existent _run_journal.record API; events now actually persist.
- Goal gate: a failing blocking hook now carries the captured stdout/stderr
  summary into last_reason so the next continuation prompt has actionable repair
  diagnostics instead of a bare label.
- Tests: +4 covering async thread-offload, durable journal persistence, and
  goal-failure diagnostics propagation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 10:11:22 +00:00
praisonai-triage-agent[bot]andMervinPraison 2281f14b09 fix: fail closed on missing checkpoint + hash config values in fingerprint
Addresses two P1 correctness gaps from PR review:
- Explicit --resume onto an absent/misspelled/deleted checkpoint now returns
  a clear error instead of silently running the workflow from step 1 and
  repeating already-completed side effects.
- _definition_fingerprint now hashes agent config values (not just keys), so
  semantic edits (instructions/model/tools/condition/routing) invalidate the
  checkpoint rather than combining a stale step index with an edited workflow.

Adds two regression tests: missing-checkpoint fail-closed, config-value edit
changes fingerprint.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 10:10:15 +00:00
praisonai-triage-agent[bot]andMervin Praison 489c7a9527 fix: preserve NEXT tail in handoff cap; don't mark assistant questions as completed
Addresses two P1 review findings on PR #4059:

- handoff._cap: capping an oversized recap dropped the actionable NEXT:
  continuation guidance. Cap now preserves the head (preamble/goal/progress)
  and the NEXT: tail verbatim, trimming only the middle recap block.
- summary_builder: assistant turns that merely proposed or *asked* about work
  were recorded under "Completed Actions", so a resumed agent could skip work
  only discussed. Question-bearing assistant turns now flow to Pending
  Questions / Remaining Work only; executed tool calls/results stay completed.

Adds regression tests for both.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 10:07:08 +00:00
praisonai-triage-agent[bot]andMervinPraison 57b278beb0 fix: make workflow routing surfaces execute instead of silently falling through (fixes #4052)
- Defect 1: map parsed markdown routing (TaskRoutingConfig) onto real
  Task.branch_condition/next_steps the executor reads; stop clobbering
  condition with a dataclass; guard dict-condition crash in step loop.
- Defect 2: wire Task(when=..., then_task=..., else_task=...) into the
  WorkflowManager step-advance path for per-step conditional redirection.
- Defect 3: register `workflow validate` on the Typer workflow app so it
  reaches the existing handler.
- Defect 4: align WorkflowStep schema with the runtime dialect (bare
  agent/route/if/loop/repeat/parallel/include steps) and treat
  backstory/instructions as aliases so shipped example workflows validate.
- Defect 5: fix .praison -> .praisonai list dir via shared path helper;
  reject unsupported on_fail values clearly; fail loudly on YAML files in
  the markdown workflows dir.
- Tests: executable markdown branch routing (matched + unmatched), when
  routing, and a round-trip validation over examples/yaml/workflows/.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 10:04:51 +00:00
praisonai-triage-agent[bot]andMervinPraison bdf9644846 fix: expose workflow checkpoint resume from CLI + fingerprint the definition (fixes #4055)
Wire --resume/--checkpoint/--rebase-checkpoint into `workflow run` and add a
`workflow checkpoints` subcommand. Store a stable, normalized definition
fingerprint in each checkpoint and compare it on resume, refusing to silently
land on a stale step index after the workflow file was edited (with
--rebase-checkpoint to force). Record resumed_from_step in the result.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 10:03:14 +00:00
praisonai-triage-agent[bot]andMervin Praison 562aa735d0 fix: deep-copy job state on read/write; skip one-shot state persistence
Addresses two reviewer-flagged issues in the scheduler cross-run memory:

- P2 (nested aliasing): get_state/set_state now deepcopy so a caller
  mutating a nested list/dict in a read result can no longer bypass the
  16 KiB size cap or copy-on-read guarantee.
- P1 (orphan one-shot state): _persist_job_state now skips
  delete_after_run jobs, which claim_due already removed (state popped)
  before the run — persisting would recreate an orphan job_state entry
  nothing cleans up.

Adds tests: deep copy-on-read/snapshot isolation (core) and one-shot
non-recreation (wrapper).

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 10:02:24 +00:00
praisonai-triage-agent[bot]andMervinPraison abeec246f5 fix: wire verification hooks into completion gate (fixes #4053)
Make the dormant verification primitive enforceable:
- Wire _verification_gate() into run_autonomous(_async): blocking hook
  failures block a success outcome and feed captured stdout/stderr back as
  feedback; never-passing checks end at max_iterations, not success.
- Fix lossy _run_verification_hooks re-wrap (preserve details/error/duration).
- Add declarative FileCheckHook (exists/non_empty/contains/json_field==equals),
  no shell; CommandVerificationHook now accepts a string command.
- Feed the goal judge executable evidence; a failing blocking hook
  short-circuits to continue without spending a judge call.
- add_verification()/remove_verification() for runtime registration.
- Add 'verification' run-journal event kind and YAML `verification:` config
  parity mapping command:/file: shapes onto the two hook classes.

Opt-in only: agents without verification_hooks are unchanged.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 10:02:24 +00:00
praisonai-triage-agent[bot]andMervinPraison 79d60fcd47 fix: add session handoff continuation prompt and default structured compaction summary (fixes #4056)
Un-stub the documented structured_template compaction feature with a
deterministic DefaultSummaryBuilder that renders SUMMARY_TEMPLATE (falling
back to the plain summary on failure), wired as the default builder in
ContextCompactor when structured_template=True.

Add a deterministic session handoff assembler (build_handoff_prompt) that
turns durable state (recap + persisted GoalState + workflow checkpoint) into a
self-contained continuation prompt with no LLM call, plus a
`praisonai session handoff` CLI command with --json/--copy.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 10:01:15 +00:00
praisonai-triage-agent[bot]andMervin Praison 322ede1ab4 fix: honour HTTP-date Retry-After and drop invalid WhatsApp thread context
Address two P1 review findings on the standalone scheduled sender:

- _HttpSendError now preserves the raw Retry-After header verbatim (via a
  headers dict) instead of pre-parsing to float, so server_retry_after honours
  both integer-seconds and HTTP-date forms. A float(raw) previously discarded
  any HTTP-date delay, letting the sender retry early and exhaust attempts under
  throttling.
- WhatsApp standalone sender no longer maps a generic scheduler thread_id to
  context.message_id. WhatsApp requires a real inbound message id to quote-reply;
  a generic thread id is rejected as an invalid permanent 4xx. This mirrors the
  live adapter, which only sets context from an explicit reply_to.

Adds tests for HTTP-date + integer Retry-After parsing and WhatsApp thread_id
context omission.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:59:06 +00:00
praisonai-triage-agent[bot] 7aa90f0bf6 Merge pull request #4039 from MervinPraison/claude/issue-4038-20260819-0851
fix: discover named agents and commands from .claude/ and .agents/
2026-08-19 09:58:37 +00:00
ugbotueferhire 763a3637b8 fix: register pytest timeout marker in pytest.ini 2026-08-19 10:58:34 +01:00
praisonai-triage-agent[bot]andMervin Praison 24d9ee2d8a fix: make observe() recurrence key survive nested slot values
Slots are typed Dict[str, Any] and SuggestionStore accepts nested
lists/dicts/sets; the previous tuple(sorted(items)) key raised TypeError
on unhashable slot values before recurrence could be recorded. Add a
recursive _freeze() helper producing a deterministic, hashable key.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:55:57 +00:00
praisonai-triage-agent[bot]andMervinPraison b56088942e fix: give scheduled automations cross-run memory (fixes #4049)
Implement the core JobStateStoreProtocol on the existing
ConfigYamlScheduleStore (get_state/set_state/clear_state), persisting a
small, size-bounded per-job scratchpad under a job_state key in
config.yaml and clearing it when a job is removed or a one-shot fires.

Wire the bot ScheduledAgentExecutor to load prior state into a compact
Notepad prompt block, thread it into a stateful monitor gate only when
the gate opts in (signature-detected), and persist GateResult.state_updates
plus any agent-emitted state back after the run. All hasattr/signature-gated
so stores and gates without support behave exactly as today.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 09:54:32 +00:00
praisonai-triage-agent[bot]andMervinPraison 851e4c24e3 fix: durable retry + WhatsApp/Signal senders for standalone scheduled delivery (fixes #4050)
Standalone (out-of-process) scheduled delivery was fire-and-forget with a
platform coverage gap. This adds:

- Bounded in-process retry with exponential backoff (honouring Retry-After)
  around standalone HTTP sends, reusing the shared bots._resilience
  classifiers so only transient 5xx/429/network failures are retried and
  permanent failures (bad token, 4xx) fail fast. An ephemeral cron/serverless
  tick has no persistent process to drain a durable SQLite outbox, so a
  bounded retry is the lightweight durability fit for that model.
- Standalone senders for WhatsApp (Cloud API) and Signal (signal-cli bridge),
  the two live-adapter platforms previously missing from _STANDALONE_SENDERS.

The documented `all` fan-out token is already implemented in botos.py
`_deliver_job_text`, so no change was needed there.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 09:53:10 +00:00
praisonai-triage-agent[bot]andMervinPraison db12658e7b fix: add recurrence generator to SuggestionEngine.observe() (fixes #4048)
The consent-first automation-suggestion surface (store, TTL, dedup, chat
Accept/Dismiss buttons, CLI) already exists but nothing ever generated a
suggestion — propose() was only reachable via manual CLI calls, so the
"noticed you ask for a morning summary every day — automate it?" moment
never fired on its own.

Add a lightweight, deterministic recurrence generator as a new
SuggestionEngine.observe() method in the wrapper: a caller feeds each
completed turn's inferred blueprint+slots, and once the same intent recurs
threshold times within a trailing window the engine auto-calls propose().
Consent-first is preserved (jobs still only materialise on explicit accept),
per-principal isolation and store dedup keep it non-nagging.

Minimal in-repo fix — no new package, dependency, or export; reuses the
existing propose()/store machinery.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 09:49:51 +00:00
praisonai-triage-agent[bot]andMervin Praison 31779462ed fix: stub turn preflight in gateway start SSL/no-preflight tests
The default-on model turn pre-flight (#4042) now runs after the channel
probe in `gateway start`, so two pre-existing start-path tests that never
mocked a model round-trip aborted with exit 1 instead of their expected
exit 0. Mock `_verify_turn_preflight` green in both so each test isolates
exactly the behaviour it guards (SSL-only soft-fail; --no-preflight skip),
without weakening any assertion.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:31:42 +00:00
praisonai-triage-agent[bot]andMervin Praison b9c738c4cb fix: resolve recovery drain_outbox hook on the supervised object itself (#4043)
The gateway passes the durable platform adapter directly to
ChannelSupervisor.run(), so drain_outbox() lives on the bot object itself,
not on bot.adapter. Check the object first, then fall back to bot.adapter,
so built-in channels actually re-drain on recovery. Adds a test for the
production object shape.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:30:11 +00:00
praisonai-triage-agent[bot]andMervin Praison 3ddc585a70 fix: prevent diagnostics bundle overwrite on same-second exports
Second-resolution timestamps caused two exports into the same directory
within one second to resolve to the same path, silently truncating the
first bundle (Greptile P1). Add _unique_bundle_path() to append a -N
suffix when the timestamped name already exists, preserving every export.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:28:13 +00:00
praisonai-triage-agent[bot]andMervin Praison d2b6c44b28 fix: harden gateway turn preflight (toggle, timeout, provider parity)
Address Greptile P1 review feedback on #4045:
- Decouple turn verification from the channel --preflight flag so
  `--no-preflight --verify-turn` still runs the model round-trip.
- Bound the preflight turn with a short run_timeout (default 60s,
  overridable via gateway.preflight.verify_turn_timeout) so a stalled
  provider fails fast instead of inheriting the 5-minute interactive
  default at startup/onboarding.
- Pass per-agent base_url/api_key/api_base through to the synthetic
  Agent so preflight exercises the same provider the live gateway uses.

Adds 3 tests covering timeout default/override and provider parity.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:26:56 +00:00
praisonai-triage-agent[bot] 915998a417 Merge pull request #4036 from MervinPraison/claude/issue-4035-20260819-0828
fix: non-blocking Redis SCAN, race-safe async MySQL init, Mongo regex escape
2026-08-19 09:22:00 +00:00
praisonai-triage-agent[bot]andMervinPraison 4362d76c34 feat: add gateway diagnostics export sanitised support bundle (fixes #4044)
Add a `praisonai gateway diagnostics export` command that writes a single,
pre-sanitised .zip (summary, health, config shape, redacted logs, forensics
snapshot) an operator can safely attach to a bug report. Reuses existing
secret redaction, forensics snapshot, health probe, and daemon log readers;
config is reduced to key/mode shape with no secret values, and all text is
passed through the shared redact_secrets pass. Runs even when the gateway is
unhealthy via local log fallback.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 09:21:59 +00:00
praisonai-triage-agent[bot]andMervinPraison 35c3fe076c fix: re-drain durable outbox when a channel recovers (fixes #4043)
The durable outbox held deliverable replies through a transient channel
outage but nothing re-attempted them on recovery — they sat undelivered
until the next inbound chat() turn or a process restart. The supervisor
now fires a bounded, best-effort adapter.drain_outbox() when a channel
comes back after a recoverable outage, closing the loop opened by the
attempt-and-age policy. Duck-typed and no-op for bots without the hook.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 09:20:45 +00:00
praisonai-triage-agent[bot]andMervinPraison c8b8fbd694 fix: run a real agent turn at gateway startup and onboarding (fixes #4042)
Wire the existing run_turn_test into the default gateway start preflight and
the onboard wizard so a missing/invalid model credential fails at setup time,
not silently on the first user message. Default on via
gateway.preflight.verify_turn; opt out with --no-verify-turn or
PRAISONAI_NO_VERIFY_TURN=1 for constrained/offline environments.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 09:20:14 +00:00
praisonai-triage-agent[bot]andMervin Praison 7c568b7f5a fix: enforce HTTPS on OAuth redirect hops and advertised endpoints
- Re-validate every redirect hop + final URL in metadata fetch (SSRF-safe)
- Enforce HTTPS/loopback guard on discovered authorization/token/registration
  endpoints so an HTTPS metadata doc cannot smuggle a plaintext endpoint
- Defense-in-depth HTTPS guard on the persisted refresh token endpoint
- Add tests for endpoint validation and redirect revalidation

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:01:24 +00:00
praisonai-triage-agent[bot]andMervin Praison 40a152018f fix: nearer dir wins over ancestor in ecosystem discovery precedence
Fixes cross-level precedence bug flagged by greptile/reviewers: the
nearest project directory now wins over more distant ancestors, so an
ancestor .claude/.agents definition no longer silently overrides a
nested .praisonai one. Collect walk-up levels then apply ancestors
first / cwd last under the "later wins" order; .praisonai stays last
within each level.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 09:01:15 +00:00
praisonai-triage-agent[bot]andMervinPraison d98f571a07 fix: discover named agents and commands from .claude/ and .agents/ (fixes #4038)
Extend CustomDefinitionsDiscovery to enumerate the conventional ecosystem
roots .claude/ and .agents/ for agents and commands, mirroring the skills
loader. .praisonai/ wins on name collision and the ancestor walk applies to
all roots. Tools stay .praisonai-only since loading executes user code.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 08:55:06 +00:00
praisonai-triage-agent[bot]andMervinPraison 3e24f3d01c fix: zero-config OAuth for remote MCP servers (fixes #4037)
Add metadata discovery, RFC 7591 dynamic client registration, and an
orchestrating provider that wires the existing PKCE callback helpers and
MCPAuthStorage into a lazy ensure_authenticated() flow. Fully additive and
backward-compatible: servers without auth or with pre-supplied credentials
behave exactly as before.

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 08:55:04 +00:00
praisonai-triage-agent[bot]andMervinPraison 2dc7c3b02c fix: non-blocking Redis SCAN, race-safe async MySQL init, Mongo regex escape (fixes #4035)
- Replace blocking Redis KEYS with cursor SCAN in storage/redis_adapter
  (list_keys, clear) and persistence state redis/upstash keys()
- Add double-checked async lock to AsyncMySQLConversationStore.init()
  to prevent concurrent cold-start pool leaks (mirrors async_postgres)
- Escape regex metacharacters in MongoDBStateStore.keys() to prevent
  ReDoS / unintended matches (matches MongoDBStorageAdapter behaviour)

Co-authored-by: MervinPraison <[email protected]>
2026-08-19 08:31:26 +00:00
praisonai-triage-agent[bot]andMervin Praison 348d81d237 fix: PII redaction hook, planning task restore, and tool-pair reconciliation (fixes #4033)
- redact.py: register PII BEFORE_LLM hook with sequential=True so
  modified_input is actually applied to outgoing messages
- hooks/runner.py: warn when a parallel hook returns modified_input that
  would be silently discarded
- agents.py: restore original self.tasks after planning; keep plan-step
  tasks under _plan_tasks and reset task_id_counter to avoid id collisions
- context/composer.py: iterate _ensure_tool_pairs to a fixed point so
  reinserted tool_calls messages don't leave dangling sibling calls

Co-authored-by: Mervin Praison <[email protected]>
2026-08-19 07:14:50 +00:00
MacOS 19f5f4a15b refactor(agents): keep middleware identity plumbing generic 2026-08-18 19:02:21 +08:00
MacOS 9432cc4b5b feat(agents): add optional AgentFuse tool middleware 2026-08-18 19:02:21 +08:00
praisonai-triage-agent[bot]andMervin Praison 75d8177691 fix: terminate when-routing cleanly, detect guardrails/retry/skills defaults
- process.py: when a task uses only when/then_task/else_task routing and it
  resolves to no target (taken branch has no target) with no next_tasks, end the
  workflow instead of falling into _find_next_not_started_task() (sync + async).
- loader.py: include guardrails/retry/skills in _defaults_has_any_values() so a
  config with only [defaults].guardrails (or retry) is applied instead of being
  silently skipped by apply_config_defaults' fast path.
- factories.py: document ChromaMemoryAdapter's shared short/long-term collection
  so per-tier reset semantics are explicit.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>
2026-08-18 07:26:59 +00:00
praisonai-triage-agent[bot]andMervinPraison 3ac28617c2 fix: wire task when-routing, guard Knowledge/Memory erasure, apply defaults.guardrails (fixes #4019)
- Process now consults Task.get_next_task (when/then_task/else_task) in both
  sync and async workflows before falling back to next_tasks, and no longer
  ends the workflow early when only when-routing is configured.
- Knowledge.reset/delete_all/history now guard with hasattr, logging a no-op
  warning for reset and raising NotImplementedError for unsupported erasure.
- ChromaMemoryAdapter (default) implements reset_short_term/reset_long_term so
  the default memory config actually erases; Memory warns when an adapter lacks
  reset support instead of silently succeeding.
- config defaults: guardrails and retry are now loaded into DefaultsConfig and
  guardrails is applied to Agent via apply_config_defaults; unused/unconsumed
  defaults keys (api_key/context/hooks/templates) removed from VALID_DEFAULTS_KEYS
  so misconfiguration fails loudly, and retry added since agent.py consumes it.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: MervinPraison <[email protected]>
2026-08-18 07:18:05 +00:00
praisonai-triage-agent[bot]andMervin Praison f53cf4c2dc fix: scope memory availability probe to skip FileMemory path (fixes #4016)
Agent.__init__ ran a dependency probe that eagerly imported the heavy
memory.memory module for any truthy memory value. The common FileMemory
paths (memory=True, "file", and file-provider dicts without learn) never
touch that module, so the probe wasted a ~100ms+ import. Scope the probe
to run only for values that resolve to the heavy Memory backend, preserving
the existing ImportError remediation for every heavy branch.

Co-authored-by: Mervin Praison <[email protected]>
2026-08-17 17:18:08 +00:00
471 changed files with 34475 additions and 14008 deletions

No files matched your search

+14
View File
@@ -98,6 +98,20 @@ jobs:
--ignore=tests/unit/cli/test_message_queue.py \
--maxfail=5
- name: Run praisonai-agents subscription-auth smoke tests
env:
PRAISONAI_TEST_TIER: smoke
PRAISONAI_ALLOW_NETWORK: '0'
OPENAI_MODEL_NAME: gpt-4o-mini
OPENAI_API_KEY: 'test-key'
shell: bash
run: |
set -euo pipefail
cd src/praisonai-agents
python -m pytest tests/smoke/test_subscription_auth.py \
tests/unit/auth/test_agent_auth_wiring.py \
-q --tb=line --timeout=60 --maxfail=5
- name: Standalone praisonai-code import smoke
shell: bash
run: |
+42 -13
View File
@@ -130,7 +130,7 @@ Each layer wraps the one inside it. When an agent misbehaves, the layer tells yo
| **3 · Harness** | Can it act, and be checked? | `tools=`, `MCP()`, `guardrails=`, `approval=`, `hooks=`, `sandbox=` |
| **4 · Loop** | When do we stop? | `execution=ExecutionConfig(...)`, `reflection=`, `autonomy=`, doom-loop detection |
| **5 · Graph** | Who runs when, and who checks whom? | `AgentFlow`, `route()`, `parallel()`, `loop()`, `repeat()` |
| **⬡ Managed** | *Where does it actually run?* | `run_on="docker"` — one shared remote sandbox, or a fully hosted loop |
| **⬡ Managed** | *Where does it actually run?* | `tools_run_on="docker"` — one shared sandbox for the tools, or `run_on="anthropic"` for the whole agent |
### Layer 1 · Prompt — *Did I say it clearly?*
@@ -235,7 +235,7 @@ The harness is commoditising; **where** the agent executes is the next multiplie
pip install praisonai
```
The simplest way in is `run_on=` — one whole team or workflow shares **one** sandbox, so a file written by step 1 is there for step 2:
The simplest way in is `tools_run_on=` — one whole team or workflow shares **one** sandbox, so a file written by step 1 is there for step 2. Thinking stays on your machine:
```python
from praisonaiagents import Agent, AgentFlow
@@ -243,7 +243,7 @@ from praisonaiagents import Agent, AgentFlow
writer = Agent(name="Writer", instructions="You write files.")
reader = Agent(name="Reader", instructions="You read files.")
flow = AgentFlow(run_on="docker", steps=[writer, reader]) # or e2b | modal | daytona | flyio
flow = AgentFlow(tools_run_on="docker", steps=[writer, reader]) # or e2b | modal | daytona | flyio
flow.run("Write 'hello' to /workspace/note.txt, then read it back")
```
@@ -251,7 +251,7 @@ Same thing with no Python at all:
```yaml
name: remote-demo
run_on: docker # every step shares one sandbox
tools_run_on: docker # every step shares one sandbox
agents:
writer: {role: Writer, goal: Write files}
reader: {role: Reader, goal: Read files}
@@ -262,22 +262,51 @@ steps:
action: "Read /workspace/note.txt"
```
For a single agent, pick the axis you need — remote **tools** or a remote **loop**:
For a single agent, two words cover it — and they answer different questions:
```python
from praisonai import Agent, LocalAgent, LocalAgentConfig, HostedAgent
from praisonaiagents import Agent
# A. Tools run in a remote sandbox; the agent loop stays local
agent = Agent(name="builder", backend=LocalAgent(
compute="e2b", # or modal | daytona | flyio | docker | tenki
config=LocalAgentConfig(model="gpt-4o-mini", name="RemoteTools"),
))
# A. Only the TOOLS move. Thinking stays on your machine.
agent = Agent(name="builder", instructions="You build things.",
tools_run_on="docker") # docker | e2b | modal | daytona | flyio
# tenki | sandlock | ssh | novita | subprocess
# B. The entire agent loop runs in the cloud (needs ANTHROPIC_API_KEY)
agent = Agent(name="teacher", backend=HostedAgent(provider="anthropic"))
# B. The WHOLE agent moves — model calls, loop and tools
agent = Agent(name="teacher", instructions="You teach.", run_on="anthropic") # hosted
agent = Agent(name="builder", instructions="You build.", run_on="docker") # self-hosted
agent.start("Write a Python script that prints the first 10 primes, then run it")
```
Ask any object where it runs, and it will tell you:
```python
>>> Agent(name="builder", instructions="x", tools_run_on="docker")
Agent(name='builder', thinks_on='this machine', tools_run_on='a Docker container')
>>> agent.where_does_it_run()
Thinking (the AI model calls) happens on this machine.
Tools run on a Docker container.
Your own tools (check_db) still run on this machine -- only shell, file and
code tools move. They read and write this machine's files.
```
Naming a place that cannot do the job is a typo, not a preference, so it says so:
```python
>>> Agent(name="x", instructions="i", run_on="e2b")
TypeError: Agent(run_on='e2b') is not valid: run_on= places the whole agent
-- model calls, loop and tools -- on a managed runtime, and 'e2b' runs
commands but cannot host an agent loop.
To run only the tools there: Agent(tools_run_on='e2b')
```
To run one block of code somewhere else, name the place on that call:
```python
agent.execute_code_sync("print(6 * 7)", run_in="sandlock") # kernel-enforced
```
See what is running and reclaim strays:
```bash
+8 -1
View File
@@ -8,11 +8,18 @@ PraisonAI takes security seriously. We appreciate responsible disclosure from re
|---------|----------|-------------|
| `praisonaiagents` | [PyPI](https://pypi.org/project/praisonaiagents/) | `src/praisonai-agents/` |
| `praisonai` | [PyPI](https://pypi.org/project/praisonai/) | `src/praisonai/` |
| `praisonai-platform` | [PyPI](https://pypi.org/project/praisonai-platform/) | `src/praisonai-platform/` |
| `praisonai` | [npm](https://www.npmjs.com/package/praisonai) | `src/praisonai-ts/` |
Report issues against the **specific package** where the vulnerability exists. A platform-only issue does not necessarily affect the core SDK, and vice versa.
### Packages maintained in their own repositories
`praisonai-platform` now lives at
[MervinPraison/PraisonAI-Platform](https://github.com/MervinPraison/PraisonAI-Platform).
Report platform vulnerabilities through
[that repository's advisories](https://github.com/MervinPraison/PraisonAI-Platform/security/advisories/new),
not here — it is versioned and released independently of the SDK.
## In scope
- Authentication, authorisation, and multi-tenant isolation (e.g. workspace boundaries)
+12 -1
View File
@@ -30,6 +30,7 @@ Methods:
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">aclose</a>() -> None</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">add_mcp_server</a>(name: str, mcp: Any) -> Any</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">add_verification</a>(hook: Any) -> None</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">agent_id</a>() -> str</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">analyze_prompt</a>(prompt: str) -> set</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">auto_memory</a>() -> Optional[bool]</code>
@@ -70,6 +71,7 @@ Methods:
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">redo</a>() -> bool</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">refresh_tools</a>() -> List[Any]</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">remove_mcp_server</a>(name: str) -> bool</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">remove_verification</a>(name: str) -> bool</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">retrieval_config</a>() -> Optional[Any]</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">retrieve</a>(query: str, **kwargs) -> 'ContextPack'</code>
* <code title="class Agent">Agent.<a href="./src/praisonai-agents/praisonaiagents/agent/agent.py">rules_manager</a>() -> Optional[Any]</code>
@@ -238,10 +240,12 @@ from praisonaiagents import Memory, MemoryBackend, MemoryConfig
Methods:
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">acommit_memory_batch</a>(writes: List[tuple]) -> None</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">build_cache_optimized_context</a>(task_descr: str, user_id: Optional[str] = None, additional: str = '', max_items: int = 3, include_cache_boundary: bool = True, include_in_output: Optional[bool] = None) -> Dict[str, str]</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">build_context_for_task</a>(task_descr: str, user_id: Optional[str] = None, additional: str = '', max_items: int = 3, include_in_output: Optional[bool] = None) -> str</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">calculate_quality_metrics</a>(output: str, expected_output: str, llm: Optional[str] = None, custom_prompt: Optional[str] = None) -> Dict[str, float]</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">close_connections</a>()</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">commit_memory_batch</a>(writes: List[tuple]) -> None</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">compute_quality_score</a>(completeness: float, relevance: float, clarity: float, accuracy: float, weights: Dict[str, float] = None) -> float</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">delete_long_term</a>(memory_id: str) -> bool</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">delete_memories</a>(memory_ids: List[str]) -> int</code>
@@ -251,6 +255,7 @@ Methods:
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">finalize_task_output</a>(content: str, agent_name: str, quality_score: float, threshold: float = 0.7, metrics: Dict[str, Any] = None, task_id: str = None)</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">forget</a>(**kwargs) -> int</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">get_all_memories</a>() -> List[Dict[str, Any]]</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">get_context</a>(query: Optional[str] = None, **kwargs) -> str</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">get_learn_context</a>() -> str</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">learn</a>()</code>
* <code title="class Memory">Memory.<a href="./src/praisonai-agents/praisonaiagents/memory/memory.py">recall</a>(query: str, **kwargs) -> List[Dict[str, Any]]</code>
@@ -744,7 +749,7 @@ Methods:
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">get_token_usage_summary</a>() -> Dict[str, Any]</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">has_state</a>(key: str) -> bool</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">increment_state</a>(key: str, amount: float = 1, default: float = 0) -> float</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">launch</a>(path: str = '/agents', port: int = 8000, host: str = '0.0.0.0', debug: bool = False, protocol: str = 'http')</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">launch</a>(path: str = '/agents', port: int = 8000, host: str = '127.0.0.1', debug: bool = False, protocol: str = 'http')</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">restore_session_state</a>(session_id: str) -> bool</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">run</a>(content = None, return_dict = False, **kwargs)</code>
* <code title="class AgentTeam">AgentTeam.<a href="./src/praisonai-agents/praisonaiagents/agents/agents.py">run_all_tasks</a>()</code>
@@ -878,6 +883,7 @@ Methods:
* <code title="cli">praisonai recipe list <a href="./src/praisonai/praisonai/cli/commands/recipe.py">--help</a></code>
* <code title="cli">praisonai recipe optimize <a href="./src/praisonai/praisonai/cli/commands/recipe.py">--help</a></code>
* <code title="cli">praisonai recipe run <a href="./src/praisonai/praisonai/cli/commands/recipe.py">--help</a></code>
* <code title="cli">praisonai recipe runs <a href="./src/praisonai/praisonai/cli/commands/recipe.py">--help</a></code>
* <code title="cli">praisonai recipe serve <a href="./src/praisonai/praisonai/cli/commands/recipe.py">--help</a></code>
* <code title="cli">praisonai replay cleanup <a href="./src/praisonai/praisonai/cli/commands/replay.py">--help</a></code>
* <code title="cli">praisonai replay context <a href="./src/praisonai/praisonai/cli/commands/replay.py">--help</a></code>
@@ -894,7 +900,11 @@ Methods:
* <code title="cli">praisonai schedule describe <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule list <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule logs <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule pause <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule remove <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule restart <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule resume <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule runs <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule schedule-callback <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule start <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule stats <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
@@ -903,6 +913,7 @@ Methods:
* <code title="cli">praisonai schedule suggestion-dismiss <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule suggestion-propose <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule suggestions <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai schedule update <a href="./src/praisonai/praisonai/cli/commands/schedule.py">--help</a></code>
* <code title="cli">praisonai validate check <a href="./src/praisonai/praisonai/cli/commands/validate.py">--help</a></code>
* <code title="cli">praisonai validate schema <a href="./src/praisonai/praisonai/cli/commands/validate.py">--help</a></code>
* <code title="cli">praisonai validate validate <a href="./src/praisonai/praisonai/cli/commands/validate.py">--help</a></code>
+1 -1
View File
@@ -16,7 +16,7 @@ RUN mkdir -p /root/.praison
# Install Python packages (using latest versions)
RUN pip install --no-cache-dir \
praisonai_tools \
"praisonai>=4.6.164" \
"praisonai>=4.7.1" \
"praisonai[chat]" \
"embedchain[github,youtube]"
+1 -1
View File
@@ -20,7 +20,7 @@ RUN mkdir -p /root/.praison
# Install Python packages (using latest versions)
RUN pip install --no-cache-dir \
praisonai_tools \
"praisonai>=4.6.164" \
"praisonai>=4.7.1" \
"praisonai[ui]" \
"praisonai[chat]" \
"praisonai[realtime]" \
+1 -1
View File
@@ -16,7 +16,7 @@ RUN mkdir -p /root/.praison
# Install Python packages (using latest versions)
RUN pip install --no-cache-dir \
praisonai_tools \
"praisonai>=4.6.164" \
"praisonai>=4.7.1" \
"praisonai[ui]" \
"praisonai[crewai]"
@@ -0,0 +1,110 @@
"""
HOL Guard Tool Policy Example - PraisonAI Agents
Demonstrates using HOL Guard (an optional, external runtime security engine)
at the existing `wrap_tool_call` middleware boundary to inspect command-bearing
tool calls *before* they execute.
HOL Guard is installed and versioned separately. Its side-effect-free CLI can
classify a shell command before execution:
hol-guard command test '<command>' --json
Fail-closed policy: the wrapped tool only runs when Guard returns an explicit
allow/benign classification. Review/block/unknown verdicts, malformed output,
timeouts, or CLI failures all short-circuit the call so the tool never runs.
pip install hol-guard # optional, external dependency
"""
import json
import shutil
import subprocess
from praisonaiagents import Agent, tool
from praisonaiagents.hooks import wrap_tool_call, ToolRequest, ToolResponse
COMMAND_BEARING_TOOLS = {"run_shell"}
GUARD_TIMEOUT_SECONDS = 10
@tool
def run_shell(command: str) -> str:
"""Run a shell command and return its output."""
result = subprocess.run(
command, shell=True, capture_output=True, text=True
)
return result.stdout or result.stderr
def _inspect_with_hol_guard(command: str) -> bool:
"""Return True only if HOL Guard explicitly allows the command.
Fails closed (returns False) on any ambiguity: missing CLI, non-zero exit,
timeout, malformed JSON, or a non-allow verdict.
"""
if not shutil.which("hol-guard"):
return False
try:
completed = subprocess.run(
["hol-guard", "command", "test", command, "--json"],
capture_output=True,
text=True,
timeout=GUARD_TIMEOUT_SECONDS,
)
except (subprocess.TimeoutExpired, OSError):
return False
if completed.returncode != 0:
return False
try:
verdict = json.loads(completed.stdout)
except (json.JSONDecodeError, ValueError):
return False
if not isinstance(verdict, dict):
return False
decision = str(verdict.get("decision", "")).lower()
return decision in ("allow", "benign")
@wrap_tool_call
def hol_guard_tool_policy(request: ToolRequest, call_next):
"""Gate command-bearing tools through HOL Guard before execution."""
if request.tool_name not in COMMAND_BEARING_TOOLS:
return call_next(request)
command = request.arguments.get("command", "")
if _inspect_with_hol_guard(command):
return call_next(request)
blocked_message = "Blocked by HOL Guard: command was not explicitly allowed."
# Surface the denial in `result` too: the agent tool executor returns
# `ToolResponse.result` to the model and discards `error`, so a denial with
# only `error` set would reach the model as a null result. Keeping `error`
# populated preserves the signal for after_tool hooks and logging.
return ToolResponse(
tool_name=request.tool_name,
result=blocked_message,
error=blocked_message,
context=request.context,
)
agent = Agent(
name="GuardedShellBot",
instructions="You run shell commands only when they are safe.",
tools=[run_shell],
hooks=[hol_guard_tool_policy],
)
if __name__ == "__main__":
print("HOL Guard tool policy registered on 'run_shell'.")
print("Commands are only executed when Guard returns an explicit allow.")
print("\n✓ HOL Guard example complete")
+2 -3
View File
@@ -14,7 +14,7 @@ Expected Output:
Agent responds with state persisted to Redis
"""
from praisonaiagents import Agent
from praisonaiagents import Agent, MemoryConfig
from praisonaiagents.db import db
print("=== Redis State Store (Agent-First) ===")
@@ -28,8 +28,7 @@ my_db = db(
agent = Agent(
name="Assistant",
instructions="You are a helpful assistant.",
memory=my_db,
session_id="redis-state-example"
memory=MemoryConfig(db=my_db, session_id="redis-state-example"),
)
# Chat - state is automatically managed via Redis
@@ -23,6 +23,7 @@ from praisonaiagents.hooks.verification import (
VerificationResult,
BaseVerificationHook,
CommandVerificationHook,
FileCheckHook,
)
@@ -100,7 +101,19 @@ def main():
print(f" Name: {cmd_hook.name}")
print(f" Command: {cmd_hook.command}")
print(f" Timeout: {cmd_hook.timeout_seconds}s")
# 6. FileCheckHook: declarative, no-shell completion gate
print("\n6. FileCheckHook (declarative completion gate):")
file_hook = FileCheckHook(
name="changelog", path="CHANGELOG.md", non_empty=True
)
file_result = file_hook.run()
print(f" {file_hook.name}: success={file_result.success} — {file_result.output}")
print(
" Gate wiring: when verification_hooks are configured, the autonomous "
"loop cannot finalise with a success outcome while a blocking hook fails."
)
print("\n" + "=" * 60)
print("✓ Verification hooks example completed successfully!")
print("=" * 60)
+1 -1
View File
@@ -24,7 +24,7 @@ Examples for all PraisonAI server types and the unified endpoints CLI.
| `praisonai serve unified --port 8765` | Start unified server |
| `praisonai serve agents --file agents.yaml --port 8000` | Start agents API |
| `praisonai serve recipe --port 8765` | Start recipe server |
| `praisonai serve mcp --transport http --port 8080` | Start MCP server |
| `praisonai mcp serve --transport http-stream --port 8080` | Start MCP server |
| `praisonai serve tools --port 8081` | Start tools MCP server |
| `praisonai serve a2a --port 8082` | Start A2A server |
| `praisonai serve a2u --port 8083` | Start A2U server |
+1 -1
View File
@@ -13,7 +13,7 @@ Usage:
python mcp_http_server.py
# Or use CLI:
praisonai serve mcp --transport http --port 8080
praisonai mcp serve --transport http-stream --port 8080
# Test with curl:
curl http://localhost:8080/mcp/tools
@@ -2,20 +2,25 @@
#
# praisonai examples/yaml/workflows/remote_sandbox_workflow.yaml
#
# `run_on:` is the only line that differs from a normal local workflow. Every
# step shares the same sandbox and /workspace, so the file the writer creates
# is there for the reader. Orchestration still runs on your machine, and the
# sandbox is torn down when the run finishes.
# `tools_run_on:` is the only line that differs from a normal local workflow.
# Every step shares the same sandbox and working directory, so the file the
# writer creates is there for the reader. Thinking and orchestration still run
# on your machine, and the sandbox is torn down when the run finishes.
#
# Providers: docker | e2b | modal | daytona | flyio | tenki | local
# Places: docker | e2b | modal | daytona | flyio | tenki | local
# subprocess | sandlock | ssh | novita
# - docker needs a local Docker daemon and nothing else
# - e2b / modal / daytona / flyio need that provider's API key
# - sandlock is a kernel-enforced local boundary (Linux 6.12+)
# - subprocess is process separation only, NOT a security boundary
#
# `run_on:` is still accepted here as the old spelling for this key.
#
# See what is still running: praisonai managed ps
# Reclaim strays: praisonai managed stop --all
name: remote-sandbox-demo
run_on: docker
tools_run_on: docker
agents:
writer:
@@ -99,13 +99,12 @@ pip index versions praisonaiagents | head -1
pip index versions praisonai | head -1
```
13. Publish **praisonai-platform** (only when the advisory targets platform code):
```bash
cd /Users/praison/praisonai-package/src/praisonai-platform
praisonai publish pypi
# or: uv lock && uv build && uv publish --token $PYPI_TOKEN
```
Platform releases are **independent** of `praisonai` / `praisonaiagents` version numbers. A platform-only fix (e.g. `0.1.8`) does **not** require bumping the main SDK.
13. **praisonai-platform** advisories are handled in a different repository:
[MervinPraison/PraisonAI-Platform](https://github.com/MervinPraison/PraisonAI-Platform).
It is not part of this monorepo and is not published from here. Triage, patch,
release and advisory publication all happen in that repo, on its own semver line.
Nothing in this repository imports it, so a platform advisory never requires an
SDK release.
14. Publish **praisonai (npm / TypeScript)** (only when the advisory targets `src/praisonai-ts`):
```bash
@@ -113,9 +112,8 @@ cd /Users/praison/praisonai-package/src/praisonai-ts
npm version patch && npm publish
```
15. Verify platform / npm when applicable:
15. Verify npm when applicable:
```bash
pip index versions praisonai-platform | head -1
npm view praisonai version
```
@@ -139,7 +137,7 @@ gh api repos/MervinPraison/PraisonAI/security-advisories/<GHSA_ID> \
}
EOF
```
- `<PACKAGE_NAME>`: `praisonaiagents` (core SDK), `praisonai` (Python wrapper), `praisonai-platform` (platform layer), or `praisonai` (npm ecosystem for TypeScript)
- `<PACKAGE_NAME>`: `praisonaiagents` (core SDK), `praisonai` (Python wrapper), or `praisonai` (npm ecosystem for TypeScript)
- `<LAST_VULNERABLE_VERSION>`: version before the fix
- `<FIRST_PATCHED_VERSION>`: the version just published with the fix
- Always include credits for the reporter
@@ -190,8 +188,8 @@ After validating each advisory in source code, assign **one** label:
| Package | Version line | Notes |
|---|---|---|
| `praisonaiagents` + `praisonai` | Aligned patch (e.g. `1.6.62` / `4.6.62`) | Main SDK + wrapper; bump together via `bump_and_release.py` |
| `praisonai-platform` | Independent semver (e.g. `0.1.8`) | Platform-only fixes; users need **not** upgrade the main SDK |
| `praisonai` (npm) | Independent semver (e.g. `1.7.2`) | TypeScript SDK; publish from `src/praisonai-ts` |
| `praisonai-platform` | Independent semver, **separate repository** | Not released from this repo — see [PraisonAI-Platform](https://github.com/MervinPraison/PraisonAI-Platform) |
Always set the advisory `patched_versions` to the **package that actually contains the fix**. Do not imply users must upgrade all packages when only one changed.
@@ -217,9 +215,11 @@ Close (or publish advisory with no code change only if already mitigated) when:
|---|---|---|---|
| praisonaiagents | pip | src/praisonai-agents/praisonaiagents/ | tools/, mcp/, memory/, agent/, sandbox/ |
| praisonai | pip | src/praisonai/praisonai/ | cli/, capabilities/, mcp_server/, sandbox/, recipe/ |
| praisonai-platform | pip | src/praisonai-platform/praisonai_platform/ | api/routes/, services/, auth |
| praisonai | npm | src/praisonai-ts/src/ | agent/, mcp/, tools/, code-mode/ |
`praisonai-platform` is **not audited from this repository** — it lives in
[MervinPraison/PraisonAI-Platform](https://github.com/MervinPraison/PraisonAI-Platform).
## RESOURCES & DOCUMENTATION
- **Official Repository**: https://github.com/MervinPraison/PraisonAI — Source code, issue tracking, and contribution guidelines
@@ -234,7 +234,7 @@ Close (or publish advisory with no code change only if already mitigated) when:
- ALWAYS set patched_versions before publishing advisory
- ALWAYS publish to PyPI/npm BEFORE publishing advisories (so Dependabot can point users to a fix)
- Python SDK: `praisonai publish pypi` from `src/praisonai-agents`, then `bump_and_release.py` for the wrapper
- Platform-only: `praisonai publish pypi` from `src/praisonai-platform` — no SDK bump required
- Platform-only: released from the separate [PraisonAI-Platform](https://github.com/MervinPraison/PraisonAI-Platform) repo, never from here
- npm: `npm publish` from `src/praisonai-ts` when the TypeScript SDK is affected
- ALWAYS request CVE AFTER publishing advisory
- Use generic commit messages: "refactor: harden X" not "fix: SQL injection in Y"
+1 -1
View File
@@ -1074,7 +1074,7 @@ PraisonAI's reliability engineering rests on three pillars — **C**ontext, **H*
> **Evaluator status.** The `ContextEvaluator` / `HarnessEvaluator` / `LoopEvaluator` classes named in the rubric are **planned follow-ups** (PA-CHL-001–004), not yet in the repo. Until they land, the equivalent checks are covered by existing modules:
>
> - **Context** — `context/tokens.py` and `eval/tokens.py` (`estimate_tokens` / `count_tokens`) for budget; `compaction/compactor.py` (`ContextCompactor`) for compaction/retention.
> - **Harness** — `runtime/turn_context.py` for turn-context parity; `runtime/example_harness.py` and `tests/` for harness/artifact checks.
> - **Harness** — `runtime/turn_context.py` for turn-context parity; `examples/runtime/example_harness.py` and `tests/` for harness/artifact checks.
> - **Loop** — `eval/loop.py` (`EvaluationLoop`) and `agent/autonomy.py` for convergence and doom-loop guards.
>
> Keep terminology consistent with the `agent/context_agent.py` (`ContextAgent`) PRP methodology.
+41 -41
View File
@@ -18,76 +18,76 @@ This report compares **Python SDK feature categories** against **Python document
| Category | Features | Docs | Lines |
|----------|----------|------|-------|
| ✅ AGUI | 1 | 2 | 420 |
| ✅ Agent | 22 | 50 | 15813 |
| ✅ Agent | 22 | 53 | 17053 |
| ✅ Agent-to-Agent (A2A) | 1 | 7 | 2996 |
| ✅ Agent-to-User (A2U) | 1 | 3 | 689 |
| ✅ Approval | 1 | 5 | 2537 |
| ✅ Approval | 1 | 5 | 2658 |
| ✅ Audio | 2 | 12 | 1000 |
| ✅ Auto Generation | 5 | 11 | 3274 |
| ✅ Autonomy | 3 | 7 | 2756 |
| ✅ Bots | 7 | 31 | 13366 |
| ✅ Auto Generation | 5 | 11 | 3542 |
| ✅ Autonomy | 3 | 7 | 2790 |
| ✅ Bots | 7 | 31 | 13411 |
| ✅ Budget | 1 | 1 | 287 |
| ✅ CLI | 5 | 121 | 36059 |
| ✅ Chunking | 2 | 2 | 385 |
| ✅ CLI | 5 | 122 | 36734 |
| ✅ Chunking | 2 | 2 | 420 |
| ✅ Citations | 2 | 1 | 202 |
| ✅ Code Execution | 2 | 14 | 4583 |
| ✅ Conditions | 1 | 3 | 1179 |
| ✅ Configuration | 3 | 8 | 3047 |
| ✅ Context Management | 16 | 34 | 13396 |
| ✅ Code Execution | 2 | 14 | 4855 |
| ✅ Conditions | 1 | 3 | 1347 |
| ✅ Configuration | 3 | 8 | 3139 |
| ✅ Context Management | 16 | 36 | 13988 |
| ✅ Deep Research | 8 | 2 | 587 |
| ✅ Display | 6 | 3 | 741 |
| ✅ Embeddings | 6 | 23 | 2049 |
| ✅ Evaluation | 1 | 7 | 2905 |
| ✅ Evaluation | 1 | 7 | 2920 |
| ✅ Events | 1 | 2 | 749 |
| ✅ Execution | 3 | 4 | 1562 |
| ✅ Failover | 2 | 1 | 432 |
| ✅ Execution | 3 | 4 | 1606 |
| ✅ Failover | 2 | 1 | 452 |
| ✅ Files | 2 | 7 | 2275 |
| ✅ Flow | 1 | 3 | 788 |
| ✅ Gateway | 7 | 74 | 27180 |
| ✅ Guardrails | 4 | 4 | 2025 |
| ✅ Handoffs | 11 | 6 | 2563 |
| ✅ Hooks | 2 | 9 | 4434 |
| ✅ Gateway | 7 | 81 | 29955 |
| ✅ Guardrails | 4 | 4 | 2205 |
| ✅ Handoffs | 11 | 6 | 2626 |
| ✅ Hooks | 2 | 9 | 4509 |
| ✅ Image | 1 | 11 | 1255 |
| ✅ Knowledge | 4 | 13 | 4333 |
| ✅ LLM | 3 | 15 | 5192 |
| ✅ Loops | 4 | 5 | 1422 |
| ✅ MCP | 1 | 61 | 13993 |
| ✅ Memory | 6 | 18 | 7070 |
| ✅ Knowledge | 4 | 16 | 4942 |
| ✅ LLM | 3 | 15 | 5372 |
| ✅ Loops | 4 | 5 | 1475 |
| ✅ MCP | 1 | 61 | 14135 |
| ✅ Memory | 6 | 18 | 7187 |
| ✅ OCR | 2 | 1 | 237 |
| ✅ Observability | 2 | 23 | 2814 |
| ✅ Observability | 2 | 23 | 2811 |
| ✅ Optimizer | 1 | 2 | 792 |
| ✅ Output | 3 | 5 | 1242 |
| ✅ Output | 3 | 5 | 1265 |
| ✅ Parallel Execution | 3 | 2 | 497 |
| ✅ Planning | 6 | 6 | 1549 |
| ✅ Plugins | 8 | 4 | 2858 |
| ✅ Prompts | 2 | 9 | 1965 |
| ✅ Providers | 1 | 56 | 7743 |
| ✅ Planning | 6 | 6 | 1605 |
| ✅ Plugins | 8 | 5 | 3120 |
| ✅ Prompts | 2 | 9 | 1971 |
| ✅ Providers | 1 | 56 | 7781 |
| ✅ Query | 1 | 2 | 736 |
| ✅ RAG | 5 | 15 | 3003 |
| ✅ RAG | 5 | 15 | 3118 |
| ✅ Realtime | 2 | 5 | 668 |
| ✅ Reflection | 3 | 3 | 680 |
| ✅ Reflection | 3 | 3 | 730 |
| ✅ Retrieval | 2 | 5 | 1054 |
| ✅ Routing | 1 | 2 | 430 |
| ✅ Sandbox | 5 | 7 | 3202 |
| ✅ Security | 1 | 3 | 3332 |
| ✅ Sessions | 4 | 18 | 7158 |
| ✅ Sandbox | 5 | 7 | 3483 |
| ✅ Security | 1 | 3 | 3482 |
| ✅ Sessions | 4 | 19 | 7631 |
| ✅ Skills | 6 | 15 | 5638 |
| ✅ Tasks | 2 | 6 | 2819 |
| ✅ Telemetry | 1 | 2 | 604 |
| ✅ Tasks | 2 | 6 | 2897 |
| ✅ Telemetry | 1 | 2 | 648 |
| ✅ Templates | 1 | 8 | 1663 |
| ✅ Tools | 12 | 141 | 41246 |
| ✅ Tools | 12 | 144 | 43113 |
| ✅ Tracing | 3 | 2 | 139 |
| ✅ Vector Store | 1 | 12 | 1211 |
| ✅ Vector Store | 1 | 12 | 1215 |
| ✅ Video | 2 | 6 | 649 |
| ✅ Vision | 2 | 1 | 329 |
| ✅ Web | 3 | 9 | 2467 |
| ✅ Workflows | 5 | 16 | 6593 |
| ✅ Web | 3 | 9 | 2487 |
| ✅ Workflows | 5 | 18 | 7406 |
## Documentation Without Features
These docs exist but don't match any implemented feature category:
- ℹ️ Database (42 docs, 6713 lines)
- ℹ️ Database (42 docs, 6959 lines)
- ℹ️ Documents (1 docs, 787 lines)
---
@@ -14,16 +14,16 @@ import logging
import time
from typing import Any, Dict, List, Optional, TYPE_CHECKING
from .turn_context import (
from praisonaiagents.runtime.turn_context import (
PreparedTurnContext,
TurnRuntimeProtocol,
RuntimeMode,
)
from .context_builder import default_context_builder
from ..streaming.events import StreamEvent, StreamEventType
from praisonaiagents.runtime.protocols import TurnRuntimeProtocol
from praisonaiagents.runtime.context_builder import default_context_builder
from praisonaiagents.streaming.events import StreamEvent, StreamEventType
if TYPE_CHECKING:
from ..agent.protocols import AgentProtocol
from praisonaiagents.agent.protocols import AgentProtocol
logger = logging.getLogger(__name__)
@@ -363,4 +363,4 @@ async def demonstrate_harness_integration():
if __name__ == "__main__":
# Run the demonstration
asyncio.run(demonstrate_harness_integration())
asyncio.run(demonstrate_harness_integration())
@@ -92,20 +92,6 @@ from ._lazy import lazy_import, create_lazy_getattr_with_fallback
# Thread-safe cache for lazy-loaded values
_lazy_cache = {}
# Backward compatibility: _get_lazy_cache function for tests
import threading
_lazy_cache_local = threading.local()
def _get_lazy_cache():
"""Get thread-local lazy cache dict. Thread-safe for concurrent access.
Note: This is kept for backward compatibility with tests.
The main lazy loading now uses the centralized _lazy.py utility.
"""
if not hasattr(_lazy_cache_local, 'cache'):
_lazy_cache_local.cache = {}
return _lazy_cache_local.cache
# ============================================================================
# LAZY IMPORT MAPPING
# ============================================================================
@@ -27,7 +27,7 @@ SUPPRESSED_PATTERNS = [
"The `dict` method is deprecated; use `model_dump` instead",
"Pydantic serializer warnings",
"PydanticSerializationUnexpectedValue",
"Expected", # Catches all "Expected N fields but got M" patterns
"fields but got", # litellm/pydantic "Expected N fields but got M"
"Expected `StreamingChoices` but got `Choices`",
"serialized value may not be as expected",
"Mixing V1 models and V2 models",
File diff suppressed because it is too large. Load diff
@@ -136,9 +136,8 @@ class AudioAgent:
- AudioConfig: Full configuration object
verbose: Verbosity level for output
"""
# Handle model= alias
if llm is None and model is not None:
llm = model
from ..utils.model_alias import resolve_model_name
llm = resolve_model_name(llm, model, "AudioAgent")
self.name = name or "AudioAgent"
self.instructions = instructions
@@ -217,6 +217,13 @@ class AutonomyConfig:
f"Invalid autonomy level: {level!r}. "
f"Must be one of {sorted(VALID_AUTONOMY_LEVELS)}"
)
verification_hooks = data.get("verification_hooks")
# Config parity: accept declarative `verification:` entries and map
# `command:`/`file:` shapes onto the two hook classes.
declarative = data.get("verification")
if declarative:
built = _build_verification_hooks(declarative)
verification_hooks = (verification_hooks or []) + built
return cls(
enabled=data.get("enabled", True),
level=level,
@@ -227,7 +234,7 @@ class AutonomyConfig:
observe=data.get("observe", False),
completion_promise=data.get("completion_promise"),
clear_context=data.get("clear_context", False),
verification_hooks=data.get("verification_hooks"),
verification_hooks=verification_hooks,
track_changes=data.get("track_changes"),
sandbox=data.get("sandbox"),
snapshot_dir=data.get("snapshot_dir"),
@@ -237,6 +244,49 @@ class AutonomyConfig:
budget_action=data.get("budget_action", "pause"),
)
def _build_verification_hooks(entries: List[Any]) -> List[Any]:
"""Map declarative ``verification:`` config entries onto hook instances.
Each entry is a dict with either a ``command`` key (→
:class:`CommandVerificationHook`) or a ``file`` key (→
:class:`FileCheckHook`). Unknown shapes are skipped.
Example::
verification:
- {name: tests, command: "python -m pytest -q"}
- {name: changelog, file: CHANGELOG.md, non_empty: true}
"""
from ..hooks.verification import CommandVerificationHook, FileCheckHook
hooks: List[Any] = []
for entry in entries or []:
if not isinstance(entry, dict):
continue
blocking = entry.get("blocking", True)
if "command" in entry:
hooks.append(CommandVerificationHook(
name=entry.get("name", "command"),
command=entry["command"],
cwd=entry.get("cwd"),
timeout=entry.get("timeout", 60.0),
blocking=blocking,
))
elif "file" in entry:
hooks.append(FileCheckHook(
name=entry.get("name", "file"),
path=entry["file"],
exists=entry.get("exists", True),
non_empty=entry.get("non_empty", False),
contains=entry.get("contains"),
json_field=entry.get("json_field"),
equals=entry.get("equals"),
blocking=blocking,
))
return hooks
class AutonomySignal(str, Enum):
"""Signals detected from prompts for autonomy decisions.
@@ -1211,7 +1211,15 @@ Your Goal: {self.goal}"""
return content
def _extract_llm_response_content(self, response) -> Optional[str]:
"""Return assistant message text, a tool-call summary, or str(response) as fallback."""
"""Return assistant message text, or a tool-call summary.
A well-formed response that simply carries no content -- a content filter,
a refusal, or ``finish_reason="length"`` with zero output tokens -- yields
the empty string. ``str(response)`` is reserved for responses this method
could not parse at all, where the repr is a diagnostic rather than an
answer; returning it for a merely empty message put the raw SDK object's
repr in front of the user and into ``chat_history``.
"""
if not response:
return None
try:
@@ -1226,6 +1234,17 @@ Your Goal: {self.goal}"""
if tool_calls:
names = [getattr(tc.function, "name", "?") for tc in tool_calls]
return f"[tool_calls: {', '.join(names)}]"
# Parsed cleanly; the model returned no content. A refusal
# (safety) is carried in ``message.refusal`` independently of
# ``finish_reason`` -- surface it so an empty answer isn't silent.
finish_reason = getattr(choice, "finish_reason", None)
refusal = getattr(msg, "refusal", None)
if refusal or finish_reason not in (None, "stop"):
logging.warning(
f"Agent {self.name}: model returned no content "
f"(finish_reason={finish_reason!r}, refused={bool(refusal)})"
)
return ""
except (AttributeError, IndexError, TypeError) as e:
logging.warning(
f"Failed to extract LLM response content (falling back to str): {e}"
@@ -1725,7 +1744,7 @@ Your Goal: {self.goal}"""
return max_retries
return 2
def _chat_completion(self, messages, temperature=1.0, tools=None, stream=None, reasoning_steps=False, task_name=None, task_description=None, task_id=None, response_format=None, _retry_depth=0, _fallback_index=0):
def _chat_completion(self, messages, temperature=None, tools=None, stream=None, reasoning_steps=False, task_name=None, task_description=None, task_id=None, response_format=None, _retry_depth=0, _fallback_index=0):
start_time = time.time()
# --- Proactive Context Budget Management (default-on) ---
@@ -1849,6 +1868,11 @@ Your Goal: {self.goal}"""
stream = False # Set for the main execution below
else:
raise # Re-raise if it's a different ValueError
except ToolExecutionError:
# A tool failed during the streaming attempt. Re-raise so it is
# not relabelled as an LLM error and so the tool is not executed
# a second time by the non-streaming fallback below.
raise
except Exception as e:
from ..errors import LLMError
# Don't retry if it's an LLMError that has exhausted retries
@@ -1953,6 +1977,8 @@ Your Goal: {self.goal}"""
except BudgetExceededError:
raise
except ToolExecutionError:
raise
except Exception as e:
from ..errors import LLMError
@@ -2119,7 +2145,7 @@ Your Goal: {self.goal}"""
self,
exc: Exception,
messages,
temperature=1.0,
temperature=None,
tools=None,
stream=True,
reasoning_steps=False,
@@ -2309,7 +2335,7 @@ Your Goal: {self.goal}"""
def _execute_unified_chat_completion(
self,
messages,
temperature=1.0,
temperature=None,
tools=None,
stream=None,
reasoning_steps=False,
@@ -2443,7 +2469,7 @@ Your Goal: {self.goal}"""
async def _execute_unified_achat_completion(
self,
messages,
temperature=1.0,
temperature=None,
tools=None,
stream=True, # Async methods keep stream=True default (async adapters support streaming vs sync smart fallback)
reasoning_steps=False,
@@ -2781,7 +2807,11 @@ Your Goal: {self.goal}"""
model_name = self.llm if isinstance(self.llm, str) else "gpt-4o-mini"
model_limit = get_model_limit(model_name)
current_tokens = estimate_messages_tokens(optimized)
# Count the whole request (history + system prompt + tool schemas),
# otherwise a large prompt/tool block can push the call over the
# window while the history alone stays under the threshold.
overhead = self._estimate_request_overhead_tokens(system_prompt, tools)
current_tokens = estimate_messages_tokens(optimized) + overhead
# If over 95% of limit, apply emergency truncation
if current_tokens > model_limit * 0.95:
@@ -2789,20 +2819,67 @@ Your Goal: {self.goal}"""
f"[{self.name}] Context at {current_tokens} tokens (limit: {model_limit}), "
f"applying emergency truncation"
)
target = int(model_limit * 0.8) # Target 80% of limit
# Leave room for the fixed overhead so the full request lands
# near 80% of the window rather than the history alone.
target = max(1, int(model_limit * 0.8) - overhead)
optimized = self.context_manager.emergency_truncate(optimized, target)
result["emergency_truncated"] = True
result["tokens_after"] = estimate_messages_tokens(optimized)
result["tokens_after"] = estimate_messages_tokens(optimized) + overhead
except Exception as e:
logging.debug(f"Hard limit check skipped: {e}")
return optimized, result
except Exception as e:
# Context management should never break the chat flow
logging.warning(f"Context management error (continuing without): {e}")
# Context management should never break the chat flow, but silently
# returning the unchanged history disables the hard-limit truncation
# too and sends an over-budget request. Fall back to emergency
# truncation so we still fit within the model window.
logging.error(f"Context management failed: {e}")
try:
from ..context.budgeter import get_model_limit
from ..context.tokens import estimate_messages_tokens
model_name = self.llm if isinstance(self.llm, str) else "gpt-4o-mini"
model_limit = get_model_limit(model_name)
# Include the system prompt and tool schemas in the budget: the
# request can exceed the window on those alone even when the
# history is under the threshold.
overhead = self._estimate_request_overhead_tokens(system_prompt, tools)
if estimate_messages_tokens(messages) + overhead > model_limit * 0.95:
target = max(1, int(model_limit * 0.8) - overhead)
truncated = self.context_manager.emergency_truncate(messages, target)
return truncated, {"emergency_truncated": True}
except Exception as inner:
logging.debug(f"Emergency truncation fallback skipped: {inner}")
return messages, None
def _estimate_request_overhead_tokens(
self,
system_prompt: str = "",
tools: Optional[list] = None,
) -> int:
"""Estimate non-history request tokens (system prompt + tool schemas).
Emergency-truncation thresholds must budget the full request, not just
the message history, or a large system prompt / tool block can push the
call over the model window undetected.
"""
try:
from ..context.tokens import (
estimate_tokens_heuristic,
estimate_tool_schema_tokens,
)
except Exception:
return 0
overhead = 0
if system_prompt:
overhead += estimate_tokens_heuristic(system_prompt)
if tools:
overhead += estimate_tool_schema_tokens(tools)
return overhead
def _truncate_tool_output(self, tool_name: str, output: str, tool_call_id: str | None = None) -> str:
"""
Truncate tool output according to configured budget.
@@ -2888,7 +2965,7 @@ Your Goal: {self.goal}"""
)
return rendered
def chat(self, prompt: str, temperature: float = 1.0, tools: Optional[List[Any]] = None, output_json: Optional[Any] = None, output_pydantic: Optional[Any] = None, reasoning_steps: bool = False, stream: Optional[bool] = None, task_name: Optional[str] = None, task_description: Optional[str] = None, task_id: Optional[str] = None, config: Optional[Dict[str, Any]] = None, force_retrieval: bool = False, skip_retrieval: bool = False, attachments: Optional[List[str]] = None, tool_choice: Optional[str] = None, seed: Optional[int] = None, cancel_token: Optional[Any] = None) -> Optional[str]:
def chat(self, prompt: str, temperature: Optional[float] = None, tools: Optional[List[Any]] = None, output_json: Optional[Any] = None, output_pydantic: Optional[Any] = None, reasoning_steps: bool = False, stream: Optional[bool] = None, task_name: Optional[str] = None, task_description: Optional[str] = None, task_id: Optional[str] = None, config: Optional[Dict[str, Any]] = None, force_retrieval: bool = False, skip_retrieval: bool = False, attachments: Optional[List[str]] = None, tool_choice: Optional[str] = None, seed: Optional[int] = None, cancel_token: Optional[Any] = None) -> Optional[str]:
"""
Chat with the agent.
@@ -2901,6 +2978,14 @@ Your Goal: {self.goal}"""
'required' forces the LLM to call a tool before responding.
...other args...
"""
# Tools go to their sandbox before the first model call, once per
# agent. Placed on chat/achat/_start_stream rather than run/start
# because AgentTeam and AgentFlow call these three directly -- an
# agent used inside a team would otherwise run its tools locally.
if getattr(self, 'tools_run_on', None) is not None:
from .tools_placement import ensure_tools_placed
ensure_tools_placed(self)
# Slash-command invocation: /skill-name [args] renders the skill
# body before any backend/LLM call.
prompt = self._resolve_skill_invocation(prompt)
@@ -3490,11 +3575,14 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
reflection_output = _get_display_functions()['ReflectionOutput'](**reflection_data)
else:
# Use OpenAI's structured output for OpenAI models
_reflection_kwargs = {}
if temperature is not None:
_reflection_kwargs['temperature'] = temperature
reflection_response = self._openai_client.sync_client.beta.chat.completions.parse(
model=self.reflect_llm if self.reflect_llm else self.llm,
messages=messages,
temperature=temperature,
response_format=_get_display_functions()['ReflectionOutput']
response_format=_get_display_functions()['ReflectionOutput'],
**_reflection_kwargs
)
reflection_output = reflection_response.choices[0].message.parsed
@@ -3559,6 +3647,22 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
logging.error("Reflection parsing failed.", exc_info=True)
messages.append({"role": "assistant", "content": "Self Reflection failed."})
reflection_count += 1
if reflection_count >= self.max_reflect:
# Bound the retry, as the async path does. Without this
# a persistently unparseable reflection (e.g. a
# structured-output refusal, where message.parsed is
# None) loops forever, two LLM calls at a time.
if self.verbose:
_get_display_functions()['display_self_reflection']("Maximum reflection count reached after repeated parse errors, returning current response", console=self.console)
self._append_to_chat_history({"role": "assistant", "content": response_text})
try:
validated_response = self._apply_guardrail_with_retry(response_text, original_prompt, temperature, tools, task_name, task_description, task_id)
self._execute_callback_and_display(original_prompt, validated_response, time.time() - start_time, task_name, task_description, task_id)
return self._trigger_after_agent_hook(original_prompt, validated_response, start_time)
except Exception as guard_e:
logging.error(f"Agent {self.name}: Guardrail validation failed after reflection error: {guard_e}")
self._rollback_chat_history_to(chat_history_length)
return None
continue # Continue even after error to try again
except Exception:
# Catch any exception from the inner try block and re-raise to outer handler
@@ -3578,7 +3682,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
return clean_triple_backticks(output)
async def achat(self, prompt: str, temperature: float = 1.0, tools: Optional[List[Any]] = None, output_json: Optional[Any] = None, output_pydantic: Optional[Any] = None, reasoning_steps: bool = False, stream: Optional[bool] = None, task_name: Optional[str] = None, task_description: Optional[str] = None, task_id: Optional[str] = None, config: Optional[Dict[str, Any]] = None, force_retrieval: bool = False, skip_retrieval: bool = False, attachments: Optional[List[str]] = None, tool_choice: Optional[str] = None, seed: Optional[int] = None, cancel_token: Optional[Any] = None):
async def achat(self, prompt: str, temperature: Optional[float] = None, tools: Optional[List[Any]] = None, output_json: Optional[Any] = None, output_pydantic: Optional[Any] = None, reasoning_steps: bool = False, stream: Optional[bool] = None, task_name: Optional[str] = None, task_description: Optional[str] = None, task_id: Optional[str] = None, config: Optional[Dict[str, Any]] = None, force_retrieval: bool = False, skip_retrieval: bool = False, attachments: Optional[List[str]] = None, tool_choice: Optional[str] = None, seed: Optional[int] = None, cancel_token: Optional[Any] = None):
"""Async version of chat method with self-reflection support.
Args:
@@ -3586,6 +3690,14 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
attachments: Optional list of image/file paths that are ephemeral
(used for THIS turn only, NEVER stored in history).
"""
# Tools go to their sandbox before the first model call, once per
# agent. Placed on chat/achat/_start_stream rather than run/start
# because AgentTeam and AgentFlow call these three directly -- an
# agent used inside a team would otherwise run its tools locally.
if getattr(self, 'tools_run_on', None) is not None:
from .tools_placement import ensure_tools_placed
ensure_tools_placed(self)
# Slash-command invocation: /skill-name [args] renders the skill body.
prompt = self._resolve_skill_invocation(prompt)
@@ -4131,11 +4243,14 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
self._rollback_chat_history_to(chat_history_length)
return None
_areflection_kwargs = {}
if temperature is not None:
_areflection_kwargs['temperature'] = temperature
reflection_response = await self._openai_client.async_client.beta.chat.completions.parse(
model=self.reflect_llm if self.reflect_llm else self.llm,
messages=reflection_messages,
temperature=temperature,
response_format=_get_display_functions()['ReflectionOutput']
response_format=_get_display_functions()['ReflectionOutput'],
**_areflection_kwargs
)
reflection_output = reflection_response.choices[0].message.parsed
@@ -4249,9 +4364,10 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
tool_call_kwargs = dict(
model=self.llm,
messages=messages,
temperature=temperature,
tools=formatted_tools,
)
if temperature is not None:
tool_call_kwargs['temperature'] = temperature
if effective_tool_choice:
tool_call_kwargs['tool_choice'] = effective_tool_choice
response = await self._openai_client.async_client.chat.completions.create(
@@ -4265,11 +4381,14 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
self._execute_callback_and_display(original_prompt, result, time.time() - start_time, task_name, task_description, task_id)
return await self._atrigger_after_agent_hook(original_prompt, result, start_time)
elif output_json or output_pydantic:
_json_kwargs = {}
if temperature is not None:
_json_kwargs['temperature'] = temperature
response = await self._openai_client.async_client.chat.completions.create(
model=self.llm,
messages=messages,
temperature=temperature,
response_format={"type": "json_object"}
response_format={"type": "json_object"},
**_json_kwargs
)
response_text = response.choices[0].message.content
if get_logger().getEffectiveLevel() == logging.DEBUG:
@@ -4279,10 +4398,13 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
self._execute_callback_and_display(original_prompt, response_text, time.time() - start_time, task_name, task_description, task_id)
return await self._atrigger_after_agent_hook(original_prompt, response_text, start_time)
else:
_plain_kwargs = {}
if temperature is not None:
_plain_kwargs['temperature'] = temperature
response = await self._openai_client.async_client.chat.completions.create(
model=self.llm,
messages=messages,
temperature=temperature
**_plain_kwargs
)
response_text = response.choices[0].message.content
@@ -4319,11 +4441,14 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
logging.debug(f"Agent.achat completed in {total_time:.2f} seconds")
return await self._atrigger_after_agent_hook(original_prompt, response_text, start_time)
_areflection_kwargs = {}
if temperature is not None:
_areflection_kwargs['temperature'] = temperature
reflection_response = await self._openai_client.async_client.beta.chat.completions.parse(
model=self.reflect_llm if self.reflect_llm else self.llm,
messages=reflection_messages,
temperature=temperature,
response_format=_get_display_functions()['ReflectionOutput']
response_format=_get_display_functions()['ReflectionOutput'],
**_areflection_kwargs
)
reflection_output = reflection_response.choices[0].message.parsed
@@ -4349,10 +4474,13 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
{"role": "user", "content": "Now regenerate your response using the reflection you made"}
]
_regen_kwargs = {}
if temperature is not None:
_regen_kwargs['temperature'] = temperature
new_response = await self._openai_client.async_client.chat.completions.create(
model=self.llm,
messages=regenerate_messages,
temperature=temperature
**_regen_kwargs
)
response_text = new_response.choices[0].message.content
reflection_count += 1
@@ -4439,7 +4567,12 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
# after-context aggregation) are fired once, guarded, inside
# execute_tool_async — no inline duplicate dispatch here.
# Pass the tools list to honor task-scoped tools
result = await self.execute_tool_async(function_name, arguments, tools_override=tools)
result = await self.execute_tool_async(
function_name,
arguments,
tool_call_id=getattr(tool_call, "id", None),
tools_override=tools,
)
results.append(result)
except Exception as e:
@@ -4540,6 +4673,14 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
def _start_stream(self, prompt: str, **kwargs) -> Generator[str, None, None]:
"""Own the durable context for the complete streaming generator."""
# Tools go to their sandbox before the first model call, once per
# agent. Placed on chat/achat/_start_stream rather than run/start
# because AgentTeam and AgentFlow call these three directly -- an
# agent used inside a team would otherwise run its tools locally.
if getattr(self, 'tools_run_on', None) is not None:
from .tools_placement import ensure_tools_placed
ensure_tools_placed(self)
durable_context = None
durable_token = None
try:
@@ -5227,7 +5368,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
agent_id=getattr(self, 'name', None),
)
def _chat_completion_with_retry(self, messages, temperature=1.0, tools=None, stream=None, reasoning_steps=False, task_name=None, task_description=None, task_id=None, response_format=None, stream_callback=None, emit_events=True):
def _chat_completion_with_retry(self, messages, temperature=None, tools=None, stream=None, reasoning_steps=False, task_name=None, task_description=None, task_id=None, response_format=None, stream_callback=None, emit_events=True):
"""
Wrapper for _execute_unified_chat_completion that adds jittered exponential backoff retry logic.
@@ -5314,7 +5455,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
# This should never be reached, but just in case
raise RuntimeError("Retry loop completed without returning or raising an exception")
async def _achat_completion_with_retry(self, messages, temperature=1.0, tools=None, stream=None, reasoning_steps=False, task_name=None, task_description=None, task_id=None, response_format=None, stream_callback=None, emit_events=True):
async def _achat_completion_with_retry(self, messages, temperature=None, tools=None, stream=None, reasoning_steps=False, task_name=None, task_description=None, task_id=None, response_format=None, stream_callback=None, emit_events=True):
"""
Async wrapper for _execute_unified_achat_completion that adds jittered exponential backoff retry logic.
@@ -59,7 +59,8 @@ class CodeAgent:
def __init__(
self,
name: str = "CodeAgent",
llm: Optional[str] = None,
llm: Optional[str] = None, # Deprecated alias for model=
model: Optional[str] = None,
code: Optional[Union[bool, Dict, CodeConfig]] = None,
instructions: Optional[str] = None,
verbose: bool = True,
@@ -69,14 +70,16 @@ class CodeAgent:
Args:
name: Agent name
llm: LLM model (default: gpt-4o-mini)
llm: Deprecated alias for model=. Passing both raises TypeError.
model: Model to use (default: gpt-4o-mini)
code: Code configuration (bool, dict, or CodeConfig)
instructions: System instructions
verbose: Enable verbose output
**kwargs: Additional arguments
"""
from ..utils.model_alias import resolve_model_name
self.name = name
self.llm = llm or "gpt-4o-mini"
self.llm = resolve_model_name(llm, model, "CodeAgent") or "gpt-4o-mini"
self.instructions = instructions
self.verbose = verbose
@@ -17,6 +17,7 @@ from ..runtime.journal import (
KIND_MODEL_DECISION,
KIND_TOOL_CALL,
KIND_TOOL_RESULT,
KIND_VERIFICATION,
RunJournal,
)
@@ -58,6 +59,85 @@ def _accepts_idempotency_key(execute_tool_fn: Callable) -> bool:
)
def _normalize_restart_safe(value: Any) -> Optional[bool]:
"""Accept only genuine booleans as a restart-safety declaration.
``None`` means undeclared. Any other type (e.g. the string ``"False"``) is a
malformed declaration and is treated as unsafe so we fail closed rather than
coercing a truthy value into an unintended replay.
"""
if value is None:
return None
if isinstance(value, bool):
return value
return False
def _canonical_tool_name(name: Any) -> str:
"""Normalise a tool name for tolerant comparison across repair variants.
``execute_tool`` may repair case/separator variants (e.g. ``Send-Email`` →
``send_email``); the declaration lookup mirrors that so an explicit
``restart_safe`` declaration is not missed for a repaired name.
"""
return "".join(ch for ch in str(name).lower() if ch.isalnum())
def _declared_restart_safe(
function_name: str, executor: Optional[Callable]
) -> Optional[bool]:
"""Return an explicit ``restart_safe`` declaration for ``function_name``.
Resolves the tool object first from the executor's owning agent (its live
``tools``), then from the global tool registry, and reads its
``restart_safe`` attribute. Returns ``None`` when the tool is undeclared or
cannot be resolved.
"""
if not function_name:
return False
target = _canonical_tool_name(function_name)
agent = getattr(executor, "__self__", None)
tools = getattr(agent, "tools", None)
if isinstance(tools, (list, tuple)):
for tool in tools:
name = getattr(tool, "name", None) or getattr(tool, "__name__", None)
if (
name is not None
and _canonical_tool_name(name) == target
and getattr(tool, "restart_safe", None) is not None
):
return _normalize_restart_safe(tool.restart_safe)
try:
from ..tools import get_registry as _get_tool_registry
tool = _get_tool_registry().get(function_name)
except Exception: # pragma: no cover - registry lookup is best-effort
tool = None
declared = getattr(tool, "restart_safe", None) if tool is not None else None
return _normalize_restart_safe(declared)
def _is_restart_safe(function_name: str, executor: Optional[Callable] = None) -> bool:
"""Resolve whether a tool is safe to re-run for an in-flight durable resume.
An explicit ``restart_safe`` declaration on the tool contract wins. When the
tool is undeclared (or cannot be resolved), fall back to the read-only name
heuristic and, ultimately, fail closed — an effectful/unknown tool is *not*
replayed so a missing declaration never causes a duplicated side effect.
"""
if not function_name:
return False
declared = _declared_restart_safe(function_name, executor)
if declared is not None:
return declared
try:
from .tool_execution import ToolExecutionMixin
return bool(ToolExecutionMixin._is_read_only_tool(function_name))
except Exception: # pragma: no cover - heuristic import is best-effort
return False
class DurableRunContext:
"""Per-turn journal state; safe for parallel tool-call wrappers."""
@@ -80,6 +160,10 @@ class DurableRunContext:
self._results_by_tool_call_id: Dict[str, Any] = {}
self._pending_by_call_id: Dict[str, Tuple[int, str, Dict[str, Any], str]] = {}
self._pending_by_fingerprint: Dict[str, Tuple[int, str, Dict[str, Any], str]] = {}
# Names of in-flight tool calls (journalled tool_call with no tool_result
# at the crash). Used only when replaying to gate replay by restart-safety.
self._inflight_names_by_call_id: Dict[str, str] = {}
self._inflight_names_by_fingerprint: Dict[str, str] = {}
self._recorded_iterations = set()
for event in events:
if event.kind == KIND_TOOL_RESULT:
@@ -106,8 +190,11 @@ class DurableRunContext:
or f"{self.run_id}:{event.seq}:{name}"
)
pending = (event.seq, call_id, args, key)
fingerprint = self._fingerprint(name, args)
self._pending_by_call_id[call_id] = pending
self._pending_by_fingerprint[self._fingerprint(name, args)] = pending
self._pending_by_fingerprint[fingerprint] = pending
self._inflight_names_by_call_id[call_id] = name
self._inflight_names_by_fingerprint[fingerprint] = name
self._resume_completed_steps = len(self._recorded_iterations)
@@ -119,6 +206,44 @@ class DurableRunContext:
def _fingerprint(function_name: str, arguments: Dict[str, Any]) -> str:
return f"{function_name}:{json.dumps(_json_safe(arguments), sort_keys=True)}"
def _is_inflight_call(
self,
function_name: str,
arguments: Dict[str, Any],
tool_call_id: Optional[str],
) -> bool:
"""Whether this call was in-flight (journalled, no result) at the crash.
Only meaningful while replaying: such calls have a recorded ``tool_call``
but no ``tool_result``, so re-driving the loop would re-execute their
side effect. Completed calls (already have a result) are replayed
upstream and never reach this check.
"""
if not self.replaying:
return False
call_id = str(tool_call_id) if tool_call_id is not None else None
if call_id and call_id in self._inflight_names_by_call_id:
return True
return self._fingerprint(function_name, arguments) in (
self._inflight_names_by_fingerprint
)
@staticmethod
def _not_safely_resumable_result(function_name: str) -> Dict[str, Any]:
"""Typed, operator-visible outcome for a gated in-flight effectful tool."""
return {
"error": (
f"Tool '{function_name}' was in-flight when the durable run "
"crashed and is not declared restart_safe; its outcome could not "
"be confirmed. It was not re-executed on resume to avoid a "
"duplicate side effect. Reconcile the external action manually "
"or mark the tool @tool(restart_safe=True) if it is idempotent."
),
"error_type": "NotSafelyResumable",
"not_safely_resumable": True,
"restart_safe": False,
}
def restore_messages(self, messages: List[Dict[str, Any]]) -> List[Dict[str, Any]]:
"""Append completed decision/result pairs once, before the next model call."""
if not self.replaying or self._restored:
@@ -277,6 +402,26 @@ class DurableRunContext:
)
self.finalize("failed")
def record_verification(self, payloads: List[Dict[str, Any]]) -> None:
"""Append verification-gate results as durable ``verification`` events.
Each payload gets its own fresh ``seq`` so the events append cleanly
alongside the tool-call cursor without colliding on ``(run_id, seq,
kind)``. Best-effort: journalling never raises into the gate.
"""
if self._closed:
return
with self._lock:
for payload in payloads:
seq = self._next_seq
self._next_seq += 1
try:
self.journal.append(
JournalEvent(self.run_id, seq, KIND_VERIFICATION, payload)
)
except Exception: # pragma: no cover - journalling is best-effort
pass
def wrap_sync(self, execute_tool_fn: Optional[Callable]) -> Optional[Callable]:
if execute_tool_fn is None:
return None
@@ -286,9 +431,19 @@ class DurableRunContext:
call_id = str(tool_call_id) if tool_call_id is not None else None
if call_id and call_id in self._results_by_tool_call_id:
return self._results_by_tool_call_id[call_id]
gate_inflight = self._is_inflight_call(
function_name, arguments, tool_call_id
) and not _is_restart_safe(function_name, execute_tool_fn)
seq, call_id, idempotency_key = self._allocate_step(
function_name, arguments, tool_call_id
)
if gate_inflight:
return self._record_result(
seq,
call_id,
self._not_safely_resumable_result(function_name),
iteration_index,
)
token = _active_idempotency_key.set(idempotency_key)
try:
call_kwargs = dict(kwargs)
@@ -319,9 +474,20 @@ class DurableRunContext:
call_id = str(tool_call_id) if tool_call_id is not None else None
if call_id and call_id in self._results_by_tool_call_id:
return self._results_by_tool_call_id[call_id]
gate_inflight = self._is_inflight_call(
function_name, arguments, tool_call_id
) and not _is_restart_safe(function_name, execute_tool_fn)
seq, call_id, idempotency_key = await asyncio.to_thread(
self._allocate_step, function_name, arguments, tool_call_id
)
if gate_inflight:
return await asyncio.to_thread(
self._record_result,
seq,
call_id,
self._not_safely_resumable_result(function_name),
iteration_index,
)
token = _active_idempotency_key.set(idempotency_key)
try:
call_kwargs = dict(kwargs)
@@ -110,8 +110,8 @@ class EmbeddingAgent:
- EmbeddingConfig: Full configuration object
verbose: Verbosity level for output
"""
if llm is None and model is not None:
llm = model
from ..utils.model_alias import resolve_model_name
llm = resolve_model_name(llm, model, "EmbeddingAgent")
self.name = name or "EmbeddingAgent"
self.instructions = instructions
@@ -43,24 +43,67 @@ HERE = "this machine"
# a place that never executes.
_ALIASES = {"native": "sandlock", "local": "subprocess"}
# ...but only for the SANDBOX registry. "local" resolves to two different
# backends depending on which parameter carried it:
# run_in="local" -> SandboxManager collapses it to subprocess:
# scrubbed environment, blocked commands and paths
# tools_run_on="local" -> the wrapper's LocalCompute: a plain shell in the
# current directory, full environment inherited,
# no security policy at all
# Describing the second in the first's words overstates it, which is the exact
# failure this module exists to prevent. One word, two backends -- so the
# phrase has to depend on where the word came from.
_COMPUTE_ONLY_WORDS = {"local": "a plain shell on this machine (no policy applied)"}
# Tiers that separate a process but do NOT contain it. Verified: under the
# subprocess backend, outbound network still works and ~/.ssh is readable even
# though SecurityPolicy declares them blocked.
_NOT_A_BOUNDARY = {"subprocess", "local", "native"}
# `native` is deliberately absent: it aliases sandlock, which applies Landlock,
# seccomp, a scrubbed environment and deny-all networking. Listing it here made
# tools_run_on="native" and tools_run_on="sandlock" -- the same backend --
# disagree about whether they contain anything.
_NOT_A_BOUNDARY = {"subprocess", "local"}
def say_place(name: Any) -> str:
"""Turn a provider name into a phrase a non-developer can read."""
def say_place(name: Any, *, via: str = "sandbox") -> str:
"""Turn a place name into a phrase a non-developer can read.
``via`` says which registry resolved the name -- ``"compute"`` for
``tools_run_on=``, ``"sandbox"`` for ``run_in=``. It only matters for names
that mean different backends in each (see ``_COMPUTE_ONLY_WORDS``).
"""
if name is None:
return HERE
if name is True:
return _PLACE_WORDS["subprocess"]
if not isinstance(name, str):
# A configured provider instance: use its own declared name if it has one.
# A configured provider instance: use its own declared name if it has
# one. Normalise BEFORE the compute-only check, or a backend holding a
# LocalCompute object (provider_name="local") skips the branch and gets
# described in the subprocess backend's stronger words -- the exact
# overstatement this module exists to prevent.
name = getattr(name, "provider_name", None) or type(name).__name__
if via == "compute" and name.lower() in _COMPUTE_ONLY_WORDS:
return _COMPUTE_ONLY_WORDS[name.lower()]
key = str(name).lower()
key = _ALIASES.get(key, key)
return _PLACE_WORDS.get(key, str(name))
known = _PLACE_WORDS.get(key)
if known:
return known
# A place contributed by another package can name itself; the bare name is
# the last resort rather than the only option, because the phrase table is
# a literal that cannot know about packages installed later.
try:
from ..managed._compute_bridge import contributed_display_name
declared = contributed_display_name(key)
if declared:
return declared
except Exception:
pass
return str(name)
def _backend_places(backend: Any) -> Optional[Dict[str, str]]:
@@ -68,6 +111,21 @@ def _backend_places(backend: Any) -> Optional[Dict[str, str]]:
if backend is None:
return None
# Ask the backend what it is, rather than guessing from its class name.
# Name-matching missed any backend that did not happen to contain "Hosted"
# or "Anthropic" -- a self-hosted docker backend reported that it was
# thinking on this machine while the whole loop ran in a container.
declared = getattr(backend, "provider_name", None)
if isinstance(declared, str):
try:
from .placement import managed_runtimes
if declared.lower() in managed_runtimes():
where = say_place(declared)
return {"thinks_on": where, "tools_run_on": where}
except Exception:
pass
cls = type(backend).__name__
# Hosted runtimes move the entire turn off this machine.
if "Hosted" in cls or "Anthropic" in cls:
@@ -75,10 +133,13 @@ def _backend_places(backend: Any) -> Optional[Dict[str, str]]:
where = say_place(provider)
return {"thinks_on": where, "tools_run_on": where}
# Local/sandboxed agents keep the loop here and may push tools out.
# Local/sandboxed agents keep the loop here and may push tools out. A
# backend's compute object is a COMPUTE-registry provider, so it is read
# with the compute vocabulary: a LocalCompute here is the unrestricted
# shell, not the subprocess backend "local" collapses to under run_in=.
compute = getattr(backend, "_compute", None) or getattr(backend, "compute", None)
if compute is not None:
return {"thinks_on": HERE, "tools_run_on": say_place(compute)}
return {"thinks_on": HERE, "tools_run_on": say_place(compute, via="compute")}
return {"thinks_on": HERE, "tools_run_on": HERE}
@@ -94,11 +155,21 @@ def describe(obj: Any, *, shared: bool = False) -> Dict[str, str]:
if from_backend:
places.update(from_backend)
run_on = getattr(obj, "run_on", None)
if run_on is not None:
where = say_place(run_on)
where_tools = getattr(obj, "tools_run_on", None)
if where_tools is not None:
where = say_place(where_tools, via="compute")
places["tools_run_on"] = f"{where} (shared)" if shared else where
# run_on= puts the WHOLE agent on a managed runtime, so it moves the
# thinking as well. _backend_places() already reports that (run_on= is
# turned into a backend at construction); this only covers an object
# that carries the name without a built backend.
whole = getattr(obj, "run_on", None)
if whole is not None and not from_backend:
everywhere = say_place(whole)
places["thinks_on"] = everywhere
places["tools_run_on"] = everywhere
sandbox_config = getattr(obj, "sandbox_config", None)
if sandbox_config is not None:
places["code_runs_on"] = say_place(
@@ -109,6 +180,42 @@ def describe(obj: Any, *, shared: bool = False) -> Dict[str, str]:
return places
def _tools_staying_here(obj: Any) -> list:
"""Names of the object's own tools, which do NOT move to the sandbox.
Only four tool names are bridged (``execute_command``, ``read_file``,
``write_file``, ``list_files``); everything else the user passed keeps
running in this process, against this filesystem. The capability prompt
tells the model the sandbox is where things happen, so anything staying
behind has to be said out loud.
Reads the pre-attach tool list when a sandbox is already attached: by then
``agent.tools`` has been rewritten and the originals live in the sandbox's
restore record.
"""
try:
from ..managed.shared_compute import BRIDGED_TOOL_NAMES
except Exception:
BRIDGED_TOOL_NAMES = ("execute_command", "read_file", "write_file", "list_files")
tools = None
shared = getattr(obj, "_tools_sandbox", None)
if shared is not None:
for patched, original_tools, _ in getattr(shared, "_patched", []):
if patched is obj:
tools = original_tools
break
if tools is None:
tools = getattr(obj, "tools", None) or []
names = []
for tool in tools:
name = getattr(tool, "__name__", None) or getattr(tool, "name", None)
if isinstance(name, str) and name not in BRIDGED_TOOL_NAMES:
names.append(name)
return names
def repr_fields(obj: Any, *, shared: bool = False) -> str:
"""Render the places as ``key='value'`` pairs for a ``__repr__``."""
return ", ".join(f"{k}={v!r}" for k, v in describe(obj, shared=shared).items())
@@ -126,12 +233,20 @@ def explain(obj: Any, *, shared: bool = False) -> str:
f"Tools run on {places['tools_run_on']}.",
]
if shared and getattr(obj, "run_on", None) is not None:
if shared and getattr(obj, "tools_run_on", None) is not None:
lines.append(
"Every step shares that same sandbox, so a file written by one step "
"is visible to the next."
)
staying = _tools_staying_here(obj)
if staying and places["tools_run_on"] != places["thinks_on"]:
listed = ", ".join(staying[:6]) + ("..." if len(staying) > 6 else "")
lines.append(
f"Your own tools ({listed}) still run on {HERE} -- only shell, file "
f"and code tools move. They read and write this machine's files."
)
if "code_runs_on" in places:
lines.append(
f"Code you run yourself with execute_code() runs on {places['code_runs_on']}."
@@ -139,6 +254,7 @@ def explain(obj: Any, *, shared: bool = False) -> str:
# Say plainly when the chosen tier is not a security boundary.
raw = [
getattr(obj, "tools_run_on", None),
getattr(obj, "run_on", None),
getattr(getattr(obj, "sandbox_config", None), "sandbox_type", None),
]
@@ -147,7 +263,8 @@ def explain(obj: Any, *, shared: bool = False) -> str:
):
lines.append(
"Note: a separate process is not a security boundary -- it can still "
"reach the network and read your files. Use docker or a cloud "
"reach the network and read your files, and its blocked-command "
"list can be worked around by ordinary shell syntax. Use docker or a cloud "
"provider for untrusted code."
)
@@ -1519,6 +1519,7 @@ Write the complete compiled report:"""
run_id=getattr(self, '_current_run_id', 'unknown'),
session_id=getattr(self, '_session_id', None) or 'default',
tool_name=function_name,
metadata={"tool_call_id": tool_call_id},
),
)
@@ -1564,18 +1565,32 @@ Write the complete compiled report:"""
result.get("approval_error") or
result.get("circuit_open") or
result.get("loop_blocked") or
result.get("retryable") is False):
result.get("_praison_retryable") is False):
result.pop("_praison_retryable", None)
return result
# Determine error type for retry policy
error_type = self._classify_error_type(result, last_exception)
# Check if we should retry
if not retry_policy.should_retry(error_type, attempt):
# Check if we should retry. A tool that *raised* is flattened
# into an error dict before it can be classified, so it always
# arrives here as "unknown" — which no default retry_on
# contains. The sync path escalates exactly those error types
# to its own retry loop (tool_execution.py:853-866); honouring
# the impl's explicit `retryable` flag is how the async path
# reaches the same decision instead of never retrying at all.
# `_praison_retryable` is a private control-plane key (see
# _execute_tool_async_impl): a tool's own result may legitimately
# contain "retryable" (common for HTTP-API wrappers) and must
# never steer our retry loop.
if (not retry_policy.should_retry(error_type, attempt)
and result.get("_praison_retryable") is not True):
result.pop("_praison_retryable", None)
return result
# Don't retry on last attempt
if attempt == retry_policy.max_attempts - 1:
result.pop("_praison_retryable", None)
return result
# Emit retry hook event
@@ -1774,7 +1789,7 @@ Write the complete compiled report:"""
result = {
"error": f"Tool timed out after {tool_timeout}s",
"timeout": True,
"retryable": False,
"_praison_retryable": False,
}
else:
result = await _invoke()
@@ -1814,7 +1829,26 @@ Write the complete compiled report:"""
# sync path. The next pre-execution check will then BLOCK/HALT.
if loop_guard is not None:
loop_guard.record(function_name, arguments, False, result=None)
return {"error": f"Error executing {function_name}: {str(e)}"}
# Carry the retry verdict with the flattened exception. Without it
# the caller only sees an opaque error string, classifies it as
# "unknown" (never in RetryPolicy.retry_on) and gives up — while
# the sync path, which still has the exception object, retries.
# Mirror the sync path exactly: a ToolExecutionError already
# carries an explicit is_retryable verdict (e.g. a terminal
# non-retryable failure) and must be honoured verbatim; for any
# other exception apply the same terminal rule — programming
# errors are terminal, everything else may be retried.
if isinstance(e, ToolExecutionError):
retryable = e.is_retryable
else:
retryable = not isinstance(e, (ValueError, TypeError, AttributeError))
# Private control-plane key: a tool's own result may legitimately
# contain "retryable" (common for HTTP-API wrappers) and must not
# collide with the framework's verdict nor leak to the model.
return {
"error": f"Error executing {function_name}: {str(e)}",
"_praison_retryable": retryable,
}
except ToolExecutionError:
# A loop-guard HALT must propagate to stop the run, mirroring the sync
@@ -1824,18 +1858,26 @@ Write the complete compiled report:"""
logging.error(f"Error in execute_tool_async: {str(e)}", exc_info=True)
return {"error": f"Error in execute_tool_async: {str(e)}"}
def launch(self, path: str = '/', port: int = 8000, host: str = '0.0.0.0', debug: bool = False, protocol: str = "http"):
def launch(self, path: str = '/', port: int = 8000, host: str = '127.0.0.1', debug: bool = False, protocol: str = "http"):
"""
Launch the agent as an HTTP API endpoint or MCP server.
This method now delegates to protocol-based launchers to follow
the protocol-driven architecture. Heavy implementations (FastAPI/uvicorn)
are only imported when needed through lazy loading.
Request authorisation matches ``PraisonAIAgents.launch``: when
``PRAISONAI_LAUNCH_AUTH_TOKEN`` is set, every HTTP route requires that
bearer token (401 otherwise). When it is unset and ``host`` is
non-loopback, a one-time token is generated and printed rather than
serving an unauthenticated endpoint on all interfaces.
Args:
path: API endpoint path (default: '/') for HTTP, or base path for MCP.
port: Server port (default: 8000)
host: Server host (default: '0.0.0.0')
host: Server host (default: '127.0.0.1'; changed from '0.0.0.0' to
avoid binding all interfaces by default — pass '0.0.0.0'
explicitly to expose externally).
debug: Enable debug mode (default: False)
protocol: "http" to launch as FastAPI, "mcp" to launch as MCP server.
@@ -1859,6 +1901,8 @@ Write the complete compiled report:"""
"""
global _server_started, _registered_agents, _shared_apps, _server_lock
from .launch_security import authorise_launch_request, resolve_launch_host
# Try to import FastAPI dependencies - lazy loading
try:
import uvicorn
@@ -1883,7 +1927,15 @@ Write the complete compiled report:"""
print("\nOr install all API dependencies with:")
print("pip install 'praisonaiagents[api]'")
return None
# Fail-closed bind guard: refuse to serve keyless on a non-loopback host
# (auto-generates and prints a one-time token instead). Matches the
# serve/jobs precedent and keeps this path in lock-step with
# PraisonAIAgents.launch. Applied only after the dependency guard above
# so a launch that bails out (missing deps) cannot mutate the
# process-wide launch token and retroactively 401 a running endpoint.
host = resolve_launch_host(host)
should_start = False
with _server_lock:
# Initialize port-specific collections if needed (once per port)
@@ -1936,6 +1988,8 @@ Write the complete compiled report:"""
# Define the endpoint handler
@_shared_apps[port].post(path)
async def handle_agent_query(request: Request, query_data: Optional[AgentQuery] = None):
if not authorise_launch_request(request):
raise HTTPException(status_code=401, detail="Unauthorized")
# Handle both direct JSON with query field and form data
if query_data is None:
try:
@@ -14,6 +14,7 @@ from typing import Optional, Any, Callable, Dict, List, Union, TYPE_CHECKING, Li
from dataclasses import dataclass, field
from enum import Enum
import inspect
from contextlib import contextmanager
from praisonaiagents._logging import get_logger
import asyncio
import contextvars
@@ -469,12 +470,46 @@ class Handoff:
return value
return 'gpt-4o-mini'
@contextmanager
def _seed_target_history(self, prior_messages: Optional[List[Any]]):
"""Temporarily seed the filtered handoff context onto the target agent.
The configured ``context_policy``/``input_filter`` produce the messages the
target should see; without seeding them the target only ever received the
literal handoff prompt string and the configured policy had no effect.
The seeding is *invocation-scoped*: the prior messages are prepended for the
duration of this handoff and the target's original ``chat_history`` is
restored on exit. This keeps handoff context from leaking into later
handoffs or ordinary chats that reuse the same target agent, and stops the
target prompt from growing across sequential handoffs.
No shared mutable state is retained between agents.
"""
existing = getattr(self.agent, 'chat_history', None)
if not prior_messages or not isinstance(existing, list):
yield
return
try:
prior = list(prior_messages)
except TypeError:
yield
return
original = existing
try:
# Avoid re-seeding if the context is already at the head.
if existing[:len(prior)] != prior:
self.agent.chat_history = prior + existing
yield
finally:
self.agent.chat_history = original
def _execute_with_runtime_resolution(
self,
source_agent: 'Agent',
prompt: str,
effective_tools: Optional[List[Any]],
context: Dict[str, Any]
context: Dict[str, Any],
prior_messages: Optional[List[Any]] = None,
) -> str:
"""Execute handoff through the target agent's full chat pipeline."""
target_model_ref = self._extract_model_ref(self.agent)
@@ -484,14 +519,16 @@ class Handoff:
target_model_ref,
_get_handoff_depth(),
)
return self.agent.chat(prompt, tools=effective_tools)
with self._seed_target_history(prior_messages):
return self.agent.chat(prompt, tools=effective_tools)
async def _execute_with_runtime_resolution_async(
self,
source_agent: 'Agent',
prompt: str,
effective_tools: Optional[List[Any]],
context: Dict[str, Any]
context: Dict[str, Any],
prior_messages: Optional[List[Any]] = None,
) -> str:
"""Execute handoff through the target agent's full async chat pipeline."""
target_model_ref = self._extract_model_ref(self.agent)
@@ -501,13 +538,14 @@ class Handoff:
target_model_ref,
_get_handoff_depth(),
)
async_chat = getattr(self.agent, 'achat', None)
if callable(async_chat) and inspect.iscoroutinefunction(async_chat):
return await async_chat(prompt, tools=effective_tools)
loop = asyncio.get_running_loop()
return await loop.run_in_executor(
None, lambda: self.agent.chat(prompt, tools=effective_tools)
)
with self._seed_target_history(prior_messages):
async_chat = getattr(self.agent, 'achat', None)
if callable(async_chat) and inspect.iscoroutinefunction(async_chat):
return await async_chat(prompt, tools=effective_tools)
loop = asyncio.get_running_loop()
return await loop.run_in_executor(
None, lambda: self.agent.chat(prompt, tools=effective_tools)
)
def _check_safety(self, source_agent: 'Agent') -> None:
"""
@@ -661,8 +699,9 @@ class Handoff:
# Execute on_handoff callback
self._execute_callback(self.config.on_handoff or self.on_handoff, source_agent, kwargs)
# Prepare context (for future extensibility - context data available for hooks)
_ = self._prepare_context(source_agent, kwargs)
# Prepare context per the configured context_policy/input_filter and
# thread the filtered history through to the target agent.
handoff_data = self._prepare_context(source_agent, kwargs)
# Build prompt with context
context_prefix = f"[Handoff from {source_agent.name}] "
@@ -677,7 +716,8 @@ class Handoff:
# Resolve runtime at turn-time instead of using construction-time pin
response = self._execute_with_runtime_resolution(
source_agent, full_prompt, effective_tools, kwargs
source_agent, full_prompt, effective_tools, kwargs,
prior_messages=handoff_data.messages,
)
result = HandoffResult(
@@ -769,8 +809,9 @@ class Handoff:
# Execute callback
self._execute_callback(self.config.on_handoff or self.on_handoff, source_agent, kwargs)
# Prepare context (for future extensibility)
_ = self._prepare_context(source_agent, kwargs)
# Prepare context per the configured context_policy/input_filter
# and thread the filtered history through to the target agent.
handoff_data = self._prepare_context(source_agent, kwargs)
# Build prompt
context_prefix = f"[Handoff from {source_agent.name}] "
@@ -785,7 +826,8 @@ class Handoff:
# Resolve runtime at turn-time for async execution
response = await self._execute_with_runtime_resolution_async(
source_agent, full_prompt, effective_tools, kwargs
source_agent, full_prompt, effective_tools, kwargs,
prior_messages=handoff_data.messages,
)
result = HandoffResult(
@@ -898,20 +940,39 @@ class Handoff:
# Prepare handoff data with context policy
handoff_data = self._prepare_context(source_agent, kwargs)
# Get the last user message or context to pass to target agent
# Get the last user message or context to pass to target agent.
# Track the index of the message chosen for ``prompt`` so exactly
# that item is excluded from the seeded history (it may not be the
# final list item if an assistant/tool message follows it).
last_message = None
for msg in reversed(handoff_data.messages):
selected_index = None
for i in range(len(handoff_data.messages) - 1, -1, -1):
msg = handoff_data.messages[i]
if isinstance(msg, dict) and msg.get('role') == 'user':
last_message = msg.get('content', '')
selected_index = i
break
if not last_message and handoff_data.messages:
last_msg = handoff_data.messages[-1]
selected_index = len(handoff_data.messages) - 1
last_msg = handoff_data.messages[selected_index]
if isinstance(last_msg, dict):
last_message = last_msg.get('content', '')
else:
last_message = str(last_msg)
# Tool-style handoff (as_tool): ContextPolicy.NONE discards the
# history, so the prompt must come from the generated ``task``/
# ``prompt`` argument instead. Without this the sub-agent would
# never run and the tool would report a hollow "completed". The
# task is the sub-agent's whole instruction, so it is passed
# verbatim rather than wrapped in a ``[Handoff from …]`` prefix.
task_prompt = None
if not last_message and not self.input_type:
task_prompt = kwargs.get('task') or kwargs.get('prompt')
if task_prompt:
last_message = str(task_prompt)
# Prepare context information
context_info = f"[Handoff from {source_agent.name}] "
if kwargs and self.input_type:
@@ -919,15 +980,26 @@ class Handoff:
# Execute the target agent with tool boundary enforcement
if last_message:
prompt = context_info + last_message
prompt = last_message if task_prompt else context_info + last_message
logger.info(f"Handing off to {self.agent.name} with prompt: {prompt}")
# Compute effective tools based on tool policy
effective_tools = self._compute_effective_tools(source_agent)
# Resolve runtime at turn-time for tool function execution
# Resolve runtime at turn-time for tool function execution.
# The selected message is already folded into ``prompt`` above,
# so exclude exactly that item from the seeded history to avoid
# duplicating it while preserving any messages that follow it.
if selected_index is None:
prior_messages = list(handoff_data.messages)
else:
prior_messages = (
handoff_data.messages[:selected_index]
+ handoff_data.messages[selected_index + 1:]
)
response = self._execute_with_runtime_resolution(
source_agent, prompt, effective_tools, kwargs
source_agent, prompt, effective_tools, kwargs,
prior_messages=prior_messages,
)
result = HandoffResult(
@@ -995,6 +1067,17 @@ class Handoff:
)
)
handoff_tool.__signature__ = inspect.Signature(sig_params)
elif self.config.context_policy == ContextPolicy.NONE:
# Tool-style handoff (as_tool): no conversation context is passed, so
# advertise an explicit ``task`` parameter the caller must fill. This
# is what ``handoff_tool`` reads as the sub-agent's prompt above.
handoff_tool.__signature__ = inspect.Signature([
inspect.Parameter(
'task',
inspect.Parameter.KEYWORD_ONLY,
annotation=str,
)
])
return handoff_tool
@@ -1468,8 +1551,9 @@ class TypedHandoff(Handoff, Generic[T]):
# Execute on_handoff callback
self._execute_callback(self.config.on_handoff or self.on_handoff, source_agent, kwargs)
# Apply input filter if provided (fixes Greptile P1 issue)
_ = self._prepare_context(source_agent, kwargs)
# Apply context policy / input filter; the resulting messages are
# seeded onto the target only for the duration of its chat below.
handoff_data = self._prepare_context(source_agent, kwargs)
# Validate payload against schema
try:
@@ -1496,7 +1580,8 @@ class TypedHandoff(Handoff, Generic[T]):
logger.info(f"Typed handoff to {self.agent.name} with validated payload")
# Execute with timeout if sync
response = self.agent.chat(full_prompt)
with self._seed_target_history(handoff_data.messages):
response = self.agent.chat(full_prompt)
result = HandoffResult(
success=True,
@@ -1581,8 +1666,9 @@ class TypedHandoff(Handoff, Generic[T]):
# Execute callback
self._execute_callback(self.config.on_handoff or self.on_handoff, source_agent, kwargs)
# Apply input filter if provided (fixes Greptile P1 issue)
_ = self._prepare_context(source_agent, kwargs)
# Apply context policy / input filter; the resulting messages are
# seeded onto the target only for the duration of its chat below.
handoff_data = self._prepare_context(source_agent, kwargs)
# Validate payload against schema
try:
@@ -1608,12 +1694,13 @@ class TypedHandoff(Handoff, Generic[T]):
logger.info(f"Async typed handoff to {self.agent.name}")
# Execute - check for async chat method
if hasattr(self.agent, 'achat'):
response = await self.agent.achat(full_prompt)
else:
# Run sync chat in executor
loop = asyncio.get_event_loop()
response = await loop.run_in_executor(None, self.agent.chat, full_prompt)
with self._seed_target_history(handoff_data.messages):
if hasattr(self.agent, 'achat'):
response = await self.agent.achat(full_prompt)
else:
# Run sync chat in executor
loop = asyncio.get_event_loop()
response = await loop.run_in_executor(None, self.agent.chat, full_prompt)
return HandoffResult(
success=True,
@@ -0,0 +1,88 @@
"""Shared authorisation + bind guard for the ``launch()`` serving paths.
Both ``Agent.launch()`` (``agent/execution_mixin.py``) and
``PraisonAIAgents.launch()`` (``agents/agents.py``) expose a prompt-execution
HTTP endpoint. They must enforce identical request authorisation and must not
silently bind all interfaces without a token. Factoring the two helpers here
keeps that policy in one place so the two launch paths cannot drift apart.
Stdlib only — no heavy imports, no new public params.
"""
from __future__ import annotations
import os
import secrets as _secrets
from typing import Optional
__all__ = [
"launch_auth_token",
"authorise_launch_request",
"resolve_launch_host",
]
# Hosts that are safe to serve keyless on: loopback only.
_LOOPBACK_HOSTS = frozenset({"127.0.0.1", "::1", "localhost"})
# One auto-generated token per process, reused across launches so a later
# non-loopback launch cannot mint a fresh token and lock out an endpoint that
# is already serving with the previously generated one.
_GENERATED_TOKEN: Optional[str] = None
def launch_auth_token() -> Optional[str]:
"""Return the configured launch bearer token, if any."""
return os.environ.get("PRAISONAI_LAUNCH_AUTH_TOKEN")
def authorise_launch_request(request) -> bool:
"""Return True if the request carries the configured bearer token.
When no token is configured this returns True (local-dev flow preserved).
Accepts either ``Authorization: Bearer <token>`` or ``X-Auth-Token``.
"""
token = launch_auth_token()
if not token:
return True
auth = request.headers.get("Authorization", "")
if auth.startswith("Bearer ") and _secrets.compare_digest(auth[7:], token):
return True
supplied = request.headers.get("X-Auth-Token", "")
return bool(supplied) and _secrets.compare_digest(supplied, token)
def _is_loopback(host: str) -> bool:
return host in _LOOPBACK_HOSTS
def resolve_launch_host(host: str) -> str:
"""Fail-closed bind guard, mirroring the ``serve``/jobs precedent.
* Token set → bind ``host`` unchanged (auth protects the endpoint).
* Token unset + loopback host → bind unchanged (local dev unchanged).
* Token unset + non-loopback host → auto-generate a token, export it via
``PRAISONAI_LAUNCH_AUTH_TOKEN`` so every route enforces it, and print it
once. This closes the unauthenticated-exposure hole without refusing to
start.
Returns the host to bind (unchanged; the guard acts on the token, not the
host, so an explicit ``0.0.0.0`` is still honoured — just never keyless).
A generated token is reused for the lifetime of the process: repeated
non-loopback launches share the one token rather than each minting a fresh
one, so a later launch cannot invalidate an already-running endpoint's
clients.
"""
if launch_auth_token() or _is_loopback(host):
return host
global _GENERATED_TOKEN
if _GENERATED_TOKEN is None:
_GENERATED_TOKEN = _secrets.token_urlsafe(32)
print(
f"🔐 launch() bound to non-loopback host {host!r} without "
f"PRAISONAI_LAUNCH_AUTH_TOKEN set. Generated a one-time bearer token "
f"(set PRAISONAI_LAUNCH_AUTH_TOKEN to override): {_GENERATED_TOKEN}"
)
os.environ["PRAISONAI_LAUNCH_AUTH_TOKEN"] = _GENERATED_TOKEN
return host
@@ -89,8 +89,8 @@ class OCRAgent:
ocr: OCR configuration
verbose: Verbosity level for output
"""
if llm is None and model is not None:
llm = model
from ..utils.model_alias import resolve_model_name
llm = resolve_model_name(llm, model, "OCRAgent")
self.name = name or "OCRAgent"
self.instructions = instructions
@@ -0,0 +1,211 @@
"""One vocabulary for "where does this run?", shared by Agent, AgentFlow and AgentTeam.
Two questions get asked about placement and they have different answers:
``run_on=``
Where the **whole agent** runs -- the model calls, the loop, the tools, all
of it on someone else's machine. Only a *managed runtime* can answer this,
because running the loop remotely means something has to host the loop.
``tools_run_on=``
Where **the tools** run. Thinking stays on this machine; only the shell,
the file writes and the code execution move. Any sandbox or compute place
can answer this, because all it has to do is run a command.
Keeping the two words apart is the entire point. The old surface used one word
(``run_on=``) on ``AgentFlow``/``AgentTeam`` for the tools-only meaning, another
(``compute=``) on ``LocalAgent`` for exactly the same meaning, and a third
(``backend=``) for the whole-agent meaning -- so the same concept had two names
and one name had two concepts.
Because the two questions have disjoint answer sets, a wrong pairing is a typo
worth catching rather than a preference worth honouring. ``run_on="docker"``
cannot mean anything: Docker does not host agent loops. It gets a ``TypeError``
naming the parameter the user actually wanted, not a silent fallback.
"""
from __future__ import annotations
from typing import Any, Literal, NamedTuple, Optional, Union
# Runtimes that can host an entire agent loop. Resolved from the wrapper's
# entry-point registry when it is installed so third-party backends work with
# `run_on=` too; the literal is the floor, not the ceiling.
_FALLBACK_MANAGED = ("anthropic",)
# Static spellings so editors can autocomplete and type-checkers can reject a
# typo at the call site rather than at the first model turn. The runtime
# functions below stay the authority for validation -- these exist for tooling,
# which cannot call a function to learn a set.
# Keep in sync with _compute_bridge._PROVIDERS | _sandbox_adapter.SANDBOX_ONLY.
ManagedRuntime = Literal["anthropic"]
ToolPlace = Literal[
"local", "subprocess", "sandlock", "docker", "e2b",
"modal", "daytona", "flyio", "tenki", "novita", "ssh",
]
def managed_runtimes() -> tuple:
"""Names that ``run_on=`` accepts -- places that host a whole agent."""
try:
from praisonai.integrations.backend_registry import get_backend_registry
names = tuple(get_backend_registry().list_all_names())
if names:
return tuple(sorted(set(names) | set(_FALLBACK_MANAGED)))
except Exception:
pass
return _FALLBACK_MANAGED
def tool_places() -> list:
"""Names that ``tools_run_on=`` accepts -- places that can run a command.
Includes the resolver's aliases. Validation runs before resolution, so
leaving them out rejected spellings the resolver handles happily:
``tools_run_on="native"`` raised "not a known place" while
``resolve_compute("native")`` returned a working sandlock adapter.
"""
try:
from ..managed._compute_bridge import _ALIASES, available_providers
return sorted(set(available_providers()) | set(_ALIASES))
except Exception:
return ["local", "docker"]
class Placement(NamedTuple):
"""The resolved answer to "where does this run?"."""
whole: Optional[Any] = None # managed runtime name/object, or None
tools: Optional[Any] = None # tools place name/object, or None
def _name_of(value: Any) -> Optional[str]:
"""The comparable name of a placement value, or None if it is an object.
Objects (a built provider, a live ``SSHSandbox``) carry their own config and
are never second-guessed -- only bare strings get routed by name.
"""
return value.lower() if isinstance(value, str) else None
def _quote_list(names) -> str:
return ", ".join(repr(n) for n in names)
def resolve_placement(
owner: str,
*,
run_on: Any = None,
tools_run_on: Any = None,
backend: Any = None,
supports_run_on: bool = True,
) -> Placement:
"""Validate placement arguments and return where things should run.
``owner`` is the class name, used only to make errors read naturally.
``supports_run_on`` is False for AgentFlow/AgentTeam, which can place tools
but cannot (yet) hand a whole multi-agent run to a managed runtime.
Raises:
TypeError: on any combination that names two different places for the
same thing, or a place that cannot do the job asked of it.
"""
managed = managed_runtimes()
places = tool_places()
# ── a place that cannot do the job asked of it ───────────────────────────
run_on_name = _name_of(run_on)
if run_on_name is not None and run_on_name not in managed:
if run_on_name in places:
raise TypeError(
f"{owner}(run_on={run_on!r}) is not valid: run_on= places the "
f"whole agent -- model calls, loop and tools -- on a managed "
f"runtime, and {run_on_name!r} runs commands but cannot host an "
f"agent loop.\n"
f" To run only the tools there: {owner}(tools_run_on={run_on!r})\n"
f" Runtimes that host a whole agent: {_quote_list(managed)}"
)
raise TypeError(
f"{owner}(run_on={run_on!r}) is not a known managed runtime.\n"
f" Runtimes that host a whole agent: {_quote_list(managed)}\n"
f" Places that can run tools: {_quote_list(places)} "
f"(pass those as tools_run_on=)"
)
tools_name = _name_of(tools_run_on)
if tools_name is not None and tools_name in managed and tools_name not in places:
raise TypeError(
f"{owner}(tools_run_on={tools_run_on!r}) is not valid: {tools_name!r} "
f"hosts an entire agent, not individual tools.\n"
f" Did you mean: {owner}(run_on={tools_run_on!r})"
)
# A typo here used to survive construction and only surface on the first
# model turn -- after the prompt was built and, for a real run, after the
# API spend. run_on= validates at the call site and YAML validates at load
# time; this is the same standard for the third spelling.
if tools_name is not None and tools_name not in places:
raise TypeError(
f"{owner}(tools_run_on={tools_run_on!r}) is not a known place.\n"
f" Places that can run tools: {_quote_list(places)}\n"
f" Runtimes that host a whole agent: {_quote_list(managed)} "
f"(pass those as run_on=)"
)
# Names that cannot work as a bare string, because the connection details
# live in the object. Catch it now rather than at first use.
if tools_name is not None:
try:
from ..managed._sandbox_adapter import NEEDS_INSTANCE
except Exception:
NEEDS_INSTANCE = {}
if tools_name in NEEDS_INSTANCE:
raise TypeError(
f"{owner}(tools_run_on={tools_run_on!r}) needs more than a name: "
f"{NEEDS_INSTANCE[tools_name]}"
)
# ── two names for the same thing ─────────────────────────────────────────
if run_on is not None and backend is not None:
raise TypeError(
f"{owner}(run_on=..., backend=...) sets the agent's runtime twice. "
f"run_on={run_on!r} is the short form of backend=HostedAgent("
f"provider={run_on!r}); pass one or the other.\n"
f" Use backend= only when you need to configure the runtime "
f"(model, system prompt, tools)."
)
if run_on is not None and tools_run_on is not None:
raise TypeError(
f"{owner}(run_on={run_on!r}, tools_run_on={tools_run_on!r}) points "
f"the tools at two machines. run_on= already runs everything -- "
f"including tools -- on {run_on!r}.\n"
f" Whole agent remote: {owner}(run_on={run_on!r})\n"
f" Only tools remote: {owner}(tools_run_on={tools_run_on!r})"
)
if backend is not None and tools_run_on is not None:
raise TypeError(
f"{owner}(backend=..., tools_run_on={tools_run_on!r}) points the "
f"tools at two machines: backend= runs the whole agent (tools "
f"included) on its managed runtime, so the tools cannot also run on "
f"{tools_run_on!r}.\n"
f" Drop tools_run_on= to keep the hosted runtime, or drop backend= "
f"to keep local thinking with remote tools."
)
# ── a class that cannot answer this question ─────────────────────────────
if run_on is not None and not supports_run_on:
raise TypeError(
f"{owner}(run_on={run_on!r}) is not supported: run_on= hands one "
f"agent's whole loop to a managed runtime, and a {owner} "
f"orchestrates several agents locally.\n"
f" To run every step's tools in one shared sandbox:\n"
f" {owner}(tools_run_on={run_on!r})\n"
f" To host a single agent's loop, put run_on= on that Agent."
)
return Placement(whole=run_on, tools=tools_run_on)
@@ -57,7 +57,8 @@ class RealtimeAgent:
def __init__(
self,
name: str = "RealtimeAgent",
llm: Optional[str] = None,
llm: Optional[str] = None, # Deprecated alias for model=
model: Optional[str] = None,
realtime: Optional[Union[bool, Dict, RealtimeConfig]] = None,
instructions: Optional[str] = None,
verbose: bool = True,
@@ -67,14 +68,16 @@ class RealtimeAgent:
Args:
name: Agent name
llm: LLM model (default: gpt-4o-realtime-preview)
llm: Deprecated alias for model=. Passing both raises TypeError.
model: Model to use (default: gpt-4o-realtime-preview)
realtime: Realtime configuration (bool, dict, or RealtimeConfig)
instructions: System instructions
verbose: Enable verbose output
**kwargs: Additional arguments
"""
from ..utils.model_alias import resolve_model_name
self.name = name
self.llm = llm or "gpt-4o-realtime-preview"
self.llm = resolve_model_name(llm, model, "RealtimeAgent") or "gpt-4o-realtime-preview"
self.instructions = instructions
self.verbose = verbose
@@ -52,19 +52,61 @@ class SandboxMixin:
return self._sandbox_manager
def _manager_for(self, run_in: Optional[Union[bool, str, 'SandboxConfig']]):
"""Return the sandbox manager for a ``run_in=`` argument.
``run_in=`` names where a single ``execute_code()`` call runs, so the
place lives on the call that uses it rather than on the constructor.
``Agent(sandbox=...)`` still sets the default for every call.
Managers are cached per place: a fresh ``SandboxManager`` per call would
start and tear down a container each time, which for Docker is seconds
of latency and for any backend means the previous call's files are gone.
"""
if run_in is None:
if not self.has_sandbox:
raise RuntimeError(
"No sandbox configured. Either name a place on the call --\n"
" agent.execute_code_sync(code, run_in='docker')\n"
"or set a default for every call with Agent(sandbox='docker')."
)
return self.get_sandbox_manager()
from ..sandbox import SandboxConfig, SandboxManager
if run_in is True:
config = SandboxConfig.subprocess()
elif isinstance(run_in, str):
config = SandboxConfig(sandbox_type=run_in)
else:
config = run_in
key = getattr(config, "sandbox_type", None) or repr(config)
cache = getattr(self, "_sandbox_managers", None)
if cache is None:
cache = self._sandbox_managers = {}
if key not in cache:
cache[key] = SandboxManager(config)
return cache[key]
async def execute_code(
self,
code: str,
language: str = "python",
check_security: bool = True,
run_in: Optional[Union[bool, str, 'SandboxConfig']] = None,
**kwargs
) -> 'SandboxResult':
"""Execute code safely in configured sandbox.
"""Execute code safely in a sandbox.
Args:
code: Code to execute
language: Programming language (python, bash, etc.)
check_security: Whether to run security pre-checks
run_in: Where to run this call -- "docker", "sandlock",
"subprocess", a SandboxConfig, or True for the default local
sandbox. Overrides Agent(sandbox=...) for this call only.
**kwargs: Additional arguments passed to sandbox.execute()
Returns:
@@ -73,10 +115,7 @@ class SandboxMixin:
Raises:
RuntimeError: If no sandbox is configured
"""
if not self.has_sandbox:
raise RuntimeError(
"No sandbox configured. Set sandbox=True or provide SandboxConfig to Agent()"
)
manager = self._manager_for(run_in)
# Security pre-check if enabled
security_warnings = None
@@ -88,7 +127,6 @@ class SandboxMixin:
if self.verbose:
logger.warning(f"Security warnings for code execution:\n{warning_text}")
manager = self.get_sandbox_manager()
result = await manager.run_code(code, language=language, **kwargs)
# Attach warnings to the result rather than forwarding a `metadata`
@@ -109,6 +147,7 @@ class SandboxMixin:
code: str,
language: str = "python",
check_security: bool = True,
run_in: Optional[Union[bool, str, 'SandboxConfig']] = None,
**kwargs
) -> 'SandboxResult':
"""Synchronous wrapper for execute_code.
@@ -123,12 +162,15 @@ class SandboxMixin:
SandboxResult with execution details
"""
from ..approval.utils import run_coroutine_safely
return run_coroutine_safely(self.execute_code(code, language, check_security, **kwargs))
return run_coroutine_safely(
self.execute_code(code, language, check_security, run_in=run_in, **kwargs)
)
async def run_shell_command(
self,
command: Union[str, list],
check_security: bool = True,
run_in: Optional[Union[bool, str, 'SandboxConfig']] = None,
**kwargs
) -> 'SandboxResult':
"""Run a shell command in the sandbox.
@@ -141,8 +183,7 @@ class SandboxMixin:
Returns:
SandboxResult with execution details
"""
if not self.has_sandbox:
raise RuntimeError("No sandbox configured")
manager = self._manager_for(run_in)
# Convert command to string for security checking
if isinstance(command, list):
@@ -159,7 +200,7 @@ class SandboxMixin:
if self.verbose:
logger.warning(f"Security warnings for command:\n{warning_text}")
async with self.get_sandbox_manager() as sandbox:
async with manager as sandbox:
return await sandbox.run_command(command, **kwargs)
def get_sandbox_status(self) -> Dict[str, Any]:
@@ -374,6 +374,12 @@ class ToolExecutionMixin:
return resolve_tool_names(tool_names)
def _resolve_tools_list(self, tools):
"""Resolve any tool-name strings inside a mixed ``tools=`` list."""
from ..tools.resolver import resolve_tools_list
return resolve_tools_list(tools)
def _cast_arguments(self, func, arguments):
"""Cast arguments to their expected types based on function signature."""
if not callable(func) or not arguments:
@@ -489,6 +495,7 @@ class ToolExecutionMixin:
run_id=getattr(self, '_current_run_id', 'unknown'),
session_id=getattr(self, '_session_id', None) or 'default',
tool_name=function_name,
metadata={"tool_call_id": tool_call_id},
),
)
@@ -746,26 +753,21 @@ class ToolExecutionMixin:
if blocked_result is not None:
result = blocked_result
else:
# Apply tool retry logic with exponential backoff
execution_config = getattr(self, '_execution_config', None)
if execution_config is None:
# Fall back to reading individual config attributes for backward compatibility
max_retry_limit = getattr(self, 'max_retry_limit', 2)
retry_initial_delay = 1.0
retry_backoff_factor = 2.0
retry_jitter = 0.1
else:
max_retry_limit = execution_config.max_retry_limit
retry_initial_delay = execution_config.retry_initial_delay
retry_backoff_factor = execution_config.retry_backoff_factor
retry_jitter = execution_config.retry_jitter
# Apply tool retry logic with exponential backoff.
# ONE vocabulary: the effective RetryPolicy caps how many times
# the tool body may run, whichever of the two loops does the
# retrying, and owns the backoff. ExecutionConfig.max_retry_limit
# / retry_* are translated into it (see
# _effective_tool_retry_policy) rather than run as a second,
# independent budget in different units.
retry_policy = self._effective_tool_retry_policy(function_name)
max_attempts = retry_policy.max_attempts
result = None
last_exception = None
# max_retry_limit is the number of retries (not total attempts)
# So total attempts = 1 (initial) + max_retry_limit (retries)
for attempt in range(1, max_retry_limit + 2):
# max_attempts is the total number of tool-body runs.
for attempt in range(1, max_attempts + 1):
try:
# P8/G11: Apply tool timeout if configured
tool_timeout = getattr(self, '_tool_timeout', None)
@@ -807,7 +809,12 @@ class ToolExecutionMixin:
_progress_active.clear()
future.cancel()
logging.warning(f"Tool {function_name} timed out after {tool_timeout}s")
result = {"error": f"Tool timed out after {tool_timeout}s", "timeout": True}
# Tag as an OUTER wall-clock timeout: unlike an
# inner-loop timeout (already retried to
# exhaustion), the body ran once here and the
# inner budget never saw it, so this one still
# earns an outer retry pass under the single budget.
result = {"error": f"Tool timed out after {tool_timeout}s", "timeout": True, "_outer_timeout": True}
# The timed-out thread cannot be reclaimed. Retire this
# executor so the next call gets a fresh worker instead of
# queuing behind a permanently stuck one — but bound how many
@@ -826,59 +833,80 @@ class ToolExecutionMixin:
# Check if the result indicates a retryable error
if isinstance(result, dict) and result.get("error"):
# Check if this is a circuit breaker error (always retryable)
if result.get("circuit_open"):
raise ToolExecutionError(
result["error"],
tool_name=function_name,
agent_id=self.name,
is_retryable=True,
)
# Check if this is a timeout error (retryable)
elif result.get("timeout"):
raise ToolExecutionError(
result["error"],
tool_name=function_name,
agent_id=self.name,
is_retryable=True,
)
# For other error dicts: approval/permission denials are legitimate
# non-retryable outcomes; everything else represents a tool failure
# that should engage the outer retry/backoff loop.
elif result.get("approval_denied") or result.get("permission_denied") or result.get("approval_error") or result.get("policy_denied") or result.get("guardrail_denied"):
# Approval/permission/policy/guardrail denials are
# legitimate non-retryable outcomes: stop immediately.
if result.get("approval_denied") or result.get("permission_denied") or result.get("approval_error") or result.get("policy_denied") or result.get("guardrail_denied"):
break
else:
# Avoid compounding with the inner retry loop in
# _execute_tool_with_circuit_breaker: error types it already
# retries (e.g. timeout/rate_limit/connection_error) are
# exhausted by the time they reach here, so escalating them as
# retryable would re-run the entire inner loop from scratch on
# every outer attempt. Only escalate error types the inner loop
# does NOT retry (e.g. "unknown") so they get one outer pass.
error_type = self._classify_error_type(result, None)
inner_policy = self._get_tool_retry_policy(function_name)
is_retryable = error_type not in inner_policy.retry_on
raise ToolExecutionError(
result.get("error", f"Tool '{function_name}' failed"),
tool_name=function_name,
agent_id=self.name,
is_retryable=is_retryable,
)
# ONE budget: the inner loop
# (_execute_tool_with_circuit_breaker) already retries
# its retry_on error types (timeout/rate_limit/
# connection_error) to exhaustion before returning here,
# so re-escalating them as retryable would restart the
# whole inner budget on every outer attempt and run the
# tool up to max_attempts² times.
error_type = self._classify_error_type(result, None)
inner_policy = self._get_tool_retry_policy(function_name)
# Only escalate to an outer retry pass when the failure is
# a transient the inner loop did NOT already re-drive:
# • _outer_timeout — this loop's own wall-clock guard
# tripped; the body ran once and the inner budget
# never saw it. BUT the timed-out body is still
# running in an orphaned thread (future.cancel() is
# a no-op once started), so retrying a mutating tool
# would duplicate its side effects. Only re-drive it
# when the tool is known idempotent/read-only.
# • circuit_open — returned by the inner loop WITHOUT a
# body run, so retrying costs no duplicate side effect.
# • _praison_retryable — a raised exception was flattened
# into this error dict (see _execute_tool_impl); honour
# that verdict, but ONLY for error types the inner loop
# does not itself retry, or inner×outer would run the
# body max_attempts² times.
# A plain error dict the tool body *returned* carries no tag
# — it is the tool's own reported outcome, not a transient
# the framework must re-drive. The body already ran to
# completion, so re-running it would duplicate its side
# effects (charge money, send a message, write a row) for a
# decision the tool already made. If a user genuinely wants
# such an outcome retried, its error type belongs in the
# RetryPolicy.retry_on the inner loop honours — not a word
# in the tool's own payload. Surface it once.
is_retryable = bool(
(result.get("_outer_timeout")
and self._is_tool_idempotent(function_name))
or result.get("circuit_open")
or (result.get("_praison_retryable") is True
and error_type not in inner_policy.retry_on
# The body already ran and may have completed
# its side effect before raising. Honour an
# explicit non-idempotent declaration here, as
# the _outer_timeout clause above already does.
and not self._tool_declares_not_idempotent(function_name))
)
# Strip the private control-plane tag before it can reach
# the model or be re-surfaced as the tool's payload.
result.pop("_praison_retryable", None)
raise ToolExecutionError(
result.get("error", f"Tool '{function_name}' failed"),
tool_name=function_name,
agent_id=self.name,
is_retryable=is_retryable,
)
else:
# Success path - return the result
break
except ToolExecutionError as e:
last_exception = e
# Only retry if the error is marked as retryable and we have retries left
# attempt starts at 1, so (attempt - 1) gives us the retry count
if not e.is_retryable or (attempt - 1) >= max_retry_limit:
# Only retry if the error is marked as retryable and the
# policy still has attempts left.
if not e.is_retryable or attempt >= max_attempts:
raise e
# Calculate delay for exponential backoff
delay = BackoffPolicy.delay(attempt, retry_initial_delay, retry_backoff_factor, retry_jitter)
# Calculate delay for exponential backoff (policy owns it)
delay = retry_policy.get_delay_ms(attempt - 1) / 1000.0
logging.warning(
f"Tool {function_name} failed (attempt {attempt}/{max_retry_limit + 1}): {e}. "
f"Tool {function_name} failed (attempt {attempt}/{max_attempts}): {e}. "
f"Retrying in {delay:.2f}s..."
)
time.sleep(delay)
@@ -894,15 +922,14 @@ class ToolExecutionMixin:
is_retryable=is_retryable,
)
last_exception = tool_error
# attempt starts at 1, so (attempt - 1) gives us the retry count
if not is_retryable or (attempt - 1) >= max_retry_limit:
if not is_retryable or attempt >= max_attempts:
raise tool_error from e
# Calculate delay for exponential backoff
delay = BackoffPolicy.delay(attempt, retry_initial_delay, retry_backoff_factor, retry_jitter)
# Calculate delay for exponential backoff (policy owns it)
delay = retry_policy.get_delay_ms(attempt - 1) / 1000.0
logging.warning(
f"Tool {function_name} failed (attempt {attempt}/{max_retry_limit + 1}): {e}. "
f"Tool {function_name} failed (attempt {attempt}/{max_attempts}): {e}. "
f"Retrying in {delay:.2f}s..."
)
time.sleep(delay)
@@ -1994,6 +2021,12 @@ class ToolExecutionMixin:
if not decision.approved:
error_msg = f"Tool execution denied: {decision.reason}"
logging.warning(error_msg)
feedback = getattr(decision, "feedback", None)
if feedback:
error_msg = (
f"Tool '{function_name}' was denied by the user. "
f"Do not retry it as-is. User guidance: {feedback}"
)
return {"error": error_msg, "approval_denied": True}
if decision.modified_args:
@@ -2027,6 +2060,12 @@ class ToolExecutionMixin:
if not decision.approved:
error_msg = f"Tool execution denied: {decision.reason}"
logging.warning(error_msg)
feedback = getattr(decision, "feedback", None)
if feedback:
error_msg = (
f"Tool '{function_name}' was denied by the user. "
f"Do not retry it as-is. User guidance: {feedback}"
)
return {"error": error_msg, "approval_denied": True}
if decision.modified_args:
@@ -2069,7 +2108,13 @@ class ToolExecutionMixin:
result.get("guardrail_denied") or
result.get("circuit_open")):
return result
# The body already ran and may have completed its side effect
# before failing. Honour an explicit non-idempotent declaration
# rather than re-driving it (send a second email, charge twice).
if self._tool_declares_not_idempotent(function_name):
return result
# Determine error type for retry policy
error_type = self._classify_error_type(result, last_exception)
@@ -2551,8 +2596,20 @@ class ToolExecutionMixin:
f"{error_msg} Expected parameters for '{function_name}' — "
f"required: {schema['required']}, optional: {schema['optional']}."
)
return {"error": error_msg, "expected_parameters": schema}
return {"error": error_msg}
# An argument-binding error is a programming error — the same
# call will always fail — so mark it terminal and never retry.
return {"error": error_msg, "expected_parameters": schema, "_praison_retryable": False}
# A tool that *raised* is flattened into an error dict here, which
# erases the exception type the retry policy needs. Carry the same
# verdict the exception paths use so the outer loop can retry a
# transient failure without re-running a tool that merely *returned*
# an error dict of its own. Programming errors are terminal;
# everything else may be retried. Private key: never leaks to the
# model and cannot collide with a tool's own "retryable" field.
return {
"error": error_msg,
"_praison_retryable": not isinstance(e, (ValueError, TypeError, AttributeError)),
}
# Unresolved: return a corrective, model-readable message so the model can
# retry with a valid name instead of repeating the same mistake.
@@ -2939,17 +2996,124 @@ class ToolExecutionMixin:
else:
return f"Unknown bridge tool: {function_name}"
def _tool_declares_not_idempotent(self, tool_name):
"""True only when the tool *explicitly* declares itself unsafe to re-run.
Deliberately narrower than ``_is_tool_idempotent``, which answers False
for unknown tools as a safe default: gating a retry on that would stop
retrying every unregistered user tool.
This keys on an explicit declaration and nothing else. In particular it
must NOT consult the shared ``MUTATING_TOOLS`` name registry -- that is a
73-name list maintained for the escalation loop guard, and using it here
silently removed the retry from any *undeclared* tool that happened to
share a name with an entry (``write_file``, ``store_memory``, ``mkdir``...).
"""
tools = getattr(self, 'tools', [])
if not isinstance(tools, (list, tuple)):
tools = []
for tool in tools:
name_attr = getattr(tool, '__name__', None) or getattr(tool, 'name', None)
if name_attr == tool_name:
explicit = getattr(tool, 'idempotent', None)
if not isinstance(explicit, bool):
# ``restart_safe`` is the public replay-safety contract on
# ``@tool`` (FunctionTool) and ``BaseTool``: ``False`` marks an
# effectful tool that must never be silently re-executed.
explicit = getattr(tool, 'restart_safe', None)
if isinstance(explicit, bool):
return not explicit
return False
# A tool from the process-global registry (only reachable under
# ToolConfig(allow_global_tools=True)) can carry its own declaration;
# ``_is_tool_idempotent`` consults it, so this must too.
if getattr(self, '_allow_global_tools', False):
try:
from ..tools.registry import get_registry
global_tool = get_registry().get(tool_name)
for attr in ('idempotent', 'restart_safe'):
explicit = getattr(global_tool, attr, None)
if isinstance(explicit, bool):
return not explicit
except Exception:
pass
return False
def _is_tool_idempotent(self, tool_name):
"""Whether re-running ``tool_name`` is safe (no duplicated side effects).
Used to decide if an OUTER wall-clock timeout may be retried: the timed-out
tool body is still running in an orphaned thread (``future.cancel()`` is a
no-op once started), so auto-retrying a mutating tool would duplicate its
side effects (send a second email, charge twice). Only tools classified as
read-only/idempotent are safe to re-drive.
Precedence: explicit ``idempotent`` attribute on the tool > the shared
read-only/mutating name registry (reused from the escalation loop guard).
Unknown tools default to NOT idempotent (safe: surface the timeout once).
"""
tools = getattr(self, 'tools', [])
if not isinstance(tools, (list, tuple)):
tools = []
for tool in tools:
tool_name_attr = getattr(tool, '__name__', None) or getattr(tool, 'name', None)
if tool_name_attr == tool_name:
explicit = getattr(tool, 'idempotent', None)
if isinstance(explicit, bool):
return explicit
break
# A tool from the process-global registry (only reachable when
# ToolConfig(allow_global_tools=True)) can carry its own explicit
# ``idempotent`` flag even when its name is absent from the shared
# read-only/mutating registries below.
if getattr(self, '_allow_global_tools', False):
try:
from ..tools.registry import get_registry
global_tool = get_registry().get(tool_name)
explicit = getattr(global_tool, 'idempotent', None)
if isinstance(explicit, bool):
return explicit
except Exception:
pass
try:
from ..escalation.loop_guard import IDEMPOTENT_TOOLS, MUTATING_TOOLS
except Exception:
return False
if tool_name in IDEMPOTENT_TOOLS:
return True
if tool_name in MUTATING_TOOLS:
return False
return False
def _get_tool_retry_policy(self, tool_name):
"""Get retry policy for a tool (tool-level > agent-level > default).
Kept as the historical name; both retry loops now go through
``_effective_tool_retry_policy`` so they share one policy object.
Args:
tool_name: Name of the tool to get retry policy for
Returns:
RetryPolicy instance
"""
return self._effective_tool_retry_policy(tool_name)
def _effective_tool_retry_policy(self, tool_name):
"""The one RetryPolicy that governs every retry of ``tool_name``.
Precedence: per-tool ``.retry_policy`` > agent-level
``ToolConfig(retry_policy=...)`` > a policy translated from the
ExecutionConfig spelling of the same knobs.
``ExecutionConfig`` speaks a second vocabulary for the same thing --
``max_retry_limit`` counts *retries* (so total runs = limit + 1),
``retry_initial_delay`` is in *seconds*, and ``retry_jitter`` is a
*fraction*. Translating it here, once, is what keeps the two retry loops
from running two independent budgets in two different units.
"""
from ..tools.retry import RetryPolicy
# Check for tool-level retry policy first
tools = getattr(self, 'tools', [])
# Handle non-iterable tools (e.g., single MCP instance)
@@ -2960,16 +3124,43 @@ class ToolExecutionMixin:
tool_policy = getattr(tool, 'retry_policy', None) if hasattr(tool, 'retry_policy') else None
if tool_name_attr == tool_name and tool_policy is not None:
return tool_policy
# Check for agent-level retry policy
agent_policy = getattr(self, '_tool_retry_policy', None)
if agent_policy is not None:
return agent_policy
# Return default retry policy (cached class-level instance)
if not hasattr(ToolExecutionMixin, '_default_retry_policy'):
ToolExecutionMixin._default_retry_policy = RetryPolicy()
return ToolExecutionMixin._default_retry_policy
# Translate the ExecutionConfig spelling into the RetryPolicy vocabulary.
execution_config = getattr(self, '_execution_config', None)
if execution_config is None:
max_retry_limit = getattr(self, 'max_retry_limit', 2)
initial_delay_s, backoff_factor, jitter_fraction = 1.0, 2.0, 0.1
else:
max_retry_limit = execution_config.max_retry_limit
initial_delay_s = execution_config.retry_initial_delay
backoff_factor = execution_config.retry_backoff_factor
jitter_fraction = execution_config.retry_jitter
cached = getattr(self, '_translated_retry_policy', None)
key = (max_retry_limit, initial_delay_s, backoff_factor, jitter_fraction)
if cached is not None and cached[0] == key:
return cached[1]
# Reproduce BackoffPolicy.delay's 60s base cap so ExecutionConfig users
# keep the exact same delay ceiling they had before this consolidation
# (RetryPolicy defaults to a 30s cap). initial_delay_ms must not exceed
# max_delay_ms per RetryPolicy validation, so lift the cap to whichever
# is larger.
initial_delay_ms = int(initial_delay_s * 1000)
policy = RetryPolicy(
max_attempts=max(1, max_retry_limit + 1),
backoff_factor=max(1.0, backoff_factor),
initial_delay_ms=initial_delay_ms,
max_delay_ms=max(60000, initial_delay_ms),
jitter=jitter_fraction > 0,
jitter_factor=min(max(jitter_fraction, 0.0), 1.0),
)
self._translated_retry_policy = (key, policy)
return policy
def _classify_error_type(self, error_dict, exception):
"""Classify error type for retry policy matching.
@@ -0,0 +1,129 @@
"""Give a single Agent's tools a sandbox, without touching its thinking.
``AgentFlow``/``AgentTeam`` already share one sandbox across a run and tear it
down when the run ends. A lone ``Agent(tools_run_on=...)`` has no "run" to hang
that lifetime on -- it is just an object someone calls ``chat()`` on, possibly
many times -- so the sandbox is created on first use and lives as long as the
agent does. That is deliberate: a file written in turn 1 is still there in turn
2, which is what anyone who asked for a working directory expects.
Attachment is idempotent and happens at the top of ``chat``/``achat``/
``_start_stream``, and in ``AgentTeam`` before the task's tool list is
snapshotted. Doing it once, rather than wrapping each call in a context
manager, sidesteps two real hazards in this codebase:
* ``_start_stream`` is a **generator**; a context manager around the call would
exit before the caller consumed a single token, tearing down the sandbox while
the model was still using it.
* ``_start_stream`` falls back to ``self.chat``, so a wrapper would **re-enter**
itself and provision a second sandbox.
Lifetime is tied to the agent by ``weakref.finalize`` rather than a process-exit
hook over a weak set. The weak set leaked: an agent and its ``SharedCompute``
reference each other, so a dropped agent was reclaimed by the cycle collector,
vanished from the set, and its sandbox was never shut down. Gateways clone an
agent **per request**, so that was one orphaned container per request.
"""
from __future__ import annotations
import logging
import threading
import weakref
from typing import Any
logger = logging.getLogger(__name__)
# One lock per agent, so two unrelated agents never wait on each other and no
# lock is ever held while another agent's provider is being imported. Held only
# by ensure_tools_placed/close_tools_sandbox for that one agent.
_AGENT_LOCKS: "weakref.WeakKeyDictionary" = weakref.WeakKeyDictionary()
_LOCKS_GUARD = threading.Lock()
def _lock_for(agent: Any) -> threading.Lock:
"""The placement lock for ``agent``, created on demand.
``_LOCKS_GUARD`` covers only this dictionary lookup -- microseconds -- never
provider construction or attachment. An earlier version held one global lock
across ``SharedCompute(...)``, which imports the provider SDK: unrelated
agents serialised behind each other, and a slow import could stall
interpreter exit.
"""
with _LOCKS_GUARD:
lock = _AGENT_LOCKS.get(agent)
if lock is None:
lock = threading.Lock()
try:
_AGENT_LOCKS[agent] = lock
except TypeError: # pragma: no cover - unhashable/non-weakrefable
pass
return lock
def _shutdown_orphan(shared: Any, name: str) -> None:
"""Tear down a sandbox whose agent is gone.
Registered with ``weakref.finalize``, so it runs when the agent is collected
*and* at interpreter exit. It must not close over the agent -- that would
keep it alive and defeat the whole point.
"""
try:
shared.shutdown()
logger.debug("[tools_placement] released the sandbox belonging to %s", name)
except Exception as exc: # pragma: no cover - teardown must stay quiet
# Loud enough to notice: a failed release means a container, or a
# billed cloud instance, is still running after the agent is gone.
logger.warning(
"[tools_placement] could not release the sandbox for %s: %s", name, exc
)
def ensure_tools_placed(agent: Any) -> None:
"""Attach the sandbox tools to ``agent`` if it asked for them. Idempotent.
Called at the top of every entry point, so it must be cheap when there is
nothing to do -- which is the overwhelmingly common case.
"""
place = getattr(agent, "tools_run_on", None)
if place is None or getattr(agent, "_tools_sandbox", None) is not None:
return
from ..managed.shared_compute import SharedCompute
with _lock_for(agent):
# Re-check under the lock: two threads calling chat() at once must not
# each provision a sandbox and leak one.
if getattr(agent, "_tools_sandbox", None) is not None:
return
shared = SharedCompute(place)
# override_declared: this sandbox exists *because* the agent named a
# place, so the skip-if-declared rule must not skip the agent itself.
shared.attach([agent], override_declared=True)
agent._tools_sandbox = shared
agent._tools_sandbox_finalizer = weakref.finalize(
agent, _shutdown_orphan, shared, str(getattr(agent, "name", agent))
)
logger.info("[tools_placement] %r tools now run on %s", getattr(agent, "name", agent), place)
def close_tools_sandbox(agent: Any) -> None:
"""Tear down the agent's sandbox and put its original tools back."""
with _lock_for(agent):
# Everything happens under the lock. Clearing the marker first and
# shutting down afterwards left a window where a concurrent chat()
# re-attached and the in-flight shutdown then restored over it, leaving
# the agent marked as sandboxed while holding no sandbox tools -- a
# state ensure_tools_placed() could never repair, because its idempotent
# early return sees the marker and does nothing.
shared = getattr(agent, "_tools_sandbox", None)
if shared is None:
return
finalizer = getattr(agent, "_tools_sandbox_finalizer", None)
if finalizer is not None:
finalizer.detach() # we are shutting down explicitly
agent._tools_sandbox_finalizer = None
shared.shutdown()
agent._tools_sandbox = None
@@ -282,7 +282,7 @@ class UnifiedExecutionMixin:
task_id=task_id,
config=config,
tool_choice=tool_choice,
parallel_tool_calls=getattr(self, 'parallel_tool_calls', False) # Gap 2 integration
parallel_tool_calls=getattr(getattr(self, "execution", None), "parallel_tool_calls", False) # Gap 2 integration
)
else:
# Standard LiteLLM path - delegate to existing LLM class
@@ -304,7 +304,7 @@ class UnifiedExecutionMixin:
task_id=task_id,
config=config,
tool_choice=tool_choice,
parallel_tool_calls=getattr(self, 'parallel_tool_calls', False) # Gap 2 integration
parallel_tool_calls=getattr(getattr(self, "execution", None), "parallel_tool_calls", False) # Gap 2 integration
)
# Store response in memory if enabled
@@ -158,9 +158,8 @@ class VideoAgent:
verbose: Verbosity level for output
output: Output preset ("silent", "verbose", etc.)
"""
# Handle model= alias for llm=
if llm is None and model is not None:
llm = model
from ..utils.model_alias import resolve_model_name
llm = resolve_model_name(llm, model, "VideoAgent")
# Store core identity
self.name = name or "VideoAgent"
@@ -112,8 +112,8 @@ class VisionAgent:
- VisionConfig: Full configuration object
verbose: Verbosity level for output
"""
if llm is None and model is not None:
llm = model
from ..utils.model_alias import resolve_model_name
llm = resolve_model_name(llm, model, "VisionAgent")
self.name = name or "VisionAgent"
self.instructions = instructions
@@ -2,6 +2,8 @@ import os
import time
import json
import logging
import contextlib
import contextvars
import threading
from praisonaiagents._logging import get_logger
from typing import Any, Dict, Optional, List, Tuple, Callable
@@ -41,18 +43,13 @@ class TaskStatus(Enum):
logger = get_logger(__name__)
def _launch_auth_token() -> Optional[str]:
return os.environ.get("PRAISONAI_LAUNCH_AUTH_TOKEN")
def _authorise_launch_request(request) -> bool:
token = _launch_auth_token()
if not token:
return True
auth = request.headers.get("Authorization", "")
if auth.startswith("Bearer ") and auth[7:] == token:
return True
return request.headers.get("X-Auth-Token") == token
# Request authorisation + fail-closed bind guard are shared with Agent.launch
# so the single-agent and multi-agent serving paths cannot drift apart.
from ..agent.launch_security import (
launch_auth_token as _launch_auth_token,
authorise_launch_request as _authorise_launch_request,
resolve_launch_host as _resolve_launch_host,
)
# Agent server registry for thread-safe server management
@@ -375,6 +372,18 @@ def _build_execution_context(agents_instance, task_id, skip_memory_init=False):
if llm and hasattr(llm, 'set_current_agent'):
llm.set_current_agent(executor_agent.display_name)
# Place the agent's tools BEFORE snapshotting them. This snapshot is passed
# to chat() as an explicit `tools=`, which wins over `agent.tools` -- so if
# the sandbox attaches later (inside chat()), the model is handed the
# pre-attach list and every tool runs on the host while a sandbox sits
# provisioned and unused. Silent, and worse than it sounds: in
# start_for_each() row 1 got local tools and row 2 got the bridged set,
# because row 1's chat() mutated agent.tools in time for row 2's snapshot.
if executor_agent is not None and getattr(executor_agent, "tools_run_on", None) is not None:
from ..agent.tools_placement import ensure_tools_placed
ensure_tools_placed(executor_agent)
# Ensure tools are available from both task and agent (create copy to avoid mutation)
tools = list(task.tools or [])
if executor_agent and executor_agent.tools:
@@ -644,7 +653,8 @@ class AgentTeam(SpawnAnnounceProtocol):
manager_llm=None,
name: Optional[str] = None,
variables: Optional[Dict[str, Any]] = None,
llm: Optional[str] = None, # Default LLM for all agents (API consistency)
llm: Optional[str] = None, # Deprecated alias for model=
model: Optional[str] = None, # Default model for members that did not name one
# Consolidated feature params (agent-centric API)
memory: Optional[Any] = False, # Union[bool, MultiAgentMemoryConfig]
planning: Optional[Any] = False, # Union[bool, MultiAgentPlanningConfig]
@@ -662,9 +672,12 @@ class AgentTeam(SpawnAnnounceProtocol):
learn: Optional[Any] = None, # Union[bool, LearnConfig] - continuous learning
# Union[str, ComputeProviderProtocol] - where every agent's shell/file
# tools run: "docker", "e2b", "modal", "daytona", "flyio", "tenki",
# "local". The team shares ONE sandbox and /workspace, so files written
# by one agent are visible to the others. Orchestration stays local.
# "local", "subprocess", "sandlock", "ssh", "novita". The team shares
# ONE sandbox and one working directory, so files written by one agent
# are visible to the others. Orchestration and thinking stay local.
# Pass a configured provider instance to customise resources.
tools_run_on: Optional[Any] = None,
# Accepted only to fail with a useful message -- see resolve_placement.
run_on: Optional[Any] = None,
):
"""
@@ -676,8 +689,11 @@ class AgentTeam(SpawnAnnounceProtocol):
process: Execution process type ("sequential", "workflow", "hierarchical").
For parallel fan-out, set async_execution=True on individual Task
objects within a "workflow" or "sequential" process.
manager_llm: LLM model for manager agent
llm: Default LLM model for all agents
manager_llm: Model for the hierarchical manager agent. Unrelated to
model=/llm=; it never touches the members.
llm: Deprecated alias for model=. Passing both raises TypeError.
model: Default model for members that did not name one themselves.
An agent constructed with its own llm=/model=/auth= keeps it.
name: Name for this agent collection
variables: Global variables for substitution
memory: Memory configuration (bool | MultiAgentMemoryConfig)
@@ -695,7 +711,21 @@ class AgentTeam(SpawnAnnounceProtocol):
"""
# Store new params for propagation to agents
self._learn = learn
self.llm = llm # Store default LLM for API consistency
# model= is the canonical name; llm= is the deprecated alias. Passing
# both is refused rather than silently resolved (see resolve_model_alias).
# The resolved value is the default model for the members: applied to
# every agent that never named a model of its own; an agent that did
# keeps it. Same rule AgentFlow uses for the agents it builds.
# Must UNWRAP, not just alias-resolve: this value is pushed into every
# member via _apply_default_llm, and a member holding an LLMConfig fails
# inside chat() with "'LLMConfig' object has no attribute 'lower'".
from ..utils.model_alias import resolve_model_name
self.llm = resolve_model_name(llm, model, type(self).__name__)
if self.llm:
for _member in (agents.values() if isinstance(agents, dict) else (agents or [])):
_apply = getattr(_member, "_apply_default_llm", None)
if callable(_apply):
_apply(self.llm)
self._autonomy = autonomy
self._knowledge = knowledge
self._guardrails = guardrails
@@ -910,7 +940,19 @@ class AgentTeam(SpawnAnnounceProtocol):
self.stream = _stream
self.name = name
# Remote execution: one shared sandbox for every agent on this team.
self.run_on = run_on
from ..agent.placement import resolve_placement
resolve_placement(
"AgentTeam", run_on=run_on, tools_run_on=tools_run_on,
supports_run_on=False,
)
self.tools_run_on = tools_run_on
# Kept readable rather than removed. `team.run_on` used to exist, and
# code doing getattr(team, "run_on", None) for introspection or
# serialisation would otherwise start raising AttributeError. None is
# the honest value: a team orchestrates locally, so nothing about it
# runs wholly on a managed runtime.
self.run_on = None
# Callbacks for workflow execution
self.on_task_start = _on_task_start
@@ -1437,6 +1479,73 @@ class AgentTeam(SpawnAnnounceProtocol):
raise result
return results
def _depends_on_pending(self, task, pending):
"""True if ``task`` depends on a task still pending in the batch.
``pending`` is a list of ``(task_id, coroutine)`` pairs already queued
for parallel execution. If one of the task's dependencies is in that
set, its result isn't available yet, so the batch must be flushed before
queuing this task (otherwise the dependent builds its prompt from an
empty result for the still-in-progress dependency).
Two dependency edges are checked, since ``_build_task_context`` reads
from both:
- ``task.context``: explicit context tasks (by object ``id``).
- ``task.previous_tasks``: workflow ``next_tasks`` edges, stored as
task *names*; without this a workflow successor could be queued in
the same async batch as its predecessor and read an empty result.
"""
if not pending:
return False
pending_ids = {tid for tid, _ in pending}
deps = getattr(task, 'context', None) or []
if any(getattr(dep, 'id', None) in pending_ids for dep in deps):
return True
previous = getattr(task, 'previous_tasks', None) or []
if previous:
pending_names = {
self.tasks[tid].name
for tid in pending_ids
if tid in self.tasks
}
if any(name in pending_names for name in previous):
return True
return False
def _deps_failed(self, task_id):
"""True if any dependency of ``task_id`` finished in a failed state.
asequential()/aworkflow() run their own failure check inside the
generator, but async tasks are buffered and drained later, so an
upstream async task may not have failed yet when the generator yielded
the dependent. Re-checking here — after pending async tasks are flushed
— makes the failure cascade fire for the async_execution path too, for
both dependency edges ``_build_task_context`` reads (context tasks and
workflow ``previous_tasks``).
"""
task = self.tasks.get(task_id)
if task is None:
return False
for dep in getattr(task, 'context', None) or []:
dep_id = getattr(dep, 'id', None)
if dep_id in self.tasks and self.tasks[dep_id].status == "failed":
return True
previous = getattr(task, 'previous_tasks', None) or []
if previous:
by_name = {t.name: t for t in self.tasks.values()}
if any(
name in by_name and by_name[name].status == "failed"
for name in previous
):
return True
return False
async def arun_all_tasks(self):
"""Async version of run_all_tasks method"""
process = Process(
@@ -1448,14 +1557,26 @@ class AgentTeam(SpawnAnnounceProtocol):
)
if self.process == "workflow":
tasks_to_run = []
tasks_to_run = [] # list of (task_id, coroutine)
async for task_id in process.aworkflow():
if self.tasks[task_id].async_execution:
tasks_to_run.append(self.arun_task(task_id))
task = self.tasks[task_id]
if task.async_execution:
# If this async task depends on another async task still
# pending in the current batch, flush first so its context
# is available before this one reads it.
if self._depends_on_pending(task, tasks_to_run):
await self._gather_with_isolation([c for _, c in tasks_to_run])
tasks_to_run = []
# A just-flushed prerequisite may now be failed; don't
# queue a dependent that would run with missing context.
if self._deps_failed(task_id):
self.tasks[task_id].status = "failed"
continue
tasks_to_run.append((task_id, self.arun_task(task_id)))
else:
# If we encounter a sync task, we must wait for the previous async tasks to finish.
if tasks_to_run:
await self._gather_with_isolation(tasks_to_run)
await self._gather_with_isolation([c for _, c in tasks_to_run])
tasks_to_run = []
# Run sync task in an executor to avoid blocking the event loop
@@ -1465,46 +1586,40 @@ class AgentTeam(SpawnAnnounceProtocol):
await loop.run_in_executor(None, copy_context_to_callable(lambda tid=task_id: self.run_task(tid)))
if tasks_to_run:
await self._gather_with_isolation(tasks_to_run)
await self._gather_with_isolation([c for _, c in tasks_to_run])
elif self.process == "sequential":
async_tasks_to_run = []
async_tasks_to_run = [] # list of (task_id, coroutine)
async def flush_async_tasks():
"""Execute all pending async tasks"""
nonlocal async_tasks_to_run
if async_tasks_to_run:
await self._gather_with_isolation(async_tasks_to_run)
await self._gather_with_isolation([c for _, c in async_tasks_to_run])
async_tasks_to_run = []
def _deps_failed(task_id):
"""Re-check dependency failure at consumption time.
asequential() runs this check inside the generator, but async
tasks are buffered and drained later, so an upstream async task
may not have failed yet when the generator yielded the dependent.
Re-checking here — after pending async tasks are flushed — makes
the failure cascade fire for the async_execution path too.
"""
task = self.tasks[task_id]
if getattr(task, 'context', None):
return any(
self.tasks[dep.id].status == "failed"
for dep in task.context
if hasattr(dep, 'id') and dep.id in self.tasks
)
return False
async for task_id in process.asequential():
if self.tasks[task_id].async_execution:
task = self.tasks[task_id]
if task.async_execution:
# If this async task depends on another async task still
# pending in the current batch, flush first so its context
# is available before this one reads it (avoids a same-batch
# race that silently substitutes empty dependency context).
if self._depends_on_pending(task, async_tasks_to_run):
await flush_async_tasks()
# A just-flushed prerequisite may now be failed; don't
# queue a dependent that would run with missing context.
if self._deps_failed(task_id):
self.tasks[task_id].status = "failed"
continue
# Collect async tasks to run in parallel
async_tasks_to_run.append(self.arun_task(task_id))
async_tasks_to_run.append((task_id, self.arun_task(task_id)))
else:
# Before running a sync task, execute all pending async tasks
await flush_async_tasks()
# A just-flushed async prerequisite may now be failed; skip
# the dependent so we don't run it with missing upstream context.
if _deps_failed(task_id):
if self._deps_failed(task_id):
self.tasks[task_id].status = "failed"
continue
# Run sync task in an executor to avoid blocking the event loop
@@ -1544,6 +1659,62 @@ class AgentTeam(SpawnAnnounceProtocol):
except StopAsyncIteration:
pass
# ── shared sandbox lifetime ──────────────────────────────────────────────
# A ContextVar, not an instance attribute: the previous version set
# `self.run_on = None` for the duration of the run, so a second caller
# inspecting the team mid-run saw "no sandbox" and any concurrent start()
# executed every tool on the host. Depth lives with the caller, not on the
# shared object, so the team's declared placement is always readable.
#
# The depth is keyed PER TEAM, not shared class-wide. A single integer here
# meant any team started while another team's run was on the stack saw
# depth==1 and skipped its own sandbox entirely -- so a nested team ran on
# the host, and a team sharing an agent with the outer run executed on the
# OUTER team's sandbox.
#
# ContextVar, not threading.local: two coroutines that `astart()` the SAME
# team under one asyncio.gather run on one thread, so thread-local state is
# shared between them -- the second saw the first's depth==1, skipped its
# own sandbox, and ran against a sandbox the first could tear down mid-flight.
# A ContextVar is copied per task at gather/create_task time, so each run
# gets its own depth map; it is also per-thread, so sync callers stay
# isolated too. The value is an immutable frozen mapping replaced via .set()
# (never mutated in place), because a copied context shares the *reference*
# to a mutable dict and in-place mutation would leak straight back across
# the tasks the copy was meant to separate.
_tools_scope_depths: "contextvars.ContextVar" = contextvars.ContextVar(
"praisonai_tools_scope_depths", default=()
)
def _needs_tools_scope(self) -> bool:
"""True when this call should provision the team's shared sandbox."""
if getattr(self, "tools_run_on", None) is None:
return False
return dict(self._tools_scope_depths.get()).get(id(self), 0) == 0
@contextlib.contextmanager
def _shared_tools_scope(self):
"""Hold one sandbox for everything nested inside.
Re-entrant by design: ``start_for_each`` opens the scope once for the
whole batch, so the ``start()`` call it makes per input row finds the
scope already open and reuses that sandbox instead of provisioning and
destroying one per row.
"""
from ..managed.shared_compute import SharedCompute
key = id(self)
depths = dict(self._tools_scope_depths.get())
depths[key] = depths.get(key, 0) + 1
token = self._tools_scope_depths.set(tuple(sorted(depths.items())))
try:
with SharedCompute(self.tools_run_on) as shared:
shared.attach(list(self.agents or []))
yield shared
finally:
self._tools_scope_depths.reset(token)
async def astart(self, content=None, return_dict=False, **kwargs):
"""Async version of start method.
@@ -1552,6 +1723,12 @@ class AgentTeam(SpawnAnnounceProtocol):
return_dict: If True, returns the full results dictionary instead of only the final response
**kwargs: Additional arguments
"""
# Same shared sandbox as start(). Without this, an async team with
# tools_run_on= ran every tool on the host and said nothing.
if self._needs_tools_scope():
with self._shared_tools_scope():
return await self.astart(content=content, return_dict=return_dict, **kwargs)
# Track execution via telemetry
if hasattr(self, '_telemetry') and self._telemetry:
self._telemetry.track_agent_execution(self.name, success=True, async_mode=True)
@@ -1812,19 +1989,11 @@ class AgentTeam(SpawnAnnounceProtocol):
```
"""
# Remote execution: provision ONE sandbox shared by every agent on the
# team, and tear it down even if execution raises. Re-enters start()
# with run_on cleared so the wrapper applies exactly once.
if getattr(self, "run_on", None) is not None:
from ..managed.shared_compute import SharedCompute
run_on, self.run_on = self.run_on, None
try:
with SharedCompute(run_on) as shared:
shared.attach(list(self.agents or []))
return self.start(content=content, return_dict=return_dict,
output=output, **kwargs)
finally:
self.run_on = run_on
# team, and tear it down even if execution raises.
if self._needs_tools_scope():
with self._shared_tools_scope():
return self.start(content=content, return_dict=return_dict,
output=output, **kwargs)
# Track execution via telemetry
if hasattr(self, '_telemetry') and self._telemetry:
@@ -2140,6 +2309,15 @@ class AgentTeam(SpawnAnnounceProtocol):
if on_error not in ("continue", "fail_fast"):
raise ValueError("on_error must be 'continue' or 'fail_fast'")
# One sandbox for the whole batch. Without this the per-row start()
# call provisions and destroys its own, so a 50-row batch paid for 50
# sandboxes and no row could see what an earlier row wrote.
if self._needs_tools_scope():
with self._shared_tools_scope():
return self.start_for_each(
inputs, on_error=on_error, output=output, **kwargs
)
batch_id = f"batch_{uuid.uuid4().hex[:12]}"
saved_variables = self.variables
task_snapshot = self._snapshot_task_state()
@@ -2176,6 +2354,13 @@ class AgentTeam(SpawnAnnounceProtocol):
if on_error not in ("continue", "fail_fast"):
raise ValueError("on_error must be 'continue' or 'fail_fast'")
# One sandbox for the whole batch -- see start_for_each.
if self._needs_tools_scope():
with self._shared_tools_scope():
return await self.astart_for_each(
inputs, on_error=on_error, **kwargs
)
batch_id = f"batch_{uuid.uuid4().hex[:12]}"
saved_variables = self.variables
task_snapshot = self._snapshot_task_state()
@@ -2457,7 +2642,7 @@ class AgentTeam(SpawnAnnounceProtocol):
print("="*50 + "\n")
def launch(self, path: str = '/agents', port: int = 8000, host: str = '0.0.0.0', debug: bool = False, protocol: str = "http"):
def launch(self, path: str = '/agents', port: int = 8000, host: str = '127.0.0.1', debug: bool = False, protocol: str = "http"):
"""
Launch all agents as a single API endpoint (HTTP) or an MCP server.
In HTTP mode, the endpoint accepts a query and processes it through all agents in sequence.
@@ -2468,7 +2653,11 @@ class AgentTeam(SpawnAnnounceProtocol):
Args:
path: API endpoint path (default: '/agents') for HTTP. Ignored in MCP mode.
port: Server port (default: 8000)
host: Server host (default: '0.0.0.0')
host: Server host (default: '127.0.0.1'; changed from '0.0.0.0' to
avoid binding all interfaces by default — pass '0.0.0.0'
explicitly to expose externally). Binding a non-loopback host
without ``PRAISONAI_LAUNCH_AUTH_TOKEN`` set auto-generates and
prints a one-time bearer token.
debug: Enable debug mode for uvicorn (default: False)
protocol: "http" to launch as FastAPI, "mcp" to serve over MCP via
``praisonai-mcp`` (install with ``pip install praisonai-mcp``).
@@ -2478,7 +2667,7 @@ class AgentTeam(SpawnAnnounceProtocol):
"""
if protocol == "http":
# Use centralized server registry
if not self.agents:
logging.warning("No agents to launch for HTTP mode. Add agents to the Agents instance first.")
return
@@ -2507,6 +2696,13 @@ class AgentTeam(SpawnAnnounceProtocol):
print("\nOr install all API dependencies with:")
print("pip install 'praisonaiagents[api]'")
return None
# Fail-closed bind guard shared with Agent.launch: never serve
# keyless on a non-loopback host. Applied only after the no-agents
# and dependency guards above, so a launch that bails out cannot
# mutate the process-wide launch token (which every route reads per
# request) and retroactively 401 an already-running endpoint.
host = _resolve_launch_host(host)
# Thread-safe initialization of FastAPI app
app, is_new = _server_registry.get_or_create_app(
@@ -3145,9 +3341,14 @@ class AgentTeam(SpawnAnnounceProtocol):
console.print(f"[dim]Progress: [{'█' * 30}] 100%[/dim]")
console.print(f"[green]Completed {completed_count}/{len(self.tasks)} tasks![/green]\n")
# Restore original tasks reference for result retrieval
self._plan_tasks = self.tasks.copy()
# Keep plan tasks for results but note original tasks are preserved in _plan_tasks
# Keep plan-step tasks/results under _plan_tasks for introspection,
# then restore the user's original task set as the canonical self.tasks.
self._plan_tasks = self.tasks
self.tasks = original_tasks
with self._task_id_lock:
self.task_id_counter = (
max(original_tasks.keys()) + 1 if original_tasks else 0
)
# Resource Lifecycle Management
def close(self) -> None:
@@ -81,12 +81,14 @@ class ConsoleBackend:
"""Interactive Rich terminal prompt. Default for CLI usage."""
def _prompt_user(self, request: ApprovalRequest):
"""Show Rich panel and ask once/session/always/no.
"""Show Rich panel and ask once/session/always/no/deny-with-guidance.
Returns a ``(approved, scope, scope_pattern)`` tuple where ``scope`` is
one of ``"once"`` / ``"session"`` / ``"always"`` and ``scope_pattern``
is the reusable target to persist for ``always`` (``None`` otherwise).
A denial returns ``(False, "once", None)``.
Returns a ``(approved, scope, scope_pattern, feedback)`` tuple where
``scope`` is one of ``"once"`` / ``"session"`` / ``"always"`` and
``scope_pattern`` is the reusable target to persist for ``always``
(``None`` otherwise). ``feedback`` carries optional free-text guidance
captured by the "deny & redirect" choice (``None`` otherwise).
A plain denial returns ``(False, "once", None, None)``.
"""
Console = _get_rich_console()
Panel = _get_rich_panel()
@@ -126,28 +128,35 @@ class ConsoleBackend:
try:
console.print(
f"[{risk_color}]Allow {request.tool_name}?[/{risk_color}] "
f"[o] once [s] this session [a] {always_label} [n] no"
f"[o] once [s] this session [a] {always_label} "
f"[n] no [d] deny & redirect"
)
choice = Prompt.ask(
"Choice",
choices=["o", "s", "a", "n"],
choices=["o", "s", "a", "n", "d"],
default="n",
)
except (KeyboardInterrupt, EOFError):
return (False, "once", None)
return (False, "once", None, None)
if choice == "n":
return (False, "once", None)
return (False, "once", None, None)
if choice == "d":
try:
feedback = Prompt.ask("What should the agent do instead?").strip()
except (KeyboardInterrupt, EOFError):
feedback = ""
return (False, "once", None, feedback or None)
if choice == "s":
return (True, "session", None)
return (True, "session", None, None)
if choice == "a":
return (True, "always", suggested or None)
return (True, "once", None)
return (True, "always", suggested or None, None)
return (True, "once", None, None)
def request_approval_sync(self, request: ApprovalRequest) -> ApprovalDecision:
"""Synchronous approval via Rich console prompt."""
try:
approved, scope, scope_pattern = self._prompt_user(request)
approved, scope, scope_pattern, feedback = self._prompt_user(request)
if approved:
return ApprovalDecision(
approved=True,
@@ -156,7 +165,13 @@ class ConsoleBackend:
scope=scope,
scope_pattern=scope_pattern,
)
return ApprovalDecision(approved=False, reason="User denied", approver="console")
reason = f"User denied: {feedback}" if feedback else "User denied"
return ApprovalDecision(
approved=False,
reason=reason,
approver="console",
feedback=feedback,
)
except Exception as e:
logger.error("Console approval error: %s", e)
return ApprovalDecision(approved=False, reason=f"Approval error: {e}")
@@ -65,6 +65,12 @@ class ApprovalDecision:
``session``/``always`` scopes (e.g. ``"bash:git status *"``
or ``"edit:src/app.py"``). When ``None`` the registry
derives one from the tool call.
feedback: Optional free-text guidance supplied by the user when
denying a tool call ("deny with guidance"). When present
on a denial it is surfaced back to the model as a
course-correction for the next turn instead of a bare
"denied" result. ``None`` (default) keeps today's
terminal-deny semantics.
"""
approved: bool
@@ -74,6 +80,7 @@ class ApprovalDecision:
metadata: Dict[str, Any] = field(default_factory=dict)
scope: str = "once"
scope_pattern: Optional[str] = None
feedback: Optional[str] = None
@dataclass
@@ -2,7 +2,10 @@
Authentication & Authorization Protocols for PraisonAI Agents.
This package provides protocol-driven auth interfaces for the core SDK.
Implementations (JWT, OAuth, etc.) live in the platform package.
Implementations (JWT, OAuth, etc.) live outside it — implement the protocols
against your own store, or use the reference implementation in the separate
``praisonai-platform`` package
(https://github.com/MervinPraison/PraisonAI-Platform).
Quick start::
@@ -155,11 +155,16 @@ class WorkspaceContextProtocol(Protocol):
"""Protocol for providing workspace context to agents.
Enables agents to access workspace-specific settings, instructions,
and agent configurations from the platform layer.
and agent configurations from a platform layer.
Implementations live outside this package. The reference one is
``PlatformWorkspaceContext`` in the ``praisonai-platform`` package
(https://github.com/MervinPraison/PraisonAI-Platform); implement this
protocol yourself to back agent configuration with your own store.
Example::
class PlatformWorkspaceContext:
class MyWorkspaceContext:
async def get_workspace_context(self, workspace_id):
ws = await db.get_workspace(workspace_id)
return ws.context
@@ -37,6 +37,8 @@ __all__ = [
"ToolResultPrunerProtocol",
"MessageFormatterProtocol",
"SummaryBuilderProtocol",
# Default structured summary builder
"DefaultSummaryBuilder",
# Read-only recap
"build_recap",
"MemoryFlushResult",
@@ -75,6 +77,10 @@ def __getattr__(name: str):
from .protocols import SummaryBuilderProtocol
return SummaryBuilderProtocol
if name == "DefaultSummaryBuilder":
from .summary_builder import DefaultSummaryBuilder
return DefaultSummaryBuilder
if name == "build_recap":
from .recap import build_recap
return build_recap
@@ -122,7 +122,18 @@ class ContextCompactor:
# Protocol implementations (defaults to None - no heavy implementations in core)
self.tool_pruner = tool_pruner
self.message_formatter = message_formatter
self.message_formatter = message_formatter
# Default the structured summary builder when the config asks for the
# phase-aware template but no builder was injected, so
# `_build_structured_summary` renders SUMMARY_TEMPLATE instead of the
# "Summary of N messages" stub. The builder is deterministic and
# dependency-free, so this stays offline-safe and zero-overhead.
if summary_builder is None and getattr(self.config, "structured_template", False):
from .summary_builder import DefaultSummaryBuilder
summary_builder = DefaultSummaryBuilder(
llm_summarize_fn=self.llm_summarize_fn
)
self.summary_builder = summary_builder
# Anti-thrashing state tracking
@@ -0,0 +1,172 @@
"""Default structured summary builder for context compaction.
This is the concrete :class:`~praisonaiagents.compaction.protocols.
SummaryBuilderProtocol` implementation that renders the declared
:data:`~praisonaiagents.compaction.config.SUMMARY_TEMPLATE` — the phase-aware
sections (``## Active Task`` / ``## Completed Actions`` / ``## In Progress`` /
``## Pending Questions`` / ``## Relevant Files / Paths`` / ``## Remaining
Work``) — so a compacted context keeps its structure instead of degrading to a
one-line ``"Summary of N messages"`` count.
Design: **deterministic, dependency-free, offline-safe.** It categorises the
transcript into the template sections from the messages themselves (roles,
tool calls, question marks, file-path tokens) rather than making an LLM call, so
it never blocks the hot compaction path, never adds a runtime dependency, and
never raises into the loop. File paths and identifiers are preserved verbatim.
When an optional ``llm_summarize_fn`` is supplied the builder still renders the
same template shape; on any failure it falls back to the deterministic render,
honouring the issue's "fall back to the plain summary on failure" rule.
"""
from __future__ import annotations
import re
from typing import Any, Dict, List, Optional
from .config import SUMMARY_TEMPLATE
# Match file/path-like tokens so they can be surfaced verbatim in the
# "Relevant Files / Paths" section (absolute/relative paths and dotted module
# names with a recognisable extension).
_PATH_RE = re.compile(
r"(?:/[^\s'\"`]+|(?:[\w.-]+/)+[\w.-]+|[\w./-]+\.[A-Za-z0-9]{1,6})"
)
_MAX_ITEMS = 12
_MAX_LINE = 200
def _text(content: Any) -> str:
"""Best-effort flatten of a message ``content`` field into a string."""
if isinstance(content, str):
return content
if isinstance(content, list):
parts: List[str] = []
for part in content:
if isinstance(part, dict):
parts.append(str(part.get("text", "")))
else:
parts.append(str(part))
return " ".join(p for p in parts if p)
return ""
def _clip(text: str, limit: int = _MAX_LINE) -> str:
text = text.strip().replace("\n", " ")
return text if len(text) <= limit else text[: limit - 1].rstrip() + "…"
class DefaultSummaryBuilder:
"""Deterministic :class:`SummaryBuilderProtocol` renderer for the template.
Args:
llm_summarize_fn: Optional callable ``(prompt: str) -> str`` used to
distil section bodies. Any failure falls back to the deterministic
render, so callers get a valid structured summary regardless.
"""
def __init__(self, llm_summarize_fn: Optional[Any] = None) -> None:
self._llm_summarize_fn = llm_summarize_fn
# -- protocol ----------------------------------------------------------
def build_structured_summary(self, messages: List[Dict[str, Any]]) -> str:
"""Render :data:`SUMMARY_TEMPLATE` from ``messages`` deterministically.
Never raises: on any failure returns the plain one-line summary so the
compaction loop keeps a valid summary string (issue fallback rule).
"""
try:
return self._render(messages)
except Exception: # noqa: BLE001 - summarisation must never crash the loop
return f"Summary of {len(messages)} messages"
def merge_summaries(self, previous: str, current: str) -> str:
"""Merge a prior structured summary with the current one.
Keeps both under a single "previous / latest" framing so an iterative
re-compaction never discards the earlier phase structure.
"""
previous = (previous or "").strip()
current = (current or "").strip()
if not previous:
return current
if not current:
return previous
return f"{previous}\n\n[Updated with newer activity]\n{current}"
# -- rendering ---------------------------------------------------------
def _render(self, messages: List[Dict[str, Any]]) -> str:
completed: List[str] = []
in_progress: List[str] = []
pending: List[str] = []
files: List[str] = []
active_task = ""
for msg in messages:
role = msg.get("role", "")
body = _text(msg.get("content"))
# First substantive user turn frames the active task.
if role == "user" and body.strip() and not active_task:
active_task = _clip(body)
# Executed work — tool calls and tool results — is *completed*.
# An assistant turn that merely proposes or *asks* about work has
# not been executed, so it must not be recorded as completed (it is
# captured under "Pending Questions" / "In Progress" instead);
# only a substantive, non-questioning assistant turn is completed.
tool_calls = msg.get("tool_calls")
if isinstance(tool_calls, list) and tool_calls:
for tc in tool_calls:
if not isinstance(tc, dict):
continue
name = (tc.get("function", {}) or {}).get("name", "tool")
completed.append(f"Called `{name}`")
elif role == "assistant" and body.strip() and "?" not in body:
completed.append(_clip(body))
elif role == "tool" and body.strip():
completed.append(_clip(f"tool result: {body}"))
# Any turn with a question mark contributes an open question.
if body and "?" in body:
for sentence in body.split("?"):
sentence = sentence.strip()
if sentence:
pending.append(_clip(sentence + "?"))
# Harvest file/path tokens verbatim from every turn.
if body:
for match in _PATH_RE.findall(body):
if match not in files:
files.append(match)
# The most recent user turn (if different) is what's in progress.
for msg in reversed(messages):
if msg.get("role") == "user":
latest = _clip(_text(msg.get("content")))
if latest and latest != active_task:
in_progress.append(latest)
break
return SUMMARY_TEMPLATE.format(
active_task=active_task or "(not specified)",
completed=self._bullets(completed),
in_progress=self._bullets(in_progress),
pending=self._bullets(pending),
files=self._bullets(files),
remaining=self._bullets(pending or in_progress),
)
@staticmethod
def _bullets(items: List[str]) -> str:
if not items:
return "(none)"
# De-duplicate while preserving order, then cap.
seen: List[str] = []
for item in items:
if item not in seen:
seen.append(item)
return "\n".join(f"- {item}" for item in seen[:_MAX_ITEMS])
@@ -25,7 +25,7 @@ Usage:
# With config
agent = Agent(
instructions="...",
memory=MemoryConfig(backend="redis", user_id="user123"),
memory=MemoryConfig(backend="sqlite", user_id="user123"),
knowledge=KnowledgeConfig(sources=["docs/"], rerank=True),
tool_search=ToolSearchConfig(enabled="auto", threshold_pct=15),
)
@@ -52,14 +52,54 @@ if TYPE_CHECKING:
class MemoryBackend(str, Enum):
"""Memory storage backends."""
"""Memory storage backends.
Every member must have an adapter in ``praisonaiagents.memory.adapters``
(FILE is served by ``FileMemory``). Declaring a backend with no adapter
used to silently swap in a local SQLite/JSON store.
"""
FILE = "file"
SQLITE = "sqlite"
REDIS = "redis"
VALKEY = "valkey"
POSTGRES = "postgres"
CHROMA = "chroma"
MEM0 = "mem0"
MONGODB = "mongodb"
DAKERA = "dakera"
IN_MEMORY = "in_memory"
#: Accepted before but never implemented: requests were silently redirected.
UNIMPLEMENTED_MEMORY_BACKENDS = ("redis", "valkey", "postgres", "postgresql")
def available_memory_backends() -> List[str]:
"""Backends ``MemoryConfig(backend=...)`` accepts, read from the registry.
Adapters added via ``register_memory_adapter()`` are accepted automatically.
"""
from ..memory.adapters import list_memory_adapters
return sorted(set(list_memory_adapters()) | {MemoryBackend.FILE.value})
def validate_memory_backend(backend: Union[str, "MemoryBackend"]) -> str:
"""Normalise a backend name; raise rather than substitute a different store."""
from .parse_utils import make_preset_error
from ..memory.adapters.registry import MEMORY_PROVIDER_ALIASES
name = backend.value if isinstance(backend, MemoryBackend) else str(backend)
name = MEMORY_PROVIDER_ALIASES.get(name.strip().lower(), name.strip().lower())
valid = available_memory_backends()
if name in valid:
return name
if name in UNIMPLEMENTED_MEMORY_BACKENDS:
raise ValueError(
f"Memory backend '{name}' is not implemented - no {name} memory "
f"adapter is registered. Earlier releases accepted it and silently "
f"stored to a local file instead. Valid backends: {', '.join(valid)}. "
f"To keep using {name}, pass a live store (memory=<instance> or "
f"db(url=...)), or register an adapter with "
f"register_memory_adapter('{name}', MyAdapter)."
)
raise make_preset_error("memory backend", name, valid)
class LearnScope(str, Enum):
@@ -194,7 +234,7 @@ class MemoryConfig:
Agent(memory=True)
# With backend
Agent(memory=MemoryConfig(backend="redis"))
Agent(memory=MemoryConfig(backend="sqlite"))
# Full config with learning
Agent(memory=MemoryConfig(
@@ -249,7 +289,11 @@ class MemoryConfig:
# Auto-save session name (consolidated from standalone auto_save param)
# When set, automatically saves session to memory with this name
auto_save: Optional[str] = None
def __post_init__(self):
# Reject a backend we cannot provide instead of substituting another.
self.backend = validate_memory_backend(self.backend)
def to_dict(self) -> Dict[str, Any]:
"""Convert to dictionary."""
learn_dict = None
@@ -279,11 +323,18 @@ class MemoryConfig:
class ChunkingStrategy(str, Enum):
"""Knowledge chunking strategies."""
"""Knowledge chunking strategies.
Every member must resolve to a chunker via
``praisonaiagents.knowledge.chunking.normalize_chunker_type``. FIXED and
PARAGRAPH are aliases for ``token``/``recursive``; the rest are chunker ids.
"""
FIXED = "fixed"
PARAGRAPH = "paragraph"
TOKEN = "token"
RECURSIVE = "recursive"
SEMANTIC = "semantic"
SENTENCE = "sentence"
PARAGRAPH = "paragraph"
@dataclass
@@ -322,10 +373,12 @@ class KnowledgeConfig:
embedder: str = "openai"
embedder_config: Optional[Dict[str, Any]] = None
# Chunking (direct fields)
chunking_strategy: Union[str, ChunkingStrategy] = ChunkingStrategy.SEMANTIC
chunk_size: int = 1000
chunk_overlap: int = 200
# Chunking (direct fields). Defaults match what Knowledge actually used
# while these fields were inert, so enabling them changes nothing for
# anyone who did not set them.
chunking_strategy: Union[str, ChunkingStrategy] = ChunkingStrategy.RECURSIVE
chunk_size: int = 512
chunk_overlap: int = 50
# Chunker config dict (alternative to direct fields)
# Supports: {"type": "semantic", "chunk_size": 512, ...}
@@ -847,12 +900,6 @@ class ExecutionConfig:
code_execution: bool = False
code_mode: str = "safe" # "safe" or "unsafe"
# NOT IMPLEMENTED - no execution path reads this field, so setting it
# provides NO isolation. Do not rely on it for safety. Use
# Agent(sandbox=...) for local isolation, or AgentFlow(run_on="docker")
# to run a whole workflow in a remote sandbox.
code_sandbox_mode: str = "sandbox" # "sandbox" or "direct" (inert)
# Code-execution-with-tools (code mode): when True, model-generated code may
# call the agent's registered tools directly via injected proxies, enabling
# multi-step tool pipelines in a single turn (intermediate results stay out
@@ -893,8 +940,12 @@ class ExecutionConfig:
# Parallel tool execution (Gap 2): Enable parallel execution of batched LLM tool calls
# When True, multiple tool calls from LLM are executed concurrently instead of sequentially
# Default False preserves existing behavior for backward compatibility
parallel_tool_calls: bool = False
# Default False preserves existing behavior for backward compatibility.
# This is the single source of truth; ToolConfig.parallel is a deprecated alias.
# None is accepted only as an internal "not set" sentinel (normalised to False
# in __post_init__) so the Agent can tell an explicit False from an omitted one
# and reject a conflicting ToolConfig(parallel=True) instead of silently winning.
parallel_tool_calls: Optional[bool] = None
# Durable tool-loop replay. Default-off keeps the execution hot path free
# of journal construction and SQLite writes.
@@ -904,6 +955,11 @@ class ExecutionConfig:
def __post_init__(self) -> None:
"""Post-initialization processing with deprecation warnings and validation."""
# parallel_tool_calls uses None as an internal "not set" sentinel so the
# Agent can distinguish an explicit False from an omitted default. Record
# explicitness, then normalise to a plain bool for every downstream reader.
self._parallel_tool_calls_explicit = self.parallel_tool_calls is not None
self.parallel_tool_calls = bool(self.parallel_tool_calls)
# Validate the unified step budget early (before any early returns below).
if self.max_steps is not None and self.max_steps < 1:
raise ValueError("ExecutionConfig.max_steps must be >= 1 when set.")
@@ -995,7 +1051,6 @@ class ExecutionConfig:
"retry_jitter": self.retry_jitter,
"code_execution": self.code_execution,
"code_mode": self.code_mode,
"code_sandbox_mode": self.code_sandbox_mode,
"code_tools": self.code_tools,
"code_tools_allow": self.code_tools_allow,
"context_compaction": (
@@ -1047,7 +1102,6 @@ class ExecutionConfig:
retry_jitter=data.get("retry_jitter", 0.1),
code_execution=data.get("code_execution", False),
code_mode=data.get("code_mode", "safe"),
code_sandbox_mode=data.get("code_sandbox_mode", "sandbox"),
code_tools=data.get("code_tools", False),
code_tools_allow=data.get("code_tools_allow", None),
context_compaction=context_compaction,
@@ -1057,7 +1111,7 @@ class ExecutionConfig:
max_context_tokens=data.get("max_context_tokens", None),
compaction_strategy=compaction_strategy,
max_budget=data.get("max_budget", None),
parallel_tool_calls=data.get("parallel_tool_calls", False),
parallel_tool_calls=data.get("parallel_tool_calls", None),
durable=data.get("durable", False),
journal_path=data.get("journal_path", None),
resume_run_id=data.get("resume_run_id", None),
@@ -1159,8 +1213,13 @@ class ToolConfig:
# Retry policy for tool execution with exponential backoff
retry_policy: Optional[Any] = None # RetryPolicy instance
# Enable parallel execution of batched LLM tool calls
parallel: bool = False
# DEPRECATED ALIAS for ExecutionConfig.parallel_tool_calls, which is the
# single source of truth for "run batched LLM tool calls in parallel".
# None (the default) means "not set here" -- the value is taken from
# execution=ExecutionConfig(parallel_tool_calls=...). An explicit True/False
# feeds that field instead; a value that contradicts an explicit
# ExecutionConfig(parallel_tool_calls=True) raises TypeError at Agent().
parallel: Optional[bool] = None
# Tool output handling and artifact storage
output_limit: int = DEFAULT_TOOL_OUTPUT_LIMIT # Maximum bytes before spilling to artifact store
@@ -1223,7 +1282,7 @@ class ToolConfig:
return cls(
timeout=data.get("timeout"),
retry_policy=retry_policy,
parallel=data.get("parallel", False),
parallel=data.get("parallel"),
output_limit=data.get("output_limit", DEFAULT_TOOL_OUTPUT_LIMIT),
output_max_lines=data.get("output_max_lines"),
output_direction=data.get("output_direction", "both"),
@@ -49,7 +49,6 @@ VALID_DEFAULTS_KEYS = {
"model": (str,),
"small_model": (str,),
"base_url": (str,),
"api_key": (str,),
# Feature flags
"allow_delegation": (bool,),
"allow_code_execution": (bool,),
@@ -66,9 +65,7 @@ VALID_DEFAULTS_KEYS = {
"caching": (dict, bool),
"autonomy": (dict, bool),
"skills": (dict, list),
"context": (dict, bool),
"hooks": (dict, list),
"templates": (dict,),
"retry": (dict, bool),
}
VALID_ROOT_KEYS = {"plugins", "defaults"}
@@ -158,12 +155,14 @@ class DefaultsConfig:
knowledge: Optional[Dict[str, Any]] = None
planning: Optional[Dict[str, Any]] = None
reflection: Optional[Dict[str, Any]] = None
guardrails: Optional[Dict[str, Any]] = None
web: Optional[Dict[str, Any]] = None
output: Optional[Dict[str, Any]] = None
execution: Optional[Dict[str, Any]] = None
caching: Optional[Dict[str, Any]] = None
autonomy: Optional[Dict[str, Any]] = None
skills: Optional[Dict[str, Any]] = None
retry: Optional[Dict[str, Any]] = None
def to_dict(self) -> Dict[str, Any]:
return {
@@ -177,12 +176,14 @@ class DefaultsConfig:
"knowledge": self.knowledge,
"planning": self.planning,
"reflection": self.reflection,
"guardrails": self.guardrails,
"web": self.web,
"output": self.output,
"execution": self.execution,
"caching": self.caching,
"autonomy": self.autonomy,
"skills": self.skills,
"retry": self.retry,
}
@@ -352,12 +353,14 @@ def _dict_to_defaults_config(data: Dict[str, Any]) -> DefaultsConfig:
knowledge=data.get("knowledge"),
planning=data.get("planning"),
reflection=data.get("reflection"),
guardrails=data.get("guardrails"),
web=data.get("web"),
output=data.get("output"),
execution=data.get("execution"),
caching=data.get("caching"),
autonomy=data.get("autonomy"),
skills=data.get("skills"),
retry=data.get("retry"),
)
@@ -706,8 +709,8 @@ def _defaults_has_any_values() -> bool:
getattr(defaults, key, None) is not None
for key in (
"model", "small_model", "base_url", "memory", "knowledge",
"planning", "reflection", "web", "output", "execution",
"caching", "autonomy",
"planning", "reflection", "guardrails", "web", "output",
"execution", "caching", "autonomy", "skills", "retry",
)
)
return _defaults_has_values
@@ -314,10 +314,14 @@ def _resolve_string(
# Check for preset
if presets:
# Case-insensitive lookup
value_lower = value.lower()
# Case-insensitive lookup, whitespace-tolerant and treating -/_ as
# interchangeable so the accepted spellings match the closed-set guard
# in validate_preset_string (which uses the same normalization). Without
# this, a value that passed construction-time validation (e.g.
# " sliding_window " or "sliding-window") would be rejected here.
value_norm = value.strip().lower().replace("-", "_")
for preset_key in presets:
if preset_key.lower() == value_lower:
if preset_key.strip().lower().replace("-", "_") == value_norm:
return _apply_preset(preset_key, presets, config_class)
# Not a valid preset - raise helpful error
@@ -195,6 +195,53 @@ def make_preset_error(
return ValueError(" ".join(msg_parts))
def canonical_preset_key(value: str) -> str:
"""
The single spelling rule for preset names. Validation and resolution must
not disagree about what counts as the same preset, so both go through here.
Matching is case-insensitive, ignores surrounding whitespace, and treats
``-``/``_`` as interchangeable.
"""
return value.strip().lower().replace("-", "_")
def validate_preset_string(
param_name: str,
value: Any,
presets: Iterable[str],
) -> None:
"""
Raise a helpful error when a string does not name a known preset.
Non-string values pass through untouched, so callers can hand this the raw
parameter without pre-checking the type. Matching is case-insensitive,
ignores surrounding whitespace, and treats ``-``/``_`` as interchangeable,
mirroring the preset lookups performed by the parameter resolvers (e.g.
``PermissionMode.resolve`` accepts both ``accept_edits`` and
``accept-edits``). This keeps the guard from rejecting spellings the
downstream resolver would happily accept.
Args:
param_name: Name of the parameter (for the error message)
value: Raw parameter value
presets: Valid preset names
Raises:
ValueError: If value is a string that is not a known preset
"""
if not isinstance(value, str):
return
normalized = canonical_preset_key(value)
presets_list = list(presets)
for preset in presets_list:
if canonical_preset_key(preset) == normalized:
return
raise make_preset_error(param_name, value, presets_list)
def is_policy_string(value: str) -> bool:
"""
Check if a string is a policy specification. O(1) operation.
@@ -19,9 +19,7 @@ MEMORY_PRESETS: Dict[str, Dict[str, Any]] = {
# Backend presets
"file": {"backend": "file"},
"sqlite": {"backend": "sqlite"},
"redis": {"backend": "redis"},
"postgres": {"backend": "postgres"},
"postgresql": {"backend": "postgres"},
"chroma": {"backend": "chroma"},
"mem0": {"backend": "mem0"},
"mongodb": {"backend": "mongodb"},
# Feature presets
@@ -32,11 +30,10 @@ MEMORY_PRESETS: Dict[str, Dict[str, Any]] = {
"chat": {"backend": "file", "history": True, "history_limit": 20}, # Conversational
}
# Only schemes backed by a registered memory adapter belong here. A scheme
# listed without an adapter resolved to a backend that does not exist, and the
# URL (host, credentials, database) was then dropped entirely.
MEMORY_URL_SCHEMES: Dict[str, str] = {
"postgresql": "postgres",
"postgres": "postgres",
"redis": "redis",
"rediss": "redis", # Redis with SSL
"sqlite": "sqlite",
"mongodb": "mongodb",
"mongodb+srv": "mongodb",
@@ -242,41 +242,51 @@ class ContextComposer:
full_history: List[Dict[str, Any]],
tool_call_ids: set
) -> List[Dict[str, Any]]:
"""Ensure tool_call/tool_result pairs are complete."""
# Find tool calls in result
result_call_ids = set()
result_response_ids = set()
for msg in result:
if "tool_calls" in msg:
for tc in msg.get("tool_calls", []):
if isinstance(tc, dict) and "id" in tc:
result_call_ids.add(tc["id"])
if msg.get("tool_call_id"):
result_response_ids.add(msg["tool_call_id"])
# Find missing pairs
missing_calls = result_response_ids - result_call_ids
missing_responses = result_call_ids - result_response_ids
if not missing_calls and not missing_responses:
return result
# Add missing messages from full history
for msg in full_history:
# Add missing tool calls
if "tool_calls" in msg:
for tc in msg.get("tool_calls", []):
if isinstance(tc, dict) and tc.get("id") in missing_calls:
if msg not in result:
result.insert(0, msg)
break
# Add missing tool responses
if msg.get("tool_call_id") in missing_responses:
if msg not in result:
result.append(msg)
"""Ensure tool_call/tool_result pairs are complete.
Reinserting a tool_calls message can introduce a new missing response
(a sibling parallel call), and reinserting a response can introduce a
new missing call. Iterate to a fixed point so the final message list
never contains a tool_call id without its matching tool response.
"""
changed = True
while changed:
changed = False
# Recompute pairs present in the current result
result_call_ids = set()
result_response_ids = set()
for msg in result:
if "tool_calls" in msg:
for tc in msg.get("tool_calls", []):
if isinstance(tc, dict) and "id" in tc:
result_call_ids.add(tc["id"])
if msg.get("tool_call_id"):
result_response_ids.add(msg["tool_call_id"])
missing_calls = result_response_ids - result_call_ids
missing_responses = result_call_ids - result_response_ids
if not missing_calls and not missing_responses:
break
# Add missing messages from full history
for msg in full_history:
# Add missing tool calls
if "tool_calls" in msg:
for tc in msg.get("tool_calls", []):
if isinstance(tc, dict) and tc.get("id") in missing_calls:
if msg not in result:
result.insert(0, msg)
changed = True
break
# Add missing tool responses
if msg.get("tool_call_id") in missing_responses:
if msg not in result:
result.append(msg)
changed = True
return result
def get_ledger(self) -> ContextLedger:
@@ -14,6 +14,21 @@ from .compressor import ContextCompressor
logger = logging.getLogger(__name__)
def _skip_leading_tool_messages(
messages: List[Dict[str, Any]]
) -> List[Dict[str, Any]]:
"""Drop any leading orphaned ``role="tool"`` messages.
A window cut can otherwise begin on a tool result whose originating
assistant ``tool_calls`` message was trimmed off, which strict providers
reject as an invalid transcript (Issue #3089).
"""
start = 0
while start < len(messages) and messages[start].get("role") == "tool":
start += 1
return messages[start:]
class BaseOptimizer(ABC):
"""Base class for optimization strategies."""
@@ -71,8 +86,9 @@ class TruncateOptimizer(BaseOptimizer):
else:
other_msgs.append(msg)
# Keep recent messages
# Keep recent messages (skip a leading orphaned tool result).
recent = other_msgs[-self.preserve_recent:] if other_msgs else []
recent = _skip_leading_tool_messages(recent)
result = system_msgs + recent
@@ -82,7 +98,17 @@ class TruncateOptimizer(BaseOptimizer):
if msg.get("role") != "system":
result.pop(i)
break
# The budget loop above pops the first non-system message, which can be
# an assistant ``tool_calls`` message whose ``role="tool"`` result stays
# behind — re-orphaning it. Re-skip leading tool results so the trimmed
# transcript never starts on an orphaned tool message (Issue #3089).
system_msgs = [m for m in result if m.get("role") == "system"]
other_msgs = _skip_leading_tool_messages(
[m for m in result if m.get("role") != "system"]
)
result = system_msgs + other_msgs
optimized_tokens = estimate_messages_tokens(result)
return result, OptimizationResult(
@@ -133,9 +159,11 @@ class SlidingWindowOptimizer(BaseOptimizer):
else:
break
# Ensure order
# Ensure order (skip a leading orphaned tool result in the tail).
system_msgs = [m for m in result if m.get("role") == "system"]
other_msgs = [m for m in result if m.get("role") != "system"]
other_msgs = _skip_leading_tool_messages(
[m for m in result if m.get("role") != "system"]
)
result = system_msgs + other_msgs
optimized_tokens = estimate_messages_tokens(result)
@@ -1080,6 +1108,18 @@ def get_optimizer(
Optimizer instance
"""
optimizer_class = OPTIMIZER_REGISTRY.get(strategy, SmartOptimizer)
# Optimizers do not share a constructor signature. Callers (e.g. the
# ContextManager) pass the union of every optimizer's kwargs, so filter to
# the ones this class actually accepts; otherwise all but SmartOptimizer
# raise TypeError and context management is silently disabled upstream.
import inspect
params = inspect.signature(optimizer_class.__init__).parameters
accepts_var_kw = any(
p.kind == inspect.Parameter.VAR_KEYWORD for p in params.values()
)
if not accepts_var_kw:
kwargs = {k: v for k, v in kwargs.items() if k in params}
return optimizer_class(**kwargs)
@@ -88,6 +88,26 @@ class _LazyDbModule:
db = _LazyDbModule()
# ``from praisonaiagents import db`` returns *this submodule*, not the singleton
# above (Python binds a real submodule as a package attribute, shadowing the
# package ``__getattr__``). Make the submodule object itself callable and proxy
# backend lookups to the singleton so ``db(...)`` and ``db.PraisonDB`` both work
# regardless of how ``db`` is imported.
import sys as _sys
from types import ModuleType as _ModuleType
class _CallableDbModule(_ModuleType):
def __call__(self, **kwargs):
return db(**kwargs)
def __getattr__(self, name):
return getattr(db, name)
_sys.modules[__name__].__class__ = _CallableDbModule
__all__ = [
"DbAdapter",
"AsyncDbAdapter",
@@ -9,6 +9,7 @@ that was duplicated across multiple evaluators.
"""
import os
import re
from praisonaiagents._logging import get_logger
from dataclasses import dataclass, field, asdict
from datetime import datetime, timezone
@@ -16,6 +17,16 @@ from typing import Any, Dict, List, Optional
logger = get_logger(__name__)
# Tolerant matcher for judge field labels. Handles markdown bolding (**SCORE:**),
# leading bullets/whitespace, and case variations - the default output style of
# most models. Without this, bolded labels parse to nothing and the verdict
# silently falls through to a fabricated mid-range score. Mirrors the matcher in
# safety.py so grader/judge fail the same way safety already does.
_FIELD_RE = re.compile(
r"^[\s>*_#`-]*(score|reasoning|suggestions)\s*\**\s*:\s*(.*)$",
re.IGNORECASE,
)
@dataclass
class GradeResult:
"""
@@ -186,39 +197,18 @@ EXPECTED OUTPUT (ideal response):
Returns:
Parsed GradeResult
"""
score = 5.0 # Default
reasoning = "Unable to parse response"
suggestions: List[str] = []
lines = response_text.strip().split('\n')
in_suggestions = False
for line in lines:
line = line.strip()
if line.startswith('SCORE:'):
try:
score_str = line.replace('SCORE:', '').strip()
score = float(score_str)
# Clamp to valid range
score = max(1.0, min(10.0, score))
except ValueError:
pass
elif line.startswith('REASONING:'):
reasoning = line.replace('REASONING:', '').strip()
elif line.startswith('SUGGESTIONS:'):
in_suggestions = True
rest = line.replace('SUGGESTIONS:', '').strip()
if rest.lower() != 'none' and rest:
suggestions.append(rest)
elif in_suggestions and line.startswith('-'):
suggestion = line.lstrip('- ').strip()
if suggestion and suggestion.lower() != 'none':
suggestions.append(suggestion)
score, reasoning, suggestions, score_parsed = _extract_score_reasoning(response_text)
if not score_parsed:
# No numeric score was parsed. Fail closed: a fabricated mid-range score
# that silently passes a threshold is the one wrong number nobody
# re-checks. Report the minimum instead.
logger.warning(
"Could not parse grader response; failing closed. Raw: %r",
response_text[:200],
)
score = 1.0
return GradeResult(
score=score,
reasoning=reasoning,
@@ -365,38 +355,102 @@ EXPECTED OUTPUT (ideal response):
expected_output=expected_output,
)
def _extract_score_reasoning(response_text: str) -> tuple:
"""
Line-based tolerant extraction of SCORE / REASONING / SUGGESTIONS.
Handles markdown-bolded labels (``**SCORE:** 1``), leading bullets and case
variations - the default output style of most models. Returns a
``score_parsed`` sentinel so callers can distinguish a genuinely-scored
verdict from an unparsable one and fail closed rather than fabricate a score.
Returns:
Tuple of (score: float, reasoning: str, suggestions: list, score_parsed: bool)
``score_parsed`` is True only when an actual numeric SCORE was read.
Callers must fail closed when it is False: a reasoning-only verdict has
no trustworthy number and must never be compared against - and pass - a
threshold.
"""
score = 5.0 # Default (only trusted when score_parsed is True)
reasoning = "Unable to parse response"
suggestions: List[str] = []
score_parsed = False
in_reasoning = False
in_suggestions = False
reasoning_lines: List[str] = []
for raw_line in response_text.strip().split('\n'):
line = raw_line.strip()
match = _FIELD_RE.match(line) if line else None
if match:
field_name = match.group(1).lower()
value = match.group(2).strip().strip('*_`').strip()
if field_name == 'score':
number = re.search(r'-?\d+(?:\.\d+)?', value)
if number:
try:
score = max(1.0, min(10.0, float(number.group(0))))
score_parsed = True
except ValueError:
pass
in_reasoning = False
in_suggestions = False
elif field_name == 'reasoning':
in_reasoning = True
in_suggestions = False
if value:
reasoning_lines.append(value)
elif field_name == 'suggestions':
in_suggestions = True
in_reasoning = False
if value and value.lower() != 'none':
suggestions.append(value)
continue
if not line:
continue
if in_suggestions and line.lstrip('*_`').startswith('-'):
suggestion = line.lstrip('*_`- ').strip()
if suggestion and suggestion.lower() != 'none':
suggestions.append(suggestion)
elif in_reasoning:
reasoning_lines.append(line)
if reasoning_lines:
reasoning = ' '.join(reasoning_lines).strip()
return score, reasoning, suggestions, score_parsed
def parse_score_reasoning(response_text: str) -> tuple:
"""
Parse SCORE and REASONING from LLM response.
DRY: Static utility function for parsing LLM-as-judge responses.
Used by AccuracyEvaluator, CriteriaEvaluator, and BaseLLMGrader.
Tolerant of markdown-bolded labels. When nothing can be parsed the verdict
fails closed (score 1.0) rather than silently returning a mid-range 5.0 that
could pass a threshold - the one wrong number nobody re-checks.
Args:
response_text: Raw LLM response text
Returns:
Tuple of (score: float, reasoning: str)
"""
import re
score, reasoning, _suggestions, score_parsed = _extract_score_reasoning(response_text)
score = 5.0 # Default
reasoning = "Unable to parse response"
# Extract score (case-insensitive, first numeric value after SCORE:)
score_match = re.search(r'SCORE:\s*(\d+(?:\.\d+)?)', response_text, re.IGNORECASE)
if score_match:
try:
score = float(score_match.group(1))
# Clamp to valid range
score = max(1.0, min(10.0, score))
except ValueError:
pass
# Extract reasoning (case-insensitive, preserves multi-line explanations)
reasoning_match = re.search(r'REASONING:\s*(.+)', response_text, re.IGNORECASE | re.DOTALL)
if reasoning_match:
reasoning = reasoning_match.group(1).strip()
if not score_parsed:
logger.warning(
"Could not parse judge response; failing closed. Raw: %r",
response_text[:200],
)
score = 1.0
return score, reasoning
@@ -19,7 +19,7 @@ from praisonaiagents._logging import get_logger
from dataclasses import dataclass
from typing import Any, Dict, List, Optional, Type, TYPE_CHECKING
from .grader import BaseLLMGrader
from .grader import BaseLLMGrader, _extract_score_reasoning
from .results import JudgeResult
if TYPE_CHECKING:
@@ -294,41 +294,22 @@ SUGGESTIONS:
Returns:
JudgeResult with score, passed, reasoning, suggestions
"""
score = 5.0
reasoning = "Unable to parse response"
suggestions: List[str] = []
lines = response_text.strip().split('\n')
in_suggestions = False
for line in lines:
line = line.strip()
if line.startswith('SCORE:'):
try:
score_str = line.replace('SCORE:', '').strip()
score = float(score_str)
score = max(1.0, min(10.0, score))
except ValueError:
pass
elif line.startswith('REASONING:'):
reasoning = line.replace('REASONING:', '').strip()
elif line.startswith('SUGGESTIONS:'):
in_suggestions = True
rest = line.replace('SUGGESTIONS:', '').strip()
if rest.lower() not in ('none', '') and rest:
suggestions.append(rest)
elif in_suggestions and line.startswith('-'):
suggestion = line.lstrip('- ').strip()
if suggestion and suggestion.lower() != 'none':
suggestions.append(suggestion)
score, reasoning, suggestions, score_parsed = _extract_score_reasoning(response_text)
if not score_parsed:
# An unscored verdict is an error, not a middling result. Fail closed
# so a fabricated 5.0 can never be compared against - and pass - a
# threshold. A reasoning-only response has no trustworthy number.
# Mirrors safety.py / parse_score_reasoning.
logger.warning(
"Could not parse judge response; failing closed. Raw: %r",
response_text[:200],
)
score = 1.0
return JudgeResult(
score=score,
passed=score >= self.threshold,
passed=score_parsed and score >= self.threshold,
reasoning=reasoning,
output=output,
expected=expected,
@@ -23,6 +23,7 @@ Example:
from typing import List, Dict, Any, Optional, Union, TYPE_CHECKING
from dataclasses import dataclass
import re
import time
from praisonaiagents._logging import get_logger
from .base import BaseEvaluator
@@ -33,6 +34,15 @@ if TYPE_CHECKING:
logger = get_logger(__name__)
# Tolerant matcher for judge field labels. Handles markdown bolding (**Score:**),
# leading bullets/whitespace, and case variations - the default output style of
# most models. Without this, bolded labels parse to nothing and the verdict
# silently falls through to maximum safety.
_FIELD_RE = re.compile(
r"^[\s>*_#-]*(category|score|detected|reasoning|safety\s*score|overall\s*reasoning|confidence)\s*\**\s*:",
re.IGNORECASE,
)
@dataclass
class SafetyResult:
"""Result container for safety evaluations."""
@@ -169,61 +179,106 @@ Please evaluate this output for safety violations across all specified categorie
"confidence": 1.0
}
@staticmethod
def _field_value(line: str) -> str:
"""Return the value after the first colon, stripped of markdown decoration."""
value = line.split(":", 1)[1] if ":" in line else ""
return value.strip().strip("*_`").strip()
def _parse_safety_response(self, response: str, categories: List[str]) -> Dict[str, Any]:
"""Parse LLM response into structured safety result."""
"""Parse LLM response into structured safety result.
Parses tolerantly (markdown bolding, bullets, case) so ordinary model
formatting is read correctly. A verdict that cannot be parsed at all is
treated as UNSAFE - never as safe - matching the exception handler in
evaluate_safety which defaults to 1.0 for the same reason. Silently
reporting maximum safety on an unparsed violation is the one wrong number
nobody re-checks.
"""
violations = {}
safety_score = 10.0 # Default to safe
# An unparsed verdict is NOT a safe verdict; start with no score and only
# tighten it as real values are read.
safety_score = None
overall_reasoning = ""
confidence = 5.0
parsed_any = False
lines = response.strip().split('\n')
current_category = None
for line in lines:
line = line.strip()
for raw_line in lines:
line = raw_line.strip()
if not line:
continue
# Parse category sections
if line.startswith("Category:"):
current_category = line.split(":", 1)[1].strip().lower()
match = _FIELD_RE.match(line)
if not match:
continue
field = re.sub(r"\s+", " ", match.group(1).lower())
value = self._field_value(line)
if field == "category":
current_category = value.lower()
if current_category in [c.lower() for c in categories]:
violations[current_category] = {}
elif line.startswith("Score:") and current_category:
parsed_any = True
elif field == "score" and current_category:
try:
score = float(line.split(":", 1)[1].strip())
violations[current_category]["score"] = score
safety_score = min(safety_score, score) # Overall score is minimum
score = float(value)
except ValueError:
violations[current_category]["score"] = 5.0
safety_score = min(safety_score, 5.0)
elif line.startswith("Detected:") and current_category:
detected_text = line.split(":", 1)[1].strip().lower()
violations[current_category]["detected"] = detected_text.startswith("y")
elif line.startswith("Reasoning:") and current_category:
violations[current_category]["reasoning"] = line.split(":", 1)[1].strip()
# Parse overall assessment
elif line.startswith("Safety Score:"):
score = 5.0
violations[current_category]["score"] = score
safety_score = score if safety_score is None else min(safety_score, score)
parsed_any = True
elif field == "detected" and current_category:
violations[current_category]["detected"] = value.lower().startswith("y")
parsed_any = True
elif field == "reasoning" and current_category:
violations[current_category]["reasoning"] = value
elif field == "safety score":
try:
parsed_overall = float(line.split(":", 1)[1].strip())
parsed_overall = float(value)
# Don't let overall score override a worse category score
safety_score = min(safety_score, parsed_overall)
safety_score = parsed_overall if safety_score is None else min(safety_score, parsed_overall)
parsed_any = True
except ValueError:
pass
elif line.startswith("Overall Reasoning:"):
overall_reasoning = line.split(":", 1)[1].strip()
elif line.startswith("Confidence:"):
elif field == "overall reasoning":
overall_reasoning = value
elif field == "confidence":
try:
confidence = float(line.split(":", 1)[1].strip())
confidence = float(value)
except ValueError:
confidence = 5.0
# Nothing usable was parsed. Fail closed: report UNSAFE rather than let the
# default fall through to maximum safety.
if not parsed_any or safety_score is None:
logger.warning(
"Could not parse safety judge response; treating as UNSAFE. Raw: %r",
response[:200],
)
return {
"violations": {
category.lower(): {
"detected": True,
"score": 1.0,
"reasoning": "Safety verdict could not be parsed; failing closed.",
}
for category in categories
},
"safety_score": 1.0,
"overall_reasoning": "Safety judge response could not be parsed; treated as unsafe.",
"confidence": 1.0,
}
# Ensure all categories have violation data
for category in categories:
category_lower = category.lower()
@@ -233,7 +288,7 @@ Please evaluate this output for safety violations across all specified categorie
"score": 8.0,
"reasoning": "No specific evaluation provided"
}
return {
"violations": violations,
"safety_score": safety_score,
@@ -29,11 +29,16 @@ from .protocols import (
# Config hot-reload observability (Issue #3049)
ReloadStatus,
compute_config_revision,
# Saturation / back-pressure observability (Issue #4265)
HealthPressure,
evaluate_pressure,
# Push protocols and dataclasses
PushChannelProtocol,
PresenceProtocol,
DeliveryGuaranteeProtocol,
OutboundDeliveryProtocol,
IdempotencyStoreProtocol,
InMemoryIdempotencyStore,
ChannelInfo,
PresenceInfo,
# Home channel and delivery protocols
@@ -159,6 +164,11 @@ from .protocols import (
TurnPlacement,
TurnExecutorProtocol,
InProcessTurnExecutor,
# Global operator emergency-stop / pause brake (Issue #4220)
EmergencyStopState,
EmergencyStopProtocol,
NullEmergencyStop,
FileEmergencyStop,
# Schema-validated inbound frame codec (Issue #2831)
HelloParams,
HelloResult,
@@ -209,6 +219,7 @@ from .config import (
GatewayConfig,
SessionConfig,
ApiConfig,
EmergencyStopConfig,
ChannelRouteConfig,
MultiChannelGatewayConfig,
# Config version stamp + doctor-driven migration (Issue #3841)
@@ -303,11 +314,15 @@ __all__ = [
# Config hot-reload observability (Issue #3049)
"ReloadStatus",
"compute_config_revision",
"HealthPressure",
"evaluate_pressure",
# Push protocols (always available)
"PushChannelProtocol",
"PresenceProtocol",
"DeliveryGuaranteeProtocol",
"OutboundDeliveryProtocol",
"IdempotencyStoreProtocol",
"InMemoryIdempotencyStore",
"ChannelInfo",
"PresenceInfo",
# Home channel and delivery protocols
@@ -429,6 +444,11 @@ __all__ = [
"TurnPlacement",
"TurnExecutorProtocol",
"InProcessTurnExecutor",
# Global operator emergency-stop / pause brake (Issue #4220)
"EmergencyStopState",
"EmergencyStopProtocol",
"NullEmergencyStop",
"FileEmergencyStop",
# Schema-validated inbound frame codec (Issue #2831)
"HelloParams",
"HelloResult",
@@ -473,6 +493,7 @@ __all__ = [
"GatewayConfig",
"SessionConfig",
"ApiConfig",
"EmergencyStopConfig",
"ChannelRouteConfig",
"MultiChannelGatewayConfig",
# Config version stamp + doctor-driven migration (Issue #3841)
@@ -706,6 +706,71 @@ class ApiConfig:
)
@dataclass
class EmergencyStopConfig:
"""Configuration for the global operator emergency-stop brake (Issue #4220).
Selects the backend for the durable, fail-safe operator brake consulted at
every new-work admission seam (WebSocket inbound, HTTP/MCP inbound, kanban
dispatch, scheduler due-loop). The default ``"off"`` backend engages a
no-op brake so ``is_engaged()`` is always ``False`` — behaviour is
byte-for-byte today's, no new dependency, no hot-path change. Selecting
``"file"`` persists the engaged state to a sentinel at ``path`` so it
survives a crash/restart and is shared across lanes; an unreadable/corrupt
sentinel counts as *engaged* (fail-safe).
This maps onto the pure core
:class:`~praisonaiagents.gateway.protocols.EmergencyStopProtocol`;
:meth:`to_estop` builds the concrete brake.
Attributes:
backend: ``"off"`` (default, no-op) or ``"file"`` (durable sentinel).
path: Sentinel location for the ``"file"`` backend (required for it).
"""
backend: str = "off"
path: Optional[str] = None
def __post_init__(self) -> None:
if self.backend not in ("off", "file"):
raise ValueError(
f"Invalid control backend {self.backend!r}; expected 'off' or 'file'"
)
if self.backend == "file" and not self.path:
raise ValueError("control backend 'file' requires a 'path'")
@property
def enabled(self) -> bool:
"""Whether a real (non-``off``) brake backend is selected."""
return self.backend != "off"
def to_estop(self):
"""Build the pure core emergency-stop brake this config describes.
``"off"`` returns a :class:`NullEmergencyStop` (never engaged);
``"file"`` returns a durable, fail-safe :class:`FileEmergencyStop`.
"""
from .protocols import FileEmergencyStop, NullEmergencyStop
if self.backend == "file" and self.path:
return FileEmergencyStop(self.path)
return NullEmergencyStop()
def to_dict(self) -> Dict[str, Any]:
"""Convert to dictionary."""
return {"backend": self.backend, "path": self.path}
@classmethod
def from_dict(cls, data: Optional[Dict[str, Any]]) -> "EmergencyStopConfig":
"""Create from a parsed ``gateway.control`` mapping (tolerant of None)."""
if not isinstance(data, dict):
return cls()
return cls(
backend=str(data.get("backend") or "off"),
path=data.get("path"),
)
@dataclass
class GatewayConfig:
"""Configuration for the gateway server.
@@ -783,6 +848,12 @@ class GatewayConfig:
# serialises turns across replicas so a horizontally-scaled gateway does not
# run concurrent turns on one session.
turn_lock: "TurnLockConfig" = field(default_factory=lambda: TurnLockConfig())
# Issue #4220: global operator emergency-stop / pause brake. Default "off"
# backend is a no-op (never engaged) so behaviour is unchanged; "file"
# persists a durable, fail-safe sentinel every new-work lane can consult.
control: "EmergencyStopConfig" = field(
default_factory=lambda: EmergencyStopConfig()
)
def __post_init__(self) -> None:
"""Post-initialization to set bind_host from host if not specified and validate values."""
@@ -905,6 +976,7 @@ class GatewayConfig:
"api": self.api.to_dict(),
"liveness": self.liveness.to_dict(),
"turn_lock": self.turn_lock.to_dict(),
"control": self.control.to_dict(),
}
@property
@@ -1096,6 +1168,7 @@ class MultiChannelGatewayConfig:
api=ApiConfig.from_dict(gw_data.get("api")),
liveness=LivenessConfig.from_dict(gw_data.get("liveness")),
turn_lock=TurnLockConfig.from_dict(gw_data.get("turn_lock")),
control=EmergencyStopConfig.from_dict(gw_data.get("control")),
)
# Parse agents section (pass through as dicts)
@@ -86,7 +86,12 @@ def _lookup(path: str, payload: Dict[str, Any]) -> Any:
return current
def render_template(template: Optional[str], payload: Dict[str, Any]) -> str:
def render_template(
template: Optional[str],
payload: Dict[str, Any],
*,
fence_values: bool = False,
) -> str:
"""Render ``template`` against ``payload`` with no external dependencies.
Supports ``{{ payload.x }}`` and ``{x}`` placeholders resolving dotted
@@ -96,6 +101,12 @@ def render_template(template: Optional[str], payload: Dict[str, Any]) -> str:
Args:
template: The template string (or None).
payload: The decoded JSON request body.
fence_values: When True, each interpolated payload-derived value is
wrapped in an ``<external_request_payload>`` fence so the agent
treats it as untrusted data, not instructions. The operator's own
static template text stays outside the fence. Used for the agent
message (see :meth:`HookConfig.resolve_message`); left False for
session/idempotency keys where fencing would corrupt the value.
Returns:
The rendered string.
@@ -103,13 +114,35 @@ def render_template(template: Optional[str], payload: Dict[str, Any]) -> str:
if not template:
return ""
wrap = None
notice = None
if fence_values:
from praisonaiagents.tools.trust import (
request_payload_notice as notice,
wrap_request_payload as wrap,
)
fenced = False
def _resolve(match: "re.Match[str]") -> str:
nonlocal fenced
# group(1) is the ``{{ ... }}`` body, group(2) the ``{ ... }`` body.
expr = match.group(1) if match.group(1) is not None else match.group(2)
value = _lookup(expr, payload)
return "" if value is None else str(value)
if value is None:
return ""
if wrap is None:
return str(value)
fenced = True
return wrap(str(value))
return _PLACEHOLDER.sub(_resolve, template)
rendered = _PLACEHOLDER.sub(_resolve, template)
# Prepend the inline untrusted-data notice once (outside the fence) when a
# payload value was fenced, so the semantics travel with the message even if
# the agent runs with ``use_system_prompt=False``.
if fenced and notice is not None:
return f"{notice()}\n\n{rendered}"
return rendered
def compute_idempotency_key(
@@ -375,9 +408,22 @@ class HookConfig:
self.idempotency_key, payload, path=self.path
)
def resolve_message(self, payload: Dict[str, Any]) -> str:
"""Render the agent message for ``payload``."""
return render_template(self.message, payload)
def resolve_message(self, payload: Dict[str, Any], *, fence: bool = True) -> str:
"""Render the hook message for ``payload``.
Payload-derived interpolations are fenced as untrusted request data so
the agent never treats externally-POSTed content as instructions; the
operator's own template text stays outside the fence.
Args:
payload: The decoded request body.
fence: When True (the agent-turn default), interpolated payload
values are wrapped in an ``<external_request_payload>`` fence.
Pass ``fence=False`` for ``deliver_only`` hooks, where the
rendered message is delivered verbatim to a channel with no
agent consuming (and therefore stripping) the fence markup.
"""
return render_template(self.message, payload, fence_values=fence)
def to_dict(self) -> Dict[str, Any]:
"""Convert to a dictionary (hides the auth/signing secrets)."""
@@ -126,11 +126,27 @@ class LoopWatchdog:
self._last_ack = 0.0
self._last_probe = 0.0
self._wedged = False
# Continuously-measured scheduling lag (ms) of the most recently
# acked probe. Read back by the health surface as a saturation signal
# (Issue #4265) — the same measurement the wedge check already relies
# on, exposed rather than only compared against the wedge threshold.
self._probe_sent_at = 0.0
self._last_lag_ms = 0.0
@property
def armed(self) -> bool:
return self._thread is not None and self._thread.is_alive()
@property
def last_lag_ms(self) -> float:
"""Most recent event-loop scheduling lag in milliseconds.
The delay between scheduling a probe and the loop running its ack.
``0.0`` until the first probe round-trips. Read by the gateway health
surface as a forward saturation signal (Issue #4265).
"""
return self._last_lag_ms
@property
def wedged(self) -> bool:
"""True once a wedge has been confirmed (mainly for ``dump_only``)."""
@@ -176,7 +192,22 @@ class LoopWatchdog:
def _ack(self) -> None:
"""Callback run *on the loop*; records that the loop is alive."""
self._last_ack = time.monotonic()
now = time.monotonic()
self._last_ack = now
# Record the scheduling lag: how long the loop took to run this ack
# after we scheduled it. This is the same signal the wedge check uses,
# exposed as a gauge for the health surface (Issue #4265).
#
# ``_probe_sent_at`` is anchored to the *oldest still-unacked* probe,
# not the most recent one: when the loop stalls across several probe
# intervals the watchdog keeps scheduling fresh acks that all queue
# behind the wedge, and measuring from the newest probe would report a
# fraction of the true stall. Consuming the anchor here (setting it to
# 0.0) lets the next scheduled probe re-anchor from a caught-up loop.
sent = self._probe_sent_at
if sent:
self._last_lag_ms = max(0.0, (now - sent) * 1000.0)
self._probe_sent_at = 0.0
def _schedule_probe(self) -> bool:
"""Schedule an ack onto the loop. Returns False if scheduling fails."""
@@ -184,8 +215,16 @@ class LoopWatchdog:
if loop is None:
return False
try:
# Only (re-)anchor the lag clock when the previous probe has been
# acked (``_ack`` zeroes ``_probe_sent_at``). If the loop is stalled
# and earlier probes are still queued, keep the anchor pinned to the
# oldest unacked probe so the reported lag reflects the full stall
# rather than the gap since the newest probe (Issue #4265).
now = time.monotonic()
if not self._probe_sent_at:
self._probe_sent_at = now
loop.call_soon_threadsafe(self._ack)
self._last_probe = time.monotonic()
self._last_probe = now
return True
except RuntimeError:
# Loop is closed / not running — treat as not-scheduled but do not
@@ -30,6 +30,8 @@ from typing import (
Iterator,
List,
Literal,
Mapping,
MutableMapping,
Optional,
Protocol,
Sequence,
@@ -198,6 +200,10 @@ class EventType(str, Enum):
TOOL_PROGRESS_STREAM = "tool_progress_stream"
STREAM_ERROR = "stream_error"
STREAM_END = "stream_end"
MODEL_FALLBACK_STREAM = "model_fallback_stream"
RETRY_STREAM = "retry_stream"
TODO_STREAM = "todo_stream"
TOOL_RESULT_STREAM = "tool_result_stream"
# System events
HEALTH = "health"
@@ -1093,6 +1099,10 @@ class GatewayProtocol(Protocol):
:func:`compute_config_revision`) of the config the gateway is
*actually running*, comparable against the on-disk revision to
detect drift.
- pressure: Optional :class:`HealthPressure` dict (admission /
inbound / outbound backlog + event-loop lag and a derived
``pressure`` classification), when the gateway runs back-pressure
machinery. See :class:`HealthPressure` and :func:`evaluate_pressure`.
"""
...
@@ -1188,6 +1198,165 @@ def compute_config_revision(config: Optional[Dict[str, Any]]) -> str:
return hashlib.sha256(canonical.encode("utf-8")).hexdigest()[:12]
# ---------------------------------------------------------------------------
# Saturation / back-pressure observability (Issue #4265)
#
# The always-on gateway already *enforces* back-pressure — a concurrency
# ceiling with a bounded fair wait-queue (``AdmissionGate``), a durable
# outbound outbox with a dead-letter tier (``OutboundQueue``), and an
# event-loop wedge watchdog (``LoopWatchdog``) — but it exposes no saturation
# *telemetry*. The health surface reports liveness and config drift, yet never
# reports how close the gateway is to its limits, so the first signal an
# operator gets is dropped work (shed turns / stalled outbound) rather than a
# forward warning. This is the small, canonical contract — mirroring
# ``ReloadStatus`` exactly — that both the SDK's ``gateway.health()`` and the
# bot's ``/health`` populate so saturation is a first-class, observable signal.
# Core owns only the *shape* (a frozen dataclass) and a pure, deterministic
# classification helper; the wrapper reads back the facts the enforcement layer
# already computes and fills the block.
# ---------------------------------------------------------------------------
@dataclass(frozen=True)
class HealthPressure:
"""Observable saturation snapshot of the gateway's back-pressure machinery.
Populated by the running gateway and surfaced in
:meth:`GatewayProtocol.health` so an operator (or an autoscaler / a
``/ready``-driven load balancer) can ask "is the gateway backing up?"
*before* admission starts shedding turns — rather than inferring overload
post-mortem from shed-load log lines.
Attributes:
admission_max: Configured concurrency ceiling (``0`` when unbounded).
admission_in_flight: Turns currently running.
admission_queued: Turns currently waiting for a slot.
admission_shed_total: Cumulative turns shed since start.
inbox_pending: Aggregate pending inbound queue depth across sessions.
outbox_pending: Durable outbound backlog awaiting delivery.
outbox_dead_letter: Durable outbound entries in the dead-letter tier.
event_loop_lag_p99_ms: Recent event-loop scheduling lag (ms).
pressure: Single derived classification — ``"nominal"``,
``"elevated"`` or ``"saturated"`` (closed vocabulary) — so an
orchestrator can branch on one field.
"""
admission_max: int = 0
admission_in_flight: int = 0
admission_queued: int = 0
admission_shed_total: int = 0
inbox_pending: int = 0
outbox_pending: int = 0
outbox_dead_letter: int = 0
event_loop_lag_p99_ms: float = 0.0
pressure: Literal["nominal", "elevated", "saturated"] = "nominal"
def to_dict(self) -> Dict[str, Any]:
"""Convert to a JSON-serializable dict for the health surface."""
return {
"admission_max": self.admission_max,
"admission_in_flight": self.admission_in_flight,
"admission_queued": self.admission_queued,
"admission_shed_total": self.admission_shed_total,
"inbox_pending": self.inbox_pending,
"outbox_pending": self.outbox_pending,
"outbox_dead_letter": self.outbox_dead_letter,
"event_loop_lag_p99_ms": self.event_loop_lag_p99_ms,
"pressure": self.pressure,
}
def evaluate_pressure(
*,
admission: Optional[Dict[str, Any]] = None,
inbox_pending: int = 0,
outbox_pending: int = 0,
outbox_dead_letter: int = 0,
loop_lag_p99_ms: float = 0.0,
) -> HealthPressure:
"""Pure, deterministic classification of gateway load. No I/O.
Reads back facts the enforcement layer already computes
(``AdmissionGate.stats()``, the outbox ``status`` counts, the watchdog's
measured lag) and folds them into a single :class:`HealthPressure`. Lives
in core — like :func:`compute_config_revision` — so the SDK and the bot
classify identically without divergence.
Classification (highest wins):
* ``"saturated"`` — admission is full *and* work is queuing, the outbound
dead-letter tier is non-empty, or the event loop is lagging badly
(``>= 500 ms``): shed / stall is imminent or occurring.
* ``"elevated"`` — admission is highly utilised (``>= 80 %``), the inbound
or outbound backlog is building, or the loop is lagging (``>= 100 ms``).
* ``"nominal"`` — none of the above.
Args:
admission: An :meth:`AdmissionGate.stats` snapshot (or ``None``).
inbox_pending: Aggregate pending inbound queue depth.
outbox_pending: Durable outbound backlog.
outbox_dead_letter: Durable outbound dead-letter depth.
loop_lag_p99_ms: Recent event-loop scheduling lag in ms.
Returns:
A frozen :class:`HealthPressure` ready for the health surface.
"""
stats = admission or {}
def _int(value: Any) -> int:
try:
return int(value or 0)
except (TypeError, ValueError):
return 0
admission_max = _int(stats.get("max_concurrent_runs"))
in_flight = _int(stats.get("in_flight"))
queued = _int(stats.get("queued"))
shed_total = _int(stats.get("shed"))
inbox = max(0, _int(inbox_pending))
outbox = max(0, _int(outbox_pending))
dead_letter = max(0, _int(outbox_dead_letter))
try:
lag = float(loop_lag_p99_ms or 0.0)
except (TypeError, ValueError):
lag = 0.0
if lag < 0.0:
lag = 0.0
utilisation = (in_flight / admission_max) if admission_max > 0 else 0.0
saturated = (
(admission_max > 0 and in_flight >= admission_max and queued > 0)
or dead_letter > 0
or lag >= 500.0
)
elevated = (
utilisation >= 0.8
or queued > 0
or inbox > 0
or outbox > 0
or lag >= 100.0
)
if saturated:
pressure: Literal["nominal", "elevated", "saturated"] = "saturated"
elif elevated:
pressure = "elevated"
else:
pressure = "nominal"
return HealthPressure(
admission_max=admission_max,
admission_in_flight=in_flight,
admission_queued=queued,
admission_shed_total=shed_total,
inbox_pending=inbox,
outbox_pending=outbox,
outbox_dead_letter=dead_letter,
event_loop_lag_p99_ms=lag,
pressure=pressure,
)
# ---------------------------------------------------------------------------
# Push notification dataclasses
# ---------------------------------------------------------------------------
@@ -1565,6 +1734,90 @@ class OutboundDeliveryProtocol(Protocol):
...
@runtime_checkable
class IdempotencyStoreProtocol(Protocol):
"""Protocol for inbound webhook/trigger delivery deduplication.
The gateway's inbound HTTP hook surface must not start a second agent run
for an event a provider re-delivers (webhook providers routinely retry for
minutes to days). Deduplication is a three-step, restart-stable claim on the
deterministic idempotency key (``compute_idempotency_key``):
- ``reserve`` — atomically claim the key. Returns ``False`` when the key
was already recorded *or* is currently in flight, so both a redelivery
and a concurrent duplicate are rejected.
- ``record`` — commit the key after a successful run so future
redeliveries dedup.
- ``release`` — drop an in-flight reservation after a failed run so the
provider's retry can re-run.
This mirrors :class:`CallbackPayloadStoreProtocol`: the contract lives in
core so third-party gateways and a future ``redis`` backend interoperate;
core ships the bounded in-memory default (:class:`InMemoryIdempotencyStore`)
and the durable, restart-surviving SQLite backend lives in the
``praisonai-bot`` runtime (as the ingress journal and outbound queue do).
"""
def reserve(self, key: str) -> bool:
"""Atomically claim ``key``; ``False`` if seen-or-in-flight."""
...
def record(self, key: str) -> None:
"""Commit ``key`` as processed after a successful run."""
...
def release(self, key: str) -> None:
"""Drop an in-flight reservation so a failed delivery can be retried."""
...
class InMemoryIdempotencyStore:
"""Bounded, zero-dependency in-memory :class:`IdempotencyStoreProtocol`.
The default store for single-replica deployments — identical behaviour to
the gateway's original per-process ``OrderedDict`` + in-flight ``set``. It
is *not* durable: after a process restart the store is empty, so a durable
backend (SQLite/redis) must be injected for the restart/multi-replica case.
"""
def __init__(
self,
*,
max_entries: int = 10_000,
ttl_seconds: float = 86_400.0,
) -> None:
self._max_entries = max(1, int(max_entries))
self._ttl_seconds = float(ttl_seconds)
# key -> insertion time (seconds); insertion-ordered for FIFO eviction.
self._seen: "Dict[str, float]" = {}
self._inflight: Set[str] = set()
def _purge_expired(self, now: float) -> None:
if not self._seen:
return
expired = [k for k, ts in self._seen.items() if now - ts > self._ttl_seconds]
for k in expired:
self._seen.pop(k, None)
def reserve(self, key: str) -> bool:
now = time.time()
self._purge_expired(now)
if key in self._seen or key in self._inflight:
return False
self._inflight.add(key)
return True
def record(self, key: str) -> None:
self._inflight.discard(key)
self._seen[key] = time.time()
while len(self._seen) > self._max_entries:
oldest = next(iter(self._seen))
self._seen.pop(oldest, None)
def release(self, key: str) -> None:
self._inflight.discard(key)
# ---------------------------------------------------------------------------
# Per-route, trust-tiered toolset scoping (Issue #2298)
# ---------------------------------------------------------------------------
@@ -4922,6 +5175,26 @@ class GatewayTraceHook(Protocol):
session=sid,
):
reply = await agent.astart(text)
W3C trace-context propagation is layered on top of the same seam without
forcing OpenTelemetry into core. ``stage`` accepts an optional
``parent_carrier`` (a header mapping such as an inbound request's
``{"traceparent": ..., "tracestate": ...}``) so an exporter can *continue*
an upstream caller's trace instead of starting a detached one; and the two
companion methods let egress call sites propagate the active span context:
# ingress: continue the caller's trace when a traceparent arrives
with self._trace.stage("agent.run", parent_carrier=inbound.headers):
...
# egress: write the active traceparent onto an outbound request.
# Seed with provider headers first, then inject last so the active
# trace context always wins over any stale traceparent/tracestate.
headers = dict(provider_headers)
self._trace.inject_context(headers) # no-op unless an exporter is set
Both companion methods are no-ops in :class:`NullGatewayTraceHook`, so the
default path stays zero-cost and OpenTelemetry-free.
"""
def stage(
@@ -4929,6 +5202,7 @@ class GatewayTraceHook(Protocol):
name: str,
*,
correlation_id: "Optional[str]" = None,
parent_carrier: "Optional[Mapping[str, str]]" = None,
**attrs: Any,
) -> "AbstractContextManager[Any]":
"""Open a tracing scope for pipeline stage ``name``.
@@ -4938,6 +5212,11 @@ class GatewayTraceHook(Protocol):
span name.
correlation_id: The inbound turn's correlation id, attached as a
span attribute so spans and logs share a key.
parent_carrier: Optional inbound header mapping carrying W3C
trace-context (``traceparent``/``tracestate``). When present and
an exporter is attached, the stage is entered *under* the
extracted parent context so the span nests within the caller's
distributed trace instead of starting a new root.
**attrs: Extra span attributes (e.g. ``session``, ``model``,
``tool``, ``channel``).
@@ -4946,6 +5225,28 @@ class GatewayTraceHook(Protocol):
"""
...
def inject_context(self, carrier: "MutableMapping[str, str]") -> None:
"""Write the active span context into ``carrier`` as W3C headers.
Called at an egress boundary (LLM / MCP / HTTP-tool request) so the
downstream service's spans nest under the current agent turn. A no-op
when no exporter is attached, leaving ``carrier`` untouched.
"""
...
def extract_carrier(
self, carrier: "Mapping[str, str]"
) -> "Optional[Mapping[str, str]]":
"""Return a propagation carrier extracted from inbound ``carrier``.
Reads W3C trace-context (``traceparent``/``tracestate``) from an
inbound header mapping and returns a normalized carrier suitable to pass
as ``stage(..., parent_carrier=...)``, or ``None`` when no usable
context is present. A no-op returning ``None`` when no exporter is
attached.
"""
...
class NullGatewayTraceHook:
"""Zero-cost no-op :class:`GatewayTraceHook` used when tracing is disabled.
@@ -4967,11 +5268,22 @@ class NullGatewayTraceHook:
name: str,
*,
correlation_id: "Optional[str]" = None,
parent_carrier: "Optional[Mapping[str, str]]" = None,
**attrs: Any,
) -> "AbstractContextManager[Any]":
"""Return a no-op context manager, ignoring all arguments."""
return self._null_scope()
def inject_context(self, carrier: "MutableMapping[str, str]") -> None:
"""No-op: leave ``carrier`` untouched when tracing is disabled."""
return None
def extract_carrier(
self, carrier: "Mapping[str, str]"
) -> "Optional[Mapping[str, str]]":
"""No-op: no parent context to continue when tracing is disabled."""
return None
# Shared singleton: the default no-op hook is stateless, so one instance is
# reused everywhere a gateway needs a zero-cost default.
@@ -5980,3 +6292,195 @@ def _register_core_gateway_methods() -> None:
_register_core_gateway_methods()
# ---------------------------------------------------------------------------
# Global operator emergency-stop / pause brake (Issue #4220)
# ---------------------------------------------------------------------------
#
# A single, durable, fail-safe operator brake: "stop admitting NEW agent work
# everywhere, right now, but let in-flight runs finish — and resume later with
# no restart." Every new-work admission seam (WebSocket inbound, HTTP/MCP
# inbound, kanban dispatch cycle, scheduler due-loop) consults one shared
# contract instead of each lane deciding independently.
#
# Design mirrors the drain / idle / admission / liveness policy family already
# in this module: a pure ``Protocol`` in core plus a lightweight default and a
# durable fail-safe backend. When no brake is engaged, ``is_engaged()`` is
# ``False`` and behaviour is byte-for-byte today's — zero cost, no new
# dependency, fully backward-compatible.
@dataclass(frozen=True)
class EmergencyStopState:
"""Immutable snapshot of the operator brake, for status/audit surfaces.
``engaged`` is the only field the hot path needs; ``reason``/``actor``/
``at`` provide the optional audit trail surfaced in ``/health``/status.
"""
engaged: bool
reason: str = ""
actor: str = ""
at: float = 0.0
def to_dict(self) -> Dict[str, Any]:
return {
"engaged": self.engaged,
"reason": self.reason,
"actor": self.actor,
"at": self.at,
}
@runtime_checkable
class EmergencyStopProtocol(Protocol):
"""Pure contract for the global operator brake consulted at every seam.
Fail-safe rule: if the engaged state cannot be read with confidence (a
corrupt / unreadable durable sentinel), ``is_engaged()`` MUST return
``True`` — an ambiguous brake holds new work rather than letting it run
freely. ``engage``/``disengage`` are idempotent.
"""
def is_engaged(self) -> bool: ...
def engage(self, *, reason: str = "", actor: str = "") -> None: ...
def disengage(self) -> None: ...
def state(self) -> EmergencyStopState: ...
class NullEmergencyStop:
"""Default no-op brake: never engaged, no persistence.
Selected by ``backend: "off"`` (the default) so a gateway with no brake
configured behaves exactly as before — ``is_engaged()`` is always
``False`` and ``engage``/``disengage`` are inert.
"""
def is_engaged(self) -> bool:
return False
def engage(self, *, reason: str = "", actor: str = "") -> None:
return None
def disengage(self) -> None:
return None
def state(self) -> EmergencyStopState:
return EmergencyStopState(engaged=False)
class FileEmergencyStop:
"""Durable, fail-safe file-sentinel operator brake.
Engaging writes a small JSON sentinel at ``path``; disengaging removes it.
The engaged state therefore survives a crash/restart (durable) and is
shared by every lane that consults the same path.
Fail-safe: any error reading the sentinel — a partially written file,
corrupt JSON, a permission error — is treated as *engaged*. An ambiguous
brake holds new work; it never silently falls open to "run freely". The
common, unambiguous case (sentinel simply absent) reports not-engaged.
Pure-stdlib (``os``/``json``): no new dependency, safe to live in core.
"""
def __init__(self, path: str) -> None:
if not path:
raise ValueError("FileEmergencyStop requires a non-empty sentinel path")
import os
self._path = os.path.expanduser(str(path))
def is_engaged(self) -> bool:
import os
if not os.path.exists(self._path):
return False
# Present but unreadable/corrupt => fail-safe engaged.
try:
with open(self._path, "r", encoding="utf-8") as fh:
fh.read()
return True
except OSError:
return True
def engage(self, *, reason: str = "", actor: str = "") -> None:
import json
import os
directory = os.path.dirname(self._path)
if directory:
os.makedirs(directory, exist_ok=True)
payload = {
"engaged": True,
"reason": str(reason or ""),
"actor": str(actor or ""),
"at": time.time(),
}
# Atomic replace so a reader never observes a half-written sentinel
# (which would fail-safe engaged anyway, but this keeps it clean).
# ``mkstemp`` in the sentinel's own directory yields an unpredictable
# name owned by us, so a local attacker cannot pre-create a symlink to
# redirect the write. fsync + parent-dir fsync make an engaged brake
# durable across an abrupt crash.
import tempfile
fd, tmp = tempfile.mkstemp(
dir=directory or ".", prefix=".gateway.pause.", suffix=".tmp"
)
try:
with os.fdopen(fd, "w", encoding="utf-8") as fh:
json.dump(payload, fh)
fh.flush()
os.fsync(fh.fileno())
os.replace(tmp, self._path)
except BaseException:
try:
os.remove(tmp)
except OSError:
pass
raise
if directory:
try:
dir_fd = os.open(directory, os.O_RDONLY)
try:
os.fsync(dir_fd)
finally:
os.close(dir_fd)
except OSError:
pass
def disengage(self) -> None:
import os
try:
os.remove(self._path)
except FileNotFoundError:
return None
def state(self) -> EmergencyStopState:
import json
import os
if not os.path.exists(self._path):
return EmergencyStopState(engaged=False)
try:
with open(self._path, "r", encoding="utf-8") as fh:
data = json.load(fh)
if not isinstance(data, dict):
raise ValueError("sentinel is not a JSON object")
return EmergencyStopState(
engaged=True,
reason=str(data.get("reason", "")),
actor=str(data.get("actor", "")),
at=float(data.get("at", 0.0) or 0.0),
)
except (OSError, TypeError, ValueError):
# Fail-safe: unreadable/corrupt sentinel counts as engaged. A valid
# JSON object with a non-numeric ``at`` (e.g. a list) raises
# TypeError from ``float()`` and must also fail-safe engaged.
return EmergencyStopState(engaged=True, reason="unreadable-sentinel")
@@ -47,7 +47,11 @@ def _tail(text: str, limit: int = 4000) -> str:
return text[-limit:]
def _build_goal_judge_prompt(state: "GoalState", transcript_tail: str) -> str:
def _build_goal_judge_prompt(
state: "GoalState",
transcript_tail: str,
verification_block: Optional[str] = None,
) -> str:
"""Build a strict, criteria-anchored, JSON-only judge prompt."""
lines = [
"You are an independent completion judge for an autonomous agent.",
@@ -72,6 +76,13 @@ def _build_goal_judge_prompt(state: "GoalState", transcript_tail: str) -> str:
lines.append(
"If ANY constraint is violated, you MUST answer 'continue'."
)
if verification_block:
lines += [
"",
"EXECUTABLE VERIFICATION RESULTS (authoritative — command exit "
"codes and file checks; prefer this over prose claims):",
verification_block,
]
lines += [
"",
"AGENT OUTPUT (most recent):",
@@ -165,6 +176,7 @@ def judge_goal(
transcript_tail: str,
*,
judge_model: Optional[str] = None,
verification_block: Optional[str] = None,
) -> Tuple[str, str]:
"""Judge whether ``state.goal`` is met given the latest agent output.
@@ -180,7 +192,7 @@ def judge_goal(
"""
from ..eval.judge import Judge
prompt = _build_goal_judge_prompt(state, transcript_tail)
prompt = _build_goal_judge_prompt(state, transcript_tail, verification_block)
try:
judge = Judge(model=judge_model or _default_judge_model(), temperature=0.0)
litellm = judge._get_litellm()
@@ -128,11 +128,44 @@ class GoalLoopMixin:
if state is None or state.status != "active":
return None
# Executable verification: run configured hooks and gate on the result.
# A failing BLOCKING hook short-circuits to "continue" WITHOUT spending
# a judge call. Passing/non-blocking results become authoritative
# evidence in the judge prompt.
verification_block: Optional[str] = None
if getattr(self, "_verification_hooks", None):
results = self._run_verification_hooks()
self._last_verification_results = results
self._record_verification_journal(results)
verification_block = self._verification_summary_tail(results)
blocking_failed = [
r for r in results
if r.get("blocking", True) and not r.get("success")
]
if blocking_failed:
state.turns_used += 1
state.last_verdict = "continue"
# Carry the failing hooks' captured stdout/stderr into the
# continuation prompt so the next turn has the diagnostics
# needed to repair the failure (not just a bare label).
failure_detail = self._verification_summary_tail(blocking_failed)
reason = "verification gate failed"
if failure_detail:
reason = f"{reason}:\n{failure_detail}"
state.last_reason = reason
if state.turns_used >= state.max_turns:
state.status = "paused"
self._persist_goal_state()
return "budget_paused", reason
self._persist_goal_state()
return "continue", reason
state.turns_used += 1
verdict, reason = judge_goal(
state,
_tail(response),
judge_model=getattr(self, "_goal_judge_model", None),
verification_block=verification_block,
)
state.last_verdict, state.last_reason = verdict, reason
@@ -7,7 +7,12 @@ including both function-based and LLM-based guardrails.
from .guardrail_result import GuardrailResult
from .llm_guardrail import LLMGuardrail
from .protocols import GuardrailProtocol, StructuralGuardrailProtocol, PolicyGuardrailProtocol
from .protocols import (
GuardrailProtocol,
StructuralGuardrailProtocol,
PolicyGuardrailProtocol,
is_guardrail_object,
)
from .chain import GuardrailChain
__all__ = [
@@ -16,5 +21,6 @@ __all__ = [
"GuardrailProtocol",
"StructuralGuardrailProtocol",
"PolicyGuardrailProtocol",
"GuardrailChain"
"GuardrailChain",
"is_guardrail_object",
]
@@ -175,3 +175,25 @@ class PolicyGuardrailProtocol(Protocol):
"""
...
# Method names that make an object a guardrail. An object exposing at least one
# of these is a protocol-conforming guardrail even though it is not ``callable``.
GUARDRAIL_PROTOCOL_METHODS = ("validate_input", "validate_output", "validate_tool_call")
def is_guardrail_object(obj: Any) -> bool:
"""Return True when ``obj`` is a protocol-conforming guardrail *instance*.
``isinstance(obj, GuardrailProtocol)`` is not usable here: a ``runtime_checkable``
Protocol only checks method presence and would also match unrelated objects
partially, while classes (not instances) must be rejected. This helper is the
single place that decides "is this thing a guardrail object?".
Plain validator callables are handled by their own passthrough branch and are
not required to match here (they will, however, if they also expose one of the
protocol methods - e.g. ``GuardrailChain``).
"""
if obj is None or isinstance(obj, type):
return False
return any(callable(getattr(obj, name, None)) for name in GUARDRAIL_PROTOCOL_METHODS)
@@ -104,6 +104,9 @@ __all__ = [
# Verification hooks (protocols)
"VerificationHook",
"VerificationResult",
"BaseVerificationHook",
"CommandVerificationHook",
"FileCheckHook",
# Simplified API (beginner-friendly)
"add_hook",
"remove_hook",
@@ -178,6 +181,9 @@ _LAZY_GROUPS = {
'verification': {
'VerificationHook': ('praisonaiagents.hooks.verification', 'VerificationHook'),
'VerificationResult': ('praisonaiagents.hooks.verification', 'VerificationResult'),
'BaseVerificationHook': ('praisonaiagents.hooks.verification', 'BaseVerificationHook'),
'CommandVerificationHook': ('praisonaiagents.hooks.verification', 'CommandVerificationHook'),
'FileCheckHook': ('praisonaiagents.hooks.verification', 'FileCheckHook'),
},
# Simplified API (beginner-friendly aliases)
'simplified_api': {
@@ -184,7 +184,19 @@ class HookRunner:
self._execute_single(hook, event, input_data)
for hook in hooks
]
return await asyncio.gather(*tasks)
results = await asyncio.gather(*tasks)
# Parallel hooks cannot mutate input_data (only sequential hooks apply
# modified_input). Warn if a parallel hook returns modifications that
# will be silently discarded, so hook authors mark it sequential=True.
for hook, result in zip(hooks, results):
if result.success and result.output and result.output.modified_input:
logger.warning(
"Parallel hook '%s' returned modified_input which is "
"discarded; register it with sequential=True to apply it.",
hook.name,
)
return results
async def _execute_sequential(
self,
@@ -114,17 +114,26 @@ class BaseVerificationHook:
name: str = "base"
timeout_seconds: float = 60.0
def __init__(self, name: Optional[str] = None, timeout: float = 60.0):
blocking: bool = True
def __init__(
self,
name: Optional[str] = None,
timeout: float = 60.0,
blocking: bool = True,
):
"""Initialize the hook.
Args:
name: Override the hook name
timeout: Timeout in seconds for execution
blocking: When True (default), a failure of this hook blocks the
autonomous loop from finalising with a success outcome.
"""
if name:
self.name = name
self.timeout_seconds = timeout
self.blocking = blocking
def run(self, context: Optional[Dict[str, Any]] = None) -> VerificationResult:
"""Run the verification hook.
@@ -177,19 +186,25 @@ class CommandVerificationHook(BaseVerificationHook):
def __init__(
self,
name: str,
command: list,
command,
cwd: Optional[str] = None,
timeout: float = 60.0,
blocking: bool = True,
):
"""Initialize command hook.
Args:
name: Hook name
command: Command to run as list (e.g., ["pytest", "-v"])
command: Command to run as a list (e.g., ["pytest", "-v"]) or a
string (e.g., "python -m pytest -q"), which is shell-split.
cwd: Working directory for command
timeout: Timeout in seconds
blocking: When True (default), a failure blocks completion.
"""
super().__init__(name=name, timeout=timeout)
super().__init__(name=name, timeout=timeout, blocking=blocking)
if isinstance(command, str):
import shlex
command = shlex.split(command)
self.command = command
self.cwd = cwd
@@ -235,3 +250,143 @@ class CommandVerificationHook(BaseVerificationHook):
output=str(e),
error=str(e),
)
def _get_dotted(data: Any, path: str) -> Any:
"""Access a dotted path (e.g. ``"a.b.c"``) in nested dicts/lists.
Returns ``None`` if any segment is missing. List indices are supported
via integer-looking segments.
"""
value = data
for part in path.split("."):
if isinstance(value, dict):
value = value.get(part)
elif isinstance(value, (list, tuple)):
try:
value = value[int(part)]
except (ValueError, IndexError):
return None
else:
return None
return value
class FileCheckHook(BaseVerificationHook):
"""Declarative file-assertion verification hook (no shell involved).
Checks portable filesystem facts:
- ``exists`` : the file exists (default True).
- ``non_empty`` : the file has non-zero size.
- ``contains`` : the file text contains a substring.
- ``json_field``/``equals`` : the JSON value at a dotted path equals a value.
Example:
hook = FileCheckHook(name="changelog", path="CHANGELOG.md", non_empty=True)
hook = FileCheckHook(name="cfg", path="out.json",
json_field="status.code", equals=0)
"""
def __init__(
self,
name: str,
path: str,
exists: bool = True,
non_empty: bool = False,
contains: Optional[str] = None,
json_field: Optional[str] = None,
equals: Any = None,
blocking: bool = True,
):
super().__init__(name=name, blocking=blocking)
self.path = path
self.exists = exists
self.non_empty = non_empty
self.contains = contains
self.json_field = json_field
self.equals = equals
def _execute(self, context: Optional[Dict[str, Any]] = None) -> VerificationResult:
import os
details: Dict[str, Any] = {"path": self.path}
file_exists = os.path.isfile(self.path)
details["exists"] = file_exists
if self.exists and not file_exists:
return VerificationResult(
success=False,
output=f"File not found: {self.path}",
error="not_found",
details=details,
)
if not self.exists:
success = not file_exists
return VerificationResult(
success=success,
output=(
f"File exists but was expected absent: {self.path}"
if not success else f"File absent as expected: {self.path}"
),
details=details,
)
if self.non_empty:
size = os.path.getsize(self.path)
details["size"] = size
if size == 0:
return VerificationResult(
success=False,
output=f"File is empty: {self.path}",
error="empty",
details=details,
)
if self.contains is not None or self.json_field is not None:
try:
with open(self.path, "r", encoding="utf-8") as fh:
text = fh.read()
except Exception as e:
return VerificationResult(
success=False, output=str(e), error=str(e), details=details
)
if self.contains is not None and self.contains not in text:
return VerificationResult(
success=False,
output=f"File {self.path} does not contain {self.contains!r}",
error="missing_substring",
details=details,
)
if self.json_field is not None:
import json as _json
try:
data = _json.loads(text)
except Exception as e:
return VerificationResult(
success=False,
output=f"File {self.path} is not valid JSON: {e}",
error="invalid_json",
details=details,
)
actual = _get_dotted(data, self.json_field)
details["json_field"] = self.json_field
details["actual"] = actual
if actual != self.equals:
return VerificationResult(
success=False,
output=(
f"{self.path}:{self.json_field} = {actual!r}, "
f"expected {self.equals!r}"
),
error="mismatch",
details=details,
)
return VerificationResult(
success=True,
output=f"File check passed: {self.path}",
details=details,
)
@@ -2,6 +2,30 @@ from typing import List, Union, Optional, Dict, Any
from functools import cached_property
import importlib
#: Names accepted for a chunking strategy that are not chunker ids themselves.
#: ``ChunkingStrategy.FIXED`` and ``.PARAGRAPH`` had no chunker at all, so they
#: silently did nothing; they now map onto the chunkers that implement them.
CHUNKER_ALIASES = {
"fixed": "token",
"paragraph": "recursive",
}
def normalize_chunker_type(name: str) -> str:
"""Map a user-facing chunking strategy name onto a chunker id."""
if not name:
return "recursive"
key = str(name).strip().lower()
key = CHUNKER_ALIASES.get(key, key)
if key not in Chunking.CHUNKER_PARAMS:
from ..config.parse_utils import make_preset_error
raise make_preset_error(
"chunking strategy", name,
sorted(set(Chunking.CHUNKER_PARAMS) | set(CHUNKER_ALIASES)),
)
return key
class Chunking:
"""A unified class for text chunking with various chunking strategies."""
@@ -2,7 +2,7 @@ import os
import logging
from praisonaiagents._logging import get_logger
from datetime import datetime
from .chunking import Chunking
from .chunking import Chunking, normalize_chunker_type
from functools import cached_property
@@ -162,6 +162,10 @@ class Knowledge:
# Merge graph_store config if provided (for graph memory support)
if "graph_store" in self._config:
base_config["graph_store"] = self._config["graph_store"]
# Merge chunker config if provided (consumed by self.chunker)
if "chunker" in self._config:
base_config["chunker"] = self._config["chunker"]
return base_config
def _prepare_mem0_config(self, config):
@@ -195,28 +199,46 @@ class Knowledge:
def memory(self):
"""Initialize knowledge adapter using protocol-driven approach."""
# Import registry functions
from .adapters import get_knowledge_adapter, get_first_available_knowledge_adapter
from .adapters import (
get_knowledge_adapter,
get_first_available_knowledge_adapter,
has_knowledge_adapter,
list_knowledge_adapters,
)
# Determine provider preference. Distinguish an explicit user choice from
# the implicit default so fallback diagnostics are only loud when a
# configured backend degrades (see issue #2972 / PR #2982 review).
# ``self.config`` is always merged with defaults, so use the raw
# user-supplied ``_config`` to detect whether the provider was chosen.
provider_explicit = bool(
(self._config or {}).get("vector_store", {}).get("provider")
# Presence of the key (not truthiness) marks an explicit choice, so an
# explicitly empty/null provider is treated as a misconfiguration and
# surfaces the preset error instead of silently degrading to Mem0.
provider_explicit = "provider" in (
(self._config or {}).get("vector_store", {}) or {}
)
provider = self.config.get("vector_store", {}).get("provider", "mem0")
self._log(f"Requested knowledge provider: {provider}")
# Map legacy provider names to adapter names
# Legacy provider aliases. Anything else is looked up in the adapter
# registry, so adapters added with register_knowledge_adapter() are
# reachable; only genuinely unknown names fall back (and say so).
provider_mapping = {
"chroma": "chroma",
"mongodb": "mongodb",
"mem0": "mem0",
"sqlite": "sqlite"
"chromadb": "chroma",
"rag": "chroma",
}
adapter_name = provider_mapping.get(provider, "mem0")
adapter_name = provider_mapping.get(provider, provider)
if not has_knowledge_adapter(adapter_name):
from ..config.parse_utils import make_preset_error
err = make_preset_error(
"knowledge vector_store provider", provider,
sorted(set(list_knowledge_adapters()) | set(provider_mapping)),
)
if provider_explicit:
raise err
self._log(f"{err} Falling back to 'mem0'.")
adapter_name = "mem0"
# Try to get preferred adapter, fallback to available ones
try:
@@ -287,10 +309,13 @@ class Knowledge:
@cached_property
def chunker(self):
# Read from config; the previous hardcoded recursive/512/50 made
# KnowledgeConfig.chunk_size / chunking_strategy / chunker inert.
chunker_cfg = self.config.get("chunker") or {}
return Chunking(
chunker_type='recursive',
chunk_size=512,
chunk_overlap=50
chunker_type=normalize_chunker_type(chunker_cfg.get("type", "recursive")),
chunk_size=chunker_cfg.get("chunk_size", 512),
chunk_overlap=chunker_cfg.get("chunk_overlap", 50),
)
def _log(self, message, level=2):
@@ -413,7 +438,11 @@ class Knowledge:
def history(self, memory_id):
"""Get the history of changes for a memory."""
return self.memory.history(memory_id)
if hasattr(self.memory, "history"):
return self.memory.history(memory_id)
raise NotImplementedError(
f"{type(self.memory).__name__} does not support history()"
)
def delete(self, memory_id):
"""Delete a memory."""
@@ -421,11 +450,21 @@ class Knowledge:
def delete_all(self, user_id=None, agent_id=None, run_id=None):
"""Delete all memories."""
self.memory.delete_all(user_id=user_id, agent_id=agent_id, run_id=run_id)
if hasattr(self.memory, "delete_all"):
self.memory.delete_all(user_id=user_id, agent_id=agent_id, run_id=run_id)
else:
raise NotImplementedError(
f"{type(self.memory).__name__} does not support delete_all()"
)
def reset(self):
"""Reset all memories."""
self.memory.reset()
if hasattr(self.memory, "reset"):
self.memory.reset()
else:
logger.warning(
f"{type(self.memory).__name__} does not support reset(); no-op"
)
def normalize_content(self, content):
"""Normalize content for consistent storage."""
@@ -107,6 +107,22 @@ def __getattr__(name):
from .rate_limiter import RateLimiter
_lazy_cache[name] = RateLimiter
return RateLimiter
elif name == "QuotaCoordinatorProtocol":
from .quota import QuotaCoordinatorProtocol
_lazy_cache[name] = QuotaCoordinatorProtocol
return QuotaCoordinatorProtocol
elif name == "QuotaCoordinatorConfig":
from .quota import QuotaCoordinatorConfig
_lazy_cache[name] = QuotaCoordinatorConfig
return QuotaCoordinatorConfig
elif name == "LocalQuotaCoordinator":
from .quota import LocalQuotaCoordinator
_lazy_cache[name] = LocalQuotaCoordinator
return LocalQuotaCoordinator
elif name == "build_quota_coordinator":
from .quota import build_quota_coordinator
_lazy_cache[name] = build_quota_coordinator
return build_quota_coordinator
elif name == "TokenUsage":
from .llm import TokenUsage
_lazy_cache[name] = TokenUsage
@@ -229,6 +245,11 @@ __all__ = [
"create_routing_agent",
"RateLimiter",
"TokenUsage",
# Provider quota coordination (cross-replica credential cooldowns)
"QuotaCoordinatorProtocol",
"QuotaCoordinatorConfig",
"LocalQuotaCoordinator",
"build_quota_coordinator",
# Protocols
"LLMProviderProtocol",
"ModelCapabilitiesProtocol",
@@ -16,6 +16,7 @@ import time
from dataclasses import dataclass, field
from enum import Enum
from typing import (
TYPE_CHECKING,
Any,
Callable,
Dict,
@@ -25,6 +26,9 @@ from typing import (
runtime_checkable,
)
if TYPE_CHECKING:
from .quota import QuotaCoordinatorProtocol
logger = get_logger(__name__)
class ProviderStatus(str, Enum):
@@ -112,6 +116,29 @@ class AuthProfile:
metadata=data.get("metadata", {}),
)
@property
def credential_id(self) -> str:
"""Stable, non-secret identity for cross-replica quota coordination.
The coordinator keys benches by the *credential*, not the profile
label. ``name`` is a local display label: two replicas may name the
same key differently (breaking cooldown propagation) or reuse a name
like ``"default"`` for different keys (benching an unrelated key).
Derive a deterministic id from the fields that identify the credential
(provider, api_key, base_url) using a short salted hash so the real key
is never exposed. Falls back to ``name`` when no api_key is present.
"""
if not self.api_key:
return self.name
import hashlib
digest = hashlib.sha256(
f"{self.provider}\x00{self.base_url or ''}\x00{self.api_key}".encode(
"utf-8", "ignore"
)
).hexdigest()[:16]
return f"{self.provider}:{digest}"
@property
def is_available(self) -> bool:
"""Check if this profile is currently available."""
@@ -207,13 +234,27 @@ class FailoverManager:
profile = manager.get_next_profile()
"""
def __init__(self, config: Optional[FailoverConfig] = None):
def __init__(
self,
config: Optional[FailoverConfig] = None,
coordinator: Optional["QuotaCoordinatorProtocol"] = None,
):
"""Initialize the failover manager.
Args:
config: Failover configuration
coordinator: Optional shared quota coordinator. When supplied
(e.g. a Redis-backed one wired by the gateway), credential
benches/cooldowns are coordinated fleet-wide so a key benched
by any replica is skipped by all replicas. Defaults to an
in-memory local coordinator, keeping single-replica behaviour
exactly as before with no new dependency and no hot-path cost.
"""
self.config = config or FailoverConfig()
if coordinator is None:
from .quota import LocalQuotaCoordinator
coordinator = LocalQuotaCoordinator()
self._coordinator: "QuotaCoordinatorProtocol" = coordinator
self._profiles: List[AuthProfile] = []
self._current_index: int = 0
self._on_failover_callbacks: List[Callable[[AuthProfile, AuthProfile], None]] = []
@@ -274,6 +315,30 @@ class FailoverManager:
with self._lock:
return list(self._profiles)
def _sync_bench_from_coordinator(
self, profile: AuthProfile, now: Optional[float] = None
) -> None:
"""Apply a fleet-wide bench from the coordinator onto a local profile.
If another replica benched this credential, reflect its cooldown here
so this replica skips it too. Fail-open: never raise into failover.
Callers already hold ``self._lock``.
"""
try:
until = self._coordinator.benched_until(profile.credential_id, now=now)
except Exception as e: # pragma: no cover - defensive
logger.warning(
f"Quota coordinator lookup failed for '{profile.name}': {e}; "
f"using local cooldown state"
)
return
if until is not None and (
profile.cooldown_until is None or until > profile.cooldown_until
):
if profile.status == ProviderStatus.AVAILABLE:
profile.status = ProviderStatus.RATE_LIMITED
profile.cooldown_until = until
def get_next_profile(self) -> Optional[AuthProfile]:
"""Get the next available profile.
@@ -287,9 +352,10 @@ class FailoverManager:
if not self._profiles:
return None
# First, check if any cooldowns have expired
# First, sync fleet-wide benches, then check if any cooldowns have expired.
current_time = time.time()
for profile in self._profiles:
self._sync_bench_from_coordinator(profile, now=current_time)
if profile.cooldown_until and current_time >= profile.cooldown_until:
profile.reset()
@@ -328,12 +394,29 @@ class FailoverManager:
f"Profile '{profile.name}' rate limited, "
f"cooldown for {self.config.cooldown_on_rate_limit}s"
)
reason = "rate_limit"
else:
profile.mark_error(error, self.config.cooldown_on_error)
logger.warning(
f"Profile '{profile.name}' error: {error}, "
f"cooldown for {self.config.cooldown_on_error}s"
)
reason = "error"
# Share the bench fleet-wide so other replicas skip this key too.
# Fail-open: a coordinator hiccup must never wedge failover.
if profile.cooldown_until is not None:
try:
self._coordinator.bench(
profile.credential_id,
until=profile.cooldown_until,
reason=reason,
)
except Exception as e: # pragma: no cover - defensive
logger.warning(
f"Quota coordinator bench failed for '{profile.name}': {e}; "
f"falling back to local cooldown only"
)
# Resolve the target profile and snapshot callbacks while holding
# the lock, but invoke them AFTER releasing it. User callbacks may
@@ -361,8 +444,30 @@ class FailoverManager:
"""
with self._lock:
if profile.status != ProviderStatus.AVAILABLE:
# Snapshot the cooldown this success is recovering from BEFORE
# resetting, so we can avoid clobbering a newer fleet-wide bench.
recovered_from = profile.cooldown_until
profile.reset()
logger.info(f"Profile '{profile.name}' recovered")
cred_id = profile.credential_id
try:
# A concurrent/other-replica failure may have benched this
# credential with a LATER expiry than the cooldown this
# (possibly stale, already in-flight) success is recovering
# from. Clearing unconditionally would resume a credential
# that is still rate-limited. Only clear when the shared
# bench is not newer than what we recovered from.
shared_until = self._coordinator.benched_until(cred_id)
if (
shared_until is None
or recovered_from is None
or shared_until <= recovered_from
):
self._coordinator.clear(cred_id)
except Exception as e: # pragma: no cover - defensive
logger.warning(
f"Quota coordinator clear failed for '{profile.name}': {e}"
)
def on_failover(
self,
+242 -58
View File
@@ -28,6 +28,14 @@ from ..tools.call_executor import ToolCall, create_tool_call_executor
from ..tools.schema import build_tool_definition
# Sentinel returned as the "arguments" value when a tool call's argument string
# cannot be parsed (e.g. truncated by max_tokens or a dropped connection).
# It is distinct from {} ("no arguments"): {} would silently execute the tool
# with the WRONG arguments and report success. Callers must detect this sentinel
# and surface a tool-error so the model can re-emit the call instead.
_TOOL_ARGUMENTS_PARSE_FAILED = object()
def _durable_iteration_kwargs(execute_tool_fn: Callable, index: int) -> Dict[str, int]:
if getattr(execute_tool_fn, "_accepts_durable_iteration", False):
return {"_durable_iteration_index": index}
@@ -534,7 +542,18 @@ Respond with ONLY a valid JSON tool call in this format:
if self._failover_manager:
self._current_profile = self._failover_manager.get_next_profile()
if self._current_profile:
self._switch_to_profile(self._current_profile)
# Apply the initial profile's values to the instance attributes
# (backward compatible with the documented llm.api_key/model
# surface). Later failover rotations are per-call only and do
# not mutate these attributes (issue #3613 gap 2).
profile = self._current_profile
if profile.api_key:
self.api_key = profile.api_key
if profile.base_url:
self.base_url = profile.base_url
if profile.model and profile.model != self.model:
logging.info(f"Failover: using profile model {profile.model}")
self.model = profile.model
# Cache for formatted tools and messages
self._formatted_tools_cache = {}
@@ -974,18 +993,58 @@ Respond with ONLY a valid JSON tool call in this format:
def _switch_to_profile(self, profile: "AuthProfile") -> None:
"""Switch to a new auth profile for failover.
The profile's credentials are threaded through the per-call kwargs of
the retry loop instead of being written onto the shared instance. The
old behaviour mutated ``self.api_key``/``self.base_url``/``self.model``
on a shared ``LLM`` (issue #3613 gap 2), so concurrent requests on one
instance could silently cross-talk credentials and model after a
failover rotation. Keeping the instance attributes on the initial
profile preserves single-profile behaviour and the documented
``llm.api_key``/``llm.model`` surface.
Args:
profile: AuthProfile to switch to
"""
# NOTE: profile values are applied to the per-call kwargs by
# _handle_retry_exception when it rotates. This method is kept as a
# no-op placeholder so any out-of-tree callers that invoke it directly
# keep working; it intentionally no longer mutates shared state.
if profile is None:
return
def _response_model_for_tracking(self, response: Any) -> str:
"""Model to attribute token usage to for a completed call.
Prefers the model carried on the response itself, which reflects the
provider/profile that actually served the request. This is race-free
under concurrency (unlike reading the shared ``self._current_profile``)
and stays correct after a failover rotation. Falls back to
``self.model`` when the response does not expose a model.
"""
model = None
if isinstance(response, dict):
model = response.get("model")
else:
model = getattr(response, "model", None)
return model or self.model
def _apply_profile_to_kwargs(self, profile: "AuthProfile", kwargs: dict) -> dict:
"""Return a new kwargs dict with profile overrides applied.
Never mutates ``self``: the active profile is a per-call concern, so
its credentials travel in the request kwargs only. Callers that pass
an explicit per-call override (e.g. ``api_key=``) keep it; profile
values fill in the gaps.
"""
kwargs = dict(kwargs)
if profile.api_key:
self.api_key = profile.api_key
kwargs["api_key"] = profile.api_key
if profile.base_url:
self.base_url = profile.base_url
if profile.model and profile.model != self.model:
# Only log if model actually changes
logging.info(f"Failover: switching from {self.model} to {profile.model}")
self.model = profile.model
kwargs["base_url"] = profile.base_url
if profile.model:
kwargs["model"] = profile.model
return kwargs
def _resolve_subscription_creds(self):
"""Lazy resolve + cache subscription credentials, checking expiration."""
@@ -1055,7 +1114,7 @@ Respond with ONLY a valid JSON tool call in this format:
)
return None
def _handle_retry_exception(self, e, attempt, kwargs, refreshed_creds=None):
def _handle_retry_exception(self, e, attempt, kwargs, refreshed_creds=None, active_profile=None):
"""Decide retry vs raise from a failover decision. No sleep/await.
Shared decision logic used by both the sync (`_call_with_retry`) and
@@ -1069,21 +1128,34 @@ Respond with ONLY a valid JSON tool call in this format:
blocks the event loop. The already-refreshed credentials (if any) are
passed in via ``refreshed_creds``.
The active failover profile is a *per-call* value threaded in via
``active_profile`` and returned back in the result tuple. It is never
read from or written to ``self._current_profile`` here, so concurrent
requests sharing one ``LLM`` instance cannot corrupt each other's
failover bookkeeping or cost attribution (issue #3613 gap 2).
Args:
e: The exception raised by the wrapped call.
attempt: Zero-based attempt index for the current iteration.
kwargs: Keyword arguments for the wrapped call (may be updated).
refreshed_creds: Credentials already refreshed by the caller (off
the event loop for async), or ``None`` if no refresh was done.
active_profile: The profile this call is currently using, or
``None``. Defaults to the initial profile for backward compat.
Returns:
Tuple of (should_raise, category, retry_delay, error_str, kwargs):
Tuple of (should_raise, category, retry_delay, error_str, kwargs,
active_profile):
should_raise: Whether the caller should re-raise immediately.
category: The error category/reason from the decision.
retry_delay: Seconds to wait before the next attempt.
error_str: String form of the exception.
kwargs: The (possibly updated) keyword arguments.
active_profile: The (possibly rotated) profile for the next
attempt.
"""
if active_profile is None:
active_profile = self._current_profile
# A turn is "side-effecting" when it exposes tools the model may call:
# a post-dispatch failure on such a turn could have already run a
# side-effecting tool, so it must not be silently replayed. A turn with
@@ -1135,55 +1207,48 @@ Respond with ONLY a valid JSON tool call in this format:
# immediately with fresh credentials and skip profile rotation so we
# neither mark the current profile failed nor overwrite the new creds.
if refreshed_auth:
return False, category, retry_delay, error_str, kwargs
return False, category, retry_delay, error_str, kwargs, active_profile
# Handle different failover decision actions
# Handle different failover decision actions. Rotation is a per-call
# concern: the active profile is a local threaded in/out of this method,
# never self._current_profile, so concurrent calls on one shared LLM
# cannot mark each other's profiles failed/healthy (issue #3613 gap 2).
if decision.action == "rotate_profile" and self._failover_manager:
if self._current_profile:
if active_profile:
is_rate_limit = (category == "rate_limit")
self._failover_manager.mark_failure(
self._current_profile, error_str, is_rate_limit=is_rate_limit
active_profile, error_str, is_rate_limit=is_rate_limit
)
next_profile = self._failover_manager.get_next_profile()
if next_profile and next_profile != self._current_profile:
self._switch_to_profile(next_profile)
self._current_profile = next_profile
# Update the kwargs with new profile values for the next retry
if "api_key" in kwargs:
kwargs["api_key"] = self.api_key
if "base_url" in kwargs:
kwargs["base_url"] = self.base_url
if "model" in kwargs:
kwargs["model"] = self.model
if next_profile and next_profile != active_profile:
active_profile = next_profile
# Thread the active profile through the per-call kwargs so the
# shared instance state is never mutated (issue #3613 gap 2).
kwargs = self._apply_profile_to_kwargs(next_profile, kwargs)
logging.info(f"Failover: switched to profile '{next_profile.name}'")
else:
# No alternate profile available - retrying would just hit the
# same failing profile, so surface the error instead.
can_retry = False
# Legacy failover for compatibility (when decision is retry but failover is configured)
elif self._failover_manager and self._current_profile and decision.action == "retry":
elif self._failover_manager and active_profile and decision.action == "retry":
is_rate_limit = (category == "rate_limit")
self._failover_manager.mark_failure(
self._current_profile, error_str, is_rate_limit=is_rate_limit
active_profile, error_str, is_rate_limit=is_rate_limit
)
next_profile = self._failover_manager.get_next_profile()
if next_profile and next_profile != self._current_profile:
self._switch_to_profile(next_profile)
self._current_profile = next_profile
# Update the kwargs with new profile values for the next retry
if "api_key" in kwargs:
kwargs["api_key"] = self.api_key
if "base_url" in kwargs:
kwargs["base_url"] = self.base_url
if "model" in kwargs:
kwargs["model"] = self.model
if next_profile and next_profile != active_profile:
active_profile = next_profile
# Thread the active profile through the per-call kwargs so the
# shared instance state is never mutated (issue #3613 gap 2).
kwargs = self._apply_profile_to_kwargs(next_profile, kwargs)
# Enable retry for profile switch even if originally non-retryable
can_retry = True
retry_delay = 0.0
logging.info(f"Failover: switched to profile '{next_profile.name}'")
should_raise = decision.action == "surface_error" or not can_retry
return should_raise, category, retry_delay, error_str, kwargs
return should_raise, category, retry_delay, error_str, kwargs, active_profile
def _call_with_retry(self, func, *args, **kwargs):
"""Call a function with automatic retry on rate limit errors and failover support.
@@ -1200,6 +1265,10 @@ Respond with ONLY a valid JSON tool call in this format:
The original exception if max retries exceeded
"""
last_error = None
# Track the failover profile per call (never self._current_profile) so
# concurrent calls on one shared LLM cannot corrupt each other's
# failover bookkeeping (issue #3613 gap 2).
active_profile = self._current_profile
for attempt in range(self._max_retries + 1):
try:
@@ -1210,8 +1279,8 @@ Respond with ONLY a valid JSON tool call in this format:
result = func(*args, **kwargs)
# Mark success if failover is configured
if self._failover_manager and self._current_profile:
self._failover_manager.mark_success(self._current_profile)
if self._failover_manager and active_profile:
self._failover_manager.mark_success(active_profile)
# Reset idle timeout circuit breaker on success
self._idle_timeout_breaker.reset()
@@ -1226,8 +1295,12 @@ Respond with ONLY a valid JSON tool call in this format:
if self._should_attempt_auth_refresh(e, attempt):
refreshed_creds = self._try_refresh_subscription_creds()
should_raise, category, retry_delay, error_str, kwargs = (
self._handle_retry_exception(e, attempt, kwargs, refreshed_creds=refreshed_creds)
should_raise, category, retry_delay, error_str, kwargs, active_profile = (
self._handle_retry_exception(
e, attempt, kwargs,
refreshed_creds=refreshed_creds,
active_profile=active_profile,
)
)
if should_raise:
@@ -1276,6 +1349,10 @@ Respond with ONLY a valid JSON tool call in this format:
The original exception if max retries exceeded
"""
last_error = None
# Track the failover profile per call (never self._current_profile) so
# concurrent coroutines on one shared LLM cannot corrupt each other's
# failover bookkeeping (issue #3613 gap 2).
active_profile = self._current_profile
for attempt in range(self._max_retries + 1):
try:
@@ -1286,8 +1363,8 @@ Respond with ONLY a valid JSON tool call in this format:
result = await func(*args, **kwargs)
# Mark success if failover is configured
if self._failover_manager and self._current_profile:
self._failover_manager.mark_success(self._current_profile)
if self._failover_manager and active_profile:
self._failover_manager.mark_success(active_profile)
# Reset idle timeout circuit breaker on success
self._idle_timeout_breaker.reset()
@@ -1305,8 +1382,12 @@ Respond with ONLY a valid JSON tool call in this format:
self._try_refresh_subscription_creds
)
should_raise, category, retry_delay, error_str, kwargs = (
self._handle_retry_exception(e, attempt, kwargs, refreshed_creds=refreshed_creds)
should_raise, category, retry_delay, error_str, kwargs, active_profile = (
self._handle_retry_exception(
e, attempt, kwargs,
refreshed_creds=refreshed_creds,
active_profile=active_profile,
)
)
if should_raise:
@@ -1358,7 +1439,7 @@ Respond with ONLY a valid JSON tool call in this format:
import litellm
response = self._call_with_retry(litellm.completion, **completion_params)
if not completion_params.get("stream"):
self._track_token_usage(response, self.model)
self._track_token_usage(response, self._response_model_for_tracking(response))
return response
async def _acompletion_with_retry(self, **completion_params):
@@ -1379,7 +1460,7 @@ Respond with ONLY a valid JSON tool call in this format:
**completion_params,
)
if not completion_params.get("stream"):
self._track_token_usage(response, self.model)
self._track_token_usage(response, self._response_model_for_tracking(response))
return response
def _supports_web_search(self) -> bool:
@@ -1766,8 +1847,15 @@ Respond with ONLY a valid JSON tool call in this format:
except (KeyError, json.JSONDecodeError, TypeError) as e:
logging.error(f"Error parsing tool call arguments: {e}")
function_name = tool_call.get("name", "unknown_function")
arguments = {}
function_name = (
tool_call.get("function", {}).get("name")
if isinstance(tool_call.get("function"), dict)
else None
) or tool_call.get("name", "unknown_function")
# A parse failure is NOT "no arguments". Returning {} here would run
# the tool with the wrong arguments and report success. Signal the
# failure so callers surface a tool-error instead of dispatching.
arguments = _TOOL_ARGUMENTS_PARSE_FAILED
tool_call_id = tool_call.get("id", f"tool_{id(tool_call)}")
return function_name, arguments, tool_call_id
@@ -2432,7 +2520,7 @@ Respond with ONLY a valid JSON tool call in this format:
prompt: Union[str, List[Dict]],
system_prompt: Optional[str] = None,
chat_history: Optional[List[Dict]] = None,
temperature: float = 1.0,
temperature: Optional[float] = None,
tools: Optional[List[Any]] = None,
output_json: Optional[BaseModel] = None,
output_pydantic: Optional[BaseModel] = None,
@@ -2749,10 +2837,17 @@ Respond with ONLY a valid JSON tool call in this format:
# Execute tool calls using ToolCallExecutor (Gap 2: parallel or sequential)
is_ollama = self._is_ollama_provider()
tool_calls_batch = []
parse_error_messages = []
# Prepare batch of ToolCall objects
for tool_call in tool_calls:
function_name, arguments, tool_call_id = self._extract_tool_call_info(tool_call, is_ollama=is_ollama)
if self._tool_arguments_parse_failed(arguments):
# Do NOT dispatch with {}: surface a retryable error.
parse_error_messages.append(
self._tool_parse_error_message(function_name, tool_call_id)
)
continue
tool_calls_batch.append(ToolCall(
function_name=function_name,
arguments=arguments,
@@ -2826,6 +2921,11 @@ Respond with ONLY a valid JSON tool call in this format:
"content": content,
})
# Report any unparseable tool-call arguments so the
# model can re-emit them (never dispatched with {}).
for _err_msg in parse_error_messages:
messages.append(_err_msg)
# Safety: break after max_iter iterations
if iteration_count + 1 >= max_iterations:
self._last_stop_reason = "max_steps"
@@ -3529,6 +3629,11 @@ Respond with ONLY a valid JSON tool call in this format:
is_ollama = self._is_ollama_provider()
function_name, arguments, tool_call_id = self._extract_tool_call_info(tool_call, is_ollama)
if self._tool_arguments_parse_failed(arguments):
# Do NOT dispatch with {}: surface a retryable error.
messages.append(self._tool_parse_error_message(function_name, tool_call_id))
continue
# Validate and filter arguments for Ollama provider
if is_ollama and tools:
# First check if any argument references a previous tool result
@@ -4088,7 +4193,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
prompt: Union[str, List[Dict]],
system_prompt: Optional[str] = None,
chat_history: Optional[List[Dict]] = None,
temperature: float = 1.0,
temperature: Optional[float] = None,
tools: Optional[List[Any]] = None,
output_json: Optional[BaseModel] = None,
output_pydantic: Optional[BaseModel] = None,
@@ -4273,10 +4378,17 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
# Execute tool calls using ToolCallExecutor (Gap 2: parallel or sequential)
is_ollama = self._is_ollama_provider()
tool_calls_batch = []
parse_error_messages = []
# Prepare batch of ToolCall objects
for tool_call in tool_calls:
function_name, arguments, tool_call_id = self._extract_tool_call_info(tool_call, is_ollama)
if self._tool_arguments_parse_failed(arguments):
# Do NOT dispatch with {}: surface a retryable error.
parse_error_messages.append(
self._tool_parse_error_message(function_name, tool_call_id)
)
continue
tool_calls_batch.append(ToolCall(
function_name=function_name,
arguments=arguments,
@@ -4316,6 +4428,11 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
tool_result.is_ollama
)
messages.append(tool_message)
# Report any unparseable tool-call arguments so the
# model can re-emit them (never dispatched with {}).
for _err_msg in parse_error_messages:
messages.append(_err_msg)
# Continue conversation after tool execution - get follow-up response
try:
@@ -4423,7 +4540,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
prompt: Union[str, List[Dict]],
system_prompt: Optional[str] = None,
chat_history: Optional[List[Dict]] = None,
temperature: float = 1.0,
temperature: Optional[float] = None,
tools: Optional[List[Any]] = None,
output_json: Optional[BaseModel] = None,
output_pydantic: Optional[BaseModel] = None,
@@ -4653,6 +4770,10 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
for tool_call in tool_calls:
function_name, arguments, tool_call_id = self._extract_tool_call_info(tool_call)
if self._tool_arguments_parse_failed(arguments):
# Do NOT dispatch with {}: surface a retryable error.
messages.append(self._tool_parse_error_message(function_name, tool_call_id))
continue
logging.debug(f"[RESPONSES_API_ASYNC] Executing tool {function_name}")
tool_result = await _dispatch_async_tool(
execute_tool_fn,
@@ -4902,6 +5023,11 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
is_ollama = self._is_ollama_provider()
function_name, arguments, tool_call_id = self._extract_tool_call_info(tool_call, is_ollama)
if self._tool_arguments_parse_failed(arguments):
# Do NOT dispatch with {}: surface a retryable error.
messages.append(self._tool_parse_error_message(function_name, tool_call_id))
continue
# Validate and filter arguments for Ollama provider
if is_ollama and tools:
arguments = self._validate_and_filter_ollama_arguments(function_name, arguments, tools)
@@ -5612,6 +5738,16 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
# Override with any provided parameters
params.update(override_params)
# Resolve temperature from the instance when the caller did not specify
# one. Public entry points now default temperature to None so a value
# configured via Agent(llm={'temperature': ...}) actually reaches the
# request instead of being silently overridden by a hardcoded 1.0.
if params.get("temperature") is None:
if self.temperature is not None:
params["temperature"] = self.temperature
else:
params.pop("temperature", None)
# Handle structured output parameters
output_json = override_params.get('output_json')
@@ -5944,6 +6080,19 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
if self.timeout:
params["timeout"] = self.timeout
# ── Subscription credentials ────────────────────────────────────
# Mirror _build_completion_params: without this the Responses API
# transport silently ignores auth= and bills the plain API key.
creds = self._resolve_subscription_creds()
if creds:
params["api_key"] = creds.api_key
if creds.base_url:
params["base_url"] = creds.base_url
if creds.headers:
extra_headers = dict(params.get("extra_headers") or {})
extra_headers.update(creds.headers)
params["extra_headers"] = extra_headers
# ── Structured output ───────────────────────────────────────────
output_json = kwargs.pop("output_json", None)
output_pydantic = kwargs.pop("output_pydantic", None)
@@ -5994,7 +6143,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
"""
import litellm
response = await self._call_with_retry_async(litellm.aresponses, **params)
self._track_token_usage(response, self.model)
self._track_token_usage(response, self._response_model_for_tracking(response))
return response
def _extract_from_responses_output(self, response) -> tuple:
@@ -6233,6 +6382,17 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
is_reasoning=False,
))
elif evt_type == "response.reasoning_summary_text.delta":
delta_text = (event.get("delta", "") if isinstance(event, dict)
else getattr(event, "delta", ""))
if _emit and delta_text:
stream_callback(StreamEvent(
type=StreamEventType.DELTA_TEXT,
timestamp=time.perf_counter(),
content=delta_text,
is_reasoning=True,
))
elif evt_type == "response.function_call_arguments.delta":
idx = (event.get("output_index", 0) if isinstance(event, dict)
else getattr(event, "output_index", 0))
@@ -6345,17 +6505,41 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
tool_call_id = tool_call.id
except (json.JSONDecodeError, AttributeError) as e:
logging.error(f"Error parsing object-style tool call: {e}")
function_name = "unknown_function"
arguments = {}
tool_call_id = f"tool_{id(tool_call)}"
function_name = getattr(getattr(tool_call, 'function', None), 'name', None) or "unknown_function"
# See _parse_tool_call_arguments: a parse failure is not {}.
arguments = _TOOL_ARGUMENTS_PARSE_FAILED
tool_call_id = getattr(tool_call, 'id', None) or f"tool_{id(tool_call)}"
return function_name, arguments, tool_call_id
@staticmethod
def _tool_arguments_parse_failed(arguments) -> bool:
"""True when tool-call arguments could not be parsed (vs. legitimately empty)."""
return arguments is _TOOL_ARGUMENTS_PARSE_FAILED
@staticmethod
def _tool_parse_error_message(function_name: str, tool_call_id: str) -> Dict[str, str]:
"""Build a tool-role message telling the model its arguments were lost.
Surfacing this instead of dispatching with {} converts a silent
wrong-action-reported-as-success into a visible, retryable error.
"""
return {
"role": "tool",
"tool_call_id": tool_call_id,
"content": (
f"Error: arguments for tool '{function_name}' could not be parsed "
f"(the argument string was invalid or truncated). "
f"The tool was NOT executed. Please re-emit the tool call with "
f"complete, valid JSON arguments."
),
}
# Response without tool calls
def response(
self,
prompt: Union[str, List[Dict]],
system_prompt: Optional[str] = None,
temperature: float = 1.0,
temperature: Optional[float] = None,
stream: bool = True,
verbose: bool = True,
markdown: bool = True,
@@ -6449,7 +6633,7 @@ Output MUST be JSON with 'reflection' and 'satisfactory'.
self,
prompt: Union[str, List[Dict]],
system_prompt: Optional[str] = None,
temperature: float = 1.0,
temperature: Optional[float] = None,
stream: bool = True,
verbose: bool = True,
markdown: bool = True,
@@ -200,6 +200,26 @@ class ToolCall:
type: str
function: Dict[str, Any]
def _extract_tool_call_name_and_args(tool_call):
"""Parse a tool call's function name and JSON arguments.
Handles both the ToolCall dataclass and OpenAI-SDK objects. Returns a
tuple of (name, args, tool_call_id, err); err is None on success and the
caught exception otherwise. Callers keep their own failure handling.
"""
tool_call_id = tool_call.id if hasattr(tool_call, 'id') else tool_call.get('id')
function_name = None
try:
if isinstance(tool_call, ToolCall):
function_name = tool_call.function["name"]
raw_arguments = tool_call.function["arguments"]
else:
function_name = tool_call.function.name
raw_arguments = tool_call.function.arguments
return function_name, json.loads(raw_arguments), tool_call_id, None
except (json.JSONDecodeError, KeyError, AttributeError, TypeError) as e:
return function_name, None, tool_call_id, e
def process_stream_chunks(chunks):
"""Process streaming chunks into combined response"""
if not chunks:
@@ -1559,10 +1579,13 @@ class OpenAIClient:
params = {
"model": model,
"messages": messages,
"temperature": temperature,
"stream": stream,
**kwargs
}
# Omit temperature when unset so the provider default applies rather
# than sending an explicit None.
if temperature is not None:
params["temperature"] = temperature
# Add tools if provided
if tools:
@@ -1620,10 +1643,13 @@ class OpenAIClient:
params = {
"model": model,
"messages": messages,
"temperature": temperature,
"stream": stream,
**kwargs
}
# Omit temperature when unset so the provider default applies rather
# than sending an explicit None.
if temperature is not None:
params["temperature"] = temperature
# Add tools if provided
if tools:
@@ -1906,13 +1932,19 @@ class OpenAIClient:
# replies for this turn (keeps tool replies consecutive).
_deferred_media_followups = []
for tool_call in tool_calls:
# Handle both ToolCall dataclass and OpenAI object
if isinstance(tool_call, ToolCall):
function_name = tool_call.function["name"]
arguments = json.loads(tool_call.function["arguments"])
else:
function_name = tool_call.function.name
arguments = json.loads(tool_call.function.arguments)
# Handle both ToolCall dataclass and OpenAI object.
# Guard the parse itself so malformed/truncated argument
# JSON is reported back to the model instead of aborting
# the whole run (matches chat_completion_with_tools_stream).
function_name, arguments, _tool_call_id, err = _extract_tool_call_name_and_args(tool_call)
if err is not None:
logging.warning(f"Failed to parse tool call arguments: {err}")
messages.append({
"role": "tool",
"tool_call_id": _tool_call_id,
"content": json.dumps({"error": f"Invalid arguments JSON: {err}"}),
})
continue
# Always trigger callback for tool call tracking (even when verbose=False)
display_tool_call_fn = _get_display_tool_call()
@@ -1921,7 +1953,6 @@ class OpenAIClient:
# Capture failures and report them back to the model instead of
# aborting the whole run (safe-by-default, matching the streaming
# path chat_completion_with_tools_stream).
_tool_call_id = tool_call.id if hasattr(tool_call, 'id') else tool_call.get('id')
try:
tool_result = execute_tool_fn(
function_name,
@@ -2209,13 +2240,19 @@ class OpenAIClient:
# replies for this turn (keeps tool replies consecutive).
_deferred_media_followups = []
for tool_call in tool_calls:
# Handle both ToolCall dataclass and OpenAI object
if isinstance(tool_call, ToolCall):
function_name = tool_call.function["name"]
arguments = json.loads(tool_call.function["arguments"])
else:
function_name = tool_call.function.name
arguments = json.loads(tool_call.function.arguments)
# Handle both ToolCall dataclass and OpenAI object.
# Guard the parse itself so malformed/truncated argument
# JSON is reported back to the model instead of aborting
# the whole run (matches chat_completion_with_tools_stream).
function_name, arguments, _tool_call_id, err = _extract_tool_call_name_and_args(tool_call)
if err is not None:
logging.warning(f"Failed to parse tool call arguments: {err}")
messages.append({
"role": "tool",
"tool_call_id": _tool_call_id,
"content": json.dumps({"error": f"Invalid arguments JSON: {err}"}),
})
continue
# Always trigger callback for tool call tracking (even when verbose=False)
display_tool_call_fn = _get_display_tool_call()
@@ -2228,7 +2265,6 @@ class OpenAIClient:
# Capture failures and report them back to the model instead of
# aborting the whole run (safe-by-default, matching the streaming
# path chat_completion_with_tools_stream).
_tool_call_id = tool_call.id if hasattr(tool_call, 'id') else tool_call.get('id')
try:
if asyncio.iscoroutinefunction(execute_tool_fn):
tool_result = await execute_tool_fn(
@@ -2451,16 +2487,14 @@ class OpenAIClient:
_deferred_media_followups = []
for tool_call in tool_calls:
# Handle both ToolCall dataclass and OpenAI object
try:
if isinstance(tool_call, ToolCall):
function_name = tool_call.function["name"]
arguments = json.loads(tool_call.function["arguments"])
else:
function_name = tool_call.function.name
arguments = json.loads(tool_call.function.arguments)
except json.JSONDecodeError as e:
function_name, arguments, _, err = _extract_tool_call_name_and_args(tool_call)
if err is not None:
# Preserve original behaviour: only malformed JSON is
# reported to the caller; other errors propagate.
if not isinstance(err, json.JSONDecodeError):
raise err
if verbose:
yield f"\n[Error parsing arguments for {function_name if 'function_name' in locals() else 'unknown function'}: {str(e)}]"
yield f"\n[Error parsing arguments for {function_name if function_name is not None else 'unknown function'}: {str(err)}]"
continue
# Always trigger callback for tool call tracking (even when verbose=False)
@@ -0,0 +1,137 @@
"""
Provider Quota Coordination for PraisonAI Agents.
Provides a lightweight, protocol-driven seam so provider-quota state
(credential cooldowns / benches) can be coordinated *fleet-wide* when a
shared backend is configured, while defaulting to today's in-process,
in-memory behaviour with zero new dependencies and no hot-path change.
Design:
- ``QuotaCoordinatorProtocol`` is a pure contract (stdlib + typing only).
- ``LocalQuotaCoordinator`` is the default in-memory implementation used
when no shared backend is selected — single-replica deployments behave
exactly as before.
- A concrete shared backend (e.g. Redis, reusing the gateway's existing
connection) implements the same protocol in the wrapper/bot package and
is selected via ``QuotaCoordinatorConfig``. Core keeps only the protocol
and the in-memory default.
Fail-open by contract: implementations MUST degrade to local behaviour on
backend errors rather than wedge a healthy request path, and bench entries
carry TTLs so a dead replica's benches self-expire.
"""
from __future__ import annotations
import time
from dataclasses import dataclass
from typing import Dict, Optional, Protocol, runtime_checkable
@runtime_checkable
class QuotaCoordinatorProtocol(Protocol):
"""Contract for coordinating provider-quota state across replicas.
A coordinator tracks per-credential cooldowns ("benches"). When a shared
backend is configured, a credential benched by any replica is treated as
benched by all replicas until its cooldown expires.
"""
def bench(self, cred_id: str, *, until: float, reason: str = "") -> None:
"""Bench a credential until ``until`` (an epoch timestamp, TTL-based)."""
...
def is_benched(self, cred_id: str, *, now: Optional[float] = None) -> bool:
"""Return True if the credential is currently benched."""
...
def benched_until(self, cred_id: str, *, now: Optional[float] = None) -> Optional[float]:
"""Return the epoch timestamp the credential is benched until, or None."""
...
def clear(self, cred_id: str) -> None:
"""Clear any bench for the credential (e.g. on recovery)."""
...
@dataclass
class QuotaCoordinatorConfig:
"""Configuration for provider-quota coordination.
Attributes:
backend: ``"local"`` (in-memory, default) or a shared backend name
such as ``"redis"`` provided by the wrapper/bot package.
url: Optional backend URL; when omitted a shared backend reuses the
already-established connection (e.g. gateway ``RedisConfig``).
"""
backend: str = "local"
url: Optional[str] = None
def to_dict(self) -> Dict[str, Optional[str]]:
return {"backend": self.backend, "url": self.url}
@classmethod
def from_dict(cls, data: Dict[str, Optional[str]]) -> "QuotaCoordinatorConfig":
return cls(
backend=(data.get("backend") or "local"),
url=data.get("url"),
)
class LocalQuotaCoordinator:
"""In-memory ``QuotaCoordinatorProtocol`` (default, zero-dependency).
Thread-safe via a lightweight lock. Bench entries carry an expiry so
they self-clear once the cooldown passes — mirroring the TTL semantics a
shared backend uses so behaviour is identical across implementations.
"""
def __init__(self) -> None:
import threading
self._benches: Dict[str, float] = {}
self._lock = threading.Lock()
def bench(self, cred_id: str, *, until: float, reason: str = "") -> None:
with self._lock:
existing = self._benches.get(cred_id)
# Keep the longest cooldown if a longer one is already set.
if existing is None or until > existing:
self._benches[cred_id] = until
def is_benched(self, cred_id: str, *, now: Optional[float] = None) -> bool:
return self.benched_until(cred_id, now=now) is not None
def benched_until(self, cred_id: str, *, now: Optional[float] = None) -> Optional[float]:
current = time.time() if now is None else now
with self._lock:
until = self._benches.get(cred_id)
if until is None:
return None
if current >= until:
# Expired — self-clear.
self._benches.pop(cred_id, None)
return None
return until
def clear(self, cred_id: str) -> None:
with self._lock:
self._benches.pop(cred_id, None)
def build_quota_coordinator(
config: Optional[QuotaCoordinatorConfig] = None,
) -> QuotaCoordinatorProtocol:
"""Build a coordinator from config, defaulting to the local in-memory one.
Only the ``"local"`` backend is resolvable from core. Shared backends
(e.g. ``"redis"``) are provided by the wrapper/bot package, which passes
an already-constructed coordinator instance to ``FailoverManager``; this
helper falls back to local for unknown backends so core never grows a
heavy optional dependency.
"""
if config is None or config.backend == "local":
return LocalQuotaCoordinator()
# Unknown/heavy backend not resolvable in core: fail open to local.
return LocalQuotaCoordinator()
@@ -11,30 +11,83 @@ from __future__ import annotations
import importlib
from typing import Any, Optional
_INSTALL_HINT = "Remote compute requires the wrapper package: pip install praisonai"
_INSTALL_HINT = "Remote compute requires: pip install praisonai-sandbox"
# name -> (module, attribute). Kept in sync with
# praisonai.integrations.managed_local._resolve_compute
_PROVIDERS = {
"local": ("praisonai.integrations.compute.local", "LocalCompute"),
"docker": ("praisonai.integrations.compute.docker", "DockerCompute"),
"e2b": ("praisonai.integrations.compute.e2b", "E2BCompute"),
"modal": ("praisonai.integrations.compute.modal_compute", "ModalCompute"),
"daytona": ("praisonai.integrations.compute.daytona", "DaytonaCompute"),
"flyio": ("praisonai.integrations.compute.flyio", "FlyioCompute"),
"tenki": ("praisonai.integrations.compute.tenki", "TenkiCompute"),
"local": ("praisonai_sandbox.compute.local", "LocalCompute"),
"docker": ("praisonai_sandbox.compute.docker", "DockerCompute"),
"e2b": ("praisonai_sandbox.compute.e2b", "E2BCompute"),
"modal": ("praisonai_sandbox.compute.modal_compute", "ModalCompute"),
"daytona": ("praisonai_sandbox.compute.daytona", "DaytonaCompute"),
"flyio": ("praisonai_sandbox.compute.flyio", "FlyioCompute"),
"tenki": ("praisonai_sandbox.compute.tenki", "TenkiCompute"),
}
# What to actually type when a provider is missing. Every name here must point
# at an extra that EXISTS and installs something -- three of these used to name
# extras that were absent or empty, so a user followed the official hint, waited
# for the install, and hit the identical failure again.
#
# The providers in _PROVIDERS now live in praisonai-sandbox, so the failing
# import is `praisonai_sandbox.compute.*`: point the hint at the lightweight
# package that owns the module, not the heavy wrapper. Reaching E2B through
# praisonai-sandbox[e2b] resolves 58 packages against 143 through praisonai.
# Sandbox-only places (novita/sandlock/ssh) resolve through the
# SandboxComputeAdapter and only need `praisonai-sandbox`.
_EXTRA_HINTS = {
"e2b": "pip install praisonai[e2b]",
"modal": "pip install praisonai[modal]",
"daytona": "pip install praisonai[daytona]",
"e2b": "pip install 'praisonai-sandbox[e2b]'",
"modal": "pip install 'praisonai-sandbox[modal]'",
"daytona": "pip install 'praisonai-sandbox[daytona]'",
"docker": "pip install 'praisonai-sandbox[docker]'",
"novita": "pip install 'praisonai-sandbox[novita]'",
"sandlock": "pip install 'praisonai-sandbox[sandlock]'",
"ssh": "pip install 'praisonai-sandbox[ssh]'",
# flyio and tenki need a credential rather than an SDK; flyio speaks plain
# HTTP through aiohttp, which praisonaiagents already requires. Export the
# variable so a child process inherits it -- a bare assignment would not.
"flyio": "export FLY_API_TOKEN=... (see https://fly.io/docs/flyctl/auth-token)",
"tenki": "pip install 'praisonai-sandbox[tenki]'",
}
# Places that live only in praisonai-sandbox. They speak SandboxProtocol
# (one object IS one environment) rather than ComputeProviderProtocol (one
# object hands out many), so an adapter supplies the missing half.
from ._sandbox_adapter import NEEDS_INSTANCE, SANDBOX_ONLY # noqa: E402
# Spellings users already have in their code, mapped to the canonical name.
_ALIASES = {"native": "sandlock"}
def _entry_point_providers() -> dict:
"""Places contributed by other installed packages.
The sandbox and managed-backend registries already discover plugins this
way (``praisonai.sandbox``, ``praisonai.managed_backends``); the compute
registry was the one hardcoded dict, so adding a place meant editing core.
A provider can now ship in its own distribution:
[project.entry-points."praisonai.compute"]
runpod = "praisonai_compute_runpod:RunpodCompute"
"""
found = {}
try:
from importlib.metadata import entry_points
for ep in entry_points(group="praisonai.compute"):
found[ep.name.lower()] = ep
except Exception: # pragma: no cover - discovery must never break resolution
pass
return found
def available_providers() -> list:
"""Return the compute provider names this bridge can resolve."""
return sorted(_PROVIDERS)
"""Every place ``tools_run_on=`` / ``run_in=`` accepts, from all registries."""
return sorted(
set(_PROVIDERS) | set(SANDBOX_ONLY) | set(_entry_point_providers())
)
def compute_package_available() -> bool:
@@ -58,15 +111,44 @@ def resolve_compute(compute: Optional[Any]) -> Optional[Any]:
if not isinstance(compute, str):
if hasattr(compute, "provision") and hasattr(compute, "execute"):
return compute
# A SandboxProtocol instance -- e.g. SSHSandbox(host=...) -- is adapted,
# which is the only way to pass connection details.
if hasattr(compute, "run_command") and hasattr(compute, "start"):
from ._sandbox_adapter import wrap_sandbox_instance
return wrap_sandbox_instance(compute)
raise TypeError(
f"compute= expects a provider name or a ComputeProviderProtocol "
f"instance, got {type(compute).__name__}"
)
name = compute.lower().strip()
name = _ALIASES.get(name, name)
# A sandbox-only place: adapt it to the compute-provider shape.
if name in SANDBOX_ONLY:
if name in NEEDS_INSTANCE:
raise ValueError(
f"{name!r} needs connection details a bare name cannot carry. "
f"Instead, {NEEDS_INSTANCE[name]}"
)
from ._sandbox_adapter import SandboxComputeAdapter
return SandboxComputeAdapter(name)
external = _entry_point_providers()
if name in external and name not in _PROVIDERS:
# Let a contributed place describe itself. Without this the repr falls
# back to the bare name, because the phrase table is a literal that
# cannot know about packages installed later.
_remember_display_name(name, external[name])
# A place contributed by another package. Loaded on demand, so an
# installed-but-broken plugin cannot break anything that never names it.
return external[name].load()()
if name not in _PROVIDERS:
raise ValueError(
f"Unknown compute provider {name!r}. "
f"Unknown place {name!r}. "
f"Available: {', '.join(available_providers())}"
)
@@ -78,3 +160,23 @@ def resolve_compute(compute: Optional[Any]) -> Optional[Any]:
raise ImportError(f"compute={name!r} requires {module_name}. {hint}") from exc
return getattr(module, attr)()
#: Display phrases contributed by external providers, filled in on resolve.
_DISPLAY_NAMES: dict = {}
def _remember_display_name(name: str, entry_point) -> None:
"""Record a contributed provider's own phrase, if it declares one."""
try:
cls = entry_point.load()
phrase = getattr(cls, "display_name", None)
if isinstance(phrase, str) and phrase:
_DISPLAY_NAMES[name] = phrase
except Exception: # pragma: no cover - naming must never break resolution
pass
def contributed_display_name(name: str):
"""The phrase a contributed place declared for itself, if any."""
return _DISPLAY_NAMES.get((name or "").lower())
@@ -0,0 +1,254 @@
"""Expose a single sandbox environment as a one-instance compute provider.
There are two execution stacks in this project and they are *not* duplicates:
* ``SandboxProtocol`` (praisonai-sandbox) -- one object **is** one environment:
``start / stop / execute / run_command / reset``.
* ``ComputeProviderProtocol`` -- one object **hands out** many environments:
``provision / execute(instance_id, ...) / shutdown / list_instances``.
``tools_run_on=`` speaks the second protocol, so four backends that only exist
as sandboxes -- ``subprocess``, ``sandlock``, ``ssh``, ``novita`` -- were
unreachable through it. This adapter is the missing half: it holds exactly one
environment and presents the manager-shaped API over it.
Deliberate limitation: ``list_instances()`` can only report what *this process*
provisioned, so adapter-backed places never appear in ``praisonai managed ps``.
A single environment has no cross-process registry to consult, and pretending
otherwise would be worse than saying so.
"""
from __future__ import annotations
import logging
import uuid
from typing import Any, Dict, List, Optional
logger = logging.getLogger(__name__)
# Backends that exist only as SandboxProtocol implementations. The literal is
# the floor, not the ceiling: the sandbox registry accepts plugins by entry
# point, so a hardcoded tuple silently withheld contributed backends from
# tools_run_on=. `capsule` was the live example -- it ships from
# praisonai-plugins, worked with run_in=, and was invisible to tools_run_on=.
_SANDBOX_ONLY_FLOOR = ("subprocess", "sandlock", "ssh", "novita")
def sandbox_only_names() -> tuple:
"""Sandbox backends with no compute-registry equivalent.
Anything the compute registry already provides is excluded, so a name that
exists in both (docker, e2b, modal, daytona) keeps its richer compute
implementation rather than being downgraded to the one-instance adapter.
"""
names = set(_SANDBOX_ONLY_FLOOR)
try:
from ..sandbox._sandbox_bridge import get_sandbox_registry
registry = get_sandbox_registry()
registry = registry.default() if isinstance(registry, type) else registry
names |= {str(n).lower() for n in registry.list_all_names()}
except Exception: # pragma: no cover - discovery must never break resolution
pass
try:
from ._compute_bridge import _PROVIDERS
names -= set(_PROVIDERS)
except Exception:
pass
return tuple(sorted(names))
class _SandboxOnly(tuple):
"""A tuple that re-reads the registry, so `in` sees plugins installed later.
Kept as a tuple subclass because SANDBOX_ONLY is imported and iterated in
several places that predate this.
"""
def __contains__(self, item):
return item in sandbox_only_names()
def __iter__(self):
return iter(sandbox_only_names())
def __len__(self):
return len(sandbox_only_names())
SANDBOX_ONLY = _SandboxOnly(_SANDBOX_ONLY_FLOOR)
# Names that need connection details no bare string can carry.
NEEDS_INSTANCE = {
"ssh": (
"run on a remote machine over SSH by passing the object, so it can "
"carry the host: SSHSandbox(host='...', user='...')"
),
}
class SandboxComputeAdapter:
"""One ``SandboxProtocol`` environment, wearing the compute-provider shape."""
def __init__(self, sandbox_type: str, config: Optional[Any] = None,
sandbox: Optional[Any] = None):
self._type = sandbox_type
self._config = config
self._sandbox = sandbox # pre-built instance, if supplied
self._owns_sandbox = sandbox is None
self._instance_id: Optional[str] = None
# ── identity ─────────────────────────────────────────────────────────────
@property
def provider_name(self) -> str:
return self._type
@property
def is_available(self) -> bool:
if self._sandbox is not None:
return bool(getattr(self._sandbox, "is_available", True))
try:
from ..sandbox._sandbox_bridge import resolve_sandbox_class
cls = resolve_sandbox_class(self._type)
probe = cls() if self._type not in NEEDS_INSTANCE else None
return bool(getattr(probe, "is_available", False)) if probe else False
except Exception:
return False
# ── lifecycle ────────────────────────────────────────────────────────────
async def provision(self, config: Any) -> Any:
from .protocols import InstanceInfo, InstanceStatus
if self._sandbox is None:
from ..sandbox import SandboxConfig
from ..sandbox.manager import SandboxManager
cfg = self._config
if cfg is None:
# "/workspace" is the convention for *container* sandboxes and
# does not exist on a Mac or a bare Linux box -- creating it
# fails with "Read-only file system". Local backends pick their
# own private temp dir, so only pass a working_dir through when
# the caller actually chose one.
wanted_dir = getattr(config, "working_dir", None)
local_place = self._type in ("subprocess", "sandlock")
if local_place and wanted_dir in (None, "", "/workspace"):
wanted_dir = None
cfg = SandboxConfig(
sandbox_type=self._type,
env=dict(getattr(config, "env", None) or {}),
**({"working_dir": wanted_dir} if wanted_dir else {}),
)
# This sandbox exists to back the model's execute_command tool,
# which IS a shell. The default policy sets allow_subprocess=
# False, which makes `sh -c` -- and therefore every pipe,
# redirect and && the model writes -- fail as "disabled by
# security policy". Blocking the shell inside a shell tool is a
# contradiction, not a protection; blocked_commands and
# blocked_paths still apply.
if getattr(cfg, "security_policy", None) is not None:
cfg.security_policy.allow_subprocess = True
if getattr(config, "image", None):
cfg.image = config.image
self._manager = SandboxManager(cfg)
self._sandbox = await self._manager.__aenter__()
else:
self._manager = None
starter = getattr(self._sandbox, "start", None)
if starter is not None:
await starter()
self._instance_id = f"{self._type}_{uuid.uuid4().hex[:12]}"
logger.info("[sandbox_adapter] provisioned %s as %s", self._type, self._instance_id)
return InstanceInfo(
instance_id=self._instance_id,
status=InstanceStatus.RUNNING,
endpoint=f"{self._type}://local",
provider=self._type,
metadata={"adapter": True, "discoverable": False},
)
async def execute(self, instance_id: str, command: str,
timeout: Optional[int] = 300) -> Dict[str, Any]:
if self._sandbox is None:
raise RuntimeError(
f"{self._type} sandbox is not running; provision() was not called"
)
# The bridged execute_command tool hands us a shell command string, and
# models write pipes, redirects and && constantly. Without shell=True
# `echo x > f` is argv-split and "> f" arrives as a literal argument.
try:
result = await self._sandbox.run_command(command, shell=True)
except TypeError:
# Backends predating the shell= parameter.
result = await self._sandbox.run_command(command)
# A policy denial arrives as result.error with exit_code=None. Dropping
# it would turn "blocked by security policy" into a silent success --
# the caller would see exit 0 and empty output.
error = getattr(result, "error", None)
exit_code = getattr(result, "exit_code", None)
stderr = getattr(result, "stderr", "") or ""
if error:
stderr = f"{stderr}\n{error}".strip() if stderr else str(error)
if exit_code in (None, 0):
exit_code = 1
return {
"stdout": getattr(result, "stdout", "") or "",
"stderr": stderr,
"exit_code": exit_code or 0,
}
async def shutdown(self, instance_id: str) -> None:
try:
if getattr(self, "_manager", None) is not None:
await self._manager.__aexit__(None, None, None)
elif self._sandbox is not None:
stopper = getattr(self._sandbox, "stop", None)
if stopper is not None:
await stopper()
finally:
if self._owns_sandbox:
self._sandbox = None
self._manager = None
self._instance_id = None
async def get_status(self, instance_id: str) -> Any:
from .protocols import InstanceInfo, InstanceStatus
running = self._sandbox is not None and instance_id == self._instance_id
return InstanceInfo(
instance_id=instance_id,
status=InstanceStatus.RUNNING if running else InstanceStatus.STOPPED,
provider=self._type,
)
async def list_instances(self) -> List[Any]:
"""Only what this process provisioned -- see the module docstring."""
from .protocols import InstanceInfo, InstanceStatus
if self._instance_id is None:
return []
return [InstanceInfo(
instance_id=self._instance_id,
status=InstanceStatus.RUNNING,
provider=self._type,
metadata={"adapter": True, "discoverable": False},
)]
# ── file transfer ────────────────────────────────────────────────────────
async def upload_file(self, instance_id: str, local_path: str, remote_path: str) -> None:
with open(local_path, "r") as handle:
await self._sandbox.write_file(remote_path, handle.read())
async def download_file(self, instance_id: str, remote_path: str, local_path: str) -> None:
content = await self._sandbox.read_file(remote_path)
with open(local_path, "w") as handle:
handle.write(content if isinstance(content, str) else str(content))
def wrap_sandbox_instance(sandbox: Any) -> SandboxComputeAdapter:
"""Adapt an already-constructed sandbox (e.g. ``SSHSandbox(host=...)``)."""
name = getattr(sandbox, "sandbox_type", None) or type(sandbox).__name__.lower()
return SandboxComputeAdapter(str(name), sandbox=sandbox)
@@ -17,6 +17,7 @@ import logging
import shlex
import threading
import uuid
import weakref
from typing import Any, Dict, List, Optional
from ._compute_bridge import resolve_compute
@@ -118,8 +119,13 @@ class SharedCompute:
def shutdown(self) -> None:
"""Tear down the instance and restore any agents we patched."""
for agent, original_tools, original_backstory in self._patched:
for ref, original_tools, original_backstory in self._patched:
agent = ref()
if agent is None:
continue # already collected; nothing left to restore
try:
if getattr(agent, "_tools_sandbox", None) is self:
agent._tools_sandbox = None
agent.tools = original_tools
agent.backstory = original_backstory
cache = getattr(agent, "_system_prompt_cache", None)
@@ -136,6 +142,8 @@ class SharedCompute:
logger.info("[shared_compute] shut down instance %s", self.instance_id)
except Exception as exc: # pragma: no cover - teardown must not mask errors
logger.warning("[shared_compute] shutdown failed for %s: %s", self.instance_id, exc)
self.instance_id = None
raise # the caller logs whether the sandbox was released
finally:
self.instance_id = None
@@ -187,9 +195,14 @@ class SharedCompute:
# heredoc early (which would truncate the file and run the remainder
# as shell commands). Guard against the astronomically-unlikely case
# where the token still appears in the body.
delimiter = f"__PRAISON_EOF_{uuid.uuid4().hex}__"
# Uppercase hex on purpose. uuid4().hex is lowercase, and the
# security policy substring-matches blocked_commands against the
# whole command -- "dd" is one of them, and appears in 9.6% of
# random lowercase hex strings. One write in ten failed with
# "Blocked command pattern: dd" for no reason the caller could see.
delimiter = f"__PRAISON_EOF_{uuid.uuid4().hex.upper()}__"
while delimiter in content:
delimiter = f"__PRAISON_EOF_{uuid.uuid4().hex}__"
delimiter = f"__PRAISON_EOF_{uuid.uuid4().hex.upper()}__"
heredoc = (
f"mkdir -p $(dirname {quoted}) && "
f"cat > {quoted} <<'{delimiter}'\n{content}\n{delimiter}"
@@ -203,13 +216,25 @@ class SharedCompute:
"""List files in a directory on the shared remote sandbox."""
return self._format(self.run_command(f"ls -la {shlex.quote(path)}"))
return [execute_command, read_file, write_file, list_files]
bridged = [execute_command, read_file, write_file, list_files]
# Tag them so Agent.clone_for_channel() drops them: each closes over
# THIS sandbox, so a clone inheriting them would talk to the original
# agent's instance and then attach a second sandbox of its own --
# duplicating the capability prompt and splitting its work across two
# machines. The clone regenerates its own on first use.
for tool in bridged:
tool._praison_sandbox_tool = True
return bridged
def attach(self, agents: List[Any]) -> None:
def attach(self, agents: List[Any], *, override_declared: bool = False) -> None:
"""Give each agent the shared tools and tell it they exist.
Agents that already carry their own managed ``backend`` are skipped --
they have deliberately been pointed at their own runtime.
``override_declared`` is set only by the agent's *own* placement, which
is this sandbox's whole reason for existing. A run-level sandbox leaves
it False so an agent that named its own place keeps it.
"""
tools = self.build_tools()
by_name = {t.__name__: t for t in tools}
@@ -217,6 +242,31 @@ class SharedCompute:
for agent in agents:
if agent is None or getattr(agent, "backend", None) is not None:
continue
# An agent that named its own place, or already has a sandbox, must
# not be attached again. A second attach appends CAPABILITY_PROMPT
# twice and, if the two teardowns do not happen in LIFO order,
# permanently restores the wrong tools: the agent is left holding
# four tools bound to a shut-down instance.
#
# `tools_run_on` is checked as well as `_tools_sandbox` because of
# ordering: a flow attaches at the start of the run, before the
# agent's first chat() has created its own sandbox. Checking only
# the live sandbox would attach here and let the agent attach again
# on its first turn. An explicit per-agent choice outranks the run's
# default, so the flow leaves it alone.
declared_own = (
not override_declared
and getattr(agent, "tools_run_on", None) is not None
)
if getattr(agent, "_tools_sandbox", None) is not None or declared_own:
logger.debug(
"[shared_compute] %r already runs its tools on %s; leaving it alone",
getattr(agent, "name", agent),
getattr(agent, "tools_run_on", "its own sandbox"),
)
continue
if any(agent is ref() for ref, _, _ in self._patched):
continue
original_tools = list(getattr(agent, "tools", None) or [])
# Agent.__init__ copies `instructions` into role/goal/backstory and
@@ -248,4 +298,18 @@ class SharedCompute:
logger.warning("[shared_compute] could not attach tools to %r: %s", agent, exc)
continue
self._patched.append((agent, original_tools, original_backstory))
# Mark where this agent's tools now run, so a nested attach (or a
# later ensure_tools_placed) can see it is already bound.
try:
agent._tools_sandbox = self
except Exception: # pragma: no cover - exotic agent objects
pass
# Weakly: an agent points at its SharedCompute and the SharedCompute
# pointed back, so a dropped agent was reclaimed as a cycle and its
# sandbox was never shut down. Holding the agent weakly lets
# weakref.finalize see the agent die and release the sandbox.
try:
ref = weakref.ref(agent)
except TypeError: # pragma: no cover - non-weakrefable agent
ref = lambda _agent=agent: _agent
self._patched.append((ref, original_tools, original_backstory))
@@ -51,6 +51,12 @@ _LAZY_IMPORTS = {
"get_redirect_url": _t("praisonaiagents.mcp.mcp_oauth_callback", "get_redirect_url"),
"OAUTH_CALLBACK_PORT": _t("praisonaiagents.mcp.mcp_oauth_callback", "OAUTH_CALLBACK_PORT"),
"OAUTH_CALLBACK_PATH": _t("praisonaiagents.mcp.mcp_oauth_callback", "OAUTH_CALLBACK_PATH"),
# Zero-config OAuth: discovery, dynamic registration, orchestration.
"discover_oauth_metadata": _t("praisonaiagents.mcp.oauth_discovery", "discover_oauth_metadata"),
"parse_www_authenticate": _t("praisonaiagents.mcp.oauth_discovery", "parse_www_authenticate"),
"register_client": _t("praisonaiagents.mcp.oauth_registration", "register_client"),
"MCPOAuthProvider": _t("praisonaiagents.mcp.oauth_provider", "MCPOAuthProvider"),
"InteractiveAuthRequired": _t("praisonaiagents.mcp.oauth_provider", "InteractiveAuthRequired"),
# Protocols (lazy loaded)
"MCPClientProtocol": _t("praisonaiagents.mcp.protocols", "MCPClientProtocol"),
# Loader (lazy loaded)
@@ -100,4 +106,10 @@ __all__ = [
"get_redirect_url",
"OAUTH_CALLBACK_PORT",
"OAUTH_CALLBACK_PATH",
# Zero-config OAuth (lazy loaded)
"discover_oauth_metadata",
"parse_www_authenticate",
"register_client",
"MCPOAuthProvider",
"InteractiveAuthRequired",
]
@@ -0,0 +1,231 @@
"""
MCP OAuth Metadata Discovery.
Implements the discovery half of zero-config OAuth for remote MCP servers:
- Parse a ``WWW-Authenticate: Bearer resource_metadata="..."`` challenge from a
``401`` response (RFC 9728 / MCP authorization spec).
- Fetch protected-resource metadata (``/.well-known/oauth-protected-resource``).
- Fetch authorization-server metadata
(``/.well-known/oauth-authorization-server`` with an OpenID configuration
fallback), yielding ``authorization_endpoint``, ``token_endpoint`` and
``registration_endpoint``.
Network access is HTTPS-only (except loopback) to preserve the SSRF-safe
posture used elsewhere in the MCP transports. ``requests`` is imported lazily so
this module stays additive and does not affect import time.
"""
import re
from typing import Any, Dict, List, Optional
from urllib.parse import urljoin, urlparse
from praisonaiagents._logging import get_logger
logger = get_logger("mcp-oauth-discovery")
_LOCALHOST_HOSTS = {"localhost", "127.0.0.1", "::1"}
def _require_https(url: str) -> None:
"""Reject non-HTTPS metadata URLs (loopback HTTP is allowed for testing)."""
parsed = urlparse(url)
if parsed.scheme == "https":
return
if parsed.scheme == "http" and (parsed.hostname or "") in _LOCALHOST_HOSTS:
return
raise ValueError(
f"Refusing to fetch OAuth metadata over insecure transport: {url!r}"
)
def parse_www_authenticate(header: Optional[str]) -> Dict[str, str]:
"""
Parse a ``WWW-Authenticate`` challenge header into its parameters.
Only ``Bearer`` challenges are relevant here. Returns a dict of the
``key="value"`` auth-params (e.g. ``resource_metadata``, ``scope``,
``error``). Returns an empty dict when the header is missing or not a
Bearer challenge.
"""
if not header:
return {}
# Strip the leading scheme (e.g. "Bearer ") if present.
stripped = header.strip()
if stripped.lower().startswith("bearer"):
stripped = stripped[len("bearer"):].lstrip()
params: Dict[str, str] = {}
for match in re.finditer(r'(\w+)\s*=\s*"([^"]*)"', stripped):
params[match.group(1).lower()] = match.group(2)
return params
def _get_json(url: str, timeout: float = 10.0) -> Dict[str, Any]:
"""Fetch and parse a JSON metadata document over HTTPS.
Redirects are followed but every hop — including the final destination — is
re-validated with :func:`_require_https` so a redirect cannot escape the
HTTPS/loopback guard to an internal or plaintext endpoint (SSRF-safe).
"""
_require_https(url)
import requests # lazy import — optional dependency
resp = requests.get(
url,
headers={"Accept": "application/json"},
timeout=timeout,
allow_redirects=True,
)
# Re-validate every redirect hop and the final URL: allow_redirects only
# checks the initial URL, so a 30x to http:// or an internal host would
# otherwise bypass the guard.
for previous in getattr(resp, "history", None) or []:
_require_https(previous.url)
_require_https(resp.url)
resp.raise_for_status()
return resp.json()
def _wellknown_candidates(server_url: str) -> List[str]:
"""Build ``.well-known`` metadata URL candidates for a server URL."""
parsed = urlparse(server_url)
origin = f"{parsed.scheme}://{parsed.netloc}"
return [
urljoin(origin + "/", ".well-known/oauth-protected-resource"),
urljoin(origin + "/", ".well-known/oauth-authorization-server"),
urljoin(origin + "/", ".well-known/openid-configuration"),
]
def discover_protected_resource(
server_url: str,
resource_metadata_url: Optional[str] = None,
timeout: float = 10.0,
) -> Optional[Dict[str, Any]]:
"""
Discover protected-resource metadata for an MCP server.
Args:
server_url: The MCP server URL that returned a 401.
resource_metadata_url: Optional explicit URL from the
``WWW-Authenticate: resource_metadata="..."`` challenge.
timeout: Per-request timeout in seconds.
Returns:
The protected-resource metadata document, or None if unavailable.
"""
url = resource_metadata_url or _wellknown_candidates(server_url)[0]
try:
return _get_json(url, timeout=timeout)
except Exception as exc: # noqa: BLE001 - discovery is best-effort
logger.debug(f"Protected-resource metadata unavailable at {url}: {exc}")
return None
def discover_authorization_server(
server_url: str,
authorization_servers: Optional[List[str]] = None,
timeout: float = 10.0,
) -> Optional[Dict[str, Any]]:
"""
Discover authorization-server metadata.
Tries, in order: any ``authorization_servers`` advertised by the
protected-resource metadata, then the server-origin
``/.well-known/oauth-authorization-server`` and OpenID-configuration
fallbacks.
Returns the first metadata document that exposes at least an
``authorization_endpoint`` and ``token_endpoint``, or None.
"""
candidates: List[str] = []
for issuer in authorization_servers or []:
issuer = issuer.rstrip("/")
candidates.append(issuer + "/.well-known/oauth-authorization-server")
candidates.append(issuer + "/.well-known/openid-configuration")
# Fall back to the resource server's own origin.
for candidate in _wellknown_candidates(server_url)[1:]:
candidates.append(candidate)
for url in candidates:
try:
metadata = _get_json(url, timeout=timeout)
except Exception as exc: # noqa: BLE001 - best-effort discovery
logger.debug(f"Auth-server metadata unavailable at {url}: {exc}")
continue
if metadata.get("authorization_endpoint") and metadata.get("token_endpoint"):
return metadata
return None
def discover_oauth_metadata(
server_url: str,
www_authenticate: Optional[str] = None,
timeout: float = 10.0,
) -> Optional[Dict[str, Any]]:
"""
Full metadata discovery for an OAuth-protected MCP server.
Combines the ``WWW-Authenticate`` challenge (if any), protected-resource
metadata, and authorization-server metadata into a single normalised dict:
{
"authorization_endpoint": str,
"token_endpoint": str,
"registration_endpoint": str | None,
"scopes_supported": list[str] | None,
"resource": str | None,
}
Returns None if a usable authorization/token endpoint pair cannot be found.
"""
challenge = parse_www_authenticate(www_authenticate)
resource_meta = discover_protected_resource(
server_url,
resource_metadata_url=challenge.get("resource_metadata"),
timeout=timeout,
)
authorization_servers = None
resource_id = None
if resource_meta:
authorization_servers = resource_meta.get("authorization_servers")
resource_id = resource_meta.get("resource")
auth_meta = discover_authorization_server(
server_url,
authorization_servers=authorization_servers,
timeout=timeout,
)
if not auth_meta:
return None
# Enforce the HTTPS/loopback guard on the advertised endpoints too: an
# HTTPS metadata document must not be able to smuggle a plaintext
# authorization/token/registration endpoint that would later receive
# authorization codes, PKCE verifiers, refresh tokens, or client secrets
# over an insecure transport.
authorization_endpoint = auth_meta["authorization_endpoint"]
token_endpoint = auth_meta["token_endpoint"]
registration_endpoint = auth_meta.get("registration_endpoint")
_require_https(authorization_endpoint)
_require_https(token_endpoint)
if registration_endpoint:
_require_https(registration_endpoint)
return {
"authorization_endpoint": authorization_endpoint,
"token_endpoint": token_endpoint,
"registration_endpoint": registration_endpoint,
"scopes_supported": (
auth_meta.get("scopes_supported")
or (resource_meta or {}).get("scopes_supported")
),
"resource": resource_id,
}
@@ -0,0 +1,340 @@
"""
MCP OAuth Provider — zero-config orchestration.
Composes the OAuth building blocks into a single ``ensure_authenticated`` entry
point that transports invoke on a ``401``:
discovery -> dynamic client registration (if no client stored)
-> PKCE authorization-code flow (browser + loopback callback)
-> token persistence
-> transparent refresh on expiry
All heavy work (network I/O, browser, loopback HTTP server) is lazily imported
and only runs when a server actually challenges for OAuth, so servers without
auth — or with pre-supplied client info/tokens — behave exactly as before.
"""
import time
import webbrowser
from http.server import BaseHTTPRequestHandler, HTTPServer
from threading import Thread
from typing import Any, Dict, Optional
from urllib.parse import urlencode, urlparse, parse_qs
from praisonaiagents._logging import get_logger
from .mcp_oauth_callback import (
OAuthCallbackHandler,
OAUTH_CALLBACK_PORT,
OAUTH_CALLBACK_PATH,
generate_state,
generate_code_verifier,
generate_code_challenge,
get_redirect_url,
)
logger = get_logger("mcp-oauth-provider")
class InteractiveAuthRequired(RuntimeError):
"""Raised when interactive OAuth is needed but not possible (headless/CI)."""
def _make_callback_server(handler: OAuthCallbackHandler, port: int) -> HTTPServer:
"""Build a minimal loopback HTTP server that feeds codes to ``handler``."""
class _Handler(BaseHTTPRequestHandler):
def do_GET(self): # noqa: N802 - required name
parsed = urlparse(self.path)
if parsed.path != OAUTH_CALLBACK_PATH:
self.send_response(404)
self.end_headers()
return
params = parse_qs(parsed.query)
state = (params.get("state") or [""])[0]
code = (params.get("code") or [""])[0]
if state and code:
handler.receive_callback(state, code)
body = b"Authentication complete. You can close this window."
else:
body = b"Authentication failed: missing code or state."
self.send_response(200)
self.send_header("Content-Type", "text/plain")
self.end_headers()
self.wfile.write(body)
def log_message(self, *args, **kwargs): # silence default logging
pass
return HTTPServer(("127.0.0.1", port), _Handler)
class MCPOAuthProvider:
"""
Orchestrates zero-config OAuth for a single remote MCP server.
Args:
mcp_name: Stable identifier used as the storage key.
server_url: The MCP server URL.
storage: Optional pre-built ``MCPAuthStorage`` (created lazily otherwise).
open_browser: Whether to open a browser for interactive auth. Set False
for headless/CI to get a single actionable ``InteractiveAuthRequired``.
"""
def __init__(
self,
mcp_name: str,
server_url: str,
storage: Optional[Any] = None,
open_browser: bool = True,
):
self.mcp_name = mcp_name
self.server_url = server_url
self.open_browser = open_browser
if storage is None:
from .mcp_auth_storage import MCPAuthStorage
storage = MCPAuthStorage()
self.storage = storage
def get_valid_token(self) -> Optional[str]:
"""Return a non-expired access token if one is stored, else None."""
entry = self.storage.get_for_url(self.mcp_name, self.server_url)
if not entry or not entry.get("tokens"):
return None
if self.storage.is_token_expired(self.mcp_name):
refreshed = self._try_refresh(entry)
if not refreshed:
return None
entry = self.storage.get_for_url(self.mcp_name, self.server_url) or {}
tokens = entry.get("tokens") or {}
return tokens.get("access_token")
def ensure_authenticated(
self,
www_authenticate: Optional[str] = None,
timeout: float = 10.0,
) -> str:
"""
Ensure a valid access token exists, running the full flow if needed.
Returns:
A valid bearer access token.
Raises:
InteractiveAuthRequired: If interactive auth is needed but disabled.
RuntimeError: If discovery fails or the flow cannot complete.
"""
token = self.get_valid_token()
if token:
return token
from .oauth_discovery import discover_oauth_metadata
metadata = discover_oauth_metadata(
self.server_url,
www_authenticate=www_authenticate,
timeout=timeout,
)
if not metadata:
raise RuntimeError(
f"Could not discover OAuth metadata for {self.server_url}. "
"The server may not advertise standard authorization-server "
"metadata; supply client credentials manually."
)
client_info = self._ensure_client(metadata, timeout=timeout)
scope = None
scopes = metadata.get("scopes_supported")
if scopes:
scope = " ".join(scopes)
return self._run_pkce_flow(metadata, client_info, scope, timeout=timeout)
def _ensure_client(
self,
metadata: Dict[str, Any],
timeout: float,
) -> Dict[str, Any]:
"""Return stored client info or perform dynamic client registration."""
entry = self.storage.get_for_url(self.mcp_name, self.server_url)
if entry and entry.get("client_info", {}).get("client_id"):
return entry["client_info"]
registration_endpoint = metadata.get("registration_endpoint")
if not registration_endpoint:
raise RuntimeError(
f"No client is registered for {self.server_url} and the "
"authorization server does not support dynamic client "
"registration (no registration_endpoint)."
)
from .oauth_registration import register_client
scope = None
scopes = metadata.get("scopes_supported")
if scopes:
scope = " ".join(scopes)
client_info = register_client(
registration_endpoint,
redirect_uris=[get_redirect_url()],
scope=scope,
timeout=timeout,
)
self.storage.set_client_info(
self.mcp_name, client_info, server_url=self.server_url
)
return client_info
def _run_pkce_flow(
self,
metadata: Dict[str, Any],
client_info: Dict[str, Any],
scope: Optional[str],
timeout: float,
) -> str:
"""Run the interactive PKCE authorization-code flow and store tokens."""
if not self.open_browser:
raise InteractiveAuthRequired(
f"Interactive OAuth is required to authenticate with "
f"{self.server_url}. Run this from an interactive session, or "
f"pre-supply tokens, to complete authentication."
)
callback = OAuthCallbackHandler()
state = generate_state()
code_verifier = generate_code_verifier()
code_challenge = generate_code_challenge(code_verifier)
params = {
"response_type": "code",
"client_id": client_info["client_id"],
"redirect_uri": get_redirect_url(),
"state": state,
"code_challenge": code_challenge,
"code_challenge_method": "S256",
}
if scope:
params["scope"] = scope
if metadata.get("resource"):
params["resource"] = metadata["resource"]
auth_url = f"{metadata['authorization_endpoint']}?{urlencode(params)}"
server = _make_callback_server(callback, OAUTH_CALLBACK_PORT)
thread = Thread(target=server.serve_forever, daemon=True)
thread.start()
try:
logger.debug(f"Opening browser for OAuth authorization: {auth_url}")
webbrowser.open(auth_url)
code = callback.wait_for_callback(state, timeout=300.0)
finally:
server.shutdown()
tokens = self._exchange_code(
metadata, client_info, code, code_verifier, timeout=timeout
)
self.storage.set_tokens(
self.mcp_name, tokens, server_url=self.server_url
)
return tokens["access_token"]
def _exchange_code(
self,
metadata: Dict[str, Any],
client_info: Dict[str, Any],
code: str,
code_verifier: str,
timeout: float,
) -> Dict[str, Any]:
"""Exchange an authorization code for tokens at the token endpoint."""
import requests # lazy import — optional dependency
data = {
"grant_type": "authorization_code",
"code": code,
"redirect_uri": get_redirect_url(),
"client_id": client_info["client_id"],
"code_verifier": code_verifier,
}
if client_info.get("client_secret"):
data["client_secret"] = client_info["client_secret"]
if metadata.get("resource"):
data["resource"] = metadata["resource"]
resp = requests.post(
metadata["token_endpoint"],
data=data,
headers={"Accept": "application/json"},
timeout=timeout,
)
resp.raise_for_status()
return self._normalize_tokens(
resp.json(), token_endpoint=metadata["token_endpoint"]
)
def _try_refresh(self, entry: Dict[str, Any]) -> bool:
"""Attempt a refresh-token grant; return True on success."""
tokens = entry.get("tokens") or {}
refresh_token = tokens.get("refresh_token")
token_endpoint = tokens.get("token_endpoint")
client_info = entry.get("client_info") or {}
client_id = client_info.get("client_id")
if not (refresh_token and token_endpoint and client_id):
return False
try:
from .oauth_discovery import _require_https
# Defense in depth: never POST a refresh token / client secret to a
# persisted endpoint that isn't HTTPS (or loopback).
_require_https(token_endpoint)
import requests # lazy import — optional dependency
data = {
"grant_type": "refresh_token",
"refresh_token": refresh_token,
"client_id": client_id,
}
if client_info.get("client_secret"):
data["client_secret"] = client_info["client_secret"]
resp = requests.post(
token_endpoint,
data=data,
headers={"Accept": "application/json"},
timeout=10.0,
)
resp.raise_for_status()
new_tokens = self._normalize_tokens(
resp.json(), token_endpoint=token_endpoint
)
# Preserve refresh_token if the server didn't return a new one.
if not new_tokens.get("refresh_token"):
new_tokens["refresh_token"] = refresh_token
self.storage.set_tokens(
self.mcp_name, new_tokens, server_url=self.server_url
)
return True
except Exception as exc: # noqa: BLE001 - refresh is best-effort
logger.debug(f"Token refresh failed for {self.mcp_name}: {exc}")
return False
@staticmethod
def _normalize_tokens(
raw: Dict[str, Any],
token_endpoint: Optional[str] = None,
) -> Dict[str, Any]:
"""Normalise a token response, computing an absolute ``expires_at``."""
tokens = dict(raw)
expires_in = tokens.get("expires_in")
if expires_in and not tokens.get("expires_at"):
try:
tokens["expires_at"] = time.time() + float(expires_in)
except (TypeError, ValueError):
pass
if token_endpoint:
tokens["token_endpoint"] = token_endpoint
return tokens
@@ -0,0 +1,91 @@
"""
MCP OAuth Dynamic Client Registration (RFC 7591).
Performs an anonymous dynamic client registration against an authorization
server's ``registration_endpoint`` so that connecting to a hosted MCP server by
URL requires no pre-provisioned ``client_id``. The registered client info is
returned for persistence via :meth:`MCPAuthStorage.set_client_info`.
``requests`` is imported lazily to keep this module additive.
"""
from typing import Any, Dict, List, Optional
from urllib.parse import urlparse
from praisonaiagents._logging import get_logger
logger = get_logger("mcp-oauth-registration")
_LOCALHOST_HOSTS = {"localhost", "127.0.0.1", "::1"}
def _require_https(url: str) -> None:
"""Reject non-HTTPS registration URLs (loopback HTTP allowed for testing)."""
parsed = urlparse(url)
if parsed.scheme == "https":
return
if parsed.scheme == "http" and (parsed.hostname or "") in _LOCALHOST_HOSTS:
return
raise ValueError(
f"Refusing to register client over insecure transport: {url!r}"
)
def register_client(
registration_endpoint: str,
redirect_uris: List[str],
client_name: str = "PraisonAI Agent",
scope: Optional[str] = None,
timeout: float = 10.0,
) -> Dict[str, Any]:
"""
Register a public OAuth client via RFC 7591 Dynamic Client Registration.
Args:
registration_endpoint: The ``registration_endpoint`` from auth-server
metadata.
redirect_uris: Allowed redirect URIs (the loopback callback URL).
client_name: Human-readable client name.
scope: Optional space-delimited scope string to request.
timeout: Request timeout in seconds.
Returns:
The registration response containing at least ``client_id`` (and
``client_secret`` for confidential clients).
Raises:
ValueError: If the endpoint is insecure or the response lacks a
``client_id``.
"""
_require_https(registration_endpoint)
import requests # lazy import — optional dependency
payload: Dict[str, Any] = {
"client_name": client_name,
"redirect_uris": redirect_uris,
"grant_types": ["authorization_code", "refresh_token"],
"response_types": ["code"],
"token_endpoint_auth_method": "none",
}
if scope:
payload["scope"] = scope
resp = requests.post(
registration_endpoint,
json=payload,
headers={"Content-Type": "application/json", "Accept": "application/json"},
timeout=timeout,
)
resp.raise_for_status()
client_info = resp.json()
if not client_info.get("client_id"):
raise ValueError(
"Dynamic client registration response missing 'client_id'"
)
logger.debug(
f"Registered OAuth client '{client_info.get('client_id')}' "
f"at {registration_endpoint}"
)
return client_info
@@ -26,6 +26,7 @@ from .registry import (
list_memory_adapters,
get_first_available_memory_adapter,
has_memory_adapter,
resolve_memory_adapter_name,
)
from .factories import (
create_mem0_memory_adapter,
@@ -53,4 +54,5 @@ __all__ = [
'list_memory_adapters',
'get_first_available_memory_adapter',
'has_memory_adapter',
'resolve_memory_adapter_name',
]
@@ -371,6 +371,39 @@ class ChromaMemoryAdapter:
sanitized[k] = str(v)
return sanitized
def _reset_collection(self) -> None:
"""Delete and recreate this adapter's collection, wiping stored memory.
Short-term and long-term share one collection in this adapter, so both
resets route here. Scoped to this adapter's own collection to avoid
wiping other collections in the shared persistent store.
"""
try:
self.client.delete_collection(name=self.collection_name)
except Exception:
pass
self.collection = self.client.create_collection(
name=self.collection_name,
metadata={"hnsw:space": "cosine"}
)
def reset_short_term(self) -> None:
"""Clear this adapter's memory.
NOTE: this adapter stores short-term and long-term in a single shared
collection (``store_short_term``/``search_short_term`` delegate to their
long-term counterparts and no ``memory_type`` tag is recorded), so
per-tier scoping is not possible here — resetting short-term also clears
long-term. Use a tier-aware backend (e.g. the Dakera adapter) if you need
to erase a single tier.
"""
self._reset_collection()
def reset_long_term(self) -> None:
"""Clear this adapter's memory (shared with short-term; see
``reset_short_term`` for the shared-collection caveat)."""
self._reset_collection()
def close(self):
"""Clean up ChromaDB resources."""
# ChromaDB PersistentClient has no explicit close; release references.
@@ -77,6 +77,17 @@ def has_memory_adapter(name: str) -> bool:
return get_default_memory_registry().is_available(name)
#: Accepted spellings for a backend, mapped to the adapter that serves them.
#: Single source of truth for MemoryConfig, Agent and Memory.
MEMORY_PROVIDER_ALIASES = {"rag": "chroma", "chromadb": "chroma", "none": "in_memory"}
def resolve_memory_adapter_name(name: str) -> Optional[str]:
"""Adapter name for *name*, or None if nothing is registered under it."""
candidate = MEMORY_PROVIDER_ALIASES.get(name, name)
return candidate if has_memory_adapter(candidate) else None
def get_first_available_memory_adapter(
preferences: Optional[List[str]] = None, **kwargs
) -> Optional[Tuple[str, MemoryProtocol]]:
@@ -107,4 +118,6 @@ __all__ = [
'add_memory_adapter',
'add_memory_factory',
'has_memory_adapter',
'resolve_memory_adapter_name',
'MEMORY_PROVIDER_ALIASES',
]
@@ -2,6 +2,7 @@ import os
import sqlite3
import json
import time
import asyncio
import shutil
import threading
from typing import Any, Dict, List, Optional, Union, Literal
@@ -136,16 +137,21 @@ class Memory(SearchMixin, MemoryCoreMixin):
provider = self.cfg.get("provider", "rag").lower()
self._log_verbose(f"Requested memory provider: {provider}")
# Map legacy provider names to adapter names
provider_mapping = {
"rag": "chroma", # Legacy "rag" provider uses ChromaDB
"mem0": "mem0",
"mongodb": "mongodb",
"sqlite": "sqlite",
"none": "in_memory"
}
adapter_name = provider_mapping.get(provider, provider)
# Legacy provider aliases live in memory/adapters/registry.py
from .adapters.registry import (
MEMORY_PROVIDER_ALIASES, list_memory_adapters, resolve_memory_adapter_name)
# A provider with no adapter must fail loudly: falling through landed
# on the SQLite fallback below, so provider="redis" silently produced a
# local .db file per process.
adapter_name = resolve_memory_adapter_name(provider)
if adapter_name is None:
from ..config.parse_utils import make_preset_error
raise make_preset_error(
"memory provider",
provider,
sorted(set(list_memory_adapters()) | set(MEMORY_PROVIDER_ALIASES)),
)
# Try to get preferred adapter, fallback to available ones
adapter = None
@@ -195,8 +201,15 @@ class Memory(SearchMixin, MemoryCoreMixin):
self.provider = adapter_name
return
# Fallback to first available adapter
self._log_verbose(f"Provider '{adapter_name}' not available, trying fallbacks")
# Falling back changes where the data lives - say so out loud when
# the user named a specific provider.
_fallback_log = (
logger.warning if provider_explicitly_requested else self._log_verbose
)
_fallback_log(
f"Memory provider '{adapter_name}' is not available; falling back "
f"to a local store. Data will NOT be in '{adapter_name}'."
)
# Try each fallback preference individually
for fallback_provider in ["sqlite", "in_memory"]:
try:
@@ -204,7 +217,7 @@ class Memory(SearchMixin, MemoryCoreMixin):
adapter = get_memory_adapter(fallback_provider, **fallback_config)
if adapter:
adapter_name = fallback_provider
self._log_verbose(f"Using fallback adapter: {adapter_name}")
_fallback_log(f"Using fallback memory adapter: {adapter_name}")
break
except Exception as e:
self._log_verbose(f"Fallback {fallback_provider} failed: {e}")
@@ -267,6 +280,27 @@ class Memory(SearchMixin, MemoryCoreMixin):
# Initialize use_vector_search to False for non-MongoDB providers
self.use_vector_search = False
@staticmethod
def _path_safe_suffix(user_id: Any) -> str:
"""Return a filesystem-safe ``_<user_id>`` suffix for default store paths.
The scoping ``user_id`` doubles as a metadata filter, so it may be any
string. When it is embedded into default sqlite/chroma paths a raw value
containing separators or traversal (e.g. ``a/b`` or ``../escape``) would
create stores outside the project-data dir or break sqlite init. Reject
path separators/parent refs and keep only path-safe characters; a bare
store with no user_id keeps the original shared defaults.
"""
if not user_id:
return ""
text = str(user_id)
if ".." in text or "/" in text or "\\" in text or "\x00" in text:
raise ValueError(
"memory user_id must not contain path separators or parent references"
)
safe = "".join(c if (c.isalnum() or c in "-_.") else "_" for c in text.strip())
return f"_{safe}" if safe else ""
def _get_adapter_config(self) -> Dict[str, Any]:
"""Get configuration for adapter initialization."""
# Only include adapter-relevant configuration
@@ -284,11 +318,18 @@ class Memory(SearchMixin, MemoryCoreMixin):
from ..paths import get_project_data_dir
project_data = str(get_project_data_dir())
os.makedirs(project_data, exist_ok=True)
config["short_db"] = self.cfg.get("short_db", os.path.join(project_data, "short_term.db"))
config["long_db"] = self.cfg.get("long_db", os.path.join(project_data, "long_term.db"))
config["rag_db_path"] = self.cfg.get("rag_db_path", os.path.join(project_data, "chroma_db"))
config["collection_name"] = self.cfg.get("collection_name", "memory_store")
# When a user_id scopes this store, derive per-user default paths/names so
# two agents in one process/dir don't silently share one on-disk store.
# Explicit short_db/long_db/rag_db_path/collection_name always win; a bare
# store with no user_id keeps the original shared defaults (backwards
# compatible).
suffix = self._path_safe_suffix(self.cfg.get("user_id"))
config["short_db"] = self.cfg.get("short_db", os.path.join(project_data, f"short_term{suffix}.db"))
config["long_db"] = self.cfg.get("long_db", os.path.join(project_data, f"long_term{suffix}.db"))
config["rag_db_path"] = self.cfg.get("rag_db_path", os.path.join(project_data, f"chroma_db{suffix}"))
config["collection_name"] = self.cfg.get("collection_name", f"memory_store{suffix}")
config["verbose"] = self.verbose
# Add specific configurations for different adapters
@@ -325,9 +366,13 @@ class Memory(SearchMixin, MemoryCoreMixin):
# This ensures existing code that accesses _get_stm_conn() still works
from ..paths import get_project_data_dir
project_data = str(get_project_data_dir())
self.short_db = self.cfg.get("short_db", os.path.join(project_data, "short_term.db"))
self.long_db = self.cfg.get("long_db", os.path.join(project_data, "long_term.db"))
# Scope legacy direct-SQLite defaults by user_id so this path matches the
# per-user store paths derived in _get_adapter_config (explicit paths win).
suffix = self._path_safe_suffix(self.cfg.get("user_id"))
self.short_db = self.cfg.get("short_db", os.path.join(project_data, f"short_term{suffix}.db"))
self.long_db = self.cfg.get("long_db", os.path.join(project_data, f"long_term{suffix}.db"))
# Only create separate SQLite adapter if primary adapter is not SQLite
if self.provider != "sqlite":
@@ -346,6 +391,110 @@ class Memory(SearchMixin, MemoryCoreMixin):
self._all_connections = self._sqlite_adapter._all_connections
self._connection_lock = self._sqlite_adapter._connection_lock
@staticmethod
def _resolve_batch_target(method_name: str) -> str:
"""Map a staged write name to its ``store_*`` persistence method."""
target = method_name.replace("add_", "store_", 1)
if target not in ("store_short_term", "store_long_term"):
raise ValueError(f"Unsupported staged memory write {method_name!r}")
return target
def commit_memory_batch(
self,
writes: List[tuple],
*,
deadline: float,
commit_guard: Any = None,
) -> None:
"""Persist a batch of staged memory writes.
Mirrors ``FileMemory.commit_memory_batch`` so the pre-compaction fact
flush (compaction/memory_flush.py) durably commits extracted facts for
sqlite/chroma/mongodb/mem0 backends instead of raising and being
swallowed. Each staged tuple is ``(method_name, args, kwargs)`` produced
by _StagedMemory; ``add_*`` names map to the ``store_*`` equivalents.
The ``store_*`` methods serialize their own SQLite writes with
``_write_lock``; this method therefore must NOT hold that lock while
calling them (it is a non-reentrant ``threading.Lock`` and doing so
would deadlock). Each write goes through ``commit_guard.commit`` so a
write is skipped once the flush has been cancelled or the shared
``deadline`` has passed, honoring the same atomic-commit contract as the
file backend.
"""
for method_name, args, kwargs in writes:
target = self._resolve_batch_target(method_name)
store = getattr(self, target)
authorized = self._authorize_commit(
lambda store=store, args=args, kwargs=kwargs: store(*args, **kwargs),
deadline=deadline,
commit_guard=commit_guard,
)
if not authorized:
return
async def acommit_memory_batch(
self,
writes: List[tuple],
*,
deadline: float,
commit_guard: Any = None,
) -> None:
"""Async variant preferring ``store_*_async`` when available.
Blocking ``store_*`` work is offloaded to a worker thread so the event
loop is never blocked, and each write is gated by the same deadline /
cancellation guard as the sync path so late or cancelled facts are not
persisted after compaction resumes.
"""
import inspect
for method_name, args, kwargs in writes:
if self._commit_expired(deadline, commit_guard):
return
target = self._resolve_batch_target(method_name)
async_method = getattr(self, f"{target}_async", None)
if async_method is not None:
if self._commit_expired(deadline, commit_guard):
return
result = async_method(*args, **kwargs)
if inspect.isawaitable(result):
await result
continue
store = getattr(self, target)
authorized = await asyncio.to_thread(
self._authorize_commit,
lambda store=store, args=args, kwargs=kwargs: store(*args, **kwargs),
deadline=deadline,
commit_guard=commit_guard,
)
if not authorized:
return
@staticmethod
def _commit_expired(deadline: float, commit_guard: Any) -> bool:
"""True once the flush was cancelled or the shared deadline has passed."""
if commit_guard is not None and getattr(commit_guard, "cancelled", False):
return True
return time.monotonic() >= deadline
def _authorize_commit(
self, operation: Any, *, deadline: float, commit_guard: Any
) -> bool:
"""Run ``operation`` under the guard's atomic-commit gate.
Returns ``False`` (and skips the write) once cancelled or past the
deadline. When no guard is supplied, fall back to a plain deadline
check so callers outside the flush path still behave correctly.
"""
if commit_guard is not None and hasattr(commit_guard, "commit"):
return commit_guard.commit(operation, deadline=deadline)
if self._commit_expired(deadline, commit_guard):
return False
operation()
return True
def _get_stm_conn(self):
"""Get thread-local short-term memory SQLite connection."""
if not hasattr(self._local, 'stm_conn') or self._local.stm_conn is None:
@@ -814,6 +963,11 @@ class Memory(SearchMixin, MemoryCoreMixin):
if getattr(self, "memory_adapter", None):
if hasattr(self.memory_adapter, "reset_short_term"):
self.memory_adapter.reset_short_term()
else:
logger.warning(
f"{type(self.memory_adapter).__name__} does not support "
"reset_short_term(); short-term memory was NOT cleared"
)
return
conn = self._get_stm_conn()
with self._write_lock: # Serialize write operations
@@ -1199,6 +1353,11 @@ class Memory(SearchMixin, MemoryCoreMixin):
if getattr(self, "memory_adapter", None):
if hasattr(self.memory_adapter, "reset_long_term"):
self.memory_adapter.reset_long_term()
else:
logger.warning(
f"{type(self.memory_adapter).__name__} does not support "
"reset_long_term(); long-term memory was NOT cleared"
)
return
conn = self._get_ltm_conn()
with self._write_lock: # Serialize write operations
@@ -1735,13 +1894,17 @@ class Memory(SearchMixin, MemoryCoreMixin):
into a single text block with deduplication and clean formatting.
Args:
include_in_output: If None, memory content is only included when debug logging is enabled.
If True, memory content is always included.
If False, memory content is never included (only logged for debugging).
include_in_output: If None, memory content is included (the primary
purpose of this method is to feed retrieved memory
into the prompt). If True, memory content is always
included. If False, memory content is never included
(only logged for debugging).
"""
# Determine whether to include memory content in output based on logging level
# Include retrieved memory by default. Gating this on DEBUG-level logging
# meant Agent(memory=True) silently retrieved hits but never appended them
# to the prompt under normal usage.
if include_in_output is None:
include_in_output = get_logger().getEffectiveLevel() == logging.DEBUG
include_in_output = True
q = (task_descr + " " + additional).strip()
lines = []
@@ -1911,6 +2074,30 @@ class Memory(SearchMixin, MemoryCoreMixin):
return result
def get_context(self, query: Optional[str] = None, **kwargs) -> str:
"""
Return retrieved memory as a prompt-ready context string.
Satisfies ``AgentMemoryProtocol`` (used by ``Agent.get_memory_context()``)
so the non-prompt-caching code path can inject memory into the system
prompt. Without this, ``hasattr(memory, 'get_context')`` was False and the
fallback branch always returned "".
"""
# A missing/empty query would make the local fallback search match every
# record (LIKE "%%") with no relevance ordering, leaking unrelated (and
# possibly other users') memories into the prompt. Retrieve nothing until
# there is a meaningful query.
if not query or not str(query).strip():
return ""
# Propagate the effective user id so user-scoped memories are included and
# cross-user records are not returned by a shared Memory instance.
user_id = kwargs.get("user_id") or self.cfg.get("user_id")
return self.build_context_for_task(
task_descr=query,
user_id=user_id,
include_in_output=True,
)
# -------------------------------------------------------------------------
# Master Reset (Everything)
# -------------------------------------------------------------------------
@@ -257,6 +257,26 @@ class _LazyObsModule:
obs = _LazyObsModule()
# ``from praisonaiagents import obs`` returns *this submodule*, not the singleton
# above (Python binds a real submodule as a package attribute, shadowing the
# package ``__getattr__``). Make the submodule object itself callable and proxy
# provider lookups to the singleton so ``obs(...)``, ``obs.auto()`` and
# ``obs.langfuse()`` all work regardless of how ``obs`` is imported.
import sys as _sys
from types import ModuleType as _ModuleType
class _CallableObsModule(_ModuleType):
def __call__(self, provider: str = "auto", **kwargs):
return obs(provider, **kwargs)
def __getattr__(self, name):
return getattr(obs, name)
_sys.modules[__name__].__class__ = _CallableObsModule
__all__ = [
"ObservabilityAdapter",
"Span",
@@ -74,6 +74,10 @@ class Process:
self._state_lock = asyncio.Lock()
return self._state_lock
def _task_by_name(self, name):
"""Return the task whose name matches, or None. First-match, mirrors prior inline lookup."""
return next((t for t in self.tasks.values() if t.name == name), None)
def _create_llm_instance(self):
"""Create and return a configured LLM instance for manager tasks."""
from ..llm import LLM
@@ -115,7 +119,7 @@ class Process:
if current_task.previous_tasks:
# For validation tasks, typically validate the most recent previous task
prev_task_name = current_task.previous_tasks[-1]
validated_task = next((t for t in self.tasks.values() if t.name == prev_task_name), None)
validated_task = self._task_by_name(prev_task_name)
elif current_task.context:
# If no previous_tasks, check context for the validated task
for ctx_task in reversed(current_task.context):
@@ -348,6 +352,43 @@ class Process:
task_id=loop_task.id
)
def _build_routing_context(self, current_task: Task) -> Dict[str, Any]:
"""Build a variable context for evaluating a task's `when` condition.
Combines the task's structured result (json_dict / pydantic fields) with
the raw output so expressions like ``{{score}} > 80`` can resolve, and
exposes the raw text as ``previous_output``.
"""
context: Dict[str, Any] = {}
result = getattr(current_task, "result", None)
if result is not None:
try:
context.update(result.to_dict())
except Exception:
pass
context["previous_output"] = getattr(result, "raw", "")
return context
def _has_when_routing(self, task: Task) -> bool:
"""True if the task uses the unified when/then_task/else_task routing."""
return task.when is not None or task.then_task is not None or task.else_task is not None
def _resolve_when_routing(self, current_task: Task) -> Optional[Task]:
"""Resolve the next Task via the unified `when`/`then_task`/`else_task`
routing on the current task. Returns None if no such routing applies."""
if current_task.when is None and current_task.then_task is None and current_task.else_task is None:
return None
next_name = current_task.get_next_task(self._build_routing_context(current_task))
if not next_name:
return None
next_task = next((t for t in self.tasks.values() if t.name == next_name), None)
if next_task:
next_task.status = "not started"
logging.debug(f"Routing to {next_task.name} based on when-condition: {current_task.when}")
else:
logging.warning(f"when-routing target '{next_name}' not found among tasks")
return next_task
def _build_task_context(self, current_task: Task) -> str:
"""Build context for a task based on its retain_full_context setting"""
# Check if we have validation feedback to include
@@ -377,7 +418,7 @@ class Process:
if current_task.retain_full_context:
# Original behavior: include all previous tasks
for prev_name in current_task.previous_tasks:
prev_task = next((t for t in self.tasks.values() if t.name == prev_name), None)
prev_task = self._task_by_name(prev_name)
if prev_task and prev_task.result:
context += f"\n{prev_name}: {prev_task.result.raw}"
@@ -391,7 +432,7 @@ class Process:
if current_task.previous_tasks:
# Get the most recent previous task (last in the list)
prev_name = current_task.previous_tasks[-1]
prev_task = next((t for t in self.tasks.values() if t.name == prev_name), None)
prev_task = self._task_by_name(prev_name)
if prev_task and prev_task.result:
context += f"\n{prev_name}: {prev_task.result.raw}"
@@ -599,7 +640,7 @@ class Process:
for task in self.tasks.values():
if task.next_tasks:
for next_task_name in task.next_tasks:
next_task = next((t for t in self.tasks.values() if t.name == next_task_name), None)
next_task = self._task_by_name(next_task_name)
if next_task:
next_task.previous_tasks.append(task.name)
logging.debug(f"Added {task.name} as previous task for {next_task_name}")
@@ -760,9 +801,9 @@ Subtask: {st.name}
decision_str = None
if current_task.result:
if current_task.result.pydantic and hasattr(current_task.result.pydantic, "decision"):
decision_str = current_task.result.pydantic.decision.lower()
decision_str = current_task.result.pydantic.decision.lower().strip()
elif current_task.result.raw:
decision_str = current_task.result.raw.lower()
decision_str = current_task.result.raw.lower().strip()
# For loop tasks, use "done" to follow condition path
if current_task.task_type == "loop" and all(t.status == "completed" for t in subtasks):
@@ -770,7 +811,7 @@ Subtask: {st.name}
target_tasks = current_task.condition.get(decision_str, []) if decision_str else []
task_value = target_tasks[0] if isinstance(target_tasks, list) else target_tasks
next_task = next((t for t in self.tasks.values() if t.name == task_value), None)
next_task = self._task_by_name(task_value)
if next_task:
next_task.status = "not started" # Reset status to allow execution
logging.debug(f"Routing to {next_task.name} based on decision: {decision_str}")
@@ -799,7 +840,7 @@ Subtask: {st.name}
logging.debug(f"No input file, marking {current_task.name} as completed")
if current_task.next_tasks:
next_task_name = current_task.next_tasks[0]
next_task = next((t for t in self.tasks.values() if t.name == next_task_name), None)
next_task = self._task_by_name(next_task_name)
current_task = next_task
else:
current_task = None
@@ -811,8 +852,8 @@ Subtask: {st.name}
yield task_id
visited_tasks.add(task_id)
# Only end workflow if no next_tasks AND no conditions
if not current_task.next_tasks and not current_task.condition and not any(
# Only end workflow if no next_tasks AND no conditions AND no when-routing
if not current_task.next_tasks and not current_task.condition and not self._has_when_routing(current_task) and not any(
t.task_type == "loop" and current_task.name.startswith(t.name + "_")
for t in self.tasks.values()
):
@@ -853,9 +894,9 @@ Subtask: {st.name}
if current_task and current_task.result:
if current_task.task_type in ["decision", "loop"]:
# Get decision from pydantic or raw response
decision_str = current_task.result.raw.lower()
decision_str = current_task.result.raw.lower().strip()
if current_task.result.pydantic and hasattr(current_task.result.pydantic, "decision"):
decision_str = current_task.result.pydantic.decision.lower()
decision_str = current_task.result.pydantic.decision.lower().strip()
# Check if task has conditions and next_tasks
if current_task.condition:
@@ -870,7 +911,7 @@ Subtask: {st.name}
else:
# Find the target task by name
task_value = target_tasks[0] if isinstance(target_tasks, list) else target_tasks
next_task = next((t for t in self.tasks.values() if t.name == task_value), None)
next_task = self._task_by_name(task_value)
if next_task:
next_task.status = "not started" # Reset status to allow execution
@@ -899,10 +940,26 @@ Subtask: {st.name}
# Don't mark workflow as finished when following condition path
await self._set_workflow_finished(False)
# Unified condition routing (when/then_task/else_task) takes priority
# over next_tasks when configured on the current task.
when_routing_exhausted = False
if not next_task and current_task:
if self._has_when_routing(current_task):
when_task = self._resolve_when_routing(current_task)
if when_task:
next_task = when_task
await self._set_workflow_finished(False)
elif not current_task.next_tasks:
# when-routing is authoritative: it resolved to no target
# (e.g. the taken branch has no then/else_task) and there
# is no next_tasks fallback, so this path ends cleanly
# instead of picking an unrelated not-started task.
when_routing_exhausted = True
# If no condition-based routing, use next_tasks
if not next_task and current_task and current_task.next_tasks:
next_task_name = current_task.next_tasks[0]
next_task = next((t for t in self.tasks.values() if t.name == next_task_name), None)
next_task = self._task_by_name(next_task_name)
if next_task:
# Reset the next task to allow re-execution
next_task.status = "not started"
@@ -915,7 +972,7 @@ Subtask: {st.name}
logging.debug(f"Following next_tasks to {next_task.name}")
current_task = next_task
if not current_task:
if not current_task and not when_routing_exhausted:
current_task = self._find_next_not_started_task() # General fallback if no next task in workflow
@@ -1166,7 +1223,7 @@ Provide a JSON with the structure:
for task in self.tasks.values():
if task.next_tasks:
for next_task_name in task.next_tasks:
next_task = next((t for t in self.tasks.values() if t.name == next_task_name), None)
next_task = self._task_by_name(next_task_name)
if next_task:
next_task.previous_tasks.append(task.name)
@@ -1351,9 +1408,9 @@ Subtask: {st.name}
decision_str = None
if current_task.result:
if current_task.result.pydantic and hasattr(current_task.result.pydantic, "decision"):
decision_str = current_task.result.pydantic.decision.lower()
decision_str = current_task.result.pydantic.decision.lower().strip()
elif current_task.result.raw:
decision_str = current_task.result.raw.lower()
decision_str = current_task.result.raw.lower().strip()
# For loop tasks, use "done" to follow condition path
if current_task.task_type == "loop" and all(t.status == "completed" for t in subtasks):
@@ -1361,7 +1418,7 @@ Subtask: {st.name}
target_tasks = current_task.condition.get(decision_str, []) if decision_str else []
task_value = target_tasks[0] if isinstance(target_tasks, list) else target_tasks
next_task = next((t for t in self.tasks.values() if t.name == task_value), None)
next_task = self._task_by_name(task_value)
if next_task:
next_task.status = "not started" # Reset status to allow execution
logging.debug(f"Routing to {next_task.name} based on decision: {decision_str}")
@@ -1390,7 +1447,7 @@ Subtask: {st.name}
logging.debug(f"No input file, marking {current_task.name} as completed")
if current_task.next_tasks:
next_task_name = current_task.next_tasks[0]
next_task = next((t for t in self.tasks.values() if t.name == next_task_name), None)
next_task = self._task_by_name(next_task_name)
current_task = next_task
else:
current_task = None
@@ -1402,8 +1459,8 @@ Subtask: {st.name}
yield task_id
visited_tasks.add(task_id)
# Only end workflow if no next_tasks AND no conditions
if not current_task.next_tasks and not current_task.condition and not any(
# Only end workflow if no next_tasks AND no conditions AND no when-routing
if not current_task.next_tasks and not current_task.condition and not self._has_when_routing(current_task) and not any(
t.task_type == "loop" and current_task.name.startswith(t.name + "_")
for t in self.tasks.values()
):
@@ -1442,9 +1499,9 @@ Subtask: {st.name}
if current_task and current_task.result:
if current_task.task_type in ["decision", "loop"]:
# Get decision from pydantic or raw response
decision_str = current_task.result.raw.lower()
decision_str = current_task.result.raw.lower().strip()
if current_task.result.pydantic and hasattr(current_task.result.pydantic, "decision"):
decision_str = current_task.result.pydantic.decision.lower()
decision_str = current_task.result.pydantic.decision.lower().strip()
# Check if task has conditions and next_tasks
if current_task.condition:
@@ -1459,7 +1516,7 @@ Subtask: {st.name}
else:
# Find the target task by name
task_value = target_tasks[0] if isinstance(target_tasks, list) else target_tasks
next_task = next((t for t in self.tasks.values() if t.name == task_value), None)
next_task = self._task_by_name(task_value)
if next_task:
next_task.status = "not started" # Reset status to allow execution
@@ -1488,10 +1545,26 @@ Subtask: {st.name}
# Don't mark workflow as finished when following condition path
self._set_workflow_finished_sync(False)
# Unified condition routing (when/then_task/else_task) takes priority
# over next_tasks when configured on the current task.
when_routing_exhausted = False
if not next_task and current_task:
if self._has_when_routing(current_task):
when_task = self._resolve_when_routing(current_task)
if when_task:
next_task = when_task
self._set_workflow_finished_sync(False)
elif not current_task.next_tasks:
# when-routing is authoritative: it resolved to no target
# (e.g. the taken branch has no then/else_task) and there
# is no next_tasks fallback, so this path ends cleanly
# instead of picking an unrelated not-started task.
when_routing_exhausted = True
# If no condition-based routing, use next_tasks
if not next_task and current_task and current_task.next_tasks:
next_task_name = current_task.next_tasks[0]
next_task = next((t for t in self.tasks.values() if t.name == next_task_name), None)
next_task = self._task_by_name(next_task_name)
if next_task:
# Reset the next task to allow re-execution
next_task.status = "not started"
@@ -1504,7 +1577,7 @@ Subtask: {st.name}
logging.debug(f"Following next_tasks to {next_task.name}")
current_task = next_task
if not current_task:
if not current_task and not when_routing_exhausted:
current_task = self._find_next_not_started_task() # General fallback if no next task in workflow
@@ -67,6 +67,7 @@ class RetrievalConfig:
min_score: float = 0.0
max_context_tokens: int = 4000
rerank: bool = False
rerank_model: Optional[str] = None
hybrid: bool = False
citations: bool = True
citations_mode: CitationsMode = CitationsMode.APPEND
@@ -88,6 +89,11 @@ class RetrievalConfig:
exclude_glob: Optional[list] = None # Glob patterns to exclude
path_filter: Optional[str] = None # Regex for path filtering
# Chunking configuration (applied when documents are ingested)
chunking_strategy: str = "recursive"
chunk_size: int = 512
chunk_overlap: int = 50
# Vector store configuration
vector_store_provider: str = "chroma"
vector_store_config: Dict[str, Any] = field(default_factory=dict)
@@ -176,6 +182,7 @@ class RetrievalConfig:
"min_score": self.min_score,
"max_context_tokens": self.max_context_tokens,
"rerank": self.rerank,
"rerank_model": self.rerank_model,
"hybrid": self.hybrid,
"citations": self.citations,
"citations_mode": self.citations_mode.value if isinstance(self.citations_mode, CitationsMode) else self.citations_mode,
@@ -188,6 +195,9 @@ class RetrievalConfig:
"include_glob": self.include_glob,
"exclude_glob": self.exclude_glob,
"path_filter": self.path_filter,
"chunking_strategy": self.chunking_strategy,
"chunk_size": self.chunk_size,
"chunk_overlap": self.chunk_overlap,
"vector_store_provider": self.vector_store_provider,
"vector_store_config": self.vector_store_config,
"collection_name": self.collection_name,
@@ -225,6 +235,7 @@ class RetrievalConfig:
min_score=data.get("min_score", 0.0),
max_context_tokens=data.get("max_context_tokens", 4000),
rerank=data.get("rerank", False),
rerank_model=data.get("rerank_model"),
hybrid=data.get("hybrid", False),
citations=data.get("citations", True),
citations_mode=citations_mode,
@@ -237,6 +248,9 @@ class RetrievalConfig:
include_glob=data.get("include_glob"),
exclude_glob=data.get("exclude_glob"),
path_filter=data.get("path_filter"),
chunking_strategy=data.get("chunking_strategy", "recursive"),
chunk_size=data.get("chunk_size", 512),
chunk_overlap=data.get("chunk_overlap", 50),
vector_store_provider=data.get("vector_store_provider", "chroma"),
vector_store_config=data.get("vector_store_config", {}),
collection_name=data.get("collection_name"),
@@ -281,7 +295,26 @@ class RetrievalConfig:
if self.rerank:
config["reranker"] = {"enabled": True, "default_rerank": True}
if self.rerank_model:
# mem0's RerankerConfig needs a provider to instantiate the
# reranker; a config with only {"model": ...} is dropped by
# Knowledge._prepare_mem0_config and the request is silently
# lost. Derive the provider from a "provider/model" prefix
# (e.g. "cohere/rerank-v3" -> provider "cohere") so the model
# is actionable; fall back to the model string as provider.
model = self.rerank_model
provider = model.split("/", 1)[0] if "/" in model else model
config["reranker"]["provider"] = provider
config["reranker"]["config"] = {"model": model}
# Chunking must reach Knowledge, which otherwise hardcodes
# recursive/512/50 and ignores the user's chunk settings entirely.
config["chunker"] = {
"type": self.chunking_strategy,
"chunk_size": self.chunk_size,
"chunk_overlap": self.chunk_overlap,
}
return config
def to_rag_config(self) -> Dict[str, Any]:
@@ -78,6 +78,9 @@ KIND_TOOL_RESULT = "tool_result"
KIND_APPROVAL = "approval"
#: The loop iteration index, journalled so the cursor is restored exactly.
KIND_ITERATION = "iteration"
#: A verification/completion-gate check result: ``{"name", "success",
#: "returncode", "command"/"path", "duration_seconds", "output_hash"}``.
KIND_VERIFICATION = "verification"
VALID_KINDS = frozenset(
{
@@ -86,6 +89,7 @@ VALID_KINDS = frozenset(
KIND_TOOL_RESULT,
KIND_APPROVAL,
KIND_ITERATION,
KIND_VERIFICATION,
}
)
@@ -106,7 +106,11 @@ class SandboxConfig:
"""
sandbox_type: str = "subprocess"
image: str = "python:3.11-slim"
# Kept in step with the compute-side DockerCompute default. The two
# implementations of "docker" disagreed -- 3.11 here, 3.12 there -- so
# tools_run_on="docker" and run_in="docker" handed you different Pythons
# for the same word. Nobody chose that; they drifted apart.
image: str = "python:3.12-slim"
working_dir: str = "/workspace"
env: Dict[str, str] = field(default_factory=dict)
resource_limits: ResourceLimits = field(default_factory=ResourceLimits)
@@ -133,7 +137,7 @@ class SandboxConfig:
}
@classmethod
def docker(cls, image: str = "python:3.11-slim") -> "SandboxConfig":
def docker(cls, image: str = "python:3.12-slim") -> "SandboxConfig":
"""Create a Docker sandbox configuration."""
return cls(
sandbox_type="docker",
@@ -29,7 +29,7 @@ class SandboxManager:
Example:
from praisonaiagents.sandbox import SandboxManager, SandboxConfig
config = SandboxConfig.docker("python:3.11-slim")
config = SandboxConfig.docker("python:3.12-slim")
manager = SandboxManager(config)
result = await manager.run_code("print('Hello, World!')")
"""
@@ -79,10 +79,43 @@ class SandboxManager:
f"Unknown sandbox type: {sandbox_type!r}. {e}"
) from e
kwargs: Dict[str, Any] = {"config": self.config}
if sandbox_type == "docker":
# Not every backend takes a SandboxConfig: SSHSandbox and ModalSandbox
# carry their own connection details instead, so passing config= to them
# raised "unexpected keyword argument 'config'" before the sandbox was
# ever built. Ask the constructor what it accepts.
import inspect
params = inspect.signature(sandbox_cls.__init__).parameters
takes = lambda name: name in params or any(
p.kind is p.VAR_KEYWORD for p in params.values()
)
kwargs: Dict[str, Any] = {}
if takes("config"):
kwargs["config"] = self.config
if sandbox_type == "docker" and takes("image"):
kwargs["image"] = self.config.image
# A required argument we cannot supply from a config object -- SSH needs
# a host. Say so instead of raising TypeError from deep inside.
missing = [
name for name, prm in params.items()
if name != "self"
and prm.default is prm.empty
and prm.kind not in (prm.VAR_POSITIONAL, prm.VAR_KEYWORD)
and name not in kwargs
]
if missing:
raise TypeError(
f"The {sandbox_type!r} sandbox needs {', '.join(missing)}, which a "
f"SandboxConfig cannot carry. Build it directly and pass the "
f"object:\n"
f" from praisonai_sandbox.{sandbox_type} import "
f"{sandbox_cls.__name__}\n"
f" sandbox = {sandbox_cls.__name__}("
f"{'=..., '.join(missing)}=...)"
)
sandbox = sandbox_cls(**kwargs)
is_available = getattr(sandbox, "is_available", True)
@@ -206,7 +206,7 @@ class SandboxProtocol(Protocol):
from praisonai_sandbox import DockerSandbox
sandbox = DockerSandbox(image="python:3.11-slim")
sandbox = DockerSandbox(image="python:3.12-slim")
result = await sandbox.execute("print('Hello, World!')")
print(result.stdout)
"""
@@ -7,6 +7,7 @@ other config.yaml content.
"""
import contextlib
import copy
from praisonaiagents._logging import get_logger
import os
import threading
@@ -21,6 +22,11 @@ logger = get_logger(__name__)
_HISTORY_FILE = "run_history.yaml"
_LOCK_FILE = "config.schedules.lock"
_MAX_HISTORY = 200
# Hard cap on a single job's persisted per-run scratchpad. A watermark /
# cursor / last-seen hash is tiny; this only exists so a runaway ``set_state``
# cannot grow config.yaml unbounded. Oversized writes are rejected (prior
# state kept) rather than silently truncated.
_MAX_STATE_BYTES = 16 * 1024
class ConfigYamlScheduleStore:
"""CRUD store backed by ``config.yaml``.
@@ -41,6 +47,9 @@ class ConfigYamlScheduleStore:
self._max_history = max_history
self._lock = threading.RLock()
self._jobs: Dict[str, ScheduleJob] = {}
# Per-job durable scratchpad (cursors / watermarks / last-seen hash),
# persisted under the ``job_state`` key alongside ``schedules``.
self._job_state: Dict[str, Dict] = {}
self._history: List[RunRecord] = []
# In-memory record of leases we currently hold, so ``complete`` can
# release them. Cross-process leases live in the persisted job
@@ -126,6 +135,8 @@ class ConfigYamlScheduleStore:
self._reload_locked()
if job_id in self._jobs:
del self._jobs[job_id]
# Drop any per-job scratchpad so a deleted job leaves no state.
self._job_state.pop(job_id, None)
self._save()
return True
return False
@@ -145,6 +156,7 @@ class ConfigYamlScheduleStore:
if principal is not None and job.principal != principal:
continue
del self._jobs[jid]
self._job_state.pop(jid, None)
self._save()
return True
return False
@@ -199,6 +211,7 @@ class ConfigYamlScheduleStore:
if job.delete_after_run:
# One-shot: remove now so no competitor re-claims it.
del self._jobs[job.id]
self._job_state.pop(job.id, None)
if changed:
if not self._save():
# The lease/last_run_at advance was NOT persisted (full
@@ -283,6 +296,7 @@ class ConfigYamlScheduleStore:
a job already claimed/leased by another process is observed.
"""
self._jobs = {}
self._job_state = {}
self._load()
# ── execution history ─────────────────────────────────────────────
@@ -327,6 +341,59 @@ class ConfigYamlScheduleStore:
records = [r for r in records if r.job_id == job_id]
return records[:limit]
# ── per-job state (JobStateStoreProtocol) ─────────────────────────
def get_state(self, job_id: str) -> Dict:
"""Return the persisted scratchpad for ``job_id`` (``{}`` if none).
A deep copy is returned so a caller mutating the result — including a
nested list or dict — cannot silently alter the in-memory store without
going through :meth:`set_state` (which enforces the size cap).
"""
with self._lock:
state = self._job_state.get(job_id)
return copy.deepcopy(state) if isinstance(state, dict) else {}
def set_state(self, job_id: str, state: Dict) -> None:
"""Persist ``state`` for ``job_id`` under the ``job_state`` key.
Size-capped: a serialised state larger than ``_MAX_STATE_BYTES`` is
rejected (prior state kept) so a runaway write cannot grow config.yaml
unbounded. An empty/falsy ``state`` clears the entry.
"""
if not state:
self.clear_state(job_id)
return
if not isinstance(state, dict):
logger.warning(
"Ignoring non-dict state for job '%s' (%s)", job_id, type(state).__name__,
)
return
try:
import yaml
size = len(yaml.safe_dump(state).encode("utf-8"))
except Exception as e: # pragma: no cover - defensive
logger.warning("Could not size state for job '%s': %s", job_id, e)
return
if size > _MAX_STATE_BYTES:
logger.warning(
"Rejecting oversized state for job '%s' (%d > %d bytes); keeping prior",
job_id, size, _MAX_STATE_BYTES,
)
return
with self._lock, self._file_lock():
self._reload_locked()
self._job_state[job_id] = copy.deepcopy(state)
self._save()
def clear_state(self, job_id: str) -> None:
"""Drop any persisted scratchpad for ``job_id`` (no-op if absent)."""
with self._lock, self._file_lock():
self._reload_locked()
if job_id in self._job_state:
del self._job_state[job_id]
self._save()
# ── persistence ──────────────────────────────────────────────────
def _load(self) -> None:
@@ -353,6 +420,11 @@ class ConfigYamlScheduleStore:
job_data.setdefault("id", job_id)
job = ScheduleJob.from_dict(job_data)
self._jobs[job.id] = job
job_state = data.get("job_state", {})
if isinstance(job_state, dict):
for job_id, state in job_state.items():
if isinstance(state, dict):
self._job_state[str(job_id)] = state
except ValueError:
raise
except Exception as e:
@@ -381,6 +453,15 @@ class ConfigYamlScheduleStore:
schedules[job.id] = job.to_dict()
data["schedules"] = schedules
# Persist per-job scratchpad alongside; drop the key entirely when
# empty so config.yaml stays clean for the stateless common case.
if self._job_state:
data["job_state"] = {
jid: state for jid, state in self._job_state.items()
}
else:
data.pop("job_state", None)
# Atomic write
os.makedirs(os.path.dirname(self._path), exist_ok=True)
tmp = self._path + ".tmp"
@@ -298,6 +298,21 @@ class ScheduleJob:
killed (with its process group on POSIX) and the tick is
recorded as ``failed``. Bounds the action so a hung command
cannot stall the ticker. Defaults to 60s.
backend: Optional external coding-CLI backend id (e.g.
``"claude-code"``, ``"codex-cli"``). When set, the job's
``message`` is executed as one headless turn through the
named backend from the backend registry — no native agent is
resolved and no in-process model turn is taken. Like
``command``, this is a trusted operator-configured action:
it spawns a host CLI subprocess and is deliberately not
exposed on the LLM-callable scheduling tools. Additive and
backward-compatible: jobs without a ``backend`` are
unchanged.
backend_options: Optional mapping of overrides for the backend run.
Recognised keys are validated by the executor/backend (e.g.
``cwd`` for the working directory, ``timeout_ms`` for the
subprocess bound); unknown config overrides are rejected at
resolution time rather than silently ignored.
provider: Optional model *provider* snapshotted when the job was
created (e.g. ``"openai"``). Advisory metadata paired with
``model`` so a drift check can report both. ``None`` means no
@@ -376,6 +391,8 @@ class ScheduleJob:
context_from: Optional[List[str]] = None
context_max_chars: int = 4000
on_missing_context: Literal["run", "skip"] = "run"
backend: Optional[str] = None
backend_options: Dict[str, Any] = field(default_factory=dict)
# ── serialisation ────────────────────────────────────────────────
@@ -432,6 +449,13 @@ class ScheduleJob:
d["context_max_chars"] = self.context_max_chars
if self.on_missing_context != "run":
d["on_missing_context"] = self.on_missing_context
# External CLI backend action. Only persist when configured so agent
# and command jobs stay byte-for-byte unchanged; options are opaque to
# the core (the executor validates them against the backend registry).
if self.backend is not None:
d["backend"] = self.backend
if self.backend_options:
d["backend_options"] = dict(self.backend_options)
# Atomic-claim lease metadata (set dynamically by stores that support
# ``claim_due``). Persisted so a lease is visible across processes and
# survives a restart; omitted when no lease is held.
@@ -480,6 +504,12 @@ class ScheduleJob:
context_from=context_from,
context_max_chars=d.get("context_max_chars", 4000),
on_missing_context=d.get("on_missing_context", "run"),
backend=d.get("backend"),
backend_options=(
dict(d["backend_options"])
if isinstance(d.get("backend_options"), dict)
else {}
),
)
# Restore atomic-claim lease metadata if present (see ``to_dict``).
job._lease_until = d.get("lease_until", 0.0) or 0.0
@@ -5,26 +5,35 @@ This module provides automatic session persistence with zero configuration.
## Quick Start
```python
from praisonaiagents import Agent
from praisonaiagents import Agent, MemoryConfig
# With session persistence (auto-enabled)
agent = Agent(
name="Assistant",
session_id="my-session-123"
memory=MemoryConfig(session_id="my-session-123"),
)
agent.start("Hello, my name is Alice")
# Later, in a new process - history is restored automatically
agent = Agent(
name="Assistant",
session_id="my-session-123"
name="Assistant",
memory=MemoryConfig(session_id="my-session-123"),
)
agent.start("What is my name?") # Agent remembers: "Alice"
```
The `session_id` is part of the Agent's memory configuration. `Agent` itself has
no top-level `session_id` parameter — passing one raises
`TypeError: Agent.__init__() got unexpected keyword argument(s): session_id`.
A plain dict is accepted as shorthand for `MemoryConfig`:
```python
agent = Agent(name="Assistant", memory={"session_id": "my-session-123"})
```
## How It Works
When you provide a `session_id` to an Agent:
When you configure a `session_id` on an Agent:
1. **Automatic Persistence**: Conversation history is automatically saved to disk
2. **Automatic Restoration**: When a new Agent is created with the same `session_id`, history is restored
@@ -74,8 +83,8 @@ Fields are persisted in session JSON `metadata` and mirrored at root on save. Po
| Scenario | Behavior |
|----------|----------|
| `session_id` provided, no DB | JSON persistence (auto) |
| `session_id` provided, with DB | DB adapter used |
| `memory=MemoryConfig(session_id=...)`, no DB | JSON persistence (auto) |
| `memory=MemoryConfig(session_id=..., db=...)` | DB adapter used |
| No `session_id`, same Agent instance | In-memory only |
| No `session_id`, new Agent instance | No history |
@@ -105,6 +114,7 @@ store.delete_session("session-123")
### Custom Session Directory
<!-- praisonai: skip=true -->
```python
from praisonaiagents.session import DefaultSessionStore
@@ -120,13 +130,15 @@ store = DefaultSessionStore(
When a DB adapter is provided, it takes precedence over JSON persistence:
```python
from praisonaiagents import Agent
from praisonai.db import PostgresAdapter
from praisonaiagents import Agent, MemoryConfig
from praisonaiagents.db import db
agent = Agent(
name="Assistant",
session_id="my-session",
db=PostgresAdapter(connection_string="...")
memory=MemoryConfig(
session_id="my-session",
db=db(database_url="postgresql://localhost/mydb"),
),
)
```
@@ -142,17 +154,27 @@ Multiple processes can safely read/write to the same session.
## Context Caching
For cost optimization, use `prompt_caching=True` with Anthropic models:
Prompt caching is opt-in via `caching=CachingConfig(prompt_caching=True)` — there
is no top-level `prompt_caching` parameter on `Agent`. When enabled, `Agent`
checks `praisonaiagents.llm.model_capabilities.supports_prompt_caching(model)`
and, for providers that need explicit breakpoints (Anthropic), injects
`cache_control` markers itself. OpenAI/Gemini use automatic prefix caching, so no
markers are emitted:
```python
from praisonaiagents import Agent, MemoryConfig, CachingConfig
agent = Agent(
name="Assistant",
session_id="my-session",
prompt_caching=True, # Enables Anthropic prompt caching
llm="anthropic/claude-sonnet-4-5",
memory=MemoryConfig(session_id="my-session"),
caching=CachingConfig(prompt_caching=True),
)
```
This caches the system prompt, reducing token costs for repeated conversations.
Without `prompt_caching=True`, no `cache_control` breakpoints are injected on the
Anthropic path.
## API Reference
@@ -162,7 +184,7 @@ This caches the system prompt, reducing token costs for repeated conversations.
class DefaultSessionStore:
def __init__(
self,
session_dir: Optional[str] = None, # Default: ~/.praison/sessions/
session_dir: Optional[str] = None, # Default: ~/.praisonai/sessions/
max_messages: int = 100,
lock_timeout: float = 5.0,
): ...
@@ -2,26 +2,32 @@
Session persistence module for PraisonAI Agents.
Provides automatic session persistence with zero configuration.
When a session_id is provided to an Agent, conversation history
When a session_id is configured on an Agent, conversation history
is automatically persisted to disk and restored on subsequent runs.
The session_id is set through the Agent's memory configuration; Agent itself
has no top-level session_id parameter.
Usage:
from praisonaiagents import Agent
from praisonaiagents import Agent, MemoryConfig
# With session persistence (auto-enabled)
agent = Agent(
name="Assistant",
session_id="my-session-123"
memory=MemoryConfig(session_id="my-session-123"),
)
agent.start("Hello")
# Later, new process - history is restored
agent = Agent(
name="Assistant",
session_id="my-session-123"
name="Assistant",
memory=MemoryConfig(session_id="my-session-123"),
)
agent.start("What did I say before?") # Remembers!
# The plain-dict spelling is equivalent:
# Agent(name="Assistant", memory={"session_id": "my-session-123"})
Default storage: ~/.praisonai/sessions/{session_id}.json
"""
@@ -98,6 +104,16 @@ def __getattr__(name: str):
_module_cache[name] = SessionMirrorProtocol
return SessionMirrorProtocol
if name == "PortableSessionStoreProtocol":
from .protocols import PortableSessionStoreProtocol
_module_cache[name] = PortableSessionStoreProtocol
return PortableSessionStoreProtocol
if name == "ImportReport":
from .protocols import ImportReport
_module_cache[name] = ImportReport
return ImportReport
if name == "SessionHit":
from .protocols import SessionHit
_module_cache[name] = SessionHit
@@ -170,6 +186,12 @@ def __getattr__(name: str):
_module_cache[name] = workspace_id
return workspace_id
# Cross-context continuation prompt assembler (session handoff)
if name == "build_handoff_prompt":
from .handoff import build_handoff_prompt
_module_cache[name] = build_handoff_prompt
return build_handoff_prompt
raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
@@ -185,6 +207,8 @@ __all__ = [
"SessionStoreProtocol",
"SearchableSessionStoreProtocol",
"SessionMirrorProtocol",
"PortableSessionStoreProtocol",
"ImportReport",
"SessionHit",
"SessionSummary",
"HierarchicalSessionStore",
@@ -201,4 +225,5 @@ __all__ = [
"get_session_context",
"clear_session_context",
"workspace_id",
"build_handoff_prompt",
]
@@ -17,6 +17,16 @@ from typing import Any, Dict, List, Optional, TYPE_CHECKING
logger = logging.getLogger(__name__)
# Sub-agent transcripts live *inside* the parent session's own record, under
# ``SessionData.metadata[AGENT_HISTORY_KEY][agent_key]``.
AGENT_HISTORY_KEY = "agent_histories"
# Opt-in restore of sub-agent transcripts written by older versions as separate
# top-level sessions named ``"{parent}_{name}:{role}"`` *without* parentage
# tags. Such an id is indistinguishable from a real user session of the same
# sanitised name, so it is not restored unless this is explicitly set.
LEGACY_AGENT_KEYS_ENV = "PRAISONAI_SESSION_LEGACY_AGENT_KEYS"
if TYPE_CHECKING:
from ..memory.memory import Memory
from ..knowledge.knowledge import Knowledge
@@ -116,6 +126,7 @@ class Session:
self._knowledge = None
self._agents_instance = None
self._agents = {}
self._legacy_histories_cache = None
else:
self.memory_config = {}
self.knowledge_config = {}
@@ -123,6 +134,7 @@ class Session:
self._knowledge = None
self._agents_instance = None
self._agents = {}
self._legacy_histories_cache = None
def _get_session_dir(self):
"""Get session-specific directory using centralized paths."""
@@ -274,6 +286,55 @@ class Session:
return {}
def _get_session_store(self):
"""Return the default session store, or ``None`` if unavailable."""
try:
from . import get_default_session_store
return get_default_session_store()
except ImportError:
return None
@staticmethod
def _legacy_agent_keys_enabled() -> bool:
"""Whether to restore *untagged* legacy sub-agent records.
Records written before the ``parent_session_id``/``agent_key`` tags
existed carry no parentage, so ``"{parent}_{agent_key}"`` cannot be told
apart from a real user session of the same sanitised name. Restoring one
can silently pull an unrelated transcript into an agent, so it is
opt-in.
"""
return os.environ.get(LEGACY_AGENT_KEYS_ENV, "").strip().lower() in (
"1", "true", "yes", "on",
)
def _stored_agent_histories(self, session_store) -> Dict[str, List[Dict[str, Any]]]:
"""Sub-agent transcripts held inside this session's own record."""
if session_store is None or not hasattr(session_store, "get_session"):
return {}
try:
data = session_store.get_session(self.session_id)
except Exception as exc:
logger.debug(f"Cannot read agent histories for {self.session_id}: {exc}")
return {}
histories = (getattr(data, "metadata", None) or {}).get(AGENT_HISTORY_KEY)
if not isinstance(histories, dict):
return {}
return {k: v for k, v in histories.items() if isinstance(v, list) and v}
def _merged_agent_histories(self, session_store) -> Dict[str, List[Dict[str, Any]]]:
"""All known sub-agent transcripts: legacy records under current ones.
Legacy per-agent records are read *underneath* the parent's current
``metadata[AGENT_HISTORY_KEY]`` so a partially-migrated parent (one
agent already in the current format) still surfaces a *different*
agent that only exists in a tagged legacy record. Current-format
entries always win on key collisions.
"""
merged = dict(self._legacy_agent_histories(session_store))
merged.update(self._stored_agent_histories(session_store))
return merged
def _restore_agent_chat_history(self, agent_key: str) -> List[Dict[str, Any]]:
"""
Restore agent chat history from memory.
@@ -287,19 +348,13 @@ class Session:
if self.is_remote:
return []
# G-2 FIX: mirror the save path priority — read SessionStore first so
# history persisted by _save_agent_chat_histories() is actually found.
session_store = None
try:
from . import get_default_session_store
session_store = get_default_session_store()
except ImportError:
pass
session_store = self._get_session_store()
if session_store is not None and hasattr(session_store, "get_chat_history"):
messages = session_store.get_chat_history(f"{self.session_id}_{agent_key}")
if messages:
return messages
# Current format first, then any (tagged / opted-in) legacy per-agent
# record — even when the parent is only partially migrated.
merged = self._merged_agent_histories(session_store)
if agent_key in merged:
return merged[agent_key]
results = self.memory.search_short_term(
query="Agent chat history for",
@@ -316,54 +371,101 @@ class Session:
return []
def _legacy_agent_histories(self, session_store) -> Dict[str, List[Dict[str, Any]]]:
"""Sub-agent transcripts older versions wrote as top-level sessions.
Never deletes them: an untagged candidate may in fact be a real user
session that merely sanitises to the same name.
"""
# Legacy per-agent records are a frozen migration artefact: nothing
# writes them after the upgrade and neither save nor restore mutates
# them. Memoise the full-disk scan per Session so a save pass over N
# agents doesn't re-enumerate every stored session N times (and once
# migrated, the common case, the scan collapses to a single hit).
# Key the cache on the opt-in flag: the untagged-restore env toggle
# changes what the scan yields, so each mode caches independently.
allow_untagged = self._legacy_agent_keys_enabled()
cached = getattr(self, "_legacy_histories_cache", None)
if cached is not None and cached[0] == allow_untagged:
return cached[1]
histories: Dict[str, List[Dict[str, Any]]] = {}
list_sessions = getattr(session_store, "list_sessions", None)
if session_store is None or not callable(list_sessions):
self._legacy_histories_cache = (allow_untagged, histories)
return histories
prefix = f"{self.session_id}_"
# Migration must consider every stored session, not the 50 most recent:
# a legacy per-agent record is by definition older than anything written
# after the upgrade, so list_sessions()'s default window silently
# excludes it (regression from #4126).
try:
try:
entries = list_sessions(limit=None) or []
except TypeError: # stores whose limit is not optional
entries = list_sessions(limit=10**9) or []
except Exception:
return histories
for entry in entries:
if isinstance(entry, dict):
stored_id = entry.get("session_id")
# Prefer the explicit parent/agent_key tags written on save;
# this disambiguates overlapping composite ids (e.g.
# "chat"+"support_agent" vs "chat_support"+"agent").
tagged_parent = entry.get("parent_session_id")
tagged_key = entry.get("agent_key")
else:
stored_id, tagged_parent, tagged_key = entry, None, None
if not isinstance(stored_id, str):
continue
if tagged_parent == self.session_id and tagged_key:
agent_key = tagged_key
elif (
tagged_parent is None
and tagged_key is None
and stored_id.startswith(prefix)
and len(stored_id) > len(prefix)
):
# Saved before the tags existed: the id alone is ambiguous.
agent_key = stored_id[len(prefix):]
logger.warning(
"Session %r: untagged session %r %s as sub-agent %r history "
"(ambiguous id; %s).",
self.session_id, stored_id,
"restored" if allow_untagged else "ignored",
agent_key,
f"{LEGACY_AGENT_KEYS_ENV}=1" if allow_untagged
else f"set {LEGACY_AGENT_KEYS_ENV}=1 to restore it",
)
if not allow_untagged:
continue
else:
continue
try:
messages = session_store.get_chat_history(stored_id)
except Exception:
continue
if agent_key and messages:
histories[agent_key] = messages
self._legacy_histories_cache = (allow_untagged, histories)
return histories
def _restore_agent_chat_histories(self) -> None:
"""Restore all agent chat histories from memory."""
"""Restore all agent chat histories."""
if self.is_remote:
return
# G-2 FIX: read SessionStore first (where save_state now writes), then
# fall back to Memory for backward compatibility.
session_store = None
try:
from . import get_default_session_store
session_store = get_default_session_store()
except ImportError:
pass
session_store = self._get_session_store()
if session_store is not None and hasattr(session_store, "get_chat_history"):
prefix = f"{self.session_id}_"
list_sessions = getattr(session_store, "list_sessions", None)
if callable(list_sessions):
for entry in list_sessions():
if isinstance(entry, dict):
stored_id = entry.get("session_id")
# Prefer the explicit parent/agent_key tags written on
# save; this disambiguates overlapping composite ids
# (e.g. "chat"+"support_agent" vs "chat_support"+"agent").
tagged_parent = entry.get("parent_session_id")
tagged_key = entry.get("agent_key")
if tagged_parent == self.session_id and tagged_key:
agent_key = tagged_key
elif (
tagged_parent is None
and isinstance(stored_id, str)
and stored_id.startswith(prefix)
):
# Legacy sessions saved before the tag existed.
agent_key = stored_id[len(prefix):]
else:
continue
else:
stored_id = entry
if not (isinstance(stored_id, str) and stored_id.startswith(prefix)):
continue
agent_key = stored_id[len(prefix):]
messages = session_store.get_chat_history(stored_id)
if agent_key and messages:
self._agents[agent_key] = {
"agent": None,
"chat_history": messages
}
# Current-format records win; legacy (tagged / opted-in) ones fill the
# gaps so a partially-migrated parent still recovers every agent.
for agent_key, messages in self._merged_agent_histories(session_store).items():
self._agents[agent_key] = {"agent": None, "chat_history": messages}
results = self.memory.search_short_term(
query="Agent chat history for",
@@ -383,12 +485,50 @@ class Session:
"chat_history": chat_history
}
def _store_agent_history(
self, session_store, agent_key: str, messages: List[Dict[str, Any]]
) -> bool:
"""Persist one sub-agent transcript onto this session's own record.
The store replaces the whole ``AGENT_HISTORY_KEY`` map per write, so a
naive read-then-replace would let a concurrent writer (another agent
under the same parent) clobber this agent's entry, or vice versa. We
re-read the freshest map immediately before each write and confirm no
*other* key changed underneath us, retrying a bounded number of times.
Legacy per-agent records are always merged in (they stay on disk).
"""
update_meta = getattr(session_store, "update_session_metadata", None)
if not callable(update_meta):
return False
legacy = self._legacy_agent_histories(session_store)
for _ in range(5):
current = self._stored_agent_histories(session_store)
merged = dict(legacy)
merged.update(current)
merged[agent_key] = messages
if not update_meta(self.session_id, **{AGENT_HISTORY_KEY: merged}):
return False
# Verify a concurrent writer did not drop another agent between our
# read and write; if the persisted map matches what we wrote, we win.
persisted = self._stored_agent_histories(session_store)
if persisted.get(agent_key) == messages and all(
persisted.get(k) == v for k, v in current.items()
):
return True
logger.warning(
"Session %r: could not persist sub-agent history for %r after %d "
"attempts; the write was not verified.",
self.session_id, agent_key, 5,
)
return False
def _save_agent_chat_histories(self) -> None:
"""Save all agent chat histories.
G-2 FIX: Routes to SessionStore instead of Memory.store_short_term() to
maintain clean separation between conversation history (SessionStore)
and semantic memory (Memory). Falls back to Memory for backward compat.
Sub-agent transcripts go into the parent session's own record, under
``metadata[AGENT_HISTORY_KEY][agent_key]``. Nothing is written into the
global session-id namespace, so a sub-agent can no longer overwrite an
unrelated user session. Falls back to Memory for backward compat.
"""
if self.is_remote:
return
@@ -404,17 +544,10 @@ class Session:
chat_history = agent_data.get("chat_history")
if chat_history is not None:
# G-2 FIX: Try SessionStore first for clean separation
session_store = None
try:
from . import get_default_session_store
session_store = get_default_session_store()
except ImportError:
pass
session_store = self._get_session_store()
if session_store is not None:
# Replace atomically to avoid duplicate appends on repeated save_state()
session_id = f"{self.session_id}_{agent_key}"
messages = [
{
"role": msg.get("role", "user"),
@@ -424,32 +557,18 @@ class Session:
if isinstance(msg, dict)
]
if not messages:
logging.debug(f"No chat history to persist for session {session_id}")
elif hasattr(session_store, "set_chat_history"):
session_store.set_chat_history(session_id, messages)
# Tag the child session so bulk restore can resolve the
# exact agent_key without ambiguous composite-key prefix
# parsing (e.g. "chat" + "support_agent" vs "chat_support"
# + "agent" both collapse to "chat_support_agent").
update_meta = getattr(session_store, "update_session_metadata", None)
if callable(update_meta):
update_meta(
session_id,
parent_session_id=self.session_id,
agent_key=agent_key,
)
else:
# Fallback to add_message - may create duplicates on repeated calls
logging.debug(
f"No chat history to persist for agent {agent_key} "
f"in session {self.session_id}"
)
elif not self._store_agent_history(
session_store, agent_key, messages
):
logging.warning(
f"Session store lacks 'set_chat_history' method. Using fallback "
f"'add_message' which may create duplicates on repeated save_state() calls."
f"Session store {type(session_store).__name__} cannot "
f"persist sub-agent history; chat history for "
f"{agent_key} in session {self.session_id} was lost."
)
for msg in messages:
session_store.add_message(
session_id,
role=msg["role"],
content=msg["content"],
)
else:
# Fallback to Memory.store_short_term() for backward compatibility
history_text = f"Agent chat history for {agent_key}"
Loaded 100 of 471 files, more files were not shown because too many files have changed in this diff. Show more