Compare commits

...
Author SHA1 Message Date
praisonai-triage-agent[bot]andMervin Praison c19decfabf refactor: allow configurable client names for better monitoring
- Add client_name parameter to create_valkey_client function
- Use specific client names for each component:
  - ValkeyStateStore: praisonai_state_client
  - ValkeyVectorKnowledgeStore: praisonai_knowledge_client
  - ValkeyStorageAdapter: praisonai_storage_client
  - ValkeySearchBackend: praisonai_search_client
- Maintains backward compatibility with default fallback
- Addresses Gemini reviewer feedback for component distinction

Co-authored-by: Mervin Praison <[email protected]>
2026-05-27 17:11:07 +00:00
Anna Tao 003becc561 feat: add CLIENT SETNAME to Valkey client for connection identification
Sets client_name="praisonai_persistence_client" on GlideClientConfiguration
so connections are identifiable in CLIENT LIST, Valkey Admin, and CloudWatch.

Naming convention: {project}_{purpose}_client
- praisonai = project
- persistence = purpose (state, knowledge, and session storage)
- _client = convention (matches Valkey Admin pattern)
2026-05-27 09:55:36 -07:00
4 changed files with 8 additions and 0 deletions

No files matched your search

@@ -24,12 +24,15 @@ _MISSING_MSG = (
"Install with: pip install 'praisonai[valkey]'"
)
_CLIENT_NAME = "praisonai_persistence_client"
def create_valkey_client(
host: str = "localhost",
port: int = 6379,
password: Optional[str] = None,
db: int = 0,
client_name: str = _CLIENT_NAME,
):
"""Create and return a GlideClientSync instance."""
if GlideClientSync is None:
@@ -40,5 +43,6 @@ def create_valkey_client(
addresses=addresses,
credentials=creds,
database_id=db,
client_name=client_name,
)
return GlideClientSync.create(config)
@@ -73,6 +73,7 @@ class ValkeyVectorKnowledgeStore(KnowledgeStore):
host=self.host,
port=self.port,
password=self.password,
client_name="praisonai_knowledge_client",
)
return self._client
@@ -52,6 +52,7 @@ class ValkeyStateStore(StateStore):
port=self.port,
password=self.password,
db=self.db,
client_name="praisonai_state_client",
)
return self._client
@@ -80,6 +80,7 @@ class ValkeyStorageAdapter:
host=self.host,
port=self.port,
password=self.password,
client_name="praisonai_storage_client",
)
return self._client
@@ -260,6 +261,7 @@ class ValkeySearchBackend:
host=self.host,
port=self.port,
password=self.password,
client_name="praisonai_search_client",
)
return self._client