Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2183] [MERGED] Milvus bug fix #3911

New Issue
Closed
opened 2026-02-22 18:34:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2183
Author: @shatfield4
Created: 8/26/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @timothycarambat

Base: master ← Head: 2159-bug-crash-when-try-embed-a-document-using-milvus

📝 Commits (5)

  • 5d5824e patch no text results for milvus chunks
  • f245827 wrap addDocumentToNamespace in try catch for handling milvus errors
  • 6ea34a5 lint
  • 59abb08 revert milvus db changes
  • bd703ca add try catch to handle grpc error from milvus

📊 Changes

1 file changed (+29 additions, -21 deletions)

View changed files

📝 server/utils/vectorDbProviders/milvus/index.js (+29 -21)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #2159

What is in this change?

  • Wrap addDocumentToNamespace function in try catch to catch any errors from Milvus to prevent crashing of the backend server

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2183 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 8/26/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `2159-bug-crash-when-try-embed-a-document-using-milvus` --- ### 📝 Commits (5) - [`5d5824e`](https://github.com/Mintplex-Labs/anything-llm/commit/5d5824ed91c67bfd6a2c04d1d9f448b0cda1b996) patch no text results for milvus chunks - [`f245827`](https://github.com/Mintplex-Labs/anything-llm/commit/f245827799525249a1d75f0721dc10be3140f632) wrap addDocumentToNamespace in try catch for handling milvus errors - [`6ea34a5`](https://github.com/Mintplex-Labs/anything-llm/commit/6ea34a53f0b9a5383135f73f91d46c4c9843d027) lint - [`59abb08`](https://github.com/Mintplex-Labs/anything-llm/commit/59abb0855193c058d319dcea4102d4e8c15e413e) revert milvus db changes - [`bd703ca`](https://github.com/Mintplex-Labs/anything-llm/commit/bd703cabb1193ce35d48aaefcc654097ee0d4f74) add try catch to handle grpc error from milvus ### 📊 Changes **1 file changed** (+29 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/vectorDbProviders/milvus/index.js` (+29 -21) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #2159 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Wrap `addDocumentToNamespace` function in try catch to catch any errors from Milvus to prevent crashing of the backend server ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:45 -05:00
yindo closed this issue 2026-02-22 18:34:45 -05:00
yindo changed title from [PR #2183] Milvus bug fix to [PR #2183] [MERGED] Milvus bug fix 2026-06-05 15:15:52 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?