Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #2513] [MERGED] Fix tooling examples #4020

New Issue
Closed
opened 2026-02-22 18:34:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/2513
Author: @timothycarambat
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @timothycarambat

Base: master ← Head: fix-tooling-examples

📝 Commits (5)

  • cac2135 Fix incorrect json API description.
  • 260e46d Merge branch 'master' of github.com:Mintplex-Labs/anything-llm into fix-tooling-examples
  • f772f83 small edits and validity checks
  • 34ee01b remove console.logs
  • 3dc55a3 unset and recheck changes

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 server/utils/agents/aibitat/providers/helpers/untooled.js (+4 -1)

📄 Description

Original PR from @phazei

Pull Request Type

  • ✨ feat
  • [ x] 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

Resolves:

closes #2465
resolves #2432

What is in this change?

The example agent JSON query doesn't align with the description "All JSON responses should have two keys." "name" "arguments"

Previous agent example:

Query: "Save that to memory please."
JSON: {
    "action": "store",
    "content": "<insert summary of conversation until now>"
}

This PR fixes that:

Corrected agent example:

Query: "Save that to memory please."
JSON: {
  "name": "rag-memory",
  "arguments": {
    "action": "store",
    "content": "<insert summary of conversation until now>"
  }
}

Larger, smarter models can understand the inaccuracy in the description and correct for it, but smaller models follow the examples which are incorrect.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
    yarn lint doesn't work and looks for directories that don't exist.

  • [ x] Relevant documentation has been updated
    none needed

  • [ x] I have tested my code functionality
    ran it locally and looked at generations, also created a test script not included in this pr.

  • [ x] Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/2513 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `fix-tooling-examples` --- ### 📝 Commits (5) - [`cac2135`](https://github.com/Mintplex-Labs/anything-llm/commit/cac21356b41be16faf044093d4cf0588ebce57d2) Fix incorrect json API description. - [`260e46d`](https://github.com/Mintplex-Labs/anything-llm/commit/260e46d584557554abbf2ceadbaf4d462a3d6f11) Merge branch 'master' of github.com:Mintplex-Labs/anything-llm into fix-tooling-examples - [`f772f83`](https://github.com/Mintplex-Labs/anything-llm/commit/f772f83dea69b4f3871c3423cb6e2817772a0217) small edits and validity checks - [`34ee01b`](https://github.com/Mintplex-Labs/anything-llm/commit/34ee01b3d19f4125583a1958ae0379be65eed212) remove console.logs - [`3dc55a3`](https://github.com/Mintplex-Labs/anything-llm/commit/3dc55a32e7387af40cbbef1a5c9ed9d6d0f3b64f) unset and recheck changes ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/agents/aibitat/providers/helpers/untooled.js` (+4 -1) </details> ### 📄 Description Original PR from @phazei ### Pull Request Type - [ ] ✨ feat - [ x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues Resolves: closes #2465 resolves #2432 ### What is in this change? The example agent JSON query doesn't align with the description "All JSON responses should have two keys." "name" "arguments" Previous agent example: ``` Query: "Save that to memory please." JSON: { "action": "store", "content": "<insert summary of conversation until now>" } ``` This PR fixes that: Corrected agent example: ``` Query: "Save that to memory please." JSON: { "name": "rag-memory", "arguments": { "action": "store", "content": "<insert summary of conversation until now>" } } ``` Larger, smarter models can understand the inaccuracy in the description and correct for it, but smaller models follow the examples which are incorrect. ### Developer Validations <!-- All of the applicable items should be checked. --> - [ ] I ran `yarn lint` from the root of the repo & committed changes yarn lint doesn't work and looks for directories that don't exist. - [ x] Relevant documentation has been updated none needed - [ x] I have tested my code functionality ran it locally and looked at generations, also created a test script not included in this pr. - [ x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:58 -05:00
yindo closed this issue 2026-02-22 18:34:58 -05:00
yindo changed title from [PR #2513] Fix tooling examples to [PR #2513] [MERGED] Fix tooling examples 2026-06-05 15:16:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4020
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?