Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #4956] [MERGED] Fix agent workspace settings loading forever #4841

New Issue
Closed
opened 2026-02-22 18:36:38 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:36:38 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/4956
Author: @shatfield4
Created: 2/2/2026
Status: ✅ Merged
Merged: 2/2/2026
Merged by: @timothycarambat

Base: master ← Head: 4952-bug-agent-configuration-page-blank

📝 Commits (1)

  • 7da3246 remove .brief from SystemSettings.agent_sql_connections

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 server/endpoints/admin.js (+1 -2)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4949
resolves #4952
resolves #4954

What is in this change?

  • Resolves bug where admin endpoint was trying to call SystemSettings.brief.agent_sql_connections()
  • .brief was removed in #4848 so this no longer exists
  • This does expose SQL credentials to the frontend but we are protected by the admin and manager middlewares so the users that are allowed to see the credentials already had permission to see them inside the agent skills SQL tool

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/4956 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/2/2026 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `4952-bug-agent-configuration-page-blank` --- ### 📝 Commits (1) - [`7da3246`](https://github.com/Mintplex-Labs/anything-llm/commit/7da324687c9d589b95e87ed1520ab49c62e02e19) remove .brief from SystemSettings.agent_sql_connections ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/endpoints/admin.js` (+1 -2) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #4949 resolves #4952 resolves #4954 ### What is in this change? <!-- Describe the changes in this PR that are impactful to the repo. --> - Resolves bug where admin endpoint was trying to call `SystemSettings.brief.agent_sql_connections()` - `.brief` was removed in #4848 so this no longer exists - This does expose SQL credentials to the frontend but we are protected by the `admin` and `manager` middlewares so the users that are allowed to see the credentials already had permission to see them inside the agent skills SQL tool ### Additional Information <!-- Add any other context about the Pull Request here that was not captured above. --> ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:36:38 -05:00
yindo closed this issue 2026-02-22 18:36:38 -05:00
yindo changed title from [PR #4956] Fix agent workspace settings loading forever to [PR #4956] [MERGED] Fix agent workspace settings loading forever 2026-06-05 15:20:39 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#4841
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?