mirror of
https://github.com/OISF/suricata.git
synced 2026-10-12 02:07:10 +00:00
debug/validate: remove redundant checks
Pointed out by cppcheck.
This commit is contained in:
+1
-1
@@ -750,7 +750,7 @@ static int Setup(Flow *f, HtpState *hstate)
|
||||
|
||||
if (NULL == htp) {
|
||||
#ifdef DEBUG_VALIDATION
|
||||
BUG_ON(htp == NULL);
|
||||
BUG_ON(1);
|
||||
#endif
|
||||
/* should never happen if HTPConfigure is properly invoked */
|
||||
goto error;
|
||||
|
||||
+1
-3
@@ -95,9 +95,7 @@ TmEcode OutputFlowLog(ThreadVars *tv, void *thread_data, Flow *f)
|
||||
OutputFlowLogger *logger = list;
|
||||
OutputLoggerThreadStore *store = op_thread_data->store;
|
||||
|
||||
DEBUG_VALIDATE_BUG_ON(logger == NULL && store != NULL);
|
||||
DEBUG_VALIDATE_BUG_ON(logger != NULL && store == NULL);
|
||||
DEBUG_VALIDATE_BUG_ON(logger == NULL && store == NULL);
|
||||
DEBUG_VALIDATE_BUG_ON(store == NULL);
|
||||
|
||||
while (logger && store) {
|
||||
DEBUG_VALIDATE_BUG_ON(logger->LogFunc == NULL);
|
||||
|
||||
+1
-3
@@ -94,9 +94,7 @@ static TmEcode OutputPacketLog(ThreadVars *tv, Packet *p, void *thread_data)
|
||||
OutputPacketLogger *logger = list;
|
||||
OutputLoggerThreadStore *store = op_thread_data->store;
|
||||
|
||||
DEBUG_VALIDATE_BUG_ON(logger == NULL && store != NULL);
|
||||
DEBUG_VALIDATE_BUG_ON(logger != NULL && store == NULL);
|
||||
DEBUG_VALIDATE_BUG_ON(logger == NULL && store == NULL);
|
||||
DEBUG_VALIDATE_BUG_ON(store == NULL);
|
||||
|
||||
while (logger && store) {
|
||||
DEBUG_VALIDATE_BUG_ON(logger->LogFunc == NULL || logger->ConditionFunc == NULL);
|
||||
|
||||
Reference in New Issue
Block a user