Qt: Fix Winconsistent-missing-override warning.

we use snprintf now, so this isn't useful anymore.

pcsx2-qt/GameList/GameListWidget.h

@@ -92,7 +92,7 @@ public Q_SLOTS:
 	void refreshGridCovers();
 
 protected:
-	void resizeEvent(QResizeEvent* event);
+	void resizeEvent(QResizeEvent* event) override;
 	bool event(QEvent* event) override;
 
 private:

pcsx2/GS/Renderers/HW/GSTextureCache.cpp

@@ -1192,8 +1192,8 @@ GSTextureCache::Source* GSTextureCache::LookupDepthSource(const bool is_depth, c
 		if (inside_target)
 		{
 			// Need to set it up as a region target.
-			src->m_region.SetX(block_boundary_rect.x, src->m_from_target->m_valid.z);
-			src->m_region.SetY(block_boundary_rect.y, src->m_from_target->m_valid.w);
+			src->m_region.SetX(block_boundary_rect.x, std::max(src->m_from_target->m_valid.z, block_boundary_rect.z));
+			src->m_region.SetY(block_boundary_rect.y, std::max(src->m_from_target->m_valid.w, block_boundary_rect.w));
 		}
 
 		if (GSRendererHW::GetInstance()->IsTBPFrameOrZ(dst->m_TEX0.TBP0))
@@ -1800,10 +1800,6 @@ GSTextureCache::Source* GSTextureCache::LookupSource(const bool is_color, const
 							if (!t->HasValidBitsForFormat(psm, req_color, req_alpha, rt_tbw == TEX0.TBW) && !(possible_shuffle && GSLocalMemory::m_psm[psm].bpp == 16 && GSLocalMemory::m_psm[t->m_TEX0.PSM].bpp == 32))
 								continue;
 
-							// Be careful of shuffles where it can shuffle the width of the target, even though it may not have all been drawn to.
-							if (!possible_shuffle && frame.Block() != TEX0.TBP0 && !t->Inside(bp, bw, psm, block_boundary_rect))
-								continue;
-
 							x_offset = rect.x;
 							y_offset = rect.y;
 							dst = t;

pcsx2/IopBios.cpp

@@ -21,6 +21,7 @@
 #include <cstring>
 #include <fmt/format.h>
 #include <sys/stat.h>
+#include <algorithm>
 
 #include <fcntl.h>
 
@@ -928,12 +929,6 @@ namespace R3000A
 	{
 		int Kprintf_HLE()
 		{
-			// Using sprintf here is a bit nasty, but it has a large buffer..
-			// Don't feel like rewriting it.
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-#endif
 
 			// Emulate the expected Kprintf functionality:
 			iopMemWrite32(sp, a0);
@@ -956,7 +951,7 @@ namespace R3000A
 			char tmp[max_len], tmp2[max_len];
 			char* ptmp = tmp;
 			unsigned int printed_bytes = 0;
-			unsigned int remaining_buf = max_len - 1;
+			int remaining_buf = max_len - 1;
 			int n = 1, i = 0, j = 0;
 
 			while (fmt[i])
@@ -1000,7 +995,7 @@ namespace R3000A
 						{
 							case 'f':
 							case 'F':
-								printed_bytes = snprintf(ptmp, remaining_buf, tmp2, (float)iopMemRead32(sp + n * 4));
+								printed_bytes = std::min(remaining_buf, snprintf(ptmp, remaining_buf, tmp2, (float)iopMemRead32(sp + n * 4)));
 								remaining_buf -= printed_bytes;
 								ptmp += printed_bytes;
 								n++;
@@ -1012,7 +1007,7 @@ namespace R3000A
 							case 'E':
 							case 'g':
 							case 'G':
-								printed_bytes = snprintf(ptmp, remaining_buf, tmp2, (double)iopMemRead32(sp + n * 4));
+								printed_bytes = std::min(remaining_buf, snprintf(ptmp, remaining_buf, tmp2, (double)iopMemRead32(sp + n * 4)));
 								remaining_buf -= printed_bytes;
 								ptmp += printed_bytes;
 								n++;
@@ -1028,14 +1023,14 @@ namespace R3000A
 							case 'X':
 							case 'u':
 							case 'U':
-								printed_bytes = snprintf(ptmp, remaining_buf, tmp2, (u32)iopMemRead32(sp + n * 4));
+								printed_bytes = std::min(remaining_buf, snprintf(ptmp, remaining_buf, tmp2, (u32)iopMemRead32(sp + n * 4)));
 								remaining_buf -= printed_bytes;
 								ptmp += printed_bytes;
 								n++;
 								break;
 
 							case 'c':
-								printed_bytes = snprintf(ptmp, remaining_buf, tmp2, (u8)iopMemRead32(sp + n * 4));
+								printed_bytes = std::min(remaining_buf, snprintf(ptmp, remaining_buf, tmp2, (u8)iopMemRead32(sp + n * 4)));
 								remaining_buf -= printed_bytes;
 								ptmp += printed_bytes;
 								n++;
@@ -1044,7 +1039,7 @@ namespace R3000A
 							case 's':
 							{
 								std::string s = iopMemReadString(iopMemRead32(sp + n * 4));
-								printed_bytes = snprintf(ptmp, remaining_buf, tmp2, s.data());
+								printed_bytes = std::min(remaining_buf, snprintf(ptmp, remaining_buf, tmp2, s.data()));
 								remaining_buf -= printed_bytes;
 								ptmp += printed_bytes;
 								n++;
@@ -1070,10 +1065,6 @@ namespace R3000A
 			iopConLog(ShiftJIS_ConvertString(tmp, 1023));
 
 			return 1;
-
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
 		}
 	} // namespace sysmem