Compare commits

...

2 Commits

Author SHA1 Message Date
refractionpcsx2
0b6dccae51 GS/HW: Resize validity to draw size when most of target is covered 2025-06-21 05:52:50 +02:00
refractionpcsx2
60adfd5046 GS/TC: Fix region area on new source interpreted for shuffle 2025-06-21 05:52:50 +02:00
3 changed files with 34 additions and 7 deletions

View File

@@ -4179,6 +4179,10 @@ void GSRendererHW::Draw()
const int new_w = std::min(2048, std::max(new_size.x, std::max(rt ? rt->m_unscaled_size.x : 0, ds ? ds_size.x : 0)));
const int new_h = std::min(2048, std::max(new_size.y, std::max(rt ? rt->m_unscaled_size.y : 0, ds ? ds_size.y : 0)));
const bool full_cover_clear = is_possible_mem_clear && GSLocalMemory::IsPageAligned(m_cached_ctx.FRAME.PSM, m_r) && m_r.x == 0 && m_r.y == 0 && !preserve_rt_rgb &&
!IsPageCopy() && m_r.width() == (m_cached_ctx.FRAME.FBW * 64);
if (rt)
{
const u32 old_end_block = rt->m_end_block;
@@ -4225,9 +4229,9 @@ void GSRendererHW::Draw()
g_texture_cache->AddDirtyRectTarget(rt, GSVector4i(rt->m_valid.x, rt->m_valid.w, rt->m_valid.z, new_h), rt->m_TEX0.PSM, rt->m_TEX0.TBW, mask, false);
g_texture_cache->GetTargetSize(rt->m_TEX0.TBP0, rt->m_TEX0.TBW, rt->m_TEX0.PSM, 0, new_h);
}
rt->ResizeValidity(rt->m_valid.rintersect(rt->GetUnscaledRect()));
rt->ResizeDrawn(rt->m_drawn_since_read.rintersect(rt->GetUnscaledRect()));
const bool rt_cover = full_cover_clear && (m_r.height() + frame_psm.pgs.y) >= rt->m_valid.height();
rt->ResizeValidity(rt_cover ? update_rect : rt->m_valid.rintersect(rt->GetUnscaledRect()));
rt->ResizeDrawn(rt_cover ? update_rect : rt->m_drawn_since_read.rintersect(rt->GetUnscaledRect()));
}
const bool rt_update = can_update_size || (m_texture_shuffle && (src && rt && src->m_from_target != rt));
@@ -4235,7 +4239,7 @@ void GSRendererHW::Draw()
// If it's updating from a texture shuffle, limit the size to the source size.
if (rt_update && !can_update_size)
{
if(src->m_from_target)
if (src->m_from_target)
update_rect = update_rect.rintersect(src->m_from_target->m_valid);
update_rect = update_rect.rintersect(GSVector4i::loadh(GSVector2i(new_w, new_h)));
@@ -4305,16 +4309,18 @@ void GSRendererHW::Draw()
DevCon.Warning("HW: Temporary depth buffer creation failed.");
}
}
const bool z_masked = m_cached_ctx.ZBUF.ZMSK;
if (!m_texture_shuffle && !m_channel_shuffle)
{
ds->ResizeValidity(ds->GetUnscaledRect());
ds->ResizeDrawn(ds->GetUnscaledRect());
const bool z_cover = full_cover_clear && (m_r.height() + GSLocalMemory::m_psm[m_cached_ctx.ZBUF.PSM].pgs.y) >= ds->m_valid.height();
ds->ResizeValidity(z_cover ? m_r : ds->GetUnscaledRect());
ds->ResizeDrawn(z_cover ? m_r : ds->GetUnscaledRect());
}
// Limit to 2x the vertical height of the resolution (for double buffering)
// Dark cloud writes to 424 when the buffer is only 416 high, but masks the Z.
// Updating the valid causes the Z to overlap the framebuffer, which is obviously incorrect.
const bool z_masked = m_cached_ctx.ZBUF.ZMSK;
const bool z_update = can_update_size && !z_masked;
if (rt && m_using_temp_z)

View File

@@ -2041,11 +2041,29 @@ GSTextureCache::Source* GSTextureCache::LookupSource(const bool is_color, const
{
rect.y /= 2;
rect.w /= 2;
if (region.HasY())
{
const u32 min_y = region.GetMinY() / 2;
const u32 max_y = region.GetMaxY() / 2;
region.ClearY();
region.SetY(min_y, max_y);
}
}
else
{
rect.x /= 2;
rect.z /= 2;
if (region.HasX())
{
const u32 min_x = region.GetMinX() / 2;
const u32 max_x = region.GetMaxX() / 2;
region.ClearX();
region.SetX(min_x, max_x);
}
}
if (TEX0.TBP0 == frame.Block())
{

View File

@@ -45,6 +45,9 @@ public:
bool HasY() const { return static_cast<u32>(bits >> 32) != 0; }
bool HasEither() const { return (bits != 0); }
void ClearX() { bits &= ~0xFFFFFFFFULL; }
void ClearY() { bits &= 0xFFFFFFFFULL; }
void SetX(s32 min, s32 max) { bits |= (static_cast<u64>(static_cast<u16>(min)) | (static_cast<u64>(static_cast<u16>(max) << 16))); }
void SetY(s32 min, s32 max) { bits |= ((static_cast<u64>(static_cast<u16>(min)) << 32) | (static_cast<u64>(static_cast<u16>(max)) << 48)); }