Compare commits

...

3 Commits

Author SHA1 Message Date
JordanTheToaster
7e18c02c7e GameDB: Xenosaga Episode III fixes 2025-06-23 06:27:13 +02:00
twingofan
4a505cc239 GameDB: Add memcardFilters to Armored Core: Last Raven NTSC-U SLUS-21338. (#12891) 2025-06-23 06:26:16 +02:00
Kuan-Wei Chiu
35c81106c6 Fix invalid comparator in FullscreenUI game list sort
The game list comparator previously used >= when sorting by CRC in
descending order. This violates the requirements of a strict weak
ordering, as defined by the C++ standard, which mandates that the
comparator must be irreflexive: comp(x, x) must always return false.

Using >= causes comp(a, b) and comp(b, a) to both return true when
a == b, which breaks the irreflexivity and can invalidate the
assumptions made by std::sort. This may lead to undefined behavior,
including memory corruption or segmentation faults.

Replace >= with > to ensure the comparator satisfies the strict weak
ordering requirement, restoring correctness and stability in game list
sorting behavior.
2025-06-22 14:44:34 -04:00
2 changed files with 13 additions and 1 deletions

View File

@@ -2409,6 +2409,7 @@ SCAJ-20179:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
SCAJ-20180:
name: "Xenosaga Episode III - Also Sprach Zarathustra [Disc 2 of 2]"
region: "NTSC-Unk"
@@ -2416,6 +2417,7 @@ SCAJ-20180:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
SCAJ-20181:
name: "Minna no Tennis"
region: "NTSC-Unk"
@@ -35734,6 +35736,7 @@ SLPM-61147:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
SLPM-61148:
name: "グローランサーⅤ ジェネレーションズ [体験版]"
name-sort: "ぐろーらんさー5 じぇねれーしょんず [たいけんばん]"
@@ -59562,6 +59565,7 @@ SLPS-25640:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
memcardFilters: # Allows import of Xenosaga II save data.
- "SLPS-25640"
- "SLPS-25368"
@@ -59575,6 +59579,7 @@ SLPS-25641:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
memcardFilters:
- "SLPS-25640"
- "SLPS-25368"
@@ -69974,6 +69979,11 @@ SLUS-21338:
halfPixelOffset: 2 # Corrects shadow alignment and reduces blurriness.
recommendedBlendingLevel: 3 # Fixes level and map menu brightness.
preloadFrameData: 1 # Fixes glowing emblems.
memcardFilters: # Convert savegames from AC: Nexus and AC: Nine Breaker.
- "SLUS-21338"
- "SLUS-21200"
- "SLUS-20986"
- "SLUS-21079"
SLUS-21339:
name: "Puzzle Challenge - Crosswords and More!"
region: "NTSC-U"
@@ -70356,6 +70366,7 @@ SLUS-21389:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
memcardFilters: # Allows import of Xenosaga II save data.
- "SLUS-21389"
- "SLUS-20892"
@@ -70525,6 +70536,7 @@ SLUS-21417:
autoFlush: 1 # Fixes shadows.
halfPixelOffset: 4 # Fixes lighting misalignment.
nativeScaling: 2 # Fixes lighting smoothness.
textureInsideRT: 1 # Fixes broken crystalline surface textures.
memcardFilters:
- "SLUS-21389"
- "SLUS-20892"

View File

@@ -6285,7 +6285,7 @@ void FullscreenUI::PopulateGameListEntryList()
case 4: // CRC
{
if (lhs->crc != rhs->crc)
return reverse ? (lhs->crc >= rhs->crc) : (lhs->crc < rhs->crc);
return reverse ? (lhs->crc > rhs->crc) : (lhs->crc < rhs->crc);
}
break;