RPCS3/archived-rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-01-31 01:25:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

vk: Invalidate renderpass key in post-cyclic-z barrier

Browse Source 
- Post-Z renderpass split is crucial due to loss of writes. The failure to invalidate the renderpass key was an oversight.
This commit is contained in:
kd-11
2026-01-25 19:26:42 +03:00
committed by Ani
parent 9dfaca4cd8
commit 29cb4f59bd
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
rpcs3/Emu/RSX/VK/VKDraw.cpp
View File

@@ -143,6 +143,17 @@ VkRenderPass VKGSRender::get_render_pass()
return m_cached_renderpass;
}
void VKGSRender::invalidate_render_pass()
{
// Regenerate renderpass key for the next draw call
if (const auto key = vk::get_renderpass_key(m_fbo_images, m_current_renderpass_key);
key != m_current_renderpass_key)
{
m_current_renderpass_key = key;
m_cached_renderpass = VK_NULL_HANDLE;
}
}
void VKGSRender::update_draw_state()
{
m_profiler.start();
@@ -514,12 +525,7 @@ void VKGSRender::load_texture_env()
if (check_for_cyclic_refs)
{
// Regenerate renderpass key
if (const auto key = vk::get_renderpass_key(m_fbo_images, m_current_renderpass_key);
key != m_current_renderpass_key)
{
m_current_renderpass_key = key;
m_cached_renderpass = VK_NULL_HANDLE;
}
invalidate_render_pass();
}
if (backend_config.supports_asynchronous_compute)
@@ -1069,6 +1075,9 @@ void VKGSRender::end()
// Since we're ending the subpass, might as well restore DCC/HiZ for extra performance
ds->change_layout(*m_current_command_buffer, VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
ds->reset_surface_counters();
// Regenerate render pass key
invalidate_render_pass();
}
}

1
rpcs3/Emu/RSX/VK/VKGSRender.h
View File

@@ -227,6 +227,7 @@ private:
void begin_render_pass();
void close_render_pass();
VkRenderPass get_render_pass();
void invalidate_render_pass();
void update_draw_state();
void check_present_status();