Commit Graph

3661 Commits

Author SHA1 Message Date
Malcolm Bechard
4b2483ee88
Fix #2005. Allow multiple compilation units to declare identical push_constant blocks (#2123)
* Fixes #2005

Allow multiple units in a stage to have push_constants as long
as the blocks match.
Requires #2006 to be fixed to be functional.

* tweaks to #2005 fix after some testing

* add unit tests for push constants across multiple compilation units

For #2005

* update reference output for tests that fail validation

* fix uninitialized result.validationResult
2020-03-16 08:51:15 -06:00
Chow
9b620aa0c1
Add flag to check whether offset is implicit or explicit (#2031)
When we use unsized array in shader storage buffer, glslang calculate the offset during delcaring the block, it may lead to incorrect block offsets when its implicit array size changed.

So here is what we do:
1. For GLSL, we add flag explicitOffset in TQualifier, and set it when layout offset is specified explicitly
2. By using this flag we could tell difference as whether it is an explicit offset, and recalculate the block member offset conditionally in OpenGL.
2020-03-11 03:59:25 -06:00
Ryan Harrison
56a7e02056
Use strcmp for all of the extended instruction set checks in the disassembler (#2107)
Fixes #2106

* Convert memcmps to strcmps
2020-03-11 01:00:13 -06:00
John Kessenich
e2176c91b2
Merge pull request #2110 from jeffbolznv/escapeseq
EXT_debug_printf - make escape sequences better match C/C++
2020-03-10 23:55:48 -06:00
Jeff Bolz
ad3f10bbd0 EXT_debug_printf - make escape sequences better match C/C++ 2020-03-10 10:23:07 -05:00
John Kessenich
dbb56a1d48
Merge pull request #2105 from jeffbolznv/nonunif
Allow nonuniformEXT() on sampler types
2020-03-10 03:50:27 -06:00
John Kessenich
343d4f6f18
Merge pull request #2109 from jeffbolznv/disable_escape
disable escape sequences for #line and #error
2020-03-09 22:53:51 -06:00
Jeff Bolz
13444545a9 disable escape sequences for #line and #error 2020-03-09 21:09:18 -05:00
Jeff Bolz
b57af2f5ad Decorate accesschain operand for nonuniform UBO loads
This is conservative and still also decorates the loaded value.
2020-03-09 14:09:41 -05:00
Jeff Bolz
39ffdaf2ab Allow nonuniformEXT() on sampler types.
Also add missing NonUniformEXT decoration on OpImageTexelPointer.
2020-03-09 10:48:12 -05:00
John Kessenich
f333272eb5
Merge pull request #2103 from kainino0x/web-cmake-typo
Fix typo in Web CMakeLists
2020-03-09 02:03:02 -06:00
John Kessenich
3b5eaf7941
Merge pull request #2102 from sfricke-samsung/sfricke-samsung-android-build
Add Android build instructions to README
2020-03-09 01:54:39 -06:00
John Kessenich
6861ea4e10
Merge pull request #2101 from travisfoo/master
add c wrapper for standalone ResourceLimits and remove that dependency from glslang_c_interface
2020-03-09 01:53:41 -06:00
Kai Ninomiya
851f3daad0 Fix typo in Web CMakeLists 2020-03-06 19:13:16 -08:00
Travis Fort
0b71a071e2 add missing string.h header for resource_limits_c.cpp 2020-03-06 10:31:14 -05:00
Travis Fort
fd37e0c0f1 add c wrapper for standalone ResourceLimits and remove that dependency from glslang_c_interface 2020-03-06 10:06:47 -05:00
John Kessenich
aa95c80e1a
Merge pull request #2100 from travisfoo/master
Fix for #2099: add c interface support for TBuiltInResource and glslang::DefaultTBuiltInResource
2020-03-06 00:14:41 -07:00
John Kessenich
6f230b9e0b
Merge pull request #2098 from jeffbolznv/debugprintf
GL_EXT_debug_printf implementation
2020-03-06 00:12:27 -07:00
Travis Fort
48556b8471 add stdbool.h to properly support bool type 2020-03-05 20:49:49 -05:00
Travis Fort
bdcfc48466 add c interface support for TBuiltInResource and glslang::DefaultTBuiltInResource 2020-03-05 16:05:07 -05:00
Jeff Bolz
04d73731de GL_EXT_debug_printf implementation 2020-03-05 13:41:34 -06:00
Spencer Fricke
442f561ad5 Add Android build instructions to README 2020-03-04 15:33:59 -08:00
John Kessenich
c6a4c6d3d8
Improve formatting. 2020-03-04 00:15:20 -07:00
John Kessenich
c40c4bc38a
Add "news" section and component status.
Includes an additional deprecation and rationalizing the beginning sections.
2020-03-04 00:07:50 -07:00
John Kessenich
8985fc9108 Fix long lines in the SPIR-V generator, retrigger bots. 2020-03-03 10:25:07 -07:00
John Kessenich
bbbd9a2a1f Fix #1843: Handle built-in function output parameters to a swizzled arg
In GLSL/HLSL/AST,  v.zyx is an l-value, but not in SPIR-V, which cannot represent it.
So, a temporary is used instead.
2020-03-03 07:21:37 -07:00
John Kessenich
56364b6b60 Copyright update, mostly to trigger bots again. 2020-03-01 04:51:40 -07:00
John Kessenich
c480237be2 Fix #2095: correct the indentation.
This also made it obvious some code was (functionally correctly)
repeated, so deleted that too.
2020-03-01 02:16:51 -07:00
John Kessenich
9606a5cb99 Fix #1461: set the SPIRV-Tools' optimizer's target environment. 2020-02-28 07:10:59 -07:00
John Kessenich
82da15f4f0 Fix #2091, remove incorrect assert for division by 0.0. 2020-02-28 04:10:13 -07:00
John Kessenich
70ba66cdbc
Merge pull request #2093 from LilyWangL/vcpkg-instructions
Add vcpkg installation instructions
2020-02-28 01:01:47 -07:00
John Kessenich
f13d38f3cd
Merge pull request #2092 from corporateshark/master
Fix for #2075: removed DefaultTBuiltInResource from glslang_c_interface.cpp
2020-02-28 00:26:33 -07:00
wangli28
717264316a Add vcpkg installation instructions 2020-02-28 06:41:58 +00:00
Sergey Kosarevsky
a7ff36e6bd Fix for #2075: removed DefaultTBuiltInResource from glslang_c_interface.cpp 2020-02-28 02:18:37 +03:00
John Kessenich
07e1a0a67a
Merge pull request #2090 from amdrexu/bugfix
Fix an issue of SPV generation for imageAtomicStore.
2020-02-22 07:52:12 -07:00
Rex Xu
fb18b6df28 Fix an issue of SPV generation for imageAtomicStore.
For GLSL function imageAtomicStore, it will be translated to
OpImageTexelPointer + OpAtomicStore. The result type of
OpImageTexelPointer must be the same as the sampled type of OpTypeImage.
On translation, the result type is mistakenly fetched from operand list
operands[2] while operands[2] corresponds to sampleNum whose type is
always uint. This leads to an error if the image type is iimageXXX that is
int image.
2020-02-22 22:04:31 +08:00
John Kessenich
c12493ff69
Merge pull request #2086 from samuelig/SPV_AMD_shader_image_load_store_lod
SPV_AMD_shader_image_load_store_lod is now validated by spirv-tools
2020-02-19 23:25:39 -07:00
Samuel Iglesias Gonsálvez
a515fff401 SPV_AMD_shader_image_load_store_lod is now validated by spirv-tools 2020-02-20 06:57:49 +01:00
John Kessenich
c008fcb8cc
Merge pull request #2089 from Roy-AMD/Fix-iomapper-issue
Fix iomapper issue
2020-02-19 03:51:38 -07:00
Roy.li
615ae25891 Fix iomapper issue
Use type name to index map to instead of use instance name to index map, or anonymous block will cause a map issue.
2020-02-19 16:38:02 +08:00
John Kessenich
ed0da37dd9
Merge pull request #2087 from KhronosGroup/fix-2070-implicit-conv-single-arg
HLSL: Fix part of #2070: Correctly handle promotion for <unary-op>(int).
2020-02-18 07:27:50 -07:00
John Kessenich
abfc4c2ceb Fix part of #2070: Correctly handle promotion for <unary-op>(int).
This still only handles a scalar correctly, and some
vector cases need additional fixes.
2020-02-18 06:53:39 -07:00
John Kessenich
113d07a6eb
Merge pull request #2084 from durswd/enable_rtti
Add an option to make RTTI enabled
2020-02-17 19:27:46 -07:00
durswd
b848387262 Add an option to make RTTI enabled 2020-02-18 02:37:09 +09:00
John Kessenich
ae59435606
Merge pull request #2081 from kainino0x/split-emscripten-from-glslang.js
CMake: Split "is emscripten" config from "enable glslang.js"
2020-02-07 06:10:29 -07:00
Kai Ninomiya
5166bc1859 Split "is emscripten" config from "enable glslang.js"
This should enable glslang to be used as a dependency of other projects
that target WebAssembly, instead of assuming "EMSCRIPTEN" => "Want
glslang.js".
2020-02-06 14:06:20 -08:00
John Kessenich
95c414ffee
Merge pull request #2079 from dneto0/warnings
Avoid enum-compare warning, missing cases in switch
2020-02-06 09:12:50 -07:00
David Neto
4bb910cb74 Avoid enum-compare warning 2020-02-06 05:43:43 -05:00
John Kessenich
2d70e98dea
Merge pull request #2028 from ShchchowAMD/constant_expressions_array_mod
GLSL: Support constant folding for mod
2020-02-06 02:56:37 -07:00
John Kessenich
656650f461
Merge pull request #2078 from amdrexu/bugfix
GLSL: Fix semantic error for GL_KHR_memory_scope_semantics
2020-02-06 02:20:47 -07:00