libusb_submit_transfer: Don't reference the device on submission failure

If submission fails libusb_ref_device will never get balanced by an unref
on completion, since there will be no completion.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Hans de Goede
2014-05-30 12:25:18 +02:00
parent 4f347f01fa
commit 6edd96ab81
2 changed files with 4 additions and 4 deletions
+3 -3
View File
@@ -1456,10 +1456,10 @@ int API_EXPORTED libusb_submit_transfer(struct libusb_transfer *transfer)
if (r != LIBUSB_SUCCESS) {
list_del(&itransfer->list);
arm_timerfd_for_next_timeout(ctx);
} else {
/* keep a reference to this device */
libusb_ref_device(transfer->dev_handle->dev);
}
/* keep a reference to this device */
libusb_ref_device(transfer->dev_handle->dev);
out:
updated_fds = (itransfer->flags & USBI_TRANSFER_UPDATED_FDS);
usbi_mutex_unlock(&itransfer->lock);
+1 -1
View File
@@ -1 +1 @@
#define LIBUSB_NANO 10899
#define LIBUSB_NANO 10900