RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-10 14:36:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

PathV2: Fix a possible infinite loop.

Browse Source 
- The code could infinite loop trying to create unique files, if the directory
   containing the unique file exists, but open() calls on non-existent files in
   the path return ENOENT. This is true on the /dev/fd filesystem, for example.

 - Will add a clang side test case for this.

llvm-svn: 168081
This commit is contained in:
Daniel Dunbar 2012-11-15 20:24:52 +00:00
parent daffcbaf3b
commit 078f28c96d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Support/Unix/PathV2.inc
View File

@ -424,9 +424,10 @@ rety_open_create:
// If the file existed, try again, otherwise, error.
if (errno == errc::file_exists)
goto retry_random_path;
// The path prefix doesn't exist.
if (errno == errc::no_such_file_or_directory) {
StringRef p(RandomPath.begin(), RandomPath.size());
// If path prefix doesn't exist, try to create it.
if (errno == errc::no_such_file_or_directory &&
!exists(path::parent_path(RandomPath))) {
StringRef p(RandomPath);
SmallString<64> dir_to_create;
for (path::const_iterator i = path::begin(p),
e = --path::end(p); i != e; ++i) {