RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-16 18:30:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use all_of instead of a raw loop; NFC

Browse Source 
Added some tests despite being NFC, since it looks like nothing was
exercising the "all incoming values to exit PHIs are same" logic.

llvm-svn: 268407
This commit is contained in:
Sanjoy Das 2016-05-03 17:50:06 +00:00
parent b469accc72
commit 0a6bbc1c79
2 changed files with 60 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Transforms/Scalar/LoopDeletion.cpp
View File

@ -86,12 +86,10 @@ bool LoopDeletion::isLoopDead(Loop *L, ScalarEvolution &SE,
// block. If there are different incoming values for different exiting
// blocks, then it is impossible to statically determine which value should
// be used.
for (unsigned i = 1, e = exitingBlocks.size(); i < e; ++i) {
if (incoming != P->getIncomingValueForBlock(exitingBlocks[i])) {
AllOutgoingValuesSame = false;
break;
}
}
AllOutgoingValuesSame =
all_of(makeArrayRef(exitingBlocks).slice(1), [&](BasicBlock *BB) {
return incoming == P->getIncomingValueForBlock(BB);
});
if (!AllOutgoingValuesSame)
break;

58
test/Transforms/LoopDeletion/multiple-exits.ll
View File

@ -2,13 +2,13 @@
; Checks whether dead loops with multiple exits can be eliminated
define void @foo(i64 %n, i64 %m) nounwind {
; CHECK-LABEL: @foo(
; CHECK: entry:
; CHECK-NEXT: br label %return
; CHECK: return:
; CHECK-NEXT: ret void
define void @foo(i64 %n, i64 %m) nounwind {
entry:
br label %bb
@ -24,3 +24,57 @@ bb2:
return:
ret void
}
define i64 @bar(i64 %n, i64 %m) nounwind {
; CHECK-LABEL: @bar(
; CHECK: entry:
; CHECK-NEXT: br label %return
; CHECK: return:
; CHECK-NEXT: ret i64 10
entry:
br label %bb
bb:
%x.0 = phi i64 [ 0, %entry ], [ %t0, %bb3 ]
%t0 = add i64 %x.0, 1
%t1 = icmp slt i64 %x.0, %n
br i1 %t1, label %bb2, label %return
bb2:
%t2 = icmp slt i64 %x.0, %m
br i1 %t2, label %bb3, label %return
bb3:
%t3 = icmp slt i64 %x.0, %m
br i1 %t3, label %bb, label %return
return:
%x.lcssa = phi i64 [ 10, %bb ], [ 10, %bb2 ], [ 10, %bb3 ]
ret i64 %x.lcssa
}
define i64 @baz(i64 %n, i64 %m) nounwind {
; CHECK-LABEL: @baz(
; CHECK: return:
; CHECK-NEXT: %x.lcssa = phi i64 [ 12, %bb ], [ 10, %bb2 ]
; CHECK-NEXT: ret i64 %x.lcssa
entry:
br label %bb
bb:
%x.0 = phi i64 [ 0, %entry ], [ %t0, %bb3 ]
%t0 = add i64 %x.0, 1
%t1 = icmp slt i64 %x.0, %n
br i1 %t1, label %bb2, label %return
bb2:
%t2 = icmp slt i64 %x.0, %m
br i1 %t2, label %bb3, label %return
bb3:
%t3 = icmp slt i64 %x.0, %m
br i1 %t3, label %bb, label %return
return:
%x.lcssa = phi i64 [ 12, %bb ], [ 10, %bb2 ], [ 10, %bb3 ]
ret i64 %x.lcssa
}