CrashRecovery: Make CrashRecoveryContext static methods thread safe.

llvm-svn: 111307
This commit is contained in:
Daniel Dunbar 2010-08-17 22:32:34 +00:00
parent 535ca58e85
commit 0fc35d7284
2 changed files with 12 additions and 4 deletions

View File

@ -47,12 +47,10 @@ public:
CrashRecoveryContext() : Impl(0) {}
~CrashRecoveryContext();
/// \brief Enable crash recovery. This function is not thread safe, clients
/// should call it during startup or with a lock held.
/// \brief Enable crash recovery.
static void Enable();
/// \brief Disable crash recovery. This function is not thread safe, clients
/// should call it during startup or with a lock held.
/// \brief Disable crash recovery.
static void Disable();
/// \brief Execute the provide callback function (with the given arguments) in

View File

@ -10,6 +10,7 @@
#include "llvm/Support/CrashRecoveryContext.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/Config/config.h"
#include "llvm/System/Mutex.h"
#include "llvm/System/ThreadLocal.h"
#include <setjmp.h>
#include <cstdio>
@ -47,6 +48,7 @@ public:
}
static sys::Mutex gCrashRecoveryContexMutex;
static bool gCrashRecoveryEnabled = false;
CrashRecoveryContext::~CrashRecoveryContext() {
@ -59,6 +61,8 @@ CrashRecoveryContext::~CrashRecoveryContext() {
// FIXME: No real Win32 implementation currently.
void CrashRecoveryContext::Enable() {
sys::ScopedLock L(gCrashRecoveryContexMutex);
if (gCrashRecoveryEnabled)
return;
@ -66,6 +70,8 @@ void CrashRecoveryContext::Enable() {
}
void CrashRecoveryContext::Disable() {
sys::ScopedLock L(gCrashRecoveryContexMutex);
if (!gCrashRecoveryEnabled)
return;
@ -121,6 +127,8 @@ static void CrashRecoverySignalHandler(int Signal) {
}
void CrashRecoveryContext::Enable() {
sys::ScopedLock L(gCrashRecoveryContexMutex);
if (gCrashRecoveryEnabled)
return;
@ -138,6 +146,8 @@ void CrashRecoveryContext::Enable() {
}
void CrashRecoveryContext::Disable() {
sys::ScopedLock L(gCrashRecoveryContexMutex);
if (!gCrashRecoveryEnabled)
return;