RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-13 22:58:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

llvm-mc: Improve handling of implicit alignment for magic section directives

Browse Source 
(e.g., .objc_message_refs).
 - Just emit a .align when we see the directive; this isn't exactly what 'as'
   does but in practice it should be ok, at least for now. See FIXME.

llvm-svn: 79697
This commit is contained in:
Daniel Dunbar 2009-08-21 23:30:15 +00:00
parent 63ce9dc3a8
commit 15dbbf3644
2 changed files with 21 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
test/MC/MachO/sections.s
View File

@ -121,8 +121,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x3)
@ -135,8 +134,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 3)
// CHECK: ('alignment', 3)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x4)
@ -149,8 +147,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 4)
// CHECK: ('alignment', 4)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0xe)
@ -241,8 +238,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x6)
@ -255,8 +251,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x7)
@ -282,8 +277,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x9)
@ -296,8 +290,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0xa)
@ -427,8 +420,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x10000005)
@ -441,8 +433,7 @@
// CHECK: ('address', 0)
// CHECK: ('size', 0)
// CHECK: ('offset', 2464)
// FIXME: We aren't setting alignment correctly yet.
// CHECX: ('alignment', 2)
// CHECK: ('alignment', 2)
// CHECK: ('reloc_offset', 0)
// CHECK: ('num_reloc', 0)
// CHECK: ('flags', 0x10000005)

13
tools/llvm-mc/AsmParser.cpp
View File

@ -794,13 +794,24 @@ bool AsmParser::ParseDirectiveSectionSwitch(const char *Segment,
// FIXME: Arch specific.
// FIXME: Cache this!
// FIXME: Handle the implicit alignment!!
MCSection *S = 0; // Ctx.GetSection(Section);
if (S == 0)
S = MCSectionMachO::Create(Segment, Section, TAA, StubSize,
SectionKind(), Ctx);
Out.SwitchSection(S);
// Set the implicit alignment, if any.
//
// FIXME: This isn't really what 'as' does; I think it just uses the implicit
// alignment on the section (e.g., if one manually inserts bytes into the
// section, then just issueing the section switch directive will not realign
// the section. However, this is arguably more reasonable behavior, and there
// is no good reason for someone to intentionally emit incorrectly sized
// values into the implicitly aligned sections.
if (Align)
Out.EmitValueToAlignment(Align, 0, 1, 0);
return false;
}