RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-07 03:40:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix http://llvm.org/bugs/show_bug.cgi?id=10568

Browse Source 
Move the reloc size assert into AsmBackend - where it is more apropos.

llvm-svn: 136855
This commit is contained in:
Jason W Kim 2011-08-04 00:38:45 +00:00
parent 60e17f8212
commit 18ca6290c9
3 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/MC/ELFObjectWriter.cpp
View File

@ -1698,7 +1698,6 @@ unsigned X86ELFObjectWriter::GetRelocType(const MCValue &Target,
default: llvm_unreachable("invalid fixup kind!");
case FK_Data_8: Type = ELF::R_X86_64_64; break;
case X86::reloc_signed_4byte:
assert(isInt<32>(Target.getConstant()));
switch (Modifier) {
default:
llvm_unreachable("Unimplemented");

17
lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
View File

@ -93,6 +93,23 @@ public:
assert(Fixup.getOffset() + Size <= DataSize &&
"Invalid fixup offset!");
// Check that the upper bits are either all 0 or all 1's
switch (Size) {
case 1:
assert((isInt<8>(Value) || isUInt<8>(Value)) &&
"Value does not fit in a 1Byte Reloc");
break;
case 2:
assert((isInt<16>(Value) || isUInt<16>(Value)) &&
"Value does not fit in a 2Byte Reloc");
break;
case 4:
assert((isInt<32>(Value) || isUInt<32>(Value)) &&
"Value does not fit in a 4Byte Reloc");
break;
}
for (unsigned i = 0; i != Size; ++i)
Data[Fixup.getOffset() + i] = uint8_t(Value >> (i * 8));
}

13
test/MC/ELF/x86_64-reloc-sizetest.s Normal file
View File

@ -0,0 +1,13 @@
// RUN: llvm-mc -triple x86_64-linux-gnu -filetype=obj %s | elf-dump | FileCheck %s
// Tests that relocation value fits in the provided size
// Original bug http://llvm.org/bugs/show_bug.cgi?id=10568
L: movq $(L + 2147483648),%rax
// CHECK: Relocation 0x00000000
// CHECK-NEXT: 'r_offset', 0x00000003
// CHECK-NEXT: 'r_sym'
// CHECK-NEXT: 'r_type', 0x0000000b
// CHECK-NEXT: 'r_addend', 0x80000000