[ConstantRange] Add unsignedMulMayOverflow()

Same as the other ConstantRange overflow checking methods, but for
unsigned mul. In this case there is no cheap overflow criterion, so
using umul_ov for the implementation.

Differential Revision: https://reviews.llvm.org/D60574

llvm-svn: 358228
This commit is contained in:
Nikita Popov 2019-04-11 21:10:33 +00:00
parent d18f384bc5
commit 1da36cb589
3 changed files with 35 additions and 0 deletions

View File

@ -399,6 +399,9 @@ public:
/// Return whether signed sub of the two ranges always/never overflows.
OverflowResult signedSubMayOverflow(const ConstantRange &Other) const;
/// Return whether unsigned mul of the two ranges always/never overflows.
OverflowResult unsignedMulMayOverflow(const ConstantRange &Other) const;
/// Print out the bounds to a stream.
void print(raw_ostream &OS) const;

View File

@ -1252,6 +1252,26 @@ ConstantRange::OverflowResult ConstantRange::signedSubMayOverflow(
return OverflowResult::NeverOverflows;
}
ConstantRange::OverflowResult ConstantRange::unsignedMulMayOverflow(
const ConstantRange &Other) const {
if (isEmptySet() || Other.isEmptySet())
return OverflowResult::MayOverflow;
APInt Min = getUnsignedMin(), Max = getUnsignedMax();
APInt OtherMin = Other.getUnsignedMin(), OtherMax = Other.getUnsignedMax();
bool Overflow;
(void) Min.umul_ov(OtherMin, Overflow);
if (Overflow)
return OverflowResult::AlwaysOverflows;
(void) Max.umul_ov(OtherMax, Overflow);
if (Overflow)
return OverflowResult::MayOverflow;
return OverflowResult::NeverOverflows;
}
void ConstantRange::print(raw_ostream &OS) const {
if (isFullSet())
OS << "full-set";

View File

@ -1578,6 +1578,18 @@ TEST_F(ConstantRangeTest, UnsignedSubOverflowExhaustive) {
});
}
TEST_F(ConstantRangeTest, UnsignedMulOverflowExhaustive) {
TestOverflowExhaustive(
[](const APInt &N1, const APInt &N2) {
bool Overflow;
(void) N1.umul_ov(N2, Overflow);
return Overflow;
},
[](const ConstantRange &CR1, const ConstantRange &CR2) {
return CR1.unsignedMulMayOverflow(CR2);
});
}
TEST_F(ConstantRangeTest, SignedAddOverflowExhaustive) {
TestOverflowExhaustive(
[](const APInt &N1, const APInt &N2) {