RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-03 10:54:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[asan] don't instrument globals that we've created ourselves (reduces the binary size a bit)

Browse Source 
llvm-svn: 167230
This commit is contained in:
Kostya Serebryany 2012-11-01 13:42:40 +00:00
parent dac0de603a
commit 2bae7f204a
2 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Transforms/Instrumentation/AddressSanitizer.cpp
View File

@ -215,6 +215,7 @@ struct AddressSanitizer : public FunctionPass {
Function *AsanErrorCallback[2][kNumberOfAccessSizes];
InlineAsm *EmptyAsm;
SmallSet<GlobalValue*, 32> DynamicallyInitializedGlobals;
SmallSet<GlobalValue*, 32> GlobalsCreatedByAsan;
};
} // namespace
@ -508,6 +509,7 @@ bool AddressSanitizer::ShouldInstrumentGlobal(GlobalVariable *G) {
if (BL->isIn(*G)) return false;
if (!Ty->isSized()) return false;
if (!G->hasInitializer()) return false;
if (GlobalsCreatedByAsan.count(G)) return false; // Our own global.
// Touch only those globals that will not be defined in other modules.
// Don't handle ODR type linkages since other modules may be built w/o asan.
if (G->getLinkage() != GlobalVariable::ExternalLinkage &&
@ -1090,9 +1092,10 @@ bool AddressSanitizer::poisonStackInFunction(Function &F) {
Value *BasePlus1 = IRB.CreateAdd(LocalStackBase,
ConstantInt::get(IntptrTy, LongSize/8));
BasePlus1 = IRB.CreateIntToPtr(BasePlus1, IntptrPtrTy);
Value *Description = IRB.CreatePointerCast(
createPrivateGlobalForString(*F.getParent(), StackDescription.str()),
IntptrTy);
GlobalVariable *StackDescriptionGlobal =
createPrivateGlobalForString(*F.getParent(), StackDescription.str());
GlobalsCreatedByAsan.insert(StackDescriptionGlobal);
Value *Description = IRB.CreatePointerCast(StackDescriptionGlobal, IntptrTy);
IRB.CreateStore(Description, BasePlus1);
// Poison the stack redzones at the entry.

19
test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll Normal file
View File

@ -0,0 +1,19 @@
; This test checks that we are not instrumenting globals
; that we created ourselves.
; RUN: opt < %s -asan -S | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define void @_Z3barv() uwtable address_safety {
entry:
%a = alloca i32, align 4
call void @_Z3fooPi(i32* %a)
ret void
}
declare void @_Z3fooPi(i32*)
; We create one global string constant for the stack frame above.
; Make sure we don't create any other global constants.
; CHECK: = private constant
; CHECK-NOT: = private constant