RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-04 17:56:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add an optimization to support the most common access pattern for the

Browse Source 
library.  This speeds debug builds up significantly.

llvm-svn: 3826
This commit is contained in:
Chris Lattner 2002-09-19 19:22:11 +00:00
parent d47c947c82
commit 39614ed129
2 changed files with 44 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/Support/LeakDetector.cpp
View File

@ -12,6 +12,13 @@
static std::set<const void*> *Objects = 0;
static std::set<const Value*> *LLVMObjects = 0;
// Because the most common usage pattern, by far, is to add a garbage object,
// then remove it immediately, we optimize this case. When an object is added,
// it is not added to the set immediately, it is added to the CachedValue Value.
// If it is immediately removed, no set search need be performed.
//
static const Value *CachedValue;
void LeakDetector::addGarbageObjectImpl(void *Object) {
if (Objects == 0)
Objects = new std::set<const void*>();
@ -25,18 +32,28 @@ void LeakDetector::removeGarbageObjectImpl(void *Object) {
}
void LeakDetector::addGarbageObjectImpl(const Value *Object) {
if (LLVMObjects == 0)
LLVMObjects = new std::set<const Value*>();
assert(LLVMObjects->count(Object) == 0 && "Object already in set!");
LLVMObjects->insert(Object);
if (CachedValue) {
if (LLVMObjects == 0)
LLVMObjects = new std::set<const Value*>();
assert(LLVMObjects->count(CachedValue) == 0 && "Object already in set!");
LLVMObjects->insert(CachedValue);
}
CachedValue = Object;
}
void LeakDetector::removeGarbageObjectImpl(const Value *Object) {
if (LLVMObjects)
if (Object == CachedValue)
CachedValue = 0; // Cache hit!
else if (LLVMObjects)
LLVMObjects->erase(Object);
}
void LeakDetector::checkForGarbageImpl(const std::string &Message) {
if (CachedValue) // Flush the cache to the set...
addGarbageObjectImpl((Value*)0);
assert(CachedValue == 0 && "No value should be cached anymore!");
if ((Objects && !Objects->empty()) || (LLVMObjects && !LLVMObjects->empty())){
std::cerr << "Leaked objects found: " << Message << "\n";

27
support/lib/Support/LeakDetector.cpp
View File

@ -12,6 +12,13 @@
static std::set<const void*> *Objects = 0;
static std::set<const Value*> *LLVMObjects = 0;
// Because the most common usage pattern, by far, is to add a garbage object,
// then remove it immediately, we optimize this case. When an object is added,
// it is not added to the set immediately, it is added to the CachedValue Value.
// If it is immediately removed, no set search need be performed.
//
static const Value *CachedValue;
void LeakDetector::addGarbageObjectImpl(void *Object) {
if (Objects == 0)
Objects = new std::set<const void*>();
@ -25,18 +32,28 @@ void LeakDetector::removeGarbageObjectImpl(void *Object) {
}
void LeakDetector::addGarbageObjectImpl(const Value *Object) {
if (LLVMObjects == 0)
LLVMObjects = new std::set<const Value*>();
assert(LLVMObjects->count(Object) == 0 && "Object already in set!");
LLVMObjects->insert(Object);
if (CachedValue) {
if (LLVMObjects == 0)
LLVMObjects = new std::set<const Value*>();
assert(LLVMObjects->count(CachedValue) == 0 && "Object already in set!");
LLVMObjects->insert(CachedValue);
}
CachedValue = Object;
}
void LeakDetector::removeGarbageObjectImpl(const Value *Object) {
if (LLVMObjects)
if (Object == CachedValue)
CachedValue = 0; // Cache hit!
else if (LLVMObjects)
LLVMObjects->erase(Object);
}
void LeakDetector::checkForGarbageImpl(const std::string &Message) {
if (CachedValue) // Flush the cache to the set...
addGarbageObjectImpl((Value*)0);
assert(CachedValue == 0 && "No value should be cached anymore!");
if ((Objects && !Objects->empty()) || (LLVMObjects && !LLVMObjects->empty())){
std::cerr << "Leaked objects found: " << Message << "\n";