RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-13 23:20:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

When we legalize target nodes, do not use getNode to create a new node,

Browse Source 
use UpdateNodeOperands to just update the operands!  This is important because
getNode will allocate a new node if the node returns a flag and this breaks
assumptions in the legalizer that you can legalize some things multiple times
and get exactly the same results.

This latent bug was exposed by my ppc patch last night, and this fixes
gsm/toast.

llvm-svn: 28348
This commit is contained in:
Chris Lattner 2006-05-17 18:00:08 +00:00
parent d3ff015877
commit 4252704561
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
View File

@ -529,19 +529,10 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) {
// If this is a target node, legalize it by legalizing the operands then
// passing it through.
std::vector<SDOperand> Ops;
bool Changed = false;
for (unsigned i = 0, e = Node->getNumOperands(); i != e; ++i) {
for (unsigned i = 0, e = Node->getNumOperands(); i != e; ++i)
Ops.push_back(LegalizeOp(Node->getOperand(i)));
Changed = Changed || Node->getOperand(i) != Ops.back();
}
if (Changed)
if (Node->getNumValues() == 1)
Result = DAG.getNode(Node->getOpcode(), Node->getValueType(0), Ops);
else {
std::vector<MVT::ValueType> VTs(Node->value_begin(),
Node->value_end());
Result = DAG.getNode(Node->getOpcode(), VTs, Ops);
}
Result = DAG.UpdateNodeOperands(Result.getValue(0), Ops);
for (unsigned i = 0, e = Node->getNumValues(); i != e; ++i)
AddLegalizedOperand(Op.getValue(i), Result.getValue(i));
@ -1058,7 +1049,7 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) {
// Merge in the last call, to ensure that this call start after the last
// call ended.
if (LastCALLSEQ_END.getOpcode() != ISD::EntryNode) {
if (LastCALLSEQ_END.getOpcode() != ISD::EntryToken) {
Tmp1 = DAG.getNode(ISD::TokenFactor, MVT::Other, Tmp1, LastCALLSEQ_END);
Tmp1 = LegalizeOp(Tmp1);
}