RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-09 22:04:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

CGP: Clear data structures at the end of a loop iteration instead of the beginning.

Browse Source 
Clearing LargeOffsetGEPMap at the end fixes a bug where if a large
offset GEP is in a dead basic block, we fail an assertion when trying
to delete the block due to the asserting VH in LargeOffsetGEPMap.

Differential Revision: https://reviews.llvm.org/D53464

llvm-svn: 345082
This commit is contained in:
Peter Collingbourne 2018-10-23 21:23:18 +00:00
parent 49ffee130a
commit 43f785d798
2 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/CodeGen/CodeGenPrepare.cpp
View File

@ -436,11 +436,6 @@ bool CodeGenPrepare::runOnFunction(Function &F) {
bool MadeChange = true;
while (MadeChange) {
MadeChange = false;
SeenChainsForSExt.clear();
ValToSExtendedUses.clear();
RemovedInsts.clear();
LargeOffsetGEPMap.clear();
LargeOffsetGEPID.clear();
for (Function::iterator I = F.begin(); I != F.end(); ) {
BasicBlock *BB = &*I++;
bool ModifiedDTOnIteration = false;
@ -460,6 +455,11 @@ bool CodeGenPrepare::runOnFunction(Function &F) {
I->deleteValue();
EverMadeChange |= MadeChange;
SeenChainsForSExt.clear();
ValToSExtendedUses.clear();
RemovedInsts.clear();
LargeOffsetGEPMap.clear();
LargeOffsetGEPID.clear();
}
SunkAddrs.clear();

22
test/CodeGen/Thumb2/unreachable-large-offset-gep.ll Normal file
View File

@ -0,0 +1,22 @@
; RUN: llc -o - %s | FileCheck %s
; CHECK: .LBB0_1:
; CHECK: b .LBB0_1
target triple = "thumbv8m-unknown-linux-android"
define void @d(i32* %c) {
entry:
br i1 false, label %f.exit, label %i.d
i.d:
br label %i.d
f.exit:
%0 = getelementptr i32, i32* %c, i32 57
br label %if.g
if.g:
store i32 0, i32* %0
ret void
}