RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-22 19:49:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove wasteful caching. This isn't needed for correctness because any function

Browse Source 
that might have changed been affected by a merge elsewhere will have been
removed from the function set, and it isn't needed for performance because we
call grow() ahead of time to prevent reallocations.

llvm-svn: 124717
This commit is contained in:
Nick Lewycky 2011-02-02 05:31:01 +00:00
parent 11acb5002d
commit 4f38aaec24
1 changed files with 2 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/Transforms/IPO/MergeFunctions.cpp
View File

@ -112,23 +112,10 @@ public:
Func = NULL;
}
bool &getOrInsertCachedComparison(const ComparableFunction &Other,
bool &inserted) const {
typedef DenseMap<Function *, bool>::iterator iterator;
std::pair<iterator, bool> p =
CompareResultCache.insert(std::make_pair(Other.getFunc(), false));
inserted = p.second;
return p.first->second;
}
private:
explicit ComparableFunction(unsigned Hash)
: Func(NULL), Hash(Hash), TD(NULL) {}
// DenseMap::grow() triggers a recomparison of all keys in the map, which is
// wildly expensive. This cache tries to preserve known results.
mutable DenseMap<Function *, bool> CompareResultCache;
AssertingVH<Function> Func;
unsigned Hash;
TargetData *TD;
@ -675,16 +662,8 @@ bool DenseMapInfo<ComparableFunction>::isEqual(const ComparableFunction &LHS,
assert(LHS.getTD() == RHS.getTD() &&
"Comparing functions for different targets");
bool inserted;
bool &result1 = LHS.getOrInsertCachedComparison(RHS, inserted);
if (!inserted)
return result1;
bool &result2 = RHS.getOrInsertCachedComparison(LHS, inserted);
if (!inserted)
return result1 = result2;
return result1 = result2 = FunctionComparator(LHS.getTD(), LHS.getFunc(),
RHS.getFunc()).compare();
return FunctionComparator(LHS.getTD(), LHS.getFunc(),
RHS.getFunc()).compare();
}
// Replace direct callers of Old with New.