Somehow this important part of the patch, where I actually check the Mask,

got lost during my iterations of review.

Thanks to Hal for spotting it!

llvm-svn: 190604
This commit is contained in:
Joey Gouly 2013-09-12 14:23:19 +00:00
parent 51105ec453
commit 533d4eae52
2 changed files with 7 additions and 4 deletions

View File

@ -169,7 +169,7 @@ public:
std::string &Info) const {
if (ComplexDeprecationInfo)
return ComplexDeprecationInfo(MI, STI, Info);
if (DeprecatedFeatureMask != 0) {
if ((DeprecatedFeatureMask & STI.getFeatureBits()) != 0) {
// FIXME: it would be nice to include the subtarget feature here.
Info = "deprecated";
return true;

View File

@ -1,5 +1,8 @@
@ RUN: llvm-mc -triple armv8 -show-encoding < %s 2>&1 | FileCheck %s
@ RUN: llvm-mc -triple armv8 -show-encoding < %s 2>&1 | FileCheck %s --check-prefix=CHECK-V8
@ RUN: llvm-mc -triple armv7 -show-encoding < %s 2>&1 | FileCheck %s --check-prefix=CHECK-V7
setend be
@ CHECK: warning: deprecated
@ CHECK-V8: warning: deprecated
@ CHECK-V7-NOT: warning: deprecated
mcr p8, #0, r5, c7, c5, #4
@ CHECK: warning: deprecated on armv8
@ CHECK-V8: warning: deprecated on armv8
@ CHECK-V7-NOT: warning: deprecated on armv8