RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-04 03:06:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Limit size of non-GlobalValue name

Browse Source 
Otherwise, in some extreme test case, very long names are created and the
compiler consumes large amount of memory. Size limit is set to a relatively
high value not to disturb debugging.

Compiler flag -non-global-value-max-name-size=<value> can be used to customize
the size.

Differential Revision: https://reviews.llvm.org/D41296

llvm-svn: 321886
This commit is contained in:
Serge Guelton 2018-01-05 19:41:19 +00:00
parent 374396ccbc
commit 567d46dc34
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/IR/Value.cpp
View File

@ -39,6 +39,10 @@
using namespace llvm;
static cl::opt<unsigned> NonGlobalValueMaxNameSize(
"non-global-value-max-name-size", cl::Hidden, cl::init(1024),
cl::desc("Maximum size for the name of non-global values."));
//===----------------------------------------------------------------------===//
// Value Class
//===----------------------------------------------------------------------===//
@ -244,6 +248,11 @@ void Value::setNameImpl(const Twine &NewName) {
if (getName() == NameRef)
return;
// Cap the size of non-GlobalValue names.
if (NameRef.size() > NonGlobalValueMaxNameSize && !isa<GlobalValue>(this))
NameRef =
NameRef.substr(0, std::max(1u, (unsigned)NonGlobalValueMaxNameSize));
assert(!getType()->isVoidTy() && "Cannot assign a name to void values!");
// Get the symbol table to update for this object.

18
test/Bitcode/value-with-long-name.ll Normal file
View File

@ -0,0 +1,18 @@
; Check the size of generated variable when no option is set
; RUN: opt -S %s -O2 -o - | FileCheck -check-prefix=CHECK-LONG %s
; CHECK-LONG: %{{[a-z]{4}[a-z]+}}
; Then check we correctly cap the size of newly generated non-global values name
; Force the size to be small so that the check works on release and debug build
; RUN: opt -S %s -O2 -o - -non-global-value-max-name-size=0 | FileCheck -check-prefix=CHECK-SHORT %s
; RUN: opt -S %s -O2 -o - -non-global-value-max-name-size=1 | FileCheck -check-prefix=CHECK-SHORT %s
; CHECK-SHORT-NOT: %{{[a-z][a-z]+}}
define i32 @f(i32 %a, i32 %b) {
%c = add i32 %a, %b
%d = add i32 %c, %a
%e = add i32 %d, %b
ret i32 %e
}