RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-27 15:02:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

WebAssembly: remove 'external' from test

Browse Source 
Summary: Linker testing was sad at seeing an unresolved external symbol. For now don't do that: it's valid but we're not playing with multi-file linking yet, and the LLVM tests are used as hacky sanity tests for single-file linking (the GCC torture tests are much better for this purpose). Another solution would be to use '.extern' to make the intent explicit (don't simple-file link this, there's an unresolved symbol), some assemblers use '.extern' while others ignore it, so we wouldn't really be inventing anything new.

Reviewers: sunfish, kripken

Subscribers: jfb, llvm-commits, dschuff

Differential Revision: http://reviews.llvm.org/D15753

llvm-svn: 256353
This commit is contained in:
JF Bastien 2015-12-23 23:56:13 +00:00
parent 0d007cd82b
commit 5c96fb5825
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/CodeGen/WebAssembly/offset-folding.ll
View File

@ -5,7 +5,10 @@
target datalayout = "e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"
@x = external global [0 x i32]
; FIXME: make this 'external' and make sure it still works. WebAssembly
; currently only supports linking single files, so 'external' makes
; little sense.
@x = global [0 x i32] zeroinitializer
@y = global [50 x i32] zeroinitializer
; Test basic constant offsets of both defined and external symbols.