make TLOF subclassify BSS based on linkage type into private, external

and everything else (weak).

llvm-svn: 93846
This commit is contained in:
Chris Lattner 2010-01-19 04:15:51 +00:00
parent eeebf5a580
commit 63ef960b83
2 changed files with 20 additions and 3 deletions

View File

@ -88,6 +88,13 @@ class SectionKind {
/// BSS - Zero initialized writeable data.
BSS,
/// BSSLocal - This is BSS (zero initialized and writable) data
/// which has local linkage.
BSSLocal,
/// BSSExtern - This is BSS data with normal external linkage.
BSSExtern,
/// Common - Data with common linkage. These represent tentative
/// definitions, which always have a zero initializer and are never
/// marked 'constant'.
@ -166,7 +173,10 @@ public:
return isBSS() || isCommon() || isDataRel() || isReadOnlyWithRel();
}
bool isBSS() const { return K == BSS; }
bool isBSS() const { return K == BSS || K == BSSLocal || K == BSSExtern; }
bool isBSSLocal() const { return K == BSSLocal; }
bool isBSSExtern() const { return K == BSSExtern; }
bool isCommon() const { return K == Common; }
bool isDataRel() const {
@ -213,6 +223,8 @@ public:
static SectionKind getThreadBSS() { return get(ThreadBSS); }
static SectionKind getThreadData() { return get(ThreadData); }
static SectionKind getBSS() { return get(BSS); }
static SectionKind getBSSLocal() { return get(BSSLocal); }
static SectionKind getBSSExtern() { return get(BSSExtern); }
static SectionKind getCommon() { return get(Common); }
static SectionKind getDataRel() { return get(DataRel); }
static SectionKind getDataRelLocal() { return get(DataRelLocal); }

View File

@ -146,8 +146,13 @@ SectionKind TargetLoweringObjectFile::getKindForGlobal(const GlobalValue *GV,
return SectionKind::getCommon();
// Variable can be easily put to BSS section.
if (isSuitableForBSS(GVar))
if (isSuitableForBSS(GVar)) {
if (GVar->hasLocalLinkage())
return SectionKind::getBSSLocal();
else if (GVar->hasExternalLinkage())
return SectionKind::getBSSExtern();
return SectionKind::getBSS();
}
Constant *C = GVar->getInitializer();
@ -926,7 +931,7 @@ SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind,
// Put zero initialized globals with strong external linkage in the
// DATA, __common section with the .zerofill directive.
if (Kind.isBSS() && GV->hasExternalLinkage())
if (Kind.isBSSExtern())
return DataCommonSection;
// Otherwise, just drop the variable in the normal data section.