RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-20 10:38:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rationalize what is public in RuntimeDyldMachO and RuntimeDyldELF.

Browse Source 
The implemented RuntimeDyldImpl interface is public. Everything else is private.
Since these classes are not inherited from (yet), there is no need to have
protected members.

llvm-svn: 180733
This commit is contained in:
Rafael Espindola 2013-04-29 22:06:33 +00:00
parent d0c38e0586
commit 7d9df9376a
2 changed files with 18 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h
View File

@ -37,7 +37,6 @@ class RuntimeDyldELF : public RuntimeDyldImpl {
uint32_t Type, uint32_t Type,
int64_t Addend); int64_t Addend);
protected:
void resolveX86_64Relocation(const SectionEntry &Section, void resolveX86_64Relocation(const SectionEntry &Section,
uint64_t Offset, uint64_t Offset,
uint64_t Value, uint64_t Value,
@ -68,18 +67,9 @@ protected:
uint32_t Type, uint32_t Type,
int64_t Addend); int64_t Addend);
virtual void resolveRelocation(const RelocationEntry &RE, uint64_t Value);
virtual void processRelocationRef(unsigned SectionID,
RelocationRef RelI,
ObjectImage &Obj,
ObjSectionToIDMap &ObjSectionToID,
const SymbolTableMap &Symbols,
StubMap &Stubs);
unsigned getCommonSymbolAlignment(const SymbolRef &Sym); unsigned getCommonSymbolAlignment(const SymbolRef &Sym);
virtual ObjectImage *createObjectImage(ObjectBuffer *InputBuffer);
uint64_t findPPC64TOC() const; uint64_t findPPC64TOC() const;
void findOPDEntrySection(ObjectImage &Obj, void findOPDEntrySection(ObjectImage &Obj,
@ -87,12 +77,18 @@ protected:
RelocationValueRef &Rel); RelocationValueRef &Rel);
public: public:
RuntimeDyldELF(RTDyldMemoryManager *mm) RuntimeDyldELF(RTDyldMemoryManager *mm) : RuntimeDyldImpl(mm) {}
: RuntimeDyldImpl(mm) {}
virtual void resolveRelocation(const RelocationEntry &RE, uint64_t Value);
virtual void processRelocationRef(unsigned SectionID,
RelocationRef RelI,
ObjectImage &Obj,
ObjSectionToIDMap &ObjSectionToID,
const SymbolTableMap &Symbols,
StubMap &Stubs);
virtual bool isCompatibleFormat(const ObjectBuffer *Buffer) const;
virtual ObjectImage *createObjectImage(ObjectBuffer *InputBuffer);
virtual ~RuntimeDyldELF(); virtual ~RuntimeDyldELF();
bool isCompatibleFormat(const ObjectBuffer *Buffer) const;
}; };
} // end namespace llvm } // end namespace llvm

19
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h
View File

@ -25,7 +25,6 @@ using namespace llvm::object;
namespace llvm { namespace llvm {
class RuntimeDyldMachO : public RuntimeDyldImpl { class RuntimeDyldMachO : public RuntimeDyldImpl {
protected:
bool resolveI386Relocation(uint8_t *LocalAddress, bool resolveI386Relocation(uint8_t *LocalAddress,
uint64_t FinalAddress, uint64_t FinalAddress,
uint64_t Value, uint64_t Value,
@ -48,13 +47,6 @@ protected:
unsigned Size, unsigned Size,
int64_t Addend); int64_t Addend);
virtual void processRelocationRef(unsigned SectionID,
RelocationRef RelI,
ObjectImage &Obj,
ObjSectionToIDMap &ObjSectionToID,
const SymbolTableMap &Symbols,
StubMap &Stubs);
void resolveRelocation(const SectionEntry &Section, void resolveRelocation(const SectionEntry &Section,
uint64_t Offset, uint64_t Offset,
uint64_t Value, uint64_t Value,
@ -63,11 +55,16 @@ protected:
bool isPCRel, bool isPCRel,
unsigned Size); unsigned Size);
public: public:
virtual void resolveRelocation(const RelocationEntry &RE, uint64_t Value);
RuntimeDyldMachO(RTDyldMemoryManager *mm) : RuntimeDyldImpl(mm) {} RuntimeDyldMachO(RTDyldMemoryManager *mm) : RuntimeDyldImpl(mm) {}
bool isCompatibleFormat(const ObjectBuffer *Buffer) const; virtual void resolveRelocation(const RelocationEntry &RE, uint64_t Value);
virtual void processRelocationRef(unsigned SectionID,
RelocationRef RelI,
ObjectImage &Obj,
ObjSectionToIDMap &ObjSectionToID,
const SymbolTableMap &Symbols,
StubMap &Stubs);
virtual bool isCompatibleFormat(const ObjectBuffer *Buffer) const;
}; };
} // end namespace llvm } // end namespace llvm