RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-06 03:08:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Pull out a named variable for the cached section names to aid readability.

Browse Source 
Based on a code review suggestion from Eric Christopher in r205990

llvm-svn: 206080
This commit is contained in:
David Blaikie 2014-04-11 22:49:14 +00:00
parent e84c6abeec
commit 7e2966c6c0
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/MC/MCContext.cpp
View File

@ -241,7 +241,8 @@ void MCContext::renameELFSection(const MCSectionELF *Section, StringRef Name) {
auto I =
ELFUniquingMap.insert(std::make_pair(SectionGroupPair(Name, GroupName),
Section)).first;
const_cast<MCSectionELF*>(Section)->setSectionName(I->first.first);
StringRef CachedName = I->first.first;
const_cast<MCSectionELF*>(Section)->setSectionName(CachedName);
}
const MCSectionELF *MCContext::
@ -262,8 +263,9 @@ getELFSection(StringRef Section, unsigned Type, unsigned Flags,
if (!Group.empty())
GroupSym = GetOrCreateSymbol(Group);
MCSectionELF *Result = new (*this) MCSectionELF(
Entry.first.first, Type, Flags, Kind, EntrySize, GroupSym);
StringRef CachedName = Entry.first.first;
MCSectionELF *Result = new (*this)
MCSectionELF(CachedName, Type, Flags, Kind, EntrySize, GroupSym);
Entry.second = Result;
return Result;
}
@ -291,9 +293,9 @@ MCContext::getCOFFSection(StringRef Section, unsigned Characteristics,
if (!COMDATSymName.empty())
COMDATSymbol = GetOrCreateSymbol(COMDATSymName);
MCSectionCOFF *Result =
new (*this) MCSectionCOFF(Iter->first.first, Characteristics,
COMDATSymbol, Selection, Assoc, Kind);
StringRef CachedName = Iter->first.first;
MCSectionCOFF *Result = new (*this) MCSectionCOFF(
CachedName, Characteristics, COMDATSymbol, Selection, Assoc, Kind);
Iter->second = Result;
return Result;